On Sun, Aug 5, 2012 at 10:20 AM, Ronald S. Bultje wrote:
> Plus, I didn't say it was a good idea, I said I could live with it if
> others want it. Right now, it seems others (i.e. Loren) don't.
FYI, it makes my life harder. Also I agree with Loren.
___
On Sun, Aug 5, 2012 at 7:36 PM, Mans Rullgard wrote:
> For some reason, nasm requires this. No harm done to yasm.
>
> Signed-off-by: Mans Rullgard
> ---
> libavutil/x86/x86inc.asm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Has this been synced with x264?
__
There's no way for the encoder to know whether the input is CFR, so
assume VFR.
---
libavcodec/libx264.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c
index adda881..72fd390 100644
--- a/libavcodec/libx264.c
+++ b/libavcodec
---
libavresample/x86/audio_convert.asm| 74
libavresample/x86/audio_convert_init.c | 13 ++
2 files changed, 87 insertions(+), 0 deletions(-)
diff --git a/libavresample/x86/audio_convert.asm
b/libavresample/x86/audio_convert.asm
index 2908cbf..c666da
---
libavresample/x86/audio_convert.asm| 46
libavresample/x86/audio_convert_init.c |9 ++
2 files changed, 55 insertions(+), 0 deletions(-)
diff --git a/libavresample/x86/audio_convert.asm
b/libavresample/x86/audio_convert.asm
index 0329a79..2908cb
---
libavresample/x86/audio_convert.asm| 39
libavresample/x86/audio_convert_init.c | 13 ++
2 files changed, 52 insertions(+), 0 deletions(-)
diff --git a/libavresample/x86/audio_convert.asm
b/libavresample/x86/audio_convert.asm
index 09c4e7f..ea
---
libavresample/x86/audio_convert.asm| 83
libavresample/x86/audio_convert_init.c | 17 +++
libavutil/x86/x86util.asm | 12 +
3 files changed, 112 insertions(+), 0 deletions(-)
diff --git a/libavresample/x86/audio_convert.asm
b/li
---
libavresample/x86/audio_convert.asm| 61
libavresample/x86/audio_convert_init.c | 13 +++
2 files changed, 74 insertions(+), 0 deletions(-)
diff --git a/libavresample/x86/audio_convert.asm
b/libavresample/x86/audio_convert.asm
index db141e2..09c4e
---
libavresample/x86/audio_convert.asm| 50
libavresample/x86/audio_convert_init.c | 15 +
libavresample/x86/util.asm |6
3 files changed, 71 insertions(+), 0 deletions(-)
diff --git a/libavresample/x86/audio_convert.asm
b/li
---
libavresample/x86/audio_convert.asm| 114
libavresample/x86/audio_convert_init.c | 15
2 files changed, 129 insertions(+), 0 deletions(-)
diff --git a/libavresample/x86/audio_convert.asm
b/libavresample/x86/audio_convert.asm
index 15aaa6a..8240a32
---
libavresample/x86/audio_convert.asm| 37
libavresample/x86/audio_convert_init.c |7 ++
2 files changed, 44 insertions(+), 0 deletions(-)
diff --git a/libavresample/x86/audio_convert.asm
b/libavresample/x86/audio_convert.asm
index 8240a32..ead4a5
---
libavresample/x86/audio_convert.asm| 106
libavresample/x86/audio_convert_init.c | 15 +
2 files changed, 121 insertions(+), 0 deletions(-)
diff --git a/libavresample/x86/audio_convert.asm
b/libavresample/x86/audio_convert.asm
index c3cc76f..622a84
---
libavresample/x86/audio_convert.asm| 43
libavresample/x86/audio_convert_init.c |9 ++
2 files changed, 52 insertions(+), 0 deletions(-)
diff --git a/libavresample/x86/audio_convert.asm
b/libavresample/x86/audio_convert.asm
index 622a84c..15aaa6
---
libavresample/x86/audio_convert.asm| 123
libavresample/x86/audio_convert_init.c | 14
2 files changed, 137 insertions(+), 0 deletions(-)
diff --git a/libavresample/x86/audio_convert.asm
b/libavresample/x86/audio_convert.asm
index 4a92952..ee05efc
---
libavresample/x86/audio_convert.asm| 49
libavresample/x86/audio_convert_init.c |9 ++
2 files changed, 58 insertions(+), 0 deletions(-)
diff --git a/libavresample/x86/audio_convert.asm
b/libavresample/x86/audio_convert.asm
index ee05efc..c3cc76
---
libavresample/x86/audio_convert.asm| 37
libavresample/x86/audio_convert_init.c | 13 +++
2 files changed, 50 insertions(+), 0 deletions(-)
diff --git a/libavresample/x86/audio_convert.asm
b/libavresample/x86/audio_convert.asm
index 244c4d1..4
New round of patches for libavresample x86 asm conversions.
Justin Ruggles (15):
lavr: x86: optimized 2-channel s16p to s16 conversion
lavr: x86: optimized 6-channel s16p to s16 conversion
lavr: x86: optimized 2-channel s16p to flt conversion
lavr: x86: optimized 6-channel s16p to flt conv
It appears that something goes wrong in old nasm versions when the
%+ operator is used in the last argument of a macro invocation and
this argument is tested with %ifdef within the macro. Adding a
dummy argument somehow fixes this.
---
libavutil/x86/x86inc.asm | 9 ++---
1 file changed, 6 ins
This is required with oldish nasm versions still shipped with some
systems. Without this patch, the code still builds but due to
a bug[1] crashes at runtime even if avx is not used.
[1]
http://repo.or.cz/w/nasm.git/commitdiff/3cb0e8c052a672424eaf59a021f0dbfb6ef205b8
Signed-off-by: Mans Rullgard
yasm tolerates mismatch between movd/movq and source register size,
adjusting the instruction according to the register. nasm is more
strict.
Signed-off-by: Mans Rullgard
---
Missed a couple that somehow worked with nasm 2.10 but fail with 2.08.
---
libavcodec/x86/h264_deblock_10bit.asm | 12 ++
All OK
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
nasm prints a warning if the colon is missing.
Signed-off-by: Mans Rullgard
---
libavcodec/x86/deinterlace.asm | 2 +-
libavcodec/x86/dsputil_yasm.asm| 6 ++--
libavcodec/x86/dsputilenc_yasm.asm | 4 +--
libavcodec/x86/fft_mmx.asm | 2 +-
libavcodec/x86/fmtcon
yasm tolerates mismatch between movd/movq and source register size,
adjusting the instruction according to the register. nasm is more
strict.
Signed-off-by: Mans Rullgard
---
libavcodec/x86/h264_deblock_10bit.asm | 12 ++--
libavcodec/x86/rv34dsp.asm| 2 +-
libavcodec/x86/r
nasm requires a trailing / on paths specified with -I.
It does no harm with yasm.
Signed-off-by: Mans Rullgard
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 644aff4..20e6a38 100644
--- a/Makefile
+++ b/Makefile
@@ -27,7 +27,7 @@ CPPFLA
For some reason, nasm requires this. No harm done to yasm.
Signed-off-by: Mans Rullgard
---
libavutil/x86/x86inc.asm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavutil/x86/x86inc.asm b/libavutil/x86/x86inc.asm
index 03e6c07..86c406f 100644
--- a/libavutil/x86/x86i
nasm does not support 'CPU foonop' directives. This adds a configure
test for the directive and uses it only if supported.
Signed-off-by: Mans Rullgard
---
configure| 2 ++
libavutil/x86/x86inc.asm | 12 +---
2 files changed, 11 insertions(+), 3 deletions(-)
diff --git
These patches restore support for building x86 asm with nasm.
Mans Rullgard (5):
x86: add colons after labels
x86: use 32-bit source registers with movd instruction
build: add trailing / to yasm/nasm -I flags
x86: fix rNmp macros with nasm
x86: use nop cpu directives only if supported
OK
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
OK
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
OK
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
Diego Biurrun writes:
> No, there is another issue that i cannot quite put my finger on, which
> causes errors of the type:
>
> error: (call_internal:3) `%ifdef' expects macro identifiers
I'm not seeing any such messages. I'm getting a bunch of other errors
and warnings, mostly easy to fix.
Hi,
On Sun, Aug 5, 2012 at 2:20 PM, Diego Biurrun wrote:
> On Sun, Aug 05, 2012 at 09:35:27PM +0100, Måns Rullgård wrote:
>> Diego Biurrun writes:
>> > On Tue, May 22, 2012 at 09:09:39PM +0200, Diego Biurrun wrote:
>> >> On Sun, May 20, 2012 at 06:18:10PM +0200, Diego Biurrun wrote:
>> >> > On S
On Sun, Aug 05, 2012 at 10:45:19PM +0100, Måns Rullgård wrote:
> Diego Biurrun writes:
> > No, there is another issue that i cannot quite put my finger on, which
> > causes errors of the type:
> >
> > error: (call_internal:3) `%ifdef' expects macro identifiers
>
> Does this happen with all file
Diego Biurrun writes:
> No, there is another issue that i cannot quite put my finger on, which
> causes errors of the type:
>
> error: (call_internal:3) `%ifdef' expects macro identifiers
Does this happen with all files or just some?
--
Måns Rullgård
m...@mansr.com
__
Signed-off-by: Mans Rullgard
---
libavcodec/imc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/libavcodec/imc.c b/libavcodec/imc.c
index 726ca67..0d41d5f 100644
--- a/libavcodec/imc.c
+++ b/libavcodec/imc.c
@@ -92,7 +92,6 @@ typedef struct {
float sqrt_tab[30];
GetBitContext g
IMCContext was changed from an array to a pointer in 66b84e4,
but this memset() was not updated.
Signed-off-by: Mans Rullgard
---
libavcodec/imc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/imc.c b/libavcodec/imc.c
index 899572a..726ca67 100644
--- a/libavcode
Signed-off-by: Mans Rullgard
---
avconv.c | 2 +-
avprobe.c| 2 +-
libavcodec/imc.c | 4 ++--
libavcodec/snowenc.c | 2 +-
4 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/avconv.c b/avconv.c
index b20dbec..8429a72 100644
--- a/avconv.c
+++ b/avconv.c
@@
On Sun, Aug 05, 2012 at 10:22:14PM +0100, Mans Rullgard wrote:
> Signed-off-by: Mans Rullgard
> ---
> libavcodec/imc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/imc.c b/libavcodec/imc.c
> index 297efbb..92e9c8c 100644
> --- a/libavcodec/imc.c
> +++ b/lib
OK
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
Signed-off-by: Mans Rullgard
---
libavcodec/imc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/imc.c b/libavcodec/imc.c
index 297efbb..92e9c8c 100644
--- a/libavcodec/imc.c
+++ b/libavcodec/imc.c
@@ -416,7 +416,7 @@ static int bit_allocation(IMCContext *q, IMCCha
On Sun, Aug 05, 2012 at 09:35:27PM +0100, Måns Rullgård wrote:
> Diego Biurrun writes:
> > On Tue, May 22, 2012 at 09:09:39PM +0200, Diego Biurrun wrote:
> >> On Sun, May 20, 2012 at 06:18:10PM +0200, Diego Biurrun wrote:
> >> > On Sat, May 19, 2012 at 04:54:18PM +0100, Måns Rullgård wrote:
> >> >
On Sun, 5 Aug 2012, Måns Rullgård wrote:
Martin Storsjö writes:
An inline function in MSVC system headers included by these
headers use free().
Which function?
It's in _freea in the MSVC malloc.h (which is included implicitly). It's
not used by us, but we enable the equivalent of
-Werro
On Sun, 5 Aug 2012, Måns Rullgård wrote:
Martin Storsjö writes:
At this place, the normal way of initializing a struct works
fine, there's no need for a struct literal.
---
libavformat/utils.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/utils.c b/libavf
Martin Storsjö writes:
> At this place, the normal way of initializing a struct works
> fine, there's no need for a struct literal.
> ---
> libavformat/utils.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/utils.c b/libavformat/utils.c
> index 3630c6f..5
Martin Storsjö writes:
> An inline function in MSVC system headers included by these
> headers use free().
Which function?
> The local headers (after 239fdf1b) include internal.h that redirect
> free to please_use_av_free_instead_of_free.
That is because avutil.h foolishly includes common.h.
At this place, the normal way of initializing a struct works
fine, there's no need for a struct literal.
---
libavformat/utils.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/utils.c b/libavformat/utils.c
index 3630c6f..5b26c59 100644
--- a/libavformat/utils.c
An inline function in MSVC system headers included by these
headers use free(). The local headers (after 239fdf1b) include
internal.h that redirect free to please_use_av_free_instead_of_free.
---
libavutil/x86/cpu.c | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --gi
Diego Biurrun writes:
> On Tue, May 22, 2012 at 09:09:39PM +0200, Diego Biurrun wrote:
>> On Sun, May 20, 2012 at 06:18:10PM +0200, Diego Biurrun wrote:
>> > On Sat, May 19, 2012 at 04:54:18PM +0100, Måns Rullgård wrote:
>> > > Diego Biurrun writes:
>> > > > On Sat, May 19, 2012 at 04:21:01PM +0
On Tue, May 22, 2012 at 09:09:39PM +0200, Diego Biurrun wrote:
> On Sun, May 20, 2012 at 06:18:10PM +0200, Diego Biurrun wrote:
> > On Sat, May 19, 2012 at 04:54:18PM +0100, Måns Rullgård wrote:
> > > Diego Biurrun writes:
> > > > On Sat, May 19, 2012 at 04:21:01PM +0100, Måns Rullgård wrote:
> >
On Thu, Jul 26, 2012 at 11:56:05PM +0200, Luca Barbato wrote:
> On 07/26/2012 11:40 PM, Diego Biurrun wrote:
> > On Thu, Jul 26, 2012 at 02:28:29PM +0200, Luca Barbato wrote:
> >> On 07/22/2012 12:17 AM, Diego Biurrun wrote:
> >>> ---
> >>> LICENSE | 37 -
> >>
On Sun, Aug 05, 2012 at 06:34:26PM +0100, Mans Rullgard wrote:
> Signed-off-by: Mans Rullgard
> ---
> libavcodec/imc.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/libavcodec/imc.c b/libavcodec/imc.c
> index 6df3e58..297efbb 100644
> --- a/libavcodec/imc.c
> +++ b/libavcodec/imc.c
On Sun, 5 Aug 2012, Mans Rullgard wrote:
Signed-off-by: Mans Rullgard
---
libavcodec/imc.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/libavcodec/imc.c b/libavcodec/imc.c
index 6df3e58..297efbb 100644
--- a/libavcodec/imc.c
+++ b/libavcodec/imc.c
@@ -230,9 +230,6 @@ static av_cold int
Signed-off-by: Mans Rullgard
---
libavcodec/imc.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/libavcodec/imc.c b/libavcodec/imc.c
index 6df3e58..297efbb 100644
--- a/libavcodec/imc.c
+++ b/libavcodec/imc.c
@@ -230,9 +230,6 @@ static av_cold int imc_decode_init(AVCodecContext *avctx)
On Sat, 4 Aug 2012, Derek Buitenhuis wrote:
Some corrupted files would end up with a negative offset,
and segfault.
Fixes bug #177.
Signed-off-by: Derek Buitenhuis
---
libavcodec/dpx.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libavcodec/dpx.c b/libavcodec/dpx.c
On Sun, Aug 05, 2012 at 08:19:25AM -0700, Ronald S. Bultje wrote:
> On Sun, Aug 5, 2012 at 8:05 AM, Måns Rullgård wrote:
> > "Ronald S. Bultje" writes:
> >> On Sun, Aug 5, 2012 at 5:07 AM, Måns Rullgård wrote:
> >>> Mans Rullgard writes:
> >>>
> This allows simplifying a few expressions.
>
Hi,
On Sun, Aug 5, 2012 at 8:05 AM, Måns Rullgård wrote:
> "Ronald S. Bultje" writes:
>> On Sun, Aug 5, 2012 at 5:07 AM, Måns Rullgård wrote:
>>> Mans Rullgard writes:
>>>
This allows simplifying a few expressions.
Signed-off-by: Mans Rullgard
---
>>>
>>> Ping.
>>>
>>> Doe
"Ronald S. Bultje" writes:
> Hi,
>
> On Sun, Aug 5, 2012 at 5:07 AM, Måns Rullgård wrote:
>> Mans Rullgard writes:
>>
>>> This allows simplifying a few expressions.
>>>
>>> Signed-off-by: Mans Rullgard
>>> ---
>>
>> Ping.
>>
>> Does this solve the msvc problem with those expressions?
>
> I'm c
Hi,
On Sun, Aug 5, 2012 at 5:07 AM, Måns Rullgård wrote:
> Mans Rullgard writes:
>
>> This allows simplifying a few expressions.
>>
>> Signed-off-by: Mans Rullgard
>> ---
>
> Ping.
>
> Does this solve the msvc problem with those expressions?
I'm currently working on the converter to handle suc
Hi,
On Sun, Aug 5, 2012 at 2:44 AM, Diego Biurrun wrote:
> On Sat, Aug 04, 2012 at 06:19:38PM -0700, Ronald S. Bultje wrote:
>> On Sat, Aug 4, 2012 at 2:28 PM, Loren Merritt
>> wrote:
>> > On Sat, 4 Aug 2012, Diego Biurrun wrote:
>> >> On Sat, Aug 04, 2012 at 03:11:50PM -0400, Justin Ruggles wr
On Sat, Aug 04, 2012 at 11:49:15AM +0200, Anton Khirnov wrote:
> ---
> Makefile |2 +
> avconv.c | 2227
> ++
> avconv.h | 360 ++
> avconv_opt.c | 1916 ++
> 4 files c
On Sat, Aug 04, 2012 at 11:49:16AM +0200, Anton Khirnov wrote:
> ---
> Makefile|2 +-
> avconv.c| 530 ---
> avconv.h|2 +
> avconv_filter.c | 562
> +++
> 4 files
On Wed, Aug 01, 2012 at 12:17:43AM +0200, Diego Biurrun wrote:
> ---
> libavcodec/x86/h264_idct.asm |8
> 1 files changed, 4 insertions(+), 4 deletions(-)
OKed by Benjamin on IRC.
Diego
___
libav-devel mailing list
libav-devel@libav.org
ht
On Sat, Aug 04, 2012 at 07:06:04PM +0100, Mans Rullgard wrote:
> This simplifies adding extra flags for individual programs
> and also allows more than one object file per program.
>
> Signed-off-by: Mans Rullgard
> ---
> Makefile | 17 -
> configure | 6 +++---
> 2 files chang
On Sun, Aug 05, 2012 at 12:06:23PM +0100, Mans Rullgard wrote:
> This removes some needless indirection and duplication.
>
> Signed-off-by: Mans Rullgard
> ---
> tests/fate/filter.mak | 9 ++---
> 1 file changed, 2 insertions(+), 7 deletions(-)
OK
Diego
On Sun, Jul 29, 2012 at 11:01:34PM +0200, Luca Barbato wrote:
> On 07/29/2012 08:32 PM, Måns Rullgård wrote:
> > "Ronald S. Bultje" writes:
> >> On Jul 29, 2012 9:01 AM, "Luca Barbato" wrote:
> >>> On 07/29/2012 04:00 PM, Mans Rullgard wrote:
> This allows simplifying a few expressions.
> >>
Mans Rullgard writes:
> This allows simplifying a few expressions.
>
> Signed-off-by: Mans Rullgard
> ---
Ping.
Does this solve the msvc problem with those expressions?
--
Måns Rullgård
m...@mansr.com
___
libav-devel mailing list
libav-devel@libav.
This removes some needless indirection and duplication.
Signed-off-by: Mans Rullgard
---
tests/fate/filter.mak | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/tests/fate/filter.mak b/tests/fate/filter.mak
index 35b6558..e42f837 100644
--- a/tests/fate/filter.mak
+++
"Ronald S. Bultje" writes:
> +#ifndef AVUTIL_OS_SUPPORT_H
> +#define AVUTIL_OS_SUPPORT_H
> +
> +/**
> + * @file
> + * OSSupport
> + */
> +
> +#include
> +#include
> +
> +/*
> + * snprintf() on MSVC returns -1 (instead of required buffer length)
> + * if the input buffer isn't big enough. Also,
"Ronald S. Bultje" writes:
> From: "Ronald S. Bultje"
>
> The idea is to compile in os_support.c when compiling Libav against
> the MS runtime (e.g. with the MSVC compiler) and thereby provide
> replacements for some functions hat are not standards-compliant. We
> can force-include the header us
Diego Biurrun writes:
> On Fri, Aug 03, 2012 at 09:38:29PM +0100, Måns Rullgård wrote:
>> "Ronald S. Bultje" writes:
>> >> Other than that,
>> >> this feels like it belongs in compat/ rather than libavutil. Not really
>> >> sure how best to build it though.
>> >
>> > I was actually thinking of
On Sat, Aug 04, 2012 at 06:19:38PM -0700, Ronald S. Bultje wrote:
> On Sat, Aug 4, 2012 at 2:28 PM, Loren Merritt wrote:
> > On Sat, 4 Aug 2012, Diego Biurrun wrote:
> >> On Sat, Aug 04, 2012 at 03:11:50PM -0400, Justin Ruggles wrote:
> >>> On 07/31/2012 06:17 PM, Diego Biurrun wrote:
> ---
>
On Fri, Aug 03, 2012 at 09:38:29PM +0100, Måns Rullgård wrote:
> "Ronald S. Bultje" writes:
> >> Other than that,
> >> this feels like it belongs in compat/ rather than libavutil. Not really
> >> sure how best to build it though.
> >
> > I was actually thinking of that for the header, yes. I supp
It's a perfectly normal situation, nothing to spam about.
---
libavcodec/mpegaudiodec.c |1 -
1 file changed, 1 deletion(-)
diff --git a/libavcodec/mpegaudiodec.c b/libavcodec/mpegaudiodec.c
index 6c1e8af..f388d8b 100644
--- a/libavcodec/mpegaudiodec.c
+++ b/libavcodec/mpegaudiodec.c
@@ -1663
---
libavcodec/mpegaudioenc.c |5 +
1 file changed, 5 insertions(+)
diff --git a/libavcodec/mpegaudioenc.c b/libavcodec/mpegaudioenc.c
index 6e79a61..a0ae5a7 100644
--- a/libavcodec/mpegaudioenc.c
+++ b/libavcodec/mpegaudioenc.c
@@ -24,6 +24,8 @@
* The simplest mpeg audio layer 2 encode
74 matches
Mail list logo