Re: [libav-devel] [PATCH 1/2] mov: set st->duration in mov_read_stts() only if positive

2012-11-26 Thread Janne Grunau
On 2012-11-26 10:46:27 +0100, Janne Grunau wrote: > On 2012-11-25 23:10:26 +, Måns Rullgård wrote: > > Janne Grunau writes: > > > > > Although sample count and delta are in ISO 14496-12 specified as > > > unsigned files exists were interpreting it as signed integer makes > > > more sense (see

Re: [libav-devel] [PATCH 1/2] mov: set st->duration in mov_read_stts() only if positive

2012-11-26 Thread Janne Grunau
On 2012-11-26 02:31:10 +0100, Luca Barbato wrote: > On 11/26/2012 12:03 AM, Janne Grunau wrote: > > Although sample count and delta are in ISO 14496-12 specified as > > unsigned files exists were interpreting it as signed integer makes > > more sense (see mp4-negative-stts-problem.mp4). > > Fixes a

Re: [libav-devel] [PATCH 1/2] mov: set st->duration in mov_read_stts() only if positive

2012-11-26 Thread Janne Grunau
On 2012-11-25 23:10:26 +, Måns Rullgård wrote: > Janne Grunau writes: > > > Although sample count and delta are in ISO 14496-12 specified as > > unsigned files exists were interpreting it as signed integer makes > > more sense (see mp4-negative-stts-problem.mp4). > > Can someone _please_ exp

Re: [libav-devel] [PATCH 1/2] mov: set st->duration in mov_read_stts() only if positive

2012-11-25 Thread Luca Barbato
On 11/26/2012 12:03 AM, Janne Grunau wrote: > Although sample count and delta are in ISO 14496-12 specified as > unsigned files exists were interpreting it as signed integer makes > more sense (see mp4-negative-stts-problem.mp4). > Fixes an assert caused by negative avg_frame_rate deduced from a >

Re: [libav-devel] [PATCH 1/2] mov: set st->duration in mov_read_stts() only if positive

2012-11-25 Thread Måns Rullgård
Janne Grunau writes: > Although sample count and delta are in ISO 14496-12 specified as > unsigned files exists were interpreting it as signed integer makes > more sense (see mp4-negative-stts-problem.mp4). Can someone _please_ explain how a negative duration can ever many any sense at all? Or

[libav-devel] [PATCH 1/2] mov: set st->duration in mov_read_stts() only if positive

2012-11-25 Thread Janne Grunau
Although sample count and delta are in ISO 14496-12 specified as unsigned files exists were interpreting it as signed integer makes more sense (see mp4-negative-stts-problem.mp4). Fixes an assert caused by negative avg_frame_rate deduced from a negative duratoin computed in mov_read_stts() with the