Re: [libav-devel] [PATCH] libavcodec/mjpeg_qsv: Add the QSV MJPEG encoder

2017-07-17 Thread Diego Biurrun
On Mon, Jul 17, 2017 at 04:40:38PM +0800, Huang, Zhengxu wrote: > > From 45be66259e8fb99b05796748ead308f0fc73c68c Mon Sep 17 00:00:00 2001 > From: "Huang, Zhengxu" > Date: Tue, 18 Jul 2017 01:13:24 +0800 > Subject: [PATCH] libavcodec/mjpeg_qsv: Add the QSV MJPEG encoder > > usage: > -hwaccel qs

Re: [libav-devel] [PATCH 1/2] png: Report more details regarding unsupported pixel formats

2017-07-17 Thread Diego Biurrun
On Sun, Jul 16, 2017 at 04:04:59PM +0200, Luca Barbato wrote: > --- > libavcodec/pngdec.c | 3 +++ > 1 file changed, 3 insertions(+) LGTM Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 2/2] png: Support RGBA64 pixel format

2017-07-17 Thread Diego Biurrun
On Sun, Jul 16, 2017 at 04:05:00PM +0200, Luca Barbato wrote: > --- > libavcodec/pngdec.c | 3 +++ > 1 file changed, 3 insertions(+) probably OK Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-dev

Re: [libav-devel] [PATCH V2] libavcodec/mjpeg_qsv: Add the QSV MJPEG encoder

2017-07-20 Thread Diego Biurrun
On Wed, Jul 19, 2017 at 02:41:31PM +0800, Huang, Zhengxu wrote: > --- > Changes from v1: > * separate the mjpeg encoder from h264/hevc/mpeg2 as per Luca's review > * reuse the global_quality option as per Luca's review > * modify some coding-style and add changlog as per Diego's review > --- >

Re: [libav-devel] [PATCH 1/4] qsv: rename to qsvdec

2015-03-25 Thread Diego Biurrun
On Thu, Mar 19, 2015 at 09:45:48AM +0100, Anton Khirnov wrote: > --- a/configure > +++ b/configure > @@ -1828,7 +1828,7 @@ h263p_encoder_select="h263_encoder" > h264_decoder_select="cabac golomb h264chroma h264dsp h264pred h264qpel > startcode videodsp" > h264_decoder_suggest="error_resilience"

Re: [libav-devel] [PATCH 2/4] qsvdec: split off some code that will be shared with the encoder

2015-03-25 Thread Diego Biurrun
On Thu, Mar 19, 2015 at 09:45:49AM +0100, Anton Khirnov wrote: > --- /dev/null > +++ b/libavcodec/qsv.c > @@ -0,0 +1,115 @@ > +int ff_qsv_init_internal_session(AVCodecContext *avctx, mfxSession *session) > +{ > + > +switch (MFX_IMPL_BASETYPE(impl)) { > +case MFX_IMPL_SOFTWARE: > +

Re: [libav-devel] [PATCH 3/4] qsvdec: add 'decode' to the non-static function names

2015-03-25 Thread Diego Biurrun
On Thu, Mar 19, 2015 at 09:45:50AM +0100, Anton Khirnov wrote: > --- > libavcodec/qsvdec.c | 4 ++-- > libavcodec/qsvdec.h | 4 ++-- > libavcodec/qsvdec_h264.c | 4 ++-- > 3 files changed, 6 insertions(+), 6 deletions(-) Should be squashed with 1/3 IMO. LGTM Diego

Re: [libav-devel] [RFC/PATCH 4/4] lavc: add Intel libmfx-based H.264 encoder

2015-03-25 Thread Diego Biurrun
On Thu, Mar 19, 2015 at 09:45:51AM +0100, Anton Khirnov wrote: > --- > Changelog | 1 + > configure | 4 + > libavcodec/Makefile | 2 + > libavcodec/allcodecs.c| 1 + > libavcodec/qsv_internal.h | 13 ++ > l

Re: [libav-devel] [RFC/PATCH 4/4] lavc: add Intel libmfx-based H.264 encoder

2015-03-26 Thread Diego Biurrun
On Wed, Mar 25, 2015 at 08:19:35PM +0100, Anton Khirnov wrote: > Quoting Diego Biurrun (2015-03-25 18:04:54) > > On Thu, Mar 19, 2015 at 09:45:51AM +0100, Anton Khirnov wrote: > > > --- a/libavcodec/allcodecs.c > > > +++ b/libavcodec/allcodecs.c > > > @@ -463,6

Re: [libav-devel] [PATCH] Canopus HQ/HQA decoder

2015-03-26 Thread Diego Biurrun
On Sun, Mar 22, 2015 at 03:49:50PM +, Vittorio Giovara wrote: > --- /dev/null > +++ b/libavcodec/hq_hqa.c > @@ -0,0 +1,454 @@ > + > +#include It seems you only need stdint.h. > +#include "libavutil/imgutils.h" > +#include "libavutil/intreadwrite.h" > + > +#include "avcodec.h" > +#include "in

Re: [libav-devel] [PATCH] Canopus HQ/HQA decoder

2015-03-27 Thread Diego Biurrun
On Thu, Mar 26, 2015 at 07:19:08PM +, Vittorio Giovara wrote: > On Thu, Mar 26, 2015 at 2:27 PM, Diego Biurrun wrote: > > On Sun, Mar 22, 2015 at 03:49:50PM +, Vittorio Giovara wrote: > >> --- /dev/null > >> +++ b/libavcodec/hqdata.c > >> @@ -0,0 +1,83

Re: [libav-devel] [PATCHv2] Canopus HQ/HQA decoder

2015-03-27 Thread Diego Biurrun
On Fri, Mar 27, 2015 at 05:06:51PM +0100, Vittorio Giovara wrote: > Updated containing all reviews received. No. Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] Canopus HQ/HQA decoder

2015-03-27 Thread Diego Biurrun
On Fri, Mar 27, 2015 at 01:20:48PM +0100, Luca Barbato wrote: > On 27/03/15 11:17, Diego Biurrun wrote: > > > regexp-replace is your friend. > > s:^\( *\)\(.,\) :\1 \2: > > assuming 2 digits. Simple regexp replacements with one's favorite editor are not common kn

[libav-devel] [PATCH] qsv: Skip header compilation depending on what parts of qsv are enabled

2015-03-29 Thread Diego Biurrun
--- libavcodec/Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/Makefile b/libavcodec/Makefile index a29927f..39158f3 100644 --- a/libavcodec/Makefile +++ b/libavcodec/Makefile @@ -724,7 +724,9 @@ SKIPHEADERS+= %_tablegen.h

[libav-devel] [PATCH 2/2] sndio: Use a more consistent file naming scheme

2015-03-29 Thread Diego Biurrun
--- libavdevice/Makefile| 6 +++--- libavdevice/{sndio_common.c => sndio.c} | 2 +- libavdevice/{sndio_common.h => sndio.h} | 0 libavdevice/sndio_dec.c | 2 +- libavdevice/sndio_enc.c | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) ren

[libav-devel] [PATCH 1/2] alsa: Use a more consistent file naming scheme

2015-03-29 Thread Diego Biurrun
--- libavdevice/Makefile | 6 ++ libavdevice/{alsa-audio-common.c => alsa-audio.c} | 0 libavdevice/{alsa-audio-dec.c => alsa-audio_dec.c} | 0 libavdevice/{alsa-audio-enc.c => alsa-audio_enc.c} | 0 4 files changed, 2 insertions(+), 4 deletions(-) rename libavd

Re: [libav-devel] [PATCH 1/2] hevc: split out setting AVCodecContext parameters

2015-03-29 Thread Diego Biurrun
On Sun, Mar 29, 2015 at 02:18:54PM +0200, Anton Khirnov wrote: > --- a/libavcodec/hevc.c > +++ b/libavcodec/hevc.c > @@ -383,24 +383,63 @@ static int decode_lt_rps(HEVCContext *s, LongTermRPS > *rps, GetBitContext *gb) > return 0; > } > > +static void export_stream_params(AVCodecContext *a

Re: [libav-devel] [PATCH] lavc: add MMAL hardware decoder wrapper

2015-03-29 Thread Diego Biurrun
On Fri, Mar 27, 2015 at 11:04:08PM +0100, wm4 wrote: > --- a/configure > +++ b/configure > @@ -217,6 +217,7 @@ External library support: >--enable-libxcb-xfixes enable X11 grabbing mouse rendering [auto] >--enable-libxvid enable Xvid encoding via xvidcore, >

[libav-devel] [PATCH] indeo: Give Indeo4/5 shared code a more consistent name

2015-03-29 Thread Diego Biurrun
--- libavcodec/Makefile| 4 ++-- libavcodec/indeo4.c| 2 +- libavcodec/indeo4data.h| 3 +-- libavcodec/indeo5.c| 2 +- libavcodec/{ivi_common.c => ivi.c} | 2 +- libavcodec/{ivi_common.h => ivi.h} | 6 +++--- libavcodec/ivi_dsp.c

[libav-devel] [PATCH 1/3] mjpeg: Move code only used in the encoder(s) to the appropriate header

2015-03-29 Thread Diego Biurrun
--- libavcodec/jpeglsenc.c | 1 + libavcodec/mjpeg.h | 7 --- libavcodec/mjpegdec.c| 1 + libavcodec/mjpegenc.h| 7 +++ libavcodec/mjpegenc_common.c | 1 + 5 files changed, 10 insertions(+), 7 deletions(-) diff --git a/libavcodec/jpeglsenc.c b/libavcodec/jp

[libav-devel] [PATCH 2/3] mjpeg: Use a more precise type for put_marker()

2015-03-29 Thread Diego Biurrun
--- libavcodec/mjpeg.h| 4 ++-- libavcodec/mjpegenc.h | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/libavcodec/mjpeg.h b/libavcodec/mjpeg.h index 8b7bf8d..35df3bb 100644 --- a/libavcodec/mjpeg.h +++ b/libavcodec/mjpeg.h @@ -38,7 +38,7 @@ #include "avcodec.h" /* JP

[libav-devel] [PATCH 3/3] build: Split JPEG-related tables off into a separate component

2015-03-29 Thread Diego Biurrun
--- configure| 14 +++- libavcodec/Makefile | 12 +- libavcodec/g2meet.c | 1 + libavcodec/{mjpeg.c => jpegtables.c} | 2 +- libavcodec/jpegtables.h | 43 libavcodec/lj

Re: [libav-devel] [PATCH 1/2] hevc: split out setting AVCodecContext parameters

2015-03-29 Thread Diego Biurrun
On Sun, Mar 29, 2015 at 03:09:53PM +0200, Anton Khirnov wrote: > Quoting Diego Biurrun (2015-03-29 14:48:58) > > On Sun, Mar 29, 2015 at 02:18:54PM +0200, Anton Khirnov wrote: > > > --- a/libavcodec/hevc.c > > > +++ b/libavcodec/hevc.c > > > @@ -383,24

Re: [libav-devel] [PATCH] Canopus fixes

2015-03-30 Thread Diego Biurrun
On Mon, Mar 30, 2015 at 12:15:11PM +0200, Vittorio Giovara wrote: > --- > This is on top of [PATCHv2] and addresses the reviews I forgot. > Cheers, > Vittorio > > libavcodec/hq_hqa.h | 2 +- > libavcodec/hq_hqadata.c | 2 +- > tests/fate/video.mak| 6 +++--- > 3 files changed, 5 inser

Re: [libav-devel] [PATCH 1/2] alsa: Use a more consistent file naming scheme

2015-03-30 Thread Diego Biurrun
On Mon, Mar 30, 2015 at 01:21:58PM +0200, Nicolas George wrote: > Le decadi 10 germinal, an CCXXIII, Vittorio Giovara a écrit : > > also OSS is named oss_audio, should this be renamed alsa_audio_dec for > > consistency? > > I concur. It could also be just "alsa", since the name is completely > dis

Re: [libav-devel] [PATCH] qsv: Skip header compilation depending on what parts of qsv are enabled

2015-03-30 Thread Diego Biurrun
On Sun, Mar 29, 2015 at 02:20:44PM +0200, Diego Biurrun wrote: > --- > libavcodec/Makefile | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) OKed by Anton on IRC. Diego ___ libav-devel mailing list libav-devel@libav.

Re: [libav-devel] [PATCH] tiff: Return more meaningful error codes

2015-03-30 Thread Diego Biurrun
On Mon, Mar 30, 2015 at 12:27:56AM +0530, Himangi Saraogi wrote: > --- > libavcodec/tiffenc.c | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) Queueing. Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org

Re: [libav-devel] [PATCH 2/3] mjpeg: Use a more precise type for put_marker()

2015-03-30 Thread Diego Biurrun
On Mon, Mar 30, 2015 at 11:56:30AM +0200, Vittorio Giovara wrote: > On Sun, Mar 29, 2015 at 3:00 PM, Diego Biurrun wrote: > > --- > > libavcodec/mjpeg.h| 4 ++-- > > libavcodec/mjpegenc.h | 3 ++- > > 2 files changed, 4 insertions(+), 3 deletions(-) > >

[libav-devel] [PATCH] avdevice: Apply a more consistent file naming scheme

2015-03-31 Thread Diego Biurrun
--- Squashed it all together and dropped further silly name suffixes. libavdevice/Makefile | 18 -- libavdevice/{alsa-audio-common.c => alsa.c} | 2 +- libavdevice/{alsa-audio.h => alsa.h} | 0 libavdevice/{alsa-audio-dec.c => alsa_dec.c} | 2 +

Re: [libav-devel] [PATCH] hevc: split out setting AVCodecContext parameters

2015-03-31 Thread Diego Biurrun
On Tue, Mar 31, 2015 at 12:41:54PM +0200, Anton Khirnov wrote: > --- a/libavcodec/hevc.c > +++ b/libavcodec/hevc.c > @@ -383,24 +383,65 @@ static int decode_lt_rps(HEVCContext *s, LongTermRPS > *rps, GetBitContext *gb) > > +static void export_stream_params(AVCodecContext *avctx, > +

Re: [libav-devel] [PATCH] avdevice: Apply a more consistent file naming scheme

2015-03-31 Thread Diego Biurrun
On Tue, Mar 31, 2015 at 03:16:50PM +0200, Vittorio Giovara wrote: > On Tue, Mar 31, 2015 at 11:15 AM, Diego Biurrun wrote: > > --- > > > > Squashed it all together and dropped further silly name suffixes. > > > > libavdevice/Make

[libav-devel] [PATCH 2/2] Go2Meeting decoder

2015-03-31 Thread Diego Biurrun
From: Kostya Shishkov ELS and ePIC decoder courtesy of Maxim Poliakovski Cleanup and integration by Diego Biurrun. Signed-off-by: Diego Biurrun --- - Rebased on top of current master. - Fixed all Coverity warnings. - minor cosmetic cleanups Changelog | 1 + doc/general.texi

[libav-devel] [PATCH 1/2] g2meet: K&R formatting cosmetics

2015-03-31 Thread Diego Biurrun
--- libavcodec/g2meet.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/libavcodec/g2meet.c b/libavcodec/g2meet.c index ddd7a1f..a995724 100644 --- a/libavcodec/g2meet.c +++ b/libavcodec/g2meet.c @@ -28,11 +28,12 @@ #include #include "libavutil/intreadw

[libav-devel] [PATCH 1/3] g2meet: K&R formatting cosmetics

2015-03-31 Thread Diego Biurrun
--- Updated to match Kostya's preference. libavcodec/g2meet.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/g2meet.c b/libavcodec/g2meet.c index ddd7a1f..475c244 100644 --- a/libavcodec/g2meet.c +++ b/libavcodec/g2meet.c @@ -28,11 +28,12 @@ #include #i

[libav-devel] [PATCH 2/3] Go2Meeting decoder

2015-03-31 Thread Diego Biurrun
From: Kostya Shishkov ELS and ePIC decoder courtesy of Maxim Poliakovski, cleanup and integration by Diego Biurrun. Signed-off-by: Diego Biurrun --- Now states Go2Meeting support prominently in the file header, as requested by Kostya. Changelog| 1 + doc/general.texi | 2

[libav-devel] [PATCH 3/3] g2meet: Add FATE tests for all three G2M variants

2015-03-31 Thread Diego Biurrun
--- Split the tests off into a separate commit. tests/fate/screen.mak | 12 tests/ref/fate/g2m2 | 161 ++ tests/ref/fate/g2m3 | 42 + tests/ref/fate/g2m4 | 29 + 4 files changed, 244 insertions(+) create mode 1006

Re: [libav-devel] [PATCH] avcodec/libx265: export choosen picture types

2015-03-31 Thread Diego Biurrun
On Tue, Mar 31, 2015 at 02:50:40PM -0400, Derek Buitenhuis wrote: > From: Michael Niedermayer > > Signed-off-by: Michael Niedermayer > Signed-off-by: Derek Buitenhuis > --- > libavcodec/libx265.c | 13 + > 1 file changed, 13 insertions(+) Just "x265" is enough as topic ch_O_sen

Re: [libav-devel] [PATCHv3] Canopus HQ/HQA decoder

2015-04-02 Thread Diego Biurrun
On Tue, Mar 31, 2015 at 07:03:33PM +0200, Vittorio Giovara wrote: > --- /dev/null > +++ b/libavcodec/hq_hqa.c > @@ -0,0 +1,378 @@ > +static int hq_hqa_decode_frame(AVCodecContext *avctx, void *data, > + int *got_frame, AVPacket *avpkt) > +{ > +/* Parse FIEL tag

Re: [libav-devel] [PATCHv3] log: Print a full backtrace under Valgrinds on error message

2015-04-02 Thread Diego Biurrun
Valgrind_ I'd even say log: Print a full backtrace along with error messages under Valgrind On Mon, Mar 23, 2015 at 11:29:23PM +, Vittorio Giovara wrote: > Useful to understand where and in what execution state a certain message > is generated. It is enabled only when optimizations are disab

Re: [libav-devel] [PATCH] libavcodec: Add proper documentation of the internal codec capability flags

2015-04-02 Thread Diego Biurrun
On Thu, Apr 02, 2015 at 03:17:36PM +0300, Martin Storsjö wrote: > --- a/libavcodec/internal.h > +++ b/libavcodec/internal.h > @@ -34,11 +34,16 @@ > #include "config.h" > > /** > - * Codec is thread safe. > + * The codec doesn't touch global variables in the init function, allowing > + * running

Re: [libav-devel] [PATCH 2/3] Go2Meeting decoder

2015-04-02 Thread Diego Biurrun
On Thu, Apr 02, 2015 at 02:10:05PM +0200, Vittorio Giovara wrote: > On Tue, Mar 31, 2015 at 4:31 PM, Diego Biurrun wrote: > > From: Kostya Shishkov > > --- /dev/null > > +++ b/libavcodec/elsdec.c > > +{ -1, -72, 169, 145 }, > > +{ -6, -5, 168, 49

Re: [libav-devel] [RFC] ppc: linux: Check altivec using the auxv

2015-04-04 Thread Diego Biurrun
On Fri, Apr 03, 2015 at 03:31:32PM +0200, Luca Barbato wrote: > --- a/libavutil/ppc/cpu.c > +++ b/libavutil/ppc/cpu.c > @@ -62,6 +66,32 @@ int ff_get_cpu_flags_ppc(void) > if (err == 0) > return has_vu ? AV_CPU_FLAG_ALTIVEC : 0; > return 0; > +#elif defined(__linux__) > +// T

Re: [libav-devel] [PATCH] avconv: Avoid null dereferences

2015-04-04 Thread Diego Biurrun
avconv: Avoid NULL pointer dereferences LGTM Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] libavcodec: Clarify the documentation of the internal codec capability flags

2015-04-04 Thread Diego Biurrun
On Fri, Apr 03, 2015 at 02:05:56PM +0300, Martin Storsjö wrote: > The previous documentation was very vague and almost misleading. > --- > Updated with the final wording suggested by Vittorio. > --- > libavcodec/internal.h | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) Sounds go

Re: [libav-devel] [PATCHv3] log: Print a full backtrace under Valgrinds on error message

2015-04-04 Thread Diego Biurrun
On Thu, Apr 02, 2015 at 01:55:26PM +0200, Vittorio Giovara wrote: > On Thu, Apr 2, 2015 at 1:20 PM, Diego Biurrun wrote: > >> --- a/configure > >> +++ b/configure > >> @@ -315,6 +315,8 @@ Developer options (useful when working on Libav > >> itself): >

Re: [libav-devel] [PATCH] svq3: initialize some required H264Context fields.

2015-04-06 Thread Diego Biurrun
On Sun, Apr 05, 2015 at 09:15:06PM +0200, Anton Khirnov wrote: > They are no longer initialized in ff_h264_decode_init() since 43fd3dd, > so svq3 needs to initialize the manually. the_m Diego ___ libav-devel mailing list libav-devel@libav.org https://li

Re: [libav-devel] [PATCH 1/2] lavu/parseutils: add av_small_strptime()

2015-04-06 Thread Diego Biurrun
On Sun, Apr 05, 2015 at 11:40:47AM -0600, John Stebbins wrote: > From: Stefano Sabatini > > Make internal small_strptime() function public, and use it in place of > strptime(). > This allows to avoid a dependency on strptime() on systems which do not > support it. Which systems are affected? Di

Re: [libav-devel] [PATCH 1/2] lavu/parseutils: add av_small_strptime()

2015-04-06 Thread Diego Biurrun
On Mon, Apr 06, 2015 at 06:11:59PM +0200, Luca Barbato wrote: > On 06/04/15 17:57, Diego Biurrun wrote: > >On Sun, Apr 05, 2015 at 11:40:47AM -0600, John Stebbins wrote: > >>From: Stefano Sabatini > >> > >>Make internal small_strptime() function public,

Re: [libav-devel] [PATCH 7/7] h264: drop a comment that carries no useful information

2015-04-07 Thread Diego Biurrun
On Mon, Apr 06, 2015 at 09:04:14PM +0200, Anton Khirnov wrote: > --- a/libavcodec/h264.c > +++ b/libavcodec/h264.c > @@ -1698,7 +1698,7 @@ av_cold void ff_h264_free_context(H264Context *h) > { > int i; > > -ff_h264_free_tables(h); // FIXME cleanup init stuff perhaps > +ff_h264_free_

Re: [libav-devel] [PATCHv3] log: Print a full backtrace under Valgrinds on error message

2015-04-07 Thread Diego Biurrun
On Tue, Apr 07, 2015 at 10:22:16AM +0200, Luca Barbato wrote: > On 06/04/15 23:28, Vittorio Giovara wrote: > >On Sat, Apr 4, 2015 at 6:43 PM, Diego Biurrun wrote: > >>On Thu, Apr 02, 2015 at 01:55:26PM +0200, Vittorio Giovara wrote: > >>>On Thu, Apr 2, 2015 at

Re: [libav-devel] [PATCH 2/2] mov: Double-check that alias path does is not an absolute path

2015-04-07 Thread Diego Biurrun
s/does is/is/ Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 3/3] parseutil: Make av_small_strptime public

2015-04-07 Thread Diego Biurrun
On Mon, Apr 06, 2015 at 11:52:21PM +0200, Vittorio Giovara wrote: > On Mon, Apr 6, 2015 at 12:50 PM, Luca Barbato wrote: > > And use it in libavformat. > > > > Based on a similar patch from Stefano Sabatini . > > s/from/by/ Either form is fine. Diego

Re: [libav-devel] [PATCH 2/3] Go2Meeting decoder

2015-04-07 Thread Diego Biurrun
On Sun, Apr 05, 2015 at 09:04:09AM +0200, Anton Khirnov wrote: > Quoting Diego Biurrun (2015-03-31 16:31:33) > > +unsigned ff_els_decode_unsigned(ElsDecCtx *ctx, ElsUnsignedRung *ur) > > +{ > > +int i, n, r, bit; > > +ElsRungNode *rung_node; > > + > >

Re: [libav-devel] [PATCH 0/3] Fix AviSynth upgrade message

2015-04-08 Thread Diego Biurrun
On Thu, Apr 02, 2015 at 03:39:24PM -0400, Stephen Hutchinson wrote: > > Regarding AviSynth+, the upgrade message > currently uses the revision-based version > since 0.2 hasn't been released yet. Once > 0.2 has been released, then the message > should be adjusted to use that instead. Didn't AviSyn

Re: [libav-devel] [PATCH 2/3] Go2Meeting decoder

2015-04-08 Thread Diego Biurrun
On Tue, Apr 07, 2015 at 08:41:19PM +0200, Anton Khirnov wrote: > Quoting Diego Biurrun (2015-04-07 17:55:19) > > On Sun, Apr 05, 2015 at 09:04:09AM +0200, Anton Khirnov wrote: > > > Quoting Diego Biurrun (2015-03-31 16:31:33) > > > > +unsigned ff_els_decode_unsigned(E

Re: [libav-devel] [PATCH 2/3] Go2Meeting decoder

2015-04-08 Thread Diego Biurrun
On Wed, Apr 08, 2015 at 01:05:04PM +0200, Anton Khirnov wrote: > Quoting Diego Biurrun (2015-04-08 12:57:09) > > On Tue, Apr 07, 2015 at 08:41:19PM +0200, Anton Khirnov wrote: > > > Quoting Diego Biurrun (2015-04-07 17:55:19) > > > > On Sun, Apr 05, 2015 at 09:04:0

Re: [libav-devel] HQX codec patch: faster decode with multi threaded decoding of slices; fixed clipping bug

2015-04-08 Thread Diego Biurrun
> From e750ddd8b1b79cfad04f2cdd58b5ba438390adf1 Mon Sep 17 00:00:00 2001 > From: fo You should fix your Git configuration so that this contains your full name. Also, which one is your preferred email address? > Date: Mon, 6 Apr 2015 15:47:14 +0200 > Subject: [PATCH] libavcodec/hqx: made decoding

Re: [libav-devel] [PATCH 2/3] Go2Meeting decoder

2015-04-08 Thread Diego Biurrun
On Thu, Apr 02, 2015 at 02:10:05PM +0200, Vittorio Giovara wrote: > On Tue, Mar 31, 2015 at 4:31 PM, Diego Biurrun wrote: > > --- a/libavcodec/g2meet.c > > +++ b/libavcodec/g2meet.c > > @@ -895,6 +1603,7 @@ static av_cold int g2m_decode_end(AVCod

Re: [libav-devel] [PATCH] libavformat: Handle error return from ff_listen_bind

2015-04-08 Thread Diego Biurrun
On Wed, Apr 08, 2015 at 04:24:33PM +0200, Anders Nystrom wrote: > --- a/libavformat/tcp.c > +++ b/libavformat/tcp.c > @@ -114,11 +114,11 @@ static int tcp_open(URLContext *h, const char *uri, int > flags) > > if (s->listen) { > -if ((fd = ff_listen_bind(fd, cur_ai->ai_addr, cur_ai->

[libav-devel] [PATCH] Go2Meeting decoder

2015-04-08 Thread Diego Biurrun
From: Kostya Shishkov ELS and ePIC decoder courtesy of Maxim Poliakovski, cleanup and integration by Diego Biurrun. Signed-off-by: Diego Biurrun --- Addresses all review comments from Vittorio and Anton: - some cosmetics reformatting and restructuring - els_exp_tab is now a static instead of

[libav-devel] [PATCH 1/2] avdevice: Add missing header for NULL_IF_CONFIG_SMALL

2015-04-08 Thread Diego Biurrun
Also reshuffle headers into canonical order where appropriate. --- libavdevice/alsa-audio-dec.c | 5 - libavdevice/alsa-audio-enc.c | 3 +++ libavdevice/jack_audio.c | 1 + libavdevice/libdc1394.c | 17 ++--- libavdevice/pulse.c | 6 -- libavdevice/sndio_d

[libav-devel] [PATCH 2/2] avdevice: Apply a more consistent file naming scheme

2015-04-08 Thread Diego Biurrun
--- Now includes jack and a prefixed include for sndio.h to avoid conflicts. libavdevice/Makefile | 20 +--- libavdevice/{alsa-audio-common.c => alsa.c} | 2 +- libavdevice/{alsa-audio.h => alsa.h} | 6 +++--- libavdevice/{alsa-audio-dec.c => al

Re: [libav-devel] [PATCH] tests: Add atrac3+ tests

2015-04-10 Thread Diego Biurrun
On Fri, Apr 10, 2015 at 09:39:00PM +0200, Diego Biurrun wrote: > On Fri, Apr 10, 2015 at 10:38:34AM -0700, Timothy Gu wrote: > > --- > > Now with proper commit message. My question about decoded files still stand. > > I can create them or you can give them to me. Also, a be

Re: [libav-devel] [PATCH 2/2] mov: Double-check that alias path does is not an absolute path

2015-04-10 Thread Diego Biurrun
On Tue, Apr 07, 2015 at 03:06:05PM +0200, Vittorio Giovara wrote: > --- a/libavformat/mov.c > +++ b/libavformat/mov.c > @@ -2300,7 +2300,7 @@ static int mov_open_dref(AVIOContext **pb, char *src, > MOVDref *ref, > /* try relative path, we do not try the absolute because it can leak > informa

Re: [libav-devel] [PATCH 3/4] hqx: Store shareable data in main decoder context

2015-04-09 Thread Diego Biurrun
On Thu, Apr 09, 2015 at 06:09:33PM +0200, Vittorio Giovara wrote: > In preparation for multithread decoding. multithread_ed > --- a/libavcodec/hqx.c > +++ b/libavcodec/hqx.c > @@ -154,9 +151,9 @@ static int decode_block(GetBitContext *gb, VLC *vlc, > -static int hqx_decode_422(HQXContext *ctx, AV

Re: [libav-devel] [PATCH] Go2Meeting decoder

2015-04-09 Thread Diego Biurrun
On Wed, Apr 08, 2015 at 06:33:19PM +0200, Vittorio Giovara wrote: > On Wed, Apr 8, 2015 at 5:10 PM, Diego Biurrun wrote: > > @@ -914,5 +1620,5 @@ AVCodec ff_g2m_decoder = { > > .init = g2m_decode_init, > > .close = g2m_decode_

Re: [libav-devel] [PATCH] hqx: Store shareable data in main decoder context

2015-04-09 Thread Diego Biurrun
On Thu, Apr 09, 2015 at 07:06:33PM +0200, Vittorio Giovara wrote: > In preparation for multithreaded decoding. > --- > libavcodec/hqx.c | 112 > +-- > libavcodec/hqx.h | 13 +++ > 2 files changed, 64 insertions(+), 61 deletions(-) LGTM >

Re: [libav-devel] [PATCH 3/8] hqx: Mark codec as init-thread-safe and init-cleanup

2015-04-09 Thread Diego Biurrun
On Thu, Apr 09, 2015 at 11:48:40AM +0200, Vittorio Giovara wrote: > --- a/libavcodec/hqx.c > +++ b/libavcodec/hqx.c > @@ -626,10 +626,7 @@ static av_cold int hqx_decode_close(AVCodecContext > *avctx) > static av_cold int hqx_decode_init(AVCodecContext *avctx) > { > HQXContext *ctx = avctx->

Re: [libav-devel] [PATCH] Implement shared parsing of INFO tag in Canopus family

2015-04-09 Thread Diego Biurrun
On Thu, Apr 09, 2015 at 06:11:10PM +0200, Vittorio Giovara wrote: > Add some bound checking to CLLC; reduce HQX variable scoping and add bound_s > --- /dev/null > +++ b/libavcodec/canopus.c > @@ -0,0 +1,62 @@ > +switch (field_order) { > +case 0: avctx->field_order = AV_FIELD_TT; break; >

Re: [libav-devel] [PATCHv3] log: Print a full backtrace under Valgrinds on error message

2015-04-09 Thread Diego Biurrun
On Thu, Apr 09, 2015 at 12:39:33AM +0200, Janne Grunau wrote: > On 2015-04-07 14:38:59 +0200, Diego Biurrun wrote: > > On Tue, Apr 07, 2015 at 10:22:16AM +0200, Luca Barbato wrote: > > > On 06/04/15 23:28, Vittorio Giovara wrote: > > > >On Sat, Apr 4, 2015 at

Re: [libav-devel] [PATCH 3/4] hqx: Store shareable data in main decoder context

2015-04-09 Thread Diego Biurrun
On Thu, Apr 09, 2015 at 06:50:24PM +0200, Vittorio Giovara wrote: > On Thu, Apr 9, 2015 at 6:42 PM, Diego Biurrun wrote: > > On Thu, Apr 09, 2015 at 06:09:33PM +0200, Vittorio Giovara wrote: > >> @@ -47,12 +48,21 @@ typedef struct HQXAC { > >> > >> +typ

Re: [libav-devel] [PATCH 1/2] avdevice: Add missing header for NULL_IF_CONFIG_SMALL

2015-04-09 Thread Diego Biurrun
On Wed, Apr 08, 2015 at 05:41:50PM +0200, Diego Biurrun wrote: > Also reshuffle headers into canonical order where appropriate. > --- > libavdevice/alsa-audio-dec.c | 5 - > libavdevice/alsa-audio-enc.c | 3 +++ > libavdevice/jack_audio.c | 1 + > libavdevice/lib

Re: [libav-devel] [PATCH 7/8] ffv1: Check memory allocations

2015-04-09 Thread Diego Biurrun
On Thu, Apr 09, 2015 at 11:48:44AM +0200, Vittorio Giovara wrote: > --- > libavcodec/ffv1.c | 12 +++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/ffv1.c b/libavcodec/ffv1.c > index d1a6a83..1a02cf8 100644 > --- a/libavcodec/ffv1.c > +++ b/libavcodec/ffv1

Re: [libav-devel] [PATCH 8/8] lavc: check memory allocations

2015-04-09 Thread Diego Biurrun
On Thu, Apr 09, 2015 at 11:48:45AM +0200, Vittorio Giovara wrote: > --- > libavcodec/aacpsy.c| 6 ++ > libavcodec/asvenc.c| 2 ++ > libavcodec/dct.c | 2 ++ > libavcodec/eatgv.c | 3 +++ > libavcodec/flacenc.c | 2 ++ > libavcodec/huffyuvenc.c|

Re: [libav-devel] [PATCHv4] Canopus HQ/HQA decoder

2015-04-09 Thread Diego Biurrun
On Thu, Apr 09, 2015 at 06:12:30PM +0200, Vittorio Giovara wrote: > --- /dev/null > +++ b/libavcodec/hq_hqa.c > @@ -0,0 +1,370 @@ > +/* HQ defines dimensions and number of slices, so walking order is too; > + * HQA has no size constraint and features a fixed number of slices, > + * thus

Re: [libav-devel] [PATCH 4/4] hqx: Implement slice thread decoding

2015-04-09 Thread Diego Biurrun
On Thu, Apr 09, 2015 at 06:09:34PM +0200, Vittorio Giovara wrote: > Inspired by a patch from Ferdinand Oeinck . > --- > libavcodec/hqx.c | 128 > ++- > libavcodec/hqx.h | 10 +++-- > 2 files changed, 78 insertions(+), 60 deletions(-) slice-thr

Re: [libav-devel] [PATCH 1/4] hqx: Merge invalid format check within switch block

2015-04-09 Thread Diego Biurrun
On Thu, Apr 09, 2015 at 06:09:31PM +0200, Vittorio Giovara wrote: > --- > libavcodec/hqx.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) LGTM Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/

Re: [libav-devel] [PATCH] avcodec/libx265: print supported presets and tunes on error

2015-04-11 Thread Diego Biurrun
On Fri, Apr 10, 2015 at 04:55:55PM -0400, Derek Buitenhuis wrote: > From: James Almer > > Based on code from libavcodec/libx264.c > > Signed-off-by: James Almer > Signed-off-by: Derek Buitenhuis > --- > libavcodec/libx265.c | 15 ++- > 1 file changed, 14 insertions(+), 1 deletion(

[libav-devel] [PATCH] libdc1394: Unbreak build after c201069fa

2015-04-11 Thread Diego Biurrun
From: Michael Kostylev --- Gosh, c201069fa was humbling again .. libavdevice/libdc1394.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/libavdevice/libdc1394.c b/libavdevice/libdc1394.c index 3fa5d1f..20696f5 100644 --- a/libavdevice/libdc1394.c +++

Re: [libav-devel] [PATCH] Fix negative value "-1" assigned to unsigned ints

2015-04-11 Thread Diego Biurrun
On Sat, Apr 11, 2015 at 02:11:06AM +0530, Himangi Saraogi wrote: > --- > libavcodec/faxcompr.c | 2 +- > libavformat/ac3dec.c | 2 +- > libavformat/mp3dec.c | 2 +- > libavformat/rtmppkt.c | 3 ++- > 4 files changed, 5 insertions(+), 4 deletions(-) Is this an attempt to find and fix all instanc

[libav-devel] [PATCH] ffv1: Check memory allocations

2015-04-11 Thread Diego Biurrun
From: Vittorio Giovara Signed-off-by: Diego Biurrun --- Slightly simplified version of Vittorio's patch. libavcodec/ffv1.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/libavcodec/ffv1.c b/libavcodec/ffv1.c index d1a6a83..459ca08 100644

Re: [libav-devel] [PATCH] avformat: fix compiler warning integer conversion resulted in a change of sign

2015-04-11 Thread Diego Biurrun
On Sat, Apr 11, 2015 at 02:01:02PM +0200, Nicolas George wrote: > [...] Thanks, I think we've had enough of your trolling for today. Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] avformat: fix compiler warning integer conversion resulted in a change of sign

2015-04-11 Thread Diego Biurrun
On Sat, Apr 11, 2015 at 01:19:45PM +0200, wm4 wrote: > On Sat, 14 Mar 2015 21:41:13 +0530 > Himangi Saraogi wrote: > > --- a/libavformat/ac3dec.c > > +++ b/libavformat/ac3dec.c > > @@ -61,7 +61,7 @@ static int ac3_eac3_probe(AVProbeData *p, enum AVCodecID > > expected_codec_id) > > > > if

Re: [libav-devel] [PATCH] Fix negative value "-1" assigned to unsigned ints

2015-04-11 Thread Diego Biurrun
On Sat, Apr 11, 2015 at 02:45:56PM +0200, Anton Khirnov wrote: > Quoting Diego Biurrun (2015-04-11 11:00:51) > > On Sat, Apr 11, 2015 at 02:11:06AM +0530, Himangi Saraogi wrote: > > > --- a/libavformat/rtmppkt.c > > > +++ b/libavformat/rtmppkt.c > > > @

Re: [libav-devel] [PATCH] avformat: fix compiler warning integer conversion resulted in a change of sign

2015-04-11 Thread Diego Biurrun
On Sat, Apr 11, 2015 at 02:18:38PM +0200, Nicolas George wrote: > Le duodi 22 germinal, an CCXXIII, Diego Biurrun a écrit : > > > > -unsigned int code = -1; > > > > +unsigned int code = 0x; > > > Why change this? AFAIK it's perfectly

Re: [libav-devel] [PATCH 8/8] lavc: check memory allocations

2015-04-11 Thread Diego Biurrun
On Thu, Apr 09, 2015 at 11:48:45AM +0200, Vittorio Giovara wrote: > --- a/libavcodec/aacpsy.c > +++ b/libavcodec/aacpsy.c OK > --- a/libavcodec/dct.c > +++ b/libavcodec/dct.c OK > --- a/libavcodec/jpeglsdec.c > +++ b/libavcodec/jpeglsdec.c OK > --- a/libavcodec/libtheoraenc.c > +++ b/libavcod

Re: [libav-devel] [PATCH] Fix negative value "-1" assigned to unsigned ints

2015-04-11 Thread Diego Biurrun
On Sat, Apr 11, 2015 at 05:30:09PM +0200, Nicolas George wrote: > But as Diego heavily emphasized, providing a "fair, productive > environment for developers and contributors" does not apply to me, It does if you play by the rules of civility and let our contributors live peacefully. Now let us p

Re: [libav-devel] [PATCHv4] Canopus HQ/HQA decoder

2015-04-13 Thread Diego Biurrun
On Sun, Apr 12, 2015 at 05:58:04PM +0200, Vittorio Giovara wrote: > On Fri, Apr 10, 2015 at 12:17 PM, Diego Biurrun wrote: > > On Fri, Apr 10, 2015 at 11:58:13AM +0200, Vittorio Giovara wrote: > >> On Fri, Apr 10, 2015 at 11:33 AM, Vittorio Giovara > >> wrote: > &g

Re: [libav-devel] [PATCH] mpeg4videodec: remove useless messages

2015-04-14 Thread Diego Biurrun
On Mon, Apr 13, 2015 at 07:35:54PM +0200, wm4 wrote: > --- a/libavcodec/mpeg4videodec.c > +++ b/libavcodec/mpeg4videodec.c > @@ -2097,8 +2097,6 @@ static int decode_vop_header(Mpeg4DecContext *ctx, > GetBitContext *gb) > > if (ctx->time_increment_bits == 0 || > !(show_bits(gb, ctx-

Re: [libav-devel] [PATCH 1/2] mmal: move system headers before local headers

2015-04-14 Thread Diego Biurrun
On Mon, Apr 13, 2015 at 07:17:59PM +0200, wm4 wrote: > --- > Requested by Diego some time ago. Thanks, queueing together with 2/2. Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] libdc1394: Unbreak build after c201069fa

2015-04-14 Thread Diego Biurrun
On Sat, Apr 11, 2015 at 11:44:26PM +0300, Martin Storsjö wrote: > On Sat, 11 Apr 2015, Diego Biurrun wrote: > >--- > > > >Gosh, c201069fa was humbling again .. > > > >libavdevice/libdc1394.c | 20 ++-- > >1 file changed, 10 insertions(+), 10 de

Re: [libav-devel] [PATCH] Add atrac3+ tests

2015-04-14 Thread Diego Biurrun
On Fri, Apr 10, 2015 at 10:25:28AM -0700, Timothy Gu wrote: > --- > > The samples are all from https://samples.libav.org/A-codecs/ATRAC3%2b/. > Should I upload the .pcm files to somewhere? They are trivial enough to > reproduce. make fate GEN=1 should create them. > --- a/tests/fate/atrac.mak >

Re: [libav-devel] [PATCH] tests: Do not include stdout/stderr or diff if the test passed

2015-04-14 Thread Diego Biurrun
On Fri, Apr 10, 2015 at 10:36:03AM -0700, Timothy Gu wrote: > FATE currently discards this information anyway, so why waste the > disk space? > --- a/tests/fate-run.sh > +++ b/tests/fate-run.sh > @@ -211,7 +211,13 @@ else > > -echo "${test}:${sig:-$err}:$($base64 <$cmpfile):$($base64 <$errfile)"

Re: [libav-devel] [PATCHv3] log: Print a full backtrace under Valgrinds on error message

2015-04-14 Thread Diego Biurrun
On Sun, Apr 12, 2015 at 11:56:30AM +0200, Janne Grunau wrote: > On 2015-04-09 18:44:59 +0200, Diego Biurrun wrote: > > On Thu, Apr 09, 2015 at 12:39:33AM +0200, Janne Grunau wrote: > > > On 2015-04-07 14:38:59 +0200, Diego Biurrun wrote: > > > > On Tue, Apr 07,

Re: [libav-devel] [PATCH] motion_est: Fix warning from zero_cmp() assignment

2015-04-14 Thread Diego Biurrun
On Tue, Apr 14, 2015 at 01:32:06PM +0200, Vittorio Giovara wrote: > warning: incompatible > pointer types assigning to 'me_cmp_func' (aka 'int (*)(struct > MpegEncContext *, uint8_t *, uint8_t *, ptrdiff_t, int)') from 'int > (MpegEncContext *, uint8_t *, uint8_t *, int, int)' >

[libav-devel] [PATCH 1/2] avisynth: Simplify shared library name construction

2015-04-14 Thread Diego Biurrun
--- Untested, I don't have avisynth, so testing more than welcome. libavformat/avisynth.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/libavformat/avisynth.c b/libavformat/avisynth.c index fb7441c..48b2a12 100644 --- a/libavformat/avisynth.c +++ b/libavformat/avisy

[libav-devel] [PATCH 2/2] configure: Simplify avisynth check

2015-04-14 Thread Diego Biurrun
--- Again, untested as I don't have avisynth, so testing more than welcome. configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 8821cbc..3493ea8 100755 --- a/configure +++ b/configure @@ -4217,8 +4217,8 @@ for func in $MATH_FUNCS; do don

Re: [libav-devel] [PATCHv3] log: Print a full backtrace under Valgrinds on error message

2015-04-14 Thread Diego Biurrun
On Mon, Mar 23, 2015 at 11:29:23PM +, Vittorio Giovara wrote: > --- a/configure > +++ b/configure > @@ -315,6 +315,8 @@ Developer options (useful when working on Libav itself): > (group) and PROB the probability associated with > NAME (def

Re: [libav-devel] [PATCH] vc1_pred: Always initialize px and py

2015-04-15 Thread Diego Biurrun
On Wed, Apr 15, 2015 at 03:04:32PM +0100, Vittorio Giovara wrote: > Fix a rather lenghty warning from clang. leng_th_y > --- a/libavcodec/vc1_pred.c > +++ b/libavcodec/vc1_pred.c > @@ -648,7 +648,8 @@ void ff_vc1_pred_mv_intfr(VC1Context *v, int n, int > dmv_x, int dmv_y, > } el

Re: [libav-devel] [PATCH] mpegvideo_enc: Simplify picture allocation

2015-04-15 Thread Diego Biurrun
On Wed, Apr 15, 2015 at 03:16:13PM +0100, Vittorio Giovara wrote: > --- > libavcodec/mpegvideo_enc.c | 12 +--- > 1 file changed, 5 insertions(+), 7 deletions(-) LGTM Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.

<    4   5   6   7   8   9   10   11   12   13   >