Commit id 'fb2bd208' essentially copied the qemuGetSecretString
creating an libxlGetSecretString. Rather than have multiple copies
of the same code, create src/secret/secret_util.{c,h} files and
place the common function in there.
Modify the the build in order to build the module as a library
[...]
>>
>> The secret driver should be calling functions from src/util, not the
>> other way around.
>>
>> Could this function be moved into src/secret?
>>
>
> Won't that place dependencies on secret_driver for libxl_driver and
> qemu_driver? IOW: Some sort of Makefile magic to get a symbol
Dear libvir[t] hackers,
## Intro
I'd like to tell you about a project I'm working on, how it pertains to
libvirt, and to inspire you about this idea.
I thought I'd first give you some quick background about myself... Skip
to '## Project' if you'd prefer... I'm James, but I go by purpleidea on
a
In order for the client to see all thread counts and limits, current total
and free worker count getters need to be introduced. Client might also be
interested in the job queue length, so provide a getter for that too. As with
the other getters, preparing for the admin interface, mutual exclusion
So far, the values the affected getters retrieve are static, i.e. there's no
way of changing them during runtime. But admin interface will later enable
not only getting but changing them as well. So to prevent phenomenons like
torn reads or concurrent reads and writes of unaligned values, use
since v2:
- all getters are now protected by threadpool mutex to prevent torn reads in
concurrent execution
- some checks in adminDispatchServerGetThreadpoolParameters were redundant,
thus were optimizes out
- fixed memory leak in adminDispatchServerGetThreadpoolParameters when
allocating a
New API to retrieve current server workerpool specs. Since it uses typed
parameters, more specs to retrieve can be further included in the pool of
supported ones.
Signed-off-by: Erik Skultety
---
daemon/admin.c | 45 +++
Since threadpool increments the current number of threads according to current
load, i.e. how many jobs are waiting in the queue. The count however, is
constrained by max and min limits of workers. The logic of this new API works
like this:
1) setting the minimum
a) When the limit is
Make all relevant changes to admin protocol, in order to achieve $(subj)
Signed-off-by: Erik Skultety
---
cfg.mk | 2 +-
src/admin/admin_protocol.x | 24
src/admin_protocol-structs | 25 +
3 files
Otherwise 'Unknown' error will be returned to client.
Signed-off-by: Erik Skultety
---
po/POTFILES.in | 1 +
src/util/virthreadpool.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/po/POTFILES.in b/po/POTFILES.in
index 5316d4f..6d720c0 100644
---
Commit a474371f broke ordering of the records. Now if a file required for
translation is missing, syntax-check (po-check) will fail and suggest a patch
to add the missing file. However, if the ordering is broken, the patch will
be understandably inapplicable (cleanly), since the diff isn't against
Before any getter or setter methods can be introduced, first specify a set of
public attributes/flags that these methods will be compatible with.
Signed-off-by: Erik Skultety
---
include/libvirt/libvirt-admin.h | 60 +
1 file changed,
When either creating a threadpool, or creating a new thread to accomplish a job
that had been placed into the jobqueue, every time thread-specific data need to
be allocated, threadpool needs to be (re)-allocated and thread count indicators
updated. Make the code clearer to read by compressing
Wire up the server threadpool tunable APIs to virt-admin client.
Signed-off-by: Erik Skultety
---
tools/virt-admin.c | 132 +
1 file changed, 132 insertions(+)
diff --git a/tools/virt-admin.c b/tools/virt-admin.c
index
Commits 0472cef6, 9afc115f, 8cd1d546 exported typed params handlers internally,
but a commit which would move the public definition from libvirt-host to
libvirt-common was missing.
Signed-off-by: Erik Skultety
---
include/libvirt/libvirt-common.h.in | 185
Signed-off-by: Vasiliy Tolstov
---
src/network/bridge_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c
index 0d14e3a3..73236ffe1cd9 100644
--- a/src/network/bridge_driver.c
+++
Signed-off-by: Vasiliy Tolstov
---
src/lxc/lxc_container.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c
index 348bbfbc01fc..a1deb0c00d4c 100644
--- a/src/lxc/lxc_container.c
+++
Signed-off-by: Vasiliy Tolstov
---
docs/formatdomain.html.in | 12 +++-
docs/schemas/domaincommon.rng | 5 +
src/conf/domain_conf.c| 14 +-
src/conf/domain_conf.h| 1 +
4 files changed, 30 insertions(+), 2 deletions(-)
diff
Signed-off-by: Vasiliy Tolstov
---
src/qemu/qemu_interface.c | 39 +++
1 file changed, 39 insertions(+)
diff --git a/src/qemu/qemu_interface.c b/src/qemu/qemu_interface.c
index 13a513152876..5729325fadb9 100644
---
Signed-off-by: Vasiliy Tolstov
---
src/util/virnetdev.c | 54
src/util/virnetdev.h | 1 +
2 files changed, 39 insertions(+), 16 deletions(-)
diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c
index
Some minor improvements and patch split as suggested by Laine Stump
Vasiliy Tolstov (5):
virnetdev allow to set peer address
libvirt domain xml allow to set peer address
lxc domain allow to set peer address
bridge network ignore peer address
qemu domain allow to set ip address, peer
On 04/04/2016 03:47 PM, Cole Robinson wrote:
> On 04/04/2016 03:36 PM, John Ferlan wrote:
>> Details in each patch...
>>
>> Depending on whether I get a review before I close my eyes for the
>> night I can push or if reviewed after than and before a release is
>> made - I'm sure someone else
On 04/04/2016 10:33 AM, Ján Tomko wrote:
> On Thu, Mar 31, 2016 at 11:05:07AM -0400, John Ferlan wrote:
>> Commit id 'fb2bd208' essentially copied the qemuGetSecretString
>> creating an libxlGetSecretString. Rather than have multiple copies
>> of the same code, create virsecret.{c,h} files and
On 04/04/2016 03:36 PM, John Ferlan wrote:
> Details in each patch...
>
> Depending on whether I get a review before I close my eyes for the
> night I can push or if reviewed after than and before a release is
> made - I'm sure someone else can grab and push too...
>
> John Ferlan (6):
>
Commit id '5ab8640' misapplied a merge of commit id '019244751'
to place the "-chardev" command after formatting the character
backend value.
Signed-off-by: John Ferlan
---
src/qemu/qemu_command.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Commit id '0e1e7ade' misapplied a merge of commit id '019244751'
to place the "-chardev" command after formatting the character
backend value.
Signed-off-by: John Ferlan
---
src/qemu/qemu_command.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Details in each patch...
Depending on whether I get a review before I close my eyes for the
night I can push or if reviewed after than and before a release is
made - I'm sure someone else can grab and push too...
John Ferlan (6):
qemu: Fix mis-merge of qemuBuildSmartcardCommandLine
qemu:
Commit id '59e7ef3c' misapplied a merge of commit id '019244751'
to place the "-chardev" command after formatting the character
backend value.
Signed-off-by: John Ferlan
---
src/qemu/qemu_command.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Commit id '858bafeb' misapplied a merge of commit id '019244751'
to place the "-chardev" command after formatting the character
backend value.
Signed-off-by: John Ferlan
---
src/qemu/qemu_command.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Commit id 'e6944a52' misapplied a merge of commit id '019244751'
to place the "-chardev" command after formatting the character
backend value.
Signed-off-by: John Ferlan
---
src/qemu/qemu_command.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Commit id '3cdcc910' misapplied a merge of commit id '019244751'
to place the "-chardev" command after formatting the character
backend value.
Signed-off-by: John Ferlan
---
src/qemu/qemu_command.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
On 03/29/2016 10:59 PM, Daniel Veillard wrote:
> As suggested yesterday, I tagged RC1 in git and pushed signed tarball
> and rpms to the usual place:
>
> ftp://libvirt.org/libvirt/
>
>
> Seems to work for me, but please give it some testing !
> I expect to have an rc2 on Friday, and do
From: sendmail [mailto:justsendmailnothinge...@gmail.com] On Behalf Of Laine
Stump
Sent: Sunday, April 03, 2016 7:14 PM
To: Libvirt
Cc: Moshe Levi ; Alex Williamson
Subject: Re: [libvirt] Host device assignment driver
Basically, the existing code was built around the assumption that
no cgroup name could appear as part of the name of another cgroup...
Unfortunately, valid cgroup names include 'cpu', 'cpuacct' and 'cpuset'.
This series removes the assumption.
Cheers.
Andrea Bolognani (2):
host-validate: Be
Simply checking whether the cgroup name appears somewhere inside
/proc/self/cgroup is enough most of the time, but there are some
corner cases that require a more mindful parsing.
As a bonus, after the rewrite 'line' is no longer leaked.
---
tools/virt-host-validate-common.c | 49
The existing code was built with the assumption that no cgroup
name could appear as part of another cgroup name. Rewrite it to
handle such cases correctly.
---
tools/virt-host-validate-common.c | 18 +++---
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git
On 03/28/2016 05:17 PM, Laine Stump wrote:
On 03/28/2016 07:52 AM, John Ferlan wrote:
While reviewing patch:
http://www.redhat.com/archives/libvir-list/2016-March/msg00194.html
I noted that the order of operations during the code path was slightly
different and could cause issues if the
On Thu, Mar 31, 2016 at 11:05:07AM -0400, John Ferlan wrote:
> Commit id 'fb2bd208' essentially copied the qemuGetSecretString
> creating an libxlGetSecretString. Rather than have multiple copies
> of the same code, create virsecret.{c,h} files and place the common
> function in there.
>
> Usage
Removes the check for graphics type, it's not a public API and developer
know what he's doing and this check makes no sense. It also removes
the ability to allocate a new array if there is none. This was used by
the virDomainGraphicsListenAdd* functions and isn't used anymore.
This is now a
Move generation of vnc unix socket to qemuProcessPrepareDomain which is
the correct place to do those things. Now we can also test it.
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_command.c| 20 -
src/qemu/qemu_command.h
Instead of calling the virDomainGraphicsListensParseXML function for all
graphics types and ignore the wrong ones move the call only to graphics
types where we supports listen elements.
Signed-off-by: Pavel Hrdina
---
src/conf/domain_conf.c | 28 +++-
Those are the last two places that uses the getter functions. Use a
direct access instead and remove those getters.
Signed-off-by: Pavel Hrdina
---
src/conf/domain_conf.c | 58 ++--
src/conf/domain_conf.h | 8 ---
There is no point the use two different getters on the same listen
structure few lines apart.
Signed-off-by: Pavel Hrdina
---
src/libxl/libxl_conf.c | 15 +++
src/qemu/qemu_command.c| 98 --
src/qemu/qemu_migration.c |
Signed-off-by: Pavel Hrdina
---
src/conf/domain_conf.c | 16
src/conf/domain_conf.h | 1 +
src/libvirt_private.syms | 1 +
3 files changed, 14 insertions(+), 4 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index
Move adding the config listen type=address if there is none in
qemuProcessPrepareDomain and move check for multiple listens to
qemuProcessStartValidate.
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_process.c | 48
1 file
Move code, that parses graphics listens, to it's own function.
Signed-off-by: Pavel Hrdina
---
src/conf/domain_conf.c | 79 ++
1 file changed, 47 insertions(+), 32 deletions(-)
diff --git a/src/conf/domain_conf.c
Use VIR_APPEND_ELEMENT_COPY_INPLACE to add listen elements into listens
array while parsing.
Signed-off-by: Pavel Hrdina
---
src/conf/domain_conf.c | 27 ---
1 file changed, 16 insertions(+), 11 deletions(-)
diff --git a/src/conf/domain_conf.c
Signed-off-by: Pavel Hrdina
---
src/conf/domain_conf.c | 16
src/conf/domain_conf.h | 2 --
src/libvirt_private.syms | 1 -
3 files changed, 19 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index a1a73ac..abe5d5a 100644
---
Pavel Hrdina (18):
tests: remove unwanted VIR_FREE of spice and vnc default listen
docs: rewrite graphics XML documentation
domain_conf: introduce virDomainGraphicsListensParseXML
domain_conf: cleanup virDomainGraphicsListensParseXML
domain_conf: split graphics xml parser into multiple
Refactor the listen parser to use only one loop.
Signed-off-by: Pavel Hrdina
---
src/conf/domain_conf.c | 117 +
1 file changed, 50 insertions(+), 67 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
This effectively removes virDomainGraphicsListenSetAddress which was
used only to change the address of listen structure and possible change
the listen type. The new function will auto-expand the listens array
and add a new listen.
The old function was used on pre-allocated array of listens and
This cleanups the documentation, reformat some of the paragraphs to use
instead of and rewrites the listen part to be more extendable.
Signed-off-by: Pavel Hrdina
---
docs/formatdomain.html.in | 351 ++
1 file changed, 169
Signed-off-by: Pavel Hrdina
---
src/conf/domain_conf.c | 835 +++--
1 file changed, 453 insertions(+), 382 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 9d48d07..fd9316f 100644
---
The same as for virDomainGraphicsListenAddAddress from previous commit
applies to this one too.
Signed-off-by: Pavel Hrdina
---
src/conf/domain_conf.c | 30 +++---
src/conf/domain_conf.h | 5 +++--
src/libvirt_private.syms | 2 +-
3 files
After the test and qemu_process refactor now we can benefit from default
listen address for spice and vnc in tests.
Signed-off-by: Pavel Hrdina
---
tests/qemuxml2argvdata/qemuxml2argv-graphics-spice-timeout.args | 2 +-
tests/qemuxml2argvtest.c
Signed-off-by: Pavel Hrdina
---
src/conf/domain_conf.c | 100 ++---
1 file changed, 45 insertions(+), 55 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index fd9316f..42050b0 100644
---
If in qemu.conf vncAutoUnixSocket is enabled remove all other listens
parsed from XML config.
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_domain.c | 10 ++
...-graphics-vnc-auto-unix-socket-with-listen.args | 22 +
On Mon, Apr 04, 2016 at 07:38:27AM -0400, Laine Stump wrote:
On 04/01/2016 02:04 PM, Laine Stump wrote:
There is a different regression that I also found which I've just
posted patches for:
https://www.redhat.com/archives/libvir-list/2016-April/msg00067.html
Because the fix involves adding
On Mon, Apr 04, 2016 at 08:52:22AM +0200, Michal Privoznik wrote:
On 03.04.2016 21:27, Martin Kletzander wrote:
Laine found out that he can't do 'virsh nodedev-detach pci_dev'
because of some strange error message. That was caused by my commit,
but also by all the previous ones that skipped
On 04/01/2016 02:04 PM, Laine Stump wrote:
There is a different regression that I also found which I've just
posted patches for:
https://www.redhat.com/archives/libvir-list/2016-April/msg00067.html
Because the fix involves adding in a new function that may or may not
be compiled in
On 04/03/2016 03:27 PM, Martin Kletzander wrote:
Commit d77ffb6876 added not only reporting of the PCI header type, but
also parsing of that information. However, because there was no parsing
done for the other sub-PCI capabilities, if there was any other
capability then a valid header type
On 04/04/2016 05:27 AM, Michal Privoznik wrote:
On 01.04.2016 19:54, Laine Stump wrote:
The full description of the problem fixed by these patches is in patch
3/3. Basically, a recent patch changed the ordering of things during
startup such that hostdev interfaces are given an alias named
getting err using virGetLastError() and then retrieving
message from err asks developers to test the value
of err and err->message and default to self-defined
unkown error message.
It's better to avoid it and use uniform
virGetLastErrorMessage
---
daemon/libvirtd.c | 8 +---
On Tue, Mar 29, 2016 at 07:11:35PM -0400, John Ferlan wrote:
> Add a masterKey and masterKeyLen to _qemuDomainObjPrivate to store a
> random domain master key and its length in order to support the ability
> to encrypt/decrypt sensitive data shared between libvirt and qemu. The
> key will be
On Tue, Mar 29, 2016 at 07:11:36PM -0400, John Ferlan wrote:
> If the -object secret capability exists, then get the path to the
> masterKey file and provide that to qemu. Checking for the existence
> of the file before passing to qemu could be done, but causes issues
> in mock test environment.
>
On 04.04.2016 10:29, Daniel P. Berrange wrote:
> On Sat, Apr 02, 2016 at 04:45:21PM +0200, Michal Privoznik wrote:
>> It would be nice to have these in before the release.
>>
>> Michal Privoznik (3):
>> Adapt to new virDomain{Get,Set}PerfEvents()
>> gitignore: Add more files to ignore &
On Tue, Mar 29, 2016 at 07:11:34PM -0400, John Ferlan wrote:
> Using the existing virUUIDGenerateRandomBytes, move API to virutil.c
> and add it to libvirt_private.syms.
>
> This will be used as a fallback for generating a domain master key.
>
> Signed-off-by: John Ferlan
>
On Tue, Mar 29, 2016 at 07:11:33PM -0400, John Ferlan wrote:
> Add a capability bit for the qemu secret object.
>
> Adjust the 2.6.0-1 caps/replies to add the secret object. For the
> .replies it's take from the '{"execute":"qom-list-types"}' output.
>
> Signed-off-by: John Ferlan
On Sun, Apr 03, 2016 at 10:23:20PM +0200, Martin Kletzander wrote:
> We forgot to clean up after the domain is torn down. And because they
> are kept, we don't regenerate them upn another start and because of
> that they contain old IDs in them.
>
> Again, the series is structured as with the
On 01.04.2016 19:54, Laine Stump wrote:
> The full description of the problem fixed by these patches is in patch
> 3/3. Basically, a recent patch changed the ordering of things during
> startup such that hostdev interfaces are given an alias named "netN"
> rather than the expected "hostdevN". That
On Sat, Apr 02, 2016 at 04:45:24PM +0200, Michal Privoznik wrote:
> Signed-off-by: Michal Privoznik
> ---
> AUTHORS | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/AUTHORS b/AUTHORS
> index c2af49a..cb96cdc 100644
> --- a/AUTHORS
> +++ b/AUTHORS
> @@ -13,5 +13,6 @@
On Sat, Apr 02, 2016 at 04:45:23PM +0200, Michal Privoznik wrote:
> For instance, on my system not just META.yml is produced by
> MYMETA.yml and MYMETA.json too. Also, if you happen to generate
> tags or use vim to edit the source code, you'll find some files
> useless to track in git.
>
>
On Sat, Apr 02, 2016 at 04:45:21PM +0200, Michal Privoznik wrote:
> It would be nice to have these in before the release.
>
> Michal Privoznik (3):
> Adapt to new virDomain{Get,Set}PerfEvents()
> gitignore: Add more files to ignore & reorder
> Add myself to AUTHORS
>
> .gitignore
On 03.04.2016 21:27, Martin Kletzander wrote:
> Laine found out that he can't do 'virsh nodedev-detach pci_dev'
> because of some strange error message. That was caused by my commit,
> but also by all the previous ones that skipped adding tests and
> parsing of new functions. In order for this
On Mon, Apr 04, 2016 at 07:12:50AM +0200, Michal Privoznik wrote:
On 03.04.2016 22:23, Martin Kletzander wrote:
It's the counterpart of qemuDomainSetPrivatePaths().
Signed-off-by: Martin Kletzander
---
src/qemu/qemu_domain.c | 10 ++
src/qemu/qemu_domain.h | 1
75 matches
Mail list logo