On Tue, Sep 18, 2018 at 5:45 PM, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
>
Reviewed-by: Fabiano Fidêncio
> ---
> src/util/vircgroup.c| 34 ++---
> src/util/vircgroupbackend.h | 12 +
> src/util/vircg
On Tue, Sep 18, 2018 at 5:45 PM, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
> ---
> src/util/vircgroup.c| 54 +-
> src/util/vircgroupbackend.h | 7
> src/util/vircgroupv1.c | 65 +
> 3 files changed, 73 in
On Tue, Sep 18, 2018 at 5:45 PM, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
>
Reviewed-by: Fabiano Fidêncio
> ---
> src/util/vircgroup.c| 36 +++---
> src/util/vircgroupbackend.h | 12 +
> src/util/vircgrouppriv.h| 6
On Tue, Sep 18, 2018 at 5:45 PM, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
>
Reviewed-by: Fabiano Fidêncio
> ---
> src/util/vircgroup.c| 83 ++
> src/util/vircgroupbackend.h | 9
> src/util/vircgrouppriv.h
On Tue, Sep 18, 2018 at 5:45 PM, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
>
Reviewed-by: Fabiano Fidêncio
> ---
> src/util/vircgroup.c| 14 ++
> src/util/vircgroupbackend.h | 20
> src/util/vircg
On Tue, Sep 18, 2018 at 5:45 PM, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
>
Reviewed-by: Fabiano Fidêncio
> ---
> src/util/vircgroup.c| 102 +---
> src/util/vircgroupbackend.h | 6 ++
> src/util/vircgr
On Tue, Sep 18, 2018 at 5:45 PM, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
>
Reviewed-by: Fabiano Fidêncio
> ---
> src/util/vircgroup.c| 48 +
> src/util/vircgroupbackend.h | 12 ++
> src/util/vircgrouppriv.h
On Tue, Sep 18, 2018 at 5:45 PM, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
>
Reviewed-by: Fabiano Fidêncio
> ---
> src/util/vircgroup.c| 3 ++-
> src/util/vircgroupbackend.h | 5 +
> src/util/vircgroupv1.c | 9 +
> 3 files changed
On Tue, Sep 18, 2018 at 5:45 PM, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
>
Reviewed-by: Fabiano Fidêncio
> ---
> src/util/vircgroup.c| 66 +
> src/util/vircgroupbackend.h | 5 +++
> src/util/vircg
On Tue, Sep 18, 2018 at 5:45 PM, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
>
Reviewed-by: Fabiano Fidêncio
> ---
> src/util/vircgroup.c| 32 +---
> src/util/vircgroupbackend.h | 5 +
> src/util/vircg
On Tue, Sep 18, 2018 at 5:45 PM, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
>
Reviewed-by: Fabiano Fidêncio
> ---
> src/util/vircgroup.c| 16
> src/util/vircgroupbackend.h | 4
> src/util/vircgroupv1.c | 22 +++
On Tue, Sep 18, 2018 at 5:45 PM, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
>
Reviewed-by: Fabiano Fidêncio
> ---
> src/util/vircgroup.c| 35 ++---
> src/util/vircgroupbackend.h | 4
> src/util/vircgrouppriv.h|
On Tue, Sep 18, 2018 at 5:45 PM, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
>
Reviewed-by: Fabiano Fidêncio
> ---
> src/util/vircgroup.c| 3 +--
> src/util/vircgroupbackend.h | 4
> src/util/vircgroupv1.c | 12
> 3 files changed
On Tue, Sep 18, 2018 at 5:45 PM, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
>
Reviewed-by: Fabiano Fidêncio
> ---
> src/util/vircgroup.c| 138 ++-
> src/util/vircgroupbackend.h | 14
> src/util/vircgr
On Tue, Sep 18, 2018 at 5:45 PM, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
>
Reviewed-by: Fabiano Fidêncio
> ---
> src/util/vircgroup.c| 22 +-
> src/util/vircgroupbackend.h | 7 +++
> src/util/vircg
On Tue, Sep 18, 2018 at 5:45 PM, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
>
Reviewed-by: Fabiano Fidêncio
> ---
> src/util/vircgroup.c| 13 +
> src/util/vircgroupbackend.h | 5 +
> src/util/vircgroupv1.c | 20
On Tue, Sep 18, 2018 at 5:45 PM, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
>
Reviewed-by: Fabiano Fidêncio
> ---
> src/util/vircgroup.c| 141 ++--
> src/util/vircgroupbackend.h | 15
> src/util/vircgrouppriv.h| 20
On Tue, Sep 18, 2018 at 5:45 PM, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
>
Reviewed-by: Fabiano Fidêncio
> ---
> src/util/vircgroup.c| 38 +
> src/util/vircgroupbackend.h | 6 ++
> src/util/vircg
On Tue, Sep 18, 2018 at 5:45 PM, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
>
Reviewed-by: Fabiano Fidêncio
> ---
> src/util/vircgroup.c| 85 +
> src/util/vircgroupbackend.h | 7 +++
> src/util/vircgrouppriv.h
On Tue, Sep 18, 2018 at 5:45 PM, Pavel Hrdina wrote:
> We need to update one test-case because now new cgroup object will be
> created only if there is any cgroup backend available.
>
> Signed-off-by: Pavel Hrdina
> ---
> src/util/vircgroup.c | 18 ++
> src/util/vircgrouppri
On Tue, Sep 18, 2018 at 5:45 PM, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
>
Reviewed-by: Fabiano Fidêncio
> ---
> src/util/vircgroup.c| 23 +--
> src/util/vircgroupbackend.h | 5 +
> src/util/vircgroupv1.c | 22 +
ms of the GNU Lesser General Public
> + * License as published by the Free Software Foundation; either
> + * version 2.1 of the License, or (at your option) any later version.
> + *
> + * This library is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY;
On Tue, Sep 18, 2018 at 5:45 PM, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
> ---
> src/util/vircgroup.c| 28 +---
> src/util/vircgroupbackend.h | 7 +++
> src/util/vircgroupv1.c | 35 +++
> 3 files changed, 51 ins
l Hrdina
>
Reviewed-by: Fabiano Fidêncio
> ---
> src/Makefile.am | 1 +
> src/libvirt_private.syms| 3 ++
> src/util/Makefile.inc.am| 2 ++
> src/util/vircgroupbackend.c | 64 +
> src/util/vircgroupbackend.h
t.com/mailman/listinfo/libvir-list
>
I went through your series and the patches are mostly looking there.
There are a few comments in the series related to some typos and an actual
problem in the last patch.
Please, do *not* push the reviewed patches already as I'd give them the
chance
(virCgroupDetectMountsFromFile(group, mounts, false) < 0)
> +if (virCgroupDetectMounts(group) < 0)
> goto cleanup;
>
> for (i = 0; i < VIR_CGROUP_CONTROLLER_LAST; i++) {
> @@ -196,7 +196,7 @@ testCgroupDetectMounts(const void *args)
> result = 0;
>
> cleanup:
> -VIR_FREE(mounts);
> +unsetenv("VIR_CGROUP_MOCK_FILENAME");
> VIR_FREE(parsed);
> virCgroupFree(&group);
> virBufferFreeAndReset(&buf);
> --
> 2.17.1
>
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
>
Reviewed-by: Fabiano Fidêncio
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Tue, Sep 18, 2018 at 2:17 PM, Pavel Hrdina wrote:
> Move all the cgroup data into separate files out of vircgroupmock.c
> and rework the fopen function to load data from files. This will
> make it easier to add more test cases.
>
> Signed-off-by: Pavel Hrdina
>
Re
t; virCgroupMakeGroup() takes that parent in order to inherit values
> for cpuset controller.
>
> By default cpuset controller is managed by systemd so we will never
> hit the issue but for v2 cgroups we need to use parent cgroup every
> time.
>
> Signed-off-by: Pave
oup, pid,
> +VIR_CGROUP_TASK_PROCESS |
> +VIR_CGROUP_TASK_SYSTEMD);
> }
>
>
> --
> 2.17.1
>
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
>
Reviewed-by: Fabiano Fidêncio
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Tue, Sep 18, 2018 at 2:18 PM, Pavel Hrdina wrote:
> This will be required once cgroup v2 is introduced. The cgroup
> detection is not simple and we will have multiple backends so we
> should not just jump into the middle of the detection code.
>
> In order to use virCgroupNewSelf we need to c
On Tue, Sep 18, 2018 at 2:17 PM, Pavel Hrdina wrote:
> Once we introduce cgroup v2 support we need to handle processes and
> threads differently.
>
> Signed-off-by: Pavel Hrdina
>
Reviewed-by: Fabiano Fidêncio
> ---
> src/libvirt_private.syms | 1 +
> src/q
On Tue, Sep 18, 2018 at 2:17 PM, Pavel Hrdina wrote:
> In cgroup v2 we need to handle processes and threads differently,
> following patch will introduce virCgroupAddThread.
>
> Signed-off-by: Pavel Hrdina
>
Reviewed-by: Fabiano Fidêncio
> ---
> src/libvirt-lxc.c
On Tue, Sep 18, 2018 at 2:17 PM, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
>
Reviewed-by: Fabiano Fidêncio
> ---
> tests/vircgroupmock.c | 73 ---
> 1 file changed, 73 deletions(-)
>
> diff --git a/tests/vi
On Tue, Sep 18, 2018 at 2:17 PM, Pavel Hrdina wrote:
> If virCgroupEnableMissingControllers() fails it could already create
> some directories, we should clean it up as well.
>
> Signed-off-by: Pavel Hrdina
>
Reviewed-by: Fabiano Fidêncio
> ---
> src/
xenConfigGetString returns a newly-allocated pointer and it has to be
freed by the caller.
Signed-off-by: Fabiano Fidêncio
---
src/xenconfig/xen_xl.c | 25 -
1 file changed, 16 insertions(+), 9 deletions(-)
diff --git a/src/xenconfig/xen_xl.c b/src/xenconfig/xen_xl.c
Signed-off-by: Fabiano Fidêncio
---
src/xenconfig/xen_common.c | 16 ++--
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/src/xenconfig/xen_common.c b/src/xenconfig/xen_common.c
index a35e1aff58..08fbfff44f 100644
--- a/src/xenconfig/xen_common.c
+++ b/src/xenconfig
xenConfigGetString returns a newly-allocated pointer and it has to be
freed by the caller.
Signed-off-by: Fabiano Fidêncio
---
src/xenconfig/xen_xm.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/src/xenconfig/xen_xm.c b/src/xenconfig/xen_xm.c
index a476401183
Signed-off-by: Fabiano Fidêncio
---
src/xenconfig/xen_common.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/src/xenconfig/xen_common.c b/src/xenconfig/xen_common.c
index 9ad081e56b..a6e77a9250 100644
--- a/src/xenconfig/xen_common.c
+++ b/src/xenconfig
on, this is the
closest to the original that we can get and it shouldn't change the
function behaviour.
Signed-off-by: Fabiano Fidêncio
---
src/xenconfig/xen_common.c | 23 +--
1 file changed, 13 insertions(+), 10 deletions(-)
diff --git a/src/xenconfig/xen_common.c
xenConfigGetString returns a newly-allocated pointer and it has to be
freed by the caller.
Signed-off-by: Fabiano Fidêncio
---
src/xenconfig/xen_xl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/xenconfig/xen_xl.c b/src/xenconfig/xen_xl.c
index cb1cab8482..7d86849feb 100644
--- a/src
xenConfigGetString returns a newly-allocated pointer and it has to be
freed by the caller.
Signed-off-by: Fabiano Fidêncio
---
src/xenconfig/xen_common.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/xenconfig/xen_common.c b/src/xenconfig/xen_common.c
index
xenConfigGetString returns a newly-allocated pointer and it has to be
freed by the caller.
Signed-off-by: Fabiano Fidêncio
---
src/xenconfig/xen_common.c | 50 +-
1 file changed, 28 insertions(+), 22 deletions(-)
diff --git a/src/xenconfig/xen_common.c b/src
xenConfigGetString returns a newly-allocated pointer and it has to be
freed by the caller.
Signed-off-by: Fabiano Fidêncio
---
src/xenconfig/xen_xm.c | 36
1 file changed, 20 insertions(+), 16 deletions(-)
diff --git a/src/xenconfig/xen_xm.c b/src/xenconfig
Signed-off-by: Fabiano Fidêncio
---
src/xenconfig/xen_common.c | 23 +++
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git a/src/xenconfig/xen_common.c b/src/xenconfig/xen_common.c
index a6e77a9250..786c276c99 100644
--- a/src/xenconfig/xen_common.c
+++ b/src
xenConfigGetString returns a newly-allocated pointer and it has to be
freed by the caller.
Signed-off-by: Fabiano Fidêncio
---
src/xenconfig/xen_common.c | 41 ++
1 file changed, 24 insertions(+), 17 deletions(-)
diff --git a/src/xenconfig/xen_common.c b/src
nction" touched. Some new patches were also needed
due to a behaviour change introduced by the "xen_common: Change
xenParsePCIList to using virConfGetValueStringList" patch.
Fabiano Fidêncio (15):
xen_common: Change xenConfigCopyStringInternal to using
virConfGetValueStri
xenConfigGetString returns a newly-allocated pointer and it has to be
freed by the caller.
Signed-off-by: Fabiano Fidêncio
---
src/xenconfig/xen_xl.c | 45 --
1 file changed, 26 insertions(+), 19 deletions(-)
diff --git a/src/xenconfig/xen_xl.c b/src
xenConfigGetString returns a newly-allocated pointer and it has to be
freed by the caller.
Signed-off-by: Fabiano Fidêncio
---
src/xenconfig/xen_common.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/src/xenconfig/xen_common.c b/src/xenconfig/xen_common.c
index
Signed-off-by: Fabiano Fidêncio
---
src/xenconfig/xen_common.c | 18 --
1 file changed, 4 insertions(+), 14 deletions(-)
diff --git a/src/xenconfig/xen_common.c b/src/xenconfig/xen_common.c
index 36a9d27c80..a35e1aff58 100644
--- a/src/xenconfig/xen_common.c
+++ b/src/xenconfig
tches.
Signed-off-by: Fabiano Fidêncio
---
src/xenconfig/xen_common.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/src/xenconfig/xen_common.c b/src/xenconfig/xen_common.c
index 08fbfff44f..c044cb9672 100644
--- a/src/xenconfig/xen_common.c
+++
John,
On Fri, Sep 14, 2018 at 5:04 PM, John Ferlan wrote:
>
>
> On 09/11/2018 08:59 AM, Fabiano Fidêncio wrote:
> > There are still a few places using virConfGetValue(), checking for the
> > specific type of the pointers and so on. However, those places are not
> &g
On Thu, Sep 13, 2018 at 4:38 PM, Andrea Bolognani
wrote:
> Functions that deal with virPCIDeviceAddress exclusively
> belong to util/virpci.
>
> Signed-off-by: Andrea Bolognani
>
Reviewed-by: Fabiano Fidêncio
> ---
> src/conf
Let's move those to their own newly created header (src/util/virmem.h)
as this will help us to easily start sharing the cgroup code that's
duplicated between QEMU and LXC.
Signed-off-by: Fabiano Fidêncio
---
src/conf/domain_conf.c | 11 +++
src/conf/domain_co
virCgroupSetupMemTune() has been introduced in order to remove the code
duplication present between virLXCCgroupSetupMemTune() and
qemuSetupMemoryCgroup().
Signed-off-by: Fabiano Fidêncio
---
src/libvirt_private.syms | 1 +
src/lxc/lxc_cgroup.c | 20 ++--
src/qemu
virCgroupSetupBlkioTune() has been introduced in order to remove the
code duplication present between virLXCCgroupSetupBlkioTune() and
qemuSetupBlkioCgroup().
Signed-off-by: Fabiano Fidêncio
---
src/libvirt_private.syms | 1 +
src/lxc/lxc_cgroup.c | 49
7;s nothing enforcing it, I do believe it's a good
practive that should be followed and I've checked with Andrea and
Peter about doing that and both agreed with the approach.
Fabiano Fidêncio (4):
domain_conf: split out virBlkioDevice and virDomainBlkiotune
definitions
d
Let's move those to their own newly created files
(src/util/virblkio.{c,h}) as this will help us to easily start sharing
the cgroup code that's duplicated between QEMU and LXC.
Signed-off-by: Fabiano Fidêncio
---
src/conf/domain_conf.c | 11 +
src/conf/domain_con
On Wed, Sep 12, 2018 at 12:29 PM, Andrea Bolognani
wrote:
> On Tue, 2018-09-11 at 09:36 +0200, Fabiano Fidêncio wrote:
> > Let's enable both media and tree uris tests in order to early catch URL
> > changes that need to be fixed in osinfo-db.
> >
> > Fabiano Fi
virCgroupSetupBlkioTune() has been introduced in order to remove the
code duplication present between virLXCCgroupSetupBlkioTune() and
qemuSetupBlkioCgroup().
Signed-off-by: Fabiano Fidêncio
---
src/libvirt_private.syms | 1 +
src/lxc/lxc_cgroup.c | 49
Let's move those to their own newly created files
(src/util/virblkio.{c,h}) as this will help us to easily start sharing
the cgroup code that's duplicated between QEMU and LXC.
Signed-off-by: Fabiano Fidêncio
---
src/Makefile.am | 1 +
src/conf/domain_conf.c | 11 +
virCgroupSetupMemTune() has been introduced in order to remove the code
duplication present between virLXCCgroupSetupMemTune() and
qemuSetupMemoryCgroup().
Signed-off-by: Fabiano Fidêncio
---
src/libvirt_private.syms | 1 +
src/lxc/lxc_cgroup.c | 20 ++--
src/qemu
Let's move those to their own newly created header (src/util/virmem.h)
as this will help us to easily start sharing the cgroup code that's
duplicated between QEMU and LXC.
Signed-off-by: Fabiano Fidêncio
---
src/conf/domain_conf.c | 11 +++
src/conf/domain_co
n solved now by partially following Michal's suggestion
and splitting the structs and functions that would be use in the
common code to new different files.
Fabiano Fidêncio (4):
domain_conf: split out virBlkioDevice and virDomainBlkiotune
definitions
domain_conf: split out
messages for whoever
has to debug this code path;
- Expanding virConfValue*() to support strings as other types (for
instance, as boolean or long) does not seem to be neither the safest nor
the preferential path to take.
Signed-off-by: Fabiano Fidêncio
---
src/xenconfig/xen_common.c | 163
r to lower the
non-whitespace changes in the first patch;
- Chages since v4:
All comments from Ján Tomko have been addressed (hopefully, they
actually were this time :-));
Fabiano Fidêncio (1):
xen_common: Convert to typesafe virConf acessors
src/xenconfi
Both media and tree uris tests are only run when LIBOSINFO_NETWORK_TESTS
is set.
Let's have those enabled in order to early catch URL changes in
osinfo-db.
Signed-off-by: Fabiano Fidêncio
---
guests/playbooks/build/projects/libosinfo.yml | 4
1 file changed, 4 insertions(+)
diff --
Let's enable both media and tree uris tests in order to early catch URL
changes that need to be fixed in osinfo-db.
Fabiano Fidêncio (2):
guests: Enable {media,tree}uris tests for libosinfo
projects: Enable {media,tree}uri tests for libosinfo
guests/playbooks/build/projects/libosinf
Both media and tree uris tests are only run when LIBOSINFO_NETWORK_TESTS
is set.
Let's have those enabled in order to early catch URL changes in
osinfo-db.
Signed-off-by: Fabiano Fidêncio
---
projects/libosinfo.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/projects/libosinfo
Fedora 26 has reached its EOL on May 29th 2018.
https://lists.fedoraproject.org/archives/list/annou...@lists.fedoraproject.org/message/XGG7GYUJN3VDA6HX4KJNFSKSQCGF2FMW/
Signed-off-by: Fabiano Fidêncio
---
libvirt.spec.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
On Mon, Sep 3, 2018 at 5:26 PM, Andrea Bolognani wrote:
> Please include a cover letter when sending more than a single
> patch to libvir-list.
>
> On Mon, 2018-09-03 at 15:02 +0200, Fabiano Fidêncio wrote:
> [...]
>> - include: '{{ playbook_base }}/jobs/autotools
Both media and tree uris tests are only run when LIBOSINFO_NETWORK_TESTS
is set.
Let's have those enabled in order to early catch URL changes in
osinfo-db.
Signed-off-by: Fabiano Fidêncio
---
projects/libosinfo.yaml | 4
1 file changed, 4 insertions(+)
diff --git a/pro
Both media and tree uris tests are only run when LIBOSINFO_NETWORK_TESTS
is set.
Let's have those enabled in order to early catch URL changes in
osinfo-db.
Signed-off-by: Fabiano Fidêncio
---
guests/playbooks/build/projects/libosinfo.yml | 5 +
1 file changed, 5 insertions(+)
diff --
st@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
Best Regards,
--
Fabiano Fidêncio
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
uota
> +with value 0 means no value. You can use this feature to ensure that
> all
> +vcpus run at the same speed.
> Only QEMU driver support since 0.9.4, LXC since
> 0.9.10
>
> --
> 2.17.1
>
> --
> libvir-list mailing list
> libvi
r to lower the
non-whitespace changes in the first patch;
Fabiano Fidêncio (2):
xen_common: Split per-Vif logic from xenParseVif()
xen_common: convert to typesafe virConf acessors
src/xenconfig/xen_common.c | 535 +++--
1 file changed, 273 insertio
;s basically the old xenParsePCI(), but now it
just iterates over the list of Vifs, calling xenParsePCI() per each Vif.
This patch is basically preparing the ground for the future when
typesafe virConf acessors will be used.
Signed-off-by: Fabiano Fidêncio
---
src/xenconfi
whoever
has to debug this code path;
- Expanding virConfValue*() to support strings as other types (for
instance, as boolean or long) does not seem to be the safest path to
take.
Signed-off-by: Fabiano Fidêncio
---
src/xenconfig/xen_common.c | 197 ++---
1
On Mon, Jun 11, 2018 at 3:34 PM, Ján Tomko wrote:
> On Mon, May 28, 2018 at 12:28:19AM +0200, Fabiano Fidêncio wrote:
>>
>> This patchset finishes the conversion to virConfGetValue* functions,
>> started by Daniel Berrange a few months ago.
>>
>> Please,
On Tue, Jun 5, 2018 at 4:16 PM, Michal Privoznik wrote:
> On 06/03/2018 08:09 PM, Fabiano Fidêncio wrote:
>> virCgroupSetupBlkiotune() has been introduced in order to remove the
>> code duplication present between virLXCCgroupSetupBlkioTune() and
>> qemuSetupBlkioCgroup()
virCgroupSetupMemtune() has been introduced in order to remove the code
duplication present between virLXCCgroupSetupMemTune() and
qemuSetupMemoryCgroup().
Signed-off-by: Fabiano Fidêncio
---
src/libvirt_private.syms | 1 +
src/lxc/lxc_cgroup.c | 20 ++--
src/qemu
virLXCCgroupSetupBlkioTune() and qemuSetupBlkioCgroup() and
virLXCCgroupSetupCpuTune() and qemuSetupCpuCgroup() are the most similar
functions between QEMU and LXC code.
Let's move their common code to virCgroup.
Fabiano Fidêncio (2):
vircgroup: Add virCgroupSetupBlkiotune()
vircgroup
virCgroupSetupBlkiotune() has been introduced in order to remove the
code duplication present between virLXCCgroupSetupBlkioTune() and
qemuSetupBlkioCgroup().
Signed-off-by: Fabiano Fidêncio
---
src/libvirt_private.syms | 1 +
src/lxc/lxc_cgroup.c | 49
On Mon, May 28, 2018 at 9:16 AM, Ján Tomko wrote:
> On Sun, May 27, 2018 at 02:08:58PM +0200, Fabiano Fidêncio wrote:
>>
>> On Sun, May 27, 2018 at 1:17 PM, Ján Tomko wrote:
>>>
>>> On Sat, May 26, 2018 at 11:00:27PM +0200, Fabiano Fidêncio wrote:
>
Signed-off-by: Fabiano Fidêncio
---
src/xenconfig/xen_xm.c | 26 +++---
1 file changed, 15 insertions(+), 11 deletions(-)
diff --git a/src/xenconfig/xen_xm.c b/src/xenconfig/xen_xm.c
index be50a13909..ef52cf4250 100644
--- a/src/xenconfig/xen_xm.c
+++ b/src/xenconfig
;s basically the old xenParsePCI(), but now it
just iterates over the list of PCIs, calling xenParsePCI() per each PCI.
This patch is basically preparing the ground for the future when
typesafe virConf acessors will be used.
Signed-off-by: Fabiano Fidêncio
---
src/xenconfi
whoever
has to debug this code path;
- Expanding virConfValue*() to support strings as other types (for
instance, as boolean or long) does not seem to be the safest path to
take.
Signed-off-by: Fabiano Fidêncio
---
src/xenconfig/xen_common.c | 197 ++---
1
;s basically the old xenParsePCI(), but now it
just iterates over the list of Vfis, calling xenParsePCI() per each Vfi.
This patch is basically preparing the ground for the future when
typesafe virConf acessors will be used.
Signed-off-by: Fabiano Fidêncio
---
src/xenconfi
uot;values" from virConfGetValueString() are freed
- Changes since v2:
All comments from Ján Tomko have been addressed;
A few leaks were (possibly) found and they're addressed in the last
patch of the series;
Fabiano Fidêncio (7):
xen_xm: Split the per-disk logic from xenParseXMDisk
While converting the functions of xen_common to use typesafe virConf
acessors, I've spotted a few memory leaks, which are fixed in this
patch.
Signed-off-by: Fabiano Fidêncio
---
src/xenconfig/xen_common.c | 22 +-
1 file changed, 13 insertions(+), 9 deletions(-)
diff
#x27;s basically the old xenParseXMDisk(), but
now it just iterates over the list of disks, calling xenParseXMDisk()
per each disk.
This patch is basically preparing the ground for the future when
typesafe virConf acessors will be used.
Signed-off-by: Fabiano Fidêncio
---
src/xenc
Signed-off-by: Fabiano Fidêncio
---
src/vmx/vmx.c | 194 +-
1 file changed, 70 insertions(+), 124 deletions(-)
diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c
index df6a58a474..b6df257144 100644
--- a/src/vmx/vmx.c
+++ b/src/vmx/vmx.c
On Sun, May 27, 2018 at 1:17 PM, Ján Tomko wrote:
> On Sat, May 26, 2018 at 11:00:27PM +0200, Fabiano Fidêncio wrote:
>>
>> From: Fabiano Fidêncio
>>
>> There are still some places using virConfGetValue() and then checking
>> the specific type of the pointers and
On Sun, May 27, 2018 at 1:02 PM, Ján Tomko wrote:
> On Sat, May 26, 2018 at 11:00:26PM +0200, Fabiano Fidêncio wrote:
>>
>> From: Fabiano Fidêncio
>>
>> Signed-off-by: Fabiano Fidêncio
>> ---
>> src/vmx/vmx.c | 196
>> ++-
On Sun, May 27, 2018 at 11:55 AM, Ján Tomko wrote:
> On Sat, May 26, 2018 at 11:00:25PM +0200, Fabiano Fidêncio wrote:
>>
>> From: Fabiano Fidêncio
>>
>> Signed-off-by: Fabiano Fidêncio
>
>
> The S-o-B address should match the one of the author.
Fixed
From: Fabiano Fidêncio
Signed-off-by: Fabiano Fidêncio
---
src/vmx/vmx.c | 196 ++
1 file changed, 73 insertions(+), 123 deletions(-)
diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c
index df6a58a474..54542c29a6 100644
--- a/src/vmx/vmx.c
From: Fabiano Fidêncio
There are still some places using virConfGetValue() and then checking
the specific type of the pointers and so on.
Those place are not going to be changed as:
- Directly using virConfGetValue*() would trigger virReportError() on
their current code
- Expanding
uot;values" from virConfGetValueString() are freed
Fabiano Fidêncio (3):
xen_vm: convert to typesafe virConf accessors
vmx: convert to typesafe virConf accessors
xen_common: convert to typesafe virConf accessors
src/vmx/vmx.c | 196 ++
src/xenconfig/xen
From: Fabiano Fidêncio
Signed-off-by: Fabiano Fidêncio
---
src/xenconfig/xen_xm.c | 268 -
1 file changed, 132 insertions(+), 136 deletions(-)
diff --git a/src/xenconfig/xen_xm.c b/src/xenconfig/xen_xm.c
index 4becb40b4c..fc88ac8238 100644
--- a
On Fri, May 25, 2018 at 3:27 PM, Fabiano Fidêncio wrote:
> This patchset finishes the conversion to virConfGetValue* functions,
> started by Daniel Berrange a few months ago.
>
> Please, mind that although we could make virConfGetValue* functions more
> generic in order to supp
. The side-effect of this is that we
will have to live with some specific code doing that as part of vmx and
xen_common.
Fabiano Fidêncio (3):
xen_vm: convert to typesafe virConf accessors
vmx: convert to typesafe virConf accessors
xen_common: convert to typesafe virConf accessors
src/vmx/
501 - 600 of 626 matches
Mail list logo
