Changes himidtom to highmidtom. (issue4633064)

2011-06-22 Thread mtsolo
Reviewers: , Message: Pretty self explanatory - it seems to be in keeping w/ the other tom names. Cheers, MS Description: Changes himidtom to highmidtom. Please review this at http://codereview.appspot.com/4633064/ Affected files: M Documentation/included/percussion-chart.ly M ly/drumpitc

Re: New breve rest with ledger lines (issue4650052)

2011-06-22 Thread k-ohara5a5a
What is required to demonstrate this ? I thought of \relative c'' { \override Staff.NoteHead #'style = #'mensural \override Staff.Rest #'style = #'mensural \time 4/2 << { g'1\rest b1\rest g\breve\rest b\breve\rest d\breve\rest } \\ { c,1 r2 r4 r4 r\breve r\breve r\breve } >>

New breve rest with ledger lines (issue4650052)

2011-06-22 Thread bordage . bertrand
Reviewers: , Message: Minor patch that adds a useful glyph for baroque music. Description: New breve rest with ledger lines Please review this at http://codereview.appspot.com/4650052/ Affected files: M lily/rest.cc M mf/feta-rests.mf Index: lily/rest.cc diff --git a/lily/rest.cc b/lily/

Re: ambitus: special handling of small ambits' lines (issue4609041)

2011-06-22 Thread n . puttock
Hi Janek, I'd be much happier with this change if you used a callback for 'gap instead of inserting new code into the print function. That way it's easy for users to override the default behaviour without adding more properties. Cheers, Neil http://codereview.appspot.com/4609041/

Re: Attaches bound info to beam for better normalized-endpoint calculations. (issue4605047)

2011-06-22 Thread m...@apollinemike.com
On Jun 23, 2011, at 12:31 AM, Neil Puttock wrote: > On 22 June 2011 22:48, m...@apollinemike.com wrote: > >> In this present case, I could see the bound info being calculated via a >> callback that fetches the 'quantized position property for the Y values, but >> the X values would still need

Re: Attaches bound info to beam for better normalized-endpoint calculations. (issue4605047)

2011-06-22 Thread Neil Puttock
On 22 June 2011 22:48, m...@apollinemike.com wrote: > In this present case, I could see the bound info being calculated via a > callback that fetches the 'quantized position property for the Y values, but > the X values would still need to be calculated by consulting the normal stems > à la li

Re: GOP-PROP 3: C++ formatting

2011-06-22 Thread Carl Sorensen
On 6/22/11 3:53 PM, "Graham Percival" wrote: > On Wed, Jun 22, 2011 at 01:34:42PM +0200, Jan Warchoł wrote: >> 2011/6/22 Graham Percival : >>> There are plenty of differences.  If you get the git diff command >>> to work, you'll see. >> >> It still doesn't work. I'm in top source directory, on b

Re: Current state of automatic footnotes. (issue4580041)

2011-06-22 Thread n . puttock
Hi Mike, I'll take a closer look at this at the weekend. Cheers, Neil http://codereview.appspot.com/4580041/diff/10001/input/regression/footnote-auto-numbering-page-reset.ly File input/regression/footnote-auto-numbering-page-reset.ly (right): http://codereview.appspot.com/4580041/diff/10001/i

Re: GOP-PROP 2: mentors and Frogs - probably decision

2011-06-22 Thread Graham Percival
On Wed, Jun 22, 2011 at 12:11:36PM -0600, Carl Sorensen wrote: > On 6/22/11 10:09 AM, "Jan Warchoł" > wrote: > > > I don't want to suggest laying implied obligations on anyone. > > Maybe there's a misunderstanding, so let's make things clear: do you > > say that asking Mike (who wrote automatic b

Re: GOP-PROP 3: C++ formatting

2011-06-22 Thread Graham Percival
On Wed, Jun 22, 2011 at 01:34:42PM +0200, Jan Warchoł wrote: > 2011/6/22 Graham Percival : > > There are plenty of differences.  If you get the git diff command > > to work, you'll see. > > It still doesn't work. I'm in top source directory, on branch master > which is up to date (and git diff ori

Re: Attaches bound info to beam for better normalized-endpoint calculations. (issue4605047)

2011-06-22 Thread m...@apollinemike.com
On Jun 22, 2011, at 11:40 PM, Neil Puttock wrote: > On 16 June 2011 08:18, wrote: > >> left-bound-info and right-bound-info are calculated at the beginning of >> Line_spanner::print, so this setting of Beam properties, albeit late in >> the game, would be in keeping with the stage at which thes

Re: Attaches bound info to beam for better normalized-endpoint calculations. (issue4605047)

2011-06-22 Thread Neil Puttock
On 16 June 2011 08:18, wrote: > left-bound-info and right-bound-info are calculated at the beginning of > Line_spanner::print, so this setting of Beam properties, albeit late in > the game, would be in keeping with the stage at which these properties > are calculated in the Line_spanner. They'r

Re: enharmonic problem with \transpose - should we modify it?

2011-06-22 Thread Janek Warchoł
Hi, 2011/6/20 Benkő Pál : > hi Janek, > > well, it was nastier than I thought because of the current pitch > representation, > so I haven't done it as a patch but a standalone hack; there's also a > non-standard (E31) example. > > [...] > 2011/6/21 Felipe Gonçalves Assis : > Enharmonicity is just

Re: GOP-PROP 2: mentors and Frogs - probably decision

2011-06-22 Thread Carl Sorensen
On 6/22/11 10:09 AM, "Jan Warchoł" wrote: > 2011/6/22 Graham Percival : >> On Wed, Jun 22, 2011 at 04:06:17PM +0200, Jan Warchoł wrote: >>> Problem 1: a Frog tries to modify wind diagrams code and experiences >>> some difficulties.  (S)he sends an e-mail to -devel, but gets no >>> answers because

Re: GOP-PROP 2: mentors and Frogs - probably decision

2011-06-22 Thread Jan Warchoł
2011/6/22 Graham Percival : > On Wed, Jun 22, 2011 at 04:06:17PM +0200, Jan Warchoł wrote: >> Problem 1: a Frog tries to modify wind diagrams code and experiences >> some difficulties.  (S)he sends an e-mail to -devel, but gets no >> answers because developer X (who wrote that code) overlooked his/

Re: Current state of automatic footnotes. (issue4580041)

2011-06-22 Thread mtsolo
On 2011/06/21 09:17:25, Graham Percival wrote: I can confirm the "cannot compile with this patch applied". Should apply cleanly - please confirm & leave your comments! Cheers, MS http://codereview.appspot.com/4580041/ ___ lilypond-devel mailing lis

Re: GOP-PROP 2: mentors and Frogs - probably decision

2011-06-22 Thread Jan Warchoł
More ideas. Problem 1: a Frog tries to modify wind diagrams code and experiences some difficulties. (S)he sends an e-mail to -devel, but gets no answers because developer X (who wrote that code) overlooked his/her e-mail, and noone else knows the answer. Solution: a list of developers with "specia

Re: Attaches bound info to beam for better normalized-endpoint calculations. (issue4605047)

2011-06-22 Thread mtsolo
On 2011/06/16 07:18:30, MikeSol wrote: On 2011/06/15 21:50:51, Neil Puttock wrote: > http://codereview.appspot.com/4605047/diff/1/lily/beam.cc > File lily/beam.cc (right): > > http://codereview.appspot.com/4605047/diff/1/lily/beam.cc#newcode564 > lily/beam.cc:564: + last_normal_stem (me)->extent

Re: GOP-PROP 2: mentors and Frogs - probably decision

2011-06-22 Thread Graham Percival
On Wed, Jun 22, 2011 at 04:06:17PM +0200, Jan Warchoł wrote: > Problem 1: a Frog tries to modify wind diagrams code and experiences > some difficulties. (S)he sends an e-mail to -devel, but gets no > answers because developer X (who wrote that code) overlooked his/her > e-mail, and noone else know

Re: Question: 'External references' in compiled scheme files when moving to Guile V2 from V1.8.7

2011-06-22 Thread Andy Wingo
On Tue 21 Jun 2011 22:07, Ian Hulin writes: > My question is this: > some of the .scm files in the list make references to definitions in a > .scm file loaded previously; When we compile this list of .scm files, > will we need to load each .go file produced immediately after compiling > it

Re: GOP-PROP 3: C++ formatting

2011-06-22 Thread Jan Warchoł
2011/6/22 Graham Percival : > On Wed, Jun 22, 2011 at 12:54:15AM +, Keith OHara wrote: >> Graham Percival percival-music.ca> writes: >> >> > My preference is just to say >> > "let’s just use fixcc.py strictly". >> >> Even those of us who fear emacs could probably run that script on changed .cc

Re: GOP-PROP 3: C++ formatting

2011-06-22 Thread Jan Warchoł
2011/6/22 Graham Percival : > On Wed, Jun 22, 2011 at 08:10:50AM +0200, Jan Warchoł wrote: >> I'm confused.  Are we talking about choosing indent style or choosing >> the tool that will automatically apply whichever style we want? > > Specifying a code style would be far too much work, and/or would

Re: GOP-PROP 2: mentors and Frogs - probably decision

2011-06-22 Thread Graham Percival
On Wed, Jun 22, 2011 at 07:53:09AM +0200, Jan Warchoł wrote: > 2011/6/18 Graham Percival : > > Maybe we'll just dump all newcomers on Janek? > > What's the status of this suggestion? I didn't notice any serious > discussion about it. There wasn't any. > (i mean, what are your opinions? I don't

Re: GOP-PROP 3: C++ formatting

2011-06-22 Thread Graham Percival
On Wed, Jun 22, 2011 at 08:10:50AM +0200, Jan Warchoł wrote: > 2011/6/22 Graham Percival : > > I see three main contenders: > > I'm confused. Are we talking about choosing indent style or choosing > the tool that will automatically apply whichever style we want? Specifying a code style would be

Re: GOP-PROP 3: C++ formatting

2011-06-22 Thread Graham Percival
On Wed, Jun 22, 2011 at 12:54:15AM +, Keith OHara wrote: > Graham Percival percival-music.ca> writes: > > > My preference is just to say > > "let’s just use fixcc.py strictly". > > Even those of us who fear emacs could probably run that script on changed .cc > .hh files before each commit.

Re: GOP-PROP 3: C++ formatting

2011-06-22 Thread Hans Aberg
On 22 Jun 2011, at 01:30, Graham Percival wrote: > ** Eliminate tabs > > I’m going to make the bold step of assuming that we will eliminate > tabs in all C++ files. I personally like the idea of tabs, but > from an examination of source code styles (both official and > unofficial) in various proj

Re: GOP-PROP 3: C++ formatting

2011-06-22 Thread Trevor Daniels
Graham Percival wrote Wednesday, June 22, 2011 12:30 AM Another problem is that the scripts/auxiliar/fixcc.py depends on emacs, but emacs’ formatting changes between versions. ** Eliminate tabs I’m going to make the bold step of assuming that we will eliminate tabs in all C++ files. I person