Re: Issue #1204: Document, and add regtest for, external fonts. (issue 557640051 by v.villen...@gmail.com)

2020-04-20 Thread Valentin Villenave
On 4/19/20, David Kastrup wrote: > However, there are a few > other problems with that regtest that should likely show with Guile-2 > (sometimes?). Could you elaborate as to what I need to watch out for? I’ve tested it successfully with Guile 2.2 here (but history has teached us that unforeseen s

Re: Issue #1204: Document, and add regtest for, external fonts. (issue 557640051 by v.villen...@gmail.com)

2020-04-20 Thread Jonas Hahnfeld
Am Sonntag, den 19.04.2020, 23:24 +0200 schrieb David Kastrup: > Jonas Hahnfeld writes: > > To avoid this from happening again, can we please have the rule that > > whoever reverts a commit or backs it out of staging is to provide > > guidance on what's actually wrong? My feeling is that we could

Re: Issue #1204: Document, and add regtest for, external fonts. (issue 557640051 by v.villen...@gmail.com)

2020-04-19 Thread David Kastrup
Valentin Villenave writes: > On 4/19/20, David Kastrup wrote: >> At that day I was having one patchy run after the other and I did go >> through the log files to indicate the failed file and the error message. > > Yep, and I asked for additional info both on the tracker and on > Rietveld; the on

Re: Issue #1204: Document, and add regtest for, external fonts. (issue 557640051 by v.villen...@gmail.com)

2020-04-19 Thread Valentin Villenave
On 4/19/20, David Kastrup wrote: > At that day I was having one patchy run after the other and I did go > through the log files to indicate the failed file and the error message. Yep, and I asked for additional info both on the tracker and on Rietveld; the only reply I did get was from James who

Re: Issue #1204: Document, and add regtest for, external fonts. (issue 557640051 by v.villen...@gmail.com)

2020-04-19 Thread David Kastrup
Jonas Hahnfeld writes: > Am Sonntag, den 19.04.2020, 22:16 +0200 schrieb David Kastrup: >> pkx1...@posteo.net >> writes: >> >> > Hello, >> > >> > On 19/04/2020 17:53, David Kastrup wrote: >> > > v.villen...@gmail.com >> > > writes: >> > > >> > > > On 2020/04/11 09:44:26, Valentin Villenave w

Re: Issue #1204: Document, and add regtest for, external fonts. (issue 557640051 by v.villen...@gmail.com)

2020-04-19 Thread Jonas Hahnfeld
Am Sonntag, den 19.04.2020, 22:16 +0200 schrieb David Kastrup: > pkx1...@posteo.net > writes: > > > Hello, > > > > On 19/04/2020 17:53, David Kastrup wrote: > > > v.villen...@gmail.com > > > writes: > > > > > > > On 2020/04/11 09:44:26, Valentin Villenave wrote: > > > > > What could be the cau

Re: Issue #1204: Document, and add regtest for, external fonts. (issue 557640051 by v.villen...@gmail.com)

2020-04-19 Thread David Kastrup
pkx1...@posteo.net writes: > Hello, > > On 19/04/2020 17:53, David Kastrup wrote: >> v.villen...@gmail.com writes: >> >>> On 2020/04/11 09:44:26, Valentin Villenave wrote: What could be the cause? >>> So, pushed as >>> https://git.savannah.gnu.org/cgit/lilypond.git/commit/?id=0cfef7069e86f85a

Re: Issue #1204: Document, and add regtest for, external fonts. (issue 557640051 by v.villen...@gmail.com)

2020-04-19 Thread pkx166h
Hello, On 19/04/2020 17:53, David Kastrup wrote: v.villen...@gmail.com writes: On 2020/04/11 09:44:26, Valentin Villenave wrote: What could be the cause? So, pushed as https://git.savannah.gnu.org/cgit/lilypond.git/commit/?id=0cfef7069e86f85ad392f5c4bc63f6c4801aa2c9 V. https://codereview.a

Re: Issue #1204: Document, and add regtest for, external fonts. (issue 557640051 by v.villen...@gmail.com)

2020-04-19 Thread Valentin Villenave
On 4/19/20, David Kastrup wrote: > v.villen...@gmail.com writes: > Breaks my patchy again. Whose patchy was comfortable moving it from > staging to master? Well, at any rate James’ patchy what fine with it. (As it went through the review/countdown process not just once but twice.) The regtest a

Re: Issue #1204: Document, and add regtest for, external fonts. (issue 557640051 by v.villen...@gmail.com)

2020-04-19 Thread David Kastrup
v.villen...@gmail.com writes: > On 2020/04/11 09:44:26, Valentin Villenave wrote: >> What could be the cause? > > So, pushed as > https://git.savannah.gnu.org/cgit/lilypond.git/commit/?id=0cfef7069e86f85ad392f5c4bc63f6c4801aa2c9 > > V. > > https://codereview.appspot.com/557640051/ Breaks my patch

Re: Issue #1204: Document, and add regtest for, external fonts. (issue 557640051 by v.villen...@gmail.com)

2020-04-19 Thread v . villenave
On 2020/04/11 09:44:26, Valentin Villenave wrote: > What could be the cause? So, pushed as https://git.savannah.gnu.org/cgit/lilypond.git/commit/?id=0cfef7069e86f85ad392f5c4bc63f6c4801aa2c9 V. https://codereview.appspot.com/557640051/

Re: Issue #1204: Document, and add regtest for, external fonts. (issue 557640051 by v.villen...@gmail.com)

2020-04-11 Thread v . villenave
https://codereview.appspot.com/557640051/diff/565870043/input/regression/font-name-add-files.ly File input/regression/font-name-add-files.ly (right): https://codereview.appspot.com/557640051/diff/565870043/input/regression/font-name-add-files.ly#newcode244 input/regression/font-name-add-files.ly

Re: Issue #1204: Document, and add regtest for, external fonts. (issue 557640051 by v.villen...@gmail.com)

2020-03-30 Thread v . villenave
On 2020/03/30 18:56:27, thomasmorley651 wrote: > tmpnam is deprecated in guile-3.0.2 (sigh) Nice catch! > Why introducing it, we would need to move away from it later anyway? Well, I *would* have used mkstemp, but I need to create a directory (rather than a file), and there’s no mkdtemp in Guile

Re: Issue #1204: Document, and add regtest for, external fonts. (issue 557640051 by v.villen...@gmail.com)

2020-03-30 Thread thomasmorley65
On 2020/03/30 18:29:37, Valentin Villenave wrote: > On 2020/03/30 16:06:08, lemzwerg wrote: > > Is it guaranteed that we can create this directory? What about srcdir != > > builddir? > > Yes. It’s a (tmpnam) name, located in /tmp or $TMPDIR or whatever: > https://www.gnu.org/software/guile/manua

Re: Issue #1204: Document, and add regtest for, external fonts. (issue 557640051 by v.villen...@gmail.com)

2020-03-30 Thread v . villenave
Reviewers: lemzwerg, Message: On 2020/03/30 16:06:08, lemzwerg wrote: > Is it guaranteed that we can create this directory? What about srcdir != > builddir? Yes. It’s a (tmpnam) name, located in /tmp or $TMPDIR or whatever: https://www.gnu.org/software/guile/manual/html_node/File-System.html#in

Issue #1204: Document, and add regtest for, external fonts. (issue 557640051 by v.villen...@gmail.com)

2020-03-30 Thread lemzwerg--- via Discussions on LilyPond development
Nice idea, thanks. Some nits and questions. https://codereview.appspot.com/557640051/diff/571940043/Documentation/notation/text.itely File Documentation/notation/text.itely (right): https://codereview.appspot.com/557640051/diff/571940043/Documentation/notation/text.itely#newcode1552 Documentati