Re: tfp410 and i2c_bus_num

2012-11-16 Thread Tomi Valkeinen
On 2012-11-16 20:21, Felipe Balbi wrote: > Hi, > > On Fri, Nov 16, 2012 at 05:39:44PM +0200, Tomi Valkeinen wrote: > To be fair, the whole i2c_bus_num looks like a big hackery introduced by > the way panel drivers are written for OMAP DSS. > > TFP410 is an I2C client, not an OMAPDS

tfp410 and i2c_bus_num (was: Re: [PATCH] OMAP: board-files: fix i2c_bus for tfp410)

2012-11-16 Thread Felipe Balbi
Hi, On Fri, Nov 16, 2012 at 05:39:44PM +0200, Tomi Valkeinen wrote: > >>> To be fair, the whole i2c_bus_num looks like a big hackery introduced by > >>> the way panel drivers are written for OMAP DSS. > >>> > >>> TFP410 is an I2C client, not an OMAPDSS client. After a quick look at > >>> the drive

Re: [PATCH v3 0/3] i2c: at91: add dma support

2012-11-16 Thread Wolfram Sang
Hi Ludovic, > Here is the third version taking into account your feedback. Thanks, looks mostly good. I have problems applying patch 3. What is this series based against? > Patch 1/3 should go into v3.7. No, not necessarily. It is not really a bugfix, and it is probably too late in the cycle fo

Re: [PATCH v3 3/5] i2c: i2c-mpc: make I2C bus speed configurable

2012-11-16 Thread Timur Tabi
Wolfram Sang wrote: > Ping. Somebody wants to send a patch? I already have a patch that fixes it, I just want confirmation that I'm right first. -- Timur Tabi Linux kernel developer at Freescale -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to

Re: [PATCH] OMAP: board-files: fix i2c_bus for tfp410

2012-11-16 Thread Tomi Valkeinen
On 2012-11-16 17:19, Felipe Balbi wrote: > Hi, > > On Fri, Nov 16, 2012 at 04:27:01PM +0200, Tomi Valkeinen wrote: >> On 2012-11-16 15:51, Felipe Balbi wrote: >>> Hi, >>> >>> On Fri, Nov 16, 2012 at 02:22:33PM +0200, Tomi Valkeinen wrote: The i2c handling in tfp410 driver, which handles conve

Re: [PATCH] i2c: mxs: Handle i2c DMA failure properly

2012-11-16 Thread Fabio Estevam
Hi Tim, On Fri, Nov 16, 2012 at 1:24 PM, Tim Michals wrote: > My suggestion was to always clear the DMA in the reset i2c code. This way > if there is an error reported from the ISR or a timeout, it always clears > it. I've tested this approach with I2C devices connected and and doing a > i2cde

Re: [PATCH] OMAP: board-files: fix i2c_bus for tfp410

2012-11-16 Thread Felipe Balbi
Hi, On Fri, Nov 16, 2012 at 04:27:01PM +0200, Tomi Valkeinen wrote: > On 2012-11-16 15:51, Felipe Balbi wrote: > > Hi, > > > > On Fri, Nov 16, 2012 at 02:22:33PM +0200, Tomi Valkeinen wrote: > >> The i2c handling in tfp410 driver, which handles converting parallel RGB > >> to DVI, was changed in

Re: [PATCH v6 0/2] i2c: i2c-ocores: Add support for sparc, custom set and get functions, and the GRLIB port of the controller

2012-11-16 Thread Wolfram Sang
On Thu, Nov 15, 2012 at 04:50:57PM +0100, Andreas Larsson wrote: > On sparc, irqs are not present as an IORESOURCE in the struct platform_device > representation. By using platform_get_irq instead of platform_get_resource the > driver works for sparc. > > The GRLIB port of the ocores i2c controlle

Re: [PATCH v3] i2c-hid: introduce HID over i2c specification implementation

2012-11-16 Thread Benjamin Tissoires
On Thu, Nov 15, 2012 at 3:04 PM, Benjamin Tissoires wrote: > On Thu, Nov 15, 2012 at 2:51 PM, Jiri Kosina wrote: >> On Mon, 12 Nov 2012, Benjamin Tissoires wrote: >> >>> Microsoft published the protocol specification of HID over i2c: >>> http://msdn.microsoft.com/en-us/library/windows/hardware/hh

Re: [PATCH] OMAP: board-files: fix i2c_bus for tfp410

2012-11-16 Thread Tomi Valkeinen
On 2012-11-16 15:51, Felipe Balbi wrote: > Hi, > > On Fri, Nov 16, 2012 at 02:22:33PM +0200, Tomi Valkeinen wrote: >> The i2c handling in tfp410 driver, which handles converting parallel RGB >> to DVI, was changed in 958f2717b84e88bf833d996997fda8f73276f2af. The > > commit summary should be added

Re: [PATCHv3] i2c: omap: Move the remove constraint

2012-11-16 Thread Wolfram Sang
On Thu, Nov 15, 2012 at 02:19:21PM +0530, Shubhrajyoti D wrote: > Currently we just queue the transfer and release the > qos constraints, however we do not wait for the transfer > to complete to release the constraint. Move the remove > constraint after the bus busy as we are sure that the > transf

Re: [PATCH] i2c: mxs: Handle i2c DMA failure properly

2012-11-16 Thread Wolfram Sang
Tim, On Wed, Nov 14, 2012 at 09:34:27PM -0600, Tim Michals wrote: >This patch >�@@ -150,8 +150,6 @@ static void mxs_i2c_reset(struct mxs_i2c >� writel(i2c->speed->timing2, i2c->regs + MXS_I2C_TIMING2); >� >� writel(MXS_I2C_IRQ_MASK << 8, i2c->regs + MXS_I2C_CTRL1_SE

Re: [PATCH 2/2] ARM: dts: cfa10049: Add the i2c muxer buses to the CFA-10049

2012-11-16 Thread Shawn Guo
On Fri, Nov 16, 2012 at 09:32:18AM +0100, Wolfram Sang wrote: > On Thu, Oct 25, 2012 at 06:23:54PM +0200, Maxime Ripard wrote: > > This will allow to add the 3 Nuvoton NAU7802 ADCs and the NXP PCA9555 > > GPIO expander eventually. > > > > Signed-off-by: Maxime Ripard > > Shawn, I pushed the need

Re: [PATCH 2/2] ARM: dts: cfa10049: Add the i2c muxer buses to the CFA-10049

2012-11-16 Thread Wolfram Sang
On Fri, Nov 16, 2012 at 10:25:32PM +0800, Shawn Guo wrote: > On Fri, Nov 16, 2012 at 09:32:18AM +0100, Wolfram Sang wrote: > > On Thu, Oct 25, 2012 at 06:23:54PM +0200, Maxime Ripard wrote: > > > This will allow to add the 3 Nuvoton NAU7802 ADCs and the NXP PCA9555 > > > GPIO expander eventually. >

Re: [PATCH] OMAP: board-files: fix i2c_bus for tfp410

2012-11-16 Thread Felipe Balbi
Hi, On Fri, Nov 16, 2012 at 02:22:33PM +0200, Tomi Valkeinen wrote: > The i2c handling in tfp410 driver, which handles converting parallel RGB > to DVI, was changed in 958f2717b84e88bf833d996997fda8f73276f2af. The commit summary should be added in () after commit hash. This would look like: 'was

Re: [PATCH 11/11] i2c: pxa: no need slave addr for i2c master mode reset

2012-11-16 Thread Wolfram Sang
Hi, On Thu, Nov 08, 2012 at 06:25:24AM -0800, Leo Song wrote: > Would you please help to review and merge these 11 patches for > drivers/i2c/busses/i2c-pxa.c? There are already a few formal things: - For large series, please write a cover-letter describing the series in total (use --cover-let

Re: [PATCH v3 3/5] i2c: i2c-mpc: make I2C bus speed configurable

2012-11-16 Thread Wolfram Sang
On Wed, Nov 07, 2012 at 10:40:47AM -0600, Timur Tabi wrote: > Wolfgang, > > I know it's been 3 1/2 years since you wrote this code, but I think I > found a bug. > > On Tue, Apr 7, 2009 at 3:20 AM, Wolfgang Grandegger > wrote: > > This patch makes the I2C bus speed configurable by using the I2C

Re: [PATCH] i2c: s3c2410: Add fix for i2c suspend/resume

2012-11-16 Thread Wolfram Sang
On Fri, Nov 16, 2012 at 12:46:17PM +0100, Wolfram Sang wrote: > On Wed, Nov 14, 2012 at 09:10:33AM +0530, Abhilash Kesavan wrote: > > Hi, > > > > Any comments on this fix ? > > Yes, I agree with Shubhrajyoti here and the code should be refactored so > that gpio initialization is only done once at

Re: [PATCH 0/4] i2c-s3c2410: Fix a bug and optimize code

2012-11-16 Thread Wolfram Sang
On Thu, Nov 15, 2012 at 05:43:29PM +0530, Naveen Krishna Chatradhi wrote: > The following set of patches fixes a bug in i2c-s3c2410 driver > with respect to the functioning of dedicated HDMIPHY channel. > 1. Removing unwanted spinlock > 2. Correcting the Stop sequence > 3. Optimizing the wait loop

Re: [PATCH] i2c: i2c-s3c2410: Add support for pinctrl

2012-11-16 Thread Wolfram Sang
On Tue, Nov 13, 2012 at 11:33:40AM +0100, Tomasz Figa wrote: > This patch adds support for pin configuration using pinctrl subsystem > to the i2c-s3c2410 driver. > > Signed-off-by: Tomasz Figa > Signed-off-by: Kyungmin Park Applied to for-next, thanks! -- Pengutronix e.K.

Re: [PATCH] i2c: s3c2410: Add fix for i2c suspend/resume

2012-11-16 Thread Wolfram Sang
On Wed, Nov 14, 2012 at 09:10:33AM +0530, Abhilash Kesavan wrote: > Hi, > > Any comments on this fix ? Yes, I agree with Shubhrajyoti here and the code should be refactored so that gpio initialization is only done once at probe-time unless there is a real reason to do at suspend/resume. Thanks,

Re: [PATCH 2/2] i2c-s3c2410: Convert to devm_request_and_ioremap()

2012-11-16 Thread Wolfram Sang
On Mon, Nov 05, 2012 at 09:33:39AM +0100, Mark Brown wrote: > A small code saving and less error handling to worry about. > > Signed-off-by: Mark Brown Applied to for-next, thanks! -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions

Re: [PATCH 1/2] i2c-s3c2410: Refactor ifdefs for PM_SLEEP

2012-11-16 Thread Wolfram Sang
On Mon, Nov 05, 2012 at 09:33:38AM +0100, Mark Brown wrote: > Use the PM_SLEEP ifdef for system suspend and resume. This is partly > in preparation for adding runtime operations and partly because a user > may in theory choose to enable runtime suspend but not system suspend. > > Signed-off-by: Ma

Re: [RESEND PATCH v3 1/4] i2c: introduce i2c-cbus driver

2012-11-16 Thread Wolfram Sang
On Mon, Nov 12, 2012 at 09:08:42PM +0200, Aaro Koskinen wrote: > Add i2c driver to enable access to devices behind CBUS on Nokia Internet > Tablets. > > The patch also adds CBUS I2C configuration for N8x0 which is one of the > users of this driver. > > Cc: linux-i2c@vger.kernel.org > Acked-by: Fe

Re: [PATCH 0/5] i2c-sh_mobile non-urgent changes

2012-11-16 Thread Shinya Kuribayashi
On 11/16/2012 5:07 PM, Wolfram Sang wrote: > Looks good to me, like the extensive patch descriptions. I am going to > apply it to for-next with patches 2+3 squashed, because after patch 2 we > would have a buggy state otherwise. Let me know if you are not okay with > that. It's not that buggy as y

Re: [PATCH 2/2] ARM: dts: cfa10049: Add the i2c muxer buses to the CFA-10049

2012-11-16 Thread Wolfram Sang
On Thu, Oct 25, 2012 at 06:23:54PM +0200, Maxime Ripard wrote: > This will allow to add the 3 Nuvoton NAU7802 ADCs and the NXP PCA9555 > GPIO expander eventually. > > Signed-off-by: Maxime Ripard Shawn, I pushed the needed code to my for-next now. So you could apply this patch for 3.8 or give an

Re: [PATCH 1/2] i2c: mux: Add dt support to i2c-mux-gpio driver

2012-11-16 Thread Wolfram Sang
On Thu, Oct 25, 2012 at 06:23:53PM +0200, Maxime Ripard wrote: > Allow the i2c-mux-gpio to be used by a device tree enabled device. The > bindings are inspired by the one found in the i2c-mux-pinctrl driver. > > Signed-off-by: Maxime Ripard > Reviewed-by: Stephen Warren > Acked-by: Peter Korsgaa

Re: [PATCH 0/5] i2c-sh_mobile non-urgent changes

2012-11-16 Thread Wolfram Sang
On Wed, Oct 24, 2012 at 07:55:59PM +0900, Shinya Kuribayashi wrote: > Hello, > > This is the first batch to fix the i2c-sh_mobile driver. As a first > step, this comprises of the SCL optimization work and a simple fix to > annoying spurious WAIT interrupt issue; in other words, this does not > ch