On 02/09/2020 16:16, Christoph Hellwig wrote:
> The pcd driver does not have a ->revalidate_disk method, so it can just
md ~^
Otherwise looks good,
Reviewed-by: Johannes Thumshirn
On 9/1/20 1:11 AM, Wolfram Sang wrote:
+ switch (event) {
+ case I2C_SLAVE_STOP:
+ command_size = panel->idx;
+ fallthrough;
+ case I2C_SLAVE_WRITE_REQUESTED:
+ panel->idx = 0;
+ break;
+ case I2C_SLAVE_WRITE_RECEIV
On Tue, Sep 01, 2020 at 09:55:47PM +0100, Ionela Voinescu wrote:
> Now that the update of the FI scale factor is done in cpufreq core for
> selected functions - target(), target_index() and fast_switch(),
> we can provide feedback to the task scheduler and architecture code
> on whether cpufreq sup
On Sun, Aug 30, 2020 at 03:51:51PM +0200, Krzysztof Kozlowski wrote:
> The fixed clocks implemented by Samsung clock drivers use only one
> compatible so drop the additional "fixed-clock" to fix dtbs_check
> warnings like:
>
> arch/arm/boot/dts/exynos4412-i9300.dt.yaml: xxti: compatible:0:
> 'f
Looks good,
Reviewed-by: Johannes Thumshirn
Looks good,
Reviewed-by: Johannes Thumshirn
On Wed, 2 Sep 2020 11:36:13 +0200
pet...@infradead.org wrote:
> On Wed, Sep 02, 2020 at 05:17:55PM +0900, Masami Hiramatsu wrote:
>
> > > Ok, but then lockdep will yell at you if you have that enabled and run
> > > the unoptimized things.
> >
> > Oh, does it warn for all spinlock things in kprob
So far tsc is enabled on x86_64, i386 and Arm64 architectures, add
checking helper to skip this testing for other architectures.
Signed-off-by: Leo Yan
---
tools/perf/tests/builtin-test.c | 1 +
tools/perf/tests/perf-time-to-tsc.c | 13 +
tools/perf/tests/tests.h| 1
The regulators need to be disabled in the aic32x4_register_clocks()
failure case as well.
Fixes: 9d4befff5a95 ("ASoC: codec: tlv3204: Moving GPIO reset and add ADC
reset")
Signed-off-by: Matthias Schiffer
---
sound/soc/codecs/tlv320aic32x4.c | 10 +++---
1 file changed, 7 insertions(+), 3 de
From: Colin Ian King
Currently the duration check on the discharging duration setting is
checking the charging duration rather than the discharging duration
due to a cut-n-paste coding error. Fix this by checking the value
desc->charging_max_duration_ms.
Addresses-Coverity: ("Copy-paste-error")
Em Tue, Sep 01, 2020 at 07:43:33PM -0700, Linus Torvalds escreveu:
> On Tue, Sep 1, 2020 at 3:42 PM Arnaldo Carvalho de Melo
> wrote:
> >
> > - The SNOOPX and REMOTE offsets in the data_src bitmask in perf records were
> > were both 37, SNOOPX is 38, fix it.
>
> The kernel uapi side thinks it'
Add the ability to advertise the Fiber connection if the strap or the
op-mode is configured for 100Base-FX.
Auto negotiation is not supported on this PHY when in fiber mode.
Signed-off-by: Dan Murphy
---
drivers/net/phy/dp83869.c | 35 +++
1 file changed, 35 inse
To avoid the actual PLL settings to differ from the state expected by
the clock driver, the codec should only be fully reset before the clocks
are registered. But we also need to ensure that the software reset
happens at all before clock registration, as not all boards have a reset
GPIO.
Move the
On Tue, Sep 01, 2020 at 09:55:46PM +0100, Ionela Voinescu wrote:
> To properly scale its per-entity load-tracking signals, the task scheduler
> needs to be given a frequency scale factor, i.e. some image of the current
> frequency the CPU is running at. Currently, this scale can be computed
> eithe
On Tue, Sep 01, 2020 at 09:55:45PM +0100, Ionela Voinescu wrote:
> The current frequency passed to arch_set_freq_scale() could end up
> being 0, signaling an error in setting a new frequency. Also, if the
> maximum frequency in 0, this will result in a division by 0 error.
>
> Therefore, validate t
In a number of places in emxx_udc.c, there are variables which are
assigned to without that value ever being used. Remove these pointless
assignments.
Reported-by: kernel test robot
Fixes: 33aa8d45a4fe ("staging: emxx_udc: Add Emma Mobile USB Gadget driver")
Signed-off-by: Alex Dewar
---
driver
x86 arch provides the testing for conversion between tsc and perf time,
the testing is located in x86 arch folder. Move this testing out from
x86 arch folder and place it into the common testing folder, so allows
to execute tsc testing on other architectures (e.g. Arm64).
Signed-off-by: Leo Yan
On Wed, 02 Sep 2020 17:35:30 +0200,
Al Viro wrote:
>
> On Wed, Sep 02, 2020 at 05:22:00PM +0200, Takashi Iwai wrote:
>
> > Marc, Al, could you guys check this bug?
>
> That's racy; the first one should be get_file_rcu() instead of
> file_count()+get_file(), the second is not needed at all (we
>
On 9/2/20 12:24 AM, pet...@infradead.org wrote:
> On Tue, Sep 01, 2020 at 08:51:46PM -0700, Guenter Roeck wrote:
>> On Fri, Aug 21, 2020 at 10:47:49AM +0200, Peter Zijlstra wrote:
>>> The lockdep tracepoints are under the lockdep recursion counter, this
>>> has a bunch of nasty side effects:
>>>
>>
Fold ra_submit() into its last remaining user and pass the previously added
readahead_control struct down into __do_page_cache_readahead().
Signed-off-by: David Howells
---
mm/filemap.c |6 +++---
mm/internal.h | 10 --
2 files changed, 3 insertions(+), 13 deletions(-)
diff --gi
Hi,
The first two patches probably ought to go in x86/urgent, the rest (!RFC) can
go into x86/core and wait a bit.
handle_debug() is a mess, and now that we have separate user and kernel paths,
try and clean it up a bit.
There's two RFC patches at the end that impact the ptrace_{get,set}_debugre
DR6 has a whole bunch of bits that have negative polarity; they were
architecturally reserved and defined to be 1 and are now getting used.
Since they're 1 by default, 0 becomes the signal value.
Handle this by xor'ing the read DR6 value by the reserved mask, this
will flip them around such that 1
Remove the historical junk and replace it with a WARN and a comment.
The problem is that even though the kernel only uses TF single-step in
kprobes and KGDB, both of which consume the event before this,
QEMU/KVM has bugs in this area that can trigger this state so we have
to deal with it.
Suggest
Hi Willy,
Here's a set of patches to expand the use of the readahead_control struct,
essentially from do_sync_mmap_readahead() down. It's on top of:
http://git.infradead.org/users/willy/pagecache.git
Also pass file_ra_state into force_page_cache_readahead().
The bugfix for khugepaged
Looks good,
Reviewed-by: Johannes Thumshirn
Pass struct readahead_control into the page_cache_{sync,async}_readahead()
functions in preparation for making do_sync_mmap_readahead() pass down an
RAC struct.
Signed-off-by: David Howells
---
fs/btrfs/free-space-cache.c |4 +++-
fs/btrfs/ioctl.c|9 ++---
fs/btrfs/reloc
On Sun, Aug 30, 2020 at 03:51:49PM +0200, Krzysztof Kozlowski wrote:
> Align the name of mag-mhl-gpio node to avoid dtschema confusion and
> dtbs_check warning:
>
> arch/arm/boot/dts/exynos4210-i9100.dt.yaml: pinctrl@1100: mag-mhl-gpio:
> {'samsung,pins': ['gpd0-2'], 'samsung,pin-functio
Pass a file_ra_state struct into force_page_cache_readahead(). One caller
has one that should be passed in and the other doesn't, but the former
needs to pass its in.
Signed-off-by: David Howells
---
mm/fadvise.c |3 ++-
mm/internal.h |3 ++-
mm/readahead.c |5 ++---
3 files cha
Push readahead_control down into force_page_cache_readahead() from its
callers in preparation for making do_sync_mmap_readahead() pass down an RAC
struct.
Signed-off-by: David Howells
---
mm/fadvise.c |5 -
mm/internal.h |3 +--
mm/readahead.c | 19 +++
3 files
collapse_file() in khugepaged passes PAGE_SIZE as the number of pages to be
read ahead to page_cache_sync_readahead(). It seems this was expressed as a
number of bytes rather than a number of pages.
Fix it to use the number of pages to the end of the window instead.
Fixes: 99cb0dbd47a1 ("mm,thp:
Looks good,
Reviewed-by: Johannes Thumshirn
Make ondemand_readahead() take a readahead_control struct in preparation
for making do_sync_mmap_readahead() pass down an RAC struct.
Signed-off-by: David Howells
---
mm/readahead.c | 32 ++--
1 file changed, 18 insertions(+), 14 deletions(-)
diff --git a/mm/reada
The handle_debug(.user) argument is used to terminate the #DB handler
early for the INT1-from-kernel case, since the kernel doesn't use
INT1.
Remove the argument and handle this explicitly in #DB-from-kernel.
Signed-off-by: Peter Zijlstra (Intel)
Acked-by: Andy Lutomirski
---
arch/x86/kernel/t
The perf mmap'ed buffer contains the flag 'cap_user_time_short' and two
extra fields 'time_cycles' and 'time_mask', perf tool needs to know
them for handling the counter wrapping case.
This patch is to reads out the relevant parameters from the head of the
first mmap'ed page and stores into the st
Hi,
Le 02/09/2020 à 16:14, Segher Boessenkool a écrit :
Hi!
On Wed, Sep 02, 2020 at 06:46:45AM +, Christophe Leroy wrote:
ld crashes:
LD arch/powerpc/kernel/vdso32/vdso32.so.dbg
/bin/sh: line 1: 23780 Segmentation fault (core dumped)
ppc-linux-ld -EB -m elf32ppc -shared -sona
Kprobes are on kernel text, and thus only matter for #DB-from-kernel.
Kprobes are ordered before the generic notifier, preserve that order.
Signed-off-by: Peter Zijlstra (Intel)
Acked-by: Masami Hiramatsu
Acked-by: Andy Lutomirski
---
arch/x86/include/asm/kprobes.h |4
arch/x86/kernel
From: Andy Lutomirski
Trying to clear DR7 around a #DB from usermode malfunctions if we
schedule when delivering SIGTRAP. Rather than trying to define a
special no-recursion region, just allow a single level of recursion.
We do the same thing for NMI, and it hasn't caused any problems yet.
Fixe
Matthew Wilcox wrote:
> He's done it on top of http://git.infradead.org/users/willy/pagecache.git
Sorry, yes, I should've mentioned that.
> I was hoping he'd include
> http://git.infradead.org/users/willy/pagecache.git/commitdiff/c71de787328809026cfabbcc5485cb01caca8646
> http://git.infradead.o
This patch set is to refactor the changes for the old patch set 'Perf
tool: Enable Arm arch timer counter and arm-spe's timestamp' [1].
After reviewed the old patch sets (thanks Wei Li and Al Grant), we
think it's right way to consolidate TSC code and extend the TSC
implementation to common code w
In function drm_atomic_helper_shutdown, maybe there is no need
to protect DRM_ERROR log in DRM_MODESET_LOCK_ALL_BEGIN &
DRM_MODESET_LOCK_ALL_END. This change is to make code run a bit
fast.
Signed-off-by: Bernard Zhao
---
drivers/gpu/drm/drm_atomic_helper.c | 4 +---
1 file changed, 1 insertion(
> > >> But this means that the page is not isolated and so it could be reused
> > >> for something else. No?
> > >
> > > The page is in a movable zone, has zero references, and the section is
> > > isolated (i.e. set_pageblock_migratetype(page, MIGRATE_ISOLATE);) is
> > > set. The page should be of
Looks good,
Reviewed-by: Johannes Thumshirn
Hi David,
One further thought...
> +++ b/man2/fsopen.2
[...]
> +.BR fsopen ()
> +creates a blank filesystem configuration context within the kernel for the
> +filesystem named in the
> +.I fsname
> +parameter, puts it into creation mode and attaches it to a file descriptor,
> +which it then retur
On Sun, Aug 30, 2020 at 03:51:35PM +0200, Krzysztof Kozlowski wrote:
> The PMIC has a 32768 Hz clock used by the modem which is implemented by
> driver as a regulator. Add and enable it to be sure modem get's its
> signal.
>
> Signed-off-by: Krzysztof Kozlowski
> ---
> arch/arm/boot/dts/exynos4
On Thu, Aug 27, 2020 at 03:49:03PM +0800, Feng Tang wrote:
> output of the tool
> --
>
> CPUID leafs total: 28
>
> cpu family : 6
> model : 13
> stepping: 7
Yeah, this should dump model etc and those numbers should be in hex and
addi
On Wed, Sep 02, 2020 at 08:26:43PM +0800, Ming Lei wrote:
> The field of 'q_usage_counter' is always fetched in fast path of every
> block driver, and move it into front of 'request_queue', so it can be
> fetched into 1st cacheline of 'request_queue' instance.
Looks good,
Reviewed-by: Christoph H
Hi,
first, I'm sorry for the late reply. Thanks, Josh, for the reminder.
CCing Nicolai. Nicolai, could you take a look at the proposed
documentation too, please? You have more up-to-date experience.
On Tue, 21 Jul 2020, Joe Lawrence wrote:
> +Examples
> +
> +
> +Interprocedural optimiz
On Wed, Sep 02, 2020 at 10:31:47AM +0200, Ulf Hansson wrote:
> On Tue, 1 Sep 2020 at 17:40, Christoph Hellwig wrote:
> >
> > On Tue, Sep 01, 2020 at 05:36:17PM +0200, Ulf Hansson wrote:
> > > > I still don't think this makes sense, as the dma_mask should always
> > > > be non-NULL here.
> > >
> >
Move the BTF sync near the DR6 load, as this will be the only common
code guaranteed to run on every #DB.
Signed-off-by: Peter Zijlstra (Intel)
Acked-by: Andy Lutomirski
---
arch/x86/kernel/traps.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
--- a/arch/x86/kernel/tra
Looks good,
Reviewed-by: Johannes Thumshirn
Currently, dma_map is being checked, when the right object identifier
to be null-checked is dma_map->dma_pages, instead.
Fix this by null-checking dma_map->dma_pages.
Addresses-Coverity-ID: 1496811 ("Logically dead code")
Fixes: 921b68692abb ("xsk: Enable sharing of dma mappings")
Signed-off-by:
From: Christophe Leroy
> Sent: 02 September 2020 15:13
>
>
> Le 02/09/2020 à 15:51, David Laight a écrit :
> > From: Christophe Leroy
> >> Sent: 02 September 2020 14:25
> >> Le 02/09/2020 à 15:13, David Laight a écrit :
> >>> From: Christoph Hellwig
> Sent: 02 September 2020 13:37
>
> >
Hi Willy,
On 01.09.20 18:53, Matthew Wilcox wrote:
> On Tue, Sep 01, 2020 at 06:41:12PM +0200, Helge Deller wrote:
>>> I still have a zoo of machines running for such testing, including a
>>> 715/64 and two 730.
>>> I'm going to test this git tree on the 715/64:
>
> The 715/64 is a 7100LC machine
Multiple files from arch/arm/mach-imx/ use clock init functions which
are defined in the IMX clock drivers. Declare them in globally
accessible header to fix GCC warnings:
drivers/clk/imx/clk-imx21.c:122:74: warning: no previous prototype for
'mx21_clocks_init' [-Wmissing-prototypes]
Signed-o
On Sun, Aug 30, 2020 at 03:51:28PM +0200, Krzysztof Kozlowski wrote:
> The name of I2C controller over GPIO lines node ends with '-gpio' which
> confuses dtschema:
>
> /arch/arm/boot/dts/exynos4210-i9100.dt.yaml: /: i2c-gpio:
> {'compatible': ['i2c-gpio'], ... 'maxim,over-volt': [[4500]]}}
On 2020-09-02 10:11 a.m., Christoph Hellwig wrote:
Hi Jens,
this series replaced the not very nice check_disk_change() function with
a new bdev_media_changed that avoids having the ->revalidate_disk call
at its end. As a result ->revalidate_disk can be removed from a lot of
drivers.
For over
On 9/2/20 10:03 AM, Krzysztof Kozlowski wrote:
Add missing kerneldoc to fix compile warning:
drivers/clk/davinci/da8xx-cfgchip.c:578: warning: Function parameter or
member 'dev' not described in 'da8xx_cfgchip_register_usb1_clk48'
Signed-off-by: Krzysztof Kozlowski
---
Reviewed-by: David
On Wed, Sep 02, 2020 at 11:08:49AM +0200, Christian Brauner wrote:
> On Tue, Sep 01, 2020 at 07:40:16PM -0600, Tycho Andersen wrote:
> > In seccomp_set_mode_filter() with TSYNC | NEW_LISTENER, we first initialize
> > the listener fd, then check to see if we can actually use it later in
> > seccomp_
Fix and add missing kerneldoc to fix compile warnings like:
drivers/clk/imx/clk-pfd.c:27: warning: Function parameter or member 'hw' not
described in 'clk_pfd'
drivers/clk/imx/clk-pllv3.c:53: warning: Function parameter or member
'ref_clock' not described in 'clk_pllv3'
Signed-off-by: Krzys
On 9/2/20 10:03 AM, Krzysztof Kozlowski wrote:
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.
Signed-off-by: Krzysztof Kozlowski
---
Reviewed-by: David Lechner
Do not declare in mach-imx functions defined in clock drivers but
include the respective header.
Signed-off-by: Krzysztof Kozlowski
---
arch/arm/mach-imx/common.h | 4
arch/arm/mach-imx/mach-armadillo5x0.c | 1 +
arch/arm/mach-imx/mach-bug.c| 1 +
arch
Fixup for epoll regression; there's a better solution longer term,
but this is the least intrusive fix.
The following changes since commit 52c479697c9b73f628140dcdfcd39ea302d05482:
do_epoll_ctl(): clean the failure exits up a bit (2020-08-22 18:25:52 -0400)
are available in the git rep
The at91sam9g45_pcr_layout is not used so drop it to fix build warning:
drivers/clk/at91/at91sam9g45.c:49:36: warning:
'at91sam9g45_pcr_layout' defined but not used [-Wunused-const-variable=]
Signed-off-by: Krzysztof Kozlowski
---
drivers/clk/at91/at91sam9g45.c | 7 ---
1 file changed
02.09.2020 17:53, Marek Szyprowski пишет:
> Hi Dmitry,
>
> On 02.09.2020 16:18, Dmitry Osipenko wrote:
>> Regmap can't sleep if spinlock is used for the locking protection.
>> This patch fixes regression caused by a previous commit that switched
>> regmap to use fsleep() and this broke Amlogic S92
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.
Signed-off-by: Krzysztof Kozlowski
---
drivers/clk/clk-gpio.c | 16
1 file changed, 4 insertions(+), 12 deletions(-)
diff --git a/drivers/clk/clk-gpio.
On Sat, Aug 29, 2020 at 07:25:32PM +0200, Krzysztof Kozlowski wrote:
> The binding for DesignWare HS OTG USB 2.0 in Samsung SoCs take only one
> compatible. This fixes dtbs_check warnings like:
>
> arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml: hsotg@1248:
> compatible: ['samsung,s3c
On Wed, Sep 02, 2020 at 05:22:00PM +0200, Takashi Iwai wrote:
> Marc, Al, could you guys check this bug?
That's racy; the first one should be get_file_rcu() instead of
file_count()+get_file(), the second is not needed at all (we
have the file pinned down by the caller). See vfs.git#work.epoll
fo
Add missing kerneldoc to fix compile warnings like:
drivers/clk/clk-fixed-factor.c:211: warning: Function parameter or member
'node' not described in 'of_fixed_factor_clk_setup'
Signed-off-by: Krzysztof Kozlowski
---
drivers/clk/clk-fixed-factor.c | 1 +
drivers/clk/clk-fixed-rate.c | 1 +
From: ChiYuan Huang
Fix: If vbus event is before cc_event trigger, hard_reset_count
won't bt reset for some case.
Signed-off-by: ChiYuan Huang
---
Below's the flow.
_tcpm_pd_vbus_off() -> run_state_machine to change state to SNK_UNATTACHED
call tcpm_snk_detach() -> tcpm_snk_detach() -> tcpm_de
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.
Signed-off-by: Krzysztof Kozlowski
---
drivers/clk/clk-bulk.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/clk/clk-bulk.c b/drivers/c
Em Thu, Aug 27, 2020 at 12:17:32PM +0530, Kajol Jain escreveu:
> Commit 2ed6edd33a21 ("perf: Add cond_resched() to task_function_call()")
> added assignment of ret value as -EAGAIN in case function
> call to 'smp_call_function_single' fails.
> For non-zero ret value, it did
> 'ret = !ret ? data.ret
On 9/2/20 8:38 AM, Gustavo A. R. Silva wrote:
> A few months ago, commit e132fc6bb89b ("power: supply: charger-manager: Make
> decisions focussed on battery status")
> changed the expression in the if statement from "duration >
> desc->discharging_max_duration_ms"
> to "duration > desc->charging_
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.
Signed-off-by: Krzysztof Kozlowski
---
drivers/clk/qcom/apcs-msm8916.c | 9 +++--
drivers/clk/qcom/clk-spmi-pmic-div.c | 10 --
2 files changed, 7 inse
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.
Signed-off-by: Krzysztof Kozlowski
---
drivers/clk/davinci/da8xx-cfgchip.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/clk/davinci/da8x
Marvell Prestera 98DX326x integrates up to 24 ports of 1GbE with 8
ports of 10GbE uplinks or 2 ports of 40Gbps stacking for a largely
wireless SMB deployment.
The current implementation supports only boards designed for the Marvell
Switchdev solution and requires special firmware.
The core Preste
The CRn accessor functions use __force_order as a dummy operand to
prevent the compiler from reordering the inline asm.
The fact that the asm is volatile should be enough to prevent this
already, however older versions of GCC had a bug that could sometimes
result in reordering. This was fixed in 8
Add PCI interface driver for Prestera Switch ASICs family devices, which
provides:
- Firmware loading mechanism
- Requests & events handling to/from the firmware
- Access to the firmware on the bus level
The firmware has to be loaded each time the device is reset. The driver
is loadin
Check for "!A || A && B" condition. It's equivalent to
"!A || B" condition.
Signed-off-by: Denis Efremov
---
scripts/coccinelle/misc/excluded_middle.cocci | 40 +++
1 file changed, 40 insertions(+)
create mode 100644 scripts/coccinelle/misc/excluded_middle.cocci
diff --git a/sc
Looks good,
Reviewed-by: Johannes Thumshirn
Fix kerneldoc warnings:
drivers/crypto/caam/caamalg_qi2.c:73: warning: cannot understand function
prototype: 'struct caam_ctx '
drivers/crypto/caam/caamalg_qi2.c:2962: warning: cannot understand function
prototype: 'struct caam_hash_ctx '
Signed-off-by: Krzysztof Kozlowski
---
drivers/cry
> On Sep 2, 2020, at 5:54 AM, pet...@infradead.org wrote:
>
> On Tue, Sep 01, 2020 at 09:18:57AM -0700, Nadav Amit wrote:
>
>> Unless I misunderstand the logic, __force_order should also be used by
>> rdpkru() and wrpkru() which do not have dependency on __force_order. I
>> also did not understan
Add very basic support for devlink interface:
- driver name
- fw version
- devlink ports
Signed-off-by: Vadym Kochan
---
PATCH v5:
1) Simplified some error path handling by simple return error code in:
- prestera_dl_info_get(...)
2) Remove not-needed err assignment i
On Thu, Aug 27, 2020 at 09:33:15AM +0200, Krzysztof Kozlowski wrote:
> platform_get_irq() returns -ERRNO on error. In such case comparison
> to 0 would pass the check.
>
> Fixes: 54afbec0d57f ("memory: Freescale CoreNet Coherency Fabric error
> reporting driver")
> Signed-off-by: Krzysztof Kozlo
A few months ago, commit e132fc6bb89b ("power: supply: charger-manager: Make
decisions focussed on battery status")
changed the expression in the if statement from "duration >
desc->discharging_max_duration_ms"
to "duration > desc->charging_max_duration_ms", but the arguments for
dev_info() were
And down by one,
Reviewed-by: Johannes Thumshirn
Looks good,
Reviewed-by: Johannes Thumshirn
> +static int floppy_revalidate(struct gendisk *disk);
Completely unrelated to this series but, this is the 3rd floppy
driver in the series defining it's own floppy_revalidate() and
naming it floppy_revalidate().
This makes grepping and reviewing a
Hi,
On Tue, Sep 1, 2020 at 10:36 PM Rajendra Nayak wrote:
>
>
> > * In terms of the numbers here, I believe that you're claiming that we
> > can dissipate 768 mW * 6 + 1202 mW * 2 = ~7 Watts of power. My memory
> > of how much power we could dissipate in previous laptops I worked on
> > is a lit
There are some cases where we would like to trap dropped packets only
for a single port on a device without affecting the others. For that
purpose trap_mngr was added to devlink_port and corresponding Trap API
with devlink_port were added too.
Signed-off-by: Aya Levin
---
drivers/net/ethernet/me
Managing large scale port's traps may be complicated. This patch
introduces a shortcut: when setting a trap on a device and this trap is
not registered on this device, the action will take place on all related
ports that did register this trap.
Signed-off-by: Aya Levin
---
net/core/devlink.c | 4
On Sun, Aug 30, 2020 at 11:13:53AM +0200, Greg Kroah-Hartman wrote:
> On Sun, Aug 30, 2020 at 12:37:17AM +0100, Alex Dewar wrote:
> > sysfs attributes are supposed to be only single values, which are
> > printed into a buffer of PAGE_SIZE. Accordingly, for many simple
> > attributes, sprintf() can
Register MTU error trap to allow visibility of oversize packets. Display
a naive use of devlink trap in devlink port context.
Signed-off-by: Aya Levin
---
drivers/net/ethernet/mellanox/mlx5/core/Makefile | 2 +-
drivers/net/ethernet/mellanox/mlx5/core/en.h | 2 ++
drivers/net/ethernet/
Bundle the trap related lists: trap_list, trap_group_list and
trap_policer_list and trap ops like: trap_init, trap_fini,
trap_action_set... together in trap_mngr. This will be handy in the
coming patches in the set introducing traps in devlink port context.
With trap_mngr, code reuse is much simple
Implement support for devlink traps on per-port basis.
Dropped packets in the RX flow are related to the Ethernet port and
thus should be in port context. Traps per device should trap global
configuration which can cause drops. On top of that, enabling a trap
on a device level should trigger this t
On Fri, Aug 28, 2020 at 05:37:47PM +0200, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski
> ---
> drivers/memory/tegra/tegra186-emc.c | 10 ++--
On Wed, Sep 02, 2020 at 04:41:29PM +0200, Takashi Iwai wrote:
> On Wed, 02 Sep 2020 13:01:10 +0200,
> Greg Kroah-Hartman wrote:
> >
> > Signed-off-by: Greg Kroah-Hartman
>
> I guess this and a few others with (x/9) are stale patches, right?
Ugh, yes, those were still in my directory, my fault f
On Wed, 2 Sep 2020 11:46:27 +0200 Jiri Pirko wrote:
> >? Do we need such change there too or keep it as is, each action by itself
> >and return what was performed ?
>
> Well, I don't know. User asks for X, X should be performed, not Y or Z.
> So perhaps the return value is not needed.
> Just dri
Looks good,
Reviewed-by: Johannes Thumshirn
Adding Santosh,
I'm trying to understand the code that Jim changed for the range
dma offsets. Do I miss something or can the whole DMA offset case
for keystone only happen when CONFIG_LPAE is enabled? Which means
we could ifdef out this section to avoid the warning?
On Sat, Aug 29, 2020 at 06:23:13PM -0700, Joe Perches wrote:
> On Sat, 2020-08-29 at 17:28 -0700, Joe Perches wrote:
> > On Sun, 2020-08-30 at 00:37 +0100, Alex Dewar wrote:
> > > Hi all,
> > >
> > > I've noticed there seems to have been a fair amount of discussion around
> > > the subject of poss
On 9/2/20 5:51 AM, Suravee Suthikulpanit wrote:
> When using 128-bit interrupt-remapping table entry (IRTE) (a.k.a GA mode),
> current driver disables interrupt remapping when it updates the IRTE
> so that the upper and lower 64-bit values can be updated safely.
>
> However, this creates a small w
701 - 800 of 1320 matches
Mail list logo
