Re: [PATCH v2 04/12] uprobes: revamp uprobe refcounting and lifetime management

2024-07-09 Thread Oleg Nesterov
On 07/08, Andrii Nakryiko wrote: > > On Sun, Jul 7, 2024 at 7:48 AM Oleg Nesterov wrote: > > > > And I forgot to mention... > > > > In any case __uprobe_unregister() can't ignore the error code from > > register_for_each_vma(). If it fails to restore the original insn, > > we should not remove

Re: [PATCH v4] perf,x86: avoid missing caller address in stack traces captured in uprobe

2024-07-09 Thread Andrii Nakryiko
On Tue, Jul 9, 2024 at 3:11 AM Peter Zijlstra wrote: > > On Mon, Jul 08, 2024 at 04:11:27PM -0700, Andrii Nakryiko wrote: > > +#ifdef CONFIG_UPROBES > > +/* > > + * Heuristic-based check if uprobe is installed at the function entry. > > + * > > + * Under assumption of user code being compiled

Re: [PATCH] kallsyms, livepatch: Fix livepatch with CONFIG_LTO_CLANG

2024-07-09 Thread Matthew Maurer
On Mon, Jul 8, 2024 at 5:07 PM Sami Tolvanen wrote: > > On Mon, Jul 8, 2024 at 2:33 PM Luis Chamberlain wrote: > > > > Looking at this again its not to me why Masahiro Yamada's suggestion on > > that old patch series to just increase the length and put long symbols > > names into its own section

Re: [PATCH] kallsyms, livepatch: Fix livepatch with CONFIG_LTO_CLANG

2024-07-09 Thread Song Liu
> On Jul 9, 2024, at 8:07 AM, Sami Tolvanen wrote: [...] > >>> I am a bit scared because using hashed symbol names in backtraces, gdb, >>> ... would be a nightmare. Hashes are not human readable and >>> they would complicate the life a lot. And using different names >>> in different

Re: [PATCH v4] perf,x86: avoid missing caller address in stack traces captured in uprobe

2024-07-09 Thread Peter Zijlstra
On Tue, Jul 09, 2024 at 11:10:17PM +0900, Masami Hiramatsu wrote: > On Tue, 9 Jul 2024 12:11:33 +0200 > Peter Zijlstra wrote: > > > On Mon, Jul 08, 2024 at 04:11:27PM -0700, Andrii Nakryiko wrote: > > > +#ifdef CONFIG_UPROBES > > > +/* > > > + * Heuristic-based check if uprobe is installed at

Re: [PATCH v4] perf,x86: avoid missing caller address in stack traces captured in uprobe

2024-07-09 Thread Google
On Tue, 9 Jul 2024 12:11:33 +0200 Peter Zijlstra wrote: > On Mon, Jul 08, 2024 at 04:11:27PM -0700, Andrii Nakryiko wrote: > > +#ifdef CONFIG_UPROBES > > +/* > > + * Heuristic-based check if uprobe is installed at the function entry. > > + * > > + * Under assumption of user code being compiled

[PATCH] test/vsock: add install target

2024-07-09 Thread Peng Fan (OSS)
From: Peng Fan Add install target for vsock to make Yocto easy to install the images. Signed-off-by: Peng Fan --- tools/testing/vsock/Makefile | 12 1 file changed, 12 insertions(+) diff --git a/tools/testing/vsock/Makefile b/tools/testing/vsock/Makefile index

[PATCH net-next v10 05/15] mm: page_frag: avoid caller accessing 'page_frag_cache' directly

2024-07-09 Thread Yunsheng Lin
Use appropriate frag_page API instead of caller accessing 'page_frag_cache' directly. CC: Alexander Duyck Signed-off-by: Yunsheng Lin --- drivers/vhost/net.c | 2 +- include/linux/page_frag_cache.h | 10 ++ mm/page_frag_test.c | 2 +- net/core/skbuff.c

[PATCH net-next v10 04/15] mm: page_frag: add '_va' suffix to page_frag API

2024-07-09 Thread Yunsheng Lin
Currently the page_frag API is returning 'virtual address' or 'va' when allocing and expecting 'virtual address' or 'va' as input when freeing. As we are about to support new use cases that the caller need to deal with 'struct page' or need to deal with both 'va' and 'struct page'. In order to

Re: [PATCH net-next v3 3/3] virtio-net: synchronize operstate with admin state on up/down

2024-07-09 Thread Michael S. Tsirkin
On Tue, Jul 09, 2024 at 04:02:14PM +0800, Jason Wang wrote: > This patch synchronize operstate with admin state per RFC2863. > > This is done by trying to toggle the carrier upon open/close and > synchronize with the config change work. This allows propagate status > correctly to stacked devices

Re: [PATCH v3 0/2] vdpa: support set mac address from vdpa tool

2024-07-09 Thread Michael S. Tsirkin
On Tue, Jul 09, 2024 at 02:19:19PM +0800, Cindy Lu wrote: > On Tue, 9 Jul 2024 at 11:59, Parav Pandit wrote: > > > > Hi Cindy, > > > > > From: Cindy Lu > > > Sent: Monday, July 8, 2024 12:17 PM > > > > > > Add support for setting the MAC address using the VDPA tool. > > > This feature will allow

Re: [PATCH] vdpa_sim_blk: add `capacity` module parameter

2024-07-09 Thread Stefano Garzarella
On Tue, Jul 09, 2024 at 10:56:16AM GMT, Jason Wang wrote: On Mon, Jul 8, 2024 at 4:15 PM Stefano Garzarella wrote: Hi Cindy, Jason, On Mon, Jul 08, 2024 at 03:59:34PM GMT, Jason Wang wrote: >On Mon, Jul 8, 2024 at 3:06 PM Cindy Lu wrote: >> >> On Fri, 5 Jul 2024 at 20:42, Stefano Garzarella

[PATCH v3 9/9] dt-bindings: interconnect: qcom: msm8953: Fix 'See also' in description

2024-07-09 Thread Adam Skladowski
"See also" in description seems to be wrongly defined, make it inline with other yamls. Fixes: 791ed23f735b ("dt-bindings: interconnect: qcom: Add Qualcomm MSM8953 NoC") Signed-off-by: Adam Skladowski --- .../devicetree/bindings/interconnect/qcom,msm8953.yaml | 3 +-- 1 file changed, 1

[PATCH v3 8/9] interconnect: qcom: msm8953: Add ab_coeff

2024-07-09 Thread Adam Skladowski
BIMC and SNOC-MM on downstream feature qcom,util-fact which translates to ab_coeff, add it. Signed-off-by: Adam Skladowski --- drivers/interconnect/qcom/msm8953.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/interconnect/qcom/msm8953.c b/drivers/interconnect/qcom/msm8953.c

[PATCH v3 7/9] dt-bindings: interconnect: qcom: msm8939: Fix example

2024-07-09 Thread Adam Skladowski
For now example list snoc_mm as children of bimc which is obviously not valid, drop bimc and move snoc_mm into snoc. Signed-off-by: Adam Skladowski --- .../devicetree/bindings/interconnect/qcom,msm8939.yaml | 6 -- 1 file changed, 6 deletions(-) diff --git

[PATCH v3 6/9] interconnect: qcom: qcs404: Add regmaps and more bus descriptions

2024-07-09 Thread Adam Skladowski
Currently we are lacking descriptions of regmaps, bus clocks and types of busses, provide them. Signed-off-by: Adam Skladowski --- drivers/interconnect/qcom/qcs404.c | 42 +++--- 1 file changed, 39 insertions(+), 3 deletions(-) diff --git

[PATCH v3 5/9] interconnect: qcom: qcs404: Mark AP-owned nodes as such

2024-07-09 Thread Adam Skladowski
When driver was upstreamed it seems ap_owned nodes were not available, bring them now. Signed-off-by: Adam Skladowski --- drivers/interconnect/qcom/qcs404.c | 85 ++ 1 file changed, 85 insertions(+) diff --git a/drivers/interconnect/qcom/qcs404.c

[PATCH v3 4/9] interconnect: qcom: Add MSM8937 interconnect provider driver

2024-07-09 Thread Adam Skladowski
Add driver for interconnect busses found in MSM8937 based platforms. The topology consists of four NoCs that are partially controlled by a RPM processor. Signed-off-by: Adam Skladowski --- drivers/interconnect/qcom/Kconfig |9 + drivers/interconnect/qcom/Makefile |2 +

[PATCH v3 3/9] dt-bindings: interconnect: qcom: Add Qualcomm MSM8937 NoC

2024-07-09 Thread Adam Skladowski
Add bindings for Qualcomm MSM8937 Network-On-Chip interconnect devices. Signed-off-by: Adam Skladowski --- .../bindings/interconnect/qcom,msm8939.yaml | 8 +- .../dt-bindings/interconnect/qcom,msm8937.h | 93 +++ 2 files changed, 99 insertions(+), 2 deletions(-) create

[PATCH v3 2/9] interconnect: qcom: Add MSM8976 interconnect provider driver

2024-07-09 Thread Adam Skladowski
Add driver for interconnect busses found in MSM8976 based platforms. The topology consists of four NoCs that are partially controlled by a RPM processor. Signed-off-by: Adam Skladowski --- drivers/interconnect/qcom/Kconfig |9 + drivers/interconnect/qcom/Makefile |2 +

[PATCH v3 1/9] dt-bindings: interconnect: qcom: Add Qualcomm MSM8976 NoC

2024-07-09 Thread Adam Skladowski
Add bindings for Qualcomm MSM8976 Network-On-Chip interconnect devices. Signed-off-by: Adam Skladowski --- .../bindings/interconnect/qcom,msm8939.yaml | 15 ++- .../dt-bindings/interconnect/qcom,msm8976.h | 97 +++ 2 files changed, 107 insertions(+), 5 deletions(-) create

[PATCH v3 0/9] msm8937/msm8976/qcs404 icc patches

2024-07-09 Thread Adam Skladowski
This series introduce new ICC drivers for some legacy socs while at it also updates a bit of qcs404 driver which seems to not receive much attention lately. Please take in consideration i do not own any qcs404 board so i cannot test anything else than if it compiles. Changes since v2

Re: [PATCH v4] perf,x86: avoid missing caller address in stack traces captured in uprobe

2024-07-09 Thread Peter Zijlstra
On Mon, Jul 08, 2024 at 04:11:27PM -0700, Andrii Nakryiko wrote: > +#ifdef CONFIG_UPROBES > +/* > + * Heuristic-based check if uprobe is installed at the function entry. > + * > + * Under assumption of user code being compiled with frame pointers, > + * `push %rbp/%ebp` is a good indicator that we

Re: [PATCH] rust: add `module_params` macro

2024-07-09 Thread Miguel Ojeda
On Mon, Jul 8, 2024 at 11:42 PM Luis Chamberlain wrote: > > The rationale here is that a rust binding means commitment then also > from fresh blood to help co-maintain review C / Rust for exising code > when there is will / desire to collaborate from an existing C maintainer. > > I realize this

Re: [PATCH v4 3/5] arm64: dts: qcom: sdx75: update reserved memory regions for mpss

2024-07-09 Thread Konrad Dybcio
On 9.07.2024 8:49 AM, Naina Mehta wrote: > Rename qdss@8880 memory region as qlink_logging memory region > and add qdss_mem memory region at address of 0x8850, > qlink_logging is being added at the memory region at the address > of 0x8880 as the region is being used by modem firmware.

Re: [PATCH] rust: add `module_params` macro

2024-07-09 Thread nmi
Hi Greg, On Tuesday, 9 July 2024 at 10:27, Greg KH wrote: > On Tue, Jul 09, 2024 at 06:00:46AM +, nmi wrote: > > > Hi Luis, > > > > On Monday, July 8th, 2024 at 23:42, Luis Chamberlain mcg...@kernel.org > > wrote: > > > > > I'm starting to feel the same way about modules, but

Re: [PATCH v8 2/5] remoteproc: Add TEE support

2024-07-09 Thread Arnaud POULIQUEN
On 7/8/24 17:43, Mathieu Poirier wrote: > On Fri, Jul 05, 2024 at 09:33:55AM +0200, Arnaud POULIQUEN wrote: >> >> >> On 7/4/24 17:32, Mathieu Poirier wrote: >>> On Thu, Jul 04, 2024 at 10:05:24AM +0200, Arnaud POULIQUEN wrote: On 7/3/24 17:14, Mathieu Poirier wrote: > On Wed,

Re: [PATCH] rust: add `module_params` macro

2024-07-09 Thread Greg KH
On Tue, Jul 09, 2024 at 06:00:46AM +, nmi wrote: > Hi Luis, > > On Monday, July 8th, 2024 at 23:42, Luis Chamberlain > wrote: > > > I'm starting to feel the same way about modules, but modules requires > > more work than the firmware loader. And since I also know Andreas has > > already a

[PATCH RT 1/1] Linux 4.19.317-rt137

2024-07-09 Thread Daniel Wagner
v4.19.317-rt137-rc1 stable review patch. If anyone has any objections, please let me know. --- Signed-off-by: Daniel Wagner --- localversion-rt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/localversion-rt b/localversion-rt index f824f53c19ea..41b444e910ef 100644

[PATCH RT 0/1] Linux v4.19.317-rt137-rc1

2024-07-09 Thread Daniel Wagner
Dear RT Folks, This is the RT stable review cycle of patch 4.19.317-rt137-rc1. Please scream at me if I messed something up. Please test the patches too. The -rc release is also available on kernel.org https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-stable-rt.git on the

[ANNOUNCE] 4.19.316-rt136

2024-07-09 Thread Daniel Wagner
Hello RT-list! I'm pleased to announce the 4.19.316-rt136 stable release. This is just an update to the v4.19.316 stable release. No RT specific changes. You can get this release via the git tree at: git://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-stable-rt.git branch: v4.19-rt

Re: [PATCH net-next v3 3/3] virtio-net: synchronize operstate with admin state on up/down

2024-07-09 Thread Xuan Zhuo
On Tue, 9 Jul 2024 16:02:14 +0800, Jason Wang wrote: > This patch synchronize operstate with admin state per RFC2863. > > This is done by trying to toggle the carrier upon open/close and > synchronize with the config change work. This allows propagate status > correctly to stacked devices like:

Re: [PATCH net-next v3 3/3] virtio-net: synchronize operstate with admin state on up/down

2024-07-09 Thread Xuan Zhuo
On Tue, 9 Jul 2024 16:02:14 +0800, Jason Wang wrote: > This patch synchronize operstate with admin state per RFC2863. > > This is done by trying to toggle the carrier upon open/close and > synchronize with the config change work. This allows propagate status > correctly to stacked devices like:

Re: [PATCH net-next v3 2/3] virtio: allow driver to disable the configure change notification

2024-07-09 Thread Xuan Zhuo
On Tue, 9 Jul 2024 16:02:13 +0800, Jason Wang wrote: > Sometime, it would be useful to disable the configure change > notification from the driver. So this patch allows this by introducing > a variable config_change_driver_disabled and only allow the configure > change notification callback to

Re: [PATCH net-next v3 2/3] virtio: allow driver to disable the configure change notification

2024-07-09 Thread Xuan Zhuo
On Tue, 9 Jul 2024 16:02:13 +0800, Jason Wang wrote: > Sometime, it would be useful to disable the configure change > notification from the driver. So this patch allows this by introducing > a variable config_change_driver_disabled and only allow the configure > change notification callback to

Re: [PATCH net-next v3 1/3] virtio: rename virtio_config_enabled to virtio_config_core_enabled

2024-07-09 Thread Xuan Zhuo
On Tue, 9 Jul 2024 16:02:12 +0800, Jason Wang wrote: > Following patch will allow the config interrupt to be disabled by a > specific driver via another boolean. So this patch renames > virtio_config_enabled and relevant helpers to > virtio_config_core_enabled. > > Cc: Venkat Venkatsubra > Cc:

Re: [PATCH -fixes] riscv: patch: Flush the icache right after patching to avoid illegal insns

2024-07-09 Thread Geert Uytterhoeven
Hi Alexandre, On Mon, Jun 24, 2024 at 10:23 AM Alexandre Ghiti wrote: > We cannot delay the icache flush after patching some functions as we may > have patched a function that will get called before the icache flush. > > The only way to completely avoid such scenario is by flushing the icache >

[PATCH net-next v3 3/3] virtio-net: synchronize operstate with admin state on up/down

2024-07-09 Thread Jason Wang
This patch synchronize operstate with admin state per RFC2863. This is done by trying to toggle the carrier upon open/close and synchronize with the config change work. This allows propagate status correctly to stacked devices like: ip link add link enp0s3 macvlan0 type macvlan ip link set link

[PATCH net-next v3 2/3] virtio: allow driver to disable the configure change notification

2024-07-09 Thread Jason Wang
Sometime, it would be useful to disable the configure change notification from the driver. So this patch allows this by introducing a variable config_change_driver_disabled and only allow the configure change notification callback to be triggered when it is allowed by both the virtio core and the

[PATCH net-next v3 1/3] virtio: rename virtio_config_enabled to virtio_config_core_enabled

2024-07-09 Thread Jason Wang
Following patch will allow the config interrupt to be disabled by a specific driver via another boolean. So this patch renames virtio_config_enabled and relevant helpers to virtio_config_core_enabled. Cc: Venkat Venkatsubra Cc: Gia-Khanh Nguyen Signed-off-by: Jason Wang ---

[PATCH net-next v3 0/3] virtio-net: synchronize op/admin state

2024-07-09 Thread Jason Wang
Hi All: This series tries to synchronize the operstate with the admin state which allows the lower virtio-net to propagate the link status to the upper devices like macvlan. This is done by toggling carrier during ndo_open/stop. Changes since V2: - introduce config_driver_disabled and helpers

Re: [PATCH] vdpa/mlx5: Add the support of set mac address

2024-07-09 Thread Cindy Lu
On Mon, 8 Jul 2024 at 15:27, Dragos Tatulea wrote: > > On Mon, 2024-07-08 at 14:55 +0800, Cindy Lu wrote: > > Add the function to support setting the MAC address. > > For vdpa/mlx5, the function will use mlx5_mpfs_add_mac > > to set the mac address > > > > Tested in ConnectX-6 Dx device > > > >

Re: [PATCH] vdpa/mlx5: Add the support of set mac address

2024-07-09 Thread Cindy Lu
On Tue, 9 Jul 2024 at 12:56, Ratheesh Kannoth wrote: > > On 2024-07-08 at 12:25:49, Cindy Lu (l...@redhat.com) wrote: > > +static int mlx5_vdpa_set_attr_mac(struct vdpa_mgmt_dev *v_mdev, > > + struct vdpa_device *dev, > > + const struct

Re: [PATCH] vdpa/mlx5: Add the support of set mac address

2024-07-09 Thread Cindy Lu
On Mon, 8 Jul 2024 at 19:26, Michael S. Tsirkin wrote: > > On Mon, Jul 08, 2024 at 02:55:49PM +0800, Cindy Lu wrote: > > Add the function to support setting the MAC address. > > For vdpa/mlx5, the function will use mlx5_mpfs_add_mac > > to set the mac address > > > > Tested in ConnectX-6 Dx

Re: [PATCH] vdpa/mlx5: Add the support of set mac address

2024-07-09 Thread Cindy Lu
On Mon, 8 Jul 2024 at 15:03, Jason Wang wrote: > > On Mon, Jul 8, 2024 at 2:56 PM Cindy Lu wrote: > > > > Add the function to support setting the MAC address. > > For vdpa/mlx5, the function will use mlx5_mpfs_add_mac > > to set the mac address > > > > Tested in ConnectX-6 Dx device > > Great. >

Re: [PATCH v3] init: staging: Fix missing warning/taint on builtin code

2024-07-09 Thread Uwe Kleine-König
Hello, On Sat, Jul 06, 2024 at 12:15:01AM -0300, Ágatha Isabelle Chris Moreira Guedes wrote: > Fix the absence of warning message and kernel tainting when initializing > drivers from the `drivers/staging` subtree from initcalls (when > configured as built-in). > > When such a driver is built as

Re: [PATCH 4/6] pwm: Add tracing for waveform callbacks

2024-07-09 Thread Uwe Kleine-König
On Mon, Jul 08, 2024 at 02:14:09PM -0400, Trevor Gamblin wrote: > Missing a sign-off? Yes, and a commit log. Thanks for your review! Best regards Uwe signature.asc Description: PGP signature

[PATCH v4 3/5] arm64: dts: qcom: sdx75: update reserved memory regions for mpss

2024-07-09 Thread Naina Mehta
Rename qdss@8880 memory region as qlink_logging memory region and add qdss_mem memory region at address of 0x8850, qlink_logging is being added at the memory region at the address of 0x8880 as the region is being used by modem firmware. Since different DSM region size is required for

[PATCH v4 5/5] arm64: dts: qcom: sdx75-idp: enable MPSS remoteproc node

2024-07-09 Thread Naina Mehta
Enable MPSS remoteproc node on sdx75-idp platform. Signed-off-by: Naina Mehta Reviewed-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sdx75-idp.dts | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sdx75-idp.dts b/arch/arm64/boot/dts/qcom/sdx75-idp.dts

[PATCH v4 4/5] arm64: dts: qcom: sdx75: Add remoteproc node

2024-07-09 Thread Naina Mehta
Add MPSS remoteproc node for SDX75 SoC. Signed-off-by: Naina Mehta Reviewed-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sdx75.dtsi | 47 + 1 file changed, 47 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sdx75.dtsi b/arch/arm64/boot/dts/qcom/sdx75.dtsi

[PATCH v4 2/5] remoteproc: qcom: pas: Add SDX75 remoteproc support

2024-07-09 Thread Naina Mehta
Add MPSS Peripheral Authentication Service support for SDX75 platform. Signed-off-by: Naina Mehta --- drivers/remoteproc/qcom_q6v5_pas.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c index 8458bcfe9e19..833e2f9c2c5e

[PATCH v4 1/5] dt-bindings: remoteproc: qcom,sm8550-pas: document the SDX75 PAS

2024-07-09 Thread Naina Mehta
Document the MPSS Peripheral Authentication Service on SDX75 platform. Signed-off-by: Naina Mehta Reviewed-by: Krzysztof Kozlowski --- .../devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml| 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH v4 0/5] Add MPSS remoteproc support for SDX75

2024-07-09 Thread Naina Mehta
Add modem support to SDX75 using the PAS remoteproc driver. Also, add qlink_logging memory region and split MPSS DSM region into 2 separate regions. These patches were co-authored by Rohit Agarwal while at Qualcomm. Changes in v4: - Updated commit message for reserved memory updation for mpss

Re: [PATCH v2 4/4] EDAC/mce_amd: Add support for FRU Text in MCA

2024-07-09 Thread Naik, Avadhut
On 6/26/2024 13:20, Borislav Petkov wrote: > On Wed, Jun 26, 2024 at 01:00:30PM -0500, Naik, Avadhut wrote: >>> >>> Why are you clearing it if you're overwriting it immediately? >>> >> Since its a local variable, wanted to ensure that the memory is zeroed out >> to prevent >> any issues with

Re: [PATCH v2 2/4] x86/mce, EDAC/mce_amd: Add support for new MCA_SYND{1,2} registers

2024-07-09 Thread Naik, Avadhut
On 6/26/2024 13:18, Borislav Petkov wrote: > On Wed, Jun 26, 2024 at 12:24:20PM -0500, Naik, Avadhut wrote: >> >> >> On 6/26/2024 06:10, Borislav Petkov wrote: >>> On Tue, Jun 25, 2024 at 02:56:22PM -0500, Avadhut Naik wrote: AMD's Scalable MCA systems viz. Genoa will include two new

Re: [PATCH v3 0/2] vdpa: support set mac address from vdpa tool

2024-07-09 Thread Cindy Lu
On Tue, 9 Jul 2024 at 11:59, Parav Pandit wrote: > > Hi Cindy, > > > From: Cindy Lu > > Sent: Monday, July 8, 2024 12:17 PM > > > > Add support for setting the MAC address using the VDPA tool. > > This feature will allow setting the MAC address using the VDPA tool. > > For example, in

Re: [PATCH] rust: add `module_params` macro

2024-07-09 Thread nmi
Hi Luis, On Monday, July 8th, 2024 at 23:42, Luis Chamberlain wrote: > I'm starting to feel the same way about modules, but modules requires > more work than the firmware loader. And since I also know Andreas has > already a lot on his plate, I'm at a cross roads. My above request for > the

Re: [PATCH] vdpa/mlx5: Add the support of set mac address

2024-07-08 Thread Ratheesh Kannoth
On 2024-07-08 at 12:25:49, Cindy Lu (l...@redhat.com) wrote: > +static int mlx5_vdpa_set_attr_mac(struct vdpa_mgmt_dev *v_mdev, > + struct vdpa_device *dev, > + const struct vdpa_dev_set_config *add_config) > +{ > + struct

RE: [PATCH] vdpa/mlx5: Add the support of set mac address

2024-07-08 Thread Parav Pandit
Hi Andrew, > From: Andrew Lunn > Sent: Tuesday, July 9, 2024 12:31 AM > To: Cindy Lu > Cc: Dragos Tatulea ; m...@redhat.com; > jasow...@redhat.com; Parav Pandit ; > sgarz...@redhat.com; net...@vger.kernel.org; virtualization@lists.linux- > foundation.org; linux-kernel@vger.kernel.org;

RE: [PATCH v3 0/2] vdpa: support set mac address from vdpa tool

2024-07-08 Thread Parav Pandit
Hi Cindy, > From: Cindy Lu > Sent: Monday, July 8, 2024 12:17 PM > > Add support for setting the MAC address using the VDPA tool. > This feature will allow setting the MAC address using the VDPA tool. > For example, in vdpa_sim_net, the implementation sets the MAC address to > the config space.

Re: [PATCH] vdpa_sim_blk: add `capacity` module parameter

2024-07-08 Thread Jason Wang
On Mon, Jul 8, 2024 at 4:15 PM Stefano Garzarella wrote: > > Hi Cindy, Jason, > > On Mon, Jul 08, 2024 at 03:59:34PM GMT, Jason Wang wrote: > >On Mon, Jul 8, 2024 at 3:06 PM Cindy Lu wrote: > >> > >> On Fri, 5 Jul 2024 at 20:42, Stefano Garzarella > >> wrote: > >> > > >> > On Fri, Jul 05, 2024

Re: [PATCH v4 1/2] LoongArch: KVM: Add steal time support in kvm side

2024-07-08 Thread maobibo
On 2024/7/8 下午5:47, Huacai Chen wrote: On Mon, Jul 8, 2024 at 9:16 AM maobibo wrote: On 2024/7/6 下午5:41, Huacai Chen wrote: On Sat, Jul 6, 2024 at 2:59 PM maobibo wrote: Huacai, On 2024/7/6 上午11:00, Huacai Chen wrote: Hi, Bibo, On Fri, May 24, 2024 at 3:38 PM Bibo Mao wrote:

Re: [PATCH] kallsyms, livepatch: Fix livepatch with CONFIG_LTO_CLANG

2024-07-08 Thread Sami Tolvanen
On Mon, Jul 8, 2024 at 2:33 PM Luis Chamberlain wrote: > > Looking at this again its not to me why Masahiro Yamada's suggestion on > that old patch series to just increase the length and put long symbols > names into its own section [0] could not be embraced with a new kconfig > option, so new

[PATCH for-next v4] tracing/kprobes: Add symbol counting check when module loads

2024-07-08 Thread Masami Hiramatsu (Google)
From: Masami Hiramatsu (Google) Currently, kprobe event checks whether the target symbol name is unique or not, so that it does not put a probe on an unexpected place. But this skips the check if the target is on a module because the module may not be loaded. To fix this issue, this patch

[PATCH v4] perf,x86: avoid missing caller address in stack traces captured in uprobe

2024-07-08 Thread Andrii Nakryiko
When tracing user functions with uprobe functionality, it's common to install the probe (e.g., a BPF program) at the first instruction of the function. This is often going to be `push %rbp` instruction in function preamble, which means that within that function frame pointer hasn't been

Re: [PATCH] rust: add `module_params` macro

2024-07-08 Thread Luis Chamberlain
On Fri, Jul 05, 2024 at 11:15:11AM +, Andreas Hindborg wrote: > From: Andreas Hindborg > > This patch includes changes required for Rust kernel modules to utilize > module parameters. This code implements read only support for integer > types without `sysfs` support. > > This code is a

Re: [PATCH] kallsyms, livepatch: Fix livepatch with CONFIG_LTO_CLANG

2024-07-08 Thread Luis Chamberlain
On Thu, Jul 04, 2024 at 11:02:18AM +0200, Petr Mladek wrote: > On Wed 2024-07-03 08:30:33, Luis Chamberlain wrote: > > On Tue, Jul 02, 2024 at 10:56:41PM -0700, Josh Poimboeuf wrote: > > > On Mon, Jul 01, 2024 at 03:13:23PM +0200, Petr Mladek wrote: > > > > So, you suggest to search the symbols by

Re: [PATCH] vdpa/mlx5: Add the support of set mac address

2024-07-08 Thread Andrew Lunn
On Mon, Jul 08, 2024 at 02:55:49PM +0800, Cindy Lu wrote: > Add the function to support setting the MAC address. > For vdpa/mlx5, the function will use mlx5_mpfs_add_mac > to set the mac address > > Tested in ConnectX-6 Dx device > > Signed-off-by: Cindy Lu > --- >

Re: [PATCH 4/6] pwm: Add tracing for waveform callbacks

2024-07-08 Thread Trevor Gamblin
Missing a sign-off? On 2024-07-08 6:52 a.m., Uwe Kleine-König wrote: --- drivers/pwm/core.c | 68 --- include/trace/events/pwm.h | 134 ++--- 2 files changed, 183 insertions(+), 19 deletions(-) diff --git a/drivers/pwm/core.c

Re: [PATCH v2 05/12] uprobes: move offset and ref_ctr_offset into uprobe_consumer

2024-07-08 Thread Andrii Nakryiko
On Sun, Jul 7, 2024 at 5:50 AM Oleg Nesterov wrote: > > On 07/01, Andrii Nakryiko wrote: > > > > --- a/include/linux/uprobes.h > > +++ b/include/linux/uprobes.h > > @@ -42,6 +42,11 @@ struct uprobe_consumer { > > enum uprobe_filter_ctx ctx, > >

Re: [PATCH v2 00/12] uprobes: add batched register/unregister APIs and per-CPU RW semaphore

2024-07-08 Thread Andrii Nakryiko
On Thu, Jul 4, 2024 at 2:16 AM Peter Zijlstra wrote: > > On Wed, Jul 03, 2024 at 02:33:06PM -0700, Andrii Nakryiko wrote: > > > 2. More tactically, RCU protection seems like the best way forward. We > > got hung up on SRCU vs RCU Tasks Trace. Thanks to Paul, we also > > clarified that RCU Tasks

Re: [PATCH v2 00/12] uprobes: add batched register/unregister APIs and per-CPU RW semaphore

2024-07-08 Thread Andrii Nakryiko
On Thu, Jul 4, 2024 at 8:44 AM Paul E. McKenney wrote: > > On Thu, Jul 04, 2024 at 11:15:59AM +0200, Peter Zijlstra wrote: > > On Wed, Jul 03, 2024 at 02:33:06PM -0700, Andrii Nakryiko wrote: > > > > > 2. More tactically, RCU protection seems like the best way forward. We > > > got hung up on

Re: [PATCH v2 04/12] uprobes: revamp uprobe refcounting and lifetime management

2024-07-08 Thread Andrii Nakryiko
On Sun, Jul 7, 2024 at 7:48 AM Oleg Nesterov wrote: > > And I forgot to mention... > > In any case __uprobe_unregister() can't ignore the error code from > register_for_each_vma(). If it fails to restore the original insn, > we should not remove this uprobe from uprobes_tree. > > Otherwise the

Re: [PATCH v2 04/12] uprobes: revamp uprobe refcounting and lifetime management

2024-07-08 Thread Andrii Nakryiko
On Fri, Jul 5, 2024 at 8:38 AM Oleg Nesterov wrote: > > Tried to read this patch, but I fail to understand it. It looks > obvioulsy wrong to me, see below. > > I tend to agree with the comments from Peter, but lets ignore them > for the moment. > > On 07/01, Andrii Nakryiko wrote: > > > > static

Re: [PATCH] mailmap: Update Luca Weiss's email address

2024-07-08 Thread Bjorn Andersson
On Fri, 28 Jun 2024 19:40:55 +0200, Luca Weiss wrote: > I'm slowly migrating my mail to a new domain, add an entry to map the > mail address. Just for clarity, my work-related @fairphone.com email > stays unchanged. > > Applied, thanks! [1/1] mailmap: Update Luca Weiss's email address

Re: [PATCH vhost 20/23] vdpa/mlx5: Pre-create hardware VQs at vdpa .dev_add time

2024-07-08 Thread Dragos Tatulea
Hi Zhu Yanjun, On Mon, 2024-07-08 at 18:22 +0200, Zhu Yanjun wrote: > 在 2024/6/17 17:07, Dragos Tatulea 写道: > > Currently, hardware VQs are created right when the vdpa device gets into > > DRIVER_OK state. That is easier because most of the VQ state is known by > > then. > > > > This patch

Re: [PATCH vhost 20/23] vdpa/mlx5: Pre-create hardware VQs at vdpa .dev_add time

2024-07-08 Thread Zhu Yanjun
在 2024/6/17 17:07, Dragos Tatulea 写道: Currently, hardware VQs are created right when the vdpa device gets into DRIVER_OK state. That is easier because most of the VQ state is known by then. This patch switches to creating all VQs and their associated resources at device creation time. The

Re: [PATCH] remoteproc: mediatek: Increase MT8188/MT8195 SCP core0 DRAM size

2024-07-08 Thread Mathieu Poirier
On Wed, Jul 03, 2024 at 11:05:59AM +0200, AngeloGioacchino Del Regno wrote: > Il 03/07/24 05:44, Jason Chen ha scritto: > > The current DRAM size is insufficient for the HEVC feature, which > > requires more memory for proper functionality. This change ensures the > > feature has the necessary

Re: [PATCH v8 2/5] remoteproc: Add TEE support

2024-07-08 Thread Mathieu Poirier
On Fri, Jul 05, 2024 at 09:33:55AM +0200, Arnaud POULIQUEN wrote: > > > On 7/4/24 17:32, Mathieu Poirier wrote: > > On Thu, Jul 04, 2024 at 10:05:24AM +0200, Arnaud POULIQUEN wrote: > >> > >> > >> On 7/3/24 17:14, Mathieu Poirier wrote: > >>> On Wed, Jul 03, 2024 at 09:19:44AM +0200, Arnaud

Re: [PATCH v3] init: staging: Fix missing warning/taint on builtin code

2024-07-08 Thread Dan Carpenter
Thanks! Acked-by: Dan Carpenter regards, dan carpenter

Re: [PATCH 2/2] x86/vmware: VMware support for TDX userspace hypercalls

2024-07-08 Thread Kirill A . Shutemov
On Wed, Jul 03, 2024 at 11:36:01PM +, Tim Merrifield wrote: > @@ -539,6 +547,24 @@ unsigned long vmware_tdx_hypercall(unsigned long cmd, > return args.r12; > } > EXPORT_SYMBOL_GPL(vmware_tdx_hypercall); > + > +static bool vmware_tdx_user_hcall(struct pt_regs *regs) > +{ > + struct

Re: [PATCH 1/2] x86/tdx: Add prctl to allow userlevel TDX hypercalls

2024-07-08 Thread Kirill A . Shutemov
On Wed, Jul 03, 2024 at 11:36:00PM +, Tim Merrifield wrote: > Add a new prctl option to enable/disable user-level hypercalls when > running in a confidential VM. Add support for checking this flag on > VMCALL #VE for TDX and transfer control to a hypervisor > vendor-specific handler. > >

[PATCH vhost v3 23/24] vdpa/mlx5: Don't reset VQs more than necessary

2024-07-08 Thread Dragos Tatulea
The vdpa device can be reset many times in sequence without any significant state changes in between. Previously this was not a problem: VQs were torn down only on first reset. But after VQ pre-creation was introduced, each reset will delete and re-create the hardware VQs and their associated

[PATCH vhost v3 20/24] vdpa/mlx5: Use suspend/resume during VQP change

2024-07-08 Thread Dragos Tatulea
Resume a VQ if it is already created when the number of VQ pairs increases. This is done in preparation for VQ pre-creation which is coming in a later patch. It is necessary because calling setup_vq() on an already created VQ will return early and will not enable the queue. For symmetry, suspend

[PATCH vhost v3 24/24] vdpa/mlx5: Don't enable non-active VQs in .set_vq_ready()

2024-07-08 Thread Dragos Tatulea
VQ indices in the range [cur_num_qps, max_vqs) represent queues that have not yet been activated. .set_vq_ready should not activate these VQs. Reviewed-by: Cosmin Ratiu Acked-by: Eugenio Pérez Signed-off-by: Dragos Tatulea --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 3 +++ 1 file changed, 3

[PATCH vhost v3 19/24] vdpa/mlx5: Forward error in suspend/resume device

2024-07-08 Thread Dragos Tatulea
Start using the suspend/resume_vq() error return codes previously added. Reviewed-by: Cosmin Ratiu Reviewed-by: Zhu Yanjun Reviewed-by: Eugenio Pérez Signed-off-by: Dragos Tatulea --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff

[PATCH vhost v3 22/24] vdpa/mlx5: Re-create HW VQs under certain conditions

2024-07-08 Thread Dragos Tatulea
There are a few conditions under which the hardware VQs need a full teardown and setup: - VQ size changed to something else than default value. Hardware VQ size modification is not supported. - User turns off certain device features: mergeable buffers, checksum virtio 1.0 compliance. In

[PATCH vhost v3 18/24] vdpa/mlx5: Consolidate all VQ modify to Ready to use resume_vq()

2024-07-08 Thread Dragos Tatulea
There are a few more places modifying the VQ to Ready directly. Let's consolidate them into resume_vq(). The redundant warnings for resume_vq() errors can also be dropped. There is one special case that needs to be handled for virtio-vdpa: the initialized flag must be set to true earlier in

[PATCH vhost v3 21/24] vdpa/mlx5: Pre-create hardware VQs at vdpa .dev_add time

2024-07-08 Thread Dragos Tatulea
Currently, hardware VQs are created right when the vdpa device gets into DRIVER_OK state. That is easier because most of the VQ state is known by then. This patch switches to creating all VQs and their associated resources at device creation time. The motivation is to reduce the vdpa device live

[PATCH vhost v3 16/24] vdpa/mlx5: Accept Init -> Ready VQ transition in resume_vq()

2024-07-08 Thread Dragos Tatulea
Until now resume_vq() was used only for the suspend/resume scenario. This change also allows calling resume_vq() to bring it from Init to Ready state (VQ initialization). Reviewed-by: Cosmin Ratiu Acked-by: Eugenio Pérez Signed-off-by: Dragos Tatulea --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 24

[PATCH vhost v3 17/24] vdpa/mlx5: Add error code for suspend/resume VQ

2024-07-08 Thread Dragos Tatulea
Instead of blindly calling suspend/resume_vqs(), make then return error codes. To keep compatibility, keep suspending or resuming VQs on error and return the last error code. The assumption here is that the error code would be the same. Reviewed-by: Cosmin Ratiu Acked-by: Eugenio Pérez

[PATCH vhost v3 14/24] vdpa/mlx5: Set mkey modified flags on all VQs

2024-07-08 Thread Dragos Tatulea
Otherwise, when virtqueues are moved from INIT to READY the latest mkey will not be set appropriately. Reviewed-by: Cosmin Ratiu Acked-by: Eugenio Pérez Signed-off-by: Dragos Tatulea --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH vhost v3 13/24] vdpa/mlx5: Start off rqt_size with max VQPs

2024-07-08 Thread Dragos Tatulea
Currently rqt_size is initialized during device flag configuration. That's because it is the earliest moment when device knows if MQ (multi queue) is on or off. Shift this configuration earlier to device creation time. This implies that non-MQ devices will have a larger RQT size. But the

[PATCH vhost v3 12/24] vdpa/mlx5: Set an initial size on the VQ

2024-07-08 Thread Dragos Tatulea
The virtqueue size is a pre-requisite for setting up any virtqueue resources. For the upcoming optimization of creating virtqueues at device add, the virtqueue size has to be configured. The queue size check in setup_vq() will always be false. So remove it. Signed-off-by: Dragos Tatulea

[PATCH vhost v3 15/24] vdpa/mlx5: Allow creation of blank VQs

2024-07-08 Thread Dragos Tatulea
Based on the filled flag, create VQs that are filled or blank. Blank VQs will be filled in later through VQ modify. Later patches will make use of this to pre-create blank VQs at vdpa device creation. Reviewed-by: Cosmin Ratiu Acked-by: Eugenio Pérez Signed-off-by: Dragos Tatulea ---

[PATCH vhost v3 07/24] vdpa/mlx5: Initialize and reset device with one queue pair

2024-07-08 Thread Dragos Tatulea
The virtio spec says that a vdpa device should start off with one queue pair. The driver is already compliant. This patch moves the initialization to device add and reset times. This is done in preparation for the pre-creation of hardware virtqueues at device add time. Reviewed-by: Cosmin Ratiu

[PATCH vhost v3 03/24] vdpa/mlx5: Drop redundant code

2024-07-08 Thread Dragos Tatulea
Originally, the second loop initialized the CVQ. But (acde3929492b ("vdpa/mlx5: Use consistent RQT size") initialized all the queues in the first loop, so the second iteration in init_mvqs() is never called because the first one will iterate up to max_vqs. Reviewed-by: Cosmin Ratiu Acked-by:

[PATCH vhost v3 06/24] vdpa/mlx5: Remove duplicate suspend code

2024-07-08 Thread Dragos Tatulea
Use the dedicated suspend_vqs() function instead. Reviewed-by: Cosmin Ratiu Reviewed-by: Eugenio Pérez Signed-off-by: Dragos Tatulea --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c

[PATCH vhost v3 11/24] vdpa/mlx5: Add support for modifying the VQ features field

2024-07-08 Thread Dragos Tatulea
This is done in preparation for the pre-creation of hardware virtqueues at device add time. Signed-off-by: Dragos Tatulea Reviewed-by: Cosmin Ratiu --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 12 +++- include/linux/mlx5/mlx5_ifc_vdpa.h | 1 + 2 files changed, 12 insertions(+), 1

[PATCH vhost v3 10/24] vdpa/mlx5: Add support for modifying the virtio_version VQ field

2024-07-08 Thread Dragos Tatulea
This is done in preparation for the pre-creation of hardware virtqueues at device add time. Signed-off-by: Dragos Tatulea Reviewed-by: Cosmin Ratiu --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 16 include/linux/mlx5/mlx5_ifc_vdpa.h | 1 + 2 files changed, 17 insertions(+) diff

  1   2   3   4   5   6   7   8   9   10   >