Re: [PATCH 3/5] ASoC: rt5682: clock driver must use the clock provider API

2021-04-13 Thread Jerome Brunet
On Mon 12 Apr 2021 at 22:27, Stephen Boyd wrote: > Quoting Jerome Brunet (2021-04-10 04:13:54) >> Clock drivers ops should not the clk API but the clock provider (clk_hw) >> instead. >> >> Signed-off-by: Jerome Brunet >> --- >> sound/soc/codecs/rt

[PATCH] ASoC: meson: axg-frddr: fix fifo depth on g12 and sm1

2021-04-12 Thread Jerome Brunet
: 6f68accaa864 ("ASoC: meson: axg-frddr: set fifo depth according to the period") Reported-by: Christian Hewitt Tested-by: Christian Hewitt Signed-off-by: Jerome Brunet --- sound/soc/meson/axg-frddr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/meson/axg-frddr.c b

Re: [PATCH 4/5] ASoC: lpass: use the clock provider API

2021-04-12 Thread Jerome Brunet
On Mon 12 Apr 2021 at 11:38, Srinivas Kandagatla wrote: > Thanks Jerome for the patch, > > > On 10/04/2021 12:13, Jerome Brunet wrote: >> Clock providers should be registered using the clk_hw API. >> Signed-off-by: Jerome Brunet >> --- >> so

[PATCH 5/5] ASoC: da7219: properly get clk from the provider

2021-04-10 Thread Jerome Brunet
Instead of using the clk embedded in the clk_hw (which is meant to go away), a clock provider which need to interact with its own clock should request clk reference through the clock provider API. Signed-off-by: Jerome Brunet --- sound/soc/codecs/da7219.c | 5 - 1 file changed, 4 insertions

[PATCH 2/5] ASoC: wcd934x: use the clock provider API

2021-04-10 Thread Jerome Brunet
Clock providers should use the clk_hw API Signed-off-by: Jerome Brunet --- sound/soc/codecs/wcd934x.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/wcd934x.c b/sound/soc/codecs/wcd934x.c index 5fe403307b72..ae3ea136a9f8 100644 --- a/sound/soc/codecs

[PATCH 4/5] ASoC: lpass: use the clock provider API

2021-04-10 Thread Jerome Brunet
Clock providers should be registered using the clk_hw API. Signed-off-by: Jerome Brunet --- sound/soc/codecs/lpass-va-macro.c | 2 +- sound/soc/codecs/lpass-wsa-macro.c | 9 +++-- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/sound/soc/codecs/lpass-va-macro.c b/sound/soc

[PATCH 3/5] ASoC: rt5682: clock driver must use the clock provider API

2021-04-10 Thread Jerome Brunet
Clock drivers ops should not the clk API but the clock provider (clk_hw) instead. Signed-off-by: Jerome Brunet --- sound/soc/codecs/rt5682.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/rt5682.c b/sound/soc/codecs/rt5682.c index 0e2a10ed11da

[PATCH 1/5] ASoC: stm32: properly get clk from the provider

2021-04-10 Thread Jerome Brunet
Instead of using the clk embedded in the clk_hw (which is meant to go away), a clock provider which need to interact with its own clock should request clk reference through the clock provider API. Signed-off-by: Jerome Brunet --- sound/soc/stm/stm32_sai_sub.c | 5 - 1 file changed, 4

[PATCH 0/5] ASoC: clock provider clean-up

2021-04-10 Thread Jerome Brunet
categories: * Mis-usage of the clock consumer API by a clock provider. * Clock provider also being a user of its own clocks. In this case the provider should request a 'struct clk' through the appropriate API instead of poking in 'struct clk_hw' internals. Jerome Brunet (5): ASoC: stm32: properly

[PATCH] ASoC: meson: axg-fifo: add NO_PERIOD_WAKEUP support

2021-04-07 Thread Jerome Brunet
. Signed-off-by: Jerome Brunet --- sound/soc/meson/axg-fifo.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/sound/soc/meson/axg-fifo.c b/sound/soc/meson/axg-fifo.c index b2e867113226..b9af2d513e09 100644 --- a/sound/soc/meson/axg-fifo.c +++ b/sound/soc/meson/axg

[PATCH] ASoC: meson: axg-frddr: set fifo depth according to the period

2021-04-07 Thread Jerome Brunet
When the period is small, using all the FRDDR fifo depth increases the latency of the playback because the following device won't start pulling data until the fifo reaches the depth set. We can adjust this depth so trim it down for small periods. Signed-off-by: Jerome Brunet --- sound/soc/meson

[PATCH v3 4/4] usb: gadget: u_audio: clean up locking

2021-01-18 Thread Jerome Brunet
the irqs is not necessary. Acked-by: Felipe Balbi Signed-off-by: Jerome Brunet --- drivers/usb/gadget/function/u_audio.c | 23 --- 1 file changed, 4 insertions(+), 19 deletions(-) diff --git a/drivers/usb/gadget/function/u_audio.c b/drivers/usb/gadget/function/u_audio.c index

[PATCH v3 3/4] usb: gadget: u_audio: remove struct uac_req

2021-01-18 Thread Jerome Brunet
-by: Felipe Balbi Signed-off-by: Jerome Brunet --- drivers/usb/gadget/function/u_audio.c | 58 --- 1 file changed, 26 insertions(+), 32 deletions(-) diff --git a/drivers/usb/gadget/function/u_audio.c b/drivers/usb/gadget/function/u_audio.c index 27f941f71a9d..a1a1f4c8685c

[PATCH v3 1/4] usb: gadget: u_audio: Free requests only after callback

2021-01-18 Thread Jerome Brunet
lf in case the ep is disabled. Fixes: eb9fecb9e69b0 ("usb: gadget: f_uac2: split out audio core") Reported-and-tested-by: Ferry Toth Reviewed-and-tested-by: Peter Chen Signed-off-by: Jack Pham Signed-off-by: Jerome Brunet Acked-by: Felipe Balbi --- drivers/usb/gadget/fun

[PATCH v3 0/4] usb: gadget: audio fixes and clean ups

2021-01-18 Thread Jerome Brunet
: u_audio: Free requests only after callback Jerome Brunet (3): usb: gadget: u_audio: factorize ssize to alsa fmt conversion usb: gadget: u_audio: remove struct uac_req usb: gadget: u_audio: clean up locking drivers/usb/gadget/function/u_audio.c | 135 -- 1 file

[PATCH v3 2/4] usb: gadget: u_audio: factorize ssize to alsa fmt conversion

2021-01-18 Thread Jerome Brunet
Factorize format related code common to the capture and playback path. Acked-by: Felipe Balbi Signed-off-by: Jerome Brunet --- drivers/usb/gadget/function/u_audio.c | 43 +-- 1 file changed, 21 insertions(+), 22 deletions(-) diff --git a/drivers/usb/gadget/function

[PATCH v2 5/5] usb: gadget: u_audio: clean up locking

2021-01-06 Thread Jerome Brunet
the irqs is not necessary. Signed-off-by: Jerome Brunet --- drivers/usb/gadget/function/u_audio.c | 23 --- 1 file changed, 4 insertions(+), 19 deletions(-) diff --git a/drivers/usb/gadget/function/u_audio.c b/drivers/usb/gadget/function/u_audio.c index 1d12657b3b73..e985630fbe6e

[PATCH v2 4/5] usb: gadget: u_audio: remove struct uac_req

2021-01-06 Thread Jerome Brunet
-by: Jerome Brunet --- drivers/usb/gadget/function/u_audio.c | 58 --- 1 file changed, 26 insertions(+), 32 deletions(-) diff --git a/drivers/usb/gadget/function/u_audio.c b/drivers/usb/gadget/function/u_audio.c index 045f237472a7..1d12657b3b73 100644 --- a/drivers/usb

[PATCH v2 3/5] usb: gadget: u_audio: factorize ssize to alsa fmt conversion

2021-01-06 Thread Jerome Brunet
Factorize format related code common to the capture and playback path. Signed-off-by: Jerome Brunet --- drivers/usb/gadget/function/u_audio.c | 43 +-- 1 file changed, 21 insertions(+), 22 deletions(-) diff --git a/drivers/usb/gadget/function/u_audio.c b/drivers/usb

[PATCH v2 1/5] usb: gadget: u_audio: Free requests only after callback

2021-01-06 Thread Jerome Brunet
lf in case the ep is disabled. Fixes: eb9fecb9e69b0 ("usb: gadget: f_uac2: split out audio core") Reported-and-tested-by: Ferry Toth Reviewed-and-tested-by: Peter Chen Signed-off-by: Jack Pham Signed-off-by: Jerome Brunet --- drivers/usb/gadget/function/u_audio.c | 12 +--

[PATCH v2 2/5] usb: gadget: f_uac2: reset wMaxPacketSize

2021-01-06 Thread Jerome Brunet
e endpoint maximum packet size and mark wMaxPacketSize as dynamic to solve the problem. Fixes: 913e4a90b6f9 ("usb: gadget: f_uac2: finalize wMaxPacketSize according to bandwidth") Signed-off-by: Jerome Brunet --- drivers/usb/gadget/function/f_uac2.c | 69 ++--

[PATCH v2 0/5] usb: gadget: audio fixes and clean ups

2021-01-06 Thread Jerome Brunet
...@baylibre.com [2]: https://lore.kernel.org/r/202012291638.qidqi3gs-...@intel.com Jack Pham (1): usb: gadget: u_audio: Free requests only after callback Jerome Brunet (4): usb: gadget: f_uac2: reset wMaxPacketSize usb: gadget: u_audio: factorize ssize to alsa fmt conversion usb: gadget

Re: [PATCH 3/4] usb: gadget: u_audio: remove struct uac_req

2021-01-04 Thread Jerome Brunet
On Tue 29 Dec 2020 at 23:30, Jack Pham wrote: > Hi Greg and Jerome, > > On Mon, Dec 28, 2020 at 04:01:46PM +0100, Greg Kroah-Hartman wrote: >> On Mon, Dec 21, 2020 at 06:35:30PM +0100, Jerome Brunet wrote: >> > 'struct uac_req' purpose is to link 'struct usb_request' t

Re: [PATCH 0/2] clk: meson8b: cleanup unused code

2021-01-04 Thread Jerome Brunet
On Mon 21 Dec 2020 at 19:36, Martin Blumenstingl wrote: > Hi Jerome, > > these patches are two small cleanups for code we don't need anymore. > The first patch removes support for old .dtbs. I am not sure if the > "fallback" logic still works as I have not tried this in a long time. > > >

Re: [PATCH 0/3] clk: meson: three small clk-pll fixes

2021-01-04 Thread Jerome Brunet
On Sat 26 Dec 2020 at 13:15, Martin Blumenstingl wrote: > Hi Jerome, > > while working on some changes for the 32-bit SoCs I hit a corner-case > in the HDMI PLL: there's some rate doubling going. The PLL only locks > in a specific rate range but the M/N table is not aware of that. This >

Re: [PATCH 1/3] clk: meson: clk-pll: fix initializing the old rate (fallback) for a PLL

2021-01-04 Thread Jerome Brunet
On Sat 26 Dec 2020 at 13:15, Martin Blumenstingl wrote: > The "rate" parameter in meson_clk_pll_set_rate() contains the new rate. > Retrieve the old rate with clk_hw_get_rate() so we don't inifinitely try > to switch from the new rate to the same ratte again. Small typo above fixed while

Re: [PATCH 0/2] clk: meson: axg: Remove MIPI enable clock gate

2021-01-04 Thread Jerome Brunet
On Tue 10 Mar 2020 at 09:05, Jerome Brunet wrote: > On Mon 09 Mar 2020 at 22:01, Remi Pommarel wrote: > >> As discussed here [0], HHI_MIPI_CNTL0 is part of the MIPI/PCIe analog >> PHY region and is not related to clock one. Since MIPI/PCIe PHY driver >> has been add

[PATCH 2/4] usb: gadget: u_audio: factorize ssize to alsa fmt conversion

2020-12-21 Thread Jerome Brunet
Factorize format related code common to the capture and playback path. Signed-off-by: Jerome Brunet --- drivers/usb/gadget/function/u_audio.c | 43 +-- 1 file changed, 21 insertions(+), 22 deletions(-) diff --git a/drivers/usb/gadget/function/u_audio.c b/drivers/usb

[PATCH 1/4] usb: gadget: f_uac2: reset wMaxPacketSize

2020-12-21 Thread Jerome Brunet
e endpoint maximum packet size and mark wMaxPacketSize as dynamic to solve the problem. Fixes: 913e4a90b6f9 ("usb: gadget: f_uac2: finalize wMaxPacketSize according to bandwidth") Signed-off-by: Jerome Brunet --- drivers/usb/gadget/function/f_uac2.c | 69 ++--

[PATCH 4/4] usb: gadget: u_audio: clean up locking

2020-12-21 Thread Jerome Brunet
the irqs is not necessary. Signed-off-by: Jerome Brunet --- drivers/usb/gadget/function/u_audio.c | 23 --- 1 file changed, 4 insertions(+), 19 deletions(-) diff --git a/drivers/usb/gadget/function/u_audio.c b/drivers/usb/gadget/function/u_audio.c index 3eba31b8ebcb..d94f95edca40

[PATCH 0/4] usb: gadget: audio fixes and clean ups

2020-12-21 Thread Jerome Brunet
This patchset is a collection of fixes and clean ups found while working on the uac2 gadget. Details are provided in each change. The series depends on this fix [0] by Jack Pham to apply cleanly [0]: https://lore.kernel.org/linux-usb/20201029175949.6052-1-ja...@codeaurora.org/ Jerome Brunet (4

[PATCH 3/4] usb: gadget: u_audio: remove struct uac_req

2020-12-21 Thread Jerome Brunet
-by: Jerome Brunet --- drivers/usb/gadget/function/u_audio.c | 58 --- 1 file changed, 26 insertions(+), 32 deletions(-) diff --git a/drivers/usb/gadget/function/u_audio.c b/drivers/usb/gadget/function/u_audio.c index 2f69bd572ed7..3eba31b8ebcb 100644 --- a/drivers/usb

[PATCH] ASoC: meson: axg-tdm-interface: fix loopback

2020-12-17 Thread Jerome Brunet
lves the problem. Fixes: 8dd26dff00c0 ("ASoC: dapm: Fix handling of custom_stop_condition on DAPM graph walks") Cc: Charles Keepax Signed-off-by: Jerome Brunet --- sound/soc/meson/axg-tdm-interface.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git

[PATCH] ASoC: meson: axg-tdmin: fix axg skew offset

2020-12-17 Thread Jerome Brunet
Signed-off-by: Jerome Brunet --- sound/soc/meson/axg-tdmin.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/sound/soc/meson/axg-tdmin.c b/sound/soc/meson/axg-tdmin.c index 88ed95ae886b..b4faf9d5c1aa 100644 --- a/sound/soc/meson/axg-tdmin.c +++ b/sound/soc/meson/a

Re: [PATCH 2/2] arm64: dts: meson: vim3: enable hdmi audio loopback

2020-12-15 Thread Jerome Brunet
On Mon 07 Dec 2020 at 10:53, Jerome Brunet wrote: > Enable audio capture frontends and a tdm decoder. > This makes it possible to loopback the audio played on the hdmi codec, > which is the only output interface at the moment. > > Of course, one TODDR device would

Re: 0001-add-amlogic-gpio-to-irq

2020-12-07 Thread Jerome Brunet
On Mon 07 Dec 2020 at 13:34, Linus Walleij wrote: > On Mon, Dec 7, 2020 at 12:07 PM Jerome Brunet wrote: >> On Mon 07 Dec 2020 at 11:18, Andy Shevchenko >> wrote: >> > On Fri, Dec 4, 2020 at 4:25 PM Jerome Brunet wrote: >> >> On Fri 04 Dec 2020 a

Re: 0001-add-amlogic-gpio-to-irq

2020-12-07 Thread Jerome Brunet
On Mon 07 Dec 2020 at 11:18, Andy Shevchenko wrote: > On Fri, Dec 4, 2020 at 4:25 PM Jerome Brunet wrote: >> On Fri 04 Dec 2020 at 10:13, Linus Walleij wrote: > >> This HW only has 8 irqs that can each be mapped to a pin. No direct >> translation can be made, we

[PATCH 2/2] arm64: dts: meson: vim3: enable hdmi audio loopback

2020-12-07 Thread Jerome Brunet
the same on the capture side. Signed-off-by: Jerome Brunet --- .../boot/dts/amlogic/meson-khadas-vim3.dtsi | 41 +-- 1 file changed, 37 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi b/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi

[PATCH 1/2] arm64: dts: meson: vim3: whitespace fixups

2020-12-07 Thread Jerome Brunet
Spaces have been used to indent 2 nodes. Replace those with tabs and remove one extra newline Signed-off-by: Jerome Brunet --- .../boot/dts/amlogic/meson-khadas-vim3.dtsi | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/arch/arm64/boot/dts/amlogic/meson

[PATCH 0/2] arm64: dts: meson: vim3: enable hdmi audio loopback

2020-12-07 Thread Jerome Brunet
This patchset enable the hdmi audio loopback on the vim3 and vim3l. I found a few whitespace errors while doing it. This is sent along to avoid annoying conflicts. Jerome Brunet (2): arm64: dts: meson: vim3: whitespace fixups arm64: dts: meson: vim3: enable hdmi audio loopback .../boot/dts

Re: [PATCH] net: stmmac: dwmac-meson8b: fix mask definition of the m250_sel mux

2020-12-07 Thread Jerome Brunet
BB DWMAC") > Signed-off-by: Martin Blumenstingl Reviewed-by: Jerome Brunet > --- > drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c > b/dr

Re: [PATCH] clk: meson: g12a: select COMMON_CLK_MESON_VID_PLL_DIV

2020-12-04 Thread Jerome Brunet
On Thu 03 Dec 2020 at 23:26, Arnd Bergmann wrote: > From: Arnd Bergmann > > Without this, a g12a-only config produces a link error: > > aarch64-linux-ld: drivers/clk/meson/g12a.o:(.data+0xcb68): undefined > reference to `meson_vid_pll_div_ro_ops' > > Fixes: 085a4ea93d54 ("clk: meson: g12a:

Re: 0001-add-amlogic-gpio-to-irq

2020-12-04 Thread Jerome Brunet
On Fri 04 Dec 2020 at 10:13, Linus Walleij wrote: > Hi Lisheng, > > this patch got a bit mangled but I get where you're going. > > I think Meson needs to be augmented to use hierarchical gpiolib irqchip > because this seems to be what the system is doing. > > So start with

Re: [PATCH v3 0/7] arm64: dts: meson: add more GX soundcards

2020-12-02 Thread Jerome Brunet
dts | 40 > .../dts/amlogic/meson-gxbb-wetek-play2.dts| 61 +++ > .../amlogic/meson-gxl-s905x-khadas-vim.dts| 43 - > .../dts/amlogic/meson-gxm-khadas-vim2.dts | 44 - > 7 files changed, 303 insertions(+), 5 deletions(-) Minor comment on patch 3 Minus that: Acked-by: Jerome Brunet

Re: [PATCH v3 3/7] arm64: dts: meson: add audio playback to khadas-vim2

2020-12-02 Thread Jerome Brunet
On Mon 16 Nov 2020 at 07:20, Christian Hewitt wrote: > Add initial audio support limited to HDMI i2s. > > Signed-off-by: Christian Hewitt > --- > .../dts/amlogic/meson-gxm-khadas-vim2.dts | 44 +-- > 1 file changed, 41 insertions(+), 3 deletions(-) > > diff --git

Re: [PATCH] arm64: dts: meson: fix PHY deassert timing requirements

2020-12-01 Thread Jerome Brunet
On Tue 01 Dec 2020 at 01:25, Stefan Agner wrote: > According to the datasheet (Rev. 1.4, page 30) the RTL8211F requires > at least 50ms "for internal circuits settling time" before accessing > the PHY registers. This fixes an issue where the Ethernet link doesn't > come up when using ip link

Re: [PATCH v2 0/2] clk: meson: g12a: add MIPI DSI Host Pixel Clock

2020-11-26 Thread Jerome Brunet
On Thu 26 Nov 2020 at 15:15, Neil Armstrong wrote: > This serie adss the MIPI DSI Host Pixel Clock used to feed the DSI pixel > clock to the DSI Host controller. > > Unlike the AXG SoC, the DSI Pixel Clock has a supplementary mux, divider and > gate > stage before feeding the pixel clock to

Re: [PATCH net-next 06/15] net: phy: meson-gxl: remove the use of .ack_callback()

2020-11-26 Thread Jerome Brunet
able_interrupts), with > equivalent functionality. > > This means that clearing interrupts now becomes something that the PHY > driver is responsible of doing, before enabling interrupts and after > clearing them. Make this driver follow the new contract. > > Cc: Jerome Brunet

Re: [PATCH 2/2] clk: meson: g12a: add MIPI DSI Host Pixel Clock

2020-11-25 Thread Jerome Brunet
On Mon 23 Nov 2020 at 17:38, Neil Armstrong wrote: > This adds the MIPI DSI Host Pixel Clock, unlike AXG, the pixel clock can be > different > from the VPU ENCL output clock to feed the DSI Host controller with a > different clock rate. > > Signed-off-by: Neil Armstrong Series looks good.

Re: [PATCH 1/2] drm/meson: dw-hdmi: Disable clocks on driver teardown

2020-11-23 Thread Jerome Brunet
On Fri 20 Nov 2020 at 10:42, Marc Zyngier wrote: > The HDMI driver request clocks early, but never disable them, leaving > the clocks on even when the driver is removed. > > Fix it by slightly refactoring the clock code, and register a devm > action that will eventually disable/unprepare the

Re: next/master bisection: baseline.dmesg.emerg on meson-gxbb-p200

2020-11-19 Thread Jerome Brunet
On Thu 19 Nov 2020 at 19:04, Guillaume Tucker wrote: > Hi Marc, > > On 19/11/2020 11:58, Marc Zyngier wrote: >> On 2020-11-19 10:26, Neil Armstrong wrote: >>> On 19/11/2020 11:20, Marc Zyngier wrote: On 2020-11-19 08:50, Guillaume Tucker wrote: > Please see the automated bisection

[PATCH] ASoC: meson: fix COMPILE_TEST error

2020-11-16 Thread Jerome Brunet
of error: > aiu-encoder-spdif.c:(.text+0x3a0): undefined reference to `clk_set_parent' Since we need a sane provider of the API with COMPILE_TEST, depends on COMMON_CLK. Fixes: 6dc4fa179fb8 ("ASoC: meson: add axg fifo base driver") Reported-by: kernel test robot Signed-off-by:

[PATCH] arm64: meson: select COMMON_CLK

2020-11-16 Thread Jerome Brunet
t;) Signed-off-by: Jerome Brunet --- This fix is a side effect of this 0day report: https://lore.kernel.org/r/202011151309.dvcsullh-...@intel.com It shows that we need to select an implementation of clk.h arch/arm64/Kconfig.platforms | 1 + 1 file changed, 1 insertion(+) diff --git a/

Re: [PATCH v2] reset: make shared pulsed reset controls re-triggerable

2020-11-16 Thread Jerome Brunet
On Mon 16 Nov 2020 at 17:36, Philipp Zabel wrote: > On Fri, 2020-11-13 at 16:13 +0100, Jerome Brunet wrote: >> On Fri 13 Nov 2020 at 16:04, Philipp Zabel wrote: >> >> > On Fri, 2020-11-13 at 00:00 +0100, Amjad Ouled-Ameur wrote: >> > > The curren

Re: [PATCH] mmc: meson-gx: remove IRQF_ONESHOT

2020-11-13 Thread Jerome Brunet
On Wed 11 Nov 2020 at 11:47, Ulf Hansson wrote: > On Tue, 10 Nov 2020 at 16:05, Jerome Brunet wrote: >> >> >> On Thu 08 Oct 2020 at 11:08, Ulf Hansson wrote: >> > >> > Thomas, thanks a lot for helping out and looking at this! >> > >> &g

Re: [PATCH v2] reset: make shared pulsed reset controls re-triggerable

2020-11-13 Thread Jerome Brunet
rearm() would be the way to state that the resource is >> no longer used and, that from the caller's perspective, the reset can be >> fired again if necessary. >> >> Signed-off-by: Amjad Ouled-Ameur >> Reported-by: Jerome Brunet >> --- >> Change since v1: [0] >&

Re: [PATCH] mmc: meson-gx: remove IRQF_ONESHOT

2020-11-10 Thread Jerome Brunet
On Thu 08 Oct 2020 at 11:08, Ulf Hansson wrote: > > Thomas, thanks a lot for helping out and looking at this! > > It looks like the testing of the patch below went well. Are you > intending to queue up the patch via your tip tree? > > If you need any help, just tell us! > > Kind regards > Uffe

Re: [PATCH] mmc: meson-mx-sdio: replace spin_lock_irqsave by spin_lock in hard IRQ

2020-11-05 Thread Jerome Brunet
On Tue 03 Nov 2020 at 04:48, Tian Tao wrote: > The code has been in a irq-disabled context since it is hard IRQ. There > is no necessity to do it again. > > Signed-off-by: Tian Tao Reviewed-by: Jerome Brunet > --- > drivers/mmc/host/meson-mx-sdio.c | 5 ++--- &g

Re: [PATCH] clk: define to_clk_regmap() as inline function

2020-10-26 Thread Jerome Brunet
ocks") > Fixes: 085d7a455444 ("clk: qcom: Add a regmap type clock struct") > Signed-off-by: Arnd Bergmann Acked-by: Jerome Brunet > --- > drivers/clk/meson/clk-regmap.h | 5 - > drivers/clk/qcom/clk-regmap.h | 6 +- > 2 files changed, 9 insert

Re: [PATCH v2 3/4] clk: meson: axg: add Video Clocks

2020-10-26 Thread Jerome Brunet
On Tue 15 Sep 2020 at 14:45, Neil Armstrong wrote: > Add the clocks entries used in the video clock path, the clock path > is doubled to permit having different synchronized clocks for different > parts of the video pipeline. > > The AXG only has a single ENCL CTS clock and even if VCLK exist

Re: [PATCH v2 0/4] clk: meson: axg: add clocks for MIPI-DSI support

2020-10-26 Thread Jerome Brunet
On Tue 15 Sep 2020 at 14:45, Neil Armstrong wrote: > This adds the VPU & VAPB clocks along the MIPI DSI Host clock. > > The clock scheme is based on the GXBB & G12A VPU clocks, with a different CTS > clock output used for MIPI-DSI. > > Changes since v1 at [1]: > - update patch 3 commit message

[PATCH] arm64: dts: meson: odroid-n2 plus: fix vddcpu_a pwm

2020-10-23 Thread Jerome Brunet
ike on the odroid n2, use PWM A out of GPIOE_2 for vddcpu A to fix the problem Fixes: 98d24896ee11 ("arm64: dts: meson: add support for the ODROID-N2+") Signed-off-by: Jerome Brunet --- arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2-plus.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-

[PATCH 2/2] clk: meson: g12: use devm variant to register notifiers

2020-10-21 Thread Jerome Brunet
-by: Jerome Brunet --- This clean application of this patch depends on https://lore.kernel.org/r/20201021162147.563655-4-jbru...@baylibre.com drivers/clk/meson/g12a.c | 34 -- include/linux/clk.h | 10 +- 2 files changed, 29 insertions(+), 15 deletions

[PATCH 1/2] clk: add devm variant of clk_notifier_register

2020-10-21 Thread Jerome Brunet
Add a memory managed variant of clk_notifier_register() to make life easier on clock consumers using notifiers Signed-off-by: Jerome Brunet --- drivers/clk/clk.c | 36 include/linux/clk.h | 10 ++ 2 files changed, 46 insertions(+) diff --git

[PATCH 0/2] clk: add devm variant of clk_notifier_register

2020-10-21 Thread Jerome Brunet
This patchset adds memory managed variant of clk_notifier_register and a first usage of it the amlogic clock controller of the g12 SoC family. Jerome Brunet (2): clk: add devm variant of clk_notifier_register clk: meson: g12: use devm variant to register notifiers drivers/clk/clk.c

[PATCH v2 1/3] clk: avoid devm_clk_release name clash

2020-10-21 Thread Jerome Brunet
in clk.c Signed-off-by: Jerome Brunet --- drivers/clk/clk.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index 0a9261a099bd..88e5797bb6b4 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -4068,12 +4068,12 @@ void

[PATCH v2 3/3] clk: meson: g12: drop use of __clk_lookup()

2020-10-21 Thread Jerome Brunet
g12 clock controller used __clk_lookup() to get struct clk from a struct clk_hw. This type of hack is no longer required as CCF now provides the necessary functions to get this. Signed-off-by: Jerome Brunet --- drivers/clk/meson/g12a.c | 68 +++- 1 file

[PATCH v2 2/3] clk: add api to get clk consumer from clk_hw

2020-10-21 Thread Jerome Brunet
clk_hw. Like other clk_get() variant, each call to this helper must be balanced with a call to clk_put(). To make life easier on the consumers, a memory managed version is provided as well. Cc: Martin Blumenstingl Signed-off-by: Jerome Brunet --- drivers/clk/clk.c| 61

[PATCH v2 0/3] clk: add api to get clk consumer from clk_hw

2020-10-21 Thread Jerome Brunet
However, as Stephen pointed out we don't expect this to differ from the one linked to clk_hw. In this case a warning is thrown. * Add a first usage of this in the amlogic clock driver. [0]: https://lore.kernel.org/r/20200519170440.294601-1-jbru...@baylibre.com Jerome Brunet (3): clk: avoid d

Re: [PATCH] arm64: meson: ship only the necessary clock controllers

2020-10-20 Thread Jerome Brunet
On Tue 20 Oct 2020 at 17:03, Kevin Hilman wrote: > Jerome Brunet writes: > >> There now the menu entries for the amlogic clock controllers. >> Do not select these when ARM64 is enabled so it possible to ship only the >> required. >> >> Signed-off-by:

[PATCH] arm64: dts: amlogic: add missing ethernet reset ID

2020-10-20 Thread Jerome Brunet
From: Anand Moon Add reset external reset of the ethernet mac controller Signed-off-by: Anand Moon Signed-off-by: Jerome Brunet --- arch/arm64/boot/dts/amlogic/meson-axg.dtsi| 2 ++ arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 2 ++ arch/arm64/boot/dts/amlogic/meson-gx.dtsi

[PATCH] arm64: meson: ship only the necessary clock controllers

2020-10-20 Thread Jerome Brunet
There now the menu entries for the amlogic clock controllers. Do not select these when ARM64 is enabled so it possible to ship only the required. Signed-off-by: Jerome Brunet --- arch/arm64/Kconfig.platforms | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/arm64/Kconfig.platforms b

[PATCH] usb: cdc-acm: fix cooldown mechanism

2020-10-19 Thread Jerome Brunet
9cd1d1 ("cdc-acm: introduce a cool down") Reported-by: Pascal Vizeli Cc: Oliver Neukum Signed-off-by: Jerome Brunet --- Hi, I tried to fix problem introduced by commit a4e7279cd1d1 ("cdc-acm: introduce a cool down") while keeping the original intent, or at least what

Re: [PATCH] mailbox: avoid timer start from callback

2020-10-16 Thread Jerome Brunet
On Fri 16 Oct 2020 at 20:45, Jassi Brar wrote: > On Fri, Oct 16, 2020 at 1:38 PM Jerome Brunet wrote: >> >> >> On Fri 16 Oct 2020 at 19:30, jassisinghb...@gmail.com wrote: >> >> > From: Jassi Brar >> > >> > If the txdone is don

Re: [PATCH] mailbox: cancel timer before starting it

2020-10-16 Thread Jerome Brunet
On Fri 16 Oct 2020 at 19:33, Jassi Brar wrote: > On Fri, Oct 16, 2020 at 4:00 AM Jerome Brunet wrote: >> >> >> On Fri 16 Oct 2020 at 10:52, Ionela Voinescu wrote: >> >> > On Thursday 15 Oct 2020 at 13:45:54 (-0500), Jassi Brar wrote: >> > [.

Re: [PATCH] mailbox: avoid timer start from callback

2020-10-16 Thread Jerome Brunet
On Fri 16 Oct 2020 at 19:30, jassisinghb...@gmail.com wrote: > From: Jassi Brar > > If the txdone is done by polling, it is possible for msg_submit() to start > the timer while txdone_hrtimer() callback is running. If the timer needs > recheduling, it could already be enqueued by the time

Re: [PATCH] mailbox: cancel timer before starting it

2020-10-16 Thread Jerome Brunet
On Fri 16 Oct 2020 at 10:44, Sudeep Holla wrote: > On Thu, Oct 15, 2020 at 03:29:35PM +0100, Ionela Voinescu wrote: >> Hi Jerome, >> >> On Thursday 15 Oct 2020 at 15:58:30 (+0200), Jerome Brunet wrote: >> > >> > On Thu 15 Oct 2020 at 15:46, Ionela Voin

Re: [PATCH] mailbox: cancel timer before starting it

2020-10-16 Thread Jerome Brunet
On Fri 16 Oct 2020 at 10:52, Ionela Voinescu wrote: > On Thursday 15 Oct 2020 at 13:45:54 (-0500), Jassi Brar wrote: > [..] >> > >> --- a/drivers/mailbox/mailbox.c >> > >> +++ b/drivers/mailbox/mailbox.c >> > >> @@ -82,9 +82,13 @@ static void msg_submit(struct mbox_chan *chan) >> > >> exit:

Re: [PATCH] mailbox: cancel timer before starting it

2020-10-15 Thread Jerome Brunet
On Thu 15 Oct 2020 at 15:46, Ionela Voinescu wrote: > Hi guys, > > On Wednesday 23 Sep 2020 at 14:39:16 (+0200), Jerome Brunet wrote: >> If the txdone is done by polling, it is possible for msg_submit() to start >> the timer while txdone_hrtimer() callback is runnin

Re: [PATCH] mmc: meson-gx: remove IRQF_ONESHOT

2020-10-07 Thread Jerome Brunet
t; not a given and quite some of the users rely on IRQF_ONESHOT. > > The below untested patch should cure the problem and keep the interrupt > line masked if requested with IRQF_ONESHOT. > With arm64 defconfig on Khadas vim3, no obvious regression. Looks good. Tested-by: Jerome Brunet I did not test with RT. Brad, Could you let us know is Thomas's patch works for you ? Thx

[PATCH 0/3] i2c: meson: scl rate fixups

2020-10-07 Thread Jerome Brunet
switching to this HIGH/LOW method. Jerome Brunet (2): i2c: meson: fix clock setting overwrite i2c: meson: keep peripheral clock enabled Nicolas Belin (1): i2c: meson: fixup rate calculation with filter delay drivers/i2c/busses/i2c-meson.c | 52 +- 1 file c

[PATCH 3/3] i2c: meson: fixup rate calculation with filter delay

2020-10-07 Thread Jerome Brunet
t;i2c: add support for Amlogic Meson I2C controller") Signed-off-by: Nicolas Belin Signed-off-by: Jerome Brunet --- drivers/i2c/busses/i2c-meson.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/i2c/busses/i2c-meson.c b/drivers/i2c/

[PATCH 1/3] i2c: meson: fix clock setting overwrite

2020-10-07 Thread Jerome Brunet
/low clock mode which may have been left over by the bootloader. Fixes: 30021e3707a7 ("i2c: add support for Amlogic Meson I2C controller") Signed-off-by: Jerome Brunet --- drivers/i2c/busses/i2c-meson.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git

[PATCH 2/3] i2c: meson: keep peripheral clock enabled

2020-10-07 Thread Jerome Brunet
not affect the SCL output which is still gated when i2c is idle. Fixes: 09af1c2fa490 ("i2c: meson: set clock divider in probe instead of setting it for each transfer") Signed-off-by: Jerome Brunet --- drivers/i2c/busses/i2c-meson.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletion

Re: [PATCH] mmc: meson-gx: remove IRQF_ONESHOT

2020-10-05 Thread Jerome Brunet
On Mon 05 Oct 2020 at 10:55, Thomas Gleixner wrote: > On Mon, Oct 05 2020 at 10:22, Ulf Hansson wrote: >> On Fri, 2 Oct 2020 at 18:49, Jerome Brunet wrote: >>> >>> IRQF_ONESHOT was added to this driver to make sure the irq was not enabled >>> again

Re: [PATCH] arm64: dts: meson: add SM1 soundcard name to VIM3L

2020-10-02 Thread Jerome Brunet
On Fri 02 Oct 2020 at 20:45, Kevin Hilman wrote: > Christian Hewitt writes: > >>> On 2 Oct 2020, at 6:44 pm, Jerome Brunet wrote: >>> >>> On Fri 02 Oct 2020 at 16:16, Christian Hewitt >>> wrote: >>> >>>> VIM3L now inher

[PATCH] mmc: meson-gx: remove IRQF_ONESHOT

2020-10-02 Thread Jerome Brunet
by: Brad Harper Cc: Sebastian Andrzej Siewior Signed-off-by: Jerome Brunet --- drivers/mmc/host/meson-gx-mmc.c | 47 - 1 file changed, 29 insertions(+), 18 deletions(-) diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c index 08a3b1c

Re: [PATCH v2 00/10] arm64: dts: meson: add more GX soundcards

2020-10-02 Thread Jerome Brunet
On Fri 02 Oct 2020 at 16:31, Christian Hewitt wrote: > This series adds basic support for LPCM audio over HDMI and S/PDIF > interfaces to GXBB/GXL/GXM devices without support. I'm sure audio > support can be extended in places (some devices have internal DACs > and headphone hardware) but

Re: [PATCH] arm64: dts: meson: add SM1 soundcard name to VIM3L

2020-10-02 Thread Jerome Brunet
On Fri 02 Oct 2020 at 16:16, Christian Hewitt wrote: > VIM3L now inherits the sound node from the VIM3 common dtsi but is > an SM1 device, so label it as such, and stop users blaming future > support issues on the distro/app "wrongly detecting" their device. > > Signed-off-by: Christian

Re: [PATCH 10/18] clk: meson: use semicolons rather than commas to separate statements

2020-09-28 Thread Jerome Brunet
On Sun 27 Sep 2020 at 21:12, Julia Lawall wrote: Hi Stephen, Do you want to take all the clock related patches directly ? > Replace commas with semicolons. What is done is essentially described by > the following Coccinelle semantic patch (http://coccinelle.lip6.fr/): > > // > @@

Re: [PATCH] mmc: host: meson-gx-mmc: fix possible deadlock condition for preempt_rt

2020-09-25 Thread Jerome Brunet
On Fri 25 Sep 2020 at 15:44, Sebastian Andrzej Siewior wrote: > On 2020-09-25 11:11:42 [+0200], Jerome Brunet wrote: >> I'm not sure about this. >> As you have explained on IRC, I understand that IRQF_ONESHOT is causing >> trouble with RT as the hard I

Re: [PATCH] mmc: host: meson-gx-mmc: fix possible deadlock condition for preempt_rt

2020-09-25 Thread Jerome Brunet
On Thu 24 Sep 2020 at 19:01, Kevin Hilman wrote: > Hi Brad, > > Brad Harper writes: > >> Force threaded interrupts for meson_mmc_irq to prevent possible deadlock >> condition >> during mmc operations when using preempt_rt with 5.9.0-rc3-rt3 patches >> on arm64. >> >> Using meson-gx-mmc with

Re: [PATCH 8/8] arm64: dts: meson: enable RTC for VIM2 meson-gxm-khadas-vim2

2020-09-25 Thread Jerome Brunet
On Fri 25 Sep 2020 at 05:30, Artem Lapkin wrote: > enable RTC for VIM2 meson-gxm-khadas-vim2 > > Signed-off-by: Artem Lapkin > --- > arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[PATCH] mailbox: cancel timer before starting it

2020-09-23 Thread Jerome Brunet
ted-by: Da Xue Signed-off-by: Jerome Brunet --- drivers/mailbox/mailbox.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c index 0b821a5b2db8..34f9ab01caef 100644 --- a/drivers/mailbox/mailbox.c +++ b/drivers/mailbox

[PATCH 0/2] arm64: dts: meson: add aml-s905x-cc v2 support

2020-09-15 Thread Jerome Brunet
This patchset adds initial support for the libretech aml-s905x-cc v2. Jerome Brunet (2): dt-bindings: arm: amlogic: add support for libretch s905x cc v2 arm64: dts: meson: initial support for aml-s905x-cc v2 .../devicetree/bindings/arm/amlogic.yaml | 1 + arch/arm64/boot/dts/amlogic

[PATCH 1/2] dt-bindings: arm: amlogic: add support for libretch s905x cc v2

2020-09-15 Thread Jerome Brunet
Add support for the 2nd version of the libretch aml-s905x-cc. Signed-off-by: Jerome Brunet --- Documentation/devicetree/bindings/arm/amlogic.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm

[PATCH 2/2] arm64: dts: meson: initial support for aml-s905x-cc v2

2020-09-15 Thread Jerome Brunet
Add initial support for the libretech aml-s905x-cc (Le Potato) v2 Signed-off-by: Jerome Brunet --- arch/arm64/boot/dts/amlogic/Makefile | 1 + .../meson-gxl-s905x-libretech-cc-v2.dts | 318 ++ 2 files changed, 319 insertions(+) create mode 100644 arch/arm64

Re: [PATCH 2/2] arm64: dts: meson: initial support for aml-s905x-cc v2

2020-09-15 Thread Jerome Brunet
On Tue 15 Sep 2020 at 16:30, Neil Armstrong wrote: > Hi, > > On 15/09/2020 16:19, Jerome Brunet wrote: >> Add initial support for the libretech aml-s905x-cc (Le Potato) v2 >> >> Signed-off-by: Jerome Brunet >> --- >> arch/arm64/boot/dts/amlogic/Make

Re: [PATCH 4/4] clk: meson: axg: add MIPI DSI Host clock

2020-09-10 Thread Jerome Brunet
On Mon 07 Sep 2020 at 11:38, Neil Armstrong wrote: > This adds the MIPI DSI Host clock, used to measure the signal timings (ENC > VSYNC or > DW-MIPI-DSI eDPI timings). > > Signed-off-by: Neil Armstrong > --- > drivers/clk/meson/axg.c | 66 + >

Re: [PATCH 3/4] clk: meson: axg: add Video Clocks

2020-09-10 Thread Jerome Brunet
On Mon 07 Sep 2020 at 11:38, Neil Armstrong wrote: > Add the Video Clocks present on the Amlogic AXg SoCs. > > The AXG only has a single ENCL CTS clock and even if VCLK exist along VCLK2, > only VCLK2 is used since it clocks the MIPI DSI IP directly. > > Signed-off-by: Neil Armstrong > --- >

  1   2   3   4   5   6   7   8   9   10   >