Re: [RFC PATCH] memcg: oom: fix totalpages calculation for swappiness==0

2012-10-15 Thread KOSAKI Motohiro
ss, but affecting a hierarchy of groups only. > +Please note that unlike the global swappiness, memcg knob set to 0 > +really prevents from any swapping even if there is a swap storage > +available. This might lead to memcg OOM killer if there are no file > +pages to reclaim. Pretty good

Re: [RFC PATCH] memcg: oom: fix totalpages calculation for swappiness==0

2012-10-15 Thread KOSAKI Motohiro
> diff --git a/Documentation/sysctl/vm.txt b/Documentation/sysctl/vm.txt > index 078701f..308fd77 100644 > --- a/Documentation/sysctl/vm.txt > +++ b/Documentation/sysctl/vm.txt > @@ -640,6 +640,9 @@ swappiness > This control is used to define how aggressive the kernel will swap > memory pages. H

Re: [PATCH] mm: cleanup register_node()

2012-10-13 Thread KOSAKI Motohiro
tjes > CC: Andrew Morton > Signed-off-by: Yasuaki Ishimatsu Acked-by: KOSAKI Motohiro -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info

Re: [PATCH 5/10] memory-hotplug : memory-hotplug: check page type in get_page_bootmem

2012-10-12 Thread KOSAKI Motohiro
ust optimization and does not fix any problem. > > CC: David Rientjes > CC: Jiang Liu > CC: Len Brown > CC: Christoph Lameter > Cc: Minchan Kim > CC: Andrew Morton > CC: KOSAKI Motohiro > CC: Wen Congyang > Signed-off-by: Yasuaki Ishimatsu > --- > mm/memor

Re: [PATCH 1/4] acpi,memory-hotplug : add memory offline code to acpi_memory_device_remove()

2012-10-12 Thread KOSAKI Motohiro
>>> -static int acpi_memory_disable_device(struct acpi_memory_device >>> *mem_device) >>> +static int acpi_memory_remove_memory(struct acpi_memory_device *mem_device) >>> { >>> int result; >>> struct acpi_memory_info *info, *n; >>> >>> + list_for_each_entry_safe(info, n, &me

Re: [PATCH 4/4] acpi,memory-hotplug : store the node id in acpi_memory_device

2012-10-12 Thread KOSAKI Motohiro
On Mon, Oct 8, 2012 at 2:47 AM, Wen Congyang wrote: > At 10/06/2012 02:56 AM, KOSAKI Motohiro Wrote: >> On Wed, Oct 3, 2012 at 6:11 AM, Yasuaki Ishimatsu >> wrote: >>> From: Wen Congyang >>> >>> The memory device has only one node id. Store the node id

Re: [PATCH 2/4] acpi,memory-hotplug : rename remove_memory() to offline_memory()

2012-10-12 Thread KOSAKI Motohiro
On Mon, Oct 8, 2012 at 2:45 AM, Wen Congyang wrote: > At 10/05/2012 05:31 AM, KOSAKI Motohiro Wrote: >> On Wed, Oct 3, 2012 at 6:02 AM, Yasuaki Ishimatsu >> wrote: >>> From: Yasuaki Ishimatsu >>> >>> add_memory() hot adds a physical memory. But remov

Re: [PATCH] add some drop_caches documentation and info messsge

2012-10-12 Thread KOSAKI Motohiro
repeatable benchmark runs. So, add a bit more documentation > about it, and add a little KERN_NOTICE. It should help developers > who are chasing down reclaim-related bugs. > > [mho...@suse.cz: refreshed to current -mm tree] > Signed-off-by: Dave Hansen > Reviewed-by: KAMEZAWA

Re: [PATCH] memcg: oom: fix totalpages calculation for memory.swappiness==0

2012-10-11 Thread KOSAKI Motohiro
in such a case. > > Signed-off-by: Michal Hocko > Acked-by: David Rientjes > Cc: stable [3.5+] Acked-by: KOSAKI Motohiro -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordom

Re: [PATCH 2/2]suppress "Device nodeX does not have a release() function" warning

2012-10-11 Thread KOSAKI Motohiro
ecause the node > struct is part of node_devices[] array and it cannot be freed by > node_device_release(). So if system reuses the node struct, it has a garbage. > > CC: David Rientjes > CC: Jiang Liu > Cc: Minchan Kim > CC: Andrew Morton > CC: KOSAKI Motohiro > Sig

Re: [PATCH 1/2]suppress "Device memoryX does not have a release() function" warning

2012-10-11 Thread KOSAKI Motohiro
tion since the release function is prepared as a means > to free a memory_block struct. > > CC: David Rientjes > CC: Jiang Liu > Cc: Minchan Kim > CC: Andrew Morton > CC: KOSAKI Motohiro > CC: Wen Congyang > Signed-off-by: Yasuaki Ishimatsu Acked-by: KOSAKI Motohiro

Re: [PATCH 2/10] memory-hotplug : remove /sys/firmware/memmap/X sysfs

2012-10-05 Thread KOSAKI Motohiro
; CC: Jiang Liu > CC: Len Brown > CC: Christoph Lameter > Cc: Minchan Kim > CC: Andrew Morton > CC: KOSAKI Motohiro > Signed-off-by: Wen Congyang > Signed-off-by: Yasuaki Ishimatsu > > --- > drivers/firmware/memmap.c| 98 > ++

Re: [PATCH 1/10] memory-hotplug : check whether memory is offline or not when removing memory

2012-10-05 Thread KOSAKI Motohiro
the check. > CC: David Rientjes > CC: Jiang Liu > CC: Len Brown > CC: Christoph Lameter > Cc: Minchan Kim > CC: Andrew Morton > CC: KOSAKI Motohiro > Signed-off-by: Wen Congyang > Signed-off-by: Yasuaki Ishimatsu > > --- > drivers/base/memory.c |

Re: [PATCH 0/10] memory-hotplug: hot-remove physical memory

2012-10-05 Thread KOSAKI Motohiro
> Known problems: > 1. memory can't be offlined when CONFIG_MEMCG is selected. >For example: there is a memory device on node 1. The address range >is [1G, 1.5G). You will find 4 new directories memory8, memory9, memory10, >and memory11 under the directory /sys/devices/system/memory/. >

Re: [PATCH 4/4] acpi,memory-hotplug : store the node id in acpi_memory_device

2012-10-05 Thread KOSAKI Motohiro
On Wed, Oct 3, 2012 at 6:11 AM, Yasuaki Ishimatsu wrote: > From: Wen Congyang > > The memory device has only one node id. Store the node id when > enable the memory device, and we can reuse it when removing the > memory device. You don't explain why we need this. Then nobody can review nor ack.

Re: [PATCH 3/6] acpi,memory-hotplug : add physical memory hotplug code to acpi_memhotplug.c

2012-10-05 Thread KOSAKI Motohiro
On Wed, Oct 3, 2012 at 6:09 AM, Yasuaki Ishimatsu wrote: > From: Yasuaki Ishimatsu > > For hot removing physical memory, the patch adds remove_memory() into > acpi_memory_remove_memory(). But we cannot support physical memory > hot remove. So remove_memory() do nothinig. I don't understand this

Re: [PATCH 2/4] memory-hotplug: add node_device_release

2012-10-05 Thread KOSAKI Motohiro
> I have the reason to have to fill the node struct with 0 by memset. > The node is a part of node struct array (node_devices[]). > If we add empty release function for suppressing warning, > some data remains in the node struct after hot removing memory. > So if we re-hot adds the memory, the node

Re: [PATCH 2/4] acpi,memory-hotplug : rename remove_memory() to offline_memory()

2012-10-04 Thread KOSAKI Motohiro
y() to offline_memory(). We will > use rename_memory() for hot removing memory. > > CC: David Rientjes > CC: Jiang Liu > CC: Len Brown > CC: Christoph Lameter > Cc: Minchan Kim > CC: Andrew Morton > CC: KOSAKI Motohiro > Signed-off-by: Yasuaki Ishimatsu &

Re: [PATCH 1/4] acpi,memory-hotplug : add memory offline code to acpi_memory_device_remove()

2012-10-04 Thread KOSAKI Motohiro
CC: Jiang Liu > CC: Len Brown > CC: Christoph Lameter > Cc: Minchan Kim > CC: Andrew Morton > CC: KOSAKI Motohiro > Signed-off-by: Yasuaki Ishimatsu > Signed-off-by: Wen Congyang > --- > drivers/acpi/acpi_memhotplug.c | 44 > +++

Re: [PATCH] mm: use %pK for /proc/vmallocinfo

2012-10-02 Thread KOSAKI Motohiro
v = p; > > - seq_printf(m, "0x%p-0x%p %7ld", > + seq_printf(m, "0x%pK-0x%pK %7ld", > v->addr, v->addr + v->size, v->size); Looks good. Acked-by: KOSAKI Motohiro -- To unsubscribe from this list: send the line "unsubscribe

Re: [RFC v9 PATCH 01/21] memory-hotplug: rename remove_memory() to offline_memory()/offline_pages()

2012-10-02 Thread KOSAKI Motohiro
>> Then, you introduced bisect breakage. It is definitely unacceptable. > > What is "bisect breakage" meaning? Think what's happen when only applying path [1/21]. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More m

Re: [RFC v9 PATCH 06/21] memory-hotplug: export the function acpi_bus_remove()

2012-10-02 Thread KOSAKI Motohiro
On Mon, Oct 1, 2012 at 8:34 PM, Ni zhan Chen wrote: > On 09/05/2012 05:25 PM, we...@cn.fujitsu.com wrote: >> >> From: Wen Congyang >> >> The function acpi_bus_remove() can remove a acpi device from acpi device. > > IIUC, s/acpi device/acpi bus IIUC, acpi_bus_remove() mean "remove the device from

Re: [PATCH 2/4] memory-hotplug: add node_device_release

2012-10-01 Thread KOSAKI Motohiro
On Mon, Oct 1, 2012 at 2:54 AM, Yasuaki Ishimatsu wrote: > Hi Kosaki-san, > > > 2012/09/29 7:19, KOSAKI Motohiro wrote: >>>>> >>>>> I don't understand it. How can we get rid of the warning? >>>> >>>> >>>>

Re: [PATCH 1/4] memory-hotplug: add memory_block_release

2012-09-28 Thread KOSAKI Motohiro
> It is not correct. The kobject_put() is prepared against find_memory_block() > in remove_memory_block() since kobject->kref is incremented in it. > So release_memory_block() is called by device_unregister() correctly as > follows: Ok. Looks good then. Please rewrite the description more kindly a

Re: [PATCH 2/3] slub, hotplug: ignore unrelated node's hot-adding and hot-removing

2012-09-28 Thread KOSAKI Motohiro
On Fri, Sep 28, 2012 at 3:19 AM, Lai Jiangshan wrote: > HI, Christoph, KOSAKI > > SLAB always allocates kmem_list3 for all nodes(N_HIGH_MEMORY), also node > bug/bad things happens. > SLUB always requires kmem_cache_node on the correct node, so these fix is > needed. > > SLAB uses for_each_online

Re: [RFC v9 PATCH 01/21] memory-hotplug: rename remove_memory() to offline_memory()/offline_pages()

2012-09-28 Thread KOSAKI Motohiro
On Thu, Sep 27, 2012 at 11:50 PM, Yasuaki Ishimatsu wrote: > Hi Chen, > > > 2012/09/28 11:22, Ni zhan Chen wrote: >> >> On 09/05/2012 05:25 PM, we...@cn.fujitsu.com wrote: >>> >>> From: Yasuaki Ishimatsu >>> >>> remove_memory() only try to offline pages. It is called in two cases: >>> 1. hot remo

Re: [PATCH 2/4] memory-hotplug: add node_device_release

2012-09-28 Thread KOSAKI Motohiro
>>> I don't understand it. How can we get rid of the warning? >> >> See cpu_device_release() for example. > > If we implement a function like cpu_device_release(), the warning > disappears. But the comment says in the function "Never copy this way...". > So I think it is illegal way. What does "il

Re: [PATCH 2/4] memory-hotplug: add node_device_release

2012-09-27 Thread KOSAKI Motohiro
>> Moreover, your explanation is still insufficient. Even if >> node_device_release() is empty function, we can get rid of the >> warning. > > > I don't understand it. How can we get rid of the warning? See cpu_device_release() for example. >> Why do we need this node_device_release() implement

Re: [PATCH 1/4] memory-hotplug: add memory_block_release

2012-09-27 Thread KOSAKI Motohiro
On Thu, Sep 27, 2012 at 8:24 PM, Yasuaki Ishimatsu wrote: > Hi Chen, > > > 2012/09/27 19:20, Ni zhan Chen wrote: >> >> Hi Congyang, >> >> 2012/9/27 >> >>> From: Yasuaki Ishimatsu >>> >>> When calling remove_memory_block(), the function shows following message >>> at >>> device_release(). >>> >>>

Re: [PATCH 2/4] memory-hotplug: add node_device_release

2012-09-27 Thread KOSAKI Motohiro
On Thu, Sep 27, 2012 at 8:07 PM, Yasuaki Ishimatsu wrote: > Hi Kosaki-san, > > > 2012/09/28 5:13, KOSAKI Motohiro wrote: >> >> On Thu, Sep 27, 2012 at 1:45 AM, wrote: >>> >>> From: Yasuaki Ishimatsu >>> >>> When callin

Re: [PATCH 3/3] memory_hotplug: Don't modify the zone_start_pfn outside of zone_span_writelock()

2012-09-27 Thread KOSAKI Motohiro
(9/27/12 2:47 AM), Lai Jiangshan wrote: > The __add_zone() maybe call sleep-able init_currently_empty_zone() > to init wait_table, This doesn't explain why sleepable is critical important. I think sleepable is jsut unrelated. The fact is only: to write zone->zone_start_pfn require zone_span_writel

Re: [PATCH 2/3] slub, hotplug: ignore unrelated node's hot-adding and hot-removing

2012-09-27 Thread KOSAKI Motohiro
(9/27/12 2:47 AM), Lai Jiangshan wrote: > SLUB only fucus on the nodes which has normal memory, so ignore the other > node's hot-adding and hot-removing. > > Aka: if some memroy of a node(which has no onlined memory) is online, > but this new memory onlined is not normal memory(HIGH memory example

Re: [PATCH 1/3] memory_hotplug: fix stale node_states[N_NORMAL_MEMORY]

2012-09-27 Thread KOSAKI Motohiro
(9/27/12 2:47 AM), Lai Jiangshan wrote: > Currently memory_hotplug only manages the node_states[N_HIGH_MEMORY], > it forgets to manage node_states[N_NORMAL_MEMORY]. it causes > node_states[N_NORMAL_MEMORY] becomes stale. What's mean 'stale'? I guess : Currently memory_hotplug doesn't turn on/off

Re: [PATCH 4/4] memory-hotplug: auto offline page_cgroup when onlining memory block failed

2012-09-27 Thread KOSAKI Motohiro
memory. So > auto offline page_cgroup when onlining memory block failed. > > CC: David Rientjes > CC: Jiang Liu > CC: Len Brown > CC: Benjamin Herrenschmidt > CC: Paul Mackerras > Cc: Minchan Kim > CC: Andrew Morton > CC: KOSAKI Motohiro > CC: Yasuaki Ishi

Re: [PATCH 3/4] memory-hotplug: clear hwpoisoned flag when onlining pages

2012-09-27 Thread KOSAKI Motohiro
On Thu, Sep 27, 2012 at 1:45 AM, wrote: > From: Wen Congyang > > hwpoisoned may set when we offline a page by the sysfs interface > /sys/devices/system/memory/soft_offline_page or > /sys/devices/system/memory/hard_offline_page. If we don't clear > this flag when onlining pages, this page can't b

Re: [PATCH 2/4] memory-hotplug: add node_device_release

2012-09-27 Thread KOSAKI Motohiro
On Thu, Sep 27, 2012 at 1:45 AM, wrote: > From: Yasuaki Ishimatsu > > When calling unregister_node(), the function shows following message at > device_release(). This description doesn't have the "following message". > Device 'node2' does not have a release() function, it is broken and must b

Re: [PATCH 1/4] memory-hotplug: add memory_block_release

2012-09-27 Thread KOSAKI Motohiro
s > CC: Jiang Liu > CC: Len Brown > CC: Benjamin Herrenschmidt > CC: Paul Mackerras > Cc: Minchan Kim > CC: Andrew Morton > CC: KOSAKI Motohiro > CC: Wen Congyang > Signed-off-by: Yasuaki Ishimatsu > --- > drivers/base/memory.c |9 - > 1 files ch

Re: [PATCH] pagemap: fix wrong KPF_THP on slab pages

2012-09-25 Thread KOSAKI Motohiro
On Tue, Sep 25, 2012 at 1:05 PM, Naoya Horiguchi wrote: > On Tue, Sep 25, 2012 at 11:59:51AM -0400, KOSAKI Motohiro wrote: >> On Tue, Sep 25, 2012 at 9:56 AM, Naoya Horiguchi >> wrote: >> > KPF_THP can be set on non-huge compound pages like slab pages, because >>

Re: [PATCH] pagemap: fix wrong KPF_THP on slab pages

2012-09-25 Thread KOSAKI Motohiro
On Tue, Sep 25, 2012 at 9:56 AM, Naoya Horiguchi wrote: > KPF_THP can be set on non-huge compound pages like slab pages, because > PageTransCompound only sees PG_head and PG_tail. Obviously this is a bug > and breaks user space applications which look for thp via /proc/kpageflags. > Currently thp

Re: [PATCH] mm: fix NR_ISOLATED_[ANON|FILE] mismatch

2012-09-20 Thread KOSAKI Motohiro
On Wed, Sep 19, 2012 at 7:51 PM, Minchan Kim wrote: > On Wed, Sep 19, 2012 at 02:28:10PM -0400, Johannes Weiner wrote: >> On Wed, Sep 19, 2012 at 01:04:56PM -0400, KOSAKI Motohiro wrote: >> > On Wed, Sep 19, 2012 at 3:45 AM, Minchan Kim wrote: >> > > When I looked

Re: [PATCH] memory-hotplug: fix zone stat mismatch

2012-09-19 Thread KOSAKI Motohiro
On Wed, Sep 19, 2012 at 3:29 AM, Minchan Kim wrote: > During memory-hotplug stress test, I found NR_ISOLATED_[ANON|FILE] > are increasing so that kernel are hang out. > > The cause is that when we do memory-hotadd after memory-remove, > __zone_pcp_update clear out zone's ZONE_STAT_ITEMS in setup_p

Re: [PATCH] mm: fix NR_ISOLATED_[ANON|FILE] mismatch

2012-09-19 Thread KOSAKI Motohiro
On Wed, Sep 19, 2012 at 3:45 AM, Minchan Kim wrote: > When I looked at zone stat mismatch problem, I found > migrate_to_node doesn't decrease NR_ISOLATED_[ANON|FILE] > if check_range fails. > > It can make system hang out. > > Cc: KOSAKI Motohiro > Cc: Mel Go

Re: Why blktrace didn't trace requests merge?

2012-09-17 Thread KOSAKI Motohiro
(9/17/12 1:55 PM), Tejun Heo wrote: > (cc'ing Jens) > > On Mon, Sep 17, 2012 at 09:22:28AM -0400, Steven Rostedt wrote: >> On Mon, 2012-09-17 at 19:33 +0800, Jianpeng Ma wrote: >>> Hi all: >>> I used blktrace to trace some io.But i can't find requests merge. I >>> searched the code and did't

Re: [PATCH] mm: fix mmap overflow checking

2012-09-07 Thread KOSAKI Motohiro
>> I've seen the exactly same patch from another fujitsu guys several >> month ago. and as I pointed >> out at that time, this line don't work when 32bit kernel + mmap2 syscall >> case. >> >> Please don't think do_mmap_pgoff() is for mmap(2) specific and read a >> past thread before resend >> a pa

Re: [PATCH 5/5] mempolicy: fix a memory corruption by refcount imbalance in alloc_pages_vma()

2012-09-07 Thread KOSAKI Motohiro
race occurs, alloc_pages_vma() falls in 'goto > retry_cpuset' path, decrements the reference count and frees the policy > prematurely. > > Signed-off-by: KOSAKI Motohiro > Signed-off-by: Mel Gorman > --- > mm/mempolicy.c | 12 +++- > 1 files changed, 11

Re: [PATCH 3/5] mempolicy: fix a race in shared_policy_replace()

2012-09-07 Thread KOSAKI Motohiro
not keen on this approach because it partially duplicates sp_alloc(). As > the paths were sp->lock is taken are not that performance critical this > patch converts sp->lock to sp->mutex so it can sleep when calling sp_alloc(). Looks make sense. Acked-by: KOSAKI Motohiro -- To unsubscr

Re: [PATCH] mm: fix mmap overflow checking

2012-09-07 Thread KOSAKI Motohiro
t;Test Pass: Error at mmap: %s\n", strerror(errno)); > return 0; > } > > if (pa == MAP_FAILED) > perror("Test FAIL: expect EOVERFLOW but get other error"); > else > printf("Test FAIL : Expect EOVERFLOW bu

Re: [PATCH 0/6][resend] mempolicy memory corruption fixlet

2012-08-06 Thread KOSAKI Motohiro
On 7/31/2012 8:33 AM, Josh Boyer wrote: > On Mon, Jun 11, 2012 at 5:17 AM, wrote: >> From: KOSAKI Motohiro >> >> Hi >> >> This is trivial fixes of mempolicy meory corruption issues. There >> are independent patches each ather. and, they don't change u

Re: [PATCH 2/2 v5][resend] tmpfs: interleave the starting node of /dev/shmem

2012-07-25 Thread KOSAKI Motohiro
> Please, what's wrong with the patch below, to replace the current > two or three? I don't have real NUMA myself: does it work? > If it doesn't work, can you see why not? It works. It doesn't match my preference. but I don't want block your way. this area is maintained you. please go ahead. at

Re: 2.6.25-rc2-mm1 - boot hangs on ia64

2008-02-26 Thread KOSAKI Motohiro
Hi Fujitsu machine can't boot too. my bisect indicate git-sched.patch cause regression too. Thanks. > 25-rc2-mm1 is hanging early in boot on my HP ia64 numa platform. I saw > the "Strange hang on ia64 with CONFIG_PRINTK_TIME=y" thread on lkml: > > http://marc.info/?t=12028839681&r=

Re: [ofa-general] Re: [patch 5/6] mmu_notifier: Support for drivers with revers maps (f.e. for XPmem)

2008-02-26 Thread KOSAKI Motohiro
> > > > Can you change the spec? > > > > > > Not really. It will break all existing codes. > > > > I meant as in eg. submit changes to MPI-3 > > MPI spec tries to be backward compatible. And MPI-2 spec is 10 years > old, but MPI-1 is still in a wider use. HPC is moving fast in terms of HW > techno

[RFC][PATCH] page reclaim throttle take2

2008-02-25 Thread KOSAKI Motohiro
45 7159 3 42.06 378.70 5336 6306 4 48.84 401.87 5474 6669 unlimited 282.301248.47 29026 - Please any comments! Signed-off-by: KOSAKI Motohiro <[EMAIL PROTECTED]> CC: KAMEZAWA Hiroyuki <[EMAIL P

Re: Tiny cpusets -- cpusets for small systems?

2008-02-24 Thread KOSAKI Motohiro
Hi Pual > Looking at some IA64 sn2 config builds I have laying about, I see the > following text sizes for a couple of versions, showing the growth of > the cpuset/cgroup apparatus over time: > > 25933 2.6.18-rc3-mm1/kernel/cpuset.o (Aug 2006) > vs. > 37823 2.6.25-rc2-mm1/kernel/c

Re: [PATCH 2/2] ResCounter: Use read_uint in memory controller

2008-02-23 Thread KOSAKI Motohiro
Hi Andrew, > yup, I agree. Even though I don't know what ILP32 and LP64 are ;) ILP32: integer and long and pointer size is 32bit LP64: long and pointer size is 64bit, but int size is 32bit linux 32bit kernel obey ILP32 model, 64bit kernel obey LP64. Thanks. - kosaki -- To unsubscribe from

Re: [PATCH] Document huge memory/cache overhead of memory controller in Kconfig

2008-02-21 Thread KOSAKI Motohiro
Hi > > I think one reason of many people easy confusion is caused by bad menu > > hierarchy. > > I popose mem-cgroup move to child of cgroup and resource counter > > (= obey denend on). > > > +config CGROUP_MEM_CONT > > + bool "Memory controller for cgroups" > > Memory _resource_ controller fo

Re: [PATCH] Document huge memory/cache overhead of memory controller in Kconfig

2008-02-21 Thread KOSAKI Motohiro
Hi > > >> For ordinary desktop people, memory controller is what developers > > >> know as MMU or sometimes even some other mysterious piece of silicon > > >> inside the heavy box. > > > > > >Actually I'd guess 'memory controller' == 'DRAM controller' == part of > > >northbridge that talks t

Re: [RFC][PATCH] the proposal of improve page reclaim by throttle

2008-02-21 Thread KOSAKI Motohiro
> > please repost question with change subject. > > i don't know reason of vanilla kernel behavior, sorry. > > Normally, embedded linux have only one zone(DMA). > > If your patch isn't applied, several processes can reclaim memory in > parallel. > then, DMA zone's pages_scanned is suddenly

Re: [RFC][PATCH] the proposal of improve page reclaim by throttle

2008-02-21 Thread KOSAKI Motohiro
Hi balbir-san > It's good to keep the main reclaim code and the memory controller reclaim in > sync, so this is a nice effort. thank you. I will repost next version (fixed nick's opinion) while a few days. > > @@ -1456,7 +1501,7 @@ unsigned long try_to_free_mem_cgroup_pag > > int targe

Re: [RFC][PATCH] the proposal of improve page reclaim by throttle

2008-02-21 Thread KOSAKI Motohiro
Hi Kim-san, Thank you very much. btw, what different between and ? > It was a very interesting result. > In embedded system, your patch improve performance a little in case > without noswap(normal case in embedded system). > But, more important thing is OOM occured when I made 240 process >

Re: [RFC][PATCH] the proposal of improve page reclaim by throttle

2008-02-20 Thread KOSAKI Motohiro
Hi > > > * max parallel reclaim tasks: > > > * max consumption time of > > > try_to_free_pages(): > > > > sorry, I inserted debug code to my patch at that time. > > Could you send me that debug code ? > If you will send it to me, I will test it my environment (ARM-920T, Core2Duo). > An

Re: [RFC][PATCH] the proposal of improve page reclaim by throttle

2008-02-20 Thread KOSAKI Motohiro
Hi Kim-san Do you adjust hackbench parameter? my parameter adjust my test machine(8GB mem), if unchanged, maybe doesn't works it because lack memory. > I am a many interested in your patch. so I want to test it with exact > same method as you did. > I will test it in embedded environment(ARM 920T

Re: [PATCH 0/8][for -mm] mem_notify v6

2008-02-19 Thread KOSAKI Motohiro
> Did those jobs share nodes -- sometimes two or more jobs using the same > nodes? I am sure SGI has such users too, though such job mixes make > the runtimes of specific jobs less obvious, so customers are more > tolerant of variations and some inefficiencies, as they get hidden in > the mix. Hm

Re: [PATCH 0/8][for -mm] mem_notify v6

2008-02-19 Thread KOSAKI Motohiro
Hi Rik > > Sounds like a job for memory limits (ulimit?), not for OOM > > notification, right? > > I suspect one problem could be that an HPC job scheduling program > does not know exactly how much memory each job can take, so it can > sometimes end up making a mistake and overcommitting the memo

cpuset trivial documentation fix s/N_MEMORY/N_HIGH_MEMORY/

2008-02-19 Thread KOSAKI Motohiro
Hi, this is easy documentation fix. current implementation of cpuset track N_HIGH_MEMORY instead N_MEMORY. (N_MEMORY doesn't exist in current implementation) Signed-off-by: KOSAKI Motohiro <[EMAIL PROTECTED]> CC: Paul Jackson <[EMAIL PROTECTED]> CC: Christoph Lameter <[

Re: [PATCH 0/8][for -mm] mem_notify v6

2008-02-18 Thread KOSAKI Motohiro
Hi Paul, Thank you for wonderful interestings comment. your comment is really nice. I was HPC guy with large NUMA box at past. I promise i don't ignroe hpc user. but unfortunately I didn't have experience of use CPUSET because at that point, it was under development yet. I hope discuss you that

Re: [RFC][PATCH] the proposal of improve page reclaim by throttle

2008-02-18 Thread KOSAKI Motohiro
Hi Nick, > Yeah this is definitely needed and a nice result. > > I'm worried about a) placing a global limit on parallelism, and b) > placing a limit on parallelism at all. sorry, i don't understand yet. a) and b) have any relation? > > I think it should maybe be a per-zone thing... > > What

[RFC][PATCH] the proposal of improve page reclaim by throttle

2008-02-18 Thread KOSAKI Motohiro
ck contention. (see above sys time. about 80% reduced) Now, we got about 1000% performance improvement of hackbench :) foture works == - more discussion with memory controller guys. Signed-off-by: KOSAKI Motohiro <[EMAIL PROTECTE

Re: [RFC] bitmap onto and fold operators for mempolicy extensions

2008-02-16 Thread KOSAKI Motohiro
Hi Paul, > > iff? > > other portions looks good :) > > "iff" -- "if and only if" > > It is from my days, a long long time ago, as a student of mathematical > logic and set theory. I was too lazy to spell that one out. My bad. not at all. I did't know the abbreviation, sorry. I think your pat

Re: [RFC] bitmap onto and fold operators for mempolicy extensions

2008-02-16 Thread KOSAKI Motohiro
Hi Paul, > The bitmap_fold() operator folds a bitmap into a second that > has bit m set iff the input bitmap has some bit n set, where > m == n mod sz, for the specified sz value. iff? other portions looks good :) Reviewed-by: KOSAKI Motohiro <[EMAIL PROTECTED]> Thanks! -- To u

Re: [RFC] bitmap relative operator for mempolicy extensions

2008-02-14 Thread KOSAKI Motohiro
Hi Ray, > > > i prefer another name [!relative]. > > > > Any suggestions? > > > > I'll give the name some thought myself. > > I like good names, and this is the right > > time to get this one right. > > 'Relative map' implies a constant offset. What you have there is just > a map as relmap c

Re: [RFC] bitmap relative operator for mempolicy extensions

2008-02-14 Thread KOSAKI Motohiro
Hi Paul, > The following adds one more bitmap operator, with the usual > cpumask and nodemask wrappers. This operator computes one > bitmap relative to another. If the n-th bit in the origin > mask is set, then the m-th bit of the destination mask will > be set, where m is the position of t

Re: [PATCH 4/8][for -mm] mem_notify v6: memory_pressure_notify() caller

2008-02-13 Thread KOSAKI Motohiro
Hi Andi, > > to be honest, I don't think at mem-cgroup until now. > > There is not only mem-cgroup BTW, but also NUMA node restrictons from > NUMA memory policy. So this means a process might not be able to access > all memory. you are right. good point out. current implementation may cause wak

Re: split up feature-removal-schedule.txt

2008-02-12 Thread KOSAKI Motohiro
Hi Greg > In the big "linux-next" series of emails, David Miller suggested that > the feature-removal-schedule file be broken up into little pieces, as it > is causing merge problems for different trees. > > This changeset does just that. Turns out that this makes things more > readable, as it's

Re: [PATCH 4/8][for -mm] mem_notify v6: memory_pressure_notify() caller

2008-02-12 Thread KOSAKI Motohiro
Hi Andrew > > and, It is judged out of trouble at the fllowing situations. > > o memory pressure decrease and stop moves an anonymous page to the > > inactive list. > > o free pages increase than (pages_high+lowmem_reserve)*2. > > This seems rather arbitrary. Why choose this stage in the page

Re: [PATCH for 2.6.24][regression fix] Mempolicy: silently restrict nodemask to allowed nodes V3

2008-02-12 Thread KOSAKI Motohiro
Hi > > please ack. > > As it's now post -rc1 and not a 100% obvious thing, I tend to hang onto > such patches for a week or so before sending up to Linus Thanks, really thanks. > Should this be backported to 2.6.24.x? If so, the reasons for such a > relatively stern step should be spelled out

[PATCH for 2.6.24][regression fix] Mempolicy: silently restrict nodemask to allowed nodes V3

2008-02-11 Thread KOSAKI Motohiro
, remove the in-line nodes_and() from sys_mbind(). I believe that this restores mbind() to the behavior before the memoryless-nodes patch series. E.g., we'll no longer treat an invalid nodemask with MPOL_PREFERRED as local allocation. Signed-off-by: Lee Schermerhorn <[EM

Re: [sample] mem_notify v6: usage example

2008-02-11 Thread KOSAKI Motohiro
Hi Andreas, Thank you very good comment. > Having such notification handled by glibc to free up unused malloc (or > any heap allocations) would be very useful, because even if a program > does "free" there is no guarantee the memory is returned to the kernel. Yes, no guarantee. but current glibc

Re: [patch 3/4] mempolicy: add MPOL_F_STATIC_NODES flag

2008-02-11 Thread KOSAKI Motohiro
Hi David, In general, I like this feature. and I found no bug in patch [1/4] and [2/4]. > @@ -218,21 +167,27 @@ static struct mempolicy *mpol_new(enum mempolicy_mode > mode, > return ERR_PTR(-ENOMEM); > flags &= MPOL_MODE_FLAGS; > atomic_set(&policy->refcnt, 1); >

Re: [PATCH 0/8][for -mm] mem_notify v6

2008-02-11 Thread KOSAKI Motohiro
> > the Linux Today article is very nice description. (great works by Jake Edge) > > http://www.linuxworld.com/news/2008/020508-kernel.html > > Just for future reference...the above-mentioned article is from LWN, > syndicated onto LinuxWorld. It has, so far as I know, never been near > Linux Today

Re: [PATCH] proc: extend /proc//fdinfo/

2008-02-11 Thread KOSAKI Motohiro
Hi Eugene In general, I think this patch isn't wrong idea. but it shuld be brush up more, may be. > kerndev: ~/code/kernel# cat /proc/`pgrep pickup`/fdinfo/6 > mode: 0622 I think this is inode attribute, but not fd attribute. > dev:253,0 > ino:21463057 may be useful, agreed with you

Re: [PATCH 2.6.24-mm1] Mempolicy: silently restrict nodemask to allowed nodes V3

2008-02-09 Thread KOSAKI Motohiro
CC'd Greg KH <[EMAIL PROTECTED]> I tested this patch on fujitsu memoryless node. (2.6.24 + silently-restrict-nodemask-to-allowed-nodes-V3 insted 2.6.24-mm1) it seems works good. Tested-by: KOSAKI Motohiro <[EMAIL PROTECTED]> Greg, I hope this patch merge to 2.6.24.x stable

Re: [PATCH 2.6.24-mm1] Mempolicy: silently restrict nodemask to allowed nodes V3

2008-02-09 Thread KOSAKI Motohiro
Hi Lee-san looks good for me. I'll test about the head of week and report it by another mail. Thanks! > Was "Re: [2.6.24 regression][BUGFIX] numactl --interleave=all doesn't > works on memoryless node." > > [Aside: I noticed there were two slightly different distributions for > this topic. I'v

Re: [PATCH 0/8][for -mm] mem_notify v6

2008-02-09 Thread KOSAKI Motohiro
Hi Rik > More importantly, all gtk+ programs, as well as most databases and other > system daemons have a poll() loop as their main loop. not only gtk+, may be all modern GUI program :) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL P

Re: [sample] mem_notify v6: usage example

2008-02-09 Thread KOSAKI Motohiro
Hi Jon > This really needs to be triggered via a generic kernel event in the > final version - I picture glibc having a reservation API and having > generic support for freeing such reservations. to be honest, I doubt idea of generic reservation framework. end up, we hope drop the application ca

Re: [PATCH 0/8][for -mm] mem_notify v6

2008-02-09 Thread KOSAKI Motohiro
Hi > Interesting patch series (I am being yuppie and reading this thread > from my iPhone on a treadmill at the gym - so further comments later). > I think that this is broadly along the lines that I was thinking, but > this should be an RFC only patch series for now. sorry, I fixed at next post.

[sample] mem_notify v6: usage example

2008-02-09 Thread KOSAKI Motohiro
this is usage example of /dev/mem_notify. Daniel Spang create original version. kosaki add fasync related code. Signed-off-by: Daniel Spang <[EMAIL PROTECTED]> Signed-off-by: KOSAKI Motohiro <[EMAIL PROTECTED]> --- Documentation/mem_not

[PATCH 8/8][for -mm] mem_notify v6: support fasync feature

2008-02-09 Thread KOSAKI Motohiro
ve SIGUSR1 */ ChangeLog v5 -> v6: o rewrite usage example o cleanups number of wakeup tasks calculation. v5: new Signed-off-by: KOSAKI Motohiro <[EMAIL PROTECTED]> --- mm/mem_notify.c | 109 +

[PATCH 7/8][for -mm] mem_notify v6: ignore very small zone for prevent incorrect low mem notify

2008-02-09 Thread KOSAKI Motohiro
: KOSAKI Motohiro <[EMAIL PROTECTED]> --- include/linux/mem_notify.h |3 +++ mm/page_alloc.c|6 +- 2 files changed, 8 insertions(+), 1 deletion(-) Index: b/include/linux/mem_notify.h === --- a/include

[PATCH 6/8][for -mm] mem_notify v6: (optional) fixed incorrect shrink_zone

2008-02-09 Thread KOSAKI Motohiro
rity) + 1; ^ it cause unnecessary low memory notify ;-) I fixed it. ChangeLog v5: new Signed-off-by: KOSAKI Motohiro <[EMAIL PROTECTED]> --- mm/vmscan.c | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) Index

[PATCH 5/8][for -mm] mem_notify v6: add new mem_notify field to /proc/zoneinfo

2008-02-09 Thread KOSAKI Motohiro
show new member of zone struct by /proc/zoneinfo. ChangeLog: v5: change display order to at last. Signed-off-by: Marcelo Tosatti <[EMAIL PROTECTED]> Signed-off-by: KOSAKI Motohiro <[EMAIL PROTECTED]> --- mm/vmstat.c |8 +--- 1 file changed, 5 insertions(+),

[PATCH 4/8][for -mm] mem_notify v6: memory_pressure_notify() caller

2008-02-09 Thread KOSAKI Motohiro
pressure decrease and stop moves an anonymous page to the inactive list. o free pages increase than (pages_high+lowmem_reserve)*2. ChangeLog: v5: add out of trouble notify to exit of balance_pgdat(). Signed-off-by: Marcelo Tosatti <[EMAIL PROTECTED]> Signed-off-by: KOSAKI Motohiro &

[PATCH 3/8][for -mm] mem_notify v6: introduce /dev/mem_notify new device (the core of this patch series)

2008-02-09 Thread KOSAKI Motohiro
s.revents = 0; err = poll(&pollfds, 1, -1); // wake up at low memory ... ChangeLog v5 -> v6: o improve number of wakeup tasks fomula when task is a few. Signed-off-by: Marcelo Tosatti <[EMAIL PROTECTED]> Signed-off-by: KOSAKI Motohiro <[EMAIL PR

[PATCH 2/8][for -mm] mem_notify v6: introduce wake_up_locked_nr() new API

2008-02-09 Thread KOSAKI Motohiro
introduce new API wake_up_locked_nr() and wake_up_locked_all(). it it similar as wake_up_nr() and wake_up_all(), but it doesn't lock. Signed-off-by: Marcelo Tosatti <[EMAIL PROTECTED]> Signed-off-by: KOSAKI Motohiro <[EMAIL PROTECTED]> --- include/linux/wait.h | 12 +++

[PATCH 1/8][for -mm] mem_notify v6: introduce poll_wait_exclusive()

2008-02-09 Thread KOSAKI Motohiro
(file, &kosaki_wait_queue, wait); if (data_exist) return POLLIN | POLLRDNORM; return 0; } Signed-off-by: Marcelo Tosatti <[EMAIL PROTECTED]> Signed-off-by: KOSAKI Motohiro <[EMAIL PROTECTED]> --- fs/eventpoll.c |7 +-- fs/select.c |

[PATCH 0/8][for -mm] mem_notify v6

2008-02-09 Thread KOSAKI Motohiro
mp;m=119427416315676&w=2 mem notification v4 http://marc.info/?l=linux-mm&m=120035840523718&w=2 mem notification v5 http://marc.info/?l=linux-mm&m=120114835421602&w=2 Changelog ----- v5 -> v6 (by KOSAKI Motohiro) o

Re: C++ in linux kernel

2008-02-07 Thread KOSAKI Motohiro
Hi > I am a kernel newbie. > I tried to insmod a C++ module containing classes, inheritance. > I am getting 'unresolved symbol' error when I use the 'new' keyword. > What could the problem be? under using gcc, new operator use malloc by default. but linux doesn't have malloc. Could you creat

Re: [2.6.24 regression][BUGFIX] numactl --interleave=all doesn't works on memoryless node.

2008-02-07 Thread KOSAKI Motohiro
Hi Lee-san Unfortunately, 2.6.24-mm1 can't boot on fujitsu machine. (hmm, origin.patch cause regression to pci initialization ;-) instead, I tested 2.6.24 + your patch. it seem work good :) Tested-by: KOSAKI Motohiro <[EMAIL PROTECTED]> and, I have a bit comment. > /* Do sani

Re: [patch 05/19] split LRU lists into anon & file sets

2008-02-06 Thread KOSAKI Motohiro
Hi Rik Welcome back :) > > I found number of scan pages calculation bug. > > My latest version of get_scan_ratio() works differently, with the > percentages always adding up to 100. However, your patch gave me > the inspiration to (hopefully) find the bug in my version of the > code. OK. > >

Re: 2.6.24-mm1

2008-02-06 Thread KOSAKI Motohiro
> should be fixed by the commit below. (already upstream) > > Ingo Oops, sorry ;-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

Re: 2.6.24-mm1

2008-02-06 Thread KOSAKI Motohiro
Hi Ingo, > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24/2.6.24-mm1/ > > > - The x86 git tree has been dropped due to runtime failure on one of my test > machines My PC display warning message at boot time. Could I help your debugging? ---

<    1   2   3   4   5   >