Re: [PATCHv4 05/13] Documentation/ABI: Add new node sysfs attributes

2019-01-18 Thread Keith Busch
On Thu, Jan 17, 2019 at 12:41:19PM +0100, Rafael J. Wysocki wrote: > On Wed, Jan 16, 2019 at 6:59 PM Keith Busch wrote: > > > > Add entries for memory initiator and target node class attributes. > > > > Signed-off-by: Keith Busch > > I would recommend combining

Re: [PATCHv4 00/13] Heterogeneuos memory node attributes

2019-01-17 Thread Keith Busch
On Thu, Jan 17, 2019 at 10:18:35AM -0800, Jonathan Cameron wrote: > I've been having a play with various hand constructed HMAT tables to allow > me to try breaking them in all sorts of ways. > > Mostly working as expected. > > Two places I am so far unsure on... > > 1. Concept of 'best' is not i

Re: [PATCH 0/4] Allow persistent memory to be used like normal RAM

2019-01-17 Thread Keith Busch
On Thu, Jan 17, 2019 at 12:20:06PM -0500, Jeff Moyer wrote: > Keith Busch writes: > > On Thu, Jan 17, 2019 at 11:29:10AM -0500, Jeff Moyer wrote: > >> Dave Hansen writes: > >> > Persistent memory is cool. But, currently, you have to rewrite > >> > yo

Re: [PATCH 0/4] Allow persistent memory to be used like normal RAM

2019-01-17 Thread Keith Busch
On Thu, Jan 17, 2019 at 11:29:10AM -0500, Jeff Moyer wrote: > Dave Hansen writes: > > Persistent memory is cool. But, currently, you have to rewrite > > your applications to use it. Wouldn't it be cool if you could > > just have it show up in your system like normal RAM and get to > > it like a

Re: [PATCHv4 00/13] Heterogeneuos memory node attributes

2019-01-17 Thread Keith Busch
On Thu, Jan 17, 2019 at 11:58:21PM +1100, Balbir Singh wrote: > On Wed, Jan 16, 2019 at 10:57:51AM -0700, Keith Busch wrote: > > It had previously been difficult to describe these setups as memory > > rangers were generally lumped into the NUMA node of the CPUs. New > > pla

[PATCHv4 07/13] node: Add heterogenous memory access attributes

2019-01-16 Thread Keith Busch
eported here. When a subsystem makes use of this interface, initiators of a lower class number, "Z", have better performance relative to higher class numbers. When provided, class 0 is the highest performing access class. Signed-off-by: Keith Busch --- drivers/base/Kconfig

[PATCHv4 05/13] Documentation/ABI: Add new node sysfs attributes

2019-01-16 Thread Keith Busch
Add entries for memory initiator and target node class attributes. Signed-off-by: Keith Busch --- Documentation/ABI/stable/sysfs-devices-node | 25 - 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/Documentation/ABI/stable/sysfs-devices-node b

[PATCHv4 04/13] node: Link memory nodes to their compute nodes

2019-01-16 Thread Keith Busch
nodelist: # cat /sys/devices/system/node/nodeX/class0/target_nodelist Y # cat /sys/devices/system/node/nodeY/class0/initiator_nodelist X Signed-off-by: Keith Busch --- drivers/base/node.c | 127 ++- include/linux/node.h | 6 ++- 2 files

[PATCHv4 00/13] Heterogeneuos memory node attributes

2019-01-16 Thread Keith Busch
series' objective is to provide the attributes from such systems that are useful for applications to know about, and readily usable with existing tools and libraries. Keith Busch (13): acpi: Create subtable parsing infrastructure acpi: Add HMAT to generic parsing tables acpi/hmat: Pars

[PATCHv4 08/13] Documentation/ABI: Add node performance attributes

2019-01-16 Thread Keith Busch
Add descriptions for memory class initiator performance access attributes. Signed-off-by: Keith Busch --- Documentation/ABI/stable/sysfs-devices-node | 28 1 file changed, 28 insertions(+) diff --git a/Documentation/ABI/stable/sysfs-devices-node b/Documentation

[PATCHv4 10/13] node: Add memory caching attributes

2019-01-16 Thread Keith Busch
the cache size, the line size, associativity, and write back policy. Signed-off-by: Keith Busch --- drivers/base/node.c | 142 +++ include/linux/node.h | 39 ++ 2 files changed, 181 insertions(+) diff --git a/drivers/base/node.c b

[PATCHv4 01/13] acpi: Create subtable parsing infrastructure

2019-01-16 Thread Keith Busch
parsing the entries array may be more reused for all ACPI system tables and the common code doesn't need to be duplicated. Reviewed-by: Rafael J. Wysocki Cc: Dan Williams Signed-off-by: Keith Busch --- arch/arm64/kernel/acpi_numa.c | 2 +- arch/arm64/kernel/

[PATCHv4 13/13] doc/mm: New documentation for memory performance

2019-01-16 Thread Keith Busch
query this information. Reviewed-by: Mike Rapoport Signed-off-by: Keith Busch --- Documentation/admin-guide/mm/numaperf.rst | 184 ++ 1 file changed, 184 insertions(+) create mode 100644 Documentation/admin-guide/mm/numaperf.rst diff --git a/Documentation/admin-guide

[PATCHv4 02/13] acpi: Add HMAT to generic parsing tables

2019-01-16 Thread Keith Busch
The Heterogeneous Memory Attribute Table (HMAT) header has different field lengths than the existing parsing uses. Add the HMAT type to the parsing rules so it may be generically parsed. Cc: Dan Williams Reviewed-by: Rafael J. Wysocki Signed-off-by: Keith Busch --- drivers/acpi/tables.c | 9

[PATCHv4 12/13] acpi/hmat: Register memory side cache attributes

2019-01-16 Thread Keith Busch
Register memory side cache attributes with the memory's node if HMAT provides the side cache iniformation table. Signed-off-by: Keith Busch --- drivers/acpi/hmat/hmat.c | 32 1 file changed, 32 insertions(+) diff --git a/drivers/acpi/hmat/hmat.c b/drivers

[PATCHv4 09/13] acpi/hmat: Register performance attributes

2019-01-16 Thread Keith Busch
Save the best performace access attributes and register these with the memory's node if HMAT provides the locality table. While HMAT does make it possible to know performance for all possible initiator-target pairings, we export only the best pairings at this time. Signed-off-by: Keith

[PATCHv4 11/13] Documentation/ABI: Add node cache attributes

2019-01-16 Thread Keith Busch
Add the attributes for the system memory side caches. Signed-off-by: Keith Busch --- Documentation/ABI/stable/sysfs-devices-node | 34 + 1 file changed, 34 insertions(+) diff --git a/Documentation/ABI/stable/sysfs-devices-node b/Documentation/ABI/stable/sysfs

[PATCHv4 03/13] acpi/hmat: Parse and report heterogeneous memory

2019-01-16 Thread Keith Busch
Systems may provide different memory types and export this information in the ACPI Heterogeneous Memory Attribute Table (HMAT). Parse these tables provided by the platform and report the memory access and caching attributes. Signed-off-by: Keith Busch --- drivers/acpi/Kconfig | 1

[PATCHv4 06/13] acpi/hmat: Register processor domain to its memory

2019-01-16 Thread Keith Busch
HMAT requires valid address ranges have an equivalent SRAT entry, verify each memory target satisfies this requirement. Signed-off-by: Keith Busch --- drivers/acpi/hmat/hmat.c | 143 --- 1 file changed, 136 insertions(+), 7 deletions(-) diff --git a/dr

Re: [PATCHv3 03/13] acpi/hmat: Parse and report heterogeneous memory

2019-01-15 Thread Keith Busch
On Thu, Jan 10, 2019 at 07:42:46AM -0800, Rafael J. Wysocki wrote: > On Wed, Jan 9, 2019 at 6:47 PM Keith Busch wrote: > > > > Systems may provide different memory types and export this information > > in the ACPI Heterogeneous Memory Attribute Table (HMAT). Parse these >

Re: Please remove warnings from msi.c:1269 and blk-mq-pci.c:52 some day

2019-01-14 Thread Keith Busch
[+linux-n...@lists.infradead.org] On Mon, Jan 14, 2019 at 10:03:39AM -0700, Keith Busch wrote: > [+Ming] > On Mon, Jan 14, 2019 at 08:31:45AM -0600, Bjorn Helgaas wrote: > > [+cc Dou, Jens, Thomas, Christoph, linux-pci, LKML] > > > > On Sun, Jan 13, 2019 at 11:24 PM fin

Re: Please remove warnings from msi.c:1269 and blk-mq-pci.c:52 some day

2019-01-14 Thread Keith Busch
[+Ming] On Mon, Jan 14, 2019 at 08:31:45AM -0600, Bjorn Helgaas wrote: > [+cc Dou, Jens, Thomas, Christoph, linux-pci, LKML] > > On Sun, Jan 13, 2019 at 11:24 PM fin4478 fin4478 wrote: > > > > Hi, > > > > A regression from the 4.20 kernel: I have the Asgard 256GB nvme drive > > and my custom non

Re: [PATCHv3 13/13] doc/mm: New documentation for memory performance

2019-01-14 Thread Keith Busch
On Sun, Jan 13, 2019 at 01:42:30PM +0200, Mike Rapoport wrote: > There are a couple of nitpicks below, otherwise > > Reviewed-by: Mike Rapoport Thank you for the detailed review. I've incorporated all your recommmendations for the next revision.

Re: [PATCHv3 08/13] Documentation/ABI: Add node performance attributes

2019-01-14 Thread Keith Busch
On Mon, Jan 14, 2019 at 12:10:12AM +0100, Pavel Machek wrote: > On Wed 2019-01-09 10:43:36, Keith Busch wrote: > > + This node's write latency in nanosecondss available to memory > > + initiators in nodes found in this class's > > initiators_nodel

Re: [PATCHv3 07/13] node: Add heterogenous memory access attributes

2019-01-11 Thread Keith Busch
On Fri, Jan 11, 2019 at 11:32:38AM +, Jonathan Cameron wrote: > On Thu, 10 Jan 2019 10:30:17 -0700 > Keith Busch wrote: > > I am not aware of a real platform that has an initiator-target pair with > > better latency but worse bandwidth than any different initiator pair

Re: [PATCHv3 07/13] node: Add heterogenous memory access attributes

2019-01-10 Thread Keith Busch
On Thu, Jan 10, 2019 at 06:07:02PM +0530, Aneesh Kumar K.V wrote: > Keith Busch writes: > > > Heterogeneous memory systems provide memory nodes with different latency > > and bandwidth performance attributes. Provide a new kernel interface for > > subsystems to register

Re: [PATCH] nvme: fix out of bounds access in nvme_cqe_pending

2019-01-10 Thread Keith Busch
On Wed, Jan 09, 2019 at 05:54:59PM -0800, Yao HongBo wrote: > On 1/10/2019 2:39 AM, Christoph Hellwig wrote: > > On Mon, Jan 07, 2019 at 10:22:07AM +0800, Hongbo Yao wrote: > >> There is an out of bounds array access in nvme_cqe_peding(). > >> > >> When enable irq_thread for nvme interrupt, there i

[PATCHv3 10/13] node: Add memory caching attributes

2019-01-09 Thread Keith Busch
the cache size, the line size, associativity, and write back policy. Signed-off-by: Keith Busch --- drivers/base/node.c | 142 +++ include/linux/node.h | 39 ++ 2 files changed, 181 insertions(+) diff --git a/drivers/base/node.c b

[PATCHv3 09/13] acpi/hmat: Register performance attributes

2019-01-09 Thread Keith Busch
Save the best performace access attributes and register these with the memory's node if HMAT provides the locality table. While HMAT does make it possible to know performance for all possible initiator-target pairings, we export only the best pairings at this time. Signed-off-by: Keith

[PATCHv3 04/13] node: Link memory nodes to their compute nodes

2019-01-09 Thread Keith Busch
on is reflected in the nodelist: # cat /sys/devices/system/node/nodeX/class0/target_nodelist Y # cat /sys/devices/system/node/nodeY/class0/initiator_nodelist X Signed-off-by: Keith Busch --- drivers/base/node.c | 127 ++- include/linux/node

[PATCHv3 07/13] node: Add heterogenous memory access attributes

2019-01-09 Thread Keith Busch
eported here. When a subsystem makes use of this interface, initiators of a lower class number, "Z", have better performance relative to higher class numbers. When provided, class 0 is the highest performing access class. Signed-off-by: Keith Busch --- drivers/base/Kconfig

[PATCHv3 05/13] Documentation/ABI: Add new node sysfs attributes

2019-01-09 Thread Keith Busch
Add entries for memory initiator and target node class attributes. Signed-off-by: Keith Busch --- Documentation/ABI/stable/sysfs-devices-node | 25 - 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/Documentation/ABI/stable/sysfs-devices-node b

[PATCHv3 12/13] acpi/hmat: Register memory side cache attributes

2019-01-09 Thread Keith Busch
Register memory side cache attributes with the memory's node if HMAT provides the side cache iniformation table. Signed-off-by: Keith Busch --- drivers/acpi/hmat.c | 32 1 file changed, 32 insertions(+) diff --git a/drivers/acpi/hmat.c b/drivers/acpi/h

[PATCHv3 11/13] Documentation/ABI: Add node cache attributes

2019-01-09 Thread Keith Busch
Add the attributes for the system memory side caches. Signed-off-by: Keith Busch --- Documentation/ABI/stable/sysfs-devices-node | 34 + 1 file changed, 34 insertions(+) diff --git a/Documentation/ABI/stable/sysfs-devices-node b/Documentation/ABI/stable/sysfs

[PATCHv3 06/13] acpi/hmat: Register processor domain to its memory

2019-01-09 Thread Keith Busch
HMAT requires valid address ranges have an equivalent SRAT entry, verify each memory target satisfies this requirement. Signed-off-by: Keith Busch --- drivers/acpi/hmat.c | 143 +--- 1 file changed, 136 insertions(+), 7 deletions(-) diff --git a/dr

[PATCHv3 01/13] acpi: Create subtable parsing infrastructure

2019-01-09 Thread Keith Busch
parsing the entries array may be more reused for all ACPI system tables and the common code doesn't need to be duplicated. Reviewed-by: Rafael J. Wysocki Cc: Dan Williams Signed-off-by: Keith Busch --- arch/arm64/kernel/acpi_numa.c | 2 +- arch/arm64/kernel/

[PATCHv3 08/13] Documentation/ABI: Add node performance attributes

2019-01-09 Thread Keith Busch
Add descriptions for memory class initiator performance access attributes. Signed-off-by: Keith Busch --- Documentation/ABI/stable/sysfs-devices-node | 28 1 file changed, 28 insertions(+) diff --git a/Documentation/ABI/stable/sysfs-devices-node b/Documentation

[PATCHv3 00/13] Heterogeneuos memory node attributes

2019-01-09 Thread Keith Busch
ters the best performing class, "class0". Various changelog and documentation updates and clarifications. Keith Busch (13): acpi: Create subtable parsing infrastructure acpi: Add HMAT to generic parsing tables acpi/hmat: Parse and report heterogeneous memory node: Link memory nodes to

[PATCHv3 02/13] acpi: Add HMAT to generic parsing tables

2019-01-09 Thread Keith Busch
The Heterogeneous Memory Attribute Table (HMAT) header has different field lengths than the existing parsing uses. Add the HMAT type to the parsing rules so it may be generically parsed. Cc: Dan Williams Signed-off-by: Keith Busch --- drivers/acpi/tables.c | 9 + include/linux/acpi.h

[PATCHv3 13/13] doc/mm: New documentation for memory performance

2019-01-09 Thread Keith Busch
query this information. Signed-off-by: Keith Busch --- Documentation/admin-guide/mm/numaperf.rst | 184 ++ 1 file changed, 184 insertions(+) create mode 100644 Documentation/admin-guide/mm/numaperf.rst diff --git a/Documentation/admin-guide/mm/numaperf.rst b

[PATCHv3 03/13] acpi/hmat: Parse and report heterogeneous memory

2019-01-09 Thread Keith Busch
Systems may provide different memory types and export this information in the ACPI Heterogeneous Memory Attribute Table (HMAT). Parse these tables provided by the platform and report the memory access and caching attributes. Signed-off-by: Keith Busch --- drivers/acpi/Kconfig | 8

Re: [PATCH] nvme-core: don't initlialize ctrl->cntlid twice

2019-01-08 Thread Keith Busch
gt; > if (ctrl->cntlid != le16_to_cpu(id->cntlid)) > > below will always be a no-op. Yeah, this bug defeats the fabrics sanity check. Good catch. Reviewed-by: Keith Busch > diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c > index 2e65be8b1387..1ec87b30fa

Re: [PATCH v4 2/2] trace nvme submit queue status

2018-12-18 Thread Keith Busch
On Tue, Dec 18, 2018 at 06:47:50PM +0100, h...@lst.de wrote: > On Tue, Dec 18, 2018 at 10:26:46AM -0700, Keith Busch wrote: > > No need for a space after the %s. __print_disk_name already appends a > > space if there's a disk name, and we don't want the extra space if

Re: [PATCH v4 2/2] trace nvme submit queue status

2018-12-18 Thread Keith Busch
On Mon, Dec 17, 2018 at 08:51:38PM -0800, yupeng wrote: > +TRACE_EVENT(nvme_sq, > + TP_PROTO(void *rq_disk, int qid, int sq_head, int sq_tail), > + TP_ARGS(rq_disk, qid, sq_head, sq_tail), > + TP_STRUCT__entry( > + __array(char, disk, DISK_NAME_LEN) > + __field(i

Re: [PATCHv2 12/12] doc/mm: New documentation for memory performance

2018-12-12 Thread Keith Busch
On Wed, Dec 12, 2018 at 10:23:24AM +0530, Aneesh Kumar K.V wrote: > On 12/11/18 6:33 AM, Keith Busch wrote: > > +When multiple memory initiators exist, they may not all have the same > > +performance when accessing a given memory target. The highest performing > > +initiator

Re: [PATCH] PCI/AER: only insert one element into kfifo

2018-12-12 Thread Keith Busch
: > " * @n: number of elements to be added". > > We want to insert only one element into kfifo, not "sizeof(entry) = 16". > Without this patch, we would get 15 uninitialized elements. > > Signed-off-by: Yanjiang Jin My bad. I had trouble testing the GHES path for

Re: [PATCHv2 02/12] acpi/hmat: Parse and report heterogeneous memory

2018-12-11 Thread Keith Busch
On Tue, Dec 11, 2018 at 12:29:45PM -0800, Dan Williams wrote: > On Tue, Dec 11, 2018 at 8:58 AM Keith Busch wrote: > > +static int __init > > +acpi_parse_cache(union acpi_subtable_headers *header, const unsigned long > > end) > > +{ > > + struct acpi_h

Re: [PATCHv2 02/12] acpi/hmat: Parse and report heterogeneous memory

2018-12-11 Thread Keith Busch
On Mon, Dec 10, 2018 at 10:03:40PM -0800, Dan Williams wrote: > I have a use case to detect the presence of a memory-side-cache early > at init time [1]. To me this means that hmat_init() needs to happen as > a part of acpi_numa_init(). Subsequently I think that also means that > the sysfs portion

[PATCHv2 03/12] node: Link memory nodes to their compute nodes

2018-12-10 Thread Keith Busch
ist) \ --cpunodebind=$(cat ${DEV_NODE}/primary_cpu_nodelist) \ -- fio --filename=/dev/nvme0n1 --bs=4k --name=access-test Signed-off-by: Keith Busch --- drivers/base/node.c | 85 include/linux/node.h | 4 +++ 2 files changed, 89 inse

[PATCHv2 00/12] Heterogeneous memory node attributes

2018-12-10 Thread Keith Busch
alize HMAT with subsys_initcall instead of device_init. Combined the numa performance documentation into a single file and moved it to admin-guide/mm/. Changelogs updated with spelling/grammar/editorial fixes, and include additional examples. Keith Busch (12): acpi: Create subtable parsing infras

[PATCHv2 09/12] node: Add memory caching attributes

2018-12-10 Thread Keith Busch
size, associativity, and write back policy. Signed-off-by: Keith Busch --- drivers/base/node.c | 140 +++ include/linux/node.h | 23 + 2 files changed, 163 insertions(+) diff --git a/drivers/base/node.c b/drivers/base/node.c index 768612c

[PATCHv2 11/12] acpi/hmat: Register memory side cache attributes

2018-12-10 Thread Keith Busch
Register memory side cache attributes with the memory's node if HMAT provides the side cache information table. Signed-off-by: Keith Busch --- drivers/acpi/hmat.c | 32 1 file changed, 32 insertions(+) diff --git a/drivers/acpi/hmat.c b/drivers/acpi/h

[PATCHv2 04/12] Documentation/ABI: Add new node sysfs attributes

2018-12-10 Thread Keith Busch
Add the entries for primary cpu and memory node attributes. Signed-off-by: Keith Busch --- Documentation/ABI/stable/sysfs-devices-node | 34 - 1 file changed, 33 insertions(+), 1 deletion(-) diff --git a/Documentation/ABI/stable/sysfs-devices-node b/Documentation

[PATCHv2 02/12] acpi/hmat: Parse and report heterogeneous memory

2018-12-10 Thread Keith Busch
Systems may provide different memory types and export this information in the ACPI Heterogeneous Memory Attribute Table (HMAT). Parse these tables provided by the platform and report the memory access and caching attributes. Signed-off-by: Keith Busch --- drivers/acpi/Kconfig | 8

[PATCHv2 06/12] node: Add heterogenous memory performance

2018-12-10 Thread Keith Busch
filename=/dev/nvme0n1 --bs=4k --name=access-test Signed-off-by: Keith Busch --- drivers/base/Kconfig | 8 drivers/base/node.c | 44 include/linux/node.h | 22 ++ 3 files changed, 74 insertions(+) diff --git a/drivers/b

[PATCHv2 08/12] acpi/hmat: Register performance attributes

2018-12-10 Thread Keith Busch
Save the best performance access attributes and register these with the memory's node if HMAT provides the locality table. Signed-off-by: Keith Busch --- drivers/acpi/Kconfig | 1 + drivers/acpi/hmat.c | 34 ++ 2 files changed, 35 insertions(+) diff --

[PATCHv2 05/12] acpi/hmat: Register processor domain to its memory

2018-12-10 Thread Keith Busch
directory. Since HMAT requires valid address ranges have an equivalent SRAT entry, verify each memory target satisfies this requirement. Signed-off-by: Keith Busch --- drivers/acpi/hmat.c | 149 +--- 1 file changed, 142 insertions(+), 7 deletion

[PATCHv2 12/12] doc/mm: New documentation for memory performance

2018-12-10 Thread Keith Busch
query this information. Signed-off-by: Keith Busch --- Documentation/admin-guide/mm/numaperf.rst | 171 ++ 1 file changed, 171 insertions(+) create mode 100644 Documentation/admin-guide/mm/numaperf.rst diff --git a/Documentation/admin-guide/mm/numaperf.rst b

[PATCHv2 10/12] Documentation/ABI: Add node cache attributes

2018-12-10 Thread Keith Busch
Add the attributes for the system memory side caches. Signed-off-by: Keith Busch --- Documentation/ABI/stable/sysfs-devices-node | 34 + 1 file changed, 34 insertions(+) diff --git a/Documentation/ABI/stable/sysfs-devices-node b/Documentation/ABI/stable/sysfs

[PATCHv2 01/12] acpi: Create subtable parsing infrastructure

2018-12-10 Thread Keith Busch
parsing the entries array may be more reused for all ACPI system tables. Signed-off-by: Keith Busch --- arch/x86/kernel/acpi/boot.c | 36 drivers/acpi/numa.c | 16 +-- drivers/acpi/scan.c | 4 +-- drivers/acpi/tables.c| 67

[PATCHv2 07/12] Documentation/ABI: Add node performance attributes

2018-12-10 Thread Keith Busch
Add descriptions for primary memory initiator performance access attributes. Signed-off-by: Keith Busch --- Documentation/ABI/stable/sysfs-devices-node | 28 1 file changed, 28 insertions(+) diff --git a/Documentation/ABI/stable/sysfs-devices-node b/Documentation

Re: [PATCH] nvme-rdma: complete requests from ->timeout

2018-12-07 Thread Keith Busch
On Fri, Dec 07, 2018 at 12:05:37PM -0800, Sagi Grimberg wrote: > > > Could you please take a look at this bug and code review? > > > > We are seeing more instances of this bug and found that reconnect_work > > could hang as well, as can be seen from below stacktrace. > > > > Workqueue: nvme-wq

Re: [PATCH 1/7] node: Link memory nodes to their compute nodes

2018-12-04 Thread Keith Busch
On Tue, Dec 04, 2018 at 09:13:33PM +0530, Aneesh Kumar K.V wrote: > Keith Busch writes: > > > > Indeed, that particular example is out of scope for this series. The > > first objective is to aid a process running in node B's CPUs to allocate > > memory in B1. Any

Re: [PATCH 2/7] node: Add heterogenous memory performance

2018-11-27 Thread Keith Busch
On Mon, Nov 26, 2018 at 11:00:09PM -0800, Dan Williams wrote: > On Wed, Nov 14, 2018 at 2:53 PM Keith Busch wrote: > > > > Heterogeneous memory systems provide memory nodes with latency > > and bandwidth performance attributes that are different from other > > nodes.

Re: [PATCH 4/7] node: Add memory caching attributes

2018-11-26 Thread Keith Busch
On Mon, Nov 26, 2018 at 11:06:19AM -0800, Greg Kroah-Hartman wrote: > On Wed, Nov 14, 2018 at 03:49:17PM -0700, Keith Busch wrote: > > System memory may have side caches to help improve access speed. While > > the system provided cache is transparent to the software accessing &

Re: [PATCH 4/7] node: Add memory caching attributes

2018-11-26 Thread Keith Busch
On Thu, Nov 22, 2018 at 06:59:21PM +0530, Anshuman Khandual wrote: > > > On 11/20/2018 04:36 AM, Keith Busch wrote: > > On Mon, Nov 19, 2018 at 09:44:00AM +0530, Anshuman Khandual wrote: > >> On 11/15/2018 04:19 AM, Keith Busch wrote: > >>> System memory

Re: [PATCH 3/7] doc/vm: New documentation for memory performance

2018-11-20 Thread Keith Busch
On Tue, Nov 20, 2018 at 02:51:50PM +0100, Mike Rapoport wrote: > On Wed, Nov 14, 2018 at 03:49:16PM -0700, Keith Busch wrote: > > Platforms may provide system memory where some physical address ranges > > perform differently than others. These heterogeneous memory attributes are &g

Re: [PATCH 4/7] node: Add memory caching attributes

2018-11-19 Thread Keith Busch
On Mon, Nov 19, 2018 at 09:44:00AM +0530, Anshuman Khandual wrote: > On 11/15/2018 04:19 AM, Keith Busch wrote: > > System memory may have side caches to help improve access speed. While > > the system provided cache is transparent to the software accessing > > these memory

Re: [PATCH 6/7] acpi: Create subtable parsing infrastructure

2018-11-19 Thread Keith Busch
On Mon, Nov 19, 2018 at 10:58:12AM +0100, Rafael J. Wysocki wrote: > > +static unsigned long __init > > +acpi_get_entry_length(struct acpi_subtable_entry *entry) > > +{ > > + switch (entry->type) { > > + case ACPI_SUBTABLE_COMMON: > > + return entry->hdr->common.length; >

Re: [PATCH 0/2] PCI/AER: Consistently use _OSC to determine who owns AER

2018-11-19 Thread Keith Busch
On Mon, Nov 19, 2018 at 11:53:05AM -0500, Tyler Baicar wrote: > On Thu, Nov 15, 2018 at 8:49 PM Sinan Kaya wrote: > > > > On 11/15/2018 3:16 PM, Alexandru Gagniuc wrote: > > > I've asked around a few people at Dell and they unanimously agree that > > > _OSC is the correct way to determine ownershi

Re: [PATCH v2 2/2] PCI: pciehp: Add HXT quirk for Command Completed errata

2018-11-19 Thread Keith Busch
On Wed, Nov 07, 2018 at 03:25:05PM +0800, Shunyong Yang wrote: > The HXT SD4800 PCI controller does not set the Command Completed > bit unless writes to the Slot Command register change "Control" > bits. > > This patch adds SD4800 to the quirk. > > Cc: Joey Zheng > Signed-off-by: Shunyong Yang

Re: [PATCH 1/7] node: Link memory nodes to their compute nodes

2018-11-19 Thread Keith Busch
On Mon, Nov 19, 2018 at 08:45:25AM +0530, Anshuman Khandual wrote: > On 11/17/2018 12:02 AM, Keith Busch wrote: > > On Thu, Nov 15, 2018 at 12:36:54PM -0800, Matthew Wilcox wrote: > >> So ... let's imagine a hypothetical system (I've never seen one built like > &

Re: [PATCH 2/7] node: Add heterogenous memory performance

2018-11-19 Thread Keith Busch
On Mon, Nov 19, 2018 at 09:05:07AM +0530, Anshuman Khandual wrote: > On 11/15/2018 04:19 AM, Keith Busch wrote: > > Heterogeneous memory systems provide memory nodes with latency > > and bandwidth performance attributes that are different from other > > nodes. Create an interf

Re: Enable tracing only for one function and its children?

2018-11-16 Thread Keith Busch
On Fri, Nov 16, 2018 at 04:37:55PM -0600, Timur Tabi wrote: > Is there a way to enable ftrace tracing only for one specific function > and all the functions it calls? Then when the function returns, > disable tracing until the next time? > > When I pass the function name only to set_ftrace_filter

Re: [PATCH 1/7] node: Link memory nodes to their compute nodes

2018-11-16 Thread Keith Busch
On Thu, Nov 15, 2018 at 12:36:54PM -0800, Matthew Wilcox wrote: > On Thu, Nov 15, 2018 at 07:59:20AM -0700, Keith Busch wrote: > > On Thu, Nov 15, 2018 at 05:57:10AM -0800, Matthew Wilcox wrote: > > > On Wed, Nov 14, 2018 at 03:49:14PM -0700, Keith Busch wrote: > > > >

Re: [PATCH 0/7] ACPI HMAT memory sysfs representation

2018-11-16 Thread Keith Busch
On Fri, Nov 16, 2018 at 11:57:58AM +0530, Anshuman Khandual wrote: > On 11/15/2018 04:19 AM, Keith Busch wrote: > > This series provides a new sysfs representation for heterogeneous > > system memory. > > > > The previous series that was specific to HMAT that this serie

Re: [PATCH 1/7] node: Link memory nodes to their compute nodes

2018-11-15 Thread Keith Busch
On Thu, Nov 15, 2018 at 05:57:10AM -0800, Matthew Wilcox wrote: > On Wed, Nov 14, 2018 at 03:49:14PM -0700, Keith Busch wrote: > > Memory-only nodes will often have affinity to a compute node, and > > platforms have ways to express that locality relationship. > > > >

[PATCH 2/7] node: Add heterogenous memory performance

2018-11-14 Thread Keith Busch
ystem/node/nodeY/initiator_access /sys/devices/system/node/nodeY/initiator_access |-- read_bandwidth |-- read_latency |-- write_bandwidth `-- write_latency The bandwidth is exported as MB/s and latency is reported in nanoseconds. Signed-off-by: Keith Busch --- drivers/base/Kc

[PATCH 7/7] acpi/hmat: Parse and report heterogeneous memory

2018-11-14 Thread Keith Busch
memory numa nodes so they can be observed through sysfs. Signed-off-by: Keith Busch --- drivers/acpi/Kconfig | 9 ++ drivers/acpi/Makefile | 1 + drivers/acpi/hmat.c | 384 ++ drivers/acpi/tables.c | 10 ++ 4 files changed, 404 insertions

[PATCH 4/7] node: Add memory caching attributes

2018-11-14 Thread Keith Busch
ack policy. Signed-off-by: Keith Busch --- drivers/base/node.c | 117 +++ include/linux/node.h | 23 ++ 2 files changed, 140 insertions(+) diff --git a/drivers/base/node.c b/drivers/base/node.c index 232535761998..bb94f1d18115 100644 --- a/dr

[PATCH 1/7] node: Link memory nodes to their compute nodes

2018-11-14 Thread Keith Busch
#x27;Y' local to commpute node 'X': # ls -l /sys/devices/system/node/nodeX/initiator* /sys/devices/system/node/nodeX/targetY -> ../nodeY # ls -l /sys/devices/system/node/nodeY/target* /sys/devices/system/node/nodeY/initiatorX -> ../nodeX Signed-off-b

[PATCH 3/7] doc/vm: New documentation for memory performance

2018-11-14 Thread Keith Busch
attributes the kernel makes available to aid applications wishing to query this information. Signed-off-by: Keith Busch --- Documentation/vm/numaperf.rst | 71 +++ 1 file changed, 71 insertions(+) create mode 100644 Documentation/vm/numaperf.rst diff --git a

[PATCH 5/7] doc/vm: New documentation for memory cache

2018-11-14 Thread Keith Busch
attributes for application optimization. Signed-off-by: Keith Busch --- Documentation/vm/numacache.rst | 76 ++ 1 file changed, 76 insertions(+) create mode 100644 Documentation/vm/numacache.rst diff --git a/Documentation/vm/numacache.rst b/Documentation/vm

[PATCH 6/7] acpi: Create subtable parsing infrastructure

2018-11-14 Thread Keith Busch
parsing the entries array may be more reused for all ACPI system tables. Signed-off-by: Keith Busch --- drivers/acpi/tables.c | 75 --- 1 file changed, 65 insertions(+), 10 deletions(-) diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c index

[PATCH 0/7] ACPI HMAT memory sysfs representation

2018-11-14 Thread Keith Busch
xport characteristics about the memory nodes. Documentation desribing the new representation are provided. Finally the series adds a kernel user for these new APIs from parsing the ACPI HMAT. Keith Busch (7): node: Link memory nodes to their compute nodes node: Add heterogenous memory perfor

Re: [PATCH v2 1/6] mm/gup: finish consolidating error handling

2018-11-12 Thread Keith Busch
ost of this has been > taken care of by commit df06b37ffe5a4 ("mm/gup: cache dev_pagemap while > pinning pages"), but there was one case remaining. > > Also, there was still an unnecessary shadow declaration (with a > different type) of the "ret" variable, whi

Re: [PATCH v2] PCI/MSI: Don't touch MSI bits when the PCI device is disconnected

2018-11-09 Thread Keith Busch
On Fri, Nov 09, 2018 at 03:32:57AM -0800, Greg Kroah-Hartman wrote: > On Fri, Nov 09, 2018 at 08:29:53AM +0100, Lukas Wunner wrote: > > On Thu, Nov 08, 2018 at 02:01:17PM -0800, Greg Kroah-Hartman wrote: > > > On Thu, Nov 08, 2018 at 02:09:17PM -0600, Bjorn Helgaas wrote: > > > > I'm having second

Re: [PATCH v2] PCI/MSI: Don't touch MSI bits when the PCI device is disconnected

2018-11-08 Thread Keith Busch
On Thu, Nov 08, 2018 at 02:42:55PM -0800, Greg Kroah-Hartman wrote: > On Thu, Nov 08, 2018 at 03:32:58PM -0700, Keith Busch wrote: > > On Thu, Nov 08, 2018 at 02:01:17PM -0800, Greg Kroah-Hartman wrote: > > > On Thu, Nov 08, 2018 at 02:09:17PM -0600, Bjorn Helgaas wrote: > &g

Re: [PATCH v2] PCI/MSI: Don't touch MSI bits when the PCI device is disconnected

2018-11-08 Thread Keith Busch
On Thu, Nov 08, 2018 at 02:01:17PM -0800, Greg Kroah-Hartman wrote: > On Thu, Nov 08, 2018 at 02:09:17PM -0600, Bjorn Helgaas wrote: > > I'm having second thoughts about this. One thing I'm uncomfortable > > with is that sprinkling pci_dev_is_disconnected() around feels ad hoc > > instead of syste

Re: [PATCH 00/12] error handling and pciehp maintenance

2018-11-06 Thread Keith Busch
On Tue, Nov 06, 2018 at 05:21:00PM +, Lorenzo Pieralisi wrote: > If you have a simple reproducer for the bugs I am happy to help you test > it (I can also apply arm64 DYNAMIC_FTRACE_WITH_REGS patches and test that > new code path if that's the final direction we are taking). The easiest way to

Re: [PATCH 00/12] error handling and pciehp maintenance

2018-11-06 Thread Keith Busch
On Tue, Nov 06, 2018 at 04:34:08PM +, Lorenzo Pieralisi wrote: > The question is whether we really need to dynamically patch the kernel > with ftrace to achieve what that patch does. > > Furthermore, it would also be good to report what bugs we are actually > fixing, from what you are writing

Re: [PATCH 1/3] PCI/AER: Option to leave System Error Interrupts as-is

2018-11-02 Thread Keith Busch
On Fri, Nov 02, 2018 at 05:26:23PM +0100, Borislav Petkov wrote: > On Fri, Nov 02, 2018 at 10:17:30AM -0600, Keith Busch wrote: > > VMD acts a bit like a host-bus adapter. The firmware knows about the > > adapter, but not about anything on the bus that it attaches to. > &

Re: [PATCH 1/3] PCI/AER: Option to leave System Error Interrupts as-is

2018-11-02 Thread Keith Busch
On Fri, Nov 02, 2018 at 10:53:00AM +0100, Borislav Petkov wrote: > On Mon, Oct 29, 2018 at 04:06:51PM -0500, Bjorn Helgaas wrote: > > If I squint hard enough this sort of makes sense, but it also makes me > > confused about the normal APEI firmware-first model works. > > > > In the NON-firmare-fir

Re: [PATCH 11/14] irq: add support for allocating (and affinitizing) sets of IRQs

2018-10-30 Thread Keith Busch
On Tue, Oct 30, 2018 at 08:53:37AM -0600, Jens Axboe wrote: > The sum of the set can't exceed the nvecs passed in, the nvecs passed in > should be the less than or equal to nvecs. Granted this isn't enforced, > and perhaps that should be the case. That should at least initially be true for a prope

Re: [PATCH v4] PCI/AER: Enable error reporting for all ports

2018-10-19 Thread Keith Busch
On Thu, Oct 18, 2018 at 08:11:35PM -0500, Bjorn Helgaas wrote: > On Thu, Oct 18, 2018 at 05:03:13PM -0600, Keith Busch wrote: > > On Thu, Oct 18, 2018 at 03:53:58PM -0500, Bjorn Helgaas wrote: > > > Change the AER service driver so it binds to *all* PCIe Ports, > > > in

Re: [PATCH v4] PCI/AER: Enable error reporting for all ports

2018-10-18 Thread Keith Busch
On Thu, Oct 18, 2018 at 03:53:58PM -0500, Bjorn Helgaas wrote: > Change the AER service driver so it binds to *all* PCIe Ports, including > Switch Upstream and Downstream Ports. Enable AER error reporting for all > these Ports, but not for any children. I'm looking at this again and think enablin

[PATCHv3] mm/gup: Cache dev_pagemap while pinning pages

2018-10-12 Thread Keith Busch
operation when dev_pagemap is used by caching the last dev_pagemap while getting user pages. The gup_benchmark kernel self test reports this reduces time to get user pages to as low as 1/3 of the previous time. Cc: Dave Hansen Reviewed-by: Dan Williams Acked-by: Kirill A. Shutemov Signed-off-by: K

Re: [PATCHv2] mm/gup: Cache dev_pagemap while pinning pages

2018-10-12 Thread Keith Busch
On Fri, Oct 12, 2018 at 09:58:18AM -0700, Dan Williams wrote: > On Fri, Oct 12, 2018 at 4:00 AM Kirill A. Shutemov > wrote: > [..] > > > Does this have defined behavior? I would feel better with " = { 0 }" > > > to be explicit. > > > > Well, it's not allowed by the standart, but GCC allows this.

[PATCHv2] mm/gup: Cache dev_pagemap while pinning pages

2018-10-11 Thread Keith Busch
operation when dev_pagemap is used by caching the last dev_pagemap while getting user pages. The gup_benchmark kernel self test reports this reduces time to get user pages to as low as 1/3 of the previous time. Cc: Kirill Shutemov Cc: Dave Hansen Cc: Dan Williams Signed-off-by: Keith Busch --- Ch

Re: [PATCH v3] PCI/AER: Enable reporting for ports enumerated after AER driver registration

2018-10-11 Thread Keith Busch
On Thu, Oct 11, 2018 at 08:26:18AM -0700, Bjorn Helgaas wrote: > From: Bjorn Helgaas > > Previously we enabled AER error reporting only for Switch Ports that were > enumerated prior to registering the AER service driver. Switch Ports > enumerated after AER driver registration were left with erro

<    1   2   3   4   5   6   7   8   9   10   >