Re: [PATCH] [v4] ieee802154: ca8210: Fix a potential UAF in ca8210_probe

ister_ext_clock(). v4: -Remove an unused variable 'ret'. This patch has been applied to the wpan tree and will be part of the next pull request to net. Thanks! regards Stefan Schmidt

Re: [PATCH] [v3] ieee802154: ca8210: Fix a potential UAF in ca8210_probe

riable 'ret' [-Wunused-variable] 2743 | int ret = 0; | ^~~ Please take care of this now unused variable after your re-factor. With this fixed and send out as v4 I am happy to get this applied to the wpan tree. regards Stefan Schmidt

Re: [PATCH] [v2] ieee802154: ca8210: Fix a potential UAF in ca8210_probe

t ca8210_priv *priv = spi_get_drvdata(spi); - if (!priv->clk) + if (IS_ERR_OR_NULL(priv->clk)) return of_clk_del_provider(spi->dev.of_node); Alex, Stefan, who handles wpan and wpan/next this release? IIRC it would be me for wpan and Alex for wpan-next. regards Stefan Schmidt

Re: [PATCH v2] net: mac802154: Fix general protection fault

here. This patch has been applied to the wpan tree and will be part of the next pull request to net. Thanks! regards Stefan Schmidt

Re: [PATCH v2] net: mac802154: Fix general protection fault

ey->tfm[i]) + if (!IS_ERR_OR_NULL(key->tfm[i])) crypto_free_aead(key->tfm[i]); kfree_sensitive(key); Alex, are you happy with this patch now? I would like to get it applied. Waiting for your review or ack given you had comments on the first version. regards Stefan Schmidt

Re: UBSAN: shift-out-of-bounds in nl802154_new_interface

at these? Yes, I have it on my list. I will try to fix them at the weekend. Great, thank you! Thanks for handling these. Your first batch is reviewed and applied. I will wait for the next round before I send a pull request to net. regards Stefan Schmidt

Re: [PATCH] net/ieee802154: remove unused macros to tame gcc

Hello. On 06.11.20 09:10, Alex Shi wrote: Signed-off-by: Alex Shi Cc: Alexander Aring Cc: Stefan Schmidt Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-w...@vger.kernel.org Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- net/ieee802154/nl802154.c | 4 ---

Re: [PATCH v5 25/52] docs: net: ieee802154.rst: fix C expressions

o Carvalho Chehab --- Documentation/networking/ieee802154.rst | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) Acked-by: Stefan Schmidt regards Stefan Schmidt

Re: [PATCH v5 25/52] docs: net: ieee802154.rst: fix C expressions

On 06.10.20 16:03, Mauro Carvalho Chehab wrote: There are some warnings produced with Sphinx 3.x: Documentation/networking/ieee802154.rst:29: WARNING: Error in declarator or parameters Invalid C declaration: Expecting "(" in parameters. [error at 7] int sd =

Re: [PATCH 4/8] net: mac802154: convert tasklets to use new tasklet_setup() API

); - tasklet_init(>tasklet, -ieee802154_tasklet_handler, -(unsigned long)local); + tasklet_setup(>tasklet, ieee802154_tasklet_handler); skb_queue_head_init(>skb_queue); Acked-by: Stefan Schmidt regards Stefan Schmidt

Re: [PATCH] ieee802154/adf7242: check status of adf7242_read_reg

lp, 0, _u8); + ret = adf7242_read_reg(lp, 0, _u8); + if (ret) + return ret; len = len_u8; This patch has been applied to the wpan tree and will be part of the next pull request to net. Thanks! regards Stefan Schmidt

Re: [PATCH 24/24] net: pass a sockptr_t into ->setsockopt

m_setsockopt(struct sock *sk, int level, int optname, if (optlen < sizeof(int)) return -EINVAL; - if (get_user(val, (int __user *)optval)) + if (copy_from_sockptr(, optval, sizeof(int))) return -EFAULT; For the ieee802154 part: Acked-by: Stefan Schmidt regards Stefan Schmidt

Re: [PATCH for v5.9] net: ieee802154: adf7242: Replace HTTP links with HTTPS ones

://www.analog.com/ADF7242 */ #include This patch has been applied to the wpan tree and will be part of the next pull request to net. Thanks! regards Stefan Schmidt

Re: [PATCH 05/22] net: remove compat_sock_common_{get,set}sockopt

sock_common_setsockopt, - .compat_getsockopt = compat_sock_common_getsockopt, -#endif For the ieee802154 part: Acked-by: Stefan Schmidt regards Stefan Schmidt

Re: [PATCH] ieee802154: ca8210: prevent memory leak

of the next pull request to net. Thanks! regards Stefan Schmidt

Re: [PATCH] ieee802154: mcr20a: simplify a bit 'mcr20a_handle_rx_read_buf_complete()'

Hello. On 24.09.19 23:40, Xue Liu wrote: On Sat, 21 Sep 2019 at 13:52, Stefan Schmidt wrote: Hello Xue. On 20.09.19 21:45, Christophe JAILLET wrote: Use a 'skb_put_data()' variant instead of rewritting it. The __skb_put_data variant is safe here. It is obvious that the skb can not overflow

Re: [PATCH] ieee802154: mcr20a: simplify a bit 'mcr20a_handle_rx_read_buf_complete()'

buf, len); > ieee802154_rx_irqsafe(lp->hw, skb, lp->rx_lqi[0]); > > print_hex_dump_debug("mcr20a rx: ", DUMP_PREFIX_OFFSET, 16, 1, > Could you please review and ACK this? If you are happy I will take it through my tree. regards Stefan Schmidt

Re: [PATCH] ieee802154: ca8210: prevent memory leak

spi, pdata); > if (ret) { > dev_crit(_device->dev, "ca8210_get_platform_data failed\n"); > goto error; > } > - priv->spi->dev.platform_data = pdata; > > ret = ca8210_dev_com_init(priv); > if (ret) { > Could you review this patch for the ca8210 driver? regards Stefan Schmidt

Re: [PATCH] ieee802154: atusb: fix use-after-free at disconnect

done\n", __func__); > } > This patch has been applied to the wpan tree and will be part of the next pull request to net. Thanks a lot for having a look at this! regards Stefan Schmidt

Re: [PATCH] net: ieee802154: remove redundant assignment to rc

een applied to the wpan tree and will be part of the next pull request to net. Thanks! regards Stefan Schmidt

Re: [PATCH] ieee802154: mcr20a: fix indentation, remove tabs

t; This patch has been applied to the wpan tree and will be part of the next pull request to net. Thanks! regards Stefan Schmidt

Re: [PATCH net-next] ieee802154: ca8210: fix possible u8 overflow in ca8210_rx_done

"Received packet len (%u) erroneously long\n", > len > ); > goto finish; > This patch has been applied to the wpan tree and will be part of the next pull request to net. Thanks! regards Stefan Schmidt

Re: [PATCH net-next] ieee802154: ca8210: fix possible u8 overflow in ca8210_rx_done

apply it. I will take this one directly now and do some smoke testing. It will come together with another fix as pull request to you. regards Stefan Schmidt

Re: [PATCH] ieee802154: ca8210: remove redundant condition check before debugfs_remove

info(>spi->dev, "Test interface removed\n"); > } > This patch has been applied to the wpan tree and will be part of the next pull request to net. Thanks! regards Stefan Schmidt

Re: [PATCH] ieee802154: ca8210: remove redundant condition check before debugfs_remove

info(>spi->dev, "Test interface removed\n"); > } > This patch has been applied to the wpan tree and will be part of the next pull request to net. Thanks! regards Stefan Schmidt

Re: [PATCH] ieee802154: remove a redundant local variable 'i'

\ > Sorry, but this patch is wrong. The variable i is used in line 513 inside the CMD() macro. The compiler clearly tells this when running with your patch: net/ieee802154/nl802154.c: In function ‘nl802154_send_wpan_phy’: net/ieee802154/nl802154.c:513:4: error: ‘i’ undeclared (first use in this

Re: [PATCH] ieee802154: remove a redundant local variable 'i'

\ > Sorry, but this patch is wrong. The variable i is used in line 513 inside the CMD() macro. The compiler clearly tells this when running with your patch: net/ieee802154/nl802154.c: In function ‘nl802154_send_wpan_phy’: net/ieee802154/nl802154.c:513:4: error: ‘i’ undeclared (first use in this

Re: [PATCH net-next] ieee802154: Use kmemdup instead of duplicating it in ca8210_test_int_driver_write

> kfifo_in(>up_fifo, _buffer, 4); > wake_up_interruptible(>test.readq); > This patch has been applied to the wpan tree and will be part of the next pull request to net. Thanks! regards Stefan Schmidt

Re: [PATCH net-next] ieee802154: Use kmemdup instead of duplicating it in ca8210_test_int_driver_write

> kfifo_in(>up_fifo, _buffer, 4); > wake_up_interruptible(>test.readq); > This patch has been applied to the wpan tree and will be part of the next pull request to net. Thanks! regards Stefan Schmidt

Re: [PATCH] net: ieee802154: atusb: Replace GFP_ATOMIC with GFP_KERNEL in atusb_probe

usb_alloc_urb(0, GFP_ATOMIC); > + atusb->tx_urb = usb_alloc_urb(0, GFP_KERNEL); > if (!atusb->tx_urb) > goto fail; > This patch has been applied to the wpan tree and will be part of the next pull request to net. Thanks! regards Stefan Schmidt

Re: [PATCH] net: ieee802154: atusb: Replace GFP_ATOMIC with GFP_KERNEL in atusb_probe

(0, GFP_ATOMIC); > + atusb->tx_urb = usb_alloc_urb(0, GFP_KERNEL); > if (!atusb->tx_urb) > goto fail; > This patch has been applied to the wpan tree and will be part of the next pull request to net. Thanks! regards Stefan Schmidt

Re: [PATCH] ieee802154: mcr20a: Fix memory leak in mcr20a_probe

it mcr20a local data */ > @@ -1366,6 +1367,8 @@ mcr20a_probe(struct spi_device *spi) > > free_dev: > ieee802154_free_hw(lp->hw); > +free_pdata: > + kfree(pdata); > > return ret; > } This patch has been applied to the wpan tree and will be part of the next pull request to net. Thanks! regards Stefan Schmidt

Re: [PATCH] ieee802154: mcr20a: Fix memory leak in mcr20a_probe

1366,6 +1367,8 @@ mcr20a_probe(struct spi_device *spi) > > free_dev: > ieee802154_free_hw(lp->hw); > +free_pdata: > + kfree(pdata); > > return ret; > } This patch has been applied to the wpan tree and will be part of the next pull request to net. Thanks! regards Stefan Schmidt

Re: [PATCH] ieee802154: mcr20a: Fix memory leak in mcr20a_probe

o picks the ACK up and adds it to the patch before I apply it from there. No worries, I did this manually for you this time. For the next time please use the correct format to have this tracked. regards Stefan Schmidt

Re: [PATCH] ieee802154: mcr20a: Fix memory leak in mcr20a_probe

apply it from there. No worries, I did this manually for you this time. For the next time please use the correct format to have this tracked. regards Stefan Schmidt

Re: [PATCH][next] ieee802154: remove unused variable 'val'

g |= (IAR_RX_FRAME_FLT_ACK_FT | > IAR_RX_FRAME_FLT_NS_FT); This patch has been applied to the wpan-next tree and will be part of the next pull request to net-next. Thanks! regards Stefan Schmidt

Re: [PATCH][next] ieee802154: remove unused variable 'val'

IAR_RX_FRAME_FLT_NS_FT); This patch has been applied to the wpan-next tree and will be part of the next pull request to net-next. Thanks! regards Stefan Schmidt

Re: [PATCH] ieee802154: mrf24j40: fix incorrect mask in mrf24j40_stop

_hw *hw, u8 page, u8 > channel) > This patch has been applied to the wpan-next tree and will be part of the next pull request to net-next. Thanks! regards Stefan Schmidt

Re: [PATCH] ieee802154: mrf24j40: fix incorrect mask in mrf24j40_stop

been applied to the wpan-next tree and will be part of the next pull request to net-next. Thanks! regards Stefan Schmidt

Re: [PATCH] ieee802154: mrf24j40: fix incorrect mask in mrf24j40_stop

02154_hw *hw, u8 page, u8 > channel) > Could you review this and give me your ack when you are happy so I can apply it to my tree? regards Stefan Schmidt

Re: [PATCH] ieee802154: mrf24j40: fix incorrect mask in mrf24j40_stop

t;regmap_short, REG_INTCON, > -BIT_TXNIE | BIT_TXNIE, BIT_TXNIE | BIT_TXNIE); > +BIT_TXNIE | BIT_RXIE, BIT_TXNIE | BIT_RXIE); > } > > static int mrf24j40_set_channel(struct ieee802154_hw *hw, u8 page, u8 > channel) > Could you r

Re: linux-4.14-rc3/drivers/net/ieee802154/atusb.c:827: pointless test ?

the compiler warnign out a while ago and I actually did a fix that works for it already. https://git.kernel.org/pub/scm/linux/kernel/git/sschmidt/wpan-next.git/commit/?id=763556980dde78166886734ae470664c67067dd4 Its waiting for getting pulled into net-next right now. regards Stefan Schmidt

Re: linux-4.14-rc3/drivers/net/ieee802154/atusb.c:827: pointless test ?

the compiler warnign out a while ago and I actually did a fix that works for it already. https://git.kernel.org/pub/scm/linux/kernel/git/sschmidt/wpan-next.git/commit/?id=763556980dde78166886734ae470664c67067dd4 Its waiting for getting pulled into net-next right now. regards Stefan Schmidt

Re: [PATCH] inet: frags: Convert timers to use timer_setup()

..@gmail.com> > Cc: Stefan Schmidt <ste...@osg.samsung.com> > Cc: "David S. Miller" <da...@davemloft.net> > Cc: Alexey Kuznetsov <kuz...@ms2.inr.ac.ru> > Cc: Hideaki YOSHIFUJI <yoshf...@linux-ipv6.org> > Cc: Pablo Neira Ayuso <pa...@netfilter.org&

Re: [PATCH] inet: frags: Convert timers to use timer_setup()

Hello. On 05.10.2017 02:52, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Alexander Aring > Cc: St

Re: [PATCH][next] ieee802154: atusb: make two structures static, fixes warnings

= -100, > .set_txpower = hulusb_set_txpower, > This patch has been applied to the wpan-next tree and will be part of the next pull request to net-next. Thanks! regards Stefan Schmidt

Re: [PATCH][next] ieee802154: atusb: make two structures static, fixes warnings

atusb_set_txpower, > .set_channel = atusb_set_channel, > }; > > -struct atusb_chip_data hulusb_chip_data = { > +static struct atusb_chip_data hulusb_chip_data = { > .t_channel_switch = 11, > .rssi_base_val = -100, > .set_txpower = hulusb_set_txpower, > This patch has been applied to the wpan-next tree and will be part of the next pull request to net-next. Thanks! regards Stefan Schmidt

Re: [PATCH] ieee802154: fix gcc-4.9 warnings

t ieee802154_hdr header = { 0 }; + struct ieee802154_hdr header = { }; struct secspec secspec; unsigned int mac_len; Acked-by: Stefan Schmidt <ste...@osg.samsung.com> regards Stefan Schmidt

Re: [PATCH] ieee802154: fix gcc-4.9 warnings

ader = { 0 }; + struct ieee802154_hdr header = { }; struct secspec secspec; unsigned int mac_len; Acked-by: Stefan Schmidt regards Stefan Schmidt

Re: [PATCH 3/7] ieee802154: 6lowpan: make header_ops const

struct header_ops lowpan_header_ops = { .create = lowpan_header_create, }; Acked-by: Stefan Schmidt <ste...@osg.samsung.com> regards Stefan Schmidt

Re: [PATCH 3/7] ieee802154: 6lowpan: make header_ops const

= { .create = lowpan_header_create, }; Acked-by: Stefan Schmidt regards Stefan Schmidt

Re: [PATCH] net: ieee802154: fix net_device reference release too early

Hello. On Thu, 2017-05-18 at 15:14, Stefan Schmidt wrote: > Hello. > > On Thu, 2017-05-18 at 15:50, linzhang wrote: > > This patch fixes the kernel oops when release net_device reference in > > advance. In function raw_sendmsg(i think the dgram_sendmsg has

Re: [PATCH] net: ieee802154: fix net_device reference release too early

Hello. On Thu, 2017-05-18 at 15:14, Stefan Schmidt wrote: > Hello. > > On Thu, 2017-05-18 at 15:50, linzhang wrote: > > This patch fixes the kernel oops when release net_device reference in > > advance. In function raw_sendmsg(i think the dgram_sendmsg has

Re: [PATCH] net: ieee802154: fix net_device reference release too early

goto out_skb; > > skb->dev = dev; > - skb->sk = sk; > skb->protocol = htons(ETH_P_IEEE802154); > > - dev_put(dev); > - > err = dev_queue_xmit(skb); > if (err > 0) > err = net_xmit_errno(err); > > + dev_put(dev); > + > return err ?: size; Going to give this a test ride here now. regards Stefan Schmidt

Re: [PATCH] net: ieee802154: fix net_device reference release too early

; > skb->dev = dev; > - skb->sk = sk; > skb->protocol = htons(ETH_P_IEEE802154); > > - dev_put(dev); > - > err = dev_queue_xmit(skb); > if (err > 0) > err = net_xmit_errno(err); > > + dev_put(dev); > + > return err ?: size; Going to give this a test ride here now. regards Stefan Schmidt

Re: [PATCH] Add checks for kmalloc allocation failures

s/net/ieee802154/ca8210.c ls: cannot access drivers/net/ieee802154/ca8210.c: No such file or directory This new driver is sitting in bluetooth-next right now for the next merge. regards Stefan Schmidt

Re: [PATCH] Add checks for kmalloc allocation failures

ls: cannot access drivers/net/ieee802154/ca8210.c: No such file or directory This new driver is sitting in bluetooth-next right now for the next merge. regards Stefan Schmidt

Re: [ieee802154_unregister_hw] bea5b158ff BUG: scheduling while atomic: swapper/1/0x00000002

can you do that please? The latest stable kernel is 4.10.1 and the latest longterm stable is 4.9.13. Both of them should have this fix already. If there is a desire I could try sending it for the older longterm stable tree 4.4.x. Not sure if this is really worth the effort. Comments? regards Stefan Schmidt

Re: [ieee802154_unregister_hw] bea5b158ff BUG: scheduling while atomic: swapper/1/0x00000002

can you do that please? The latest stable kernel is 4.10.1 and the latest longterm stable is 4.9.13. Both of them should have this fix already. If there is a desire I could try sending it for the older longterm stable tree 4.4.x. Not sure if this is really worth the effort. Comments? regards Stefan Schmidt

Re: [PATCH] at86rf230: Allow slow GPIO pins for "rstn"

Hello. On 21/12/16 19:30, Chris Healy wrote: On Dec 21, 2016 5:11 AM, "Stefan Schmidt" <ste...@osg.samsung.com <mailto:ste...@osg.samsung.com>> wrote: Hello. On 19/12/16 00:25, Andrey Smirnov wrote: Driver code never touches "rstn&qu

Re: [PATCH] at86rf230: Allow slow GPIO pins for "rstn"

Hello. On 21/12/16 19:30, Chris Healy wrote: On Dec 21, 2016 5:11 AM, "Stefan Schmidt" mailto:ste...@osg.samsung.com>> wrote: Hello. On 19/12/16 00:25, Andrey Smirnov wrote: Driver code never touches "rstn" signal in atomic context, so

Re: [PATCH] at86rf230: Allow slow GPIO pins for "rstn"

stn)) { udelay(1); - gpio_set_value(rstn, 0); + gpio_set_value_cansleep(rstn, 0); udelay(1); - gpio_set_value(rstn, 1); + gpio_set_value_cansleep(rstn, 1); usleep_range(120, 240); } Acked-by: Stefan

Re: [PATCH] at86rf230: Allow slow GPIO pins for "rstn"

io_set_value(rstn, 0); + gpio_set_value_cansleep(rstn, 0); udelay(1); - gpio_set_value(rstn, 1); + gpio_set_value_cansleep(rstn, 1); usleep_range(120, 240); } Acked-by: Stefan Schmidt regards Stefan Schmidt

Re: [PATCH 5/8] linux: drop __bitwise__ everywhere

def unsigned __bitwise ieee80211_rx_result; #define RX_CONTINUE((__force ieee80211_rx_result) 0u) #define RX_DROP_UNUSABLE ((__force ieee80211_rx_result) 1u) #define RX_DROP_MONITOR((__force ieee80211_rx_result) 2u) For net/ieee802154/6lowpan/6lowpan_i.h Ac

Re: [PATCH 5/8] linux: drop __bitwise__ everywhere

signed __bitwise ieee80211_rx_result; #define RX_CONTINUE((__force ieee80211_rx_result) 0u) #define RX_DROP_UNUSABLE ((__force ieee80211_rx_result) 1u) #define RX_DROP_MONITOR((__force ieee80211_rx_result) 2u) For net/ieee802154/6lowpan/6lowpan_i.h Acked-by: Stefan Schmidt

Re: [PATCH 1/1] Fixed to BUG_ON to WARN_ON def

ggestions and docs I would think people will keep ignoring your patches. regards Stefan Schmidt

Re: [PATCH 1/1] Fixed to BUG_ON to WARN_ON def

nk people will keep ignoring your patches. regards Stefan Schmidt

Re: [PATCH] Fixed to checkpatch.pl errors to vlan_dev.c

iv(dev); struct netpoll *netpoll = vlan->netpoll; if (!netpoll) regards Stefan Schmidt

Re: [PATCH] Fixed to checkpatch.pl errors to vlan_dev.c

= vlan->netpoll; if (!netpoll) regards Stefan Schmidt

Re: [PATCH] ARM: pxa: ezx: fix a910 camera data

Hello. On 03.12.2016 17:55, Antonio Ospite wrote: > On Sat, 26 Nov 2016 00:30:52 +0100 > Stefan Schmidt <ste...@datenfreihafen.org> wrote: > >> Hello. >> > > Hi everyone, > >> On 25.11.2016 20:53, Robert Jarzmik wrote: >>> Stefan Schmidt

Re: [PATCH] ARM: pxa: ezx: fix a910 camera data

Hello. On 03.12.2016 17:55, Antonio Ospite wrote: > On Sat, 26 Nov 2016 00:30:52 +0100 > Stefan Schmidt wrote: > >> Hello. >> > > Hi everyone, > >> On 25.11.2016 20:53, Robert Jarzmik wrote: >>> Stefan Schmidt writes: >>> >>

Re: [PATCH] ARM: pxa: ezx: fix a910 camera data

Hello. On 25.11.2016 20:53, Robert Jarzmik wrote: > Stefan Schmidt <ste...@datenfreihafen.org> writes: > >> Hello. >> >> On 24.11.2016 17:29, Arnd Bergmann wrote: >>> The camera_supply_dummy_device definition is shared between a780 and a910, >>

Re: [PATCH] ARM: pxa: ezx: fix a910 camera data

Hello. On 25.11.2016 20:53, Robert Jarzmik wrote: > Stefan Schmidt writes: > >> Hello. >> >> On 24.11.2016 17:29, Arnd Bergmann wrote: >>> The camera_supply_dummy_device definition is shared between a780 and a910, >>> but only provided wh

Re: [PATCH] ARM: pxa: ezx: fix a910 camera data

think. Daniel, Harald, if one of you is still interested in these and what to pick up the work again, please speak up now. :) regards Stefan Schmidt

Re: [PATCH] ARM: pxa: ezx: fix a910 camera data

if one of you is still interested in these and what to pick up the work again, please speak up now. :) regards Stefan Schmidt

Re: [PATCH] net: ieee802154: drop duplicate header delay.h

802154/adf7242.c index 4ff4c7d..3e4c8b2 100644 --- a/drivers/net/ieee802154/adf7242.c +++ b/drivers/net/ieee802154/adf7242.c @@ -20,7 +20,6 @@ #include #include #include -#include #include #include #include Good catch. Acked-by: Stefan Schmidt <ste...@osg.samsung.com> regards Stefan Schmidt

Re: [PATCH] net: ieee802154: drop duplicate header delay.h

..3e4c8b2 100644 --- a/drivers/net/ieee802154/adf7242.c +++ b/drivers/net/ieee802154/adf7242.c @@ -20,7 +20,6 @@ #include #include #include -#include #include #include #include Good catch. Acked-by: Stefan Schmidt regards Stefan Schmidt

Re: [PATCH] net: ieee802154: constify ieee802154_ops structures

Acked-by: Stefan Schmidt <ste...@osg.samsung.com> regards Stefan Schmidt

Re: [PATCH] net: ieee802154: constify ieee802154_ops structures

ieee802154_hw *hw) return 0; } -static struct ieee802154_ops atusb_ops = { +static const struct ieee802154_ops atusb_ops = { .owner = THIS_MODULE, .xmit_async = atusb_xmit, .ed = atusb_ed, Acked-by: Stefan Schmidt

Re: [PATCH 17/26] mac802154: Use skcipher

,7 @@ struct mac802154_llsec_key { /* one tfm for each authsize (4/8/16) */ struct crypto_aead *tfm[3]; - struct crypto_blkcipher *tfm0; + struct crypto_skcipher *tfm0; struct kref ref; }; Reviewed-by: Stefan Schmidt regards Stefan Schmidt

Re: [PATCH 17/26] mac802154: Use skcipher

#include @@ -30,7 +29,7 @@ struct mac802154_llsec_key { /* one tfm for each authsize (4/8/16) */ struct crypto_aead *tfm[3]; - struct crypto_blkcipher *tfm0; + struct crypto_skcipher *tfm0; struct kref ref; }; Reviewed-by: Stefan Schmidt <ste...@osg.samsung.com> regards Stefan Schmidt

Re: ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb"

l one. I have send it a second time now and it worked fine. The patch is already applied to the bluetooth-next tree and thus on its way. All good now. https://git.kernel.org/cgit/linux/kernel/git/bluetooth/bluetooth-next.git/commit/?id=4188146566a9f1d57dfce77fd9457f7304b69dfa re

Re: ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb"

l one. I have send it a second time now and it worked fine. The patch is already applied to the bluetooth-next tree and thus on its way. All good now. https://git.kernel.org/cgit/linux/kernel/git/bluetooth/bluetooth-next.git/commit/?id=4188146566a9f1d57dfce77fd9457f7304b69dfa re

Re: [PATCH] ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb"

->context); usb_free_urb(urb); } } Acked-by: Stefan Schmidt You got the original patch and my ACK on this one or would you prefer me to resend it again? this slipped through, but now it does no longer apply. Applying: ieee802154-atusb: Delete an unnecessary check before the function call "

Re: [PATCH] ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb"

Marcel, On 17/11/15 17:18, Stefan Schmidt wrote: Hello. On 17/11/15 17:17, Stefan Schmidt wrote: From: Markus Elfring Date: Mon, 16 Nov 2015 13:50:23 +0100 The kfree_skb() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed

Re: [PATCH] ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb"

kfree_skb(urb->context); +kfree_skb(urb->context); usb_free_urb(urb); } } Acked-by: Stefan Schmidt <ste...@osg.samsung.com> You got the original patch and my ACK on this one or would you prefer me to resend it again? this slipped through, but now it d

Re: [PATCH] ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb"

Marcel, On 17/11/15 17:18, Stefan Schmidt wrote: Hello. On 17/11/15 17:17, Stefan Schmidt wrote: From: Markus Elfring <elfr...@users.sourceforge.net> Date: Mon, 16 Nov 2015 13:50:23 +0100 The kfree_skb() function tests whether its argument is NULL and then returns immediately. Thus th

Re: [PATCH] ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb"

->context); usb_free_urb(urb); } } Acked-by: Stefan Schmidt for some reason I am missing the original patch, can someone resend it please. Done. Resend the original message from my address but with the From line intact inside the patch. Please check if it really lists Markus as author w

[PATCH] ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb"

From: Markus Elfring Date: Mon, 16 Nov 2015 13:50:23 +0100 The kfree_skb() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

Re: [PATCH] ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb"

Hello. On 17/11/15 17:17, Stefan Schmidt wrote: From: Markus Elfring Date: Mon, 16 Nov 2015 13:50:23 +0100 The kfree_skb() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle

Re: [PATCH] ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb"

Hello. On 17/11/15 17:17, Stefan Schmidt wrote: From: Markus Elfring <elfr...@users.sourceforge.net> Date: Mon, 16 Nov 2015 13:50:23 +0100 The kfree_skb() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This

[PATCH] ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb"

From: Markus Elfring Date: Mon, 16 Nov 2015 13:50:23 +0100 The kfree_skb() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software.

Re: [PATCH] ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb"

kfree_skb(urb->context); usb_free_urb(urb); } } Acked-by: Stefan Schmidt <ste...@osg.samsung.com> for some reason I am missing the original patch, can someone resend it please. Done. Resend the original message from my address but with the From line intact inside

Re: [PATCH] ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb"

t;context); + kfree_skb(urb->context); usb_free_urb(urb); } } Acked-by: Stefan Schmidt regards Stefan Schmidt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH] ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb"

f (urb->context) - kfree_skb(urb->context); + kfree_skb(urb->context); usb_free_urb(urb); } } Acked-by: Stefan Schmidt <ste...@osg.samsung.com> regards Stefan Schmidt -- To unsubscribe from this list: send the line "un

Re: [PATCH] mac802154: select CRYPTO when needed

CCM Good point. I thought that would have been pulled in by CRYPTO_* automatically. Nicely spotted. Reviewed-by: Stefan Schmidt regards Stefan Schmidt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org

Re: [PATCH] mac802154: select CRYPTO when needed

CRYPTO_CCM Good point. I thought that would have been pulled in by CRYPTO_* automatically. Nicely spotted. Reviewed-by: Stefan Schmidt ste...@osg.samsung.com regards Stefan Schmidt -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [ANNOUNCE] d80211 based driver for Intel PRO/Wireless 3945ABG

cepting firmware)? Quote from the mentioned website: "In addition to using the new d80211 subsystem, this project uses a new microcode image which removes the need for the user space regulatory daemon for this adapter" regards Stefan Schmidt signature.asc Description: Digital signature

Re: [ANNOUNCE] d80211 based driver for Intel PRO/Wireless 3945ABG

the mentioned website: In addition to using the new d80211 subsystem, this project uses a new microcode image which removes the need for the user space regulatory daemon for this adapter regards Stefan Schmidt signature.asc Description: Digital signature

Re: [patch 2/3] acpi: Add a docked sysfs file to the dock driver.

Hello. On Wed, 2006-12-13 at 10:14, Kay Sievers wrote: > On Wed, 2006-12-13 at 00:26 +0100, Stefan Schmidt wrote: > > On Tue, 2006-12-12 at 15:00, Kristen Carlson Accardi wrote: > > > > > > I did have different dock/undock events a few months ago - but > > &g

  1   2   >