On 2018/9/8 17:46, Thomas Gleixner wrote:
> On Sat, 8 Sep 2018, zhong jiang wrote:
>> Hi, Thomas
>>
>> Can you pick up the patch?
> I'm not picking up patches for lib/sg_pool. Why would I?
>
I am sorry for that. I regard you as maintainer for lib/sg_pool mistakely
mempool_destroy has taken null pointer check into account. so remove the
redundant check.
Signed-off-by: zhong jiang
---
drivers/s390/scsi/zfcp_aux.c | 21 +++--
1 file changed, 7 insertions(+), 14 deletions(-)
diff --git a/drivers/s390/scsi/zfcp_aux.c b/drivers/s390/scsi
mempool_destroy has taken null pointer check into account. so remove the
redundant check.
Signed-off-by: zhong jiang
---
drivers/s390/scsi/zfcp_aux.c | 21 +++--
1 file changed, 7 insertions(+), 14 deletions(-)
diff --git a/drivers/s390/scsi/zfcp_aux.c b/drivers/s390/scsi
Hi, Thomas
Can you pick up the patch?
Thanks
zhong jiang
On 2018/8/1 0:21, zhong jiang wrote:
> kmem_cache_destroy/mempool_destroy has taken null check into account.
> so remove the redundant check.
>
> Signed-off-by: zhong jiang
> ---
> lib/sg_pool.c | 7 +++
&g
Hi, Thomas
Can you pick up the patch?
Thanks
zhong jiang
On 2018/8/1 0:21, zhong jiang wrote:
> kmem_cache_destroy/mempool_destroy has taken null check into account.
> so remove the redundant check.
>
> Signed-off-by: zhong jiang
> ---
> lib/sg_pool.c | 7 +++
&g
kmemdup has implemented the function that kmalloc() + memcpy() will
do. and we prefer to use the kmemdup rather than the open coded implementation.
Signed-off-by: zhong jiang
---
drivers/s390/crypto/zcrypt_msgtype6.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git
kmemdup has implemented the function that kmalloc() + memcpy() will
do. and we prefer to use the kmemdup rather than the open coded implementation.
Signed-off-by: zhong jiang
---
drivers/s390/crypto/zcrypt_msgtype6.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git
kmemdup has implemented the function that kzalloc() + memcpy() will
do. and we prefer to use the kmemdup rather than the open coded implementation.
Signed-off-by: zhong jiang
---
sound/soc/qcom/qdsp6/q6core.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/sound/soc
I find the issue with the help of Coccinelle.
zhong jiang (2):
sound: q6core: Use kmemdup to replace kzalloc + memcpy
sound: skl-topology: Use kmemdup to replace kzalloc + memcpy
sound/soc/intel/skylake/skl-topology.c | 3 +--
sound/soc/qcom/qdsp6/q6core.c | 8 ++--
2 files
kmemdup has implemented the function that kzalloc() + memcpy() will
do. and we prefer to use the kmemdup rather than the open coded implementation.
Signed-off-by: zhong jiang
---
sound/soc/qcom/qdsp6/q6core.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/sound/soc
I find the issue with the help of Coccinelle.
zhong jiang (2):
sound: q6core: Use kmemdup to replace kzalloc + memcpy
sound: skl-topology: Use kmemdup to replace kzalloc + memcpy
sound/soc/intel/skylake/skl-topology.c | 3 +--
sound/soc/qcom/qdsp6/q6core.c | 8 ++--
2 files
kmemdup has implemented the function that kzalloc() + memcpy() will
do. and we prefer to kmemdup rather than the open coded implementation.
Signed-off-by: zhong jiang
---
sound/soc/intel/skylake/skl-topology.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/sound/soc/intel
kmemdup has implemented the function that kzalloc() + memcpy() will
do. and we prefer to kmemdup rather than the open coded implementation.
Signed-off-by: zhong jiang
---
sound/soc/intel/skylake/skl-topology.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/sound/soc/intel
+to maintainers
On 2018/8/18 18:49, zhong jiang wrote:
> debugfs_remove has taken null pointer into account. So it is safe
> to remove the check before debugfs_remove.
>
> Signed-off-by: zhong jiang
> ---
> drivers/acpi/custom_method.c | 3 +--
> 1 file changed, 1 inse
+to maintainers
On 2018/8/18 18:49, zhong jiang wrote:
> debugfs_remove has taken null pointer into account. So it is safe
> to remove the check before debugfs_remove.
>
> Signed-off-by: zhong jiang
> ---
> drivers/acpi/custom_method.c | 3 +--
> 1 file changed, 1 inse
-by: zhong jiang
---
v1->v2: According to Daniel's suggestion. I modify the subject and commit log.
drivers/thermal/tegra/soctherm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/thermal/tegra/soctherm.c b/drivers/thermal/tegra/soctherm.c
index ed28110..3aa55c9 100644
--- a/drivers/ther
-by: zhong jiang
---
v1->v2: According to Daniel's suggestion. I modify the subject and commit log.
drivers/thermal/tegra/soctherm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/thermal/tegra/soctherm.c b/drivers/thermal/tegra/soctherm.c
index ed28110..3aa55c9 100644
--- a/drivers/ther
On 2018/8/23 20:19, Alexandre Belloni wrote:
> On 23/08/2018 19:44:38+0800, zhong jiang wrote:
>> Hi, alexandre
>>
>> Can you pick up the patch? Thanks
>>
> We are still in the merge window, this has to wait for v4.19-rc1.
Fine. Thank you for let me know .
On 2018/8/23 20:19, Alexandre Belloni wrote:
> On 23/08/2018 19:44:38+0800, zhong jiang wrote:
>> Hi, alexandre
>>
>> Can you pick up the patch? Thanks
>>
> We are still in the merge window, this has to wait for v4.19-rc1.
Fine. Thank you for let me know .
Hi, alexandre
Can you pick up the patch? Thanks
Best wishes,
zhong jiang
On 2018/8/16 18:26, zhong jiang wrote:
> of_find_device_by_node takes a reference to the struct device when it
> finds a match via get_device. but it fails to put_device in
> at91_pm_
Hi, alexandre
Can you pick up the patch? Thanks
Best wishes,
zhong jiang
On 2018/8/16 18:26, zhong jiang wrote:
> of_find_device_by_node takes a reference to the struct device when it
> finds a match via get_device. but it fails to put_device in
> at91_pm_
On 2018/8/13 22:20, don.br...@microchip.com wrote:
>> -Original Message-
>> From: zhong jiang [mailto:zhongji...@huawei.com]
>> Sent: Monday, August 13, 2018 7:43 AM
>> To: don.br...@microsemi.com; j...@linux.vnet.ibm.com;
>> martin.peter...@oracle.com
>&
On 2018/8/13 22:20, don.br...@microchip.com wrote:
>> -Original Message-
>> From: zhong jiang [mailto:zhongji...@huawei.com]
>> Sent: Monday, August 13, 2018 7:43 AM
>> To: don.br...@microsemi.com; j...@linux.vnet.ibm.com;
>> martin.peter...@oracle.com
>&
Ping , Anyone has any objection with the patchset ?
Thanks,
zhong jiang
On 2018/8/16 23:58, zhong jiang wrote:
> The issue is detected with the help of Coccinelle.
>
> v1->v2:
> - According to Florian's suggestion, change the subject of the patch.
>
> zhong jiang (2):
>
Ping , Anyone has any objection with the patchset ?
Thanks,
zhong jiang
On 2018/8/16 23:58, zhong jiang wrote:
> The issue is detected with the help of Coccinelle.
>
> v1->v2:
> - According to Florian's suggestion, change the subject of the patch.
>
> zhong jiang (2):
>
turn;
>
> - eFuseWord = (u16 **)rtw_malloc2d(EFUSE_MAX_SECTION_88E,
> EFUSE_MAX_WORD_UNIT, sizeof(u16));
> + eFuseWord = (u16 **)rtw_malloc2d(EFUSE_MAX_SECTION_88E,
> + EFUSE_MAX_WORD_UNIT, (int)sizeof(u16));
>
You should be align with left parenthesis.
Thanks,
turn;
>
> - eFuseWord = (u16 **)rtw_malloc2d(EFUSE_MAX_SECTION_88E,
> EFUSE_MAX_WORD_UNIT, sizeof(u16));
> + eFuseWord = (u16 **)rtw_malloc2d(EFUSE_MAX_SECTION_88E,
> + EFUSE_MAX_WORD_UNIT, (int)sizeof(u16));
>
You should be align with left parenthesis.
Thanks,
On 2018/8/18 22:01, Julia Lawall wrote:
>
> On Sat, 18 Aug 2018, zhong jiang wrote:
>
>> On 2018/8/18 20:52, Himanshu Jha wrote:
>>> On Sat, Aug 18, 2018 at 08:01:40PM +0800, zhong jiang wrote:
>>>> Because pci_alloc_consistent has been deprecated. We prefer to
On 2018/8/18 22:01, Julia Lawall wrote:
>
> On Sat, 18 Aug 2018, zhong jiang wrote:
>
>> On 2018/8/18 20:52, Himanshu Jha wrote:
>>> On Sat, Aug 18, 2018 at 08:01:40PM +0800, zhong jiang wrote:
>>>> Because pci_alloc_consistent has been deprecated. We prefer to
Because pci_alloc_consistent has been deprecated. We prefer to use
dma_alloc_coherent directly. Therefore, we should remove pci_alloc_consistent
to increase the confidence.
Acked-by: Julia Lawall
Acked-by: Himanshu Jha
Signed-off-by: zhong jiang
---
v1->v2:
- fix some spelling mista
Because pci_alloc_consistent has been deprecated. We prefer to use
dma_alloc_coherent directly. Therefore, we should remove pci_alloc_consistent
to increase the confidence.
Acked-by: Julia Lawall
Acked-by: Himanshu Jha
Signed-off-by: zhong jiang
---
v1->v2:
- fix some spelling mista
On 2018/8/18 20:52, Himanshu Jha wrote:
> On Sat, Aug 18, 2018 at 08:01:40PM +0800, zhong jiang wrote:
>> Because pci_alloc_consistent has been deprecated. We prefer to use
>> dam_alloc_coherent directly. Therefore, we should remove pci_alloc_consistent
> ^^^ typo &q
On 2018/8/18 20:52, Himanshu Jha wrote:
> On Sat, Aug 18, 2018 at 08:01:40PM +0800, zhong jiang wrote:
>> Because pci_alloc_consistent has been deprecated. We prefer to use
>> dam_alloc_coherent directly. Therefore, we should remove pci_alloc_consistent
> ^^^ typo &q
Because pci_alloc_consistent has been deprecated. We prefer to use
dam_alloc_coherent directly. Therefore, we should remove pci_alloc_consistent
to increase the confidence.
Signed-off-by: zhong jiang
---
scripts/coccinelle/api/alloc/zalloc-simple.cocci | 41 +---
1 file
Because pci_alloc_consistent has been deprecated. We prefer to use
dam_alloc_coherent directly. Therefore, we should remove pci_alloc_consistent
to increase the confidence.
Signed-off-by: zhong jiang
---
scripts/coccinelle/api/alloc/zalloc-simple.cocci | 41 +---
1 file
We prefer to ERR_CAST rather than ERR_PTR(PTR_ERR()), So just
replace it.
The issue is detected with the help of Coccinelle
Signed-off-by: zhong jiang
---
drivers/gpu/drm/omapdrm/dss/dss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/omapdrm/dss/dss.c
b
We prefer to ERR_CAST rather than ERR_PTR(PTR_ERR()), So just
replace it.
The issue is detected with the help of Coccinelle
Signed-off-by: zhong jiang
---
drivers/gpu/drm/omapdrm/dss/dss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/omapdrm/dss/dss.c
b
debugfs_remove has taken null pointer into account. So it is safe
to remove the check before debugfs_remove.
Signed-off-by: zhong jiang
---
drivers/acpi/custom_method.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/acpi/custom_method.c b/drivers/acpi
debugfs_remove has taken null pointer into account. So it is safe
to remove the check before debugfs_remove.
Signed-off-by: zhong jiang
---
drivers/acpi/custom_method.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/acpi/custom_method.c b/drivers/acpi
We should use NULL to compare with pointer-typed value rather than
0. The issue is detected with the help of Coccinelle.
Signed-off-by: zhong jiang
---
drivers/ide/pmac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ide/pmac.c b/drivers/ide/pmac.c
index c5b902b
We should use NULL to compare with pointer-typed value rather than
0. The issue is detected with the help of Coccinelle.
Signed-off-by: zhong jiang
---
drivers/ide/pmac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ide/pmac.c b/drivers/ide/pmac.c
index c5b902b
On 2018/8/17 21:23, zhong jiang wrote:
> We should use NULL to compare with pointer-typed value rather than
> 0. The issue is detected with the help of Coccinelle.
>
> Signed-off-by: zhong jiang
> ---
> drivers/ide/pmac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 delet
On 2018/8/17 21:23, zhong jiang wrote:
> We should use NULL to compare with pointer-typed value rather than
> 0. The issue is detected with the help of Coccinelle.
>
> Signed-off-by: zhong jiang
> ---
> drivers/ide/pmac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 delet
We should use NULL to compare with pointer-typed value rather than
0. The issue is detected with the help of Coccinelle.
Signed-off-by: zhong jiang
---
drivers/ide/pmac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ide/pmac.c b/drivers/ide/pmac.c
index c5b902b
We should use NULL to compare with pointer-typed value rather than
0. The issue is detected with the help of Coccinelle.
Signed-off-by: zhong jiang
---
drivers/ide/pmac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ide/pmac.c b/drivers/ide/pmac.c
index c5b902b
dma_pool_destroy has taken the null pointer into account. so just
remove the null pointer check.
Signed-off-by: zhong jiang
---
drivers/thunderbolt/ctl.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/thunderbolt/ctl.c b/drivers/thunderbolt/ctl.c
index 37a7f4c
dma_pool_destroy has taken the null pointer into account. so just
remove the null pointer check.
Signed-off-by: zhong jiang
---
drivers/thunderbolt/ctl.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/thunderbolt/ctl.c b/drivers/thunderbolt/ctl.c
index 37a7f4c
On 2018/8/17 17:18, Laurent Pinchart wrote:
> Hi Zhong,
>
> Thank you for the patch.
>
> On Friday, 17 August 2018 06:37:26 EEST zhong jiang wrote:
>> debugfs_remove_recursive has taken null pointer into account. so
>> remove the unneeded check.
>>
>> Signe
On 2018/8/17 17:18, Laurent Pinchart wrote:
> Hi Zhong,
>
> Thank you for the patch.
>
> On Friday, 17 August 2018 06:37:26 EEST zhong jiang wrote:
>> debugfs_remove_recursive has taken null pointer into account. so
>> remove the unneeded check.
>>
>> Signe
On 2018/8/17 11:24, zhong jiang wrote:
> kfree has taken null pointer into account. so check the null pointer
> before kfree is meanless.
meanless/meaningless. will repost. please ignore the patch, thanks.
> Signed-off-by: zhong jiang
> ---
> drivers/misc/sgi-xp/xpc_partition
On 2018/8/17 11:24, zhong jiang wrote:
> kfree has taken null pointer into account. so check the null pointer
> before kfree is meanless.
meanless/meaningless. will repost. please ignore the patch, thanks.
> Signed-off-by: zhong jiang
> ---
> drivers/misc/sgi-xp/xpc_partition
kfree has taken null pointer into account. so check the null pointer
before kfree is meaningless.
Signed-off-by: zhong jiang
---
drivers/misc/sgi-xp/xpc_partition.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/misc/sgi-xp/xpc_partition.c
b/drivers/misc/sgi-xp
kfree has taken null pointer into account. so check the null pointer
before kfree is meaningless.
Signed-off-by: zhong jiang
---
drivers/misc/sgi-xp/xpc_partition.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/misc/sgi-xp/xpc_partition.c
b/drivers/misc/sgi-xp
subect: drviers/drivers will repost, please ingore the patch. Thanks
On 2018/8/17 11:31, zhong jiang wrote:
> debugfs_remove_recursive has taken the null pointer into account.
> just remove the null check before debugfs_remove_recursive.
>
> Signed-off-by: zhong jiang
> ---
>
subect: drviers/drivers will repost, please ingore the patch. Thanks
On 2018/8/17 11:31, zhong jiang wrote:
> debugfs_remove_recursive has taken the null pointer into account.
> just remove the null check before debugfs_remove_recursive.
>
> Signed-off-by: zhong jiang
> ---
>
debugfs_remove_recursive has taken null pointer into account. so
remove the unneeded check.
Signed-off-by: zhong jiang
---
drivers/media/usb/uvc/uvc_debugfs.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/media/usb/uvc/uvc_debugfs.c
b/drivers/media/usb/uvc
debugfs_remove_recursive has taken null pointer into account. so
remove the unneeded check.
Signed-off-by: zhong jiang
---
drivers/media/usb/uvc/uvc_debugfs.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/media/usb/uvc/uvc_debugfs.c
b/drivers/media/usb/uvc
debugfs_remove_recursive has taken the null pointer into account.
just remove the null check before debugfs_remove_recursive.
Signed-off-by: zhong jiang
---
drivers/platform/x86/intel_ips.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/platform/x86/intel_ips.c b
debugfs_remove_recursive has taken the null pointer into account.
just remove the null check before debugfs_remove_recursive.
Signed-off-by: zhong jiang
---
drivers/platform/x86/intel_ips.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/platform/x86/intel_ips.c b
debugfs_remove_recursive has taken the null pointer into account.
just remove the null check before debugfs_remove_recursive.
Signed-off-by: zhong jiang
---
drivers/platform/x86/intel_ips.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/platform/x86/intel_ips.c b
debugfs_remove_recursive has taken the null pointer into account.
just remove the null check before debugfs_remove_recursive.
Signed-off-by: zhong jiang
---
drivers/platform/x86/intel_ips.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/platform/x86/intel_ips.c b
kfree has taken null pointer into account. so check the null pointer
before kfree is meanless.
Signed-off-by: zhong jiang
---
drivers/misc/sgi-xp/xpc_partition.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/misc/sgi-xp/xpc_partition.c
b/drivers/misc/sgi-xp
kfree has taken null pointer into account. so check the null pointer
before kfree is meanless.
Signed-off-by: zhong jiang
---
drivers/misc/sgi-xp/xpc_partition.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/misc/sgi-xp/xpc_partition.c
b/drivers/misc/sgi-xp
On 2018/8/14 14:39, Daniel Lezcano wrote:
> On 09/08/2018 15:40, zhong jiang wrote:
>> Device node iterators will get the return node. Meawhile, It is
>> also put the previous device node. An explicit put will cause
>> a double put.
> What about:
>
> Subject: drive
On 2018/8/14 14:39, Daniel Lezcano wrote:
> On 09/08/2018 15:40, zhong jiang wrote:
>> Device node iterators will get the return node. Meawhile, It is
>> also put the previous device node. An explicit put will cause
>> a double put.
> What about:
>
> Subject: drive
PTR_ERR_OR_ZERO has implemented the if(IS_ERR(...)) + PTR_ERR, So
just replace them rather than duplicating its implement.
Signed-off-by: zhong jiang
---
drivers/phy/broadcom/phy-brcm-usb.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/phy/broadcom/phy-brcm
PTR_ERR_OR_ZERO has implemented the if(IS_ERR(...)) + PTR_ERR, So
just replace them rather than duplicating its implement.
Signed-off-by: zhong jiang
---
drivers/phy/broadcom/phy-brcm-usb.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/phy/broadcom/phy-brcm
PTR_ERR_OR_ZERO has implemented the if(IS_ERR(...)) + PTR_ERR, So
just replace them rather than duplicating its implement.
Signed-off-by: zhong jiang
---
drivers/phy/lantiq/phy-lantiq-rcu-usb2.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/phy/lantiq/phy-lantiq
The issue is detected with the help of Coccinelle.
v1->v2:
- According to Florian's suggestion, change the subject of the patch.
zhong jiang (2):
phy:phy-brcm-usb: Use PTR_ERR_OR_ZERO to replace the open coded
version
phy:phy-lantiq-rcu-usb2: Use PTR_ERR_OR_ZERO to replace the o
PTR_ERR_OR_ZERO has implemented the if(IS_ERR(...)) + PTR_ERR, So
just replace them rather than duplicating its implement.
Signed-off-by: zhong jiang
---
drivers/phy/lantiq/phy-lantiq-rcu-usb2.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/phy/lantiq/phy-lantiq
The issue is detected with the help of Coccinelle.
v1->v2:
- According to Florian's suggestion, change the subject of the patch.
zhong jiang (2):
phy:phy-brcm-usb: Use PTR_ERR_OR_ZERO to replace the open coded
version
phy:phy-lantiq-rcu-usb2: Use PTR_ERR_OR_ZERO to replace the o
instead of of_node_put in at91_pm_config_ws.
Fixes: d7484f5c6b3b ("ARM: at91: pm: configure wakeup sources for ULP1 mode")
Suggested-by: Claudiu Beznea
Signed-off-by: zhong jiang
---
arch/arm/mach-at91/pm.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm
instead of of_node_put in at91_pm_config_ws.
Fixes: d7484f5c6b3b ("ARM: at91: pm: configure wakeup sources for ULP1 mode")
Suggested-by: Claudiu Beznea
Signed-off-by: zhong jiang
---
arch/arm/mach-at91/pm.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm
On 2018/8/16 17:32, Claudiu Beznea wrote:
> Hi Alexandre,
>
> On 14.08.2018 15:59, Alexandre Belloni wrote:
>> On 14/08/2018 09:54:56+0800, zhong jiang wrote:
>>> Device node iterators put the previous value of the index variable,
>>> so an explicit put
On 2018/8/16 17:32, Claudiu Beznea wrote:
> Hi Alexandre,
>
> On 14.08.2018 15:59, Alexandre Belloni wrote:
>> On 14/08/2018 09:54:56+0800, zhong jiang wrote:
>>> Device node iterators put the previous value of the index variable,
>>> so an explicit put
On 2018/8/16 7:23, Florian Fainelli wrote:
> On 08/13/2018 04:24 AM, zhong jiang wrote:
>> PTR_ERR_OR_ZERO has implemented the if(IS_ERR(...)) + PTR_ERR, So
>> just replace them rather than duplicating its implement.
> Subject should be:
>
> phy: phy-brcm-usb: Use PTR_ERR
On 2018/8/16 7:23, Florian Fainelli wrote:
> On 08/13/2018 04:24 AM, zhong jiang wrote:
>> PTR_ERR_OR_ZERO has implemented the if(IS_ERR(...)) + PTR_ERR, So
>> just replace them rather than duplicating its implement.
> Subject should be:
>
> phy: phy-brcm-usb: Use PTR_ERR
On 2018/8/15 0:15, Alexandre Belloni wrote:
> Hi,
>
> On 13/08/2018 19:31:24+0800, zhong jiang wrote:
>> PTR_ERR_OR_ZERO has implemented the if(IS_ERR(...)) + PTR_ERR, So
>> just replace them rather than duplicating its implement.
>>
>> Signed-off-by: zhong
On 2018/8/15 0:15, Alexandre Belloni wrote:
> Hi,
>
> On 13/08/2018 19:31:24+0800, zhong jiang wrote:
>> PTR_ERR_OR_ZERO has implemented the if(IS_ERR(...)) + PTR_ERR, So
>> just replace them rather than duplicating its implement.
>>
>> Signed-off-by: zhong
We prefer to ARRAY_SIZE rather than duplicating its implementation.
And just one place use the #define variable, therefore, remove
PFM_CMD_COUNT definition altogether.
Signed-off-by: zhong jiang
---
v1->v2:
- According to Joe's suggestion. remove the #define variable,
and use ARRAY_S
We prefer to ARRAY_SIZE rather than duplicating its implementation.
And just one place use the #define variable, therefore, remove
PFM_CMD_COUNT definition altogether.
Signed-off-by: zhong jiang
---
v1->v2:
- According to Joe's suggestion. remove the #define variable,
and use ARRAY_S
On 2018/8/14 14:39, Daniel Lezcano wrote:
> On 09/08/2018 15:40, zhong jiang wrote:
>> Device node iterators will get the return node. Meawhile, It is
>> also put the previous device node. An explicit put will cause
>> a double put.
> What about:
>
> Subject: drive
On 2018/8/14 14:39, Daniel Lezcano wrote:
> On 09/08/2018 15:40, zhong jiang wrote:
>> Device node iterators will get the return node. Meawhile, It is
>> also put the previous device node. An explicit put will cause
>> a double put.
> What about:
>
> Subject: drive
Device node iterators put the previous value of the index variable,
so an explicit put causes a double put.
I detect the issue with the help of Coccinelle.
Signed-off-by: zhong jiang
---
arch/arm/mach-at91/pm.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/arch/arm
Device node iterators put the previous value of the index variable,
so an explicit put causes a double put.
I detect the issue with the help of Coccinelle.
Signed-off-by: zhong jiang
---
arch/arm/mach-at91/pm.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/arch/arm
On 2018/8/13 20:28, Vladimir Zapolskiy wrote:
> Hi zhong jiang,
>
> On 08/10/2018 05:40 AM, zhong jiang wrote:
>> kmemdup is better than kmalloc() + memcpy(), and we do not like
>> open code. So just use kmemdup instead.
>>
>> Signed-off-by: zhong jiang
>>
On 2018/8/13 20:28, Vladimir Zapolskiy wrote:
> Hi zhong jiang,
>
> On 08/10/2018 05:40 AM, zhong jiang wrote:
>> kmemdup is better than kmalloc() + memcpy(), and we do not like
>> open code. So just use kmemdup instead.
>>
>> Signed-off-by: zhong jiang
>>
vmemdup_user is better than duplicating its implementation, So just
replace the open code.
The issue is detected with the help of Coccinelle.
Signed-off-by: zhong jiang
---
drivers/scsi/hpsa.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/scsi/hpsa.c
vmemdup_user is better than duplicating its implementation, So just
replace the open code.
The issue is detected with the help of Coccinelle.
Signed-off-by: zhong jiang
---
drivers/scsi/hpsa.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/scsi/hpsa.c
Please ignore the patch, will repost . Thanks
On 2018/8/13 20:22, zhong jiang wrote:
> vmemdup_user is better than duplicating its implementation, So just
> replace the open code.
>
> Signed-off-by: zhong jiang
> ---
> drivers/scsi/hpsa.c | 10 +++---
> 1 file change
Please ignore the patch, will repost . Thanks
On 2018/8/13 20:22, zhong jiang wrote:
> vmemdup_user is better than duplicating its implementation, So just
> replace the open code.
>
> Signed-off-by: zhong jiang
> ---
> drivers/scsi/hpsa.c | 10 +++---
> 1 file change
vmemdup_user is better than duplicating its implementation, So just
replace the open code.
Signed-off-by: zhong jiang
---
drivers/scsi/hpsa.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 58bb70b..948576a 100644
vmemdup_user is better than duplicating its implementation, So just
replace the open code.
Signed-off-by: zhong jiang
---
drivers/scsi/hpsa.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 58bb70b..948576a 100644
PTR_ERR_OR_ZERO has implemented the if(IS_ERR(...)) + PTR_ERR, So
just replace them rather than duplicating its implement.
Signed-off-by: zhong jiang
---
drivers/rtc/rtc-digicolor.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/rtc/rtc-digicolor.c b/drivers/rtc
PTR_ERR_OR_ZERO has implemented the if(IS_ERR(...)) + PTR_ERR, So
just replace them rather than duplicating its implement.
Signed-off-by: zhong jiang
---
drivers/rtc/rtc-ds1347.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/rtc/rtc-ds1347.c b/drivers/rtc/rtc
PTR_ERR_OR_ZERO has implemented the if(IS_ERR(...)) + PTR_ERR, So
just replace them rather than duplicating its implement.
Signed-off-by: zhong jiang
---
drivers/rtc/rtc-digicolor.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/rtc/rtc-digicolor.c b/drivers/rtc
PTR_ERR_OR_ZERO has implemented the if(IS_ERR(...)) + PTR_ERR, So
just replace them rather than duplicating its implement.
Signed-off-by: zhong jiang
---
drivers/rtc/rtc-ds1347.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/rtc/rtc-ds1347.c b/drivers/rtc/rtc
The issue is detected with the help of Coccinelle.
zhong jiang (2):
rtc:rtc-digicolor: Use PTR_ERR_OR_ZERO to replace the open code
rtc:rtc-ds1347: Use PTR_ERR_OR_ZERO to replace the open code
drivers/rtc/rtc-digicolor.c | 4 +---
drivers/rtc/rtc-ds1347.c| 5 +
2 files changed, 2
The issue is detected with the help of Coccinelle.
zhong jiang (2):
rtc:rtc-digicolor: Use PTR_ERR_OR_ZERO to replace the open code
rtc:rtc-ds1347: Use PTR_ERR_OR_ZERO to replace the open code
drivers/rtc/rtc-digicolor.c | 4 +---
drivers/rtc/rtc-ds1347.c| 5 +
2 files changed, 2
PTR_ERR_OR_ZERO has implemented the if(IS_ERR(...)) + PTR_ERR, So
just replace them rather than duplicating its implement.
Signed-off-by: zhong jiang
---
drivers/phy/broadcom/phy-brcm-usb.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/phy/broadcom/phy-brcm
301 - 400 of 759 matches
Mail list logo