Re: [PATCH v3 02/15] exec: Rename bprm->cred_prepared to called_set_creds

2017-07-19 Thread Paul Moore
On Tue, Jul 18, 2017 at 6:25 PM, Kees Cook wrote: > The cred_prepared bprm flag has a misleading name. It has nothing to do > with the bprm_prepare_cred hook, and actually tracks if bprm_set_creds has > been called. Rename this flag and improve its comment. > > Cc: David Howells > Cc: John Johans

Re: [PATCH v3 02/15] exec: Rename bprm->cred_prepared to called_set_creds

2017-07-19 Thread James Morris
On Tue, 18 Jul 2017, Kees Cook wrote: > The cred_prepared bprm flag has a misleading name. It has nothing to do > with the bprm_prepare_cred hook, and actually tracks if bprm_set_creds has > been called. Rename this flag and improve its comment. > > Cc: David Howells > Cc: John Johansen > Cc: P

Re: [PATCH v3 02/15] exec: Rename bprm->cred_prepared to called_set_creds

2017-07-18 Thread Kees Cook
On Tue, Jul 18, 2017 at 6:06 PM, Andy Lutomirski wrote: > On Tue, Jul 18, 2017 at 3:25 PM, Kees Cook wrote: >> The cred_prepared bprm flag has a misleading name. It has nothing to do >> with the bprm_prepare_cred hook, and actually tracks if bprm_set_creds has >> been called. Rename this flag and

Re: [PATCH v3 02/15] exec: Rename bprm->cred_prepared to called_set_creds

2017-07-18 Thread Andy Lutomirski
On Tue, Jul 18, 2017 at 3:25 PM, Kees Cook wrote: > The cred_prepared bprm flag has a misleading name. It has nothing to do > with the bprm_prepare_cred hook, and actually tracks if bprm_set_creds has > been called. Rename this flag and improve its comment. > > Cc: David Howells > Cc: John Johans

Re: [PATCH v3 02/15] exec: Rename bprm->cred_prepared to called_set_creds

2017-07-18 Thread John Johansen
On 07/18/2017 03:25 PM, Kees Cook wrote: > The cred_prepared bprm flag has a misleading name. It has nothing to do > with the bprm_prepare_cred hook, and actually tracks if bprm_set_creds has > been called. Rename this flag and improve its comment. > > Cc: David Howells > Cc: John Johansen > Cc:

[PATCH v3 02/15] exec: Rename bprm->cred_prepared to called_set_creds

2017-07-18 Thread Kees Cook
The cred_prepared bprm flag has a misleading name. It has nothing to do with the bprm_prepare_cred hook, and actually tracks if bprm_set_creds has been called. Rename this flag and improve its comment. Cc: David Howells Cc: John Johansen Cc: Paul Moore Cc: Stephen Smalley Cc: Casey Schaufler