RE: [PATCH 04/11] x86/microcode_core_early.c: Define interfaces for early load ucode

2012-08-21 Thread Yu, Fenghua
av > Petkov; linux-kernel; x86 > Subject: Re: [PATCH 04/11] x86/microcode_core_early.c: Define > interfaces for early load ucode > > On 08/21/2012 01:52 PM, Yu, Fenghua wrote: > >> -Original Message- > >> From: Borislav Petkov [mailto:b...@amd64.org] > >&

Re: [PATCH 04/11] x86/microcode_core_early.c: Define interfaces for early load ucode

2012-08-21 Thread H. Peter Anvin
t; Gleixner; Mallick, Asit K; Tigran Aivazian; Andreas Herrmann; Borislav >> Petkov; linux-kernel; x86 >> Subject: Re: [PATCH 04/11] x86/microcode_core_early.c: Define >> interfaces for early load ucode >> >> On Tue, Aug 21, 2012 at 01:13:26PM -0700, H. Peter Anvin wrote:

Re: [PATCH 04/11] x86/microcode_core_early.c: Define interfaces for early load ucode

2012-08-21 Thread H. Peter Anvin
On 08/21/2012 01:48 PM, Borislav Petkov wrote: > On Tue, Aug 21, 2012 at 01:13:26PM -0700, H. Peter Anvin wrote: >> I don't know what Borislav was suggesting with "BIOS overrides", is >> that another CPU-specific thing? > > Not CPU- but rather platform-specific. It is Thomas Renninger's >

RE: [PATCH 04/11] x86/microcode_core_early.c: Define interfaces for early load ucode

2012-08-21 Thread Yu, Fenghua
av > Petkov; linux-kernel; x86 > Subject: Re: [PATCH 04/11] x86/microcode_core_early.c: Define > interfaces for early load ucode > > On Tue, Aug 21, 2012 at 01:13:26PM -0700, H. Peter Anvin wrote: > > I don't know what Borislav was suggesting with "BIOS overrides", is

Re: [PATCH 04/11] x86/microcode_core_early.c: Define interfaces for early load ucode

2012-08-21 Thread Borislav Petkov
On Tue, Aug 21, 2012 at 01:13:26PM -0700, H. Peter Anvin wrote: > I don't know what Borislav was suggesting with "BIOS overrides", is > that another CPU-specific thing? Not CPU- but rather platform-specific. It is Thomas Renninger's mechanism to override BIOS tables. -- Regards/Gruss, Boris.

Re: [PATCH 04/11] x86/microcode_core_early.c: Define interfaces for early load ucode

2012-08-21 Thread H. Peter Anvin
On 08/21/2012 01:05 PM, Yu, Fenghua wrote: > > We might name the cpio directory as: > > kernel/x86/microcode/GenuineIntel.bin > kernel/x86/microcode/AuthenticAMD.bin > kernel/x86/acpi/... > etc. > > This is expendable for the future usage. > > Plus I will add a doc on the cpio directory,

RE: [PATCH 04/11] x86/microcode_core_early.c: Define interfaces for early load ucode

2012-08-21 Thread Yu, Fenghua
av > Petkov; linux-kernel; x86 > Subject: Re: [PATCH 04/11] x86/microcode_core_early.c: Define > interfaces for early load ucode > > On Mon, Aug 20, 2012 at 01:08:49PM -0700, H. Peter Anvin wrote: > > On 08/20/2012 07:06 AM, Borislav Petkov wrote: > > > > > &

RE: [PATCH 04/11] x86/microcode_core_early.c: Define interfaces for early load ucode

2012-08-21 Thread Yu, Fenghua
; x86 Subject: Re: [PATCH 04/11] x86/microcode_core_early.c: Define interfaces for early load ucode On Mon, Aug 20, 2012 at 01:08:49PM -0700, H. Peter Anvin wrote: On 08/20/2012 07:06 AM, Borislav Petkov wrote: Or, in case we want to supply more vendor-specific stuff early at boot

Re: [PATCH 04/11] x86/microcode_core_early.c: Define interfaces for early load ucode

2012-08-21 Thread H. Peter Anvin
On 08/21/2012 01:05 PM, Yu, Fenghua wrote: We might name the cpio directory as: kernel/x86/microcode/GenuineIntel.bin kernel/x86/microcode/AuthenticAMD.bin kernel/x86/acpi/... etc. This is expendable for the future usage. Plus I will add a doc on the cpio directory, supported

Re: [PATCH 04/11] x86/microcode_core_early.c: Define interfaces for early load ucode

2012-08-21 Thread Borislav Petkov
On Tue, Aug 21, 2012 at 01:13:26PM -0700, H. Peter Anvin wrote: I don't know what Borislav was suggesting with BIOS overrides, is that another CPU-specific thing? Not CPU- but rather platform-specific. It is Thomas Renninger's mechanism to override BIOS tables. -- Regards/Gruss, Boris.

RE: [PATCH 04/11] x86/microcode_core_early.c: Define interfaces for early load ucode

2012-08-21 Thread Yu, Fenghua
; x86 Subject: Re: [PATCH 04/11] x86/microcode_core_early.c: Define interfaces for early load ucode On Tue, Aug 21, 2012 at 01:13:26PM -0700, H. Peter Anvin wrote: I don't know what Borislav was suggesting with BIOS overrides, is that another CPU-specific thing? Not CPU- but rather platform

Re: [PATCH 04/11] x86/microcode_core_early.c: Define interfaces for early load ucode

2012-08-21 Thread H. Peter Anvin
On 08/21/2012 01:48 PM, Borislav Petkov wrote: On Tue, Aug 21, 2012 at 01:13:26PM -0700, H. Peter Anvin wrote: I don't know what Borislav was suggesting with BIOS overrides, is that another CPU-specific thing? Not CPU- but rather platform-specific. It is Thomas Renninger's mechanism to

Re: [PATCH 04/11] x86/microcode_core_early.c: Define interfaces for early load ucode

2012-08-21 Thread H. Peter Anvin
Herrmann; Borislav Petkov; linux-kernel; x86 Subject: Re: [PATCH 04/11] x86/microcode_core_early.c: Define interfaces for early load ucode On Tue, Aug 21, 2012 at 01:13:26PM -0700, H. Peter Anvin wrote: I don't know what Borislav was suggesting with BIOS overrides, is that another CPU

RE: [PATCH 04/11] x86/microcode_core_early.c: Define interfaces for early load ucode

2012-08-21 Thread Yu, Fenghua
; x86 Subject: Re: [PATCH 04/11] x86/microcode_core_early.c: Define interfaces for early load ucode On 08/21/2012 01:52 PM, Yu, Fenghua wrote: -Original Message- From: Borislav Petkov [mailto:b...@amd64.org] Sent: Tuesday, August 21, 2012 1:49 PM To: H. Peter Anvin Cc: Yu

Re: [PATCH 04/11] x86/microcode_core_early.c: Define interfaces for early load ucode

2012-08-20 Thread Borislav Petkov
On Mon, Aug 20, 2012 at 01:08:49PM -0700, H. Peter Anvin wrote: > On 08/20/2012 07:06 AM, Borislav Petkov wrote: > > > > Or, > > > > in case we want to supply more vendor-specific stuff early at boot, we > > could do: > > > > kernel/x86//microcode... > > |-> bios_overrides > >

Re: [PATCH 04/11] x86/microcode_core_early.c: Define interfaces for early load ucode

2012-08-20 Thread H. Peter Anvin
On 08/20/2012 07:06 AM, Borislav Petkov wrote: > > Or, > > in case we want to supply more vendor-specific stuff early at boot, we > could do: > > kernel/x86//microcode... > |-> bios_overrides > |-> ... > > and have this layout extensible from the beginning... >

Re: [PATCH 04/11] x86/microcode_core_early.c: Define interfaces for early load ucode

2012-08-20 Thread Borislav Petkov
On Sun, Aug 19, 2012 at 04:39:42PM +, Yu, Fenghua wrote: > > Actually I think we can also skip one level of indirection here... no > > need to mention "microcode" twice. > > > > kernel/x86/microcode/GenuineIntel or GenuineIntel.bin seems good > > enough... the idea here of course is that the

Re: [PATCH 04/11] x86/microcode_core_early.c: Define interfaces for early load ucode

2012-08-20 Thread Borislav Petkov
On Sat, Aug 18, 2012 at 01:15:22AM -0700, Fenghua Yu wrote: > From: Fenghua Yu > > Define interfaces load_ucode_bsp() and load_ucode_ap() to load ucode on BSP > and > AP in early boot time. These are generic interfaces. Internally they call > vendor specific implementations. > > Signed-off-by:

Re: [PATCH 04/11] x86/microcode_core_early.c: Define interfaces for early load ucode

2012-08-20 Thread Borislav Petkov
On Sat, Aug 18, 2012 at 01:15:22AM -0700, Fenghua Yu wrote: From: Fenghua Yu fenghua...@intel.com Define interfaces load_ucode_bsp() and load_ucode_ap() to load ucode on BSP and AP in early boot time. These are generic interfaces. Internally they call vendor specific implementations.

Re: [PATCH 04/11] x86/microcode_core_early.c: Define interfaces for early load ucode

2012-08-20 Thread Borislav Petkov
On Sun, Aug 19, 2012 at 04:39:42PM +, Yu, Fenghua wrote: Actually I think we can also skip one level of indirection here... no need to mention microcode twice. kernel/x86/microcode/GenuineIntel or GenuineIntel.bin seems good enough... the idea here of course is that the string can

Re: [PATCH 04/11] x86/microcode_core_early.c: Define interfaces for early load ucode

2012-08-20 Thread H. Peter Anvin
On 08/20/2012 07:06 AM, Borislav Petkov wrote: Or, in case we want to supply more vendor-specific stuff early at boot, we could do: kernel/x86/vendor/microcode... |- bios_overrides |- ... and have this layout extensible from the beginning... Does that

Re: [PATCH 04/11] x86/microcode_core_early.c: Define interfaces for early load ucode

2012-08-20 Thread Borislav Petkov
On Mon, Aug 20, 2012 at 01:08:49PM -0700, H. Peter Anvin wrote: On 08/20/2012 07:06 AM, Borislav Petkov wrote: Or, in case we want to supply more vendor-specific stuff early at boot, we could do: kernel/x86/vendor/microcode... |- bios_overrides |- ...

RE: [PATCH 04/11] x86/microcode_core_early.c: Define interfaces for early load ucode

2012-08-19 Thread Yu, Fenghua
nux- > kernel; x86 > Subject: Re: [PATCH 04/11] x86/microcode_core_early.c: Define > interfaces for early load ucode > > On 08/18/2012 07:38 PM, Yu, Fenghua wrote: > > > > In this early phase, detecting vendor in initrd is much simpler code. > > Otherwise, detecting ve

RE: [PATCH 04/11] x86/microcode_core_early.c: Define interfaces for early load ucode

2012-08-19 Thread Yu, Fenghua
: Re: [PATCH 04/11] x86/microcode_core_early.c: Define interfaces for early load ucode On 08/18/2012 07:38 PM, Yu, Fenghua wrote: In this early phase, detecting vendor in initrd is much simpler code. Otherwise, detecting vendor by cpuid (and without cpuid) needs similar but different code

Re: [PATCH 04/11] x86/microcode_core_early.c: Define interfaces for early load ucode

2012-08-18 Thread H. Peter Anvin
On 08/18/2012 07:38 PM, Yu, Fenghua wrote: > > In this early phase, detecting vendor in initrd is much simpler code. > Otherwise, detecting vendor by cpuid (and without cpuid) needs > similar but different code as existing functions and coding would be > awkward. > I'm confused by this

Re: [PATCH 04/11] x86/microcode_core_early.c: Define interfaces for early load ucode

2012-08-18 Thread Henrique de Moraes Holschuh
On Sun, 19 Aug 2012, Yu, Fenghua wrote: > > From: Henrique de Moraes Holschuh [mailto:h...@hmh.eng.br] > > On Sat, 18 Aug 2012, Fenghua Yu wrote: > > > + char ucode_name[] = > > "kernel/x86/microcode/GenuineIntel/microcode.hex"; > > > > Why name it ".hex" when you're loading binary data? I

RE: [PATCH 04/11] x86/microcode_core_early.c: Define interfaces for early load ucode

2012-08-18 Thread Yu, Fenghua
linux-kernel; x86 > Subject: Re: [PATCH 04/11] x86/microcode_core_early.c: Define > interfaces for early load ucode > > On Sat, 18 Aug 2012, Fenghua Yu wrote: > > + char ucode_name[] = > "kernel/x86/microcode/GenuineIntel/microcode.hex"; > > Why name it &

Re: [PATCH 04/11] x86/microcode_core_early.c: Define interfaces for early load ucode

2012-08-18 Thread Henrique de Moraes Holschuh
On Sat, 18 Aug 2012, Fenghua Yu wrote: > + char ucode_name[] = "kernel/x86/microcode/GenuineIntel/microcode.hex"; Why name it ".hex" when you're loading binary data? I suggest ".bin". It is confusing to have .hex there, since you're not dealing with the Intel HEX format, nor anything

[PATCH 04/11] x86/microcode_core_early.c: Define interfaces for early load ucode

2012-08-18 Thread Fenghua Yu
From: Fenghua Yu Define interfaces load_ucode_bsp() and load_ucode_ap() to load ucode on BSP and AP in early boot time. These are generic interfaces. Internally they call vendor specific implementations. Signed-off-by: Fenghua Yu --- arch/x86/include/asm/microcode.h | 23 ++

[PATCH 04/11] x86/microcode_core_early.c: Define interfaces for early load ucode

2012-08-18 Thread Fenghua Yu
From: Fenghua Yu fenghua...@intel.com Define interfaces load_ucode_bsp() and load_ucode_ap() to load ucode on BSP and AP in early boot time. These are generic interfaces. Internally they call vendor specific implementations. Signed-off-by: Fenghua Yu fenghua...@intel.com ---

Re: [PATCH 04/11] x86/microcode_core_early.c: Define interfaces for early load ucode

2012-08-18 Thread Henrique de Moraes Holschuh
On Sat, 18 Aug 2012, Fenghua Yu wrote: + char ucode_name[] = kernel/x86/microcode/GenuineIntel/microcode.hex; Why name it .hex when you're loading binary data? I suggest .bin. It is confusing to have .hex there, since you're not dealing with the Intel HEX format, nor anything text-like.

RE: [PATCH 04/11] x86/microcode_core_early.c: Define interfaces for early load ucode

2012-08-18 Thread Yu, Fenghua
: [PATCH 04/11] x86/microcode_core_early.c: Define interfaces for early load ucode On Sat, 18 Aug 2012, Fenghua Yu wrote: + char ucode_name[] = kernel/x86/microcode/GenuineIntel/microcode.hex; Why name it .hex when you're loading binary data? I suggest .bin. It is confusing to have .hex

Re: [PATCH 04/11] x86/microcode_core_early.c: Define interfaces for early load ucode

2012-08-18 Thread Henrique de Moraes Holschuh
On Sun, 19 Aug 2012, Yu, Fenghua wrote: From: Henrique de Moraes Holschuh [mailto:h...@hmh.eng.br] On Sat, 18 Aug 2012, Fenghua Yu wrote: + char ucode_name[] = kernel/x86/microcode/GenuineIntel/microcode.hex; Why name it .hex when you're loading binary data? I suggest .bin. It

Re: [PATCH 04/11] x86/microcode_core_early.c: Define interfaces for early load ucode

2012-08-18 Thread H. Peter Anvin
On 08/18/2012 07:38 PM, Yu, Fenghua wrote: In this early phase, detecting vendor in initrd is much simpler code. Otherwise, detecting vendor by cpuid (and without cpuid) needs similar but different code as existing functions and coding would be awkward. I'm confused by this statement.