[PATCH v6 1/2] sta2x11_vip: convert to videobuf2, control framework, file handler

2013-02-05 Thread Federico Vaga
ones from videobuf2 and v4l2_fh Signed-off-by: Federico Vaga Acked-by: Giancarlo Asnaghi --- drivers/media/pci/sta2x11/Kconfig |2 +- drivers/media/pci/sta2x11/sta2x11_vip.c | 1073 +-- 2 file modificati, 434 inserzioni(+), 641 rimozioni(-) diff --git a

Re: [PATCH v6 1/2] sta2x11_vip: convert to videobuf2, control framework, file handler

2013-02-06 Thread Federico Vaga
ges (you did that, right? Just checking...), that > these are really useful improvements, and that I reviewed the code > (as well as I could) and didn't see any problems, I'm giving my ack > anyway: Tested every time I sent a patch > Acked-by: Hans Verkuil Thank you a

[PATCH 1/4] v4l: vb2: add prepare/finish callbacks to allocators

2012-09-13 Thread Federico Vaga
This patch adds support for prepare/finish callbacks in VB2 allocators. These callback are used for buffer flushing. Signed-off-by: Marek Szyprowski Acked-by: Laurent Pinchart Acked-by: Federico Vaga --- drivers/media/v4l2-core/videobuf2-core.c | 11 +++ include/media/videobuf2-core.h

[PATCH 3/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-09-13 Thread Federico Vaga
Signed-off-by: Federico Vaga --- drivers/media/v4l2-core/Kconfig | 5 + drivers/media/v4l2-core/Makefile | 1 + drivers/media/v4l2-core/videobuf2-dma-streaming.c | 205 ++ include/media/videobuf2-dma-streaming.h | 24 +++ 4

[PATCH 2/4] adv7180: remove {query/g_/s_}ctrl

2012-09-13 Thread Federico Vaga
Signed-off-by: Federico Vaga --- drivers/media/i2c/adv7180.c | 3 --- 1 file modificato, 3 rimozioni(-) diff --git a/drivers/media/i2c/adv7180.c b/drivers/media/i2c/adv7180.c index 45ecf8d..43bc2b9 100644 --- a/drivers/media/i2c/adv7180.c +++ b/drivers/media/i2c/adv7180.c @@ -402,9 +402,6

[PATCH 4/4] sta2x11_vip: convert to videobuf2 and control framework

2012-09-13 Thread Federico Vaga
Signed-off-by: Federico Vaga Acked-by: Giancarlo Asnaghi --- drivers/media/pci/sta2x11/Kconfig |2 +- drivers/media/pci/sta2x11/sta2x11_vip.c | 1235 ++- 2 file modificati, 411 inserzioni(+), 826 rimozioni(-) diff --git a/drivers/media/pci/sta2x11/Kconfig

Re: [PATCH 3/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-09-13 Thread Federico Vaga
te one or two lines of comment to summarize each function. what do you think? -- Federico Vaga -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.

Re: [PATCH 3/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-09-13 Thread Federico Vaga
> On Thursday, September 13, 2012 3:53 PM Federico Vaga wrote: > > Signed-off-by: Federico Vaga > > A few words explaining why this memory handling module is required or > beneficial will definitely improve the commit :) ok, I will write some lines > > +static void *

Re: [PATCH 3/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-09-13 Thread Federico Vaga
, you know what I'm doing in each vb2_mem_ops. I suppose that this is the reason why there are no comments inside the other memory allocator. Maybe I am wrong. -- Federico Vaga -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

Re: [PATCH 3/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-09-13 Thread Federico Vaga
In data giovedì 13 settembre 2012 11:45:31, Jonathan Corbet ha scritto: > On Thu, 13 Sep 2012 17:46:32 +0200 > > Federico Vaga wrote: > > > A few words explaining why this memory handling module is required > > > or > > > beneficial will definitely improve the

Update STA2X11 to videobuf2 and control framework

2012-07-31 Thread Federico Vaga
out any control. I add it to inherit controls from adv7180. -- Federico Vaga -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the F

[PATCH 1/3 RFC] [media] adv7180: remove {query/g_/s_}ctrl

2012-07-31 Thread Federico Vaga
Signed-off-by: Federico Vaga --- drivers/media/video/adv7180.c | 3 --- 1 file modificato, 3 rimozioni(-) diff --git a/drivers/media/video/adv7180.c b/drivers/media/video/adv7180.c index 07bb550..bcc7d60 100644 --- a/drivers/media/video/adv7180.c +++ b/drivers/media/video/adv7180.c @@ -402,9

Update VIP to videobuf2 and control framework

2012-07-31 Thread Federico Vaga
As suggested I moved the Video Buffer Input (VIP) of the STA2X11 board to the videobuf2. This patch series is an RFC. The first patch is just an update to the adv7180 because the VIP (the only user) now use the control framework so query{g_|s_|ctrl} are not necessery. The second patch adds a new

[PATCH 1/3] [media] adv7180: remove {query/g_/s_}ctrl

2012-07-31 Thread Federico Vaga
Signed-off-by: Federico Vaga --- drivers/media/video/adv7180.c | 3 --- 1 file modificato, 3 rimozioni(-) diff --git a/drivers/media/video/adv7180.c b/drivers/media/video/adv7180.c index 07bb550..bcc7d60 100644 --- a/drivers/media/video/adv7180.c +++ b/drivers/media/video/adv7180.c @@ -402,9

[PATCH 2/3] [media] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-07-31 Thread Federico Vaga
Signed-off-by: Federico Vaga --- drivers/media/video/Kconfig | 6 +- drivers/media/video/Makefile | 1 + drivers/media/video/videobuf2-dma-streaming.c | 187 ++ include/media/videobuf2-dma-streaming.h | 24 4 file

[PATCH 3/3] [media] sta2x11_vip: convert to videobuf2 and control framework

2012-07-31 Thread Federico Vaga
Signed-off-by: Federico Vaga Acked-by: Giancarlo Asnaghi --- drivers/media/video/sta2x11_vip.c | 1134 ++--- 1 file modificato, 410 inserzioni(+), 724 rimozioni(-) diff --git a/drivers/media/video/sta2x11_vip.c b/drivers/media/video/sta2x11_vip.c index 4c10205

Re: [PATCH 1/3] [media] adv7180: remove {query/g_/s_}ctrl

2012-07-31 Thread Federico Vaga
I'm sorry for the email duplication, I press the wrong key on git-send email. Ignore these emails. Sorry -- Federico Vaga -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordom

Re: Update VIP to videobuf2 and control framework

2012-07-31 Thread Federico Vaga
I use git send-email command to send patches but I think I made a mistake. If something is wrong or confused please tell me and I try to resend all the patches hopefully without mistake. Sorry again. 2012/7/31 Federico Vaga : > As suggested I moved the Video Buffer Input (VIP) of the STA2

[PATCH v2 3/4] sta2x11_vip: convert to videobuf2 and control framework

2012-09-21 Thread federico . vaga
From: Federico Vaga This patch re-write the driver and use the videobuf2 interface instead of the old videobuf. Moreover, it uses also the control framework which allows the driver to inherit controls from its subdevice (ADV7180) Signed-off-by: Federico Vaga Acked-by: Giancarlo Asnaghi

[PATCH 1/4] v4l: vb2: add prepare/finish callbacks to allocators

2012-09-21 Thread Federico Vaga
This patch adds support for prepare/finish callbacks in VB2 allocators. These callback are used for buffer flushing. Signed-off-by: Marek Szyprowski Acked-by: Laurent Pinchart Acked-by: Federico Vaga --- drivers/media/v4l2-core/videobuf2-core.c | 11 +++ include/media/videobuf2-core.h

[PATCH v2 2/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-09-21 Thread Federico Vaga
: Federico Vaga --- drivers/media/v4l2-core/Kconfig | 5 + drivers/media/v4l2-core/Makefile | 1 + drivers/media/v4l2-core/videobuf2-dma-streaming.c | 205 ++ include/media/videobuf2-dma-streaming.h | 32 4 file modificati, 243

[PATCH v2 3/4] sta2x11_vip: convert to videobuf2 and control framework

2012-09-21 Thread Federico Vaga
This patch re-write the driver and use the videobuf2 interface instead of the old videobuf. Moreover, it uses also the control framework which allows the driver to inherit controls from its subdevice (ADV7180) Signed-off-by: Federico Vaga Acked-by: Giancarlo Asnaghi --- drivers/media/pci

[PATCH v2 4/4] adv7180: remove {query/g_/s_}ctrl

2012-09-21 Thread Federico Vaga
All drivers which use this subdevice use also the control framework. The v4l2_subdev_core_ops operations {query/g_/s_}ctrl are useless because device drivers will inherit the controls from this subdevice. Signed-off-by: Federico Vaga --- drivers/media/i2c/adv7180.c | 3 --- 1 file modificato, 3

Re: [PATCH 1/4] v4l: vb2: add prepare/finish callbacks to allocators

2012-09-21 Thread Federico Vaga
rated in the kernel before this one; so this patch will be useless. Anyway, I will apply this comment fix. -- Federico Vaga -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vge

Re: [PATCH v2 3/4] sta2x11_vip: convert to videobuf2 and control framework

2012-09-23 Thread Federico Vaga
/* Buffer handlers */ > > + .vidioc_reqbufs = vb2_ioctl_reqbufs, > > + .vidioc_querybuf = vb2_ioctl_querybuf, > > + .vidioc_qbuf = vb2_ioctl_qbuf, > > + .vidioc_dqbuf = vb2_ioctl_dqbuf, > > + .vidioc_create_bufs = vb2_ioctl_create_bufs, > > If

[PATCH v3 1/4] v4l: vb2: add prepare/finish callbacks to allocators

2012-09-24 Thread Federico Vaga
This patch adds support for prepare/finish callbacks in VB2 allocators. These callback are used for buffer flushing. Signed-off-by: Marek Szyprowski Acked-by: Laurent Pinchart Acked-by: Federico Vaga --- drivers/media/v4l2-core/videobuf2-core.c | 11 +++ include/media/videobuf2-core.h

[PATCH v3 2/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-09-24 Thread Federico Vaga
: Federico Vaga --- drivers/media/v4l2-core/Kconfig | 5 + drivers/media/v4l2-core/Makefile | 1 + drivers/media/v4l2-core/videobuf2-dma-streaming.c | 205 ++ include/media/videobuf2-dma-streaming.h | 32 4 file modificati, 243

[PATCH v3 3/4] sta2x11_vip: convert to videobuf2 and control framework

2012-09-24 Thread Federico Vaga
This patch re-write the driver and use the videobuf2 interface instead of the old videobuf. Moreover, it uses also the control framework which allows the driver to inherit controls from its subdevice (ADV7180) Signed-off-by: Federico Vaga Acked-by: Giancarlo Asnaghi --- drivers/media/pci

[PATCH v3 4/4] adv7180: remove {query/g_/s_}ctrl

2012-09-24 Thread Federico Vaga
All drivers which use this subdevice use also the control framework. The v4l2_subdev_core_ops operations {query/g_/s_}ctrl are useless because device drivers will inherit controls from this subdevice. Signed-off-by: Federico Vaga --- drivers/media/i2c/adv7180.c | 3 --- 1 file modificato, 3

[PATCH v3 1/4] v4l: vb2: add prepare/finish callbacks to allocators

2012-09-25 Thread Federico Vaga
From: Marek Szyprowski This patch adds support for prepare/finish callbacks in VB2 allocators. These callback are used for buffer flushing. Signed-off-by: Marek Szyprowski Acked-by: Laurent Pinchart Acked-by: Federico Vaga --- drivers/media/v4l2-core/videobuf2-core.c | 11

Re: [PATCH v3 3/4] sta2x11_vip: convert to videobuf2 and control framework

2012-12-04 Thread Federico Vaga
On Tuesday 04 December 2012 14:15:15 Mauro Carvalho Chehab wrote: > Em 24-09-2012 07:58, Federico Vaga escreveu: > > This patch re-write the driver and use the videobuf2 > > interface instead of the old videobuf. Moreover, it uses also > > the control framework which allows

Re: [PATCH v3 3/4] sta2x11_vip: convert to videobuf2 and control framework

2012-12-05 Thread Federico Vaga
... Ok, I understand. I will write something like this. * Copyright (C) 2012 ST Microelectronics * author: Federico Vaga * Copyright (C) 2010 WindRiver Systems, Inc. * authors: Andreas Kies * Vlad Lungu > The only way of not preserving the origi

Re: [PATCH v3 2/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-12-05 Thread Federico Vaga
On Tuesday 04 December 2012 14:04:22 Mauro Carvalho Chehab wrote: > Em 24-09-2012 09:44, Marek Szyprowski escreveu: > > Hello, > > > > On Monday, September 24, 2012 12:59 PM Federico Vaga wrote: > >> The DMA streaming allocator is similar to the DMA contig but

Re: [PATCH v3 3/4] sta2x11_vip: convert to videobuf2 and control framework

2012-12-05 Thread Federico Vaga
> > Ok, I understand. I will write something like this. > > > > * Copyright (C) 2012 ST Microelectronics > > * author: Federico Vaga > > * Copyright (C) 2010 WindRiver Systems, Inc. > > * authors: Andreas Kies > > *

Re: [PATCH v3 3/4] sta2x11_vip: convert to videobuf2 and control framework

2012-12-05 Thread Federico Vaga
we need to handle it with due care. Getting other authors's > acks on such patch seems to be the only safe way of doing that. Yes I got the point. Thank you -- Federico Vaga -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a messa

[PATCH v3 3/4] sta2x11_vip: convert to videobuf2 and control framework

2012-12-06 Thread Federico Vaga
This patch re-write the driver and use the videobuf2 interface instead of the old videobuf. Moreover, it uses also the control framework which allows the driver to inherit controls from its subdevice (ADV7180) Signed-off-by: Federico Vaga Acked-by: Giancarlo Asnaghi --- drivers/media/pci

Re: [PATCH v3 2/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-12-11 Thread Federico Vaga
rface, it is not a performance problem. > On a separate but related issue, while doing DMABUF tests with an Exynos4 > hardware, using a s5p sensor, sending data to s5p-tv, I noticed a CPU > consumption of about 42%, which seems too high. Could it be related to > not using the DMA streaming A

Re: [PATCH v3 2/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2013-01-03 Thread Federico Vaga
/for_v3.9 > branch of the media-tree? I will do it -- Federico Vaga -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v3 2/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2013-01-04 Thread Federico Vaga
On Thursday 03 January 2013 17:13:14 Federico Vaga wrote: > > After all those discussions, I'm ok on adding this new driver, but please > > add a summary of those discussions at the patch description. As I said, > > the reason why this driver is needed is not obvious. So,

Re: [PATCH RFC] spidev.c: add sysfs attributes for SPI configuration

2012-12-20 Thread Federico Vaga
nderstand; what is the advantage of ioctl through char device? Or what it the issue with sysfs? Thank you very much -- Federico Vaga -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majo

Re: [PATCH v3 2/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-12-20 Thread Federico Vaga
board, but they cannot help me. -- Federico Vaga -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH RFC] spidev.c: add sysfs attributes for SPI configuration

2012-12-22 Thread Federico Vaga
fs with well known programs (echo, cat, hexdump, od) and oscilloscope. I know that I'm not so persuasive :) I can develop a simple program that can write custom tx buf with ioctl -- Federico Vaga -- To unsubscribe from this list: send the line "unsubscribe linux-kernel&quo

DWC2 and/or S3C-HSOTG for STA2X11 board

2013-07-16 Thread Federico Vaga
work in progress right now (soon), so it is better to wait after the merge? In order to use the s3c-hsotg I must implement a PCI wrapper that uses this driver. It will be accepted in the kernel even if it will be removed sooner or later because of the driver merge? Thank you :) -- Federico Vaga

Re: DWC2 and/or S3C-HSOTG for STA2X11 board

2013-07-16 Thread Federico Vaga
Thank you Felipe [add CC Giancarlo from ST] On Tuesday 16 July 2013 15:04:25 Felipe Balbi wrote: > Hi, > > On Tue, Jul 16, 2013 at 02:01:33PM +0200, Federico Vaga wrote: > > Hello, > > > > I have an x86 board made by STMicroelectronics (STA2X11) with the Synopsis >

Re: DWC2 and/or S3C-HSOTG for STA2X11 board

2013-07-22 Thread Federico Vaga
th wrapper (PCI, platform), but I do not know how much time does it takes because I am really busy at the moment You know the hardware better than me, so: have you other suggestion to point me on the right way? Thank you :) -- Federico Vaga -- To unsubscribe from this list: send the line "uns

[PATCH] dwc2/pci.c: add STMICRO vendor and device ID for STA2X11 board

2013-05-13 Thread Federico Vaga
Signed-off-by: Federico Vaga Acked-by: Giancarlo Asnaghi --- drivers/staging/dwc2/pci.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/staging/dwc2/pci.c b/drivers/staging/dwc2/pci.c index 69c65eb..7029b9f 100644 --- a/drivers/staging/dwc2/pci.c +++ b/drivers/staging/dwc2/pci.c

[RFC] assign some address families for local use

2013-05-16 Thread Federico Vaga
I attached to this email the patch that do these stuff. -- Federico Vaga>From 8ce4f2576aa8e95ea22921c31bdffd049460951d Mon Sep 17 00:00:00 2001 From: Federico Vaga Date: Wed, 15 May 2013 12:32:03 +0200 Subject: [PATCH] include/linux/socket.h: assign address families for local use The patch ass

drivers/base/core.c: about device_find_child() function

2013-04-11 Thread Federico Vaga
etric names: get_device_child() and put_device(). If the driver do not need to get_device() on a child device, it simply does a device_search_child() to retrieve a pointer. -- Federico Vaga -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a me

[PATCH] base/core.c: improve comment of the function device_find_child()

2013-04-12 Thread Federico Vaga
Signed-off-by: Federico Vaga --- drivers/base/core.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/base/core.c b/drivers/base/core.c index 016312437..eb0c6ea 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -1372,6 +1372,10 @@ int device_for_each_child(struct

Re: drivers/base/core.c: about device_find_child() function

2013-04-12 Thread Federico Vaga
On Thursday 11 April 2013 06:48:44 Greg Kroah-Hartman wrote: > On Thu, Apr 11, 2013 at 01:52:36PM +0200, Federico Vaga wrote: > > Hello, > > > > I'm using the function device_find_child() [drivers/base/core.c] to > > retrieve a specific child of a device.

Re: [PATCH] base/core.c: improve comment of the function device_find_child()

2013-04-15 Thread Federico Vaga
On Friday 12 April 2013 14:51:25 Greg Kroah-Hartman wrote: > On Fri, Apr 12, 2013 at 01:59:32PM +0200, Federico Vaga wrote: > > Signed-off-by: Federico Vaga > > --- > > > > drivers/base/core.c | 4 > > 1 file changed, 4 insertions(+) > > > > di

Re: drivers/base/core.c: about device_find_child() function

2013-04-15 Thread Federico Vaga
So, (s)he does not need to put_device(). But I think that is not a strong argumentation, and later in time someone will propose his own special use of device_for_each_child(). I think that device_for_each_child() is generic enough to cover this problem. -- Federico Vaga -- To unsubscribe from

Re: drivers/base/core.c: about device_find_child() function

2013-04-15 Thread Federico Vaga
; > > if (!enable_irq_wake(uport->irq)) > > > > uport->irq_wake = 1; > > > > put_device(tty_dev); > > mutex_unlock(&port->mutex); > > return 0; > >

[PATCH v2] base/core.c: improve comment of the function device_find_child()

2013-04-15 Thread Federico Vaga
Signed-off-by: Federico Vaga --- drivers/base/core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/base/core.c b/drivers/base/core.c index 016312437..3c8512f 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -1372,6 +1372,8 @@ int device_for_each_child(struct device

[PATCH] serial_core.c: add put_device() after device_find_child()

2013-04-15 Thread Federico Vaga
The serial core uses device_find_child() but does not drop the reference to the retrieved child after using it. This patch add the missing put_device(). Signed-off-by: Federico Vaga --- What I have done to test this issue. I used a machine with an AMBA PL011 serial driver. I tested the patch

[RFC PATCH] sparc/kernel/vio.c: add put_device() after device_find_child()

2013-04-15 Thread Federico Vaga
The vio_remove() function uses device_find_child() but it does not drop the reference of the retrieved child. Signed-off-by: Federico Vaga --- I do not have a SPARC system (and I do not know it), so I cannot test this patch. Please test it. If I'm right, the device_unregister() does not

[PATCH] net/core/sock.c: add missing VSOCK string in af_family_*_key_strings

2013-05-28 Thread Federico Vaga
The three arrays of strings: af_family_kay_strings, af_family_slock_key_strings and af_family_clock_key_strings have not VSOCK's string Signed-off-by: Federico Vaga --- net/core/sock.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/core/sock.c b/net/core/s

Re: Update VIP to videobuf2 and control framework

2012-08-05 Thread Federico Vaga
ers use the core priority handling. But for now it has to be set explicitly. -- -- Federico Vaga -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: Update VIP to videobuf2 and control framework

2012-08-06 Thread Federico Vaga
hat > > you use struct v4l2_fh. > > ^^ > > Are you using struct v4l2_fh? The version you posted didn't. You need > this anyway to implement control events. Yes I'm using it now, it is part of the extra simplification that I did. -- Federico Vaga -- To unsubscribe from this

[PATCH 3/3 v2] [media] sta2x11_vip: convert to videobuf2 and control framework

2012-08-06 Thread Federico Vaga
Signed-off-by: Federico Vaga Acked-by: Giancarlo Asnaghi --- drivers/media/video/sta2x11_vip.c | 1239 + 1 file modificato, 414 inserzioni(+), 825 rimozioni(-) diff --git a/drivers/media/video/sta2x11_vip.c b/drivers/media/video/sta2x11_vip.c index 4c10205

Re: Update VIP to videobuf2 and control framework

2012-08-06 Thread Federico Vaga
> In that case I need to see your latest version of the source code to > see why it doesn't work. I send it as patch v2 of the previous one -- Federico Vaga -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...

Re: [PATCH 3/3 v2] [media] sta2x11_vip: convert to videobuf2 and control framework

2012-08-06 Thread Federico Vaga
ags); > > No need to set V4L2_FL_USES_V4L2_FH, BTW. That will be set > automatically as soon as v4l2_fh_open is called. I saw "unsigned long flags;" in the header but without reading the comment :) Thank you. I will test it in these days but I think it's all done. -- Fede

Re: [PATCH 2/3] [media] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-08-24 Thread Federico Vaga
esting because avoid me to use cache sync in my driver. Can I work on these patches? >From this page I understand that these patches are not approved yet https://patchwork.kernel.org/project/linux-media/list/?page=2 -- Federico Vaga -- To unsubscribe from this list: send the line "unsu

Re: [PATCH 2/3] [media] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-08-24 Thread Federico Vaga
k you. I'll do the job -- Federico Vaga -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: Update VIP to videobuf2 and control framework

2012-08-16 Thread Federico Vaga
; jon I think that the memory allocator is the most questionable patch, but if there are not any other comments I will send my three patches for the inclusion. It is summer, time for vacation, so I'll wait for another week or two for critical comments and then I will send patches. -- F

[PATCH RFC] [media] adv7180.c: convert to v4l2 control framework

2012-07-10 Thread Federico Vaga
Signed-off-by: Federico Vaga --- drivers/media/video/adv7180.c | 221 + 1 file changed, 90 insertions(+), 131 deletions(-) diff --git a/drivers/media/video/adv7180.c b/drivers/media/video/adv7180.c index 174bffa..7705456 100644 --- a/drivers/media/video

Re: [PATCH RFC] [media] adv7180.c: convert to v4l2 control framework

2012-07-11 Thread Federico Vaga
-controls.txt document. Right? > > - ret = i2c_smbus_write_byte_data(client, ADV7180_HUE_REG, > > state->hue); + ret = i2c_smbus_write_byte_data(client, > > ADV7180_HUE_REG, > > + ADV7180_HUE_DEF); > > It shouldn't be necessary to initialize the controls s

Re: [PATCH RFC] [media] adv7180.c: convert to v4l2 control framework

2012-07-11 Thread Federico Vaga
trols), so I think these lines must be there. Am I wrong? > > Correct. But once sta2x11 is converted to using the control framework, > then these lines can be dropped since no one else is using this > subdevice driver. What do you suggest? I re-submit this patch and when sta2x11 is f

[PATCH] [media] adv7180.c: convert to v4l2 control framework

2012-07-11 Thread Federico Vaga
Signed-off-by: Federico Vaga --- drivers/media/video/adv7180.c | 235 +++-- 1 file changed, 84 insertions(+), 151 deletions(-) diff --git a/drivers/media/video/adv7180.c b/drivers/media/video/adv7180.c index 174bffa..07bb550 100644 --- a/drivers/media/video

[PATCH v6 1/2] sta2x11_vip: convert to videobuf2, control framework, file handler

2013-01-23 Thread Federico Vaga
ones from videobuf2 and v4l2_fh Signed-off-by: Federico Vaga Acked-by: Giancarlo Asnaghi --- drivers/media/pci/sta2x11/Kconfig |2 +- drivers/media/pci/sta2x11/sta2x11_vip.c | 1071 +-- 2 file modificati, 432 inserzioni(+), 641 rimozioni(-) diff --git a

[PATCH v6 2/2] adv7180: remove {query/g_/s_}ctrl

2013-01-23 Thread Federico Vaga
All drivers which use this subdevice use also the control framework. The v4l2_subdev_core_ops operations {query/g_/s_}ctrl are useless because device drivers will inherit controls from this subdevice. Signed-off-by: Federico Vaga --- drivers/media/i2c/adv7180.c | 3 --- 1 file modificato, 3

[PATCH RFC] spidev.c: add sysfs attributes for SPI configuration

2012-11-24 Thread Federico Vaga
; csr0 dd02 spidev spi1.0: setup mode 0, 8 bits/w, 45 Hz max --> 0 spidev spi1.0: 45 Hz (max) Signed-off-by: Federico Vaga --- drivers/spi/spidev.c | 258 +-- 1 file modificato, 208 inserzioni(+), 50 rimozioni(-) diff --git

Re: [GIT PULL FOR v3.5] Move sta2x11_vip to staging

2012-07-08 Thread Federico Vaga
> Any news on this? Hi Hans, I'm on it :) -- Federico Vaga -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please rea

Re: [PATCH 1/3] adv7180: add support to user controls

2012-07-08 Thread Federico Vaga
> If you could do that work, then that would be much appreciated. You have the > hardware, after all, so that makes it easier for you. Hi Hans, I'll submit a patch for the control framework on the ADV7180 -- Federico Vaga -- To unsubscribe from this list: send the line "u

Re: [PATCH v3 2/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2013-01-06 Thread Federico Vaga
V4 patches soon. -- Federico Vaga -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH v4 1/3] videobuf2-dma-contig: user can specify GFP flags

2013-01-06 Thread Federico Vaga
This is useful when you need to specify specific GFP flags during memory allocation (e.g. GFP_DMA). Signed-off-by: Federico Vaga --- drivers/media/v4l2-core/videobuf2-dma-contig.c | 7 ++- include/media/videobuf2-dma-contig.h | 5 + 2 file modificati, 7 inserzioni(+), 5

[PATCH V4 2/3] sta2x11_vip: convert to videobuf2 and control framework

2013-01-06 Thread Federico Vaga
This patch re-write the driver and use the videobuf2 interface instead of the old videobuf. Moreover, it uses also the control framework which allows the driver to inherit controls from its subdevice (ADV7180) Signed-off-by: Federico Vaga Acked-by: Giancarlo Asnaghi --- drivers/media/pci

[PATCH V4 3/3] adv7180: remove {query/g_/s_}ctrl

2013-01-06 Thread Federico Vaga
All drivers which use this subdevice use also the control framework. The v4l2_subdev_core_ops operations {query/g_/s_}ctrl are useless because device drivers will inherit controls from this subdevice. Signed-off-by: Federico Vaga --- drivers/media/i2c/adv7180.c | 3 --- 1 file modificato, 3

Re: [PATCH v4 1/3] videobuf2-dma-contig: user can specify GFP flags

2013-01-08 Thread Federico Vaga
ake something in the future. On x86 platform GFP_DMA allocates under 16MB and this limit can be too strict. When many other drivers use GFP_DMA we can saturate this tiny zone. As you said, this fix the issue with _older_ and _non-standard_ (like sta2x11) systems. But this fix has effect on every

Re: [PATCH v4 1/3] videobuf2-dma-contig: user can specify GFP flags

2013-01-08 Thread Federico Vaga
me vb2_dc_conf to vb2_alloc_ctx because it is an implementation vb2_alloc_ctx and (at the moment) it is used only by dma-contig -- Federico Vaga -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

fpga: fpga_mgr_get() buggy ?

2018-06-21 Thread Federico Vaga
Hello, I believe that this patch fpga: manager: change api, don't use drvdata 7085e2a94f7df5f419e3cfb2fe809ce6564e9629 is incomplete and buggy. I completely agree that drvdata should not be used by the FPGA manager or any other subsystem like that. What is buggy is the function fpga_mgr_get()

Re: fpga: fpga_mgr_get() buggy ?

2018-06-22 Thread Federico Vaga
Hi Alan, inline comments On Friday, 22 June 2018 04:07:41 CEST Alan Tull wrote: > On Thu, Jun 21, 2018 at 8:13 AM, Federico Vaga > wrote: > > Hi Federico, > > Thanks for the analysis. I'll probably not be able to look into > this very much until next week. A few

[PATCH 2/3] i2c:ocores: do not handle IRQ if IF is not set

2018-06-25 Thread Federico Vaga
If the Interrupt Flag (IF) is not set, we should not handle the IRQ: - the line can be shared with other devices - it can be a spurious interrupt To avoid reading twice the status register, the ocores_process() function expects it to be read by the caller. Signed-off-by: Federico Vaga

[PATCH 3/3] i2c:ocores: add polling interface

2018-06-25 Thread Federico Vaga
This driver assumes that an interrupt line is always available for the I2C master. This is not always the case and this patch adds support for a polling version based on workqueue. Signed-off-by: Federico Vaga --- drivers/i2c/busses/i2c-ocores.c | 94 ++--- 1

Re: i2c:ocores: fixes and polling mechanism

2018-08-11 Thread Federico Vaga
Hello, sorry to disturb you all but after one month and a half I never received any comment about this patch set and I fear it ended up in a forgotten corner. I would like to know if someone is considering it or not. Thanks :) On Monday, June 25, 2018 6:13:00 PM CEST Federico Vaga wrote

Re: [PATCH 1/2] fpga: Document when fpga_blah_free functions should be used

2018-07-26 Thread Federico Vaga
successfully registered, it > would be a bug to call fpga_(mgr|bridge|region)_free. > > Signed-off-by: Alan Tull > Suggested-by: Florian Fainelli > Suggested-by: Federico Vaga > --- > drivers/fpga/fpga-bridge.c | 10 +- > drivers/fpga/fpga-mgr.c|

Re: fpga: fpga_mgr_free usage

2018-07-26 Thread Federico Vaga
On Wednesday, July 25, 2018 6:33:44 PM CEST Alan Tull wrote: > On Wed, Jul 11, 2018 at 10:59 AM, Alan Tull wrote: > > On Wed, Jul 11, 2018 at 7:38 AM, Federico Vaga > > wrote: > > > > Hi Federico, > > > >> Hi Alan, > >> > >> I have

Re: fpga: fpga_mgr_get() buggy ?

2018-07-18 Thread Federico Vaga
Hi Alan, Thanks for your time, comments below On Wednesday, July 18, 2018 9:47:24 PM CEST Alan Tull wrote: > On Thu, Jun 28, 2018 at 2:50 AM, Federico Vaga wrote: > > On Wednesday, 27 June 2018 23:23:07 CEST Alan Tull wrote: > >> On Wed, Jun 27, 2018 at 4:25 AM, Federico Va

[PATCH 1/2] doc:process: add links where missing

2018-11-20 Thread Federico Vaga
Some documents are refering to others without links. With this patch I add those missing links. This patch affects only documents under process/ and labels where necessary. Signed-off-by: Federico Vaga --- Documentation/admin-guide/devices.rst| 1 + Documentation/dev-tools

fpga: fpga_mgr_free usage

2018-07-11 Thread Federico Vaga
Hi Alan, I have another point that I would like to discuss. It is about the usage of 'fpga_mgr_free()' which does not look like consistent. This function, according to the current implementation, can be used by an FPGA manager user and it is used by the FPGA manager itself on device release. T

i2c:ocores: fixes and polling mechanism

2018-06-25 Thread Federico Vaga
The first two patches fix what I believe are bugs. The third patch add a polling mechanism for those systems where interrupts are not available. All these patches have been tested on a system without interrupt, this means that I used my third patch to validate also the other two. I would be nice

[PATCH 1/3] i2c:ocores: stop transfer on timeout

2018-06-25 Thread Federico Vaga
is taken is because we are in timeout, so there is no need to process the IRQ. Signed-off-by: Federico Vaga --- drivers/i2c/busses/i2c-ocores.c | 28 ++-- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-ocores.c b/drivers/i2c/busses/i2c

Re: fpga: fpga_mgr_get() buggy ?

2018-06-27 Thread Federico Vaga
Hi Alan, On Tuesday, 26 June 2018 23:00:46 CEST Alan Tull wrote: > On Fri, Jun 22, 2018 at 2:53 AM, Federico Vaga > wrote: > > Hi Federico, > > >> > What is buggy is the function fpga_mgr_get(). > >> > That patch has been done to allow multiple FPGA manag

Re: fpga: fpga_mgr_get() buggy ?

2018-06-28 Thread Federico Vaga
On Wednesday, 27 June 2018 23:23:07 CEST Alan Tull wrote: > On Wed, Jun 27, 2018 at 4:25 AM, Federico Vaga wrote: > > Hi Alan, > > > > On Tuesday, 26 June 2018 23:00:46 CEST Alan Tull wrote: > >> On Fri, Jun 22, 2018 at 2:53 AM, Federico Vaga >

[PATCH 1/5] doc: typos and minor fixes

2018-05-27 Thread Federico Vaga
Signed-off-by: Federico Vaga --- Documentation/doc-guide/kernel-doc.rst| 2 +- Documentation/doc-guide/parse-headers.rst | 4 ++-- Documentation/doc-guide/sphinx.rst| 4 ++-- Documentation/index.rst | 2 +- Documentation/sphinx/parse-headers.pl | 2 +- 5 files

[PATCH 2/5] doc: add chapter labels

2018-05-27 Thread Federico Vaga
The idea is to make it easier to create references (doc-guide does the same). Signed-off-by: Federico Vaga --- Documentation/index.rst| 2 ++ Documentation/kernel-hacking/index.rst | 2 ++ 2 files changed, 4 insertions(+) diff --git a/Documentation/index.rst b/Documentation

doc: Italian translation

2018-05-27 Thread Federico Vaga
Ciao Jonathan, here the doc-guide translated in Italian. This set of patches includes some minor changes to the main one. The idea of this first set of patches is also to adjust the structure and our expectations. We tried to translate everything in **Italian**; which means that we avoided import

[PATCH 3/5] doc: add Italian translation skeleton

2018-05-27 Thread Federico Vaga
Signed-off-by: Federico Vaga Signed-off-by: Alessia Mantegazza --- Documentation/index.rst| 8 ++ .../translations/it_IT/disclaimer-ita.rst | 11 +++ Documentation/translations/it_IT/index.rst | 101 + 3 files changed, 120

[PATCH 4/5] doc:it_IT: add doc-guide translation

2018-05-27 Thread Federico Vaga
Signed-off-by: Federico Vaga Signed-off-by: Alessia Mantegazza --- .../translations/it_IT/doc-guide/hello.dot | 3 + .../translations/it_IT/doc-guide/index.rst | 24 ++ .../translations/it_IT/doc-guide/kernel-doc.rst| 402 ++ .../translations/it_IT/doc

[PATCH] i2c: ocores: update HDL sources URL

2018-05-28 Thread Federico Vaga
The URL is broken. This patch fix it Signed-off-by: Federico Vaga --- drivers/i2c/busses/i2c-ocores.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-ocores.c b/drivers/i2c/busses/i2c-ocores.c index 8c42ca7107b2..14c5f6bbfd95 100644 --- a/drivers/i2c

  1   2   3   >