[PATCH v2] PCI / PM: Always check PME wakeup capability for runtime wakeup support

2018-03-19 Thread Kai-Heng Feng
_info") Cc: sta...@vger.kernel.org # 4.13+ Signed-off-by: Kai-Heng Feng --- v2: Explicitly check dev->pme_support. drivers/pci/pci.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index f6a4dd10d9b0..52821a21fc07 100644 --- a/

[PATCH v7] usb: core: Add "quirks" parameter for usbcore

2018-03-19 Thread Kai-Heng Feng
troduce this new "dynamic" function. Now users can use "usbcore.quirks=" as short term workaround before the next kernel release. Also, the quirk parameter can XOR the builtin quirks for debugging purpose. This is inspired by usbhid and usb-storage. Signed-off-by: Kai-Heng F

Re: [PATCH v2] Input: i8042 - Fix KBD port cannot wake up system from suspend-to-idle

2018-05-04 Thread Kai Heng Feng
Hi Dmitry, On Apr 19, 2018, at 4:49 PM, Kai-Heng Feng wrote: From: Kai Heng Feng Commit f13b2065de81 ("Input: i8042 - allow KBD and AUX ports to wake up from suspend-to-idle") make system in s2idle can be woken up by i8042 keyboard, but it's disabled by default. In comm

Re: [PATCH v3] PCI / PM: Always check PME wakeup capability for runtime wakeup support

2018-05-04 Thread Kai Heng Feng
Hi Rafael, On Apr 26, 2018, at 10:36 PM, Rafael J. Wysocki wrote: On Thursday, April 26, 2018 3:55:45 PM CEST Bjorn Helgaas wrote: On Fri, Apr 13, 2018 at 09:29:56AM +0200, Rafael J. Wysocki wrote: On Friday, April 13, 2018 8:58:11 AM CEST Kai Heng Feng wrote: Hi Bjorn and Rafael, On Apr

[PATCH v2] platform/x86: dell-wmi: Ignore new rfkill and fn-lock events

2018-04-20 Thread Kai-Heng Feng
with type 0x0010 and code 0xe008 pressed These events are for notification purpose, so we can ignore them. This patch is tested on XPS 9370. Signed-off-by: Kai-Heng Feng --- v2: Reorder alphabetically. More detailed changelog. drivers/platform/x86/dell-wmi.c | 14 ++ 1 file

[PATCH v4 1/3] dell-led: Change dell-led.h to dell-common.h

2018-04-20 Thread Kai-Heng Feng
This header will be used for more than just led. Change it to a more generic name. Cc: Mario Limonciello Signed-off-by: Kai-Heng Feng --- v4: Change the commit message to clarify there's no more runtime pm warning. Also skip the check for thunderbolt attached devices. v3: Sim

[PATCH v4 3/3] ALSA: hda: Disabled unused audio controller for Dell platforms with Switchable Graphics

2018-04-20 Thread Kai-Heng Feng
the stream, it hangs the system. Since the discrete audio controller isn't useful when SG is enabled, we should just disable the device. Signed-off-by: Kai-Heng Feng --- v4: Change the commit message to clarify there's no more runtime pm warning. Also skip the check for thu

[PATCH v4 2/3] platform/x86: dell-*: Add interface for switchable graphics status query

2018-04-20 Thread Kai-Heng Feng
On some Dell platforms, there's a BIOS option "Enable Switchable Graphics". This information is useful if we want to do different things based on this value, e.g. disable unused audio controller that comes with the discrete graphics. Cc: Mario Limonciello Signed-off-by: Kai-He

Re: tg3 crashes under high load, when using 100Mbits

2018-04-14 Thread Kai-Heng Feng
Hi Satish, > On 2018Mar21, at 00:57, Kai-Heng Feng wrote: > > Satish Baddipadige wrote: > >> On Thu, Feb 15, 2018 at 7:37 PM, Siva Reddy Kallam >> wrote: >>> On Mon, Feb 12, 2018 at 10:59 AM, Siva Reddy Kallam >>> wrote: >>>> On F

Re: [PATCH] Input: i8042 - Fix KBD port cannot wake up system from suspend-to-idle

2018-04-16 Thread Kai-Heng Feng
at 5:57 AM, Dmitry Torokhov wrote: On Wed, Apr 11, 2018 at 04:59:05PM +0800, Kai-Heng Feng wrote: Commit f13b2065de81 ("Input: i8042 - allow KBD and AUX ports to wake up from suspend-to-idle") make system in s2idle can be woken up by i8042 keyboard, but it's disabled by defa

Re: [PATCH] media: uvcvideo: Support realtek's UVC 1.5 device

2018-05-10 Thread Kai-Heng Feng
the UVC 1.5 Realtek RTS5847/RTS5852 cameras have been reported to work well. I think this should also Cc: stable. Tested-by: Kai-Heng Feng Signed-off-by: ming_qian --- drivers/media/usb/uvc/uvc_video.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/media/usb/uvc

[PATCH v4] PCI / PM: Always check PME wakeup capability for runtime wakeup support

2018-05-06 Thread Kai-Heng Feng
se to true, because we want to find the deepest state that the device can still generate PME#. In this case, it's D0 for the device in question. Fixes: de3ef1eb1cd0 ("PM / core: Drop run_wake flag from struct dev_pm_info") Cc: sta...@vger.kernel.org # 4.13+ Signed-off-by: Kai-Heng F

[PATCH] platform/x86: dell-wmi: Ignore new rfkill and fn-lock events

2018-04-19 Thread Kai-Heng Feng
There are two new events generated by dell-wmi, rfkill and fn-lock, from Dell Systems. These events are for notification purpose, so we can ignore them. Tested on XPS 9370. Signed-off-by: Kai-Heng Feng --- I ordered them functionally instead of alphabetically, I can re-order them to

Re: [PATCH] platform/x86: dell-wmi: Ignore new rfkill and fn-lock events

2018-04-19 Thread Kai Heng Feng
On Apr 19, 2018, at 3:46 PM, Pali Rohár wrote: On Thursday 19 April 2018 15:24:49 Kai-Heng Feng wrote: There are two new events generated by dell-wmi, rfkill and fn-lock, from Dell Systems. These events are for notification purpose, so we can ignore them. Tested on XPS 9370. Signed-off-by

[PATCH v2] Input: i8042 - Fix KBD port cannot wake up system from suspend-to-idle

2018-04-19 Thread Kai-Heng Feng
From: Kai Heng Feng Commit f13b2065de81 ("Input: i8042 - allow KBD and AUX ports to wake up from suspend-to-idle") make system in s2idle can be woken up by i8042 keyboard, but it's disabled by default. In commit 3e6e15a862a0 ("Input: enable remote wakeup for PNP i8042 key

Re: [PATCH] usbnet: prevent device rpm suspend in usbnet_probe function

2016-11-07 Thread Kai-Heng Feng
Hi, On Mon, Nov 7, 2016 at 7:02 PM, Oliver Neukum wrote: > On Fri, 2016-11-04 at 17:57 +0800, Kai-Heng Feng wrote: >> Sometimes cdc_mbim failed to probe if runtime pm is enabled: >> [9.305626] cdc_mbim: probe of 2-2:1.12 failed with error -22 >> >> This can be solv

Re: [PATCH] usbnet: prevent device rpm suspend in usbnet_probe function

2016-11-16 Thread Kai-Heng Feng
On Mon, Nov 14, 2016 at 3:34 PM, Kai-Heng Feng wrote: > On Fri, Nov 11, 2016 at 10:44 PM, Mathias Nyman > wrote: >> On 10.11.2016 13:22, Oliver Neukum wrote: >>> >>> On Thu, 2016-11-10 at 12:09 +0100, Bjørn Mork wrote: >>>> >>>> Kai-Heng Fe

Re: [PATCH] usbnet: prevent device rpm suspend in usbnet_probe function

2016-11-09 Thread Kai-Heng Feng
Hi, On Wed, Nov 9, 2016 at 8:32 PM, Bjørn Mork wrote: > Oliver Neukum writes: > >> On Tue, 2016-11-08 at 13:44 -0500, Alan Stern wrote: >> >>> These problems could very well be caused by running at SuperSpeed >>> (USB-3) instead of high speed (USB-2). Yes, it's running at SuperSpeed, on a Kabyl

Re: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

2017-03-21 Thread Kai-Heng Feng
On Tue, Mar 21, 2017 at 4:59 PM, Bard Liao wrote: >> -Original Message- >> From: Kai-Heng Feng [mailto:kai.heng.f...@canonical.com] >> Sent: Tuesday, March 21, 2017 1:39 PM >> To: Bard Liao >> Cc: broo...@kernel.org; lgirdw...@gmail.com; Oder Chiou; >>

Re: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

2017-03-21 Thread Kai-Heng Feng
On Tue, Mar 21, 2017 at 5:15 PM, Bard Liao wrote: >> -Original Message- >> From: Kai-Heng Feng [mailto:kai.heng.f...@canonical.com] >> Sent: Tuesday, March 21, 2017 1:26 PM >> To: Mark Brown >> Cc: Liam Girdwood; Bard Liao; Oder Chiou; alsa-de...@als

Re: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

2017-03-22 Thread Kai-Heng Feng
[snip] > Let me explain it in more detail. rt5670 need to set a serious of > registers to prevent the pop noise of powering up/down muting/ > unmuting headphone. That's what rt5670_hp_event() does. But, > what rt286_hp_power_event do is only mute/unmute headphone > which is done by "HPO L" and "HP

[PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

2017-03-19 Thread Kai-Heng Feng
k: https://bugzilla.kernel.org/show_bug.cgi?id=112611 Link: https://bugzilla.redhat.com/show_bug.cgi?id=1313434 Signed-off-by: Kai-Heng Feng --- sound/soc/codecs/rt286.c | 48 +--- 1 file changed, 45 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/rt

Re: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

2017-03-20 Thread Kai-Heng Feng
On Tue, Mar 21, 2017 at 12:06 AM, Mark Brown wrote: > On Mon, Mar 20, 2017 at 03:46:13PM +0000, Kai-Heng Feng wrote: >> On Mon, Mar 20, 2017 at 11:08 PM Mark Brown wrote: > >> > As covered in SubmittingPatches this should come after the ---, it >> > doesn'

Re: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

2017-03-20 Thread Kai-Heng Feng
On Tue, Mar 21, 2017 at 1:26 AM, Mark Brown wrote: > On Tue, Mar 21, 2017 at 12:23:53AM +0800, Kai-Heng Feng wrote: >> On Tue, Mar 21, 2017 at 12:06 AM, Mark Brown wrote: > >> > As it says there "...and inserted automatically following the three dash >> > line&

Re: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

2017-03-20 Thread Kai-Heng Feng
On Tue, Mar 21, 2017 at 11:07 AM, Bard Liao wrote: >> -Original Message- >> From: Kai-Heng Feng [mailto:kai.heng.f...@canonical.com] >> Sent: Monday, March 20, 2017 11:59 AM >> To: broo...@kernel.org >> Cc: lgirdw...@gmail.com; Bard Liao; Oder Chiou; >>

[PATCH v2] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

2017-03-16 Thread Kai-Heng Feng
or plug a headphone in will produce a loud crack sound. Set AMP_OUT_MUTE before power events can make the noise less noticeable. Link: https://bugzilla.kernel.org/show_bug.cgi?id=112611 Link: https://bugzilla.redhat.com/show_bug.cgi?id=1313434 Signed-off-by: Kai-Heng Feng --- sound/soc

[PATCH] Input: i8042 - add noloop quirk for Dell Embedded Box PC 3000

2017-03-06 Thread Kai-Heng Feng
The aux port does not get detected without noloop quirk, so external PS/2 mouse cannot work as result. The PS/2 mouse can work with this quirk. BugLink: https://bugs.launchpad.net/bugs/1591053 Signed-off-by: Kai-Heng Feng --- drivers/input/serio/i8042-x86ia64io.h | 7 +++ 1 file changed, 7

[PATCH] usbnet: prevent device rpm suspend in usbnet_probe function

2016-11-04 Thread Kai-Heng Feng
Sometimes cdc_mbim failed to probe if runtime pm is enabled: [9.305626] cdc_mbim: probe of 2-2:1.12 failed with error -22 This can be solved by increase its pm usage counter. Signed-off-by: Kai-Heng Feng --- drivers/net/usb/usbnet.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion

[PATCH] ALSA: hda - Enable subwoofer on Dell Inspiron 7559

2016-08-29 Thread Kai-Heng Feng
The subwoofer on Inspiron 7559 does not work originally. Applying a pin fixup can make it work. Signed-off-by: Kai-Heng Feng --- sound/pci/hda/patch_realtek.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index

Re: [PATCH] ALSA: hda - Enable subwoofer on Dell Inspiron 7559

2016-08-29 Thread Kai Heng Feng
On Tue, Aug 30, 2016 at 1:33 PM, Takashi Iwai wrote: > On Tue, 30 Aug 2016 07:27:41 +0200, > Kai-Heng Feng wrote: >> >> The subwoofer on Inspiron 7559 does not work originally. >> Applying a pin fixup can make it work. >> >> Signed-off-by: Kai-Heng Feng >

Re: [PATCH] ALSA: hda - Enable subwoofer on Dell Inspiron 7559

2016-08-30 Thread Kai Heng Feng
On Tue, Aug 30, 2016 at 3:05 PM, Takashi Iwai wrote: > On Tue, 30 Aug 2016 08:25:18 +0200, > Kai Heng Feng wrote: >> >> On Tue, Aug 30, 2016 at 1:33 PM, Takashi Iwai wrote: >> > On Tue, 30 Aug 2016 07:27:41 +0200, >> > Kai-Heng Feng wrote: >> >> &g

[PATCH v2] ALSA: hda - Enable subwoofer on Dell Inspiron 7559

2016-08-30 Thread Kai-Heng Feng
The subwoofer on Inspiron 7559 was disabled originally. Applying a pin fixup to node 0x1b can enable it and make it work. Old pin: 0x41f0 New pin: 0x90170151 Signed-off-by: Kai-Heng Feng --- sound/pci/hda/patch_realtek.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a

[PATCH 1/2] xhci: Suspend ports to U3 directly from U1 or U2

2020-06-09 Thread Kai-Heng Feng
useful for USB2 devices, which may take a very long time to switch USB2 LPM on and off. Suggested-by: Mathias Nyman Signed-off-by: Kai-Heng Feng --- drivers/usb/host/xhci-hub.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/usb/host/xhci-hub.c b/driver

[PATCH 2/2] USB: hub: Suspend and resume port with LPM enabled

2020-06-09 Thread Kai-Heng Feng
thias Nyman Signed-off-by: Kai-Heng Feng --- drivers/usb/core/hub.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index b1e14beaac5f..882b54df6ef5 100644 --- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c @@ -3285,9 +3285,6 @@ i

[PATCH v6] drm/i915: Init lspcon after HPD in intel_dp_detect()

2020-06-10 Thread Kai-Heng Feng
e the lspcon chip on the system only gets powered after the cable is plugged. Consilidate lspcon_init() into lspcon_resume() to dynamically init lspcon chip, and make HDMI port work. Signed-off-by: Kai-Heng Feng --- v6: - Rebase on latest for-linux-next. v5: - Consolidate lspcon_resume()

[PATCH] platform/x86: intel-hid: Use hp-wireless for rfkill on HP platforms

2020-06-10 Thread Kai-Heng Feng
hotkey if HPQ6001 is present. Signed-off-by: Kai-Heng Feng --- drivers/platform/x86/intel-hid.c | 31 ++- 1 file changed, 30 insertions(+), 1 deletion(-) diff --git a/drivers/platform/x86/intel-hid.c b/drivers/platform/x86/intel-hid.c index 9ee79b74311c..31091c8faf70

Re: [PATCH 1/2] xhci: Suspend ports to U3 directly from U1 or U2

2020-06-10 Thread Kai-Heng Feng
> On Jun 10, 2020, at 22:32, Alan Stern wrote: > > On Wed, Jun 10, 2020 at 02:42:30PM +0800, Kai-Heng Feng wrote: >> xHCI spec "4.15.1 Port Suspend" states that port can be put to U3 as long >> as Enabled bit is set and from U0, U1 or U2 state. >> >&

Re: [PATCH] platform/x86: intel-hid: Use hp-wireless for rfkill on HP platforms

2020-06-11 Thread Kai-Heng Feng
> On Jun 10, 2020, at 23:49, mario.limoncie...@dell.com wrote: > >> -Original Message- >> From: platform-driver-x86-ow...@vger.kernel.org > ow...@vger.kernel.org> On Behalf Of Kai-Heng Feng >> Sent: Wednesday, June 10, 2020 10:38 AM >> To: alex.h..

Re: [PATCH] platform/x86: intel-hid: Use hp-wireless for rfkill on HP platforms

2020-06-11 Thread Kai-Heng Feng
> On Jun 11, 2020, at 01:41, Alex Hung wrote: > > On 2020-06-10 9:49 a.m., mario.limoncie...@dell.com wrote: >>> -Original Message- >>> From: platform-driver-x86-ow...@vger.kernel.org >> ow...@vger.kernel.org> On Behalf Of Kai-Heng Feng >>

Re: [PATCH 1/2] xhci: Suspend ports to U3 directly from U1 or U2

2020-06-11 Thread Kai-Heng Feng
> On Jun 10, 2020, at 23:58, Mathias Nyman > wrote: > > On 10.6.2020 18.43, Kai-Heng Feng wrote: >> >> >>> On Jun 10, 2020, at 22:32, Alan Stern wrote: >>> >>> On Wed, Jun 10, 2020 at 02:42:30PM +0800, Kai-Heng Feng wrote: >>>&

Re: [PATCH] HID: multitouch: enable multi-input as a quirk for some devices

2020-05-26 Thread Kai-Heng Feng
vents are already mapped, and simply ignores them. > > To be able to report events from the tracktick, add a new quirked > class for it, and manually add the 2 devices we know about. > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=207235 > Cc: sta...@vger.kernel.org > Sig

Re: [PATCH] HID: multitouch: Remove MT_CLS_WIN_8_DUAL

2020-05-26 Thread Kai-Heng Feng
> On May 26, 2020, at 16:43, Benjamin Tissoires > wrote: > > On Tue, May 26, 2020 at 10:24 AM Jiri Kosina wrote: >> >> On Tue, 14 Apr 2020, Kai-Heng Feng wrote: >> >>> After commit c23e2043d5f7 ("HID: multitouch: do not filter mice nodes&q

Re: [PATCH] HID: multitouch: Remove MT_CLS_WIN_8_DUAL

2020-05-28 Thread Kai-Heng Feng
> On May 27, 2020, at 20:15, Benjamin Tissoires > wrote: > > On Wed, May 27, 2020 at 11:24 AM Benjamin Tissoires > wrote: >> >> On Wed, May 27, 2020 at 8:19 AM Kai-Heng Feng >> wrote: >>> >>> >>> >>>> On May 26, 20

Re: [PATCH] leds: core: Use blocking op for system suspend

2020-07-01 Thread Kai-Heng Feng
> On Jul 2, 2020, at 05:28, Jacek Anaszewski wrote: > > Hi Kai-Heng, > > Thank you for the patch. > > On 7/1/20 11:35 AM, Kai-Heng Feng wrote: >> Sometimes LED won't be turned off by LED_CORE_SUSPENDRESUME flag upon >> system suspend. > > Just

[PATCH v2] leds: core: Flush scheduled work for system suspend

2020-07-01 Thread Kai-Heng Feng
rk to make sure LED gets turned off. Signed-off-by: Kai-Heng Feng --- v2: - Use flush_work() instead. drivers/leds/led-class.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c index 3363a6551a70..cc3929f858b6 100644 --- a/drivers/leds/led-cla

[BUG] "Pre-boot DMA Protection" makes AMDGPU stop working

2020-07-02 Thread Kai-Heng Feng
Hi, A more detailed bug report can be found at [1]. I have a AMD Renoir system that can't enter graphical session because there are many IOMMU splat. Alex suggested to disable "Pre-boot DMA Protection", I can confirm once it's disabled, AMDGPU starts working with IOMMU enabled. So raise the is

Re: [Regression] "iommu/amd: Relax locking in dma_ops path" makes tg3 ethernet transmit queue timeout

2020-06-29 Thread Kai-Heng Feng
> On May 18, 2020, at 23:32, Kai-Heng Feng wrote: > > > >> On May 18, 2020, at 22:05, Kai-Heng Feng wrote: >> >> >> >>> On May 18, 2020, at 21:32, Joerg Roedel wrote: >>> >>> On Mon, May 18, 2020 at 05:06:45PM +0800, Kai

[PATCH v3] HID: intel-ish-hid: Replace PCI_DEV_FLAGS_NO_D3 with pci_save_state

2020-06-29 Thread Kai-Heng Feng
spec mandates. Signed-off-by: Kai-Heng Feng --- v3: - Use multi-line comments. v2: - Wording change. drivers/hid/intel-ish-hid/ipc/pci-ish.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/hid/intel-ish-hid/ipc/pci-ish.c b/drivers/hid/intel-ish-hid

Re: [PATCH v6] drm/i915: Init lspcon after HPD in intel_dp_detect()

2020-06-30 Thread Kai-Heng Feng
> On Jun 10, 2020, at 15:55, Kai-Heng Feng wrote: > > On HP 800 G4 DM, if HDMI cable isn't plugged before boot, the HDMI port > becomes useless and never responds to cable hotplugging: > [3.031904] [drm:lspcon_init [i915]] *ERROR* Failed to probe lspcon > [3.0319

Re: [PATCH] xhci: Make debug message consistent with bus and port number

2020-06-30 Thread Kai-Heng Feng
> On Jun 8, 2020, at 17:29, Mathias Nyman wrote: > > On 8.6.2020 6.57, Kai-Heng Feng wrote: >> >> >>> On May 7, 2020, at 18:35, Mathias Nyman >>> wrote: >>> >>> On 7.5.2020 11.21, Greg Kroah-Hartman wrote: >>&

Re: [PATCH v3 1/2] ALSA: hda/realtek: Add COEF controlled micmute LED support

2020-06-18 Thread Kai-Heng Feng
> On Jun 18, 2020, at 15:32, Takashi Iwai wrote: > > On Thu, 18 Jun 2020 07:15:21 +0200, > Kai-Heng Feng wrote: >> >> >> >>> On Jun 17, 2020, at 23:50, Takashi Iwai wrote: >>> >>> On Wed, 17 Jun 2020 17:24:30 +0200, >>> K

[PATCH v3] HID: i2c-hid: Enable touchpad wakeup from Suspend-to-Idle

2020-06-18 Thread Kai-Heng Feng
Many laptops can be woken up from Suspend-to-Idle by touchpad. This is also the default behavior on other OSes. So let's enable the wakeup support if the system defaults to Suspend-to-Idle. Signed-off-by: Kai-Heng Feng --- v3: - Use device_init_wakeup(). - Wording change. v2: - Fix co

Re: [PATCH v3] HID: i2c-hid: Enable touchpad wakeup from Suspend-to-Idle

2020-06-18 Thread Kai-Heng Feng
Hi, > On Jun 18, 2020, at 23:28, Hans de Goede wrote: > > Hi, > > On 6/18/20 4:55 PM, Kai-Heng Feng wrote: >> Many laptops can be woken up from Suspend-to-Idle by touchpad. This is >> also the default behavior on other OSes. >> So let's enable the wa

[PATCH v2] HID: intel-ish-hid: Replace PCI_DEV_FLAGS_NO_D3 with pci_save_state

2020-06-19 Thread Kai-Heng Feng
mandates. Signed-off-by: Kai-Heng Feng --- v2: - Wording change. drivers/hid/intel-ish-hid/ipc/pci-ish.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/hid/intel-ish-hid/ipc/pci-ish.c b/drivers/hid/intel-ish-hid/ipc/pci-ish.c index f491d8b4e24c

Re: [PATCH 2/2] xhci: Poll for U0 after disabling USB2 LPM

2020-06-19 Thread Kai-Heng Feng
Hi Mathias, > On Jun 9, 2020, at 18:15, Kai-Heng Feng wrote: > > > >> On Jun 8, 2020, at 19:21, Mathias Nyman >> wrote: >> >> On 20.5.2020 13.18, Kai-Heng Feng wrote: >>> USB2 devices with LPM enabled may interrupt the system suspend: >

Re: [PATCH] HID: intel-ish-hid: Replace PCI_DEV_FLAGS_NO_D3 with pci_save_state

2020-06-12 Thread Kai-Heng Feng
> On May 21, 2020, at 12:43, Kai-Heng Feng wrote: > > Hi Srinivas, > >> On May 9, 2020, at 01:45, Srinivas Pandruvada >> wrote: >> >> On Tue, 2020-05-05 at 21:17 +0800, Kai-Heng Feng wrote: >>> PCI_DEV_FLAGS_NO_D3 should not be used outs

Re: [Intel-wired-lan] [PATCH v4] e1000e: Increase polling timeout on MDIC ready bit

2020-10-04 Thread Kai-Heng Feng
Hi Vitaly, > On Sep 30, 2020, at 14:54, Vitaly Lifshits wrote: > > On 9/29/2020 18:08, Kai-Heng Feng wrote: > > Hello Kai-Heng, >>> On Sep 29, 2020, at 21:46, Neftin, Sasha wrote: >>> >>> Hello Kai-Heng, >>> On 9/29/2020 16:31, Kai-Heng Feng

Re: [PATCH 2/2] PCI: vmd: Enable ASPM for mobile platforms

2020-10-05 Thread Kai-Heng Feng
Hi Bjorn, > On Oct 3, 2020, at 06:18, Bjorn Helgaas wrote: > > On Wed, Sep 30, 2020 at 04:24:54PM +0800, Kai-Heng Feng wrote: >> BIOS may not be able to program ASPM for links behind VMD, prevent Intel >> SoC from entering deeper power saving state. > > It's

Re: [PATCH 2/2] PCI: vmd: Enable ASPM for mobile platforms

2020-10-06 Thread Kai-Heng Feng
> On Oct 6, 2020, at 03:19, Bjorn Helgaas wrote: > > [+cc Ian, who's also working on an ASPM issue] > > On Tue, Oct 06, 2020 at 02:40:32AM +0800, Kai-Heng Feng wrote: >>> On Oct 3, 2020, at 06:18, Bjorn Helgaas wrote: >>> On Wed, Sep 30, 2020 at

[PATCH] drm/radeon: Prefer lower feedback dividers

2020-08-25 Thread Kai-Heng Feng
he original fix. Fixes: 2e26ccb119bd ("drm/radeon: prefer lower reference dividers") BugLink: https://bugs.launchpad.net/bugs/1791312 BugLink: https://bugs.launchpad.net/bugs/1861554 Signed-off-by: Kai-Heng Feng --- drivers/gpu/drm/radeon/radeon_display.c | 2 +- 1 file changed, 1

[PATCH] drm/i915/lspcon: Limits to 8 bpc for RGB/YCbCr444

2020-08-25 Thread Kai-Heng Feng
LSPCON only supports 8 bpc for RGB/YCbCr444. Set the correct bpp otherwise it renders blank screen. Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2195 Signed-off-by: Kai-Heng Feng --- drivers/gpu/drm/i915/display/intel_lspcon.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion

Re: [PATCH] PCI/ASPM: Enable ASPM for links under VMD domain

2020-08-25 Thread Kai-Heng Feng
> On Aug 25, 2020, at 14:56, Christoph Hellwig wrote: > > On Tue, Aug 25, 2020 at 02:39:55PM +0800, Kai Heng Feng wrote: >> Hi Christoph, >> >>> On Aug 25, 2020, at 2:23 PM, Christoph Hellwig wrote: >>> >>> On Fri, Aug 21, 2020 at 08:32

Re: [PATCH] drm/i915/lspcon: Limits to 8 bpc for RGB/YCbCr444

2020-08-26 Thread Kai Heng Feng
Hi Ville, > On Aug 27, 2020, at 12:24 AM, Ville Syrjälä > wrote: > > On Wed, Aug 26, 2020 at 01:21:15PM +0800, Kai-Heng Feng wrote: >> LSPCON only supports 8 bpc for RGB/YCbCr444. >> >> Set the correct bpp otherwise it renders blank screen. > > Hm

[PATCH 1/2] drm/i915/dpcd_bl: Skip testing control capability with force DPCD quirk

2020-10-07 Thread Kai-Heng Feng
-by: Kai-Heng Feng --- drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c index acbd7eb66cbe

[PATCH 2/2] drm/dp: HP DreamColor panel brigntness fix

2020-10-07 Thread Kai-Heng Feng
HP DreamColor panel, which is used by new HP ZBook Studio, needs to use DPCD to control brightness. Signed-off-by: Kai-Heng Feng --- drivers/gpu/drm/drm_dp_helper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c index

Re: [PATCH] drm/i915: Force DPCD backlight mode for HP Spectre x360 Convertible 13t-aw100

2020-10-07 Thread Kai-Heng Feng
> On Apr 8, 2020, at 15:22, Jani Nikula wrote: > > On Tue, 07 Apr 2020, Kai-Heng Feng wrote: >>> On Mar 27, 2020, at 19:03, Kai-Heng Feng >>> wrote: >>> >>> Hi, >>> >>>> On Mar 23, 2020, at 13:35, Kai-Heng Feng >&

Re: [PATCH] drm/i915: Force DPCD backlight mode for HP CML 2020 system

2020-10-07 Thread Kai-Heng Feng
> On Apr 8, 2020, at 15:23, Jani Nikula wrote: > > On Tue, 07 Apr 2020, Kai-Heng Feng wrote: >> There's another Samsung OLED panel needs to use DPCD aux interface to >> control backlight. > > Acked-by: Jani Nikula David, Can you please mer

Re: [PATCH 1/2] drm/i915/dpcd_bl: Skip testing control capability with force DPCD quirk

2020-10-07 Thread Kai-Heng Feng
ght supports AUX_SET_CAP, that should be enough for us to control > it. Does the proper fix include dropping DP_QUIRK_FORCE_DPCD_BACKLIGHT entirely? Kai-Heng > > > On Wed, 2020-10-07 at 14:58 +0800, Kai-Heng Feng wrote: >> HP DreamColor panel needs to be controlled via AUX int

Re: [PATCH 2/2] PCI: vmd: Enable ASPM for mobile platforms

2020-10-07 Thread Kai-Heng Feng
> On Oct 7, 2020, at 21:30, Bjorn Helgaas wrote: > > On Wed, Oct 07, 2020 at 12:26:19PM +0800, Kai-Heng Feng wrote: >>> On Oct 6, 2020, at 03:19, Bjorn Helgaas wrote: >>> On Tue, Oct 06, 2020 at 02:40:32AM +0800, Kai-Heng Feng wrote: >>>>> On O

Re: [Regression] "tpm: Require that all digests are present in TCG_PCR_EVENT2 structures" causes null pointer dereference

2020-10-08 Thread Kai-Heng Feng
> On Sep 30, 2020, at 10:20, Jarkko Sakkinen > wrote: > > On Tue, Sep 29, 2020 at 01:52:04PM -0400, Mimi Zohar wrote: >> On Mon, 2020-09-28 at 22:16 +0800, Kai-Heng Feng wrote: >>> Hi Jarkko, >>> >>>> On Sep 28, 2020, at 22:06, Jarkko Sakkinen

Re: [Intel-wired-lan] [PATCH v4] e1000e: Increase polling timeout on MDIC ready bit

2020-09-29 Thread Kai-Heng Feng
Hi Sasha, > On Sep 29, 2020, at 21:08, Neftin, Sasha wrote: > > On 9/28/2020 11:36, Kai-Heng Feng wrote: >> We are seeing the following error after S3 resume: >> [ 704.746874] e1000e :00:1f.6 eno1: Setting page 0x6020 >> [ 704.844232] e1000e :00:1f.6 eno1:

Re: [Intel-wired-lan] [PATCH v4] e1000e: Increase polling timeout on MDIC ready bit

2020-09-29 Thread Kai-Heng Feng
> On Sep 29, 2020, at 21:46, Neftin, Sasha wrote: > > Hello Kai-Heng, > On 9/29/2020 16:31, Kai-Heng Feng wrote: >> Hi Sasha, >>> On Sep 29, 2020, at 21:08, Neftin, Sasha wrote: >>> >>> On 9/28/2020 11:36, Kai-Heng Feng wrote: >>&

Re: [Intel-wired-lan] [PATCH v4] e1000e: Increase polling timeout on MDIC ready bit

2020-09-29 Thread Kai-Heng Feng
> On Sep 29, 2020, at 23:11, David Laight wrote: > >> Hope we finally have proper ME support under Linux? > > How about a way to disable it. This will do, too :) Kai-Heng > > David > > - > Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 > 1PT, UK > Regist

[PATCH 1/2] PCI/ASPM: Add helper to enable ASPM link

2020-09-30 Thread Kai-Heng Feng
Platform firmware may not be able to access config space to program ASPM. For instance, devices behind Intel VMD are not configured by the BIOS. So add a helper to let drivers have an option to enable ASPM. Signed-off-by: Kai-Heng Feng --- drivers/pci/pcie/aspm.c | 73

[PATCH 2/2] PCI: vmd: Enable ASPM for mobile platforms

2020-09-30 Thread Kai-Heng Feng
BIOS may not be able to program ASPM for links behind VMD, prevent Intel SoC from entering deeper power saving state. So enable ASPM for links behind VMD to increase battery life. Signed-off-by: Kai-Heng Feng --- drivers/pci/controller/vmd.c | 22 +- 1 file changed, 21

[PATCH] nvme-pci: Disable Write Zeroes on Sandisk Skyhawk

2020-10-13 Thread Kai-Heng Feng
0 So also disable Write Zeroes command on Sandisk Skyhawk. BugLink: https://bugs.launchpad.net/bugs/1899503 Signed-off-by: Kai-Heng Feng --- drivers/nvme/host/pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index 8984796db0c8..d310d7317

Re: [PATCH] Bluetooth: btusb: Avoid unnecessary reset upon system resume

2020-09-25 Thread Kai-Heng Feng
Hi Alex, > On Sep 25, 2020, at 16:23, 陆朱伟 wrote: > > Hi Kai-Heng, > >> On September 25, 2020 at 15:56, Kai-Heng Feng wrote: >> >> Hi Alex, >> >>> On Sep 25, 2020, at 15:42, 陆朱伟 wrote: >>> >>> Hi Kai-Heng, >>> >

[PATCH v4] e1000e: Increase polling timeout on MDIC ready bit

2020-09-28 Thread Kai-Heng Feng
flict with software. Signed-off-by: Kai-Heng Feng --- v4: - States that this patch just papers over the symptom. v3: - Moving delay to end of loop doesn't save anytime, move it back. - Point out this is quitely likely caused by Intel ME. v2: - Increase polling iteration instead of powerin

Re: [PATCH v3] xhci: Prevent runtime suspend on Etron EJ168

2020-09-28 Thread Kai-Heng Feng
> On Jun 8, 2020, at 11:56, Kai-Heng Feng wrote: > > > >> On May 5, 2020, at 01:16, Kai-Heng Feng wrote: >> >> Etron EJ168 USB 3.0 Host Controller stops working after S3, if it was >> runtime suspended previously: >> [ 370.080359] pci :02:00.

Re: [PATCH v6] drm/i915: Init lspcon after HPD in intel_dp_detect()

2020-09-28 Thread Kai-Heng Feng
Hi Jani, > On Jul 10, 2020, at 23:48, Kai-Heng Feng wrote: > > > >> On Jun 30, 2020, at 16:37, Kai-Heng Feng wrote: >> >> >>> On Jun 10, 2020, at 15:55, Kai-Heng Feng >>> wrote: >>> >>> On HP 800 G4 DM, if HDMI cable isn&

[Regression] "tpm: Require that all digests are present in TCG_PCR_EVENT2 structures" causes null pointer dereference

2020-09-28 Thread Kai-Heng Feng
Commit 7f3d176f5f7e "tpm: Require that all digests are present in TCG_PCR_EVENT2 structures" causes a null pointer dereference on all laptops I have: [0.00] microcode: microcode updated early to revision 0xd6, date = 2020-04-27 [0.00] Linux version 5.8.0-rc6+ (gcc (Ubuntu 10.2.0

Re: [Regression] "tpm: Require that all digests are present in TCG_PCR_EVENT2 structures" causes null pointer dereference

2020-09-28 Thread Kai-Heng Feng
Hi Jarkko, > On Sep 28, 2020, at 22:06, Jarkko Sakkinen > wrote: > > On Mon, Sep 28, 2020 at 08:31:04PM +0800, Kai-Heng Feng wrote: >> Commit 7f3d176f5f7e "tpm: Require that all digests are present in >> TCG_PCR_EVENT2 structures" causes a null pointer de

[PATCH v2] rtw88: pci: Power cycle device during shutdown

2020-09-28 Thread Kai-Heng Feng
2984 Signed-off-by: Kai-Heng Feng --- v2: - Add more detail in commit log. drivers/net/wireless/realtek/rtw88/pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/realtek/rtw88/pci.c b/drivers/net/wireless/realtek/rtw88/pci.c index 3413973bc475..7f1f5073b9f4 100644 --

Re: [PATCH v3] xhci: Prevent runtime suspend on Etron EJ168

2020-09-29 Thread Kai-Heng Feng
> On Sep 29, 2020, at 05:42, Mathias Nyman > wrote: > > On 28.9.2020 12.10, Kai-Heng Feng wrote: >> >> >>> On Jun 8, 2020, at 11:56, Kai-Heng Feng wrote: >>> >>> >>> >>>> On May 5, 2020, at 01:16, Kai-Heng Feng

[PATCH v3] xhci: Prevent runtime suspend on Etron EJ168

2020-05-04 Thread Kai-Heng Feng
Host not accessible, reset failed. [ 370.080575] xhci_hcd :04:00.0: PCI post-resume error -19! [ 370.080586] xhci_hcd :04:00.0: HC died; cleaning up This can be fixed by not runtime suspend the controller at all. So disable runtime suspend for EJ168 xHCI device. Signed-off-by: K

[PATCH] igb: Report speed and duplex as unknown when device is runtime suspended

2020-05-04 Thread Kai-Heng Feng
es to rtnl_lock() while the lock is already hold by upper ethtool layer. So let's take this approach until the igb_runtime_resume() no longer needs to hold rtnl_lock. Suggested-by: Alexander Duyck Signed-off-by: Kai-Heng Feng --- drivers/net/ethernet/intel/igb/igb_ethtool.c | 6 ++ 1 file c

[PATCH 2/2] ALSA: hda: Use hdac_to_hda_codec macro

2020-05-04 Thread Kai-Heng Feng
Use hdac_to_hda_codec() instead of container_of(). No functional change intended. Signed-off-by: Kai-Heng Feng --- include/sound/hda_codec.h | 4 sound/pci/hda/patch_hdmi.c | 12 ++-- sound/soc/codecs/hdac_hda.h | 4 3 files changed, 10 insertions(+), 10 deletions

[PATCH 1/2] ALSA: hda: Use dev_to_hdac_dev macro

2020-05-04 Thread Kai-Heng Feng
Use dev_to_hdac_dev() instead of container_of(). No functional change intended. Signed-off-by: Kai-Heng Feng --- sound/hda/ext/hdac_ext_bus.c | 2 +- sound/hda/hdac_device.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/hda/ext/hdac_ext_bus.c b/sound/hda/ext

[PATCH v2] igb: Report speed and duplex as unknown when device is runtime suspended

2020-05-04 Thread Kai-Heng Feng
, begin() calls igb_runtime_resume() , which tries to rtnl_lock() while the lock is already hold by upper ethtool layer. So let's take this approach until the igb_runtime_resume() no longer needs to hold rtnl_lock. Cc: Jeff Kirsher Cc: Aaron Brown Suggested-by: Alexander Duyck Signed-off-by: K

[PATCH v2] PCI/ASPM: Enable ASPM for root complex <-> bridge <-> bridge case

2020-05-05 Thread Kai-Heng Feng
onnects to root complex enables ASPM, instead of removing it completely, to avoid regression. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=207571 Signed-off-by: Kai-Heng Feng --- drivers/pci/pcie/aspm.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/d

[PATCH] HID: intel-ish-hid: Replace PCI_DEV_FLAGS_NO_D3 with pci_save_state

2020-05-05 Thread Kai-Heng Feng
PCI_DEV_FLAGS_NO_D3 should not be used outside of PCI core. Instead, we can use pci_save_state() to hint PCI core that the device should stay at D0 during suspend. Signed-off-by: Kai-Heng Feng --- drivers/hid/intel-ish-hid/ipc/pci-ish.c | 15 ++- 1 file changed, 10 insertions(+), 5

Re: [PATCH v2] PCI/ASPM: Enable ASPM for root complex <-> bridge <-> bridge case

2020-05-05 Thread Kai-Heng Feng
> On May 5, 2020, at 21:38, Bjorn Helgaas wrote: > > On Tue, May 05, 2020 at 08:27:59PM +0800, Kai-Heng Feng wrote: >> The TI PCIe-to-PCI bridge prevents the Intel SoC from entering power >> state deeper than PC3 due to disabled ASPM, consumes lots of unnecessary >>

[PATCH v3] PCI/ASPM: Enable ASPM for bridge-to-bridge link

2020-05-05 Thread Kai-Heng Feng
the the special case, as PCIe spec already envisioned ASPM on bridge-to-bridge link. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=207571 Signed-off-by: Kai-Heng Feng --- v3: - Remove the special case completely. v2: - Enable ASPM on root complex <-> bridge <-> bridge, ins

[PATCH v3] libata: Use per port sync for detach

2020-06-03 Thread Kai-Heng Feng
pad.net/bugs/1867983 Suggested-by: John Garry Signed-off-by: Kai-Heng Feng --- v3: - Move the comment to properly align with the code. v2: - Sync up to cookie + 1. - Squash the synchronization into the same loop. drivers/ata/libata-core.c | 11 +-- include/linux/libata.h| 3 +++

Re: [PATCH] usb: core: hub: limit HUB_QUIRK_DISABLE_AUTOSUSPEND to USB5534B

2020-05-14 Thread Kai-Heng Feng
> On May 15, 2020, at 06:02, Eugeniu Rosca wrote: > > On Tue, May 12, 2020 at 09:36:07PM +0800, Kai-Heng Feng wrote [1]: >> This patch prevents my Raven Ridge xHCI from getting runtime suspend. > > The problem described in v5.6 commit 1208f9e1d758c9 ("USB: hub: Fix

[PATCH] libata: Use per port sync for detach

2020-05-15 Thread Kai-Heng Feng
pad.net/bugs/1867983 Signed-off-by: Kai-Heng Feng --- drivers/ata/libata-core.c | 6 +++--- include/linux/libata.h| 3 +++ 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index beca5f91bb4c..4a698f6388cd 100644 --- a/drivers/ata

Re: [PATCH] libata: Use per port sync for detach

2020-05-15 Thread Kai-Heng Feng
> On May 15, 2020, at 20:38, John Garry wrote: > > On 15/05/2020 12:09, Kai-Heng Feng wrote: >> Commit 130f4caf145c ("libata: Ensure ata_port probe has completed before >> detach") may cause system freeze during suspend. >> Using async_synchronize_full()

Re: [PATCH v5] drm/i915: Init lspcon chip dynamically

2020-06-07 Thread Kai-Heng Feng
> On May 6, 2020, at 18:28, Kai-Heng Feng wrote: > > On HP 800 G4 DM, if HDMI cable isn't plugged before boot, the HDMI port > becomes useless and never responds to cable hotplugging: > [3.031904] [drm:lspcon_init [i915]] *ERROR* Failed to probe lspcon > [3.0319

Re: [PATCH v3] xhci: Prevent runtime suspend on Etron EJ168

2020-06-07 Thread Kai-Heng Feng
> On May 5, 2020, at 01:16, Kai-Heng Feng wrote: > > Etron EJ168 USB 3.0 Host Controller stops working after S3, if it was > runtime suspended previously: > [ 370.080359] pci :02:00.0: can't change power state from D3cold to D0 > (config space inaccessible) &g

Re: [PATCH] xhci: Make debug message consistent with bus and port number

2020-06-07 Thread Kai-Heng Feng
> On May 7, 2020, at 18:35, Mathias Nyman wrote: > > On 7.5.2020 11.21, Greg Kroah-Hartman wrote: >> On Thu, May 07, 2020 at 03:58:36PM +0800, Kai-Heng Feng wrote: >>> >>> >>>> On May 7, 2020, at 15:31, Greg Kroah-Hartman >>>> w

<    1   2   3   4   5   6   7   8   9   >