Re: [PATCH v6 1/2] [media] atmel-isc: add the Image Sensor Controller code

2016-07-21 Thread Wu, Songjun
On 7/21/2016 17:13, Hans Verkuil wrote: On 07/21/2016 10:14 AM, Songjun Wu wrote: Add driver for the Image Sensor Controller. It manages incoming data from a parallel based CMOS/CCD sensor. It has an internal image processor, also integrates a triple channel direct memory access controller m

Re: [PATCH v6 0/2] [media] atmel-isc: add driver for Atmel ISC

2016-07-21 Thread Wu, Songjun
On 7/21/2016 16:41, Hans Verkuil wrote: On 07/21/2016 10:14 AM, Songjun Wu wrote: The Image Sensor Controller driver includes two parts. 1) Driver code to implement the ISC function. 2) Device tree binding documentation, it describes how to add the ISC in device tree. Test result with v4

Re: [PATCH v7 2/2] [media] atmel-isc: DT binding for Image Sensor Controller driver

2016-07-31 Thread Wu, Songjun
On 7/30/2016 05:44, Rob Herring wrote: On Fri, Jul 29, 2016 at 03:54:08PM +0800, Songjun Wu wrote: DT binding documentation for ISC driver. Signed-off-by: Songjun Wu --- Changes in v7: None Changes in v6: - Add "iscck" and "gck" to clock-names. Changes in v5: - Add clock-output-names. Cha

Re: [PATCH v8 1/2] [media] atmel-isc: add the Image Sensor Controller code

2016-08-08 Thread Wu, Songjun
On 8/8/2016 17:37, Hans Verkuil wrote: On 08/03/2016 10:08 AM, Songjun Wu wrote: Add driver for the Image Sensor Controller. It manages incoming data from a parallel based CMOS/CCD sensor. It has an internal image processor, also integrates a triple channel direct memory access controller mast

Re: [PATCH v8 1/2] [media] atmel-isc: add the Image Sensor Controller code

2016-08-08 Thread Wu, Songjun
On 8/8/2016 17:56, Hans Verkuil wrote: On 08/08/2016 11:37 AM, Hans Verkuil wrote: On 08/03/2016 10:08 AM, Songjun Wu wrote: Add driver for the Image Sensor Controller. It manages incoming data from a parallel based CMOS/CCD sensor. It has an internal image processor, also integrates a triple

Re: [PATCH 1/2] ASoC: atmel-classd: add the Audio Class D Amplifier code

2015-09-06 Thread Wu, Songjun
On 9/3/2015 19:37, Mark Brown wrote: On Tue, Sep 01, 2015 at 01:41:40PM +0800, Songjun Wu wrote: +static const char * const mono_text[] = { + "stereo", "mono" +}; + +static SOC_ENUM_SINGLE_DECL(classd_mono_enum, + CLASSD_INTPMR, CLASSD_INTPMR_MONO_SHIFT, +

Re: [PATCH 2/2] ASoC: atmel-classd: DT binding for Class D audio amplifier driver

2015-09-06 Thread Wu, Songjun
On 9/3/2015 19:43, Mark Brown wrote: On Tue, Sep 01, 2015 at 01:41:41PM +0800, Songjun Wu wrote: +classd: classd@fc048000 { + compatible = "atmel,sama5d2-classd"; + reg = <0xfc048000 0x100>; + interrupts = <59 IRQ_TYPE_LEVEL_HIGH 7>; + d

Re: [PATCH 2/2] ASoC: atmel-classd: DT binding for Class D audio amplifier driver

2015-09-08 Thread Wu, Songjun
On 9/8/2015 00:25, Mark Brown wrote: On Sun, Sep 06, 2015 at 05:44:30PM +0800, Wu, Songjun wrote: On 9/3/2015 19:43, Mark Brown wrote: Why is this a separate DT node? It seems that this IP is entirely self contained so I'm not clear why we need a separate node for the card, the ca

Re: [PATCH 1/2] ASoC: atmel-classd: add the Audio Class D Amplifier code

2015-09-08 Thread Wu, Songjun
On 9/8/2015 00:23, Mark Brown wrote: On Sun, Sep 06, 2015 at 05:44:21PM +0800, Wu, Songjun wrote: On 9/3/2015 19:37, Mark Brown wrote: On Tue, Sep 01, 2015 at 01:41:40PM +0800, Songjun Wu wrote: +static const char * const eqcfg_bass_text[] = { + "-12 dB", "-6 dB&q

Re: [PATCH 1/2] ASoC: atmel-classd: add the Audio Class D Amplifier code

2015-09-08 Thread Wu, Songjun
On 9/8/2015 20:23, Mark Brown wrote: On Tue, Sep 08, 2015 at 05:36:01PM +0800, Wu, Songjun wrote: On 9/8/2015 00:23, Mark Brown wrote: OK, so that's not actually what the code was doing - it had separate enums for bass, mid and treble. If you make this a single enum with all the

Re: [PATCH 2/2] ASoC: atmel-classd: DT binding for Class D audio amplifier driver

2015-09-08 Thread Wu, Songjun
On 9/8/2015 20:23, Mark Brown wrote: On Tue, Sep 08, 2015 at 05:36:13PM +0800, Wu, Songjun wrote: On 9/8/2015 00:25, Mark Brown wrote: Sure, there's no problem at all having that structure in software but it should be possible to do this without having to represent this structure

Re: [PATCH v2 15/18] serial: intel: Support more platform

2018-08-03 Thread Wu, Songjun
On 8/3/2018 1:57 PM, Greg Kroah-Hartman wrote: On Fri, Aug 03, 2018 at 11:02:34AM +0800, Songjun Wu wrote: Support more platform. Signed-off-by: Songjun Wu --- Your changelog text makes no sense, sorry. Thanks for your comment. I will describe it more clearly.

Re: [PATCH v2 14/18] serial: intel: Add CCF support

2018-08-03 Thread Wu, Songjun
On 8/3/2018 1:56 PM, Greg Kroah-Hartman wrote: On Fri, Aug 03, 2018 at 11:02:33AM +0800, Songjun Wu wrote: Previous implementation uses platform-dependent API to get the clock. Those functions are not available for other SoC which uses the same IP. The CCF (Common Clock Framework) have an abs

Re: [PATCH v2 14/18] serial: intel: Add CCF support

2018-08-06 Thread Wu, Songjun
On 8/5/2018 5:03 AM, Arnd Bergmann wrote: On Sat, Aug 4, 2018 at 2:43 PM, Greg Kroah-Hartman wrote: On Sat, Aug 04, 2018 at 12:54:22PM +0200, Hauke Mehrtens wrote: On 08/03/2018 12:30 PM, Greg Kroah-Hartman wrote: On Fri, Aug 03, 2018 at 03:33:38PM +0800, Wu, Songjun wrote: This patch

Re: [PATCH v2 15/18] serial: intel: Support more platform

2018-08-06 Thread Wu, Songjun
On 8/5/2018 4:37 PM, Christoph Hellwig wrote: The subject line also seems odd, your are changing deps on the lantiq driver, not some (nonexistent) intel serial driver. Your suggestion is reasonable, it will be changed to "serial: lantiq".

Re: [PATCH v2 14/18] serial: intel: Add CCF support

2018-08-06 Thread Wu, Songjun
On 8/6/2018 3:20 PM, Geert Uytterhoeven wrote: Hi Songjun, On Mon, Aug 6, 2018 at 9:15 AM Wu, Songjun wrote: On 8/5/2018 5:03 AM, Arnd Bergmann wrote: On Sat, Aug 4, 2018 at 2:43 PM, Greg Kroah-Hartman wrote: On Sat, Aug 04, 2018 at 12:54:22PM +0200, Hauke Mehrtens wrote: On 08/03/2018

Re: [PATCH v2 08/18] serial: intel: Get serial id from dts

2018-08-06 Thread Wu, Songjun
On 8/3/2018 1:43 PM, Greg Kroah-Hartman wrote: On Fri, Aug 03, 2018 at 11:02:27AM +0800, Songjun Wu wrote: Get serial id from dts. "#ifdef CONFIG_LANTIQ" preprocessor is used because LTQ_EARLY_ASC macro is defined in lantiq_soc.h. lantiq_soc.h is in arch path for legacy product support. arc

Re: [PATCH v2 14/18] serial: intel: Add CCF support

2018-08-07 Thread Wu, Songjun
On 8/6/2018 5:29 PM, Geert Uytterhoeven wrote: Hi Songjun, On Mon, Aug 6, 2018 at 10:58 AM Wu, Songjun wrote: On 8/6/2018 3:20 PM, Geert Uytterhoeven wrote: On Mon, Aug 6, 2018 at 9:15 AM Wu, Songjun wrote: On 8/5/2018 5:03 AM, Arnd Bergmann wrote: On Sat, Aug 4, 2018 at 2:43 PM, Greg

Re: [PATCH v2 08/18] serial: intel: Get serial id from dts

2018-08-07 Thread Wu, Songjun
On 8/7/2018 3:33 PM, Geert Uytterhoeven wrote: Hi Songjun, On Fri, Aug 3, 2018 at 5:04 AM Songjun Wu wrote: Get serial id from dts. "#ifdef CONFIG_LANTIQ" preprocessor is used because LTQ_EARLY_ASC macro is defined in lantiq_soc.h. lantiq_soc.h is in arch path for legacy product support.

Re: [PATCH v2 08/18] serial: intel: Get serial id from dts

2018-08-10 Thread Wu, Songjun
On 8/8/2018 4:33 PM, Geert Uytterhoeven wrote: Hi Songjun, On Wed, Aug 8, 2018 at 6:05 AM Wu, Songjun wrote: On 8/7/2018 3:33 PM, Geert Uytterhoeven wrote: On Fri, Aug 3, 2018 at 5:04 AM Songjun Wu wrote: Get serial id from dts. "#ifdef CONFIG_LANTIQ" preprocessor is us

Re: [PATCH 4/7] tty: serial: lantiq: Always use readl()/writel()

2018-06-18 Thread Wu, Songjun
On 6/14/2018 6:07 PM, Arnd Bergmann wrote: On Tue, Jun 12, 2018 at 7:40 AM, Songjun Wu wrote: Previous implementation uses platform-dependent functions ltq_w32()/ltq_r32() to access registers. Those functions are not available for other SoC which uses the same IP. Change to OS provided readl

Re: [PATCH 1/7] MIPS: dts: Add aliases node for lantiq danube serial

2018-06-18 Thread Wu, Songjun
On 6/14/2018 6:03 PM, Arnd Bergmann wrote: On Tue, Jun 12, 2018 at 7:40 AM, Songjun Wu wrote: Previous implementation uses a hard-coded register value to check if the current serial entity is the console entity. Now the lantiq serial driver uses the aliases for the index of the serial port.

Re: [PATCH 1/7] MIPS: dts: Add aliases node for lantiq danube serial

2018-06-18 Thread Wu, Songjun
On 6/18/2018 6:59 PM, Arnd Bergmann wrote: On Mon, Jun 18, 2018 at 11:42 AM, Wu, Songjun wrote: On 6/14/2018 6:03 PM, Arnd Bergmann wrote: On Tue, Jun 12, 2018 at 7:40 AM, Songjun Wu wrote: Previous implementation uses a hard-coded register value to check if the current serial entity is

Re: [PATCH 7/7] tty: serial: lantiq: Add CCF support

2018-06-13 Thread Wu, Songjun
On 6/13/2018 6:39 AM, Rob Herring wrote: On Tue, Jun 12, 2018 at 01:40:34PM +0800, Songjun Wu wrote: Previous implementation uses platform-dependent API to get the clock. Those functions are not available for other SoC which uses the same IP. The CCF (Common Clock Framework) have an abstracti

Re: [PATCH 4/7] tty: serial: lantiq: Always use readl()/writel()

2018-06-14 Thread Wu, Songjun
On 6/12/2018 4:13 PM, Andy Shevchenko wrote: On Tue, Jun 12, 2018 at 8:40 AM, Songjun Wu wrote: Previous implementation uses platform-dependent functions ltq_w32()/ltq_r32() to access registers. Those functions are not available for other SoC which uses the same IP. Change to OS provided rea

Re: [PATCH 00/14] serial: langtiq: Add CCF suppport

2018-10-16 Thread Wu, Songjun
On 10/16/2018 5:58 AM, Paul Burton wrote: Hi Songjun, On Mon, Sep 24, 2018 at 06:27:49PM +0800, Songjun Wu wrote: This patch series is for adding common clock framework support for langtiq serial driver, mainly includes: s/langtiq/lantiq/ ... Thanks, it will be fixed. 1) Add common clock

Re: [PATCH] USB: gadget: udc: atmel: fix possible oops when unloading module

2014-12-23 Thread Wu, Songjun
在 12/24/2014 00:24, Felipe Balbi 写道: On Mon, Dec 22, 2014 at 05:26:14PM +0800, Songjun Wu wrote: When unloading the module, the urb request will be dequeued and the completion routine will be excuted. If no urb packet, the urb request will not be added to the endpoint queue and the completion r

看看这样回复可以吗? Re: [PATCH] USB: gadget: udc: atmel: fix possible oops when unloading module

2014-12-29 Thread Wu, Songjun
On 12/26/2014 23:27, Felipe Balbi wrote: Hi, On Wed, Dec 24, 2014 at 09:14:53AM +0800, Wu, Songjun wrote: 在 12/24/2014 00:24, Felipe Balbi 写道: On Mon, Dec 22, 2014 at 05:26:14PM +0800, Songjun Wu wrote: When unloading the module, the urb request will be dequeued and the completion routine

Re: [PATCH] USB: gadget: udc: atmel: fix possible oops when unloading module

2014-12-29 Thread Wu, Songjun
On 12/26/2014 23:27, Felipe Balbi wrote: Hi, On Wed, Dec 24, 2014 at 09:14:53AM +0800, Wu, Songjun wrote: 在 12/24/2014 00:24, Felipe Balbi 写道: On Mon, Dec 22, 2014 at 05:26:14PM +0800, Songjun Wu wrote: When unloading the module, the urb request will be dequeued and the completion routine

Re: [PATCH] USB: gadget: udc: atmel: fix possible oops when unloading module

2014-12-29 Thread Wu, Songjun
On 12/26/2014 23:27, Felipe Balbi wrote: Hi, On Wed, Dec 24, 2014 at 09:14:53AM +0800, Wu, Songjun wrote: 在 12/24/2014 00:24, Felipe Balbi 写道: On Mon, Dec 22, 2014 at 05:26:14PM +0800, Songjun Wu wrote: When unloading the module, the urb request will be dequeued and the completion routine

Re: [PATCH 1/2] [media] atmel-isc: add the Image Sensor Controller code

2016-04-13 Thread Wu, Songjun
The option 'CONFIG_COMMON_CLK=y' is needed to add to '.config'. But I do not validate, '.config' will be generated automatically and overwritten when it is changed. On 4/14/2016 00:01, kbuild test robot wrote: Hi Songjun, [auto build test ERROR on linuxtv-media/master] [also build test ERROR

Re: [PATCH v2 2/2] [media] atmel-isc: DT binding for Image Sensor Controller driver

2016-05-19 Thread Wu, Songjun
Hi Rob, Thank you for your comments. On 5/19/2016 07:05, Rob Herring wrote: On Wed, May 18, 2016 at 03:46:29PM +0800, Songjun Wu wrote: DT binding documentation for ISC driver. Signed-off-by: Songjun Wu --- Changes in v2: - Remove the unit address of the endpoint. - Add the unit address to

Re: [PATCH 1/2] ASoC: atmel-pdmic: add the Pulse Density Modulation Interface Controller

2015-12-16 Thread Wu, Songjun
On 12/16/2015 20:27, Mark Brown wrote: On Mon, Dec 14, 2015 at 04:15:39PM +0800, Songjun Wu wrote: Add driver for the Pulse Density Modulation Interface Controller. It comes with digitallly controlled gain, a High-Pass and a SINCC filter. This looks basically OK but there's a *lot* of weird

Re: [PATCH 1/2] ASoC: atmel-classd: add the Audio Class D Amplifier code

2015-09-09 Thread Wu, Songjun
On 9/9/2015 17:52, Mark Brown wrote: On Wed, Sep 09, 2015 at 11:16:08AM +0800, Wu, Songjun wrote: On 9/8/2015 20:23, Mark Brown wrote: If you want to have three controls you need to write code so that the user can only change one of them from 0dB at once, returning an error otherwise

Re: [PATCH 1/2] ASoC: atmel-classd: add the Audio Class D Amplifier code

2015-09-13 Thread Wu, Songjun
On 9/11/2015 18:34, Mark Brown wrote: On Thu, Sep 10, 2015 at 10:31:04AM +0800, Wu, Songjun wrote: On 9/9/2015 17:52, Mark Brown wrote: Yes, that's what's going to end up happening but it's not how controls are expected to behave - applications will expect changing one c

Re: [PATCH] ASoC: atmel_ssc_dai: distinguish the different SSC

2016-02-15 Thread Wu, Songjun
Any comments on this patch? On 1/13/2016 23:08, Nicolas Ferre wrote: Le 13/01/2016 07:35, Songjun Wu a écrit : Cpu_dai id always equals 0, can't distinguish the different SSC. Use platform_device id to record and distinguish the different SSC. Signed-off-by: Songjun Wu It seems okay: Acked

Re: [PATCH 2/2] [media] atmel-isc: DT binding for Image Sensor Controller driver

2016-04-19 Thread Wu, Songjun
On 4/14/2016 23:29, Rob Herring wrote: On Wed, Apr 13, 2016 at 03:44:20PM +0800, Songjun Wu wrote: DT binding documentation for ISC driver. Signed-off-by: Songjun Wu --- .../devicetree/bindings/media/atmel-isc.txt| 84 ++ 1 file changed, 84 insertions(+) cre

Re: [PATCH 1/2] [media] atmel-isc: add the Image Sensor Controller code

2016-04-18 Thread Wu, Songjun
On 4/14/2016 22:14, Laurent Pinchart wrote: Hello Songjun, On Thursday 14 Apr 2016 13:44:27 Wu, Songjun wrote: The option 'CONFIG_COMMON_CLK=y' is needed to add to '.config'. But I do not validate, '.config' will be generated automatically and overwritten when

Re: [PATCH 1/2] [media] atmel-isc: add the Image Sensor Controller code

2016-04-19 Thread Wu, Songjun
On 4/15/2016 00:21, Laurent Pinchart wrote: Hello Songjun, Thank you for the patch. On Wednesday 13 Apr 2016 15:44:19 Songjun Wu wrote: Add driver for the Image Sensor Controller. It manages incoming data from a parallel based CMOS/CCD sensor. It has an internal image processor, also integra

Re: [PATCH 1/2] [media] atmel-isc: add the Image Sensor Controller code

2016-04-19 Thread Wu, Songjun
On 4/18/2016 15:24, Hans Verkuil wrote: On 04/13/2016 09:44 AM, Songjun Wu wrote: Add driver for the Image Sensor Controller. It manages incoming data from a parallel based CMOS/CCD sensor. It has an internal image processor, also integrates a triple channel direct memory access controller mas

Re: [PATCH 1/2] [media] atmel-isc: add the Image Sensor Controller code

2016-04-19 Thread Wu, Songjun
On 4/15/2016 00:21, Laurent Pinchart wrote: >+ return -EINVAL; >+ >+ parent_names = kcalloc(num_parents, sizeof(char *), GFP_KERNEL); >+ if (!parent_names) >+ return -ENOMEM; >+ >+ of_clk_parent_fill(np, parent_names, num_parents); >+ >+ init.parent_names = par

Re: [PATCH] atmel-isc: fix platform_no_drv_owner.cocci warnings

2016-04-13 Thread Wu, Songjun
Accept. Thank you for your comments. On 4/13/2016 16:46, Julia Lawall wrote: Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci CC: Songjun Wu Signed-off-by: Fengguang Wu Signed-off-by: Julia Lawall --- atme

Re: [PATCH] atmel-isc: fix compare_const_fl.cocci warnings

2016-04-13 Thread Wu, Songjun
Accept. Thank you for your comments. On 4/13/2016 16:49, Julia Lawall wrote: Move constants to the right of binary operators. Generated by: scripts/coccinelle/misc/compare_const_fl.cocci CC: Songjun Wu Signed-off-by: Fengguang Wu Signed-off-by: Julia Lawall --- Up to you. Seems a tiny bit

Re: [PATCH] ASoC: Atmel: ClassD: Set GCK's parent clock

2015-11-22 Thread Wu, Songjun
On 11/21/2015 02:08, Mark Brown wrote: On Thu, Nov 19, 2015 at 11:26:30AM +0800, Songjun Wu wrote: Set GCK's parent clock as audio clock, make sure the GCK's parent clock is audio clock. + ret = clk_set_parent(dd->gclk, dd->aclk); + if (ret) { + dev_err(dev, "faile

Re: [PATCH 2/2] ASoC: atmel-classd: DT binding for Class D audio amplifier driver

2015-09-14 Thread Wu, Songjun
On 9/8/2015 20:23, Mark Brown wrote: On Tue, Sep 08, 2015 at 05:36:13PM +0800, Wu, Songjun wrote: On 9/8/2015 00:25, Mark Brown wrote: Sure, there's no problem at all having that structure in software but it should be possible to do this without having to represent this structure

Re: [PATCH] [media] atmel-isc: add the isc pipeline function

2017-01-09 Thread Wu, Songjun
Hi Hans, Thank you for your comments. On 1/9/2017 20:10, Hans Verkuil wrote: + +static int isc_s_ctrl(struct v4l2_ctrl *ctrl) +{ + struct isc_device *isc = container_of(ctrl->handler, +struct isc_device, ctrls.handler); + struct isc_ctrls

Re: [PATCH v5 2/2] [media] atmel-isc: DT binding for Image Sensor Controller driver

2016-06-23 Thread Wu, Songjun
Hi Rob, Thank you for your comments. On 6/20/2016 21:25, Rob Herring wrote: On Fri, Jun 17, 2016 at 04:57:14PM +0800, Songjun Wu wrote: DT binding documentation for ISC driver. Signed-off-by: Songjun Wu --- Changes in v5: - Add clock names. Changes in v4: - Remove the isc clock nodes. Cha

Re: [PATCH v5 2/2] [media] atmel-isc: DT binding for Image Sensor Controller driver

2016-06-24 Thread Wu, Songjun
On 6/24/2016 15:35, Boris Brezillon wrote: On Fri, 24 Jun 2016 13:54:09 +0800 "Wu, Songjun" wrote: Hi Rob, Thank you for your comments. On 6/20/2016 21:25, Rob Herring wrote: On Fri, Jun 17, 2016 at 04:57:14PM +0800, Songjun Wu wrote: DT binding documentation for ISC driver.

Re: [PATCH v5 0/2] [media] atmel-isc: add driver for Atmel ISC

2016-07-03 Thread Wu, Songjun
On 7/1/2016 20:20, Hans Verkuil wrote: Hi Songjun, First of all, please CC patch 2/2 to linux-media as well the next time you post this. I only see 1/2 on the mailinglist, and we need both. Secondly, before I can accept it you need to run the v4l2-compliance test first and I need to see the

Re: [PATCH] [media] atmel-isc: release the filehandle if it's not the only one.

2016-11-01 Thread Wu, Songjun
Sorry, my mistake, the device should be able to opened multiple times. It's a wrong patch. On 11/1/2016 16:52, Hans Verkuil wrote: On 01/11/16 09:08, Songjun Wu wrote: Release the filehandle in 'isc_open' if it's not the only filehandle opened for the associated video_device. What's wrong wit

Re: [PATCH] kobject: set state_initialized to 0 in kobject_cleanup

2016-11-01 Thread Wu, Songjun
On 11/1/2016 22:56, Greg KH wrote: On Tue, Nov 01, 2016 at 06:41:44PM +0800, Songjun Wu wrote: If state_initialized is not set to 0 when a kobject is released, a device is registered, unregistered, and registered again, the error below will occur. kobject (dec04bb0): tried to init an initiali

Re: [PATCH] [media] atmel-isc: fix off-by-one comparison and out of bounds read issue

2017-03-07 Thread Wu, Songjun
Hi Colin, Thank you for your comment. It is a bug, will be fixed in the next patch. On 3/7/2017 22:30, Colin King wrote: From: Colin Ian King The are only HIST_ENTRIES worth of entries in hist_entry however the for-loop is iterating one too many times leasing to a read access off the end off

Re: [PATCH] [media] atmel-isc: fix off-by-one comparison and out of bounds read issue

2017-03-12 Thread Wu, Songjun
On 3/9/2017 19:50, Colin Ian King wrote: On 09/03/17 11:49, walter harms wrote: Am 09.03.2017 11:57, schrieb Hans Verkuil: Hi Songjun, On 08/03/17 03:25, Wu, Songjun wrote: Hi Colin, Thank you for your comment. It is a bug, will be fixed in the next patch. Do you mean that you will

Re: [PATCH] [media] atmel-isc: fix off-by-one comparison and out of bounds read issue

2017-03-12 Thread Wu, Songjun
On 3/9/2017 18:57, Hans Verkuil wrote: Hi Songjun, On 08/03/17 03:25, Wu, Songjun wrote: Hi Colin, Thank you for your comment. It is a bug, will be fixed in the next patch. Do you mean that you will provide a new patch for this? Is there anything wrong with this patch? It seems reasonable

Re: [PATCH] [media] atmel-isc: fix off-by-one comparison and out of bounds read issue

2017-03-13 Thread Wu, Songjun
On 3/13/2017 17:25, Hans Verkuil wrote: On 03/13/2017 06:53 AM, Wu, Songjun wrote: On 3/9/2017 18:57, Hans Verkuil wrote: Hi Songjun, On 08/03/17 03:25, Wu, Songjun wrote: Hi Colin, Thank you for your comment. It is a bug, will be fixed in the next patch. Do you mean that you will

Re: [PATCH v8 1/2] [media] atmel-isc: add the Image Sensor Controller code

2016-08-10 Thread Wu, Songjun
On 8/8/2016 17:56, Hans Verkuil wrote: On 08/08/2016 11:37 AM, Hans Verkuil wrote: On 08/03/2016 10:08 AM, Songjun Wu wrote: Add driver for the Image Sensor Controller. It manages incoming data from a parallel based CMOS/CCD sensor. It has an internal image processor, also integrates a triple

Re: [PATCH v8 1/2] [media] atmel-isc: add the Image Sensor Controller code

2016-08-10 Thread Wu, Songjun
On 8/10/2016 15:12, Hans Verkuil wrote: On 08/10/2016 07:36 AM, Wu, Songjun wrote: On 8/8/2016 17:56, Hans Verkuil wrote: On 08/08/2016 11:37 AM, Hans Verkuil wrote: On 08/03/2016 10:08 AM, Songjun Wu wrote: Add driver for the Image Sensor Controller. It manages incoming data from a

Re: [PATCH v7 1/2] [media] atmel-isc: add the Image Sensor Controller code

2016-08-01 Thread Wu, Songjun
On 8/1/2016 17:47, Hans Verkuil wrote: Hi Songjun, Some more comments below. Except for one in the open/release functions it's all small things. On 07/29/2016 09:54 AM, Songjun Wu wrote: Add driver for the Image Sensor Controller. It manages incoming data from a parallel based CMOS/CCD senso

Re: [PATCH v7 1/2] [media] atmel-isc: add the Image Sensor Controller code

2016-08-02 Thread Wu, Songjun
On 8/2/2016 15:32, Hans Verkuil wrote: On 08/02/2016 08:20 AM, Wu, Songjun wrote: +static unsigned int sensor_preferred = 1; +module_param(sensor_preferred, uint, S_IRUGO|S_IWUSR); +MODULE_PARM_DESC(sensor_preferred, +"Sensor is preferred to output the specified format

Re: [PATCH v4 2/2] [media] atmel-isc: DT binding for Image Sensor Controller driver

2016-06-11 Thread Wu, Songjun
On 6/9/2016 05:57, Boris Brezillon wrote: On Tue, 7 Jun 2016 15:11:53 +0800 Songjun Wu wrote: DT binding documentation for ISC driver. Signed-off-by: Songjun Wu --- Changes in v4: - Remove the isc clock nodes. Changes in v3: - Remove the 'atmel,sensor-preferred'. - Modify the isc clock n

Re: [PATCH v4 2/2] [media] atmel-isc: DT binding for Image Sensor Controller driver

2016-06-12 Thread Wu, Songjun
On 6/12/2016 15:23, Boris Brezillon wrote: On Sun, 12 Jun 2016 11:04:27 +0800 "Wu, Songjun" wrote: On 6/9/2016 05:57, Boris Brezillon wrote: On Tue, 7 Jun 2016 15:11:53 +0800 Songjun Wu wrote: DT binding documentation for ISC driver. Signed-off-by: Songjun Wu --- Cha

Re: [PATCH v4 2/2] [media] atmel-isc: DT binding for Image Sensor Controller driver

2016-06-12 Thread Wu, Songjun
On 6/9/2016 04:00, Rob Herring wrote: On Tue, Jun 07, 2016 at 03:11:53PM +0800, Songjun Wu wrote: DT binding documentation for ISC driver. Signed-off-by: Songjun Wu --- Changes in v4: - Remove the isc clock nodes. Changes in v3: - Remove the 'atmel,sensor-preferred'. - Modify the isc clock

Re: [PATCH v3 2/2] [media] atmel-isc: DT binding for Image Sensor Controller driver

2016-06-05 Thread Wu, Songjun
Hi Rob, Thank you for your comments. On 6/3/2016 07:16, Rob Herring wrote: On Tue, May 31, 2016 at 02:58:23PM +0800, Songjun Wu wrote: DT binding documentation for ISC driver. Signed-off-by: Songjun Wu --- Changes in v3: - Remove the 'atmel,sensor-preferred'. - Modify the isc clock node acc

Re: [PATCH v3 2/2] [media] atmel-isc: DT binding for Image Sensor Controller driver

2016-06-05 Thread Wu, Songjun
On 6/3/2016 19:10, Boris Brezillon wrote: On Thu, 2 Jun 2016 18:16:09 -0500 Rob Herring wrote: On Tue, May 31, 2016 at 02:58:23PM +0800, Songjun Wu wrote: DT binding documentation for ISC driver. Signed-off-by: Songjun Wu --- Changes in v3: - Remove the 'atmel,sensor-preferred'. - Modify

Re: [PATCH v2 0/2] ASoC: atmel-classd: add driver for Atmel CLASSD

2015-09-27 Thread Wu, Songjun
On 9/26/2015 02:07, Mark Brown wrote: On Thu, Sep 24, 2015 at 01:41:25PM +0800, Songjun Wu wrote: Songjun Wu (2): ASoC: atmel-classd: add the Audio Class D Amplifier ASoC: atmel-classd: DT binding for Class D audio amplifier driver I don't seem to have the second patch with the bindin

Re: [alsa-devel] [PATCH] ASoC: atmel-classd: fix odd_ptr_err.cocci warnings

2015-09-28 Thread Wu, Songjun
On 9/28/2015 19:26, Peter Korsgaard wrote: "kbuild" == kbuild test robot writes: > sound/soc/atmel/atmel-classd.c:578:5-11: inconsistent IS_ERR and PTR_ERR, PTR_ERR on line 579 > PTR_ERR should access the value just tested by IS_ERR > Semantic patch information: > There can be fa

Re: [PATCH 2/2] ASoC: atmel-classd: DT binding for Class D audio amplifier driver

2015-09-16 Thread Wu, Songjun
On 9/17/2015 03:42, Mark Brown wrote: On Tue, Sep 15, 2015 at 11:11:53AM +0800, Wu, Songjun wrote: I try to use one entry, but there is a problem. It's about 'driver_data' in struct device. In function snd_soc_register_card, the parameter 'card' will be set to

Re: [PATCH 2/2] [media] atmel-isc: mark PM functions as __maybe_unused

2016-09-12 Thread Wu, Songjun
Hi Arnd, Thank you for your patch. I think it's better to add switch CONFIG_PM, but the PM feature is a must, or the ISC can not work, maybe the best choice is to add 'depends on PM' in Kconfig. #ifdef CONFIG_PM isc_runtime_suspend { XXX } isc_runtime_resume { XXX } static c

Re: [PATCH v9 0/2] [media] atmel-isc: add driver for Atmel ISC

2016-08-14 Thread Wu, Songjun
On 8/12/2016 15:32, Hans Verkuil wrote: One quick question: On 08/11/2016 09:06 AM, Songjun Wu wrote: The Image Sensor Controller driver includes two parts. 1) Driver code to implement the ISC function. 2) Device tree binding documentation, it describes how to add the ISC in device tree.

Re: [PATCH v9 0/2] [media] atmel-isc: add driver for Atmel ISC

2016-08-15 Thread Wu, Songjun
On 8/15/2016 15:15, Hans Verkuil wrote: On 08/15/2016 08:09 AM, Wu, Songjun wrote: On 8/12/2016 15:32, Hans Verkuil wrote: One quick question: On 08/11/2016 09:06 AM, Songjun Wu wrote: The Image Sensor Controller driver includes two parts. 1) Driver code to implement the ISC function. 2

Re: [PATCH v9 0/2] [media] atmel-isc: add driver for Atmel ISC

2016-08-15 Thread Wu, Songjun
On 8/15/2016 15:34, Hans Verkuil wrote: On 08/11/2016 09:06 AM, Songjun Wu wrote: The Image Sensor Controller driver includes two parts. 1) Driver code to implement the ISC function. 2) Device tree binding documentation, it describes how to add the ISC in device tree. So close... Running