[PATCH -next] [media] go7007: fix invalid use of sizeof in go7007_usb_i2c_master_xfer()

2013-03-26 Thread Wei Yongjun
From: Wei Yongjun yongjun_...@trendmicro.com.cn sizeof() when applied to a pointer typed expression gives the size of the pointer, not that of the pointed data. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn --- drivers/staging/media/go7007/go7007-usb.c | 2 +- 1 file changed, 1

Re: [PATCH -next] [media] go7007: fix invalid use of sizeof in go7007_usb_i2c_master_xfer()

2013-03-26 Thread Dan Carpenter
On Tue, Mar 26, 2013 at 02:42:47PM +0800, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn sizeof() when applied to a pointer typed expression gives the size of the pointer, not that of the pointed data. This fix isn't right. buf is a char pointer. I don't know what this

[PATCH v2] [media] s5p-mfc: Modify encoder buffer alloc sequence

2013-03-26 Thread Arun Kumar K
MFC v6 needs minimum number of output buffers to be queued for encoder depending on the stream type and profile. For achieving this the sequence for allocating buffers at the encoder is modified similar to that of decoder. The new sequence is as follows: 1) Set format on CAPTURE plane 2) REQBUF

Re: [PATCH -next] [media] go7007: fix invalid use of sizeof in go7007_usb_i2c_master_xfer()

2013-03-26 Thread Dan Carpenter
On Tue, Mar 26, 2013 at 10:04:15AM +0300, Dan Carpenter wrote: On Tue, Mar 26, 2013 at 02:42:47PM +0800, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn sizeof() when applied to a pointer typed expression gives the size of the pointer, not that of the pointed data.

Re: [PATCH -next] [media] go7007: fix invalid use of sizeof in go7007_usb_i2c_master_xfer()

2013-03-26 Thread Hans Verkuil
On Tue March 26 2013 08:35:57 Dan Carpenter wrote: On Tue, Mar 26, 2013 at 10:04:15AM +0300, Dan Carpenter wrote: On Tue, Mar 26, 2013 at 02:42:47PM +0800, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn sizeof() when applied to a pointer typed expression gives the

Re: Terratec Grabby hwrev 2

2013-03-26 Thread Timo Teras
On Mon, 25 Mar 2013 21:12:38 +0200 Timo Teras timo.te...@iki.fi wrote: On Mon, 25 Mar 2013 15:32:20 -0300 Mauro Carvalho Chehab mche...@redhat.com wrote: Em Mon, 25 Mar 2013 19:48:20 +0200 Timo Teras timo.te...@iki.fi escreveu: On Mon, 25 Mar 2013 14:36:47 -0300 Mauro Carvalho

Re: [PATCH -next] [media] go7007: remove unused including linux/version.h

2013-03-26 Thread Hans Verkuil
On Tue March 26 2013 06:45:51 Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Remove including linux/version.h that don't need it. The include is already removed. Regards, Hans Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn ---

Re: [PATCH -next] [media] tw9906: remove unused including linux/version.h

2013-03-26 Thread Hans Verkuil
On Tue March 26 2013 06:51:54 Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Remove including linux/version.h that don't need it. The include has already been removed. Regards, Hans Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn ---

Re: [PATCH -next] [media] go7007: fix invalid use of sizeof in go7007_usb_i2c_master_xfer()

2013-03-26 Thread Wei Yongjun
Hi Hans and Dan Carpenter, On 03/26/2013 04:18 PM, Hans Verkuil wrote: On Tue March 26 2013 08:35:57 Dan Carpenter wrote: On Tue, Mar 26, 2013 at 10:04:15AM +0300, Dan Carpenter wrote: On Tue, Mar 26, 2013 at 02:42:47PM +0800, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn

[PATCH -next v2] [media] go7007: fix invalid use of sizeof in go7007_usb_i2c_master_xfer()

2013-03-26 Thread Wei Yongjun
From: Wei Yongjun yongjun_...@trendmicro.com.cn sizeof() when applied to a pointer typed expression gives the size of the pointer, not that of the pointed data. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn --- drivers/staging/media/go7007/go7007-usb.c | 2 +- 1 file changed, 1

Re: [PATCH -next v2] [media] go7007: fix invalid use of sizeof in go7007_usb_i2c_master_xfer()

2013-03-26 Thread Hans Verkuil
On Tue March 26 2013 09:45:11 Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn sizeof() when applied to a pointer typed expression gives the size of the pointer, not that of the pointed data. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn Acked-by: Hans Verkuil

Re: [PATCH -next] [media] af9035: fix missing unlock on error in af9035_ctrl_msg()

2013-03-26 Thread Antti Palosaari
On 03/26/2013 07:32 AM, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Add the missing unlock before return from function af9035_ctrl_msg() in the error handling case. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn Acked-by: Antti Palosaari cr...@iki.fi

Re: [PATCH -next] [media] af9035: fix missing unlock on error in af9035_ctrl_msg()

2013-03-26 Thread Antti Palosaari
@Mauro, that bug is new and coming as I rebased AF9035 IR code to the new AF9035 non-stacked usb buffers, which introduces that mutex. Just apply it to the current master. regards Antti On 03/26/2013 11:46 AM, Antti Palosaari wrote: On 03/26/2013 07:32 AM, Wei Yongjun wrote: From: Wei

[PATCH] Fix undefined reference to `au8522_attach'

2013-03-26 Thread Hans Verkuil
au8522_attach is dependent on CONFIG_DVB_AU8522_DTV, not CONFIG_DVB_AU8522. Signed-off-by: Hans Verkuil hans.verk...@cisco.com diff --git a/drivers/media/dvb-frontends/au8522.h b/drivers/media/dvb-frontends/au8522.h index f2111e0..83fe9a6 100644 --- a/drivers/media/dvb-frontends/au8522.h +++

Re: [RFC 01/12] exynos-fimc-is: Adding device tree nodes

2013-03-26 Thread Arun Kumar K
Hi Sylwester, Thank you for the review. +Sensor sub-nodes: + +FIMC-IS IP supports custom built sensors to be controlled exclusively by +the FIMC-IS firmware. These sensor properties are to be defined here. [snip] Defining image sensor nodes in a standard way as ISP I2C bus controller

Re: [PATCH] block i2c tuner reads for Avermedia Twinstar in the af9035 driver

2013-03-26 Thread Jose Alberto Reguero
On Domingo, 24 de marzo de 2013 20:39:15 Jose Alberto Reguero escribió: On Domingo, 17 de marzo de 2013 23:46:06 Antti Palosaari escribió: On 03/17/2013 08:49 PM, Jose Alberto Reguero wrote: On Martes, 12 de marzo de 2013 00:11:38 Antti Palosaari escribió: On 03/11/2013 10:02 PM, Jose

[PATCH] staging: davinci: Fix typo in staging/media/davinci

2013-03-26 Thread Masanari Iida
Correct spelling typo in staging/media/davinci Signed-off-by: Masanari Iida standby2...@gmail.com --- drivers/staging/media/davinci_vpfe/davinci-vpfe-mc.txt | 2 +- drivers/staging/media/davinci_vpfe/dm365_isif.c| 6 +++--- drivers/staging/media/davinci_vpfe/vpfe_video.c| 8

[PATCH v7] [media] Add common video interfaces OF bindings documentation

2013-03-26 Thread Sylwester Nawrocki
From: Guennadi Liakhovetski g.liakhovet...@gmx.de This patch adds a document describing common OF bindings for video capture, output and video processing devices. It is curently mainly focused on video capture devices, with data busses defined by standards such as ITU-R BT.656 or MIPI-CSI2. It

[REVIEW PATCH 0/3] s5p-fimc driver updates

2013-03-26 Thread Sylwester Nawrocki
This patch series contains mostly conversion of the video capture node drivers to videobuf2 ioctl/fop helpers. Sylwester Nawrocki (3): s5p-fimc: Use video entity for marking media pipeline as streaming s5p-fimc: Use vb2 ioctl/fop helpers in FIMC capture driver s5p-fimc: Use vb2 ioctl

[REVIEW PATCH 1/3] s5p-fimc: Use video entity for marking media pipeline as streaming

2013-03-26 Thread Sylwester Nawrocki
It doesn't matter whether we start from the sensor of from the video node entity. Remove use of pipeline-subdevs array where possible, so we can partly drop dependency on struct fimc_pipeline in the fimc-lite module, which is also used by the exynos5-is driver. Also make sure we revert any media

[REVIEW PATCH 2/3] s5p-fimc: Use vb2 ioctl/fop helpers in FIMC capture driver

2013-03-26 Thread Sylwester Nawrocki
mmap/poll file operation and several ioctl handlers are replaced with the vb2 helper functions. Some helpers are used indirectly to maintain the buffer queue ownership. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com ---

[REVIEW PATCH 3/3] s5p-fimc: Use vb2 ioctl helpers in fimc-lite

2013-03-26 Thread Sylwester Nawrocki
Replace some ioctl, file and video buffer queue operation handlers with the videobuf2 helpers. This allows to get rid of significant amount of boilerplate. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com ---

[PATCH v5 0/6] Device tree support for Exynos SoC camera subsystem

2013-03-26 Thread Sylwester Nawrocki
Changes in this iteration include mostly adaptation to changes at the V4L2 OF parser lib and an addition of clocks/clock-names properties in the bindings of the IP blocks. If there is no more comments I intend to send a pull request including the DT bindings documentation, the V4L2 OF parser and

[PATCH v5 1/6] s5p-csis: Add device tree support

2013-03-26 Thread Sylwester Nawrocki
This patch support for binding the driver to the MIPI-CSIS devices instantiated from device tree and parsing the SoC and board specific properties. The MIPI CSI-2 channel is determined by the value of reg property placed in csis' port subnode. Signed-off-by: Sylwester Nawrocki

[PATCH v5 2/6] s5p-fimc: Add device tree support for FIMC device driver

2013-03-26 Thread Sylwester Nawrocki
This patch adds device tree support for FIMC driver on S5PV210 and Exynos4 SoCs. The FIMC IP block's features and quirks encoded statically in the driver are now parsed from the device tree. Once all relevant platforms are converted to device tree based booting the FIMC variant data structures

[PATCH v5 3/6] s5p-fimc: Add device tree support for FIMC-LITE device driver

2013-03-26 Thread Sylwester Nawrocki
This patch adds the device tree support for FIMC-LITE device driver. The bindings include compatible property for the Exynos5 SoC series, however the actual implementation for these SoCs will be added in a separate patch. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by:

[PATCH v5 4/6] s5p-fimc: Add device tree support for the media device driver

2013-03-26 Thread Sylwester Nawrocki
This patch adds changes required for the main camera media device driver corresponding to the top level 'camera' device node. The drivers of devices corresponding to child nodes of the 'camera' node are looked up and and registered as sub-devices to the top level driver. The main driver's probing

[PATCH v5 5/6] s5p-fimc: Add device tree based sensors registration

2013-03-26 Thread Sylwester Nawrocki
The sensor (I2C and/or SPI client) devices are instantiated by their corresponding control bus drivers. Since the I2C client's master clock is often provided by a video bus receiver (host interface) or other than I2C/SPI controller device, the drivers of those client devices are not accessing

[PATCH v5 6/6] s5p-fimc: Use pinctrl API for camera ports configuration

2013-03-26 Thread Sylwester Nawrocki
Before the camera ports can be used the pinmux needs to be configured properly. This patch adds a function to set the camera ports pinctrl to a default state within the media driver's probe(). The camera port(s) are then configured for the video bus operation. Signed-off-by: Sylwester Nawrocki

Re: [PATCH v5 0/6] Device tree support for Exynos SoC camera subsystem

2013-03-26 Thread Sylwester Nawrocki
On 03/26/2013 05:39 PM, Sylwester Nawrocki wrote: Changes in this iteration include mostly adaptation to changes at the V4L2 OF parser lib and an addition of clocks/clock-names properties in the bindings of the IP blocks. If there is no more comments I intend to send a pull request including

[PATCH v2 00/10] s5p-fimc: Exynos4x12 FIMC-IS support prerequisite

2013-03-26 Thread Sylwester Nawrocki
This patch series contains a few fixes to the s5p-fimc driver and changes necessary for the Exynos4x12 FIMC-IS support. The changes are listed at each patch, if there were any. I have removed two patches, adding support for setting parent clocks and added a patch changing the driver directory to

[PATCH v2 01/10] V4L: Add MATRIX option to V4L2_CID_EXPOSURE_METERING control

2013-03-26 Thread Sylwester Nawrocki
This patch adds a menu option to the V4L2_CID_EXPOSURE_METERING control for multi-zone metering. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- Documentation/DocBook/media/v4l/controls.xml |7 +++

[PATCH v2 02/10] s5p-fimc: Add error checks for pipeline stream on callbacks

2013-03-26 Thread Sylwester Nawrocki
From: Andrzej Hajda a.ha...@samsung.com set_stream error for pipelines is logged or reported to user space if possible. Signed-off-by: Andrzej Hajda a.ha...@samsung.com Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com ---

[PATCH v2 04/10] s5p-fimc: Add support for PIXELASYNCMx clocks

2013-03-26 Thread Sylwester Nawrocki
This patch ads handling of clocks for the CAMBLK subsystem which is a glue logic for FIMC-IS or LCD controller and FIMC IP. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- Changes since v1: - Do not keep PXLASYNC clocks always

[PATCH v2 05/10] s5p-fimc: Add support for ISP Writeback data input bus type

2013-03-26 Thread Sylwester Nawrocki
A second sink pad is added to each FIMC.N subdev that will be used to link it to the FIMC-IS-ISP subdev. Only V4L2_MBUS_FMT_YUV10_1X30 format is supported at this pad (FIMC_SD_PAD_SINK_FIFO). The routine checking for mismatch in the image formats at sides of the links is updated to account for

[PATCH v2 03/10] s5p-fimc: Update graph traversal for entities with multiple source pads

2013-03-26 Thread Sylwester Nawrocki
We cannot assume that the passed entity the fimc_pipeline_prepare() function is supposed to start the media graph traversal from will always have its sink pad at pad index 0. Find the starting media entity's sink pad by iterating over its all pads and checking the pad flags. This ensures proper

[PATCH v2 06/10] s5p-fimc: Ensure CAMCLK clock can be enabled by FIMC-LITE devices

2013-03-26 Thread Sylwester Nawrocki
In configurations where FIMC-LITE is used to capture image signal from an external sensor only we need to ensure one of FIMC devices is in active power state and the fimc gate clock is enabled. Otherwise the CAMCLK clock output signal will be masked off preventing an external sensor's operation.

[PATCH v2 07/10] s5p-fimc: Ensure proper s_stream() call order in the ISP datapaths

2013-03-26 Thread Sylwester Nawrocki
Since the FIMC-IS firmware communicates with an image sensor directly through the ISP I2C bus controllers data streaming cannot be simply enabled from left to right or disabled from right to left along the processing pipeline. Thus a subdev index to call s_stream() on is looked up from a table,

[PATCH v2 09/10] s5p-fimc: Remove dependency on fimc-core.h in fimc-lite driver

2013-03-26 Thread Sylwester Nawrocki
Drop fimc-lite.h header inclusion to make the exynos-fimc-lite module independent on other modules. Move struct fimc_fmt declaration to the driver's private headers as it is used in multiple modules. Reported-by: Shaik Ameer Basha shaik.am...@samsung.com Signed-off-by: Sylwester Nawrocki

[PATCH v2 10/10] s5p-fimc: Change the driver directory name to exynos4-is

2013-03-26 Thread Sylwester Nawrocki
The s5p-fimc directory now contains drivers for multiple IP blocks found in multiple Samsung application processors. This includes FIMC (CAMIF), MIPI CSIS and FIMC LITE. FIMC-IS (Imaging Subsystem) driver is going to be put into same directory. Hence we rename it to exynos4-is as s5p-fimc was only

[PATCH v3 0/5] em28xx: add support for the em2765 bridge

2013-03-26 Thread Frank Schäfer
This patch series adds basic support for the em25xx/276x/7x/8x camera bridges. These devices differ from the em2710/2750 and em28xx bridges in several points: 1) a second i2c bus is provided which has to be accessed with a different read/write algorithm (= patch 1) 2) a different frame data

[PATCH v3 2/5] em28xx: add chip id of the em2765

2013-03-26 Thread Frank Schäfer
This chip can be found in the SpeedLink VAD Laplace webcam (1ae7:9003 and 1ae7:9004). Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-cards.c | 13 - drivers/media/usb/em28xx/em28xx-reg.h |1 + drivers/media/usb/em28xx/em28xx.h

[PATCH v3 4/5] em28xx: make em28xx_set_outfmt() working with EM25xx family bridges

2013-03-26 Thread Frank Schäfer
Streaming doesn't work with the EM2765 if bit 5 of the output format register 0x27 is set. It's actually not clear if really has to be set for the other chips, but for now let's keep it to avoid regressions and add a comment to the code. Signed-off-by: Frank Schäfer fschaefer@googlemail.com

[PATCH v3 5/5] em28xx: write output frame resolution to regs 0x34+0x35 for em25xx family bridges

2013-03-26 Thread Frank Schäfer
The Windows driver writes the output resolution to registers 0x34 (width / 16) and 0x35 (height / 16) always. We don't know yet what these registers are used for. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-core.c |7 +++

[PATCH v3 1/5] em28xx: add support for em25xx i2c bus B read/write/check device operations

2013-03-26 Thread Frank Schäfer
The webcam SpeedLink VAD Laplace (em2765 + ov2640) uses a special algorithm for i2c communication with the sensor, which is connected to a second i2c bus. We don't know yet how to find out which devices support/use it. It's very likely used by all em25xx and em276x+ bridges. Tests with other

[PATCH v3 3/5] em28xx: add support for em25xx/em276x/em277x/em278x frame data processing

2013-03-26 Thread Frank Schäfer
The em25xx/em276x/em277x/em278x frame data format is different to the one used by the em2710/em2750/em28xx chips. With the recent cleanups and reorganization of the frame data processing code it can be easily extended to support these devices. Signed-off-by: Frank Schäfer

[PATCH v2 0/7] V4L2 driver for Exynos4x12 Imaging Subsystem

2013-03-26 Thread Sylwester Nawrocki
This iteration includes couple bug fixes and minor cleanup comparing to the original version (original cover letter can be found below). A patch adding ISP capture node has been removed as I'll need more time to enable this feature and I'd like to possibly have this series included in 3.10.

[PATCH v2 2/7] exynos4-is: Add FIMC-IS ISP I2C bus driver

2013-03-26 Thread Sylwester Nawrocki
This patch adds the ISP I2C bus controller driver files. Creating a standard I2C bus adapter, even if the driver doesn't actually communicates with the hardware and it is instead used by the ISP firmware running on the Cortex-A5, allows to use standard hardware description in the device tree. As

[PATCH v2 3/7] exynos4-is: Add FIMC-IS parameter region definitions

2013-03-26 Thread Sylwester Nawrocki
This patch adds ISP processing parameters interface files. Signed-off-by: Younghwan Joo yhwan@samsung.com Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/exynos4-is/fimc-is-param.c | 971

[PATCH v2 4/7] exynos4-is: Add common FIMC-IS image sensor driver

2013-03-26 Thread Sylwester Nawrocki
This patch adds a common image sensor driver and Makefile/Kconfig to enable cpmpilation of the whole IS drives. The sensor subdev driver currently only handles an image sensor's power supplies and reset signal. There is no an I2C communication as it is handled by the ISP's firmware.

[PATCH v2 5/7] exynos4-is: Add Exynos4x12 FIMC-IS device tree bindings documentation

2013-03-26 Thread Sylwester Nawrocki
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- .../devicetree/bindings/media/exynos4-fimc-is.txt | 45 1 file changed, 45 insertions(+) create mode 100644

[PATCH v2 7/7] s5p-fimc: Create media links for the FIMC-IS entities

2013-03-26 Thread Sylwester Nawrocki
Create disabled links from the FIMC-LITE subdevs to the FIMC-IS-ISP subdev and from FIMC-IS-ISP to all FIMC subdevs. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/exynos4-is/media-dev.c | 83

[PATCH v2 6/7] s5p-fimc: Add fimc-is subdevs registration

2013-03-26 Thread Sylwester Nawrocki
This patch allows to register FIMC-IS device represented by FIMC-IS-ISP subdev to the top level media device driver. The use_isp platform data structure field allows to select whether the fimc-is ISP subdev should be tried to be registered or not. Signed-off-by: Sylwester Nawrocki

[PATCH v2 0/4] exynos4-is updates

2013-03-26 Thread Sylwester Nawrocki
This patch series includes YUV order handling fix for the FIMC and FIMC-LITE, a fix for media entity ref_count issue, minor refactoring and removal of some static data that will no longer be needed since starting from 3.10 Exynos platform is going to be DT only. All dependencies of this series

[PATCH v2 1/5] exynos4-is: Remove static driver data for Exynos4210 FIMC variants

2013-03-26 Thread Sylwester Nawrocki
All Exynos4210 based boards files using FIMC are going to be removed in 3.10 and corresponding device trees are to be used instead. The FIMC variant data will be parsed directly form the device tree for those SoCs as well. Hence now unused static data is removed. Signed-off-by: Sylwester Nawrocki

[PATCH v2 1/4] exynos4-is: Use common driver data for all FIMC-LITE IP instances

2013-03-26 Thread Sylwester Nawrocki
There is no need to use separate variant data structure for each FIMC-LITE IP instance. According to my knowledge there are no differences across them on Exynos4 as well as Exynos5 SoCs. Drop flite_variant data structure and use struct flite_drvdata instead. Signed-off-by: Sylwester Nawrocki

[PATCH v2 2/4] exynos4-is: Allow colorspace conversion at fimc-lite

2013-03-26 Thread Sylwester Nawrocki
The FIMC-LITE output DMA allows to configure different YUV order than the order at the camera input interface. Thus there is some limited colorspace conversion possible. This patch makes the color format variable be per FIMC-LITE input/output, rather than a global per device. This also fixes

[PATCH v2 2/5] exynos4-is: Use common driver data for all FIMC-LITE IP instances

2013-03-26 Thread Sylwester Nawrocki
There is no need to use separate variant data structure for each FIMC-LITE IP instance. According to my knowledge there are no differences across them on Exynos4 as well as Exynos5 SoCs. Drop flite_variant data structure and use struct flite_drvdata instead. Signed-off-by: Sylwester Nawrocki

[PATCH v2 3/5] exynos4-is: Allow colorspace conversion at fimc-lite

2013-03-26 Thread Sylwester Nawrocki
The FIMC-LITE output DMA allows to configure different YUV order than the order at the camera input interface. Thus there is some limited colorspace conversion possible. This patch makes the color format variable be per FIMC-LITE input/output, rather than a global per device. This also fixes

[PATCH v2 3/4] exynos4-is: Correct input DMA YUV order configuration

2013-03-26 Thread Sylwester Nawrocki
This patch fixes erroneous setup of the YUV order caused by not clearing FIMC_REG_MSCTRL_ORDER422_MASK bit field before setting proper FIMC_REG_MSCTRL_ORDER422 bits. This resulted in false colors for YUYV, YVYU, UYVY, VYUY color formats, depending in what sequence those were configured by user

[PATCH v2 4/5] exynos4-is: Correct input DMA YUV order configuration

2013-03-26 Thread Sylwester Nawrocki
This patch fixes erroneous setup of the YUV order caused by not clearing FIMC_REG_MSCTRL_ORDER422_MASK bit field before setting proper FIMC_REG_MSCTRL_ORDER422 bits. This resulted in false colors for YUYV, YVYU, UYVY, VYUY color formats, depending in what sequence those were configured by user

[PATCH v2 4/4] exynos4-is: Ensure proper media pipeline state on device close

2013-03-26 Thread Sylwester Nawrocki
Make sure media_entity_pipeline_stop() is called on video device close in cases where there was VIDIOC_STREAMON ioctl and no VIDIOC_STREAMOFF. This patch fixes media entities stream_count state which could prevent links from being disconnected, due to non-zero stream_count. Signed-off-by:

[PATCH v2 5/5] exynos4-is: Ensure proper media pipeline state on device close

2013-03-26 Thread Sylwester Nawrocki
Make sure media_entity_pipeline_stop() is called on video device close in cases where there was VIDIOC_STREAMON ioctl and no VIDIOC_STREAMOFF. This patch fixes media entities stream_count state which could prevent links from being disconnected, due to non-zero stream_count. Signed-off-by:

cron job: media_tree daily build: ERRORS

2013-03-26 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Mar 26 19:00:30 CET 2013 git branch: test git hash: 004e45d736bfe62159bd4dc1549eff414bd27496 gcc

Re: [PATCH v2 0/4] exynos4-is updates

2013-03-26 Thread Sylwester Nawrocki
On 03/26/2013 07:38 PM, Sylwester Nawrocki wrote: This patch series includes YUV order handling fix for the FIMC and FIMC-LITE, a fix for media entity ref_count issue, minor refactoring and removal of some static data that will no longer be needed since starting from 3.10 Exynos platform is

Re: [RFC 01/12] exynos-fimc-is: Adding device tree nodes

2013-03-26 Thread Sylwester Nawrocki
On 03/26/2013 01:17 PM, Arun Kumar K wrote: +Sensor sub-nodes: + +FIMC-IS IP supports custom built sensors to be controlled exclusively by +the FIMC-IS firmware. These sensor properties are to be defined here. [snip] Defining image sensor nodes in a standard way as ISP I2C bus controller

Re: [PATCH v6 1/7] media: V4L2: add temporary clock helpers

2013-03-26 Thread Laurent Pinchart
Hello, On Tuesday 19 March 2013 10:52:29 Sylwester Nawrocki wrote: On 03/19/2013 08:32 AM, Guennadi Liakhovetski wrote: On Mon, 18 Mar 2013, Sylwester Nawrocki wrote: On 03/15/2013 10:27 PM, Guennadi Liakhovetski wrote: [...] diff --git a/drivers/media/v4l2-core/v4l2-clk.c

Re: [PATCH v6 1/7] media: V4L2: add temporary clock helpers

2013-03-26 Thread Laurent Pinchart
Hi Guennadi, On Tuesday 19 March 2013 11:27:56 Guennadi Liakhovetski wrote: On Tue, 19 Mar 2013, Sylwester Nawrocki wrote: + if (!IS_ERR(clk) !try_module_get(clk-ops-owner)) + clk = ERR_PTR(-ENODEV); + mutex_unlock(clk_lock); + + if (!IS_ERR(clk))

Re: [PATCH v6 2/7] media: V4L2: support asynchronous subdevice registration

2013-03-26 Thread Laurent Pinchart
Hi Guennadi, Thanks for the patch. On Friday 15 March 2013 22:27:48 Guennadi Liakhovetski wrote: Currently bridge device drivers register devices for all subdevices synchronously, tupically, during their probing. E.g. if an I2C CMOS sensor is attached to a video bridge device, the bridge

Re: [PATCH v6 3/7] media: soc-camera: switch I2C subdevice drivers to use v4l2-clk

2013-03-26 Thread Laurent Pinchart
Hi Guennadi, Thanks for the patch. On Friday 15 March 2013 22:27:49 Guennadi Liakhovetski wrote: Instead of centrally enabling and disabling subdevice master clocks in soc-camera core, let subdevice drivers do that themselves, using the V4L2 clock API and soc-camera convenience wrappers.

Re: [PATCH 2/2] dma-buf: Add debugfs support

2013-03-26 Thread Laurent Pinchart
Hi Sumit, Thanks for the patch. On Monday 25 March 2013 16:50:46 Sumit Semwal wrote: Add debugfs support to make it easier to print debug information about the dma-buf buffers. Cc: Dave Airlie airl...@redhat.com [minor fixes on init and warning fix] Signed-off-by: Sumit Semwal

Re: [PATCH RFC] [media] add Aptina mt9m114 HD digital image sensor driver

2013-03-26 Thread Laurent Pinchart
Hi Scott, Thank you for the patch. On Friday 18 January 2013 17:00:44 Scott Jiang wrote: This driver support parallel data output mode and QVGA/VGA/WVGA/720P resolution. You can select YCbCr and RGB565 output format. What host bridge do you use this driver with ? Signed-off-by: Scott Jiang

Re: [RFC PATCH 2/6] v4l2: add new VIDIOC_DBG_G_CHIP_NAME ioctl.

2013-03-26 Thread Laurent Pinchart
Hi Hans, On Monday 18 March 2013 17:38:16 Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com Simplify the debugging ioctls by creating the VIDIOC_DBG_G_CHIP_NAME ioctl. This will eventually replace VIDIOC_DBG_G_CHIP_IDENT. Chip matching is done by the name or index of subdevices

Re: [PATCH] [media] s5p-mfc: Change MFC clock reference w.r.t Common Clock Framework

2013-03-26 Thread Mike Turquette
Quoting Prasanna Kumar (2013-03-25 22:20:51) From: Prasanna Kumar prasanna...@samsung.com According to Common Clock framework , modified the method of getting clock for MFC Block. Signed-off-by: Prasanna Kumar prasanna...@samsung.com --- drivers/media/platform/s5p-mfc/s5p_mfc_pm.c |

[PATCH v8 1/9] mfd: Add commands abstraction layer for SI476X MFD

2013-03-26 Thread Andrey Smirnov
From: Andrey Smirnov andreysm@charmander.(none) This patch adds all the functions used for exchanging commands with the chip. Acked-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Andrey Smirnov andrew.smir...@gmail.com --- drivers/mfd/si476x-cmd.c | 1554

[PATCH v8 5/9] v4l2: Fix the type of V4L2_CID_TUNE_PREEMPHASIS in the documentation

2013-03-26 Thread Andrey Smirnov
Change the type of V4L2_CID_TUNE_PREEMPHASIS from 'integer' to 'enum v4l2_preemphasis' Acked-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Andrey Smirnov andrew.smir...@gmail.com --- Documentation/DocBook/media/v4l/controls.xml |2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH v8 0/9] Driver for Si476x series of chips

2013-03-26 Thread Andrey Smirnov
Driver for Si476x series of chips This is a eight version of the patchset originaly posted here: https://lkml.org/lkml/2012/9/13/590 Second version of the patch was posted here: https://lkml.org/lkml/2012/10/5/598 Third version of the patch was posted here: https://lkml.org/lkml/2012/10/23/510

[PATCH v8 3/9] mfd: Add chip properties handling code for SI476X MFD

2013-03-26 Thread Andrey Smirnov
From: Andrey Smirnov andreysm@charmander.(none) This patch adds code related to manipulation of the properties of SI476X chips. Acked-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Andrey Smirnov andrew.smir...@gmail.com --- drivers/mfd/si476x-prop.c | 242

[PATCH v8 6/9] v4l2: Add standard controls for FM receivers

2013-03-26 Thread Andrey Smirnov
This commit introduces new class of standard controls V4L2_CTRL_CLASS_FM_RX. This class is intended to all controls pertaining to FM receiver chips. Also, two controls belonging to said class are added as a part of this commit: V4L2_CID_TUNE_DEEMPHASIS and V4L2_CID_RDS_RECEPTION. This patch is

[PATCH v8 8/9] v4l2: Add private controls base for SI476X

2013-03-26 Thread Andrey Smirnov
Add a base to be used for allocation of all the SI476X specific controls in the corresponding driver. Acked-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Andrey Smirnov andrew.smir...@gmail.com --- include/uapi/linux/v4l2-controls.h |4 1 file changed, 4 insertions(+) diff

[PATCH v8 7/9] v4l2: Add documentation for the FM RX controls

2013-03-26 Thread Andrey Smirnov
Add appropriate documentation for all the newly added standard controls. Based on the patch by Manjunatha Halli [1] [1] http://lists-archives.com/linux-kernel/27641303-media-update-docs-for-v4l2-fm-new-features.html Acked-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Andrey Smirnov

[PATCH v8 4/9] mfd: Add header files and Kbuild plumbing for SI476x MFD core

2013-03-26 Thread Andrey Smirnov
From: Andrey Smirnov andreysm@charmander.(none) This patch adds all necessary header files and Kbuild plumbing for the core driver for Silicon Laboratories Si476x series of AM/FM tuner chips. The driver as a whole is implemented as an MFD device and this patch adds a core portion of it that

[PATCH v8 2/9] mfd: Add the main bulk of core driver for SI476x code

2013-03-26 Thread Andrey Smirnov
From: Andrey Smirnov andreysm@charmander.(none) This patch adds main part(out of three) of the I2C driver for the core of MFD device. Acked-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Andrey Smirnov andrew.smir...@gmail.com --- drivers/mfd/si476x-i2c.c | 886

Re: [PATCH] staging: davinci: Fix typo in staging/media/davinci

2013-03-26 Thread Prabhakar Lad
Hi Masanari, Thanks for the patch! On Tue, Mar 26, 2013 at 8:53 PM, Masanari Iida standby2...@gmail.com wrote: Correct spelling typo in staging/media/davinci Signed-off-by: Masanari Iida standby2...@gmail.com --- drivers/staging/media/davinci_vpfe/davinci-vpfe-mc.txt | 2 +-

Re: [RFC 01/12] exynos-fimc-is: Adding device tree nodes

2013-03-26 Thread Arun Kumar K
On Wed, Mar 27, 2013 at 4:21 AM, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: On 03/26/2013 01:17 PM, Arun Kumar K wrote: +Sensor sub-nodes: + +FIMC-IS IP supports custom built sensors to be controlled exclusively by +the FIMC-IS firmware. These sensor properties are to be defined