[RFC PATCH v8] media: add v4l2 subdev driver for S5K4ECGX sensor

2012-09-13 Thread Sangwook Lee
/brightness/sharpness Signed-off-by: Sangwook Lee Reviewed-by: Sylwester Nawrocki Cc: Francesco Lavra Cc: Scott Bambrough Cc: Homin Lee --- Changes since v7: - added gpio free function - fixed return value of power function Changes since v6: - fixed alignment issue from Francesco, Sylwester

Re: [RFC PATCH v7] media: add v4l2 subdev driver for S5K4ECGX sensor

2012-09-13 Thread Sangwook Lee
ks are correct, but please let me know if I'm > missing something. > See below. > > On 09/12/2012 01:26 PM, Sangwook Lee wrote: >> +static int s5k4ecgx_s_power(struct v4l2_subdev *sd, int on) >> +{ >> + struct s5k4ecgx *priv = to_s5k4ecgx(sd); >> + i

[RFC PATCH v7] media: add v4l2 subdev driver for S5K4ECGX sensor

2012-09-12 Thread Sangwook Lee
/brightness/sharpness Signed-off-by: Sangwook Lee Reviewed-by: Sylwester Nawrocki Cc: Francesco Lavra CC: Scott Bambrough Cc: Homin Lee --- Changes since v6: - fix alignment issue from Francesco, Sylwester Changes since v5: - deleted dummy lines - fixed pointer errors in handling firmware

Re: [RFC PATCH v6] media: add v4l2 subdev driver for S5K4ECGX sensor

2012-09-11 Thread Sangwook Lee
Hi Francesco Thanks for your advice. @ Sylwester Thanks for your nice patch, and I will squash and then send it again. Thanks Sangwook On 10 September 2012 21:29, Sylwester Nawrocki wrote: > On 09/10/2012 08:52 PM, Francesco Lavra wrote: >> On 09/10/2012 05:04 PM, Sylwester Nawrocki wrote:

[RFC PATCH v6] media: add v4l2 subdev driver for S5K4ECGX sensor

2012-09-06 Thread Sangwook Lee
/brightness/sharpness Signed-off-by: Sangwook Lee Reviewed-by: Sylwester Nawrocki --- Changes since v5: - deleted dummy lines - fixed pointer errors in handling firmware - updated comments - added le32_to_cpu,le16_to_cpu Changes since v4: - replaced register tables with the function from Sylwester

Re: [RFC PATCH v5] media: add v4l2 subdev driver for S5K4ECGX sensor

2012-09-06 Thread Sangwook Lee
Hi Sylwester Thank you for the review again. On 5 September 2012 22:56, Sylwester Nawrocki wrote: > Hi Sangwook, > > On 09/05/2012 02:28 PM, Sangwook Lee wrote: [snip] >> +#include > > What do we need this header for ? Ok, let me delete this. > >> + >>

[RFC PATCH v5] media: add v4l2 subdev driver for S5K4ECGX sensor

2012-09-05 Thread Sangwook Lee
/brightness/sharpness Signed-off-by: Sangwook Lee Cc: Sylwester Nawrocki Cc: Scott Bambrough --- Changes since v4: - replaced register tables with the function from Sylwester - updated firmware parsing function with CRC32 check firmware generator from user space: git://git.linaro.org/people

Re: [PATH v3 0/2] Add v4l2 subdev driver for S5K4ECGX sensor with embedded SoC ISP

2012-08-20 Thread Sangwook Lee
Hi Sylwester On 20 August 2012 09:12, Sangwook Lee wrote: > Hi Sylwester > > On 19 August 2012 22:29, Sylwester Nawrocki > wrote: >> Hi Sangwook, >> >> On 08/03/2012 04:24 PM, Sangwook Lee wrote: >>> I was thinking about this, but this seems to be is a bit

Re: [PATH v3 0/2] Add v4l2 subdev driver for S5K4ECGX sensor with embedded SoC ISP

2012-08-20 Thread Sangwook Lee
Hi Sylwester On 19 August 2012 22:29, Sylwester Nawrocki wrote: > Hi Sangwook, > > On 08/03/2012 04:24 PM, Sangwook Lee wrote: >> I was thinking about this, but this seems to be is a bit time-consuming >> because >> I have to do this just due to lack of s5k4ecgx hard

[PATCH v4 2/2] v4l: Add v4l2 subdev driver for S5K4ECGX sensor

2012-08-10 Thread Sangwook Lee
This driver implements preview mode of the S5K4ECGX sensor. capture (snapshot) operation, face detection are missing now. Following controls are supported: contrast/saturation/brightness/sharpness Signed-off-by: Sangwook Lee --- drivers/media/video/Kconfig|8 + drivers/media/video

[PATCH v4 1/2] v4l: Add factory register values form S5K4ECGX sensor

2012-08-10 Thread Sangwook Lee
Add preview default settings for S5K4ECGX sensor registers, which was copied from the reference code of Samsung S.LSI. Signed-off-by: Sangwook Lee --- drivers/media/video/s5k4ecgx_regs.h | 138 +++ 1 file changed, 138 insertions(+) create mode 100644 drivers

[PATCH v4 0/2] Add v4l2 subdev driver for S5K4ECGX sensor with embedded SoC ISP

2012-08-10 Thread Sangwook Lee
called twice - changed mutex_X position to be used when strictly necessary - add additional s_power(0) in case that error happens - update more accurate debugging statements - remove dummy else Sangwook Lee (2): v4l: Add factory register values form S5K4ECGX sensor v4l: Add v4l2 subdev driver for

Re: [PATH v3 1/2] v4l: Add factory register values form S5K4ECGX sensor

2012-08-03 Thread Sangwook Lee
Hi Sylwester On 2 August 2012 21:50, Sylwester Nawrocki wrote: > On 08/02/2012 03:42 PM, Sangwook Lee wrote: >> Add factory default settings for S5K4ECGX sensor registers, >> which was copied from the reference code of Samsung S.LSI. >> >> Signed-off-by: Sangwook Le

Re: [PATH v3 0/2] Add v4l2 subdev driver for S5K4ECGX sensor with embedded SoC ISP

2012-08-03 Thread Sangwook Lee
Hi Sylwester Thank you for the review. On 2 August 2012 21:11, Sylwester Nawrocki wrote: > > Hi Sangwook, > > On 08/02/2012 03:42 PM, Sangwook Lee wrote: > > The following 2 patches add driver for S5K4ECGX sensor with embedded ISP > > SoC, > > and minor v4l2 con

[PATH v3 2/2] v4l: Add v4l2 subdev driver for S5K4ECGX sensor

2012-08-02 Thread Sangwook Lee
This driver implements preview mode of the S5K4ECGX sensor. capture (snapshot) operation, face detection are missing now. Following controls are supported: contrast/saturation/brightness/sharpness Signed-off-by: Sangwook Lee --- drivers/media/video/Kconfig|8 + drivers/media/video

[PATH v3 0/2] Add v4l2 subdev driver for S5K4ECGX sensor with embedded SoC ISP

2012-08-02 Thread Sangwook Lee
Sangwook Lee (2): v4l: Add factory register values form S5K4ECGX sensor v4l: Add v4l2 subdev driver for S5K4ECGX sensor drivers/media/video/Kconfig |8 + drivers/media/video/Makefile|1 + drivers/media/video/s5k4ecgx.c | 839 ++ drivers/media/video

Re: [PATCH v2 2/2] v4l: Add v4l2 subdev driver for S5K4ECGX sensor

2012-07-20 Thread Sangwook Lee
Hi Sylwester Thank you for the great review! On 19 July 2012 22:40, Sylwester Nawrocki wrote: > > Hi Sangwook, > > A few review comments for you below... > > On 07/19/2012 02:14 PM, Sangwook Lee wrote: > > This dirver implements preview mode of the S5K4ECGX sensor. >

Re: [PATCH v2 1/2] v4l: Add factory register values form S5K4ECGX sensor

2012-07-20 Thread Sangwook Lee
Opps, the previous email has a HTML part, so resending. Hi Sylwester Thank for the review. On 19 July 2012 20:40, Sylwester Nawrocki wrote: > > Hi Sangwook, > > On 07/19/2012 02:14 PM, Sangwook Lee wrote: > > Add factory default settings for S5K4ECGX sensor registers. >

[PATCH v2 2/2] v4l: Add v4l2 subdev driver for S5K4ECGX sensor

2012-07-19 Thread Sangwook Lee
This dirver implements preview mode of the S5K4ECGX sensor. capture (snapshot) operation, face detection are missing now. Following controls are supported: contrast/saturation/birghtness/sharpness Signed-off-by: Sangwook Lee --- drivers/media/video/Kconfig|7 + drivers/media/video

[PATCH v2 0/2] Add v4l2 subdev driver for S5K4ECGX sensor with embedded SoC ISP

2012-07-19 Thread Sangwook Lee
additional s_power(0) in case that error happens - update more accurate debugging statements - remove dummy else Sangwook Lee (2): v4l: Add factory register values form S5K4ECGX sensor v4l: Add v4l2 subdev driver for S5K4ECGX sensor drivers/media/video/Kconfig |7 + drivers/media

[PATCH 2/2] v4l: Add v4l2 subdev driver for S5K4ECGX sensor

2012-07-17 Thread Sangwook Lee
This dirver implements preview mode of the S5K4ECGX sensor. capture (snapshot) operation, face detection are missing now. Following controls are supported: contrast/saturation/birghtness/sharpness Signed-off-by: Sangwook Lee --- drivers/media/video/Kconfig|7 + drivers/media/video

[PATCH 0/2] Add v4l2 subdev driver for S5K4ECGX sensor with embedded SoC ISP

2012-07-17 Thread Sangwook Lee
The following 2 patches add driver for S5K4ECGX sensor with embedded ISP SoC, and minor v4l2 control API enhancement. S5K4ECGX is 5M CMOS Image sensor from Samsung. Currenlty ony preview mode is supported. (no capture mode/face detection) Sangwook Lee (2): v4l: Add factory register values