nel.org; sakari.ai...@linux.intel.com;
> hans.verk...@cisco.com; Zheng, Jian Xu ;
> tf...@chromium.org; Mani, Rajmohan ;
> Toivonen, Tuukka ; Yang, Hyungwoo
> ; Vijaykumar, Ramya
>
> Subject: Re: [PATCH v4 3/3] intel-ipu3: cio2: Add new MIPI-CSI2 driver
>
> Hi Yong,
>
> Thanks f
Hi Tomasz,
On Thu, Jul 13, 2017 at 05:31:33PM +0900, Tomasz Figa wrote:
> On Thu, Jul 13, 2017 at 5:21 PM, Sakari Ailus wrote:
> >> >> + ret = v4l2_async_notifier_register(&cio2->v4l2_dev,
> >> >> &cio2->notifier);
> >> >> + if (ret) {
> >> >> + cio2->notifier.num_subdevs = 0
On Thu, Jul 13, 2017 at 5:21 PM, Sakari Ailus wrote:
>> >> + ret = v4l2_async_notifier_register(&cio2->v4l2_dev,
>> >> &cio2->notifier);
>> >> + if (ret) {
>> >> + cio2->notifier.num_subdevs = 0;
>> >
>> > No need to assign num_subdevs as 0.
>> >
>> > [YZ] _notifier_exit() wil
Hi Tomasz and Yong,
On Thu, Jul 13, 2017 at 01:51:18PM +0900, Tomasz Figa wrote:
> Hi Yong,
>
> On Thu, Jul 13, 2017 at 8:20 AM, Zhi, Yong wrote:
> > Hi, Sakari,
> >
> > Thanks for the time spent on code review, acks to all the comments, except
> > two places:
> >
> >> +/* .complete() is called
Hi Yong,
On Thu, Jul 13, 2017 at 8:20 AM, Zhi, Yong wrote:
> Hi, Sakari,
>
> Thanks for the time spent on code review, acks to all the comments, except
> two places:
>
>> +/* .complete() is called after all subdevices have been located */
>> +static int cio2_notifier_complete(struct v4l2_async_n
el.org] on
behalf of Sakari Ailus [sakari.ai...@iki.fi]
Sent: Tuesday, July 11, 2017 3:33 AM
To: Zhi, Yong
Cc: linux-media@vger.kernel.org; sakari.ai...@linux.intel.com;
hans.verk...@cisco.com; Zheng, Jian Xu; tf...@chromium.org; Mani, Rajmohan;
Toivonen, Tuukka; Yang, Hyungwoo; Vijaykumar, Ramya
Su
Hi Yong,
Thanks for the update! This looks pretty good in general, still some more
comments below.
Do you happen to have a todo list for the changes that are still planned?
AFAIR we should have two items in the list at least ---
1. Extend the format example to include the DMA word boundary and
This patch adds CIO2 CSI-2 device driver for
Intel's IPU3 camera sub-system support.
Signed-off-by: Yong Zhi
Signed-off-by: Hyungwoo Yang
Signed-off-by: Ramya Vijaykumar
---
drivers/media/pci/Kconfig|2 +
drivers/media/pci/Makefile |3 +-
drivers/media/pci
