Re: [PATCH v2 1/2] media: i2c: tvp7002: add support for asynchronous probing

2013-06-24 Thread Prabhakar Lad
Hi Hans, On Mon, Jun 24, 2013 at 12:44 PM, Hans Verkuil wrote: > On Sat June 22 2013 19:44:14 Prabhakar Lad wrote: >> From: "Lad, Prabhakar" >> >> Both synchronous and asynchronous tvp7002 subdevice probing >> is supported by this patch. > > Can I merg

Re: [PATCH] media: i2c: tvp514x: add support for asynchronous probing

2013-06-24 Thread Prabhakar Lad
Hi Hans, On Mon, Jun 24, 2013 at 12:41 PM, Hans Verkuil wrote: > On Sun June 23 2013 17:48:20 Prabhakar Lad wrote: >> Hi Guennadi, >> >> Thanks for the review. >> >> On Sun, Jun 23, 2013 at 8:49 PM, Guennadi Liakhovetski >> wrote: >> > On Sat, 2

Re: [PATCH] media: i2c: tvp514x: add support for asynchronous probing

2013-06-24 Thread Prabhakar Lad
Hi Hans, On Mon, Jun 24, 2013 at 2:09 PM, Hans Verkuil wrote: > On Mon June 24 2013 10:24:02 Prabhakar Lad wrote: >> Hi Hans, >> >> On Mon, Jun 24, 2013 at 12:41 PM, Hans Verkuil wrote: >> > On Sun June 23 2013 17:48:20 Prabhakar Lad wrote: >> >> Hi G

[PATCH 2/2] media: i2c: tvp514x: remove manual setting of subdev name

2013-06-24 Thread Prabhakar Lad
From: "Lad, Prabhakar" This patch removes manual setting of subdev name in the probe, ideally subdev names must be unique. Signed-off-by: Lad, Prabhakar Cc: Hans Verkuil --- drivers/media/i2c/tvp514x.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/i2c/tvp514x.c b/drivers

[PATCH 0/2] tvp514x/tvp7002 remove manual setting of subdev names

2013-06-24 Thread Prabhakar Lad
From: "Lad, Prabhakar" This patch series removes manual setting of subdev names, as ideally the subdev names must be unique and this would not be the case if there are two devices. Lad, Prabhakar (2): media: i2c: tvp7002: remove manual setting of subdev name media: i2c: tvp514x: remove manua

[PATCH 1/2] media: i2c: tvp7002: remove manual setting of subdev name

2013-06-24 Thread Prabhakar Lad
From: "Lad, Prabhakar" This patch removes manual setting of subdev name in the probe, ideally subdev names must be unique. Signed-off-by: Lad, Prabhakar Cc: Hans Verkuil --- drivers/media/i2c/tvp7002.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/i2c/tvp7002.c b/drivers

[PATCH v2] media: i2c: tvp514x: add support for asynchronous probing

2013-06-24 Thread Prabhakar Lad
From: "Lad, Prabhakar" Both synchronous and asynchronous tvp514x subdevice probing is supported by this patch. This patch also fixes the error path by calling media_entity_cleanup() on failure in probe when CONFIG_MEDIA_CONTROLLER is enabled. Signed-off-by: Prabhakar Lad Cc

Re: [PATCH RFC v3] media: OF: add video sync endpoint property

2013-06-24 Thread Prabhakar Lad
Hi Hans, Thanks for the review. On Mon, Jun 24, 2013 at 1:21 PM, Hans Verkuil wrote: > Hi Prabhakar, > > On Sat June 22 2013 17:03:03 Prabhakar Lad wrote: >> From: "Lad, Prabhakar" >> >> This patch adds video sync properties as part of endpoint >> p

Re: [PATCH RFC v3] media: OF: add video sync endpoint property

2013-06-25 Thread Prabhakar Lad
Hi Hans, On Mon, Jun 24, 2013 at 1:21 PM, Hans Verkuil wrote: > Hi Prabhakar, > > On Sat June 22 2013 17:03:03 Prabhakar Lad wrote: >> From: "Lad, Prabhakar" >> [snip] >> +#ifndef _DT_BINDINGS_VIDEO_INTERFACES_H >> +#define _DT_B

[PATCH 1/2] media: davinci: vpif: capture: add V4L2-async support

2013-06-25 Thread Prabhakar Lad
From: "Lad, Prabhakar" Add support for asynchronous subdevice probing, using the v4l2-async API. The legacy synchronous mode is still supported too, which allows to gradually update drivers and platforms. Signed-off-by: Prabhakar Lad Cc: Guennadi Liakhovetski Cc: Hans Verkuil C

[PATCH 2/2] media: davinci: vpif: display: add V4L2-async support

2013-06-25 Thread Prabhakar Lad
From: "Lad, Prabhakar" Add support for asynchronous subdevice probing, using the v4l2-async API. The legacy synchronous mode is still supported too, which allows to gradually update drivers and platforms. Signed-off-by: Lad, Prabhakar Cc: Guennadi Liakhovetski Cc: Hans Verkuil Cc: Laurent Pin

[PATCH 0/2] media: davinci: vpif: capture/display support for async subdevice probing

2013-06-25 Thread Prabhakar Lad
From: "Lad, Prabhakar" This patch series adds support for vpif capture and display driver to support asynchronously register subdevices. Need for this support: Currently bridge device drivers register devices for all subdevices synchronously, typically, during their probing. E.g. if an I2C CMOS

Re: [PATCH 1/2] media: davinci: vpif: capture: add V4L2-async support

2013-06-26 Thread Prabhakar Lad
Hi Hans, Thanks for the review. On Thu, Jun 27, 2013 at 11:27 AM, Hans Verkuil wrote: > On Tue June 25 2013 17:17:34 Prabhakar Lad wrote: >> From: "Lad, Prabhakar" >> >> Add support for asynchronous subdevice probing, using the v4l2-async API. >> The legac

Re: [PATCH v5] media: st-rc: Add ST remote control driver

2013-09-27 Thread Prabhakar Lad
gt; +{ > + struct st_rc_device *rc_dev = dev_get_drvdata(dev); > + > + if (device_may_wakeup(dev)) { > + if (!enable_irq_wake(rc_dev->irq)) > + rc_dev->irq_wake = 1; > + else > + re

Re: [PATCH] media: i2c: adv7343: fix the DT binding properties

2013-09-30 Thread Prabhakar Lad
Hi All, On Mon, Sep 23, 2013 at 8:18 AM, Prabhakar Lad wrote: > Hi Sylwester, > > On Fri, Sep 20, 2013 at 3:22 PM, Sylwester Nawrocki > wrote: >> Hi Prabhakar, >> >> On 09/20/2013 10:11 AM, Prabhakar Lad wrote: >>> OK I will, just send out a fix up

Re: [PATCH] [media] davinci: vpfe: remove deprecated IRQF_DISABLED

2013-10-06 Thread Prabhakar Lad
On Sun, Oct 6, 2013 at 11:53 AM, Michael Opdenacker wrote: > This patch proposes to remove the use of the IRQF_DISABLED flag > > It's a NOOP since 2.6.35 and it will be removed one day. > > Signed-off-by: Michael Opdenacker Acked-by: Lad, Prabhakar Regrads, --Prabhakar L

[PATCH] v4l: tuner-core: fix typo

2013-10-10 Thread Prabhakar Lad
From: "Lad, Prabhakar" Signed-off-by: Lad, Prabhakar --- drivers/media/v4l2-core/tuner-core.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/v4l2-core/tuner-core.c b/drivers/media/v4l2-core/tuner-core.c index ddc9379..4b8a9a3 100644 --- a/drivers/media/v4l

Re: [PATCH 1/6] [media] adv7343: Include linux/of.h header

2013-10-17 Thread Prabhakar Lad
On Fri, Oct 18, 2013 at 8:37 AM, Sachin Kamat wrote: > 'of_match_ptr' is defined in linux/of.h. Include it explicitly to > avoid build breakage in the future. > > Signed-off-by: Sachin Kamat Acked-by: Lad, Prabhakar Regrads, --Prabhakar Lad -- To unsubscribe from th

Re: [PATCH 5/6] [media] tvp7002: Include linux/of.h header

2013-10-17 Thread Prabhakar Lad
On Fri, Oct 18, 2013 at 8:37 AM, Sachin Kamat wrote: > 'of_match_ptr' is defined in linux/of.h. Include it explicitly to > avoid build breakage in the future. > > Signed-off-by: Sachin Kamat Acked-by: Lad, Prabhakar Regrads, --Prabhakar Lad -- To unsubscribe from th

Re: [PATCH 4/6] [media] tvp514x: Include linux/of.h header

2013-10-17 Thread Prabhakar Lad
On Fri, Oct 18, 2013 at 8:37 AM, Sachin Kamat wrote: > 'of_match_ptr' is defined in linux/of.h. Include it explicitly to > avoid build breakage in the future. > > Signed-off-by: Sachin Kamat Acked-by: Lad, Prabhakar Regrads, --Prabhakar Lad -- To unsubscribe from th

Re: [PATCH 3/6] [media] ths8200: Include linux/of.h header

2013-10-17 Thread Prabhakar Lad
On Fri, Oct 18, 2013 at 8:37 AM, Sachin Kamat wrote: > 'of_match_ptr' is defined in linux/of.h. Include it explicitly to > avoid build breakage in the future. > > Signed-off-by: Sachin Kamat Acked-by: Lad, Prabhakar Regrads, --Prabhakar Lad -- To unsubscribe from th

Re: [PATCH 1/2] staging: media: davinci_vpfe: Rewrite return statement in vpfe_video.c

2013-10-30 Thread Prabhakar Lad
_unlock(&mdev->graph_mutex); > > - return (ret == 0) ? ret : -ETIMEDOUT ; > + if (ret == 0) > + return ret; > + else I would remove this else and align the below return statement. > + return -ETIMEDOUT; > } > > /* Regard

Re: [PATCH 2/2] staging: media: davinci_vpfe: Remove spaces before semicolons

2013-10-30 Thread Prabhakar Lad
On Tue, Oct 29, 2013 at 2:53 AM, Lisa Nguyen wrote: > Remove unnecessary spaces before semicolons to meet kernel > coding style. > > Signed-off-by: Lisa Nguyen Acked-by: Lad, Prabhakar Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe li

Re: [PATCH v2] ths7303: Declare as static a private function

2013-11-07 Thread Prabhakar Lad
rning: no previous prototype for > ‘ths7303_setval’ [-Wmissing-prototypes] >int ths7303_setval(struct v4l2_subdev *sd, enum ths7303_filter_mode mode) > ^ > > Signed-off-by: Ricardo Ribalda Delgado > Acked-by: Laurent Pinchart Acked-by: Lad, Prabhakar Regards, --Prabhakar

Re: [PATCH v5] videodev2: Set vb2_rect's width and height as unsigned

2013-11-07 Thread Prabhakar Lad
_u32. > > Acked-by: Sakari Ailus (documentation and smiapp) > Signed-off-by: Ricardo Ribalda Delgado Acked-by: Lad, Prabhakar Regards, --Prabhakar Lad > --- > v5: Comments by Sakari Ailus > -Fix typos in summary > > v4: Wrong patch format > > v3: Comments by Sak

Re: [RFCv4 PATCH 7/8] vb2: return ENODATA in start_streaming in case of too few buffers.

2013-12-10 Thread Prabhakar Lad
for ENOBUFS. Regards, --Prabhakar Lad > Regards, > > Hans > > On 12/09/2013 02:43 PM, Hans Verkuil wrote: >> From: Hans Verkuil >> >> This works together with the retry_start_streaming mechanism to allow >> userspace >> to start streaming even if no

Re: [RFCv4 PATCH 7/8] vb2: return ENODATA in start_streaming in case of too few buffers.

2013-12-10 Thread Prabhakar Lad
On Tue, Dec 10, 2013 at 3:26 PM, Prabhakar Lad wrote: > Hi Hans, > > On Tue, Dec 10, 2013 at 1:21 PM, Hans Verkuil wrote: >> As Guennadi mentioned in his review, ENODATA will be replaced by ENOBUFS, >> which is >> more appropriate. >> >> Prabhakar, Ka

Re: [PATCH 2/2] staging: media: davinci_vpfe: Remove spaces before semicolons

2013-12-10 Thread Prabhakar Lad
Hi Laurent, On Tue, Dec 10, 2013 at 7:34 PM, Laurent Pinchart wrote: > Hi Prabhakar, > > On Wednesday 30 October 2013 13:20:25 Prabhakar Lad wrote: >> On Tue, Oct 29, 2013 at 2:53 AM, Lisa Nguyen wrote: >> > Remove unnecessary spaces before semicolons to meet

Re: [PATCH 2/2] staging: media: davinci_vpfe: Remove spaces before semicolons

2013-12-10 Thread Prabhakar Lad
Hi Lisa, On Tue, Dec 10, 2013 at 8:27 PM, Lisa Nguyen wrote: > Hi everyone, > > On Tue, Dec 10, 2013 at 6:34 AM, Prabhakar Lad > wrote: >> Hi Laurent, >> >> On Tue, Dec 10, 2013 at 7:34 PM, Laurent Pinchart >> wrote: >>> Hi Prabhakar, >>> &

Re: [PATCH 2/2] staging: media: davinci_vpfe: Remove spaces before semicolons

2013-12-10 Thread Prabhakar Lad
Hi Lisa, On Tue, Dec 10, 2013 at 8:38 PM, Lisa Nguyen wrote: > Hi Prabhakar, > > On Tue, Dec 10, 2013 at 7:04 AM, Prabhakar Lad > wrote: >> Hi Lisa, >> >> On Tue, Dec 10, 2013 at 8:27 PM, Lisa Nguyen wrote: >>> Hi everyone, >>> >>>

Re: [PATCH v2] staging: media: davinci_vpfe: Rewrite return statement in vpfe_video.c

2013-12-10 Thread Prabhakar Lad
return ret; >>> + >>> + return -ETIMEDOUT; >> >> I don't want to point the obvious, but what about just >> >> return ret ? -ETIMEDOUT : 0; >> >> or, if this is just about fixing the checkpatch.pl warning, >> >&g

Re: [PATCH v3] staging: media: davinci_vpfe: Rewrite return statement in vpfe_video.c

2013-12-11 Thread Prabhakar Lad
by: Lisa Nguyen Acked-by: Lad, Prabhakar Will be queueing it for 3.14. Regrads, --Prabhakar Lad > --- > Changes since v3: > - Removed () from return statement per Laurent Pinchart's suggestion > > drivers/staging/media/davinci_vpfe/vpfe_video.c |2 +- > 1 fi

[GIT PULL FOR v3.14] DaVinci VPFE trivial fixes

2013-12-11 Thread Prabhakar Lad
Hi Mauro, Please pull the following patches for davinci vpfe driver. Regards, --Prabhakar Lad The following changes since commit 989af88339db26345e23271dae1089d949c4a0f1: [media] v4l: vsp1: Add LUT support (2013-12-11 09:25:20 -0200) are available in the git repository at: http

Re: [PATCH] media: davinci_vpfe: fix build error

2013-12-20 Thread Prabhakar Lad
mplicit declaration of function ‘msleep’ > Will you pick this patch or shall I go ahead and issue a pull to Mauro ? Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordo

Re: [PATCH] media: davinci_vpfe: fix build error

2013-12-20 Thread Prabhakar Lad
ke up in linux-media but its present DLOS [1]. I posted it the same day when you pinged me about this issue. Anyway your patch too didnt reach me and I also cannot find it in the ML. May be you directly issued the pull ? [1] https://patchwork.kernel.org/patch/3362211/ Regards, --Prabhakar Lad -- To u

Re: [PATCH] media: davinci_vpfe: fix build error

2013-12-20 Thread Prabhakar Lad
Hi Hans, On Fri, Dec 20, 2013 at 7:00 PM, Hans Verkuil wrote: > Hi Prabhakar, > > On 12/20/2013 02:02 PM, Prabhakar Lad wrote: >> Hi Hans, >> >> On Fri, Dec 20, 2013 at 6:23 PM, Hans Verkuil wrote: >>> I just made a patch myself that I added to the pull reque

Re: [PATCH] [media] vpif_capture: fix condition logic in vpif_capture.c

2012-11-04 Thread Prabhakar Lad
> (https://github.com/weiyj/dpatch) > > Signed-off-by: Wei Yongjun > --- > drivers/media/platform/davinci/vpif_capture.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Thanks for the patch, I'll queue it for 3.8. Regards, --Prabhakar Lad > diff --git a/d

Re: [PATCH] [media] vpif_display: fix condition logic in vpif_enum_dv_timings()

2012-11-04 Thread Prabhakar Lad
> (https://github.com/weiyj/dpatch) > > Signed-off-by: Wei Yongjun > --- > drivers/media/platform/davinci/vpif_display.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Thanks for the patch, I'll queue it for 3.8. Regards, --Prabhakar Lad > diff --git a/d

[GIT PULL FOR v3.8] Davinci VPBE feature enhancement and fixes

2012-11-09 Thread Prabhakar Lad
Hi Mauro, Can you please pull the following patches for Davinci VPBE driver. The first patch fixes the build warnings for readl/writel, the second patch migrates the driver to videobuf2 usage and the third patch set's device caps. Thanks and Regards, --Prabhakar Lad The following changes

[GIT PULL FOR v3.8] Davinci media: migration to common clock framework

2012-11-09 Thread Prabhakar Lad
Hi Mauro, Can you please pull the following patch which migrates the media drivers for Davinci to common clock framework usage. Thanks and Regards, --Prabhakar Lad The following changes since commit 2cb654fd281e1929aa3b9f5f54f492135157a613: MAINTAINERS: add support for tea5761/tea5767

Re: [PATCH] [media] vpif_display: fix return value check in vpif_reqbufs()

2012-11-09 Thread Prabhakar Lad
LL(). Can you merge this patch 'vpif_capture: fix return value check in vpif_reqbufs()' with this one and post a v2 with above changes ? Regards, --Prabhakar Lad > vpif_err("Failed to get the context\n"); > - return -EINVAL; > +

Re: [PATCH] [media] vpif_display: fix return value check in vpif_reqbufs()

2012-11-14 Thread Prabhakar Lad
Hi Wei, On Mon, Nov 12, 2012 at 2:14 PM, Wei Yongjun wrote: > Hi Prabhakar, > > On 11/09/2012 08:33 PM, Prabhakar Lad wrote: >> Hi Wei, >> >> Thanks for the patch. >> >> On Wed, Oct 24, 2012 at 4:59 PM, Wei Yongjun wrote: >>> From: Wei

Re: [PATCH v2] [media] vpif_capture: fix return value check

2012-11-15 Thread Prabhakar Lad
R(). > > dpatch engine is used to auto generate this patch. > (https://github.com/weiyj/dpatch) > > Signed-off-by: Wei Yongjun Acked-by: Lad, Prabhakar I'll queue it for 3.8. Thanks, --Prabhakar Lad > --- > drivers/media/platform/davinci/vpif_display.c |

[PATCH v2 00/12] Media Controller capture driver for DM365

2012-11-16 Thread Prabhakar Lad
From: Manjunath Hadli This patch set adds media controller based capture driver for DM365. This driver bases its design on Laurent Pinchart's Media Controller Design whose patches for Media Controller and subdev enhancements form the base. The driver also takes copious elements taken from Lauren

[PATCH v2 09/12] davinci: vpss: dm365: set vpss clk ctrl

2012-11-16 Thread Prabhakar Lad
From: Manjunath Hadli request_mem_region for VPSS_CLK_CTRL register and ioremap. and enable clocks appropriately. Signed-off-by: Manjunath Hadli Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/vpss.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) di

[PATCH v2 12/12] davinci: vpfe: Add documentation

2012-11-16 Thread Prabhakar Lad
/Documentation/video4linux/davinci-vpfe-mc.txt @@ -0,0 +1,154 @@ +Davinci Video processing Front End (VPFE) driver + +Copyright (C) 2012 Texas Instruments Inc + +Contacts: Manjunath Hadli + Prabhakar Lad + + +Introduction + + +This file documents the Texas Instruments Davinci Video

[PATCH v2 11/12] davinci: vpfe: dm365: add build infrastructure for capture driver

2012-11-16 Thread Prabhakar Lad
From: Manjunath Hadli add build infrastructure for dm365 specific modules for VPFE capture driver. Signed-off-by: Manjunath Hadli Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/Kconfig | 11 +++ drivers/media/platform/davinci/Makefile |3 +++ 2 files changed,

[PATCH v2 02/12] davinci: vpfe: add v4l2 video driver support

2012-11-16 Thread Prabhakar Lad
+ * + * Contributors: + * Manjunath Hadli + * Prabhakar Lad + */ + +#include +#include + +#include +#include + +#include "vpfe_mc_capture.h" + +/* minimum number of buffers needed in cont-mode */ +#define MIN_NUM_BUFFERS3 + +static int debug; + +/* get v

[PATCH v2 03/12] davinci: vpfe: dm365: add IPIPEIF driver based on media framework

2012-11-16 Thread Prabhakar Lad
Hadli + * Prabhakar Lad + */ + +#include "dm365_ipipeif.h" +#include "vpfe_mc_capture.h" + +static const unsigned int ipipeif_input_fmts[] = { + V4L2_MBUS_FMT_UYVY8_2X8, + V4L2_MBUS_FMT_SGRBG12_1X12, + V4L2_MBUS_FMT_Y8_1X8, + V

[PATCH v2 06/12] davinci: vpfe: dm365: add IPIPE hardware layer support

2012-11-16 Thread Prabhakar Lad
GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + * + * Contributors: + * Manjunath Hadli + * Prabhakar Lad + */ + +#include "dm365_ipipe_hw.h"

[PATCH v2 08/12] davinci: vpss: dm365: enable ISP registers

2012-11-16 Thread Prabhakar Lad
From: Manjunath Hadli enable PPCR, enbale ISIF out on BCR and disable all events to get the correct operation from ISIF. Signed-off-by: Manjunath Hadli Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/vpss.c | 13 + 1 files changed, 13 insertions(+), 0 deletions(

[PATCH v2 10/12] davinci: vpss: dm365: add vpss helper functions to be used in the main driver for setting hardware parameters

2012-11-16 Thread Prabhakar Lad
From: Manjunath Hadli add interface functions to set sync polarity, interrupt completion and pageframe size in vpss to be used by the main driver. Signed-off-by: Manjunath Hadli Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/vpss.c | 32 in

Re: [PATCH v2 00/12] Media Controller capture driver for DM365

2012-11-16 Thread Prabhakar Lad
Hi All, On Fri, Nov 16, 2012 at 8:15 PM, Prabhakar Lad wrote: > From: Manjunath Hadli > > This patch set adds media controller based capture driver for > DM365. > > This driver bases its design on Laurent Pinchart's Media Controller Design > whose patches for M

Re: [RFCv1 PATCH 0/2] Two vpif fixes protecting the dma_queue by a lock

2012-11-18 Thread Prabhakar Lad
never saw this again. > > It makes sense as well since the interrupt routine and normal code both > manipulated the same list. > > It's fixed for both capture and display. > Acked-by: Prabhakar Lad I'll queue these patches for 3.8. Regards, --Prabhakar Lad > Rega

[PATCH] MAINTAINERS: Add entry for Davinci video drivers

2012-11-19 Thread Prabhakar Lad
f4b3aa8..9474cb4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6619,6 +6619,18 @@ S: Supported F: arch/arm/mach-davinci F: drivers/i2c/busses/i2c-davinci.c +TI DAVINCI SERIES MEDIA DRIVER +M: Manjunath Hadli +M: Prabhakar Lad +L: linux-media@vger.kernel.org +L

[PATCH] davinci: vpbe: pass different platform names to handle different ip's

2012-11-19 Thread Prabhakar Lad
From: Lad, Prabhakar The vpbe driver can handle different platforms DM644X, DM36X and DM355. To differentiate between this platforms venc_type/vpbe_type was passed as part of platform data which was incorrect. The correct way to differentiate to handle this case is by passing different platform n

Re: [PATCH v2] [media] vpif_capture: fix return value check

2012-11-19 Thread Prabhakar Lad
ons(-) > Applied to my tree with following change in commit header, 'davinci: vpif: fix return value check for vb2_dma_contig_init_ctx()' Regards, --Prabhakar Lad > diff --git a/drivers/media/platform/davinci/vpif_display.c > b/drivers/media/platform/davinci/vpif_display.c &

Re: [PATCH] [media] vpif_display: fix condition logic in vpif_enum_dv_timings()

2012-11-19 Thread Prabhakar Lad
t && should be ||. dpatch engine is used to auto generate this patch. (https://github.com/weiyj/dpatch) Regards, --Prabhakar Lad > diff --git a/drivers/media/platform/davinci/vpif_display.c > b/drivers/media/platform/davinci/vpif_display.c > index b716fbd..977ee43 100644 >

Re: [PATCH] [media] vpif_capture: fix condition logic in vpif_capture.c

2012-11-19 Thread Prabhakar Lad
n that && should be ||. dpatch engine is used to auto generate this patch. (https://github.com/weiyj/dpatch) Regards, --Prabhakar Lad > diff --git a/drivers/media/platform/davinci/vpif_capture.c > b/drivers/media/platform/davinci/vpif_capture.c > index fcabc02..2d28a96 100644 >

Re: [PATCH] davinci: vpbe: pass different platform names to handle different ip's

2012-11-20 Thread Prabhakar Lad
Sekhar, Thanks for the review. On Tue, Nov 20, 2012 at 2:40 PM, Sekhar Nori wrote: > > On 11/19/2012 6:48 PM, Prabhakar Lad wrote: >> From: Lad, Prabhakar >> >> The vpbe driver can handle different platforms DM644X, DM36X and >> DM355. To differentiate be

[PATCH v2] davinci: vpbe: pass different platform names to handle different ip's

2012-11-20 Thread Prabhakar Lad
From: Lad, Prabhakar The vpbe driver can handle different platforms DM644X, DM36X and DM355. To differentiate between this platforms venc_type/vpbe_type was passed as part of platform data which was incorrect. The correct way to differentiate to handle this case is by passing different platform n

[GIT PULL FOR v3.8] Davinci VPIF trivial fixes

2012-11-21 Thread Prabhakar Lad
Hi Mauro, Can you please pull the following patches for vpif, which fixes some trivial issues. Thanks and Regards, --Prabhakar Lad The following changes since commit 2c4e11b7c15af70580625657a154ea7ea70b8c76: [media] siano: fix RC compilation (2012-11-07 11:09:08 +0100) are available in the

Re: [PATCH 133/493] remove use of __devexit_p

2012-11-22 Thread Prabhakar Lad
/media/platform/davinci/vpss.c | 2 +- Acked-by: Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 00/12] Media Controller capture driver for DM365

2012-11-23 Thread Prabhakar Lad
Hi Sakari, On Fri, Nov 23, 2012 at 6:43 PM, Sakari Ailus wrote: > Hi Prabhakar and others, > > (Just resending; Laurent's e-mail address corrected, cc Hans, too.) > > On Fri, Nov 16, 2012 at 08:15:02PM +0530, Prabhakar Lad wrote: >> From: Manjunath Hadli >&

Re: [PATCH v2 00/12] Media Controller capture driver for DM365

2012-11-25 Thread Prabhakar Lad
Hi, On Fri, Nov 23, 2012 at 7:31 PM, Hans Verkuil wrote: > On Fri November 23 2012 14:57:53 Sakari Ailus wrote: >> Hi Prabhakar, >> >> On Fri, Nov 23, 2012 at 06:51:28PM +0530, Prabhakar Lad wrote: >> > Hi Sakari, >> > >> > On Fri, Nov 23,

Re: [PATCH v2 00/12] Media Controller capture driver for DM365

2012-11-25 Thread Prabhakar Lad
HI Sakari, On Mon, Nov 26, 2012 at 5:58 AM, Sakari Ailus wrote: > > Hi Prabhakar, > On Sun, Nov 25, 2012 at 09:57:23PM +0530, Prabhakar Lad wrote: >> On Fri, Nov 23, 2012 at 7:31 PM, Hans Verkuil wrote: >> > On Fri November 23 2012 14:57:53 Sakari Ailus wrote: > ...

Re: [PATCH] media: fix a typo CONFIG_HAVE_GENERIC_DMA_COHERENT in videobuf2-dma-contig.c

2012-11-26 Thread Prabhakar Lad
**/ -#ifdef HAVE_GENERIC_DMA_COHERENT +#ifdef CONFIG_HAVE_GENERIC_DMA_COHERENT struct vb2_dc_attachment { struct sg_table sgt; Regards, --Prabhakar > Thank you, > Kyungmin Park > > On 11/27/12, Prabhakar Lad wrote: >> From: Lad, Prabhakar >> &g

Re: [PATCH] media: fix a typo CONFIG_HAVE_GENERIC_DMA_COHERENT in videobuf2-dma-contig.c

2012-11-26 Thread Prabhakar Lad
Hi Marek, On Tue, Nov 27, 2012 at 12:53 PM, Marek Szyprowski wrote: > Hello, > > > On 11/27/2012 6:59 AM, Prabhakar Lad wrote: >> >> From: Lad, Prabhakar >> >> from commit 93049b9368a2e257ace66252ab2cc066f3399cad, which adds >> a check HAVE_GENER

Re: [PATCH] media: fix a typo CONFIG_HAVE_GENERIC_DMA_COHERENT in videobuf2-dma-contig.c

2012-11-27 Thread Prabhakar Lad
Hi, On Tue, Nov 27, 2012 at 1:21 PM, Marek Szyprowski wrote: > Hello, > > > On 11/27/2012 8:39 AM, Prabhakar Lad wrote: >> >> Hi Marek, >> >> On Tue, Nov 27, 2012 at 12:53 PM, Marek Szyprowski >> wrote: >> > Hello, >> > >> > &

[PATCH v3 0/9] Media Controller capture driver for DM365

2012-11-28 Thread Prabhakar Lad
From: Manjunath Hadli Mauro/Greg, The below series of patches have gone through good amount of reviews, and agreed by Laurent, Hans and Sakari to be part of the staging tree. I am combining the patchs with the pull request so we can get them into the 3.8 kernel. Please pull these patches.If you

[PATCH v3 2/9] davinci: vpfe: add v4l2 video driver support

2012-11-28 Thread Prabhakar Lad
02111-1307 USA + * + * Contributors: + * Manjunath Hadli + * Prabhakar Lad + */ + +#include +#include + +#include + +#include "vpfe.h" +#include "vpfe_mc_capture.h" + +/* minimum number of buffers needed in cont-mode */ +#define MIN_NUM_BUFFERS

[PATCH v3 3/9] davinci: vpfe: dm365: add IPIPEIF driver based on media framework

2012-11-28 Thread Prabhakar Lad
+ * Prabhakar Lad + */ + +#include "dm365_ipipeif.h" +#include "vpfe_mc_capture.h" + +static const unsigned int ipipeif_input_fmts[] = { + V4L2_MBUS_FMT_UYVY8_2X8, + V4L2_MBUS_FMT_SGRBG12_1X12, + V4L2_MBUS_FMT_Y8_1X8, + V

[PATCH v3 8/9] davinci: vpfe: dm365: add build infrastructure for capture driver

2012-11-28 Thread Prabhakar Lad
From: Manjunath Hadli add build infrastructure for dm365 specific modules for VPFE capture driver. Signed-off-by: Manjunath Hadli Signed-off-by: Lad, Prabhakar --- drivers/staging/media/Kconfig |2 ++ drivers/staging/media/Makefile |1 + drivers/staging/medi

[PATCH v3 9/9] davinci: vpfe: Add documentation and TODO

2012-11-28 Thread Prabhakar Lad
right (C) 2012 Texas Instruments Inc + +Contacts: Manjunath Hadli + Prabhakar Lad + + +Introduction + + +This file documents the Texas Instruments Davinci Video processing Front End +(VPFE) driver located under drivers/media/platform/davinci. The original driver +exists for Da

[PATCH v3 6/9] davinci: vpfe: dm365: add IPIPE hardware layer support

2012-11-28 Thread Prabhakar Lad
received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + * + * Contributors: + * Manjunath Hadli + * Prabhakar Lad + */ + +#include "dm365_ipipe

[PATCH v3 3/3] davinci: vpss: dm365: add vpss helper functions to be used in the main driver for setting hardware parameters

2012-11-28 Thread Prabhakar Lad
From: Manjunath Hadli add interface functions to set sync polarity, interrupt completion and pageframe size in vpss to be used by the main driver. Signed-off-by: Manjunath Hadli Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/vpss.c | 32 in

[PATCH v3 0/3] Davinci VPSS helper functions for VPFE

2012-11-28 Thread Prabhakar Lad
From: Manjunath Hadli Hi Mauro, This patchset, was part of the DM365 capture driver series, I have split them up and made as separate series as the capture patches will now be going under staging and made as version V3. This patches have undergone several reviews along with the capture driver.

[PATCH v3 1/3] davinci: vpss: dm365: enable ISP registers

2012-11-28 Thread Prabhakar Lad
From: Manjunath Hadli enable PPCR, enbale ISIF out on BCR and disable all events to get the correct operation from ISIF. Signed-off-by: Manjunath Hadli Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/vpss.c | 13 + 1 files changed, 13 insertions(+), 0 deletions(

[PATCH v3 2/3] davinci: vpss: dm365: set vpss clk ctrl

2012-11-28 Thread Prabhakar Lad
From: Manjunath Hadli request_mem_region for VPSS_CLK_CTRL register and ioremap. and enable clocks appropriately. Signed-off-by: Manjunath Hadli Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/vpss.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) di

[GIT PULL FOR v3.8] Mediabus And Pixel format supported by DM365

2012-11-28 Thread Prabhakar Lad
drivers using this formats http://patchwork.linuxtv.org/patch/15690/ . Thanks and Regards, --Prabhakar Lad The following changes since commit c6c22955f80f2db9614b01fe5a3d1cfcd8b3d848: [media] dma-mapping: fix dma_common_get_sgtable() conditional compilation (2012-11-27 09:42:31 -0200) are

[PATCH] media: davinci: vpbe: enable building of vpbe driver for DM355 and DM365

2012-11-28 Thread Prabhakar Lad
From: Lad, Prabhakar This patch allows enabling building of VPBE display driver for DM365 and DM355. This also removes unnecessary entry VIDEO_DM644X_VPBE in Kconfig, which could have been done with single entry, and appropriate changes in Makefile for building. Signed-off-by: Lad, Prabhakar Si

Re: [PATCH v3 2/3] davinci: vpss: dm365: set vpss clk ctrl

2012-11-28 Thread Prabhakar Lad
Hi Sakari, Thanks for the quick review. On Thu, Nov 29, 2012 at 1:48 AM, Sakari Ailus wrote: > Hi Prabhakar, > > On Wed, Nov 28, 2012 at 04:25:33PM +0530, Prabhakar Lad wrote: >> From: Manjunath Hadli >> >> request_mem_region for VPSS_CLK_CTRL register and io

Re: [PATCH v3 1/3] davinci: vpss: dm365: enable ISP registers

2012-11-28 Thread Prabhakar Lad
Hi Sakari, Thanks for the quick review. On Thu, Nov 29, 2012 at 1:38 AM, Sakari Ailus wrote: > On Wed, Nov 28, 2012 at 04:25:32PM +0530, Prabhakar Lad wrote: >> From: Manjunath Hadli >> >> enable PPCR, enbale ISIF out on BCR and disable all events to >> get the

Re: [PATCH v3 9/9] davinci: vpfe: Add documentation and TODO

2012-11-28 Thread Prabhakar Lad
auro Carvalho Chehab wrote: >> > Hi Prabhakar, >> > >> > Em Wed, 28 Nov 2012 16:12:09 +0530 >> > >> > Prabhakar Lad escreveu: >> > > +Introduction >> > > + >> > > + >> > > + This file documents

Re: [PATCH] [media] v4l: Add mt9v034 sensor driver

2012-11-29 Thread Prabhakar Lad
us_framefmt *__format; > + struct v4l2_rect *__crop; > + struct v4l2_rect rect; > + > + /* Clamp the crop rectangle boundaries and align them to a multiple > +* of 2 pixels to ensure a BGGR Bayer pattern. > +*/ > + rect.left = clamp(

[PATCH v4 0/3] Davinci VPSS helper functions for VPFE

2012-11-30 Thread Prabhakar Lad
From: Lad, Prabhakar This patch series adds helper functions and enables the VPSS and ISP registers required for VPFE to work. Changes for v4: 1: Fixed review comment from Sakari. Manjunath Hadli (3): davinci: vpss: dm365: enable ISP registers davinci: vpss: dm365: set vpss clk ctrl davin

[PATCH v4 1/3] davinci: vpss: dm365: enable ISP registers

2012-11-30 Thread Prabhakar Lad
From: Manjunath Hadli enable the clocks required for VPFE to work in PCCR register, and enbale ISIF out on BCR to get the correct operation from ISIF. Signed-off-by: Manjunath Hadli Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/vpss.c | 23 ++- 1 files

[PATCH v4 2/3] davinci: vpss: dm365: set vpss clk ctrl

2012-11-30 Thread Prabhakar Lad
From: Manjunath Hadli request_mem_region for VPSS_CLK_CTRL register and ioremap. and enable clocks appropriately. Signed-off-by: Manjunath Hadli Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/vpss.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) d

[PATCH v4 3/3] davinci: vpss: dm365: add vpss helper functions to be used in the main driver for setting hardware parameters

2012-11-30 Thread Prabhakar Lad
From: Manjunath Hadli add interface functions to set sync polarity, interrupt completion and pageframe size in vpss to be used by the main driver. Signed-off-by: Manjunath Hadli Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/vpss.c | 32 in

[PATCH v4 0/9] Media Controller capture driver for DM365

2012-11-30 Thread Prabhakar Lad
From: Lad, Prabhakar The below series of patches have gone through good amount of reviews, and agreed by Laurent, Hans and Sakari to be part of the staging tree. This patch set adds media controller based capture driver for DM365. This driver bases its design on Laurent Pinchart's Media Control

[PATCH v4 2/9] davinci: vpfe: add v4l2 video driver support

2012-11-30 Thread Prabhakar Lad
the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + * + * Contributors: + * Manjunath Hadli + * Prabhakar Lad + */ + +#include +#include + +#include + +#include "vpfe.h" +#include "vpfe_mc_capture.h" + +/* minimum number

[PATCH v4 3/9] davinci: vpfe: dm365: add IPIPEIF driver based on media framework

2012-11-30 Thread Prabhakar Lad
, Boston, MA 02111-1307 USA + * + * Contributors: + * Manjunath Hadli + * Prabhakar Lad + */ + +#include "dm365_ipipeif.h" +#include "vpfe_mc_capture.h" + +static const unsigned int ipipeif_input_fmts[] = { + V4L2_MBUS_FMT_UYVY8_2X8, + V4L2_M

[PATCH v4 6/9] davinci: vpfe: dm365: add IPIPE hardware layer support

2012-11-30 Thread Prabhakar Lad
: + * Manjunath Hadli + * Prabhakar Lad + */ + +#include "dm365_ipipe_hw.h" + +#define IPIPE_MODE_CONTINUOUS 0 +#define IPIPE_MODE_SINGLE_SHOT 1 + +static void ipipe_clock_enable(void *__iomem base_addr) +{ + /* enable IPIPE MMR for register write access */ +

[PATCH v4 8/9] davinci: vpfe: dm365: add build infrastructure for capture driver

2012-11-30 Thread Prabhakar Lad
From: Manjunath Hadli add build infrastructure for dm365 specific modules for VPFE capture driver. Signed-off-by: Manjunath Hadli Signed-off-by: Lad, Prabhakar Acked-by: Laurent Pinchart Acked-by: Sakari Ailus Acked-by: Hans Verkuil --- drivers/staging/media/Kconfig |2 ++

[PATCH v4 9/9] davinci: vpfe: Add documentation and TODO

2012-11-30 Thread Prabhakar Lad
FE) driver + +Copyright (C) 2012 Texas Instruments Inc + +Contacts: Manjunath Hadli + Prabhakar Lad + + +Introduction + + +This file documents the Texas Instruments Davinci Video processing Front End +(VPFE) driver located under drivers/media/platform/davinci. The original driver +

Re: [PATCH -next] [media] davinci: vpbe: remove unused variable in vpbe_initialize()

2012-12-02 Thread Prabhakar Lad
Hi Wei, Thanks for the patch. On Mon, Dec 3, 2012 at 8:23 AM, Wei Yongjun wrote: > From: Wei Yongjun > > The variable 'output_index' is initialized but never used > otherwise, so remove the unused variable. > > Signed-off-by: Wei Yongjun Acked-by: Prabhaka

Re: [PATCH -next] [media] media: davinci: vpbe: return error code on error in vpbe_display_g_crop()

2012-12-02 Thread Prabhakar Lad
Wei, On Mon, Dec 3, 2012 at 8:20 AM, Wei Yongjun wrote: > From: Wei Yongjun > > We have assigned error code to 'ret' if crop->type is not > V4L2_BUF_TYPE_VIDEO_OUTPUT, but never use it. > We'd better return the error code on this error. > > Signed-off-by

Re: [PATCH -next] [media] media: davinci: vpbe: fix return value check in vpbe_display_reqbufs()

2012-12-02 Thread Prabhakar Lad
: Wei Yongjun Acked-by: Prabhakar Lad Regards, --Prabhakar > --- > drivers/media/platform/davinci/vpbe_display.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/davinci/vpbe_display.c > b/drivers/media/platform/davinci/

[PATCH RFC v2] media: v4l2-ctrl: Add gain controls

2012-12-05 Thread Prabhakar Lad
From: Lad, Prabhakar add support for per color component digital/analog gain controls and also their corresponding offset. Signed-off-by: Lad, Prabhakar Cc: Sakari Ailus Cc: Laurent Pinchart Cc: Kyungmin Park Cc: Guennadi Liakhovetski Cc: Sylwester Nawrocki Cc: Hans Verkuil Cc: Hans de Go

Re: [PATCH RFC v2] media: v4l2-ctrl: Add gain controls

2012-12-05 Thread Prabhakar Lad
Hi Hans, On Wed, Dec 5, 2012 at 5:38 PM, Hans Verkuil wrote: > (resend without HTML formatting) > > On Wed 5 December 2012 12:49:29 Prabhakar Lad wrote: >> From: Lad, Prabhakar >> >> add support for per color component digital/analog gain controls >> an

<    1   2   3   4   5   6   7   >