The wl1271 device is using a reference clock that may change
between board to board.
Make the ref_clock parameter configurable by the board
files that set up the device, instead of having a hard coded
value in the driver source itself.
Signed-off-by: Ohad Ben-Cohen
---
drivers/net/wireless
Add a simple mechanism to pass platform data to the
SDIO instances of wl12xx.
This way there is no confusion over who owns the 'embedded data',
typechecking is preserved, and no possibility for the wrong driver to
pick up the data.
Originally proposed by Russell King.
Signed-off-by
Remove the hard coded irq information, and instead take
the irq information from the board's platform data.
Signed-off-by: Ohad Ben-Cohen
---
drivers/net/wireless/wl12xx/wl1271_sdio.c | 14 +++---
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/net/wir
Make it possible for the set power method to indicate a
success/failure return value. This is needed to support
more complex power on/off operations such as bringing up
(and down) sdio functions.
Signed-off-by: Ohad Ben-Cohen
---
drivers/net/wireless/wl12xx/wl1271.h |2 +-
drivers/net
King. Currently only a single device is
supported; multi-device support will be introduced only when/if required
Patches are based on 2.6.36-rc3 and tested on ZOOM3.
Thanks,
Ohad Ben-Cohen (7):
wireless: wl1271: make wl12xx.h common to both spi and sdio
wireless: wl1271: support return value
Move wl12xx.h outside of the spi-specific location,
so it can be shared with both spi and sdio solutions.
Signed-off-by: Ohad Ben-Cohen
---
drivers/net/wireless/wl12xx/wl1251_sdio.c |2 +-
drivers/net/wireless/wl12xx/wl1251_spi.c |2 +-
drivers/net/wireless/wl12xx/wl1271_spi.c |2
On Thursday, August 12, 2010, Russell King - ARM Linux
wrote:
> On Thu, Aug 12, 2010 at 09:40:19AM +0300, Ohad Ben-Cohen wrote:
>> On Thu, Aug 12, 2010 at 12:25 AM, Russell King - ARM Linux
>> wrote:
>> >I've outlined a far simpler and easiler solution
>> >
On Thu, Aug 12, 2010 at 12:25 AM, Russell King - ARM Linux
wrote:
>I've outlined a far simpler and easiler solution
> which avoids this kind of abuse, and given suggestions on how to extend
> it to support multiple instances.
>
Do you mean:
http://www.spinics.net/lists/arm-kernel/msg95338.html
?
On Wed, Aug 11, 2010 at 9:35 PM, DebBarma, Tarun Kanti
wrote:
>> - wl->if_ops->power(wl, true);
>> - set_bit(WL1271_FLAG_GPIO_POWER, &wl->flags);
>> + int ret = wl->if_ops->power(wl, true);
> Just a minor comment, need a blank line here?
Can't hurt, thanks.
>> + if (ret == 0)
>
Hi Vitaly,
On Thu, Aug 12, 2010 at 12:34 AM, Vitaly Wool wrote:
> On Wed, Aug 11, 2010 at 10:10 PM, Ohad Ben-Cohen wrote:
>> Think of several wl1271 devices, each of which is represented by two
>> devices; an SDIO function, and a platform device. The SDIO function
>> stan
12, 2010 12:27 AM
>> > To: DebBarma, Tarun Kanti
>> > Cc: Balbi Felipe (Nokia-MS/Helsinki); Ohad Ben-Cohen; linux-
>> > wirel...@vger.kernel.org; linux-...@vger.kernel.org; linux-
>> > o...@vger.kernel.org; Ido Yariv; Mark Brown; linux-arm-
>> > ker...@lists
Hi Kishore,
On Wed, Aug 11, 2010 at 11:09 PM, kishore kadiyala
wrote:
> Since you specified the voltage source is fixed, and if MMC3 has any
> dedicated regulator as MMC1 & MMC2 you can go with
> Roger's comments.
You are reading an old batch of the patches.
Scroll down to v4 ;)
Thanks,
Ohad.
Hi Felipe,
On Wed, Aug 11, 2010 at 9:47 PM, Felipe Balbi wrote:
>>> + pdata = pdev->dev.platform_data;
>>> + if (!pdata) {
>>> + wl1271_error("no platform data");
>>> + return -ENODEV;
>>> + }
>>> +
>>> + pdriver = container_of(pdev->dev.driver,
Add MMC3 support on ZOOM, which has the wl1271 device hardwired to.
The wl1271 is a 4-wire, 1.8V, embedded SDIO WLAN device with an
external IRQ line, and power-controlled by a GPIO-based fixed regulator.
Signed-off-by: Ohad Ben-Cohen
---
arch/arm/mach-omap2/board-zoom-peripherals.c | 34
Add a fixed regulator vmmc device to enable power control
of the wl1271 wlan device.
Signed-off-by: Ohad Ben-Cohen
---
arch/arm/mach-omap2/board-zoom-peripherals.c | 35 ++
1 files changed, 35 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/board-zoom
Make this go away:
drivers/mmc/host/omap_hsmmc.c: In function 'omap_hsmmc_suspend':
drivers/mmc/host/omap_hsmmc.c:2328: warning: unused variable 'state'
Signed-off-by: Ohad Ben-Cohen
---
drivers/mmc/host/omap_hsmmc.c |1 -
1 files changed, 0 insertions(+), 1 deleti
The wl1271 device is using a reference clock that may change
between board to board.
Make the ref_clock parameter configurable by the board
files that set up the device, instead of having a hard coded
value in the driver source itself.
Signed-off-by: Ohad Ben-Cohen
---
drivers/net/wireless
Remove the hard coded irq information, and instead take
the irq information from the board's platform data.
Signed-off-by: Ohad Ben-Cohen
---
drivers/net/wireless/wl12xx/wl1271_sdio.c | 18 +-
1 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/net/wir
Dynamically create and register a platform driver, that will
be used to to receive board-specific information like irq and
reference clock numbers.
The driver is created dynamically in order to avoid the 1-device
limitation of a fixed platform driver name.
Signed-off-by: Ohad Ben-Cohen
email access
in the next three weeks, so I might not respond right away.
Thanks,
Ohad Ben-Cohen (8):
wireless: wl1271: make wl12xx.h common to both spi and sdio
wireless: wl1271: support return value for the set power func
wireless: wl1271: add platform driver to get board data
wireless
Move wl12xx.h outside of the spi-specific location,
so it can be shared with both spi and sdio solutions.
Signed-off-by: Ohad Ben-Cohen
---
drivers/net/wireless/wl12xx/wl1251_sdio.c |2 +-
drivers/net/wireless/wl12xx/wl1251_spi.c |2 +-
drivers/net/wireless/wl12xx/wl1271_spi.c |2
Make it possible for the set power method to indicate a
success/failure return value. This is needed to support
more complex power on/off operations such as bringing up
(and down) sdio functions.
Signed-off-by: Ohad Ben-Cohen
---
drivers/net/wireless/wl12xx/wl1271.h |2 +-
drivers/net
On Wed, Aug 11, 2010 at 1:05 PM, Adrian Hunter wrote:
> Ohad Ben-Cohen wrote:
>>
>> Prepare for mmc3 regulator power control by splitting the power
>> control functions of mmc2 and mmc3, and expecting mmc3 to have
>> a single, dedicated, regulator support.
>
&
On Wed, Aug 11, 2010 at 11:37 AM, Roger Quadros wrote:
>> + .ocr_mask = MMC_VDD_165_195,
>
> Do we really need to specify ocr_mask here?
Removed, thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.
On Wed, Aug 11, 2010 at 12:01 PM, Roger Quadros wrote:
> Also shouldn't .nonremovable be set to true? as this is a non-removable card
> slot.
This doesn't seem to have any effect on SDIO, but it can't hurt.
Thanks!
>
> regards,
> -roger
>
--
To unsubscribe from this list: send the line "unsubs
On Wed, Aug 11, 2010 at 1:52 PM, Roger Quadros wrote:
> On 08/11/2010 01:05 PM, Hunter Adrian (Nokia-MS/Helsinki) wrote:
>>
>> Ohad Ben-Cohen wrote:
>>>
>>> Prepare for mmc3 regulator power control by splitting the power
>>> control functions of mmc2
On Wed, Aug 11, 2010 at 12:55 PM, Adrian Hunter wrote:
> Ohad Ben-Cohen wrote:
>>
>> Make this go away:
>>
>> drivers/mmc/host/omap_hsmmc.c: In function 'omap_hsmmc_suspend':
>> drivers/mmc/host/omap_hsmmc.c:2328: warning: unused variable 'state&#
Dynamically create and register a platform driver, that will
be used to to receive board-specific information like irq and
reference clock numbers.
The driver is created dynamically in order to avoid the 1-device
limitation of a fixed platform driver name.
Signed-off-by: Ohad Ben-Cohen
Add MMC3 support on ZOOM, which has the wl1271 device hardwired to.
The wl1271 is a 4-wire, 1.8V, embedded SDIO WLAN device with an
external IRQ line, and power-controlled by a GPIO-based fixed regulator.
Signed-off-by: Ohad Ben-Cohen
---
arch/arm/mach-omap2/board-zoom-peripherals.c | 34
Prepare for mmc3 regulator power control by splitting the power
control functions of mmc2 and mmc3, and expecting mmc3 to have
a single, dedicated, regulator support.
Signed-off-by: Ohad Ben-Cohen
---
arch/arm/mach-omap2/hsmmc.c | 10 --
drivers/mmc/host/omap_hsmmc.c | 67
Add a fixed regulator vmmc device to enable power control
of the wl1271 wlan device.
Signed-off-by: Ohad Ben-Cohen
---
arch/arm/mach-omap2/board-zoom-peripherals.c | 35 ++
1 files changed, 35 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/board-zoom
Make this go away:
drivers/mmc/host/omap_hsmmc.c: In function 'omap_hsmmc_suspend':
drivers/mmc/host/omap_hsmmc.c:2328: warning: unused variable 'state'
Signed-off-by: Ohad Ben-Cohen
---
drivers/mmc/host/omap_hsmmc.c |1 -
1 files changed, 0 insertions(+), 1 deleti
The wl1271 device is using a reference clock that may change
between board to board.
Make the ref_clock parameter configurable by the board
files that set up the device, instead of having a hard coded
value in the driver source itself.
Signed-off-by: Ohad Ben-Cohen
---
drivers/net/wireless
Remove the hard coded irq information, and instead take
the irq information from the board's platform data.
Signed-off-by: Ohad Ben-Cohen
---
drivers/net/wireless/wl12xx/wl1271_sdio.c | 18 +-
1 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/net/wir
Make it possible for the set power method to indicate a
success/failure return value. This is needed to support
more complex power on/off operations such as bringing up
(and down) sdio functions.
Signed-off-by: Ohad Ben-Cohen
---
drivers/net/wireless/wl12xx/wl1271.h |2 +-
drivers/net
Move wl12xx.h outside of the spi-specific location,
so it can be shared with both spi and sdio solutions.
Signed-off-by: Ohad Ben-Cohen
---
drivers/net/wireless/wl12xx/wl1251_sdio.c |2 +-
drivers/net/wireless/wl12xx/wl1251_spi.c |2 +-
drivers/net/wireless/wl12xx/wl1271_spi.c |2
)
Patches are based on linux-next (as of Aug 7th), and tested
on ZOOM2.
Please note that I am going to have a very limited email access
in the next three weeks, so I might not respond right away.
Thanks,
Ohad Ben-Cohen (9):
wireless: wl1271: make wl12xx.h common to both spi and sdio
wireless: wl1271
On Tue, Jul 6, 2010 at 8:42 PM, Nicolas Pitre wrote:
> Another function pair would be needed instead, which would do almost
> like the suspend/resume code is already doing. Something like:
>
> /*
> * Indicate to the core SDIO layer that we're not requiring that the
> * function remain powered.
On Tue, Aug 10, 2010 at 6:00 PM, Sapiens, Rene wrote:
> Hi Ohad,
>
> Sure I will do it.
Thanks a lot, Rene !
Ohad.
>
> Regards,
> Rene
>
>> -Original Message-----
>> From: Ohad Ben-Cohen [mailto:o...@wizery.com]
>> Sent: Tuesday, August 10, 20
Hi Rene,
On Wed, Jun 9, 2010 at 8:38 AM, Guzman Lugo, Fernando
wrote:
>>On Tue, Jun 8, 2010 at 7:16 PM, Sapiens, Rene wrote:
>>> In mbox_rx_work() you are removing the lines that enable back the mbox irq
>>> for the RX case, but inside __mbox_rx_interrupt() this interrupt is
>>> disabled i
Hi Hiroshi,
On Mon, Jun 14, 2010 at 7:51 PM, Fernando Guzman Lugo wrote:
> As pointed by Ben Ohand, the variable rq_full flag is a global
> variable, so if there are multiple mailbox users there will be
> conflics. Now there is a full flag per mailbox queue.
>
> Reported-by:
On Fri, Aug 6, 2010 at 10:07 AM, Linus Walleij
wrote:
> 2010/8/4 Ohad Ben-Cohen :
>> On Wed, Aug 4, 2010 at 2:41 PM, Russell King - ARM Linux
>>>
>>> Why not arrange for a small piece of code to be built into the kernel
>>> when this driver is selected as
On Wed, Aug 4, 2010 at 2:41 PM, Russell King - ARM Linux
wrote:
> On Wed, Aug 04, 2010 at 02:24:39PM +0300, Ohad Ben-Cohen wrote:
>> On Tue, Aug 3, 2010 at 5:17 PM, Vitaly Wool wrote:
>> > On Mon, Aug 2, 2010 at 11:35 PM, Ohad Ben-Cohen wrote:
>> >> I'm
Hi Vitaly,
On Tue, Aug 3, 2010 at 5:17 PM, Vitaly Wool wrote:
> On Mon, Aug 2, 2010 at 11:35 PM, Ohad Ben-Cohen wrote:
>> I'm honestly trying to understand your concerns, but I'm afraid that
>> just saying "it's a hack" is not too informative. Can yo
Hi Vitaly,
On Mon, Aug 2, 2010 at 7:25 PM, Vitaly Wool wrote:
> On Mon, Aug 2, 2010 at 5:54 PM, Ohad Ben-Cohen wrote:
>> SPI is using these spi_board_info tables to populate the SPI device
>> trees. These tables are registered early at the board-specific init
>> code, and
Hi Vitaly,
On Mon, Aug 2, 2010 at 7:19 PM, Vitaly Wool wrote:
> On Mon, Aug 2, 2010 at 5:59 PM, Ohad Ben-Cohen wrote:
>>
>> Check out patch no. 9:
>
> sorry for the confusion. However, I guess if the platform doesn't
> supply this value, we'll just consider
Hi Vitaly,
On Thu, Jul 29, 2010 at 7:16 PM, Vitaly Wool wrote:
> On Thu, Jul 29, 2010 at 8:00 AM, Ohad Ben-Cohen wrote:
>>> To my understanding, this data doesn't belong to mmc_host. It's not a
>>> host data at all. E. g. imagine a GPIO IRQ for some SDIO chip -
On Mon, Aug 2, 2010 at 6:12 PM, Vitaly Wool wrote:
> Also, specifically to 12xx, I'd like to see REF_CLOCK moved on and
> have this set by platform too (I haven't found anything like that in
> the patches but maybe I've overlooked that).
Check out patch no. 9:
http://www.spinics.net/lists/arm-ke
On Mon, Aug 2, 2010 at 2:42 PM, Tony Lindgren wrote:
> Nicolas Pitre made a comment saying he wants to look at these patches
> more, are there other pending comments?
I plan to post a v3 series this week with some of the comments that
were already discussed after v2.
Thanks everyone for the atte
Hi Ernesto,
On Wed, Jul 28, 2010 at 5:45 PM, Ernesto Ramos wrote:
> This series of patches is targetted to remove macros DSP_FAILED
> and DSP_SUCCEEDED since bridge driver currently uses standard kernel
> error codes.
These macros were often used to test for success, instead for errors.
This of
Hi Vitaly,
On Wed, Jul 28, 2010 at 10:47 PM, Vitaly Wool wrote:
> On Wed, Jul 21, 2010 at 7:33 PM, Ohad Ben-Cohen wrote:
>> Add support to set/get mmc_host private embedded
>> data.
>>
>> This is needed to allow software to dynamically
>> create (and remove
Hi Hari,
On Wed, Jul 28, 2010 at 1:02 AM, Ohad Ben-Cohen wrote:
> On Wed, Jul 21, 2010 at 12:41 AM, Hari Kanigeri wrote:
> > This patch provides mutiple readers support for a mailbox
> > instance.
> >
> > Signed-off-by: Hari Kanigeri
> > ---
> > ar
Hi Hari,
On Wed, Jul 21, 2010 at 12:41 AM, Hari Kanigeri wrote:
> This patch provides mutiple readers support for a mailbox
> instance.
>
> Signed-off-by: Hari Kanigeri
> ---
> arch/arm/plat-omap/include/plat/mailbox.h | 6 ++-
> arch/arm/plat-omap/mailbox.c | 63 +
:
>> -Original Message-
>> From: linux-omap-ow...@vger.kernel.org
>> [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of Ohad Ben-Cohen
>> Sent: Friday, July 02, 2010 3:53 AM
>> To: linux-omap@vger.kernel.org
>> Cc: Kanigeri, Hari; Ben-cohen, Ohad
>> Subject: [
On Mon, Jul 26, 2010 at 10:30 PM, John W. Linville
wrote:
> On Wed, Jul 21, 2010 at 08:33:34PM +0300, Ohad Ben-Cohen wrote:
>> This patch series adds native support for wl1271 on ZOOM.
>
> Just for the record, I'm fine with the wl1271 bits here going through
> the omap tr
On Sun, Jul 25, 2010 at 4:56 PM, Nicolas Pitre wrote:
> On Sun, 25 Jul 2010, Ohad Ben-Cohen wrote:
>
>> On Thu, Jul 22, 2010 at 2:35 PM, Roger Quadros
>> wrote:
>> > On 07/21/2010 08:33 PM, ext Ohad Ben-Cohen wrote:
>> >>
>> >> Add support
On Thu, Jul 22, 2010 at 2:35 PM, Roger Quadros wrote:
> On 07/21/2010 08:33 PM, ext Ohad Ben-Cohen wrote:
>>
>> Add support for an SDIO device to stay powered off even without
>> the presence of an SDIO function driver. A host should explicitly
>> ask for it by means
Add a fixed regulator vmmc device to enable power control
of the wl1271 wlan device.
Signed-off-by: Ohad Ben-Cohen
---
This patch is a follow-up to a previous wl1271 discussion,
thus all original recipients are CC'ed.
arch/arm/mach-omap2/board-zoom-peripherals.c |
On Fri, Jul 23, 2010 at 12:15 PM, Mark Brown
wrote:
> On Fri, Jul 23, 2010 at 02:13:38AM +0300, Ohad Ben-Cohen wrote:
>> On Thu, Jul 22, 2010 at 2:16 PM, Roger Quadros
>> wrote:
>> > .dev_name = "mmci-omap-hs.2"
>
>> I already set the .dev me
On Fri, Jul 23, 2010 at 1:56 AM, Nicolas Pitre wrote:
> On Wed, 21 Jul 2010, Ohad Ben-Cohen wrote:
>
>> This patch series adds native support for wl1271 on ZOOM.
>>
>> Changes since v1:
>>
>> - introduce a fixed regulator device to control the power of wl1271
&
Hi Marcel,
On Wed, Jul 21, 2010 at 8:58 PM, Marcel Holtmann wrote:
>> Add SDIO IDs for TI and for TI's wl1271 wlan device.
>>
>> Signed-off-by: Ohad Ben-Cohen
>> ---
>> include/linux/mmc/sdio_ids.h | 3 +++
>> 1 files changed, 3 insertions(+), 0 dele
Hi Gever,
On Wed, Jul 21, 2010 at 9:55 PM, Gabay, Benzy wrote:
> From: Ohad Ben-Cohen [mailto:o...@wizery.com]
> Sent: Wednesday, July 21, 2010 12:34 PM
> To: linux-wirel...@vger.kernel.org; linux-...@vger.kernel.org;
> linux-omap@vger.kernel.org
> Cc: linux-arm-ker...@lists.in
On Thu, Jul 22, 2010 at 2:16 PM, Roger Quadros wrote:
> On 07/21/2010 08:59 PM, ext Mark Brown wrote:
>>
>> On Wed, Jul 21, 2010 at 08:33:44PM +0300, Ohad Ben-Cohen wrote:
>>
>>> +static struct regulator_consumer_supply zoom_vmmc3_supply = {
>&
Keep the MMC3 wl1271 WLAN device powered off until its
SDIO function driver requests otherwise.
Signed-off-by: Ohad Ben-Cohen
---
arch/arm/mach-omap2/board-zoom-peripherals.c |1 +
arch/arm/mach-omap2/hsmmc.c |3 +++
arch/arm/mach-omap2/hsmmc.h |1
: Ohad Ben-Cohen
---
drivers/mmc/core/sdio.c | 15 +--
include/linux/mmc/host.h |1 +
2 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/core/sdio.c b/drivers/mmc/core/sdio.c
index 5c0fbfa..164353f 100644
--- a/drivers/mmc/core/sdio.c
+++ b/drivers/mmc
call SDIO claim/release power API to turn the wl1271
power on and off
Signed-off-by: Ohad Ben-Cohen
---
drivers/net/wireless/wl12xx/wl1271_sdio.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/net/wireless/wl12xx/wl1271_sdio.c
b/drivers/net/wireless/wl12xx
Ben-Cohen
---
drivers/mmc/core/sdio.c | 14 +-
drivers/mmc/core/sdio_bus.c |9 -
2 files changed, 13 insertions(+), 10 deletions(-)
diff --git a/drivers/mmc/core/sdio.c b/drivers/mmc/core/sdio.c
index 79e6fa1..5c0fbfa 100644
--- a/drivers/mmc/core/sdio.c
+++ b/drivers
Introduce the sdio_claim_power/sdio_release_power API
(with correspoding mmc_claim_power/mmc_release_power)
that controls the power of the card. A reference count
scheme is employed, to allow SDIO function voting.
Signed-off-by: Ohad Ben-Cohen
---
drivers/mmc/core/bus.c|3
Before invoking a card's resume handler, verify one exists.
Signed-off-by: Ohad Ben-Cohen
---
drivers/mmc/core/sdio.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/mmc/core/sdio.c b/drivers/mmc/core/sdio.c
index 645f173..37739f5 100644
--- a/driver
ume, since now this is part of mmc_sdio_init_card.
Signed-off-by: Ohad Ben-Cohen
---
drivers/mmc/core/sdio.c |4
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/mmc/core/sdio.c b/drivers/mmc/core/sdio.c
index b9dee28..645f173 100644
--- a/drivers/mmc/core/sd
Allow board-specific settings of private mmc data, in order to
allow embedded SDIO devices to communicate board-specific parameters
to the SDIO function driver (e.g., the external IRQ line of the wl1271).
Signed-off-by: Ohad Ben-Cohen
---
arch/arm/mach-omap2/hsmmc.c |2 ++
arch
Add MMC3 support on ZOOM, which has the wl1271 device hardwired to.
The wl1271 is a 4-wire, 1.8V, embedded SDIO WLAN device with an
external IRQ line, and power-controlled by a GPIO-based fixed regulator.
Signed-off-by: Ohad Ben-Cohen
---
arch/arm/mach-omap2/board-zoom-peripherals.c | 19
Prepare for mmc3 regulator power control by splitting the power
control functions of mmc2 and mmc3, and expecting mmc3 to have
a single, dedicated, regulator support.
Signed-off-by: Ohad Ben-Cohen
---
arch/arm/mach-omap2/hsmmc.c | 10 --
drivers/mmc/host/omap_hsmmc.c | 67
Add a fixed regulator vmmc device to enable power control
of the wl1271 wlan device.
Signed-off-by: Ohad Ben-Cohen
---
arch/arm/mach-omap2/board-zoom-peripherals.c | 34 ++
1 files changed, 34 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/board-zoom
The wl1271 device is using a reference clock that may change
between board to board.
Make the ref_clock parameter configurable by the board
files that set up the device, instead of having a hard coded
value in the driver source itself.
Signed-off-by: Ohad Ben-Cohen
---
drivers/net/wireless
Remove the hard coded irq information, and instead take
the irq information from the board private data
which is supplied by the sdio function.
Signed-off-by: Ohad Ben-Cohen
---
drivers/net/wireless/wl12xx/wl1271_sdio.c | 14 --
1 files changed, 8 insertions(+), 6 deletions
Make it possible for the set power method to indicate a
success/failure return value. This is needed to support
more complex power on/off operations such as bringing up
(and down) sdio functions.
Signed-off-by: Ohad Ben-Cohen
---
drivers/net/wireless/wl12xx/wl1271.h |2 +-
drivers/net
Move wl12xx.h outside of the spi-specific location,
so it can be shared with both spi and sdio solutions.
Signed-off-by: Ohad Ben-Cohen
---
drivers/net/wireless/wl12xx/wl1251_sdio.c |2 +-
drivers/net/wireless/wl12xx/wl1251_spi.c |2 +-
drivers/net/wireless/wl12xx/wl1271_spi.c |2
Add board muxing to support the wlan wl1271 chip that is
hardwired to mmc2 (third mmc controller) on the ZOOM3.
Signed-off-by: Ohad Ben-Cohen
---
arch/arm/mach-omap2/board-zoom3.c | 13 +
1 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/board
Add board muxing to support the wlan wl1271 chip that is
hardwired to mmc2 (third mmc controller) on the ZOOM2.
Signed-off-by: Ohad Ben-Cohen
---
arch/arm/mach-omap2/board-zoom2.c | 13 +
1 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/board
to be able to get that context
back upon creation of the new sdio func).
Signed-off-by: Ohad Ben-Cohen
---
include/linux/mmc/host.h | 12
1 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/include/linux/mmc/host.h b/include/linux/mmc/host.h
index f65913c..80db597
Remove SDIO IDs from the driver code since now it is
included in linux/mmc/sdio_ids.h.
Signed-off-by: Ohad Ben-Cohen
---
drivers/net/wireless/wl12xx/wl1271_sdio.c |8
1 files changed, 0 insertions(+), 8 deletions(-)
diff --git a/drivers/net/wireless/wl12xx/wl1271_sdio.c
b/drivers
Add SDIO IDs for TI and for TI's wl1271 wlan device.
Signed-off-by: Ohad Ben-Cohen
---
include/linux/mmc/sdio_ids.h |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/include/linux/mmc/sdio_ids.h b/include/linux/mmc/sdio_ids.h
index 33b2ea0..0d313c6 100644
--- a/in
one thing
we plan to look at next is their bahvior together with SDIO Suspend/Resume.
Special thanks to Roger Quadros and Nicolas Pitre for their extensive
review and helpful suggestions.
The patches are based on 2.6.35-rc5, and were tested on ZOOM3.
Thanks,
Ohad Ben-Cohen (20):
sdio: add T
Hi Roger,
On Fri, Jul 9, 2010 at 11:12 AM, Roger Quadros wrote:
> You are already
> creating a new platform device for wl1271_sdio just to pass platform_data
With the new approach, I can remove this platform device altogether,
and completely rely on the sdio function device for driver probing (a
On Thu, Jul 8, 2010 at 6:39 AM, Ghorai, Sukumar wrote:
> [Ghorai] In general we can avoid OMAP_ZOOM_WLAN and MMC_EMBEDDED_SDIO as
> kconfig option. 1st one is board specific and 2nd one could be generic sdio
> code. As I mentioned in other patch too.
Thanks, will get rid of the extra config op
On Thu, Jul 8, 2010 at 12:45 PM, Tony Lindgren wrote:
>
> * Ghorai, Sukumar [100708 06:34]:
> > > @@ -71,6 +71,21 @@ static struct twl4030_platform_data zoom2_twldata = {
> > >
> > > #ifdef CONFIG_OMAP_MUX
> > > static struct omap_board_mux board_mux[] __initdata = {
> > > +#ifdef CONFIG_OMAP_Z
Hi Nicolas and Roger,
On Tue, Jul 6, 2010 at 8:42 PM, Nicolas Pitre wrote:
> On Tue, 6 Jul 2010, Roger Quadros wrote:
> > If the Power enable GPIO can be treated as SDIO slot supply (i.e. vmmc),
> > then
> > the SDIO/MMC core should tackle it, just like it deals with supply for slots
> > with re
On Wed, Jul 7, 2010 at 12:31 PM, Felipe Contreras
wrote:
> On Tue, Jul 6, 2010 at 6:52 PM, Omar Ramirez Luna wrote:
>> at that point *you* wanted your patches not to be
>> included if the last one wasn't merged in.
>
> Not without the copyright update patch.
...
> So. Would you care to give a rea
On Tue, Jul 6, 2010 at 6:49 PM, Grazvydas Ignotas wrote:
> Hm, do we really need a Kconfig option just for a single pointer? It
> only saves sizeof(void *) bytes per host, but adds rather confusing
> config option for users and some ifdef complexity.
No strong feelings about it, I can remove that
Hi Roger,
On Tue, Jul 6, 2010 at 3:33 PM, Roger Quadros wrote:
>> +static void omap_zoom_wlan_power(bool enable)
>> +{
>> + int val = enable ? 1 : 0;
>> +
>> + pr_info("%s: set power %d\n", __func__, val);
>> +
>> + gpio_set_value(OMAP_ZOOM_WLAN_PMENA_GPIO, val);
>> +}
>
> Can w
On Tue, Jul 6, 2010 at 3:39 PM, Roger Quadros wrote:
> Just to clarify, is the wl1271 device always powered on the board?
Yes.
> And this GPIO power enable (OMAP_ZOOM_WLAN_PMENA_GPIO) is used to gate this
> supply internally?
Yes. It's a digital input that the chip does not draw current from
(w
Hi Roger,
On Tue, Jul 6, 2010 at 1:35 PM, Roger Quadros wrote:
> My point is that shouldn't this be handled by SDIO core?
Care to explain what you mean / give a code example ?
> If there are no users for the SDIO function and the card, doesn't the SDIO
> core power down the slot and take care o
On Tue, Jul 6, 2010 at 2:02 PM, Roger Quadros wrote:
> On 07/06/2010 01:22 PM, ext Ohad Ben-Cohen wrote:
>> We prefer not to power up the chip as early as boot time; instead, we
>
> Why?
Let's say you boot your device but never use WLAN.
In this scenario, we prefer the w
On Tue, Jul 6, 2010 at 1:22 PM, Ohad Ben-Cohen wrote:
> Note: the wl1271 device does support standard card detection, but
> AFAIK there's a limitation to use that with the specific omap
> controller the device is hardwired to. I will try to get more info
> about that, but p
Hi Nicolas,
On Tue, Jul 6, 2010 at 4:45 AM, Nicolas Pitre wrote:
> On Tue, 6 Jul 2010, Ohad Ben-Cohen wrote:
>
>> From: Ohad Ben-Cohen
>>
>> Add support for software emulation of card detect
>> events.
>>
>> This is required for specific controllers
Hi Roger,
On Tue, Jul 6, 2010 at 11:53 AM, Roger Quadros wrote:
> Could you please explain why you need to do this?
To minimize power consumption when the wlan device is not in use, we
would like to keep the device powered off as long as the interface is
down, and only power it on when the user
From: Ohad Ben-Cohen
Make it possible to build and use TI's wl1271
device on the ZOOM boards.
The device is an embedded SDIO WLAN chip
that is hardwired to the 3rd mmc controller
of the ZOOM2/3 boards.
Signed-off-by: Ohad Ben-Cohen
---
arch/arm/mach-omap2/Kconfig |
From: Ohad Ben-Cohen
Add WLAN platform device and control
functions (power and virtual card detect)
in order to allow software to control the
embedded SDIO WLAN device which resides on
the ZOOM board (TI's wl1271 device).
Based on Android's WLAN control functions by
San Mehat .
Sig
From: Ohad Ben-Cohen
The wl1271 device is using a reference clock that may change
between board to board.
Make the ref_clock parameter configurable by the board
files that set up the device, instead of having a hard coded
value in the driver source itself.
Signed-off-by: Ohad Ben-Cohen
601 - 700 of 824 matches
Mail list logo
