Re: [PATCH] omapfb: setting GOLCD bit for shadow registers to make effect

2008-09-09 Thread Daniel Stone
On Mon, Sep 08, 2008 at 09:02:56PM +0100, ext Måns Rullgård wrote: arun c [EMAIL PROTECTED] writes: + while (dispc_read_reg(DISPC_CONTROL) (1 5)) + continue; + MOD_REG_FLD(DISPC_CONTROL, 1 5, 1 5); + return height * screen_width * bpp / 8; } This looks good.

Re: [PATCH] omapfb: setting GOLCD bit for shadow registers to make effect

2008-09-09 Thread Måns Rullgård
Daniel Stone wrote: On Mon, Sep 08, 2008 at 09:02:56PM +0100, ext Måns Rullgård wrote: arun c [EMAIL PROTECTED] writes: + while (dispc_read_reg(DISPC_CONTROL) (1 5)) + continue; + MOD_REG_FLD(DISPC_CONTROL, 1 5, 1 5); + return height * screen_width * bpp / 8; }

[PATCH] omapfb: setting GOLCD bit for shadow registers to make effect

2008-09-08 Thread arun c
A shadow register change has no direct effect on the display configuration until the GOLCD (DISPC_CONTROL[5]) is set. Signed-off-by: Arun C [EMAIL PROTECTED] --- drivers/video/omap/dispc.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/video/omap/dispc.c

Re: [PATCH] omapfb: setting GOLCD bit for shadow registers to make effect

2008-09-08 Thread Måns Rullgård
arun c [EMAIL PROTECTED] writes: A shadow register change has no direct effect on the display configuration until the GOLCD (DISPC_CONTROL[5]) is set. Signed-off-by: Arun C [EMAIL PROTECTED] --- drivers/video/omap/dispc.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-)