Re: [PATCH v2 00/13] lpfc updates for 12.0.0.2

James, > This patch contains lpfc bug fixes > > The patches were cut against the Martin's 4.17/scsi-queue tree Applied to 4.18/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [Resend Patch 1/3] Vmbus: Add function to report available ring buffer to write in total ring size percentage

Long, > I hope this patch set goes through SCSI, because it's purpose is to > improve storvsc. > > If this strategy is not possible, I can resubmit the 1st two patches to > net, and the 3rd patch to scsi after the 1st two are merged. Applied to my staging tree for 4.18/scsi-queue. Thanks! --

Re: [PATCH 0/2] megaraid_sas: driver fixes and updates

Shivasharan, > Himanshu Jha (1): > megaraid_sas: Use zeroing memory allocator than allocator/memset > > Shivasharan S (2): > megaraid_sas: Increase timeout by 1 sec for non-RAID fastpath IOs > megaraid_sas: driver version upgrade Applied to 4.18/scsi-queue. Thanks! -- Martin K. Petersen

Re: [PATCH 0/8] hisi_sas: some misc changes

John, > This patchset introduces some minor, more trivial patches, some of > which have been sitting on our internal dev branch for a while. Applied to 4.18/scsi-queue. Thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v7] scsi: new zorro_esp.c for Amiga Zorro NCR53C9x boards

Hi Christoph, thanks for your review. Short of a complete rewrite of the Zorro driver support code to be closer to what PCI does, I don' see what can be done about the use of Zorro IDs. I don't think such a rewrite is planned in the near future, Geert? I can certainly use board type enums as

Re: [PATCH v2] scsi: cxgb4i: silence overflow warning in t4_uld_rx_handler()

Dan, > Smatch marks skb->data as untrusted so it complains that there is a > potential overflow here: > > drivers/scsi/cxgbi/cxgb4i/cxgb4i.c:2111 t4_uld_rx_handler() > error: buffer overflow 'cxgb4i_cplhandlers' 239 <= 255. > > In this case, skb->data comes from the hardware or

Re: [PATCH] scsi: devinfo: Add Microsoft iSCSI target to 1024 sector blacklist

Ross, > The Windows Server 2016 iSCSI target doesn't work with the Linux > kernel initiator since the kernel started sending larger requests by > default, nor does it implement the block limits VPD page. Apply the > sector limit workaround for these targets. Applied to 4.17/scsi-fixes, thank

Re: [PATCH] scsi: dpt_i2o: Use after free in I2ORESETCMD ioctl

Dan, > Here is another use after free if we reset the card. The adpt_hba_reset() > function frees "pHba" on error. Applied to 4.17/scsi-fixes. Thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v3 0/3] Report all request failures again to user space

Johannes, > I did start a series [1] for this but than got distracted by more urgent > things. I can pick it up again I think. > > [1] > https://git.kernel.org/pub/scm/linux/kernel/git/jth/linux.git/log/?h=iscsi_DID_REQUEUE Definitely a step in the right direction. -- Martin K. Petersen

Re: [PATCH v3 0/3] Report all request failures again to user space

Bart, > A recent change in the SCSI core caused certain request failures no > longer to be reported to user space. Damien noticed this by sending a > write request that is not aligned to the write pointer to an SMR drive > from user space. Such non-aligned write requests are failed by the >

Re: [PATCH] scsi: qla2xxx: Correct setting of SAM_STAT_CHECK_CONDITION

Johannes, > Bart reports that in qla_isr.c's qla2x00_handle_dif_error we're > wrongly shifting the SAM_STAT_CHECK_CONDITION by one instead of > directly ORing it onto the SCSI command's result. Applied to 4.17/scsi-fixes. Thx! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2] qla2xxx: correctly shift host byte

Johannes, > The SCSI host byte has to be shifted by 16 not 6. > > As Bart pointed out this patch does not change any functionality > because DID_OK == 0, but a wrong shift is irritating for the reviewer. Applied to 4.17/scsi-fixes. Thank you! -- Martin K. Petersen Oracle Linux

Re: [PATCH] aacraid: Insure command thread is not recursively stopped

Dave, > If a recursive IOP_RESET is invoked, usually due to the eh_thread > handling errors after the first reset, be sure we flag that the > command thread has been stopped to avoid an Oops of the form; Applied to 4.17/scsi-fixes. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] qla2xxx: Avoid double completion of abort command

Himanshu, >> qla2x00_tmf_sp_done() now deletes the timer that will run >> qla2x00_tmf_iocb_timeout(), but doesn't check whether the timer >> already expired. Check the return value from del_timer() to avoid >> calling complete() a second time. > Looks good. > > Acked-by: Himanshu Madhani

Re: [PATCH v2] qla2xxx: Fix race condition between iocb timeout and initialisation

Himanshu, > Thanks again for the patch. Testing was successful. > > Acked-by: Himanshu Madhani Applied to 4.17/scsi-fixes. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: 4.15.14 crash with iscsi target and dvd

On Mon, Apr 09, 2018 at 07:43:01PM -0400, Wakko Warner wrote: > Ming Lei wrote: > > On Mon, Apr 09, 2018 at 09:30:11PM +, Bart Van Assche wrote: > > > Hello Ming, > > > > > > Can you have a look at this? The start of this e-mail thread is available > > > at > > >

Re: 4.15.14 crash with iscsi target and dvd

Ming Lei wrote: > On Mon, Apr 09, 2018 at 09:30:11PM +, Bart Van Assche wrote: > > Hello Ming, > > > > Can you have a look at this? The start of this e-mail thread is available at > > https://www.mail-archive.com/linux-scsi@vger.kernel.org/msg72574.html. > > Sure, thanks for your sharing. >

Re: 4.15.14 crash with iscsi target and dvd

On Mon, Apr 09, 2018 at 09:30:11PM +, Bart Van Assche wrote: > On Sun, 2018-04-08 at 12:02 -0400, Wakko Warner wrote: > > I finished with git bisect. Here's the output: > > 84c8590646d5b35804bac60eb58b145839b5893e is the first bad commit > > commit 84c8590646d5b35804bac60eb58b145839b5893e > >

Re: [PATCH] iscsi: respond to netlink with unicast when appropriate

On 04/09/2018 03:15 PM, Chris Leech wrote: > Instead of always multicasting responses, send a unicast netlink message > directed at the correct pid. This will be needed if we ever want to > support multiple userspace processes interacting with the kernel over > iSCSI netlink simultaneously.

Re: usercopy whitelist woe in scsi_sense_cache

On Mon, Apr 9, 2018 at 1:30 PM, Kees Cook wrote: > Ah! dm-crypt too. I'll see if I can get that added easily to my tests. Quick update: I added dm-crypt (with XFS on top) and it hung my system almost immediately. I got no warnings at all, though. -Kees -- Kees Cook

[PATCH] iscsi: respond to netlink with unicast when appropriate

Instead of always multicasting responses, send a unicast netlink message directed at the correct pid. This will be needed if we ever want to support multiple userspace processes interacting with the kernel over iSCSI netlink simultaneously. Limitations can currently be seen if you attempt to run

Re: 4.15.14 crash with iscsi target and dvd

On Sun, 2018-04-08 at 12:02 -0400, Wakko Warner wrote: > I finished with git bisect. Here's the output: > 84c8590646d5b35804bac60eb58b145839b5893e is the first bad commit > commit 84c8590646d5b35804bac60eb58b145839b5893e > Author: Ming Lei > Date: Fri Nov 11 20:05:32

[PATCH v2 04/13] lpfc: Enlarge nvmet asynchronous receive buffer counts

Under large io load, the current sizing of asynchronous buffer counts could be exceeded, indicated by a 2885 log message: 2885 Port Status Event: port status reg 0x8180, port smphr reg 0xc000, error 1=0x52004a01, error 2=0x0 Enlarge the async receive queue size. Allow for a

[PATCH v2 13/13] lpfc: update driver version to 12.0.0.2

Update the driver version to 12.0.0.2 Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Hannes Reinecke --- drivers/scsi/lpfc/lpfc_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 08/13] lpfc: Fix WQ/CQ creation for older asic's.

The patch to enlarge WQ/CQ creation keys off of an adapter response that indicates support for the larger values. Older adapters return an incorrect response and are limited in size. Thus the adapters fail the WQ creation steps. Augment the WQ sizing checks with a check on the older adapter types

[PATCH v2 10/13] lpfc: Fix nvme remoteport registration race conditions

On tests adding and removing a remote port, calls to nvme_info would eventually show fewer target ports discovered than were present in the san. Additionally, the following error messages were seen: 6031 RemotePort Registration failed err: -116, DID x471301 There is a race condition that exists

[PATCH v2 06/13] lpfc: Fix lingering lpfc_wq resource after driver unload

After driver unloads lpfc_wq remains active. The destroy_workqueue calls were not being made in driver unload. Additionally, SLI3 is allocating lpfc_wq resources, but never uses it. Make the destroy_workqueue calls on driver unload. Modify the SLI3 code path no longer allocate lpfc_wq resources.

[PATCH v2 07/13] lpfc: Fix NULL pointer access in lpfc_nvme_info_show

After making remoteport unregister requests, the ndlp nrport pointer was stale. Track when waiting for waiting for unregister completion callback and adjust nldp pointer assignment. Add a few safety checks for NULL pointer values. Signed-off-by: Dick Kennedy

[PATCH v2 05/13] lpfc: Fix Abort request WQ selection

When running loads that generated aborts, io errors where seen. Turns out the abort requests where not placed on the proper WQ resulting in the errors. Closer inspection inspection of this error also showed improper spinlock api use. Correct the WQ selection policy for the abort requests. Correct

[PATCH v2 12/13] lpfc: Correct missing remoteport registration during link bounces

Remote port disappearance/reappearances would cause a series of RSCN events to be delivered to the driver. During the resulting GID_FT handling, the driver clears the fc4 settings on the remote port, which makes it skip registration. As such, the nvme associations eventually fail and return io

[PATCH v2 09/13] lpfc: Fix driver not recovering NVME rports during target link faults

During target-side port faults, the driver would not recover all target port logins. This resulted in a loss of nvme device discovery. The driver is coded to wait for all GID_FT requests to complete before restarting discovery. A fault is seen where the outstanding GIT_FT counts are not properly

[PATCH v2 11/13] lpfc: Fix NULL pointer reference when resetting adapter

Points referencing local port structures didn't accommodate cases where the localport may not be registered yet. Add NULL pointer checks to logic. Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Hannes Reinecke

[PATCH v2 02/13] lpfc: Correct target queue depth application changes

The max_scsicmpl_time parameter can be used to perform scsi cmd queue depth mgmt based on io completion time: the queue depth is reduced to make completion time shorter. However, as soon as an io completes and the completion time is within limits, the code immediately bumps the queue depth limit

[PATCH v2 03/13] lpfc: Add per io channel NVME IO statistics

When debugging various issues, per IO channel IO statistics were useful to understand what was happening. However, many of the stats were on a port basis rather than an io channel basis. Move statistics to an io channel basis. Signed-off-by: Dick Kennedy

[PATCH v2 00/13] lpfc updates for 12.0.0.2

This patch contains lpfc bug fixes The patches were cut against the Martin's 4.17/scsi-queue tree v2: Removed patch: lpfc: Fix create_association oops on unloading LPFC driver James Smart (13): lpfc: Fix multiple PRLI completion error path lpfc: Correct target queue depth application

[PATCH v2 01/13] lpfc: Fix multiple PRLI completion error path

Nodelist entry for SCSI array ends up in UNMAPPED state. This is due to illegal discovery State machine transition because of two PRLIs and the first one failing with LS_RJT. Also, the error path was designed assuming the PRLIs complete in the order they were sent, FCP first, then NVME. In a

Re: [PATCH 12/14] lpfc: Fix create_association oops on unloading LPFC driver

On 4/9/2018 2:14 PM, James Smart wrote: On 4/9/2018 1:03 AM, Hannes Reinecke wrote: On Sat,  7 Apr 2018 11:30:24 -0700 James Smart wrote: Driver unload isn't waiting for all outstanding nvme associations to terminate before clearing structures. In particular, it did not

Re: [PATCH 12/14] lpfc: Fix create_association oops on unloading LPFC driver

On 4/9/2018 1:03 AM, Hannes Reinecke wrote: On Sat, 7 Apr 2018 11:30:24 -0700 James Smart wrote: Driver unload isn't waiting for all outstanding nvme associations to terminate before clearing structures. In particular, it did not set dev_loss_tmo to 0 such that all

Re: [PATCH 01/10] staging: fnic2 add initialization

Greg, >> If you think that this driver doesn't belong in the drivers/staging >> community, we are happy to explore getting the driver fully ready on >> our side and getting it into the "proper" place. > > I'll take anything in staging as long as it has the correct license and > builds, that's

Re: usercopy whitelist woe in scsi_sense_cache

On Mon, Apr 9, 2018 at 12:02 PM, Oleksandr Natalenko wrote: > > Hi. > > (fancy details for linux-block and BFQ people go below) > > 09.04.2018 20:32, Kees Cook wrote: >> >> Ah, this detail I didn't have. I've changed my environment to >> >> build with: >> >>

Re: [PATCH 1/1] scsi/ufs: qcom: Don't enable PHY_QCOM_UFS by default

On Mon 09 Apr 10:38 PDT 2018, Vivek Gautam wrote: > On 4/9/2018 10:21 PM, Bjorn Andersson wrote: > > On Mon 09 Apr 06:24 PDT 2018, Vivek Gautam wrote: [..] > > > diff --git a/include/linux/phy/phy-qcom-ufs.h > > > b/include/linux/phy/phy-qcom-ufs.h > > > index 0a2c18a9771d..1388c2a2965e 100644 >

Re: [PATCH 1/2] scsi: ufs: Add UFS platform driver for Cadence UFS

On Wed, Mar 28, 2018 at 11:25:34AM +, Janek Kotas wrote: > This patch adds a device tree platform > driver description for Cadence UFS Controller. You have exactly the same subject for both patches. Don't do that. For bindings, the preferred subject prefix is "dt-bindings: ufs: ". > >

Re: usercopy whitelist woe in scsi_sense_cache

Hi. (fancy details for linux-block and BFQ people go below) 09.04.2018 20:32, Kees Cook wrote: Ah, this detail I didn't have. I've changed my environment to build with: CONFIG_BLK_MQ_PCI=y CONFIG_BLK_MQ_VIRTIO=y CONFIG_IOSCHED_BFQ=y boot with scsi_mod.use_blk_mq=1 and select BFQ in the

Re: usercopy whitelist woe in scsi_sense_cache

On Sun, Apr 8, 2018 at 12:07 PM, Oleksandr Natalenko wrote: > So far, I wasn't able to trigger this with mq-deadline (or without blk-mq). > Maybe, this has something to do with blk-mq+BFQ re-queuing, or it's just me > not being persistent enough. Ah, this detail I

Re: [PATCH 1/1] scsi/ufs: qcom: Don't enable PHY_QCOM_UFS by default

Hi Bjorn, On 4/9/2018 10:21 PM, Bjorn Andersson wrote: On Mon 09 Apr 06:24 PDT 2018, Vivek Gautam wrote: While we try to transition from a separate ufs phy driver to a more integrated qmp phy driver, don't let SCSI_UFS_QCOM to enable PHY_QCOM_UFS config by default. The users should enable

Re: [PATCH 1/1] scsi/ufs: qcom: Don't enable PHY_QCOM_UFS by default

On Mon 09 Apr 06:24 PDT 2018, Vivek Gautam wrote: > While we try to transition from a separate ufs phy driver to a > more integrated qmp phy driver, don't let SCSI_UFS_QCOM to > enable PHY_QCOM_UFS config by default. > The users should enable this in their defconfigs. > Also add inline

Re: Multi-Actuator SAS HDD First Look

On 2018-04-09 02:17 AM, Hannes Reinecke wrote: On 04/09/2018 04:08 AM, Tim Walker wrote: On Fri, Apr 6, 2018 at 11:09 AM, Douglas Gilbert wrote: On 2018-04-06 02:42 AM, Christoph Hellwig wrote: On Fri, Apr 06, 2018 at 08:24:18AM +0200, Hannes Reinecke wrote: Ah.

Re: usercopy whitelist woe in scsi_sense_cache

Hi. 09.04.2018 11:35, Christoph Hellwig wrote: I really can't make sense of that report. Sorry, I have nothing to add there so far, I just see the symptom of something going wrong in the ioctl code path that is invoked by smartctl, but I have no idea what's the minimal environment to

Re: [PATCH] scsi: qla2xxx: Correct setting of SAM_STAT_CHECK_CONDITION

On Mon, 2018-04-09 at 14:39 +0200, Johannes Thumshirn wrote: > Bart reports that in qla_isr.c's qla2x00_handle_dif_error we're > wrongly shifting the SAM_STAT_CHECK_CONDITION by one instead of > directly ORing it onto the SCSI command's result. Reviewed-by: Bart Van Assche

Re: [PATCH] scsi: qla2xxx: Correct setting of SAM_STAT_CHECK_CONDITION

On 04/09/2018 02:39 PM, Johannes Thumshirn wrote: > Bart reports that in qla_isr.c's qla2x00_handle_dif_error we're > wrongly shifting the SAM_STAT_CHECK_CONDITION by one instead of > directly ORing it onto the SCSI command's result. > > Signed-off-by: Johannes Thumshirn >

[PATCH 1/1] scsi/ufs: qcom: Don't enable PHY_QCOM_UFS by default

While we try to transition from a separate ufs phy driver to a more integrated qmp phy driver, don't let SCSI_UFS_QCOM to enable PHY_QCOM_UFS config by default. The users should enable this in their defconfigs. Also add inline definitions for couple of functions - a)

[PATCH] scsi: qla2xxx: Correct setting of SAM_STAT_CHECK_CONDITION

Bart reports that in qla_isr.c's qla2x00_handle_dif_error we're wrongly shifting the SAM_STAT_CHECK_CONDITION by one instead of directly ORing it onto the SCSI command's result. Signed-off-by: Johannes Thumshirn Reported-by: Bart Van Assche Cc:

[PATCH v2] qla2xxx: correctly shift host byte

The SCSI host byte has to be shifted by 16 not 6. As Bart pointed out this patch does not change any functionality because DID_OK == 0, but a wrong shift is irritating for the reviewer. Signed-off-by: Johannes Thumshirn Reviewed-by: Bart Van Assche

Re: [PATCH] qla2xxx: correctly shift host byte

On Fri, Apr 06, 2018 at 03:33:30PM +, Bart Van Assche wrote: > On Fri, 2018-04-06 at 09:52 +0200, Johannes Thumshirn wrote: > > The host byte has to be shifted by 16 not 6. > > > > Signed-off-by: Johannes Thumshirn > > --- > > drivers/scsi/qla2xxx/qla_isr.c | 2 +- > > 1

Re: [PATCH] qla2xxx: correctly shift host byte

On Fri, Apr 06, 2018 at 03:01:20PM +, Bart Van Assche wrote: > Please mention in the description of this patch that this patch does not > change any functionality because DID_OK == 0. Anyway: > > Reviewed-by: Bart Van Assche I'll do. Thanks for the review. --

Re: [PATCH v3 0/3] Report all request failures again to user space

On Fri, Apr 06, 2018 at 02:59:16PM +, Bart Van Assche wrote: > On Fri, 2018-04-06 at 09:45 +0200, Johannes Thumshirn wrote: > > On 05/04/18 19:49, Martin K. Petersen wrote: > > > Longer term I'd really like to see the command result integer > > > host/driver/msg/status stuff cleaned up. It's

[PATCH] tcmu: fix error resetting qfull_time_out to default

Problem: --- $ cat /sys/kernel/config/target/core/user_0/block/attrib/qfull_time_out -1 $ echo "-1" > /sys/kernel/config/target/core/user_0/block/attrib/qfull_time_out -bash: echo: write error: Invalid argument Fix: --- This patch will help reset qfull_time_out to its default i.e.

[PATCH v2 11/14] mpt3sas: Update MPI Headers

Update MPI Files to support protocol level reset for NVMe device. Signed-off-by: Chaitra P B Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpi/mpi2.h | 9 ++--- drivers/scsi/mpt3sas/mpi/mpi2_cnfg.h | 30

[PATCH v2 08/14] mpt3sas: Allow processing of events during driver unload.

Events were not processed during driver unload, hence unloading of driver doesn't complete when drives are disconnected while unloading of driver. So don't block events in ISR path, i,e., remove the flag ioc->remove_host so that events are getting processed during driver unload. Thus allowing

[PATCH v2 02/14] mpt3sas: Pre-allocate RDPQ Array at driver boot time.

Instead of allocating RDPQ array (This stores the address's of each RDPQ pools) at run time, now it will be allocated once during driver load time and same will be reused during host reset operation also (instead of allocating & freeing this buffer on the fly during every host reset operation) and

[PATCH v2 00/14] mpt3sas: Enhancements and Defect fixes.

Chaitra P B (14): mpt3sas: Bug fix for big endian systems. mpt3sas: Pre-allocate RDPQ Array at driver boot time. mpt3sas: Lockless access for chain buffers. mpt3sas: Optimize I/O memory consumption in driver. mpt3sas: Enhanced handling of Sense Buffer. mpt3sas: Added support for SAS

[PATCH v2 14/14] mpt3sas: Update driver version "25.100.00.00"

Update driver version to match OOB/internal driver version. Signed-off-by: Chaitra P B Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_base.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH v2 03/14] mpt3sas: Lockless access for chain buffers.

Introduces Chain lookup table/tracker and implements accessing chain buffer using smid. Removed link list based access of chain buffer which requires lock and allocated as many chains needed. Signed-off-by: Chaitra P B Signed-off-by: Suganath Prabu S

[PATCH v2 06/14] mpt3sas: Added support for SAS Device Discovery Error Event.

The SAS Device Discovery Error Event is sent to the host when discovery for a particular device is failed during discovery, even after maximum retries by the IOC. Signed-off-by: Chaitra P B Signed-off-by: Suganath Prabu S ---

[PATCH v2 10/14] mpt3sas: Report Firmware Package Version from HBA Driver.

Added function _base_display_fwpkg_version, which sends FWUpload request to pull FW package version from FW Image Header. Now driver prints FW package version in addition to FW version if the PackageVersion is valid. Signed-off-by: Chaitra P B Signed-off-by:

[PATCH v2 05/14] mpt3sas: Enhanced handling of Sense Buffer.

Enhanced DMA allocation for Sense Buffer, if the allocation does not fit within same 4GB.Introduced is_MSB_are_same function to check if allocted buffer within 4GB range or not. Signed-off-by: Chaitra P B Signed-off-by: Suganath Prabu S

[PATCH v2 13/14] mpt3sas: fix possible memory leak.

In ioctl exit path driver refers ioc_list to free memory associated with diag buffers and event_log pointer used to save events by driver. If ctl_exit() func is called after unregistering driver, then ioc_list will be empty and hence driver will not be able to free the allocated memory which in

[PATCH v2 12/14] mpt3sas: For NVME device, issue a protocol level reset instead of hot reset and use TM timeout value exposed in PCIe Device Page 2.

1)Manufacturing Page 11 contains parameters to control internal firmware behavior. Based on AddlFlags2 field FW/Driver behaviour can be changed, (flag tm_custom_handling is used for this) a) For PCIe device, protocol level reset should be used if flag tm_custom_handling is 0. Since Abort Task

[PATCH v2 04/14] mpt3sas: Optimize I/O memory consumption in driver.

For every IO, memory of PAGE size is allocated for handling NVMe native PRPS. And in addition to that for every IO (chains need per IO * chain buffer size, e.g. 38 * 128byte) amount of memory is allocated for chain buffers. However, at any point of time; the IO request can be for NVMe target

[PATCH v2 09/14] mpt3sas: Cache enclosure pages during enclosure add.

In function _scsih_add_device, for each device connected to an enclosure, driver reads the enclosure page(To get details like enclosure handle, enclosure logical ID, enclosure level etc.) With this patch, instead of reading enclosure page everytime, driver maintains a list for enclosure

[PATCH v2 07/14] mpt3sas: Increase event log buffer to support 24 port HBA's.

For 24 port HBA's events generated by IOC are more in certain cases and the current circular buffer may be overwritten.Hence increased the event log buffer to accommodate more events. Signed-off-by: Chaitra P B Signed-off-by: Suganath Prabu S

Re: [PATCH v7] scsi: new zorro_esp.c for Amiga Zorro NCR53C9x boards

Hi Christoph, On Mon, Apr 9, 2018 at 9:50 AM, Christoph Hellwig wrote: > On Sun, Apr 08, 2018 at 02:45:32PM +1200, Michael Schmitz wrote: >> --- /dev/null >> +++ b/drivers/scsi/zorro_esp.c >> + .driver_data = (unsigned long)_data, > > What most (or at least many)

Re: usercopy whitelist woe in scsi_sense_cache

I really can't make sense of that report. And I'm also curious why you think 17cb960f29c2 should change anything for that code path.

Re: [PATCHv2] target: prefer dbroot of /etc/target over /var/target

This looks reasonable to me: Reviewed-by: Christoph Hellwig

Re: Multi-Actuator SAS HDD First Look

On Fri, Apr 06, 2018 at 01:09:08PM -0400, Douglas Gilbert wrote: > So you found a document that outlines NVMe's architecture! Could you > share the url (no marketing BS, please)? You can always take a look at the actual spec:

Re: 答复: Re: 答复: Re: [PATCH v2] scsi: Introduce sdev_printk_ratelimited tothrottlefrequent printk

On Mon 2018-04-09 10:13:43, wen.yan...@zte.com.cn wrote: > That's a good idea, but it only solves part of the problem. > loopping printks under spinlock, there's two path: > one path is: > scsi_request_fn --> loop -> blk_peek_request-> scsi_prep_fn -> > scsi_prep_state_check -> sdev_printk

RE: [PATCH v1 03/15] mpt3sas: Add sanity checks for scsi tracker before accessing it.

Bart, We will work on this patch and submit. As of now reposting all the patches of this series except this patch. Thanks, Chaitra -Original Message- From: Bart Van Assche [mailto:bart.vanass...@wdc.com] Sent: Friday, April 6, 2018 8:59 PM To: chaitra.basa...@broadcom.com;

Re: [PATCH 11/14] lpfc: Fix NULL pointer reference when resetting adapter

On Sat, 7 Apr 2018 11:30:23 -0700 James Smart wrote: > Points referencing local port structures didn't accommodate cases > where the localport may not be registered yet. > > Add NULL pointer checks to logic. > > Signed-off-by: Dick Kennedy >

Re: [PATCH 12/14] lpfc: Fix create_association oops on unloading LPFC driver

On Sat, 7 Apr 2018 11:30:24 -0700 James Smart wrote: > Driver unload isn't waiting for all outstanding nvme associations > to terminate before clearing structures. In particular, it did not > set dev_loss_tmo to 0 such that all associations are immediately > terminated.

Re: [PATCH 14/14] lpfc: update driver version to 12.0.0.2

On Sat, 7 Apr 2018 11:30:26 -0700 James Smart wrote: > Update the driver version to 12.0.0.2 > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc_version.h | 2 +- > 1 file

Re: [PATCH 13/14] lpfc: Correct missing remoteport registration during link bounces

On Sat, 7 Apr 2018 11:30:25 -0700 James Smart wrote: > Remote port disappearance/reappearances would cause a series of RSCN > events to be delivered to the driver. During the resulting GID_FT > handling, the driver clears the fc4 settings on the remote port, which > makes

Re: [PATCH 10/14] lpfc: Fix nvme remoteport registration race conditions

On Sat, 7 Apr 2018 11:30:22 -0700 James Smart wrote: > On tests adding and removing a remote port, calls to nvme_info would > eventually show fewer target ports discovered than were present in > the san. Additionally, the following error messages were seen: > 6031

Re: [PATCH v7] scsi: new zorro_esp.c for Amiga Zorro NCR53C9x boards

On Sun, Apr 08, 2018 at 02:45:32PM +1200, Michael Schmitz wrote: > New combined SCSI driver for all ESP based Zorro SCSI boards for > m68k Amiga. > > Code largely based on board specific parts of the old drivers (blz1230.c, > blz2060.c, cyberstorm.c, cyberstormII.c, fastlane.c which were removed

Re: [PATCH 09/14] lpfc: Fix driver not recovering NVME rports during target link faults

On Sat, 7 Apr 2018 11:30:21 -0700 James Smart wrote: > During target-side port faults, the driver would not recover all > target port logins. This resulted in a loss of nvme device discovery. > > The driver is coded to wait for all GID_FT requests to complete > before

Re: [PATCH 08/14] lpfc: Fix WQ/CQ creation for older asic's.

On Sat, 7 Apr 2018 11:30:20 -0700 James Smart wrote: > The patch to enlarge WQ/CQ creation keys off of an adapter > response that indicates support for the larger values. Older > adapters return an incorrect response and are limited in size. > Thus the adapters fail the WQ

Re: [PATCH 07/14] lpfc: Fix NULL pointer access in lpfc_nvme_info_show

On Sat, 7 Apr 2018 11:30:19 -0700 James Smart wrote: > After making remoteport unregister requests, the ndlp nrport pointer > was stale. > > Track when waiting for waiting for unregister completion callback and > adjust nldp pointer assignment. Add a few safety checks

Re: [PATCH 05/14] lpfc: Fix Abort request WQ selection

On Sat, 7 Apr 2018 11:30:17 -0700 James Smart wrote: > When running loads that generated aborts, io errors where seen. > Turns out the abort requests where not placed on the proper > WQ resulting in the errors. Closer inspection inspection of this > error also showed

Re: [PATCH 06/14] lpfc: Fix lingering lpfc_wq resource after driver unload

On Sat, 7 Apr 2018 11:30:18 -0700 James Smart wrote: > After driver unloads lpfc_wq remains active. The destroy_workqueue > calls were not being made in driver unload. Additionally, SLI3 is > allocating lpfc_wq resources, but never uses it. > > Make the destroy_workqueue

Re: [PATCH 04/14] lpfc: Enlarge nvmet asynchronous receive buffer counts

On Sat, 7 Apr 2018 11:30:16 -0700 James Smart wrote: > Under large io load, the current sizing of asynchronous buffer counts > could be exceeded, indicated by a 2885 log message: > 2885 Port Status Event: port status reg 0x8180, port smphr > reg 0xc000, error

Re: [PATCH 03/14] lpfc: Add per io channel NVME IO statistics

On Sat, 7 Apr 2018 11:30:15 -0700 James Smart wrote: > When debugging various issues, per IO channel IO statistics were > useful to understand what was happening. However, many of the stats > were on a port basis rather than an io channel basis. > > Move statistics to an

Re: [PATCH 02/14] lpfc: Correct target queue depth application changes

On Sat, 7 Apr 2018 11:30:14 -0700 James Smart wrote: > The max_scsicmpl_time parameter can be used to perform scsi cmd queue > depth mgmt based on io completion time: the queue depth is reduced to > make completion time shorter. However, as soon as an io completes and >

Grüße von Frau Jordanka

Nachricht des Absenders: /Guten Morgen, Bitte schämen Sie sich nicht, diese Nachricht zu lesen, weil Sie der beabsichtigte Empfänger sind. Ich habe deine E-Mail-Adresse über ein Verzeichnis gesehen und ich habe dich kontaktiert, weil ich dringend deine Hilfe benötigt habe. Mein Name ist Frau