onstruct.
Thanks,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
this warning by switching to dev64_ul().
div64_ul() ^
Otherwise,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr.
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
The scsi_transport_sas.c part looks good, I have a nearly identical version
(different remove part due to missing patch 1 of your series). For the other
parts I can't tell.
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@su
ds
the definition of 'struct fc_ba_rjt' from scsi/fc/fc_fs.h) to the header
files included by qla_isr.c.
Fixes: 7401bc18d1ee ("scsi: qla2xxx: Add FC-NVMe command handling")
Signed-off-by: Johannes Thumshirn
---
drivers/scsi/qla2xxx/qla_isr.c | 2 ++
1 file changed, 2 insertio
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Thanks,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
_queues() so we can't accidently call it from the sq path?
Just an idea, no hard preferences here.
Byte,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr.
On Fri, Sep 01, 2017 at 08:33:40PM +0800, Ming Lei wrote:
> Given it is the only case that blk_mq_run_hw_queues() is run on
> !q->mq_ops now, I suggest to check q->mq_ops outside, otherwise
> it can be a bit overkill.
Fair enough,
Reviewed-by: Johannes Thumshirn
--
Joh
reported below [1], and
> should perhaps also be queued for -stable.
It seems to have slipped trough the cracks, can you please re-submit?
Thanks,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911
PATCH RESEND] should be OK
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fin
goto out_free_bsmbx;
Because as this patch shows there's always a chance to miss an 'rc = -EIO'.
Out of curiosity, do you know what's the value of rc in the failure case?
Anyways:
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn
#x27;rc = -EIO'.
> >
> > Out of curiosity, do you know what's the value of rc in the failure case?
>
> Yes, MBXERR_ERROR (mentioned in patch subject -- sorry, I could have
> repeated it in the message perhaps).
Ah ok I somehow missed it, sorry.
Byte,
Johanne
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
I guess it boils down to personal preference, but
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg
On Fri, Sep 08, 2017 at 01:16:29AM +0900, Damien Le Moal wrote:
> __blk_mq_debugfs_rq_show() and blk_mq_debugfs_rq_show() are exported
> symbols but ar eonly declared in the block internal file
are only
Otherwise this looks good to me,
Reviewed-by: Johannes Thumshirn
--
Jo
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
ing NUMA nodes into
account.
But that has nothing to do with your patch, just a general rant,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeld
On Fri, Sep 08, 2017 at 11:48:09AM +0200, Christoph Hellwig wrote:
> On Fri, Sep 08, 2017 at 10:39:25AM +0200, Johannes Thumshirn wrote:
> > It's a shame we have all this overflow checking kcalloc() and
> > kmalloc_array() functions but none of them is taking NUMA no
With an updates patch description (see Lee's mail)
Acked-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer,
Acked-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key
Acked-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key
tags by default".
Reduce can_queue to MAX_OUTSTANDING_COMMANDS (512) to solve the allocation
error.
Signed-off-by: Johannes Thumshirn
Fixes: 64d513ac31b - "scsi: use host wide tags by default"
Cc: sta...@vger.kernel.org # v4.4
Cc: Laura Abbott
Cc: Michael Reed
Reviewed-by: Laurence Ob
a Aditya Renukunta
>
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
H
On Mon, Apr 25, 2016 at 11:31:03PM -0700, Raghava Aditya Renukunta wrote:
> Suggested-by: Seymour, Shane M
> Signed-off-by: Raghava Aditya Renukunta
>
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh..
On Mon, Apr 25, 2016 at 11:31:43PM -0700, Raghava Aditya Renukunta wrote:
> As the firmware for series 6, 7, 8 cards does not support msi, remove it
> in the driver
>
> Signed-off-by: Raghava Aditya Renukunta
>
Reviewed-by: Johannes Thumshirn
--
Joh
the user.
>
> Signed-off-by: Raghava Aditya Renukunta
>
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörf
ot;));
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Johannes Thumshirn
nfo(&dev->pdev->dev, "Changed firmware to INTX mode");
> + }
> +
> if ((!aac_adapter_sync_cmd(dev, GET_ADAPTER_PROPERTIES,
> 0, 0, 0, 0, 0, 0,
> status+0, status+1, status+2, status+3, NULL)) &&
>
> --
> T
On Mon, Apr 25, 2016 at 11:32:44PM -0700, Raghava Aditya Renukunta wrote:
> Signed-off-by: Raghava Aditya Renukunta
>
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 740
quot; (which is
> responsible for completing the command from being timed out) from
> starting because it could not get the CPU.
>
> Fixed by replacing "cpu_relax()" call with "schedule()"
> Cc: sta...@vger.kernel.org
>
> Signed-off-by: R
Fixed by: Adding another kthread_should_stop() before schedule_timeout()
> Cc: sta...@vger.kernel.org
>
> Signed-off-by: Raghava Aditya Renukunta
>
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de
hat was why
> I used info,
> It should not impact the flow of the driver.
OK, I'm fine with the explanation
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE
On Wed, Apr 27, 2016 at 04:49:50PM +, Raghava Aditya Renukunta wrote:
> Hello Johannes,
>
> > -Original Message-
> > From: Johannes Thumshirn [mailto:jthmsh...@suse.de]
> > Sent: Wednesday, April 27, 2016 2:30 AM
> > To: Raghava Aditya Renukunta
> >
cared" messages and the driver to hang.
>
> This patch enables interrupts before the call to scsi_scan_host.
>
> Reported-by: Piotr Karbowski
> Reviewed-by: Scott Teel
> Reviewed-by: Kevin Barnett
> Signed-off-by: Don Brace
Reviewed-b
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fing
On Wed, Apr 27, 2016 at 05:13:51PM -0500, Don Brace wrote:
> faulty drives can cause the driver to hang during a
> scan operation.
>
> Reviewed-by: Scott Teel
> Reviewed-by: Kevin Barnett
> Signed-off-by: Don Brace
Reviewed-by: Johannes Thumshirn
--
On Wed, Apr 27, 2016 at 05:13:59PM -0500, Don Brace wrote:
> offload_to_be_enabled also needs to be set to 0 during a state
> change.
>
> Reviewed-by: Scott Teel
> Reviewed-by: Kevin Barnett
> Signed-off-by: Don Brace
Reviewed-by: Johannes Thumshirn
--
wed-by: Kevin Barnett
> Signed-off-by: Don Brace
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane
t Teel
> Reviewed-by: Kevin Barnett
> Signed-off-by: Don Brace
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix
On Wed, Apr 27, 2016 at 05:14:26PM -0500, Don Brace wrote:
> Reviewed-by: Gerry Morong
> Signed-off-by: Don Brace
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 68
r details cf https://lkml.org/lkml/2015/2/11/245
>
> Signed-off-by: Hannes Reinecke
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5,
king for blk_rq_bytes(req) == 0 && error in
scsi_end_request()?
>
> /*
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majo
On Fri, May 20, 2016 at 08:56:14AM -0400, Ewan D. Milne wrote:
> From: "Ewan D. Milne"
>
> A spinlock is sufficient for this purpose, and much smaller.
>
> Signed-off-by: Ewan D. Milne
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn
on Sep 17 00:00:00 2001
From: Johannes Thumshirn
Date: Tue, 24 May 2016 17:25:59 +0200
Subject: [RFC PATCH] mpt3sas: Don't do atomic memory allocations for firmware
update DMA
Currently mpt3sas uses pci_alloc_consistent() to allocate memory for the DMA
used to do firmware updates. pci_alloc_con
> Signed-off-by: Maurizio Lombardi
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Gra
oughly , as I don’t see allocation of
> several non-contiguous chunks of memory in below patch...,
The question here is if it would be possible to replace the kmalloc()
call with a vmalloc() (which is non-contiguous) and then pass the allocated
memory to a sg list?
Thanks,
Johann
Now that we do have pci_request_mem_regions() and pci_release_mem_regions() at
hand, use it in the lpfc driver.
Suggested-by: Christoph Hellwig
Signed-off-by: Johannes Thumshirn
Cc: James Smart
Cc: Dick Kennedy
Cc: "James E.J. Bottomley"
Cc: "Martin K. Petersen&q
(pdev);
Johannes Thumshirn (5):
PCI: Add helpers to request/release memory and I/O regions
NVMe: Use pci_(request|release)_mem_regions
scsi: Use pci_(request|release)_mem_regions
GenWQE: Use pci_(request|release)_mem_regions
ethernet: Use pci_(request|release)_mem_regions
drivers/misc/g
:00/00:00:00:00:00/a0 Emask 0x2 (HSM violation)
> [4.646685] ata2.00: status: { DRDY DRQ }
> [4.648193] ata2: soft resetting link
>
> ...
>
> Fix this by suppressing VPD inquiry for this device.
>
> Reported-by: Jan Stancek
> Tested-by: Jan Stance
On Wed, Jun 01, 2016 at 12:59:29AM -0700, Christoph Hellwig wrote:
> On Tue, May 31, 2016 at 02:05:11PM +0200, Johannes Thumshirn wrote:
> > Now that we do have pci_request_mem_regions() and pci_release_mem_regions()
> > at
> > hand, use it in the lpfc driver.
>
> Th
Now that we do have pci_request_mem_regions() and pci_release_mem_regions() at
hand, use it in the lpfc driver.
Suggested-by: Christoph Hellwig
Signed-off-by: Johannes Thumshirn
Cc: James Smart
Cc: Dick Kennedy
Cc: "James E.J. Bottomley"
Cc: "Martin K. Petersen&q
(pdev);
Changes since v1:
* Fixed indendatoin in pci.h patch to not cross the 80 chars boundary.
* Split Ethernet patches into two, one for Atheros and one for Intel drivers.
* Correctly named lpfc patch.
* Converted init-path of lpfc driver as well.
* Added Reviewed-by tags were appropriate.
Joh
On Thu, Jun 02, 2016 at 07:57:43AM -0400, Dick Kennedy wrote:
> Thanks Johannes, it looks good.
Hi Dick,
Can I use this as an Acked-by in the next submission?
Thanks,
Johannes
>
> On Thu, Jun 2, 2016 at 3:30 AM, Johannes Thumshirn
> wrote:
>
> >
Now that we do have pci_request_mem_regions() and pci_release_mem_regions() at
hand, use it in the lpfc driver.
Suggested-by: Christoph Hellwig
Signed-off-by: Johannes Thumshirn
Acked-by: Dick Kennedy
Cc: James Smart
Cc: Dick Kennedy
Cc: "James E.J. Bottomley"
Cc: "Martin K
atches into two, one for Atheros and one for Intel drivers.
* Correctly named lpfc patch.
* Converted init-path of lpfc driver as well.
* Added Reviewed-by tags were appropriate.
Johannes Thumshirn (6):
PCI: Add helpers to request/release memory and I/O regions
NVMe: Use pci_(request|release)_mem
On Tue, Jun 07, 2016 at 09:44:00AM +0200, Johannes Thumshirn wrote:
> The first patch in this series introduces the following 4 helper functions to
> the PCI core:
>
> * pci_request_mem_regions()
> * pci_request_io_regions()
> * pci_release_mem_regions()
> * pci_release_io
Bottomley"
> Cc: "Martin K. Petersen"
> Cc: Christoph Hellwig
> Cc: fcoe-de...@open-fcoe.org
> Cc: linux-scsi@vger.kernel.org
> Signed-off-by: Sebastian Andrzej Siewior
Tested in a Boot from FCoE scenario using a BCM57840.
Tested-by: Johannes Thumshirn
Reviewed
uffices to fix this problem globally.
>
> Fixes: 64d513ac31b - "scsi: use host wide tags by default"
> Cc: sta...@vger.kernel.org# 4.4+
> Reported-by: Helge Deller
> Tested-by: Helge Deller
> Signed-off-by: James Bottomley
R
#x27; when removing the
> structure, and avoids the above race condition.
>
> Signed-off-by: Hannes Reinecke
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SU
.
>
> We may need to test below patch thoroughly , as I don’t see allocation of
> several non-contiguous chunks of memory in below patch...,
>
Any results? What about my quest whether we can allocate the buffers by
vmalloc() and then map it in a SG list
Check for the existance of pciob->vport before accessing it.
Signed-off-by: Johannes Thumshirn
---
drivers/scsi/lpfc/lpfc_sli.c | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
index 70edf21..1340
x27;t clutter up build logs with this. Using a
> separate inline function for it makes it clear to the compiler
> that the comparison is necessary in the caller but still lets
> it do the constant-folding.
>
> Signed-off-by: Arnd Bergmann
Reviewed-by: Johannes Thumshirn
--
Johan
ove readability here.
something like
static void pqi_complete_queue_group(struct pqi_queue_group *qg, struct
pqi_device_t *device_in_reset)
{
unsigned int path;
unsigned long flags;
struct qpi_scsi_dev_t *dev;
struct pqi_io_request *ior, *next;
7;s CPU change,
* then set it here.
*/
rsp->msix->cpuid = smp_processor_id();
ha->tgt.rspq_vector_cpuid = rsp->msix->cpuid;
--
Johannes Thumshirn Storage
jth
Vasu is going to resign from his maintainer role and I'll take over.
Signed-off-by: Johannes Thumshirn
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index e1b090f..70af8c0 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -4
If there is a dma mapping error snic kfree()s buf right before printing it.
Change the order to not accidently trip on memory that's not owned by us
anymore.
Signed-off-by: Johannes Thumshirn
---
drivers/scsi/snic/snic_disc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
device = scmnd->device->hostdata;
> > if (dev == device_in_reset) {
> > set_host_byte(scmnd, DID_RESET);
> > pqi_scsi_done(scmnd);
> > li
r(mp->pool, cpu);
> spin_lock_bh(&pool->lock);
> ep = fc_exch_ptr_get(pool, (xid - mp->min_xid) >> fc_cpu_order);
> if (ep) {
Acked-by: Johannes Thumshirn
@Martin, do you queue the libfc patches as well?
--
Johannes Thumshirn
me->mac.fd_mac, fip->ctl_src_addr, ETH_ALEN);
> +
> + frame->vlan.fd_desc.fip_dtype = FIP_DT_VLAN;
> + frame->vlan.fd_desc.fip_dlen = sizeof(frame->vlan) / FIP_BPW;
> + put_unaligned_be16(fip->lp->vlan, &frame->vlan.fd_vlan);
> +
&g
On Mon, Jul 04, 2016 at 10:29:18AM +0200, Hannes Reinecke wrote:
> Update to latest FC-BB-6 draft to include FIP VN2VN VLAN notifications
> and additional flags.
>
> Signed-off-by: Hannes Reinecke
Acked-by: Johannes Thumshirn
--
Johann
On Mon, Jul 04, 2016 at 10:29:19AM +0200, Hannes Reinecke wrote:
> The FIP mode is independent on the FIP state machine, so use a
> separate enum for that instead of overloading it with state
> machine values.
>
> Signed-off-by: Hannes Reinecke
Acked-by: Johannes Thumshirn
On Mon, Jul 04, 2016 at 10:29:20AM +0200, Hannes Reinecke wrote:
> '->realdev' is always set, so this check is pointless.
>
> Signed-off-by: Hannes Reinecke
Acked-by: Johannes Thumshirn
--
Johannes Thumshirn Stor
On Mon, Jul 04, 2016 at 10:29:21AM +0200, Hannes Reinecke wrote:
> When the FIP mode is changed we need to update the multicast
> addresses to ensure we get the correct frames.
>
> Signed-off-by: Hannes Reinecke
Acked-by: Johannes Thumshirn
--
Johann
l of the duplicate fip_frame struct defition:
Acked-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard,
On Tue, Jun 28, 2016 at 01:28:19PM -0700, Tyrel Datwyler wrote:
> On 06/15/2016 06:00 AM, Johannes Thumshirn wrote:
> > Check for the existance of pciob->vport before accessing it.
>
> piocb mispelled.
Oops
>
> >
> > Signed-off-by: Johannes Thumshirn
> >
ed ISP2432
> (0x2, 0x3).
> [3.485804] qla2xxx [:13:00.0]-0037:0: Falling back-to MSI mode -258.
> [3.890145] scsi host0: qla2xxx
> [3.891956] qla2xxx [:13:00.0]-00fb:0: QLogic QLE2460 - PCI-Express
> Single Channel 4Gb Fibre Channel HBA.
> [3.894207] qla2xxx [0
six field. A possible case for such a race would be in the kdump
case when the HBA's IRQs are still enabled but the driver is undergoing
a new initialisation and thus is not aware of already activated IRQs in
the HBA.
Signed-off-by: Johannes Thumshirn
---
drivers/scsi/qla2xxx/qla_isr.c | 8 +++
Use defines from ethtool for 20Gbit and 40Gbit speeds instead of magic
numbers.
Signed-off-by: Johannes Thumshirn
---
drivers/scsi/fcoe/fcoe_transport.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/fcoe/fcoe_transport.c
b/drivers/scsi/fcoe
901 - 1000 of 1576 matches
Mail list logo
