EHCI: read status register is very slow in ehci_irq

2013-06-07 Thread Ming Lei
Hi, I found on my machine(lenovo T410), most of time only reading the status register in the entry of ehci_irq may take 2~4 microseconds, and sometimes it is extremely slow and the read can consume > 100 microseconds. I measure the time by adding two trace events around the below line in entry of

Re: [RFC v2] xhci: fix dma mask setup in xhci.c

2013-06-07 Thread Felipe Balbi
Hi, On Fri, Jun 07, 2013 at 10:19:23AM -0700, Sarah Sharp wrote: > Adding Felipe. > > Xenia, Felipe is the USB "gadget" maintainer, and also added code for > non-PCI xHCI hosts. Felipe, Xenia is my summer intern through the FOSS > Outreach Program for Women: http://kernelnewbies.org/OPWIntro He

Re: [RFC 00/50] ARM: at91: move to common clk framework

2013-06-07 Thread boris brezillon
On 07/06/2013 12:14, Gregory CLEMENT wrote: On 06/07/2013 11:32 AM, boris brezillon wrote: On 07/06/2013 11:22, Nicolas Ferre wrote: On 07/06/2013 10:34, Boris BREZILLON : Hello, This patch series is a proposal to move at91 clock implementation to common clk framework. Before discussion begi

Re: [RFC][PATCH 7/7] USB: OHCI: make ohci-s3c2410 a separate driver

2013-06-07 Thread Alan Stern
On Fri, 7 Jun 2013, Manjunath Goudar wrote: > Separate the Samsung OHCI S3C host controller driver from ohci-hcd > host code so that it can be built as a separate driver module. > This work is part of enabling multi-platform kernels on ARM. > @@ -371,10 +384,9 @@ static int usb_hcd_s3c2410_pr

Re: [PATCH] USB: serial/ftdi_sio.c Fix kernel oops

2013-06-07 Thread Willy Tarreau
On Fri, Jun 07, 2013 at 10:30:09AM -0700, Greg Kroah-Hartman wrote: > On Fri, Jun 07, 2013 at 03:14:32PM +0200, Lotfi Manseur wrote: > > Handle null termios in ftdi_set_termios(), introduced in > > commit 552f6bf1bb0eda0011c0525dd587aa9e7ba5b846 > > This has been corrected in the mainline by > > co

Re: [RFC][PATCH 6/7] USB: OHCI: make ohci-at91 a separate driver

2013-06-07 Thread Alan Stern
On Fri, 7 Jun 2013, Manjunath Goudar wrote: > Separate the TI OHCI Atmel host controller driver from ohci-hcd > host code so that it can be built as a separate driver module. > This work is part of enabling multi-platform kernels on ARM. > --- a/drivers/usb/host/Kconfig > +++ b/drivers/usb/host/

[PATCH v2] USB: cdc-acm: remove unneeded spin_lock_irqsave/restore on write path

2013-06-07 Thread Greg Kroah-Hartman
From: Greg Kroah-Hartman When writing data we were: lock do some work unlock call function lock do some work unlock return return It turns out, that "function" was only ever called in the one

Re: [RFC][PATCH 5/7] USB: OHCI: export ohci_hub_control and ohci_hub_status_data

2013-06-07 Thread Alan Stern
On Fri, 7 Jun 2013, Manjunath Goudar wrote: > In order to make ohci-at91 and ohci-s3c2410 as a separate driver, > ohci_hub_control and ohci_hub_status_data symbol needs to be exported. > This work is part of enabling multi-platform kernels on ARM. No, we are not going to export those two routines

Re: [PATCH] USB: cdc-acm: remove unneeded spin_lock_irqsave/restore on write path

2013-06-07 Thread Greg Kroah-Hartman
On Fri, Jun 07, 2013 at 10:38:30PM +0400, Sergei Shtylyov wrote: > Hello. > > On 06/07/2013 10:32 PM, Greg Kroah-Hartman wrote: > > >From: Greg Kroah-Hartman > > > >When writing data we were: > > lock > > do some work > > unlock > > call function > > lock > >

Re: [PATCH] USB: cdc-acm: remove unneeded spin_lock_irqsave/restore on write path

2013-06-07 Thread Sergei Shtylyov
Hello. On 06/07/2013 10:32 PM, Greg Kroah-Hartman wrote: From: Greg Kroah-Hartman When writing data we were: lock do some work unlock call function lock do some work unlock return return I

Re: [RFC][PATCH 4/7] USB: OHCI: make ohci-spear a separate driver

2013-06-07 Thread Alan Stern
On Fri, 7 Jun 2013, Manjunath Goudar wrote: > Separate the TI OHCI SPEAr host controller driver from ohci-hcd > host code so that it can be built as a separate driver module. > This work is part of enabling multi-platform kernels on ARM. > @@ -151,16 +98,24 @@ static int spear_ohci_hcd_drv_probe

[PATCH] USB: cdc-acm: remove unneeded spin_lock_irqsave/restore on write path

2013-06-07 Thread Greg Kroah-Hartman
From: Greg Kroah-Hartman When writing data we were: lock do some work unlock call function lock do some work unlock return return It turns out, that "function" was only ever called in the one

[RFC PATCH 33/50] ehci-atmel.c: prepare clk before calling enable

2013-06-07 Thread Boris BREZILLON
Replace clk_enable/disable with clk_prepare_enable/disable_unprepare to avoid common clk framework warnings. Signed-off-by: Boris BREZILLON --- drivers/usb/host/ehci-atmel.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/usb/host/ehci-atmel.c b/drivers/usb

[RFC PATCH 34/50] USB: ohci-at91: prepare clk before calling enable

2013-06-07 Thread Boris BREZILLON
Replace clk_enable/disable with clk_prepare_enable/disable_unprepare to avoid common clk framework warnings. Signed-off-by: Boris BREZILLON --- drivers/usb/host/ohci-at91.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/usb/host/ohci-at91.c b/drivers/u

[RFC PATCH 32/50] usb: gadget: at91_udc: prepare clk before calling enable

2013-06-07 Thread Boris BREZILLON
Replace clk_enable/disable with clk_prepare_enable/disable_unprepare to avoid common clk framework warnings. Signed-off-by: Boris BREZILLON --- drivers/usb/gadget/at91_udc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/usb/gadget/at91_udc.c b/drivers

[PATCH v3 2/3] USB: serial: make minor allocation dynamic

2013-06-07 Thread Greg KH
From: Greg Kroah-Hartman This moves the allocation of minor device numbers from a static array to be dynamic, using the idr interface. This means that you could potentially get "gaps" in a minor number range for a single USB serial device with multiple ports, but all should still work properly.

Re: [PATCH v2 2/3] USB: serial: make minor allocation dynamic

2013-06-07 Thread Greg KH
On Fri, Jun 07, 2013 at 11:40:25AM +0200, Johan Hovold wrote: > On Thu, Jun 06, 2013 at 10:31:21AM -0700, Greg KH wrote: > > From: Greg Kroah-Hartman > > [...] > > > --- a/drivers/usb/serial/usb-serial.c > > +++ b/drivers/usb/serial/usb-serial.c > > @@ -37,6 +37,7 @@ > > #include > > #include

Re: [RFC][PATCH 3/7] USB: OHCI: make ohci-omap3 a separate driver

2013-06-07 Thread Alan Stern
On Fri, 7 Jun 2013, Manjunath Goudar wrote: > Separate the TI OHCI OMAP3 host controller driver from ohci-hcd > host code so that it can be built as a separate driver module. > This work is part of enabling multi-platform kernels on ARM. > @@ -185,7 +118,16 @@ static int ohci_hcd_omap3_probe(str

Re: [RFC][PATCH 2/7] USB: OHCI: make ohci-omap a separate driver

2013-06-07 Thread Alan Stern
On Fri, 7 Jun 2013, Manjunath Goudar wrote: > Separate the TI OHCI OMAP1/2 host controller driver from ohci-hcd > host code so that it can be built as a separate driver module. > This work is part of enabling multi-platform kernels on ARM. > @@ -71,6 +77,10 @@ static struct clk *usb_dc_ck; > st

Re: [PATCH] USB: serial/ftdi_sio.c Fix kernel oops

2013-06-07 Thread Greg Kroah-Hartman
On Fri, Jun 07, 2013 at 03:14:32PM +0200, Lotfi Manseur wrote: > Handle null termios in ftdi_set_termios(), introduced in > commit 552f6bf1bb0eda0011c0525dd587aa9e7ba5b846 > This has been corrected in the mainline by > commits c515598e0f5769916c31c00392cc2bfe6af74e55 and > a816e3113b63753c330ca4751

Re: [PATCH v2 0/3] Increase the number of USB to serial devices we can support at once

2013-06-07 Thread Greg KH
On Fri, Jun 07, 2013 at 11:55:59AM +0200, Tobias Winter wrote: > On 06/07/2013 08:00 AM, Tobias Winter wrote: > > CC drivers/usb/serial/console.o > > drivers/usb/serial/console.c: In function ‘usb_console_setup’: > > drivers/usb/serial/console.c:111:2: error: implicit declaration of > > func

Re: [PATCH v2 2/3] USB: serial: make minor allocation dynamic

2013-06-07 Thread Greg KH
On Fri, Jun 07, 2013 at 12:00:47PM +0200, Johan Hovold wrote: > On Thu, Jun 06, 2013 at 10:31:21AM -0700, Greg KH wrote: > > From: Greg Kroah-Hartman > > > @@ -1040,11 +1044,10 @@ static int usb_serial_probe(struct usb_i > > */ > > serial->disconnected = 1; > > > > - if (get_free_ser

Re: [RFC][PATCH 1/7] USB: OHCI: make ohci-exynos a separate driver

2013-06-07 Thread Alan Stern
On Fri, 7 Jun 2013, Manjunath Goudar wrote: > Separate the Samsung OHCI EXYNOS host controller driver from ohci-hcd > host code so that it can be built as a separate driver module. > This work is part of enabling multi-platform kernels on ARM. > -static void exynos_ohci_phy_enable(struct exynos_

Re: [RFC v2] xhci: fix dma mask setup in xhci.c

2013-06-07 Thread Sarah Sharp
Adding Felipe. Xenia, Felipe is the USB "gadget" maintainer, and also added code for non-PCI xHCI hosts. Felipe, Xenia is my summer intern through the FOSS Outreach Program for Women: http://kernelnewbies.org/OPWIntro Felipe, we're discussing the fact that the xHCI host currently does not set up

[RESEND RFC PATCH 00/50] ARM: at91: move to common clk framework

2013-06-07 Thread Boris BREZILLON
Hello, Sorry for the noise, the first submission has been filtered. This patch series is a proposal to move at91 clock implementation to common clk framework. Most of the clock provided by the PMC (Power Management Controller) are implemented : - main clock (main oscillator) - pll clocks - maste

[RFC PATCH 01/50] ARM: at91: move at91_pmc.h to include/linux/clk/at91.h

2013-06-07 Thread Boris BREZILLON
This patch moves at91_pmc.h header from machine specific directory (arch/arm/mach-at91/include/mach/at91_pmc.h) to clk include directory (include/linux/clk/at91.h). We need this to avoid reference to machine specific headers in clk drivers. Signed-off-by: Boris BREZILLON --- arch/arm/mach-at91

Re: usbutils 006 release

2013-06-07 Thread Alan Stern
On Thu, 6 Jun 2013, Greg KH wrote: > On Mon, Jul 09, 2012 at 11:22:22AM -0400, Alan Stern wrote: > > On Fri, 6 Jul 2012, Greg KH wrote: > > > > > Here's the 006 release of usbutils. > > > > > > Some USB 3.0 updates, a new usb.ids file update, and a number of other > > > fixes and updates for ann

Re: Linux USB file storage gadget with new UDC

2013-06-07 Thread Alan Stern
On Fri, 7 Jun 2013, victor yeo wrote: > The hardware handles Set Address request, and i can see the address of > the USB gadget being shown in Windows host. Here i attach the gadget > driver log for the "Device Descriptor Test - Addressed State". The > test just failed after Get Configuration requ

Re: [PATCH] USB: serial/ftdi_sio.c Fix kernel oops

2013-06-07 Thread Sergei Shtylyov
Hello. On 06/07/2013 05:14 PM, Lotfi Manseur wrote: Handle null termios in ftdi_set_termios(), introduced in commit 552f6bf1bb0eda0011c0525dd587aa9e7ba5b846 This has been corrected in the mainline by commits c515598e0f5769916c31c00392cc2bfe6af74e55 and a816e3113b63753c330ca4751ea1d208e93e3015.

Re: [RFC][PATCH 7/7] USB: OHCI: make ohci-s3c2410 a separate driver

2013-06-07 Thread Arnd Bergmann
On Friday 07 June 2013 11:33:33 Manjunath Goudar wrote: > > + ohci_setup(hcd); > s3c2410_start_hc(dev, hcd); > > - ohci_hcd_init(hcd_to_ohci(hcd)); > - I'm not sure about this part: s3c2410_start_hc is where the clock gets enabled, presumable we are not supposed to touch the

Re: [RFC][PATCH 3/7] USB: OHCI: make ohci-omap3 a separate driver

2013-06-07 Thread Arnd Bergmann
On Friday 07 June 2013 11:33:29 Manjunath Goudar wrote: > + /* > + * RemoteWakeupConnected has to be set explicitly before > + * calling ohci_run. The reset value of RWC is 0. > + */ Just nitpicking, but you still use the wrong commenting style occasionally. The '*' charact

Re: [RFC][PATCH 1/7] USB: OHCI: make ohci-exynos a separate driver

2013-06-07 Thread Arnd Bergmann
On Friday 07 June 2013 11:33:27 Manjunath Goudar wrote: > > #if!IS_ENABLED(CONFIG_USB_OHCI_HCD_PCI) && \ > !IS_ENABLED(CONFIG_USB_OHCI_HCD_PLATFORM) && \ > + !IS_ENABLED(CONFIG_USB_OHCI_EXYNOS) && \ > !defined(PLATFORM_DRIVER) &&\ > !defined(OMAP1_PLATFORM_DR

Re: [PATCH] USB: serial/ftdi_sio.c Fix kernel oops

2013-06-07 Thread Willy Tarreau
On Fri, Jun 07, 2013 at 03:14:32PM +0200, Lotfi Manseur wrote: > Handle null termios in ftdi_set_termios(), introduced in > commit 552f6bf1bb0eda0011c0525dd587aa9e7ba5b846 > This has been corrected in the mainline by > commits c515598e0f5769916c31c00392cc2bfe6af74e55 and > a816e3113b63753c330ca4751

[PATCH] USB: serial/ftdi_sio.c Fix kernel oops

2013-06-07 Thread Lotfi Manseur
Handle null termios in ftdi_set_termios(), introduced in commit 552f6bf1bb0eda0011c0525dd587aa9e7ba5b846 This has been corrected in the mainline by commits c515598e0f5769916c31c00392cc2bfe6af74e55 and a816e3113b63753c330ca4751ea1d208e93e3015. This is to be fixed in longterm 2.6.32.60 and 3.4.47. T

Re: [RFC 00/50] ARM: at91: move to common clk framework

2013-06-07 Thread boris brezillon
On 07/06/2013 11:22, Nicolas Ferre wrote: On 07/06/2013 10:34, Boris BREZILLON : Hello, This patch series is a proposal to move at91 clock implementation to common clk framework. Before discussion begins I would like to give my kudos to you Boris! This is huge work and I thank you for it: It

Re: [RFC v2] xhci: fix dma mask setup in xhci.c

2013-06-07 Thread Mathias Nyman
On 06/07/2013 01:54 AM, Sarah Sharp wrote: On Thu, Jun 06, 2013 at 09:37:51PM +0300, Andy Shevchenko wrote: On Thu, Jun 6, 2013 at 5:21 PM, Xenia Ragiadakou wrote: This patch adds a check on whether the host machine supports the xHC DMA address mask and sets the DMA mask for coherent DMA addre

Re: [PATCH v8 0/9] Reorganize R8A7779/Marzen USB code

2013-06-07 Thread Sergei Shtylyov
Hello. On 07-06-2013 12:06, Simon Horman wrote: Here's the set of 9 patches against the Simon Horman's 'renesas.git' repo, 'renesas-next-20130528' tag. It was created to fix the shortcomings in the R8A7779/Marzen USB platform code and R8A7779 USB common PHY driver, and so spans both arch/a

Re: [RFC][PATCH 4/7] USB: OHCI: make ohci-spear a separate driver

2013-06-07 Thread Viresh Kumar
you need to cc spear-de...@list.st.com list for SPEAr patches. On 7 June 2013 11:33, Manjunath Goudar wrote: > Separate the TI OHCI SPEAr host controller driver from ohci-hcd TI ?? > host code so that it can be built as a separate driver module. > This work is part of enabling multi-platform k

Re: [RFC 00/50] ARM: at91: move to common clk framework

2013-06-07 Thread Gregory CLEMENT
On 06/07/2013 11:32 AM, boris brezillon wrote: > On 07/06/2013 11:22, Nicolas Ferre wrote: >> On 07/06/2013 10:34, Boris BREZILLON : >>> Hello, >>> >>> This patch series is a proposal to move at91 clock implementation >>> to common clk framework. >> >> Before discussion begins I would like to give

Re: [PATCH v2 2/3] USB: serial: make minor allocation dynamic

2013-06-07 Thread Johan Hovold
On Thu, Jun 06, 2013 at 10:31:21AM -0700, Greg KH wrote: > From: Greg Kroah-Hartman > @@ -1040,11 +1044,10 @@ static int usb_serial_probe(struct usb_i >*/ > serial->disconnected = 1; > > - if (get_free_serial(serial, num_ports, &minor) == NULL) { > + if (get_free_serial(se

Re: [PATCH v2 0/3] Increase the number of USB to serial devices we can support at once

2013-06-07 Thread Tobias Winter
On 06/07/2013 08:00 AM, Tobias Winter wrote: > CC drivers/usb/serial/console.o > drivers/usb/serial/console.c: In function ‘usb_console_setup’: > drivers/usb/serial/console.c:111:2: error: implicit declaration of > function ‘usb_serial_get_by_index’ [-Werror=implicit-function-declaration] >

Re: [PATCH v2 2/3] USB: serial: make minor allocation dynamic

2013-06-07 Thread Johan Hovold
On Fri, Jun 07, 2013 at 11:40:25AM +0200, Johan Hovold wrote: > On Thu, Jun 06, 2013 at 10:31:21AM -0700, Greg KH wrote: > > From: Greg Kroah-Hartman > > [...] > > > /* Functions needed by other parts of the usbserial core */ > > -extern struct usb_serial *usb_serial_get_by_index(unsigned int m

Re: [PATCH v2 2/3] USB: serial: make minor allocation dynamic

2013-06-07 Thread Johan Hovold
On Thu, Jun 06, 2013 at 10:31:21AM -0700, Greg KH wrote: > From: Greg Kroah-Hartman [...] > --- a/drivers/usb/serial/usb-serial.c > +++ b/drivers/usb/serial/usb-serial.c > @@ -37,6 +37,7 @@ > #include > #include > #include > +#include > #include "pl2303.h" > > #define DRIVER_AUTHOR "G

Re: Chipidea usb otg support for IMX/MXS (device functionality)

2013-06-07 Thread maxime.rip...@free-electrons.com
Hi Hector, On Thu, May 30, 2013 at 06:17:47PM +0200, Hector Palacios wrote: > Dear Maxime, > > On 05/29/2013 09:50 AM, maxime.rip...@free-electrons.com wrote: > >Hi, > > > >On Wed, May 29, 2013 at 07:11:30AM +, Chen Peter-B29397 wrote: > >> > >>>Hello, > >>> > >>>Am I right in assuming that t

Re: [RFC 00/50] ARM: at91: move to common clk framework

2013-06-07 Thread Nicolas Ferre
On 07/06/2013 10:34, Boris BREZILLON : Hello, This patch series is a proposal to move at91 clock implementation to common clk framework. Before discussion begins I would like to give my kudos to you Boris! This is huge work and I thank you for it: It is so great! I am sure that Jean-Christo

[RFC 01/50] ARM: at91: move arch/arm/mach-at91/include/mach/at91_pmc.h to include/linux/clk/at91.h

2013-06-07 Thread Boris BREZILLON
This patch moves at91_pmc.h header from machine specific directory (arch/arm/mach-at91/include/mach/at91_pmc.h) to clk include directory (include/linux/clk/at91.h). We need this to avoid reference to machine specific headers in clk drivers. Signed-off-by: Boris BREZILLON --- arch/arm/mach-at91

[RFC 00/50] ARM: at91: move to common clk framework

2013-06-07 Thread Boris BREZILLON
Hello, This patch series is a proposal to move at91 clock implementation to common clk framework. Most of the clock provided by the PMC (Power Management Controller) are implemented : - main clock (main oscillator) - pll clocks - master clock - programmable clocks - utmi clock - peripheral clocks

Re: Linux USB file storage gadget with new UDC

2013-06-07 Thread victor yeo
Hi, >> Thanks a lot. i understand this part now. Do you notice the Set >> Address request is not seen by the gadget driver? The Set Address >> request is handled by the hardware. Could it be the root cause? As >> gadget driver may expect the address information from the host, and >> for now UDC dr

Re: [PATCH v8 0/9] Reorganize R8A7779/Marzen USB code

2013-06-07 Thread Simon Horman
On Sun, Jun 02, 2013 at 01:28:05AM +0400, Sergei Shtylyov wrote: > Hello. > >Here's the set of 9 patches against the Simon Horman's 'renesas.git' repo, > 'renesas-next-20130528' tag. It was created to fix the shortcomings in the > R8A7779/Marzen USB platform code and R8A7779 USB common PHY dr

DWC3: Event Interrupt Mask issue

2013-06-07 Thread Huang Rui
Hi Felipe, I was reading dwc3 codes and found that during the process of configuring event buffer (dwc3_event_buffers_setup), it only write the size of the buffer and doesn't write interrupt mask bit into GEVNTSIZ register like below, dwc3_writel(dwc->regs, DWC3_GEVNTSIZ(n),