Re: [PATCH] phy-rcar-usb-gen2: add device tree support

2014-01-29 Thread Simon Horman
On Wed, Jan 29, 2014 at 04:26:55PM +0400, Sergei Shtylyov wrote: > Hello. > > On 29-01-2014 16:22, Simon Horman wrote: > > [snip] > > >>+static struct of_device_id rcar_gen2_usb_phy_ofmatch[] = { > >>+{ .compatible = "renesas,usb-phy-r8a7790", }, > >>+{ .compatible = "ren

Re: [PATCH] phy-rcar-usb-gen2: add device tree support

2014-01-29 Thread Sergei Shtylyov
Hello. On 29-01-2014 16:22, Simon Horman wrote: [snip] +static struct of_device_id rcar_gen2_usb_phy_ofmatch[] = { +{ .compatible = "renesas,usb-phy-r8a7790", }, +{ .compatible = "renesas,rcar-gen2-usb-phy", }, Frankly speaking, I don't understand the need for the clearly dupl

Re: [PATCH] phy-rcar-usb-gen2: add device tree support

2014-01-29 Thread Simon Horman
On Wed, Jan 29, 2014 at 02:41:58PM +0400, Sergei Shtylyov wrote: > Hello. > > On 29-01-2014 10:22, Simon Horman wrote: > > >>[snip] > > +static struct of_device_id rcar_gen2_usb_phy_ofmatch[] = { > +{ .compatible = "renesas,usb-phy-r8a7790", }, > +{ .compatible = "renesas,rca

Re: [PATCH] phy-rcar-usb-gen2: add device tree support

2014-01-29 Thread Sergei Shtylyov
Hello. On 29-01-2014 10:22, Simon Horman wrote: [snip] +static struct of_device_id rcar_gen2_usb_phy_ofmatch[] = { +{ .compatible = "renesas,usb-phy-r8a7790", }, +{ .compatible = "renesas,rcar-gen2-usb-phy", }, Frankly speaking, I don't understand the need for the clearly dupl

Re: [PATCH] phy-rcar-usb-gen2: add device tree support

2014-01-28 Thread Simon Horman
On Mon, Jan 27, 2014 at 07:06:26PM +, Ben Dooks wrote: > On 27/01/14 18:23, Sergei Shtylyov wrote: > >Hello. > > > >On 01/26/2014 08:05 PM, Ben Dooks wrote: > > [snip] > > >> > >>+static struct of_device_id rcar_gen2_usb_phy_ofmatch[] = { > >>+{ .compatible = "renesas,usb-phy-r8a7790", },

Re: [PATCH] phy-rcar-usb-gen2: add device tree support

2014-01-27 Thread Ben Dooks
On 27/01/14 18:23, Sergei Shtylyov wrote: Hello. On 01/26/2014 08:05 PM, Ben Dooks wrote: [snip] +static struct of_device_id rcar_gen2_usb_phy_ofmatch[] = { +{ .compatible = "renesas,usb-phy-r8a7790", }, +{ .compatible = "renesas,rcar-gen2-usb-phy", }, Frankly speaking, I don'

Re: [PATCH] phy-rcar-usb-gen2: add device tree support

2014-01-27 Thread Sergei Shtylyov
Hello. On 01/26/2014 08:05 PM, Ben Dooks wrote: Add support for the phy-rcar-gen2-usb driver to be probed from device tree. Signed-off-by: Ben Dooks Reviewed-by: Ian Molton --- Fixes from v2: - fix missing of_if patch (I clearly should not be let near git-rebase when hungry) Fix

Re: [PATCH] phy-rcar-usb-gen2: add device tree support

2014-01-27 Thread Felipe Balbi
Hi, On Sun, Jan 26, 2014 at 05:05:01PM +, Ben Dooks wrote: > Add support for the phy-rcar-gen2-usb driver to be probed from device tree. > > Signed-off-by: Ben Dooks > Reviewed-by: Ian Molton > --- > Fixes from v2: > - fix missing of_if patch > (I clearly should not be let near git-re

[PATCH] phy-rcar-usb-gen2: add device tree support

2014-01-26 Thread Ben Dooks
Add support for the phy-rcar-gen2-usb driver to be probed from device tree. Signed-off-by: Ben Dooks Reviewed-by: Ian Molton --- Fixes from v2: - fix missing of_if patch (I clearly should not be let near git-rebase when hungry) Fixes from v1: - use of_property_reasd-bool()