[Linuxptp-devel] [PATCH 1/1] Ensure TLV_PORT_STATS_NP statistics uses little endian.

2021-03-23 Thread Erez Geva
As machine byte order may vary. Ensure TLV_PORT_STATS_NP statistics use defined order. As most of us use little endian hardware and to retain backward compatible with most of us, we decide to use little endian for the statistics. All other TLVs messages remain in network order. Signed-off-by:

[Linuxptp-devel] [PATCH 0/1] Ensure TLV_PORT_STATS_NP statistics uses little end

2021-03-23 Thread Erez Geva
* Fourth round Sorry, somehow i forgot to compile it. (too many things in paraller). We use TLV_PORT_STATS_NP localy and over network. To prevent mismatch when the pmc and the ptp4l runs on mechine using different byte order. We change the statistics to little endian. We choose little endian

Re: [Linuxptp-devel] FYI: a summary scribble on my i210 SDP / PPS-in + 25 MHz ref etc sprees

2021-03-23 Thread Frantisek Rysanek
On 23 Mar 2021 at 10:05, Miroslav Lichvar wrote: > > That issue with oscillations around resolution of the clock, I think > you could try smaller PI constants, or you could switch to the nullf > servo, which is intended for cases like this. > Yes I've tried fiddling with the P and I contributions

Re: [Linuxptp-devel] Unable to have UNCALIBRAT to SLAVE transition

2021-03-23 Thread Richard Cochran
On Mon, Mar 15, 2021 at 12:38:58PM +0100, Luigi 'Comio' Mantellini wrote: > Inside port_synchronize() I noticed this: > > case SERVO_LOCKED: > port_dispatch(p, EV_MASTER_CLOCK_SELECTED, 0); > break; > case SERVO_LOCKED_STABLE: > message_interval_request(p, last_state, sync_interval);

Re: [Linuxptp-devel] [PATCH 1/1] Ensure TLV_PORT_STATS_NP statistics uses little endian.

2021-03-23 Thread Richard Cochran
On Mon, Mar 15, 2021 at 04:58:09PM +0100, Erez Geva wrote: > diff --git a/tlv.c b/tlv.c > index 98ef6e1..6e919e6 100644 > --- a/tlv.c > +++ b/tlv.c > @@ -324,6 +324,10 @@ static int mgt_post_recv(struct management_tlv *m, > uint16_t data_len, > psn = (struct port_stats_np

Re: [Linuxptp-devel] [PATCH] Revert "phc2sys: Expand the validation of the PPS mode."

2021-03-23 Thread Richard Cochran
On Mon, Mar 22, 2021 at 05:23:34PM +0100, Miroslav Lichvar wrote: > Allow the -s option to be used together with the -d option again. The > PHC is used in the PPS mode to fix the offset by an integer number of > seconds to get the system clock close to the PHC. > > This reverts commit

Re: [Linuxptp-devel] [PATCHv2] Avoid undefined integer operations.

2021-03-23 Thread Richard Cochran
On Mon, Mar 22, 2021 at 05:04:04PM +0100, Miroslav Lichvar wrote: > This fixes errors reported by the -fsanitize=undefined sanitizer. > > Before accepting the message interval value from a sync message, check > if it is between -10 and 22, same as required for the delay request > interval. > >

Re: [Linuxptp-devel] [PATCH] pmc: Fix printed totalCorrectionField.

2021-03-23 Thread Richard Cochran
On Mon, Mar 15, 2021 at 11:46:58AM +0100, Miroslav Lichvar wrote: > The value needs to be shifted to right to get nanoseconds. > > Signed-off-by: Miroslav Lichvar Applied. Thanks, Richard ___ Linuxptp-devel mailing list

Re: [Linuxptp-devel] Quation regarding the new 'uds_ro_address'

2021-03-23 Thread Richard Cochran
On Tue, Mar 16, 2021 at 12:38:38PM +, Geva, Erez wrote: > Can we set the read only file with a group, so we can run quaries > without root? You can change the permissions to whatever you want. > How about adding a "group" configuration for the uds_ro_address? I don't think we need yet

Re: [Linuxptp-devel] FYI: a summary scribble on my i210 SDP / PPS-in + 25 MHz ref etc sprees

2021-03-23 Thread Frantisek Rysanek
On 23 Mar 2021 at 8:34, Frank Rysanek wrote: > > On 22 Mar 2021 at 21:15, Richard Cochran wrote: > > > > FYI, the new ts2phc program does everything that synbc did, and > > more. > > > > Thanks, > > Richard > > Thanks for the tip, I'm gonna have to try that :-) > ...allright, reading through

Re: [Linuxptp-devel] FYI: a summary scribble on my i210 SDP / PPS-in + 25 MHz ref etc sprees

2021-03-23 Thread Miroslav Lichvar
On Mon, Mar 22, 2021 at 06:35:48PM +0100, Frantisek Rysanek wrote: > Anyway the time has come for me to post a link. > Here goes my newest scribble on the aforementioned topics: > > http://support.fccps.cz/industry/i210_hacks/i210_hacks.html Interesting stuff. Thanks for the post. That issue

Re: [Linuxptp-devel] FYI: a summary scribble on my i210 SDP / PPS-in + 25 MHz ref etc sprees

2021-03-23 Thread Frantisek Rysanek
On 22 Mar 2021 at 21:15, Richard Cochran wrote: > > FYI, the new ts2phc program does everything that synbc did, and more. > > Thanks, > Richard Thanks for the tip, I'm gonna have to try that :-) Frank ___ Linuxptp-devel mailing list