Re: [Lldb-commits] [PATCH] D12672: add a dependency on terminfo library if llvm uses it

2015-09-08 Thread Jeremi Piotrowski via lldb-commits
jeremi.piotrowski added a comment. I do not have commit access, so if you could do it for me that would be great. http://reviews.llvm.org/D12672 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

Re: [Lldb-commits] [PATCH] D12672: add a dependency on terminfo library if llvm uses it

2015-09-07 Thread Jeremi Piotrowski via lldb-commits
jeremi.piotrowski updated this revision to Diff 34169. jeremi.piotrowski added a comment. - combine nested if conditions with `and` as suggested by zturner and remove condtition from `endif` as that seems to be the convention. http://reviews.llvm.org/D12672 Files: cmake/LLDBDependencies.cm

[Lldb-commits] [PATCH] D12672: add a dependency on terminfo library if llvm uses it

2015-09-07 Thread Jeremi Piotrowski via lldb-commits
jeremi.piotrowski created this revision. jeremi.piotrowski added a subscriber: lldb-commits. Ncurses related symbols can either all be found in libnurses or split between libncurses and libtinfo. The main LLVM cmake scripts look for the setupterm symbol and stores the library that has it in TERMIN