jasonmolenda created this revision.
jasonmolenda added reviewers: JDevlieghere, bulbazord.
jasonmolenda added a project: LLDB.
Herald added a project: All.
jasonmolenda requested review of this revision.
Herald added a subscriber: lldb-commits.
This patch addresses two issues I found while looking
jasonmolenda added a comment.
One more bit of explanation about the changes: There is an SBTarget::AddModule
which takes individual parts of a module spec, and an SBTarget::AddModule which
takes an SBModuleSpec. I was going to need to duplicate my code to force the
expensive search & update t
bulbazord added a comment.
The idea seems fine to me. A few nits and comments, otherwise LGTM.
Comment at: lldb/source/API/SBTarget.cpp:1517
+ if (Symbols::DownloadObjectAndSymbolFile(*module_spec.m_opaque_up, error,
+ true)) {
jasonmolenda marked 2 inline comments as done.
jasonmolenda added inline comments.
Comment at:
lldb/test/API/python_api/target-arch-from-module/TestTargetArchFromModule.py:39
+dwarfdump_cmd_output = subprocess.check_output(
+('/usr/bin/dwarfdump --uuid "%s"'
jasonmolenda updated this revision to Diff 549507.
jasonmolenda added a comment.
Incorporate Alex's suggestions, not sure about using llvm-dwarfdump yet tho.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157659/new/
https://reviews.llvm.org/D157659
bulbazord added inline comments.
Comment at:
lldb/test/API/python_api/target-arch-from-module/TestTargetArchFromModule.py:39
+dwarfdump_cmd_output = subprocess.check_output(
+('/usr/bin/dwarfdump --uuid "%s"' % aout_exe), shell=True
+).decode("utf-8")
bulbazord accepted this revision.
bulbazord added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157659/new/
https://reviews.llvm.org/D157659
_
This revision was automatically updated to reflect the committed changes.
Closed by commit rGebf249066ac5: [lldb] SBTarget::AddModule do all searches by
UUID, set Target arch (authored by jasonmolenda).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D1