This revision was automatically updated to reflect the committed changes.
Closed by commit rL296119: Hardware breakpoints for Linux on Arm/AArch64
targets (authored by omjavaid).
Changed prior to commit:
https://reviews.llvm.org/D29669?vs=89642&id=89654#toc
Repository:
rL LLVM
https://revie
labath accepted this revision.
labath added a comment.
lgtm, thanks.
Comment at:
packages/Python/lldbsuite/test/functionalities/breakpoint/hardware_breakpoints/hardware_breakpoint_on_multiple_threads/main.cpp:30
+
+ hw_break_mutex.lock();
+
I know it's only
omjavaid updated this revision to Diff 89642.
omjavaid edited the summary of this revision.
omjavaid added a comment.
Herald added a subscriber: srhines.
@labath
Hi I have updated diff with corrections.
Thanks!
https://reviews.llvm.org/D29669
Files:
include/lldb/Host/common/NativeBreakpoint
omjavaid added inline comments.
Comment at:
packages/Python/lldbsuite/test/functionalities/breakpoint/hardware_breakpoints/hardware_breakpoint_on_multiple_threads/TestHWBreakMultiThread.py:78
+
+while count < 4 :
+
labath wrote:
> This is quite
labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.
I am sorry about the delay - I was busy last week and then this kinda fell off
my radar.
The change looks good, but I want to make the test more stable - we are running
these in CI
clayborg added a comment.
LGTM, but Pavel should give the ok as well.
https://reviews.llvm.org/D29669
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
