Re: [lng-odp] [PATCH v2 2/6] linux-generic: use source files instead of symbolic links

2016-08-04 Thread Bill Fischofer
On Thu, Aug 4, 2016 at 2:48 PM, Mike Holmes wrote: > On 4 August 2016 at 15:30, Brian Brooks wrote: > > > Use source files in arch/default for undetected archs. This > > alleviates the need to use symlinks in the source code > > directory structure. > > > > I prefer a behaviour where this fails

Re: [lng-odp] [PATCHv2] test: linux-gen: add pcap playback test

2016-08-04 Thread Bill Fischofer
On Tue, Aug 2, 2016 at 11:08 AM, Maxim Uvarov wrote: > add pcap play back test which takes 2 arguments: 1 - pcap file, > 2 - packet mask to match. Intend is to test odp with different > input traffic to check internal implementation functions. In > current case it's test for vlan tag instertion f

Re: [lng-odp] [PATCH v2 2/6] linux-generic: use source files instead of symbolic links

2016-08-04 Thread Mike Holmes
On 4 August 2016 at 15:30, Brian Brooks wrote: > Use source files in arch/default for undetected archs. This > alleviates the need to use symlinks in the source code > directory structure. > I prefer a behaviour where this fails at config time if a new ARCH appears. If you dont do this you start

[lng-odp] [PATCH v2 6/6] linux-generic: internal odp_cpu_hz_current()

2016-08-04 Thread Brian Brooks
Prefix odp_cpu_hz_current with '_' to be consistent with other internal cpu definitions in arch directory. Signed-off-by: Brian Brooks --- platform/linux-generic/arch/default/odp_sysinfo_parse.c | 3 ++- platform/linux-generic/arch/mips64/odp_sysinfo_parse.c | 3 ++- platform/linux-generic/arch

[lng-odp] [PATCH v2 5/6] linux-generic: internal odp_cpu_cycles()

2016-08-04 Thread Brian Brooks
Lift the definition of odp_cpu_cycles() out of the arch specific directory into the common odp_cpu.c which then calls the internal arch specific definition. Signed-off-by: Brian Brooks --- platform/linux-generic/Makefile.am | 1 + platform/linux-generic/arch/default/odp_cpu_arch

[lng-odp] [PATCH v2 4/6] linux-generic: lift odp_cpu_cycles_max/resolution()

2016-08-04 Thread Brian Brooks
Define odp_cpu_cycles_max() and odp_cpu_cycles_resolution() in the include API directory. These do not point to an internal value in arch because they are common across all archs. Signed-off-by: Brian Brooks --- platform/linux-generic/arch/default/odp_cpu_arch.c | 10 -- platform/linux-g

[lng-odp] [PATCH v2 3/6] linux-generic: move cpu_arch.h up two directories

2016-08-04 Thread Brian Brooks
Signed-off-by: Brian Brooks --- platform/Makefile.inc| 8 platform/linux-generic/Makefile.am | 2 +- platform/linux-generic/arch/default/{odp/api => }/cpu_arch.h | 0 platform/linux-generic/arch/mips64/{odp/api => }/cpu_ar

[lng-odp] [PATCH v2 2/6] linux-generic: use source files instead of symbolic links

2016-08-04 Thread Brian Brooks
Use source files in arch/default for undetected archs. This alleviates the need to use symlinks in the source code directory structure. Signed-off-by: Brian Brooks --- configure.ac | 13 +- platform/Makefile.inc | 3 -- plat

[lng-odp] [PATCH v2 1/6] linux-generic: internal odp_cpu_pause()

2016-08-04 Thread Brian Brooks
Signed-off-by: Brian Brooks --- platform/linux-generic/arch/default/odp/api/cpu_arch.h | 2 +- platform/linux-generic/arch/mips64/odp/api/cpu_arch.h | 2 +- platform/linux-generic/arch/powerpc/odp/api/cpu_arch.h | 2 +- platform/linux-generic/arch/x86/odp/api/cpu_arch.h | 2 +- platform/linu

[lng-odp] [Bug 2456] New: ODP name string lengths are multiply defined across the API

2016-08-04 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2456 Bug ID: 2456 Summary: ODP name string lengths are multiply defined across the API Product: OpenDataPlane - linux- generic reference Version: v1.10.1 Hardware: Other

Re: [lng-odp] [PATCH] validation: tm: use strncmp() to avoid potential string overrun

2016-08-04 Thread Bill Fischofer
On Thu, Aug 4, 2016 at 10:23 AM, Mike Holmes wrote: > > > On 3 August 2016 at 17:06, Bill Fischofer > wrote: > >> Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2426 by switching >> from >> strcmp() to strncmp() >> >> Signed-off-by: Bill Fischofer >> > > Reviewd-by: Mike Holmes > > This r

Re: [lng-odp] [PATCH] test:linux-generic: run odp_scheduling in process mode

2016-08-04 Thread Bill Fischofer
On Thu, Aug 4, 2016 at 11:17 AM, Brian Brooks wrote: > On 08/04 11:01:09, Bill Fischofer wrote: > > On Thu, Aug 4, 2016 at 10:59 AM, Mike Holmes > wrote: > > > > > > > > > > > On 4 August 2016 at 11:47, Bill Fischofer > > > wrote: > > > > > >> > > >> On Thu, Aug 4, 2016 at 10:36 AM, Mike Holmes

Re: [lng-odp] [PATCH 1/6] linux-generic: internal odp_cpu_pause()

2016-08-04 Thread Brian Brooks
On 08/04 13:39:43, Christophe Milard wrote: > Hi, > I have problems applying these patches: > ... anyone has tried? > Can you grab them from the list and apply them, Brian? I see the same issue.. Will investigate and respin. Thanks for pointing it out.

Re: [lng-odp] [PATCH] test:linux-generic: run odp_scheduling in process mode

2016-08-04 Thread Brian Brooks
On 08/04 11:01:09, Bill Fischofer wrote: > On Thu, Aug 4, 2016 at 10:59 AM, Mike Holmes wrote: > > > > > > > On 4 August 2016 at 11:47, Bill Fischofer > > wrote: > > > >> > >> On Thu, Aug 4, 2016 at 10:36 AM, Mike Holmes > >> wrote: > >> > >>> On my vanilla x86 I don't get any issues, keen to g

Re: [lng-odp] [PATCH] test:linux-generic: run odp_scheduling in process mode

2016-08-04 Thread Maxim Uvarov
On 08/04/16 18:26, Brian Brooks wrote: Reviewed-by: Brian Brooks On 08/04 09:18:14, Mike Holmes wrote: +ret=0 + +run() +{ + echo odp_scheduling_run_proc starts with $1 worker threads + echo = + + $PERFORMANCE/odp_scheduling$

Re: [lng-odp] [PATCH] test:linux-generic: run odp_scheduling in process mode

2016-08-04 Thread Bill Fischofer
On Thu, Aug 4, 2016 at 10:59 AM, Mike Holmes wrote: > > > On 4 August 2016 at 11:47, Bill Fischofer > wrote: > >> >> On Thu, Aug 4, 2016 at 10:36 AM, Mike Holmes >> wrote: >> >>> On my vanilla x86 I don't get any issues, keen to get this in and have >>> CI run it on lots of HW to see what happ

Re: [lng-odp] [PATCH] test:linux-generic: run odp_scheduling in process mode

2016-08-04 Thread Bill Fischofer
On Thu, Aug 4, 2016 at 11:03 AM, Maxim Uvarov wrote: > On 08/04/16 18:26, Brian Brooks wrote: > >> Reviewed-by: Brian Brooks >> >> On 08/04 09:18:14, Mike Holmes wrote: >> >>> +ret=0 >>> + >>> +run() >>> +{ >>> + echo odp_scheduling_run_proc starts with $1 worker threads >>> + echo =

Re: [lng-odp] [PATCH] test:linux-generic: run odp_scheduling in process mode

2016-08-04 Thread Mike Holmes
On 4 August 2016 at 11:47, Bill Fischofer wrote: > > On Thu, Aug 4, 2016 at 10:36 AM, Mike Holmes > wrote: > >> On my vanilla x86 I don't get any issues, keen to get this in and have >> CI run it on lots of HW to see what happens, many of the other tests >> completely fail in process mode so we

Re: [lng-odp] [PATCH] test:linux-generic: run odp_scheduling in process mode

2016-08-04 Thread Bill Fischofer
Quick update. I can repro this in v1.10.0.1 as well, however v1.10.0.0 seems good. On Thu, Aug 4, 2016 at 10:47 AM, Bill Fischofer wrote: > > On Thu, Aug 4, 2016 at 10:36 AM, Mike Holmes > wrote: > >> On my vanilla x86 I don't get any issues, keen to get this in and have >> CI run it on lots o

Re: [lng-odp] [PATCH] test:linux-generic: run odp_scheduling in process mode

2016-08-04 Thread Bill Fischofer
On Thu, Aug 4, 2016 at 10:36 AM, Mike Holmes wrote: > On my vanilla x86 I don't get any issues, keen to get this in and have CI > run it on lots of HW to see what happens, many of the other tests > completely fail in process mode so we will expose a lot as we add them I > think. > > On 4 August

Re: [lng-odp] [PATCH] test:linux-generic: run odp_scheduling in process mode

2016-08-04 Thread Mike Holmes
On my vanilla x86 I don't get any issues, keen to get this in and have CI run it on lots of HW to see what happens, many of the other tests completely fail in process mode so we will expose a lot as we add them I think. On 4 August 2016 at 11:33, Bill Fischofer wrote: > > > On Thu, Aug 4, 2016

Re: [lng-odp] [PATCH] test:linux-generic: run odp_scheduling in process mode

2016-08-04 Thread Bill Fischofer
On Thu, Aug 4, 2016 at 10:26 AM, Brian Brooks wrote: > Reviewed-by: Brian Brooks > > On 08/04 09:18:14, Mike Holmes wrote: > > +ret=0 > > + > > +run() > > +{ > > + echo odp_scheduling_run_proc starts with $1 worker threads > > + echo =

Re: [lng-odp] [PATCH] validation: tm: use strncmp() to avoid potential string overrun

2016-08-04 Thread Mike Holmes
On 3 August 2016 at 17:06, Bill Fischofer wrote: > Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2426 by switching from > strcmp() to strncmp() > > Signed-off-by: Bill Fischofer > Reviewd-by: Mike Holmes This raises a question on how many name lengths we need, maybe all the public API o

Re: [lng-odp] [PATCH] test:linux-generic: run odp_scheduling in process mode

2016-08-04 Thread Brian Brooks
Reviewed-by: Brian Brooks On 08/04 09:18:14, Mike Holmes wrote: > +ret=0 > + > +run() > +{ > + echo odp_scheduling_run_proc starts with $1 worker threads > + echo = > + > + $PERFORMANCE/odp_scheduling${EXEEXT} --odph_proc -c $1 || re

Re: [lng-odp] [API-NEXT PATCHv2] api: byteorder: avoid bitfield order doxygen omissions

2016-08-04 Thread Bill Fischofer
ping - needs review. thx. On Tue, Jul 12, 2016 at 9:27 PM, Bill Fischofer wrote: > Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2402 by assigning > explicit values to ODP_LITTLE_ENDIAN_BITFIELD and ODP_BIT_ENDIAN_BITFIELD > to avoid Doxygen warnings. This makes these consistent with the u

Re: [lng-odp] [PATCH] doc/implementers add internal prefix recommendation

2016-08-04 Thread Mike Holmes
On 4 August 2016 at 10:11, Christophe Milard wrote: > On 4 August 2016 at 16:08, Mike Holmes wrote: > > Promote coding style that reduces the chance of collisions with > > applications. > > > > Signed-off-by: Mike Holmes > > --- > > doc/implementers-guide/implementers-guide.adoc | 7 +++ >

Re: [lng-odp] [PATCH] doc/implementers add internal prefix recommendation

2016-08-04 Thread Christophe Milard
On 4 August 2016 at 16:08, Mike Holmes wrote: > Promote coding style that reduces the chance of collisions with > applications. > > Signed-off-by: Mike Holmes > --- > doc/implementers-guide/implementers-guide.adoc | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/doc/implementers-g

[lng-odp] [PATCH] doc/implementers add internal prefix recommendation

2016-08-04 Thread Mike Holmes
Promote coding style that reduces the chance of collisions with applications. Signed-off-by: Mike Holmes --- doc/implementers-guide/implementers-guide.adoc | 7 +++ 1 file changed, 7 insertions(+) diff --git a/doc/implementers-guide/implementers-guide.adoc b/doc/implementers-guide/implemen

Re: [lng-odp] [API-NEXT PATCH] linux-gen: drv: byteorder: fixed macro typo

2016-08-04 Thread Mike Holmes
On 4 August 2016 at 04:51, Christophe Milard wrote: > Signed-off-by: Christophe Milard > Reviewed-by: Mike Holmes > --- > platform/linux-generic/include/odp/drv/plat/byteorder_types.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/platform/linux-generic/include/odp

Re: [lng-odp] [API-NEXT PATCH] test: drv: atomic renamed to drvatomic

2016-08-04 Thread Mike Holmes
On 4 August 2016 at 04:58, Christophe Milard wrote: > At installation time (make install) all tests executables are copied > into a single directory (lib/odp/tests). > Having two modules with identical names on the two interfaces (api and drv) > leads to the same test executable name ('atomic_mai

[lng-odp] [PATCH] test:linux-generic: run odp_scheduling in process mode

2016-08-04 Thread Mike Holmes
Set up the environment to allow calling the performance tests in process mode as part of make check when enabled. To run the tests use --enable-test-perf-proc Initial patch using odp_scheduling as a proof Signed-off-by: Mike Holmes --- configure.ac | 2 ++

[lng-odp] [Bug 2414] api/spec/crypto.h contains todo items

2016-08-04 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2414 Mike Holmes changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

[lng-odp] [Bug 2424] CID 164655: Security best practices violations pktio/ipc.c:

2016-08-04 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2424 Mike Holmes changed: What|Removed |Added Resolution|--- |FIXED Status|CONFIRMED

[lng-odp] [Bug 2435] Traffic manager example includes internal files

2016-08-04 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2435 Mike Holmes changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

[lng-odp] [Bug 2453] PRIu64 is causing problems for odp-dpdk

2016-08-04 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2453 Mike Holmes changed: What|Removed |Added Ever confirmed|0 |1 Assignee|lng-odp@lists.linaro.org

Re: [lng-odp] [PATCH 1/6] linux-generic: internal odp_cpu_pause()

2016-08-04 Thread Christophe Milard
Hi, I have problems applying these patches: ... anyone has tried? Can you grab them from the list and apply them, Brian? Christophe. git am ~/incoming/PATCH_1-6_linux-generic_internal_odp_cpu_pause_.mbox Applying: linux-generic: internal odp_cpu_pause() fatal: corrupt patch at line 33 Patch faile

Re: [lng-odp] [PATCH] linux-gen: doc: defining the ODP thread

2016-08-04 Thread Maxim Uvarov
On 08/04/16 12:02, Christophe Milard wrote: On 4 August 2016 at 08:40, Maxim Uvarov wrote: I'm not sure that: platform/linux-generic/include/odp/api/platform_specific.dox directory is good for documentation files. Do we want to create a directory for a single file when the need for other f

Re: [lng-odp] [PATCH] linux-gen: doc: defining the ODP thread

2016-08-04 Thread Christophe Milard
On 4 August 2016 at 08:40, Maxim Uvarov wrote: > I'm not sure that: > > platform/linux-generic/include/odp/api/platform_specific.dox > directory is good for documentation files. Do we want to create a directory for a single file when the need for other files is not clear? > > I do not see also c

[lng-odp] [API-NEXT PATCH] test: drv: atomic renamed to drvatomic

2016-08-04 Thread Christophe Milard
At installation time (make install) all tests executables are copied into a single directory (lib/odp/tests). Having two modules with identical names on the two interfaces (api and drv) leads to the same test executable name ('atomic_main' in this case). As a consequence one of the test overwrites

[lng-odp] [API-NEXT PATCH] linux-gen: drv: byteorder: fixed macro typo

2016-08-04 Thread Christophe Milard
Signed-off-by: Christophe Milard --- platform/linux-generic/include/odp/drv/plat/byteorder_types.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/platform/linux-generic/include/odp/drv/plat/byteorder_types.h b/platform/linux-generic/include/odp/drv/plat/byteorder_types.h ind