This revision was automatically updated to reflect the committed changes.
Closed by commit rHGd74589c85f5e: bdiff: add a xdiffblocks method (authored by
quark, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2602?vs=6480&id=6516
REVISION DE
quark updated this revision to Diff 6480.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2602?vs=6476&id=6480
REVISION DETAIL
https://phab.mercurial-scm.org/D2602
AFFECTED FILES
mercurial/cext/bdiff.c
mercurial/policy.py
setup.py
CHANGE DETAILS
quark added inline comments.
INLINE COMMENTS
> indygreg wrote in bdiff.c:239
> Calling `PyList_Append()` in tight loops can be a bit slow. It is faster to
> allocate an array of `PyObject` and then allocate a `PyList` of final size
> and call `PyList_SET_ITEM` to populate it. But we can optimiz
quark added inline comments.
INLINE COMMENTS
> indygreg wrote in bdiff.c:263
> Does our C standard level allow to declare variables after non-declarations
> in blocks?
Not sure. But the rest is C89. So I'll move this up.
> indygreg wrote in bdiff.c:283
> This exception type is nonsensical. But
indygreg accepted this revision.
indygreg added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> bdiff.c:239
> + return -1;
> + if (PyList_Append(rl, m) != 0) {
> + Py_DECREF(m);
Calling `PyList_Append()` in tight loops can be a bit
quark updated this revision to Diff 6476.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2602?vs=6459&id=6476
REVISION DETAIL
https://phab.mercurial-scm.org/D2602
AFFECTED FILES
mercurial/cext/bdiff.c
mercurial/policy.py
setup.py
CHANGE DETAILS
quark created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This is similar to `bdiff.blocks`, but uses xdiff as the backend.
The indent heuristic is turned on by default since it has little overhead
and improves diff qu
