This revision was automatically updated to reflect the committed changes.
Closed by commit rHG977432970080: rust: stop putting NULL_REVISION in
MissingAncestors.bases (authored by gracinet, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D594
gracinet updated this revision to Diff 14056.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5944?vs=14041&id=14056
REVISION DETAIL
https://phab.mercurial-scm.org/D5944
AFFECTED FILES
rust/hg-core/src/ancestors.rs
CHANGE DETAILS
diff --git a/rust/hg
kevincox accepted this revision.
kevincox added inline comments.
INLINE COMMENTS
> ancestors.rs:245
> self.bases.extend(new_bases);
> +self.bases.remove(&NULL_REVISION);
> }
I think it would be more clear if you filtered the NULL_REVISION out before
extending the set.
l
gracinet created this revision.
Herald added subscribers: mercurial-devel, kevincox, durin42.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
As noted in initial review of MissingAncestors, adding
NULL_REVISION in constructor in case the given `bases` is
empty wasn't really useful, y
