Re: [Mesa-dev] [PATCH 22/22] st/dri: Add option to control exposure of 10 bpc color configs.

2017-12-13 Thread Marek Olšák
Mario, can we push these patches? Marek On Wed, Nov 29, 2017 at 5:21 AM, Mario Kleiner wrote: > Some clients may not like rgb10 fbconfigs and visuals. > Support driconf option 'allow_rgb10_configs' on gallium > to allow per application enable/disable. > > The option

Re: [Mesa-dev] [Mesa-stable] [PATCH] swr: Fix KNOB_MAX_WORKER_THREADS thread creation override.

2017-12-13 Thread Rowley, Timothy O
Reviewed-by: Tim Rowley > On Dec 12, 2017, at 5:37 PM, Bruce Cherniak > wrote: Environment variable KNOB_MAX_WORKER_THREADS allows the user to override default thread

[Mesa-dev] [PATCH] radeonsi: make use of ac_init_exec_full_mask()

2017-12-13 Thread Samuel Pitoiset
Similar to si_init_exec_full_mask(). Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeonsi/si_shader.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c

Re: [Mesa-dev] [PATCH v2 3/3] i965: if DEBUG_OUT_OF_BOUND_CHK is up, check that noise padding for each bo used in batchbuffer is correct

2017-12-13 Thread Rogovin, Kevin
Hi, > Yes. It's just the accidental writes into the read-only bo that you may miss. > Your call, and I have no > objections if such limitations are described in the comments. I'll add the comment; since there then less code to read (indeed using brw_bo_map will not work because it does not map

Re: [Mesa-dev] [PATCH v2 3/3] i965: if DEBUG_OUT_OF_BOUND_CHK is up, check that noise padding for each bo used in batchbuffer is correct

2017-12-13 Thread Chris Wilson
Quoting Rogovin, Kevin (2017-12-13 11:59:41) > Just to make sure of the reason of the original objection to trusting pread > blindly: > pread will miss writes IF the GEM BO was not listed in the execbuffer2 ioctl. Yes. It's just the accidental writes into the read-only bo that you may miss.

Re: [Mesa-dev] [PATCH v2 3/3] i965: if DEBUG_OUT_OF_BOUND_CHK is up, check that noise padding for each bo used in batchbuffer is correct

2017-12-13 Thread Rogovin, Kevin
Just to make sure of the reason of the original objection to trusting pread blindly: pread will miss writes IF the GEM BO was not listed in the execbuffer2 ioctl. If that is the case, I am ok with missing those writes because those writes (should) only occur if the GPU writes to padding of

Re: [Mesa-dev] [PATCH 1/4] intel/decoder: Drop gen_field_decode helper

2017-12-13 Thread Lionel Landwerlin
I was using it in the aubinator ui, but that's kind of stalled a bit. I'm fine adding it back later if people are still interested in the UI. This series is : Reviewed-by: Lionel Landwerlin On 13/12/17 01:38, Jason Ekstrand wrote: It's unused ---

Re: [Mesa-dev] [PATCH v2 3/3] i965: if DEBUG_OUT_OF_BOUND_CHK is up, check that noise padding for each bo used in batchbuffer is correct

2017-12-13 Thread Chris Wilson
Quoting Rogovin, Kevin (2017-12-13 11:19:10) > Hi, > > > Actually that's not strictly true. Since you only do a pread here, it will > > only synchronize against the last declared write to the bo. > > There's no guaranteed sync with the last batch for a set of read-only bo. > > Similarly, because

Re: [Mesa-dev] [PATCH v2 3/3] i965: if DEBUG_OUT_OF_BOUND_CHK is up, check that noise padding for each bo used in batchbuffer is correct

2017-12-13 Thread Rogovin, Kevin
Hi, > Actually that's not strictly true. Since you only do a pread here, it will > only synchronize against the last declared write to the bo. > There's no guaranteed sync with the last batch for a set of read-only bo. > Similarly, because of no domain tracking, it won't also ensure that the bo

Re: [Mesa-dev] [PATCH v2 3/3] i965: if DEBUG_OUT_OF_BOUND_CHK is up, check that noise padding for each bo used in batchbuffer is correct

2017-12-13 Thread Chris Wilson
Quoting kevin.rogo...@intel.com (2017-12-13 10:18:38) > From: Kevin Rogovin > > v2: > Comments indicating that brw_bo_padding_is_good() will do the required > waiting for GPU commands to finish > > Signed-off-by: Kevin Rogovin > --- >

Re: [Mesa-dev] [PATCH] radv: Don't advertise VK_EXT_debug_report.

2017-12-13 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 12/12/2017 10:17 PM, Bas Nieuwenhuizen wrote: We never supported it. Missed during copy and pasting. Fixes: 17201a2eb0b "radv: port to using updated anv entrypoint/extension generator." --- src/amd/vulkan/radv_extensions.py | 1 -

[Mesa-dev] [Bug 104233] [needs triage] Crashes XWayland when moving mouse fastly on GNOME application overview

2017-12-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104233 Michel Dänzer changed: What|Removed |Added Product|Mesa|Wayland

[Mesa-dev] [PATCH v2 3/3] i965: if DEBUG_OUT_OF_BOUND_CHK is up, check that noise padding for each bo used in batchbuffer is correct

2017-12-13 Thread kevin . rogovin
From: Kevin Rogovin v2: Comments indicating that brw_bo_padding_is_good() will do the required waiting for GPU commands to finish Signed-off-by: Kevin Rogovin --- src/mesa/drivers/dri/i965/intel_batchbuffer.c | 19 +++ 1 file

[Mesa-dev] [PATCH v2 1/3] intel/common:add debug flag for adding and checking padding on BO's

2017-12-13 Thread kevin . rogovin
From: Kevin Rogovin Signed-off-by: Kevin Rogovin --- src/intel/common/gen_debug.c | 1 + src/intel/common/gen_debug.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/intel/common/gen_debug.c b/src/intel/common/gen_debug.c index

[Mesa-dev] [PATCH v2 2/3] i965: add noise padding to buffer object and function to check if noise is correct

2017-12-13 Thread kevin . rogovin
From: Kevin Rogovin v2: Change from using rand() to using internal generating function (requested/suggested by Jason Ekstrand) Avoid having extra pointers in brw_bo struct via using the internal function and allocating buffer for pread at brw_bo_padding_is_good()

[Mesa-dev] [PATCH v2 0/3] GEM BO padding to find OOB buffer writes

2017-12-13 Thread kevin . rogovin
From: Kevin Rogovin This patch series adds a new debug option to pad each GEM BO allocated by the brw_bufmgr with pseudo-(weak) random noise values which are then checked after each batchbuffer dispatch to the kernel. This can be quite valuable to find diffucult to track

[Mesa-dev] [PATCH] radeonsi: don't use fast color clear for small images even on APUs

2017-12-13 Thread Dieter Nützel
Tested-by: Dieter Nützel Yes, on RX580 it is slightly more than 20%, but GREAT ;-) Dieter Am 13.12.2017 00:53, schrieb Marek Olšák: From: Marek Olšák Increase the limit and handle non-square images better. This makes glxgears 20% faster on APUs,

Re: [Mesa-dev] [PATCH] mesa: remove second include of errors.h in src/mesa/main/glspirv.c

2017-12-13 Thread Eduardo Lima Mitev
On 12/12/2017 05:56 PM, Ian Romanick wrote: > Weird that this was not noticed before... *shrug* This was a rebase mistake, sorry about that. Thanks Kai for catching and fixing it. Eduardo > Reviewed-by: Ian Romanick > > On 12/12/2017 07:20 AM, Kai Wasserbäch wrote:

[Mesa-dev] [PATCH 2/3] i965: add noise padding to buffer object and function to check if noise is correct

2017-12-13 Thread kevin . rogovin
From: Kevin Rogovin Signed-off-by: Kevin Rogovin --- src/mesa/drivers/dri/i965/brw_bufmgr.c | 105 - src/mesa/drivers/dri/i965/brw_bufmgr.h | 8 +++ 2 files changed, 112 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 0/3] GEM BO padding to find OOB buffer writes

2017-12-13 Thread kevin . rogovin
From: Kevin Rogovin This patch series adds a new debug option to pad each GEM BO allocated by the brw_bufmgr with pseudo-(weak) random noise values which are then checked after each batchbuffer dispatch to the kernel. This can be quite valuable to find diffucult to track

[Mesa-dev] [PATCH 3/3] i965: if DEBUG_OUT_OF_BOUND_CHK is up, check that noise padding for each bo used in batchbuffer is correct

2017-12-13 Thread kevin . rogovin
From: Kevin Rogovin Signed-off-by: Kevin Rogovin --- src/mesa/drivers/dri/i965/intel_batchbuffer.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_batchbuffer.c

[Mesa-dev] [PATCH 1/3] intel/common:add debug flag for adding and checking padding on BO's

2017-12-13 Thread kevin . rogovin
From: Kevin Rogovin Signed-off-by: Kevin Rogovin --- src/intel/common/gen_debug.c | 1 + src/intel/common/gen_debug.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/intel/common/gen_debug.c b/src/intel/common/gen_debug.c index

<    1   2