Re: [Mesa-dev] [PATCH 1/3] vbo: Reestablish VAO limit checking on imm VAOs.

2018-06-04 Thread Mathias Fröhlich
Hi Christian, On Sunday, 3 June 2018 20:08:14 CEST Christian Gmeiner wrote: > Am Sa., 2. Juni 2018 um 08:53 Uhr schrieb : > > > > From: Mathias Fröhlich > > > > Bail out with out of memory, when the required stride exceeds the > > maximum possible stride as stored in Const.MaxVertexAttribStride.

[Mesa-dev] [Bug 106594] [regression, apitrace, bisected] Prison Architect rendered unplayable by multicoloured flickering triangles and overlayed triangles when performing certain actions

2018-06-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106594 Kai changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

2018-06-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77449 Bug 77449 depends on bug 106594, which changed state. Bug 106594 Summary: [regression,apitrace,bisected] Prison Architect rendered unplayable by multicoloured flickering triangles and overlayed triangles when performing certain actions https://b

Re: [Mesa-dev] [PATCH] mesa: Make sure that imm draws are flushed before other draws execute.

2018-06-04 Thread Mathias Fröhlich
Hi, That's pushed now! Thanks for the review and testing! best Mathias On Saturday, 2 June 2018 14:57:48 CEST Kai Wasserbäch wrote: > Hey Mathias, > mathias.froehl...@gmx.net wrote on 02.06.2018 08:51: > > The below patch fixes a recently introduced failure of my VAO rework. > > I could final

Re: [Mesa-dev] [PATCH] virgl: add shader offset alignment to to v2 caps struct

2018-06-04 Thread Dave Airlie
On 5 June 2018 at 03:27, Gurchetan Singh wrote: > I sent out a patch that adds capability bits to this struct, and the > first bit is the tgsi invariant capability. It's dependent on this > patch to apply correctly to master. Oops I dropped the ball there,I saw the renderer patches had landed an

[Mesa-dev] [PATCH] virgl: enable ARB_gpu_shader_fp64

2018-06-04 Thread Dave Airlie
From: Dave Airlie This enables ARB_gpu_shader_fp64 if the host provides it. --- src/gallium/drivers/virgl/virgl_screen.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/virgl/virgl_screen.c b/src/gallium/drivers/virgl/virgl_screen.c index e8d1c751779..2

[Mesa-dev] [PATCH] intel/blorp: Don't vertex fetch directly from clear values

2018-06-04 Thread Jason Ekstrand
On gen8+, we have to VF cache flush whenever a vertex binding aliases a previous binding at the same index modulo 4GiB. We deal with this in Vulkan by ensuring that vertex buffers and the dynamic state (from which BLORP pulls its vertex buffers) are in the same 4GiB region of the address space. T

Re: [Mesa-dev] [PATCH 038.1/129] FIXUP: nir: Support deref instructions in opt_undef

2018-06-04 Thread Jason Ekstrand
LGTM On Sun, Jun 3, 2018 at 4:10 PM, Bas Nieuwenhuizen wrote: > --- > src/compiler/nir/nir_opt_undef.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/src/compiler/nir/nir_opt_undef.c b/src/compiler/nir/nir_opt_ > undef.c > index 1439ca9c165..e42a9af2bdf 100644

Re: [Mesa-dev] [PATCH 000/129] AMD Fixups for the deref patches.

2018-06-04 Thread Jason Ekstrand
I have updated my wip/nir-deref-instr branch with the recommended changes. I haven't actually squashed any fixup commits yet because I want to make sure everyone is happy with them before I do. On Sun, Jun 3, 2018 at 4:10 PM, Bas Nieuwenhuizen wrote: > These are some fixes for v4 of Jasons deref

Re: [Mesa-dev] [PATCH] radv: Do not hardcode fast clear formats.

2018-06-04 Thread Dave Airlie
On 5 June 2018 at 08:53, Bas Nieuwenhuizen wrote: > except for the odd one out. > > This should support many more formats. I suppose we should have done this back at the start, but I think I was lazy. Looks like a good idea, assuming it doesn't break anything in CTS, Reviewed-by: Dave Airlie

[Mesa-dev] [Bug 106778] Files missing from tarball - intel_sanitize_gpu.*

2018-06-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106778 Stuart Young changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |scott.d.phill...@intel.com

Re: [Mesa-dev] [PATCH shader-db 1/2] intel_stub: Wrap mmap64.

2018-06-04 Thread Ian Romanick
This fixes the problem I encountered. Thanks! Series is Reviewed-by: Ian Romanick On 06/04/2018 04:26 PM, Kenneth Graunke wrote: > Otherwise our fake GEM bo mappings don't work. > --- > intel_stub.c | 16 > 1 file changed, 16 insertions(+) > > diff --git a/intel_stub.c b/int

[Mesa-dev] [PATCH shader-db 1/2] intel_stub: Wrap mmap64.

2018-06-04 Thread Kenneth Graunke
Otherwise our fake GEM bo mappings don't work. --- intel_stub.c | 16 1 file changed, 16 insertions(+) diff --git a/intel_stub.c b/intel_stub.c index ab046e5..a3316b1 100644 --- a/intel_stub.c +++ b/intel_stub.c @@ -39,6 +39,8 @@ static void *(*libc_mmap)(void *addr, size_t le

[Mesa-dev] [PATCH shader-db 2/2] intel_stub: Make intel_run wrapper script set -o i965.

2018-06-04 Thread Kenneth Graunke
I don't think anybody is using this script with any other driver. Also take a $DEBUGGER variable so you can do: $ DEBUGGER='gdb -q --args' ./intel_run shaders --- intel_run | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/intel_run b/intel_run index 5a162f8..ad9986d 100

[Mesa-dev] [PATCH] radv: Do not hardcode fast clear formats.

2018-06-04 Thread Bas Nieuwenhuizen
except for the odd one out. This should support many more formats. --- src/amd/vulkan/radv_formats.c | 253 ++ 1 file changed, 73 insertions(+), 180 deletions(-) diff --git a/src/amd/vulkan/radv_formats.c b/src/amd/vulkan/radv_formats.c index aafe331f27d..50ec904d

Re: [Mesa-dev] [Piglit] GitLab migration of Piglit

2018-06-04 Thread Eric Anholt
Jason Ekstrand writes: > All, > > Sorry for the mess of GitLab e-mails but there are a lot of questions to > ask as this process moves forward. Today, we're discussing piglit. I've > included both the mesa and piglit list in the hopes that people will > actually see this e-mail. > > Honestly, I

Re: [Mesa-dev] GitLab migration of Piglit

2018-06-04 Thread Dylan Baker
As we discussed offline, I think it should be part of the mesa project. As I understand your explanation: if piglit becomes a mesa group project then anyone in the mesa group would automatically get piglit write access, but we can still give specific people write access to the piglit repo (without

[Mesa-dev] [Bug 106776] vma_random unrecognized command line option "-std=c++11"

2018-06-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106776 --- Comment #2 from Vinson Lee --- (In reply to Scott D Phillips from comment #1) > Created attachment 139959 [details] [review] > 0001-util-tests-vma-test-depends-on-C-11-support.patch > > I think this should do it. It looks like in the meson

[Mesa-dev] [Bug 106756] Wine 3.9 crashes with DXVK on Just Cause 3 and Quantum Break on VEGA but works ON POLARIS

2018-06-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106756 --- Comment #7 from Samuel Pitoiset --- Did you build mesa in debug mode (ie. --enable-debug)? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___

Re: [Mesa-dev] [PATCH 2/2] i965: Implement ARB_compute_variable_group_size.

2018-06-04 Thread Plamena Manolova
On Mon, 4 Jun 2018 at 21:36, Ilia Mirkin wrote: > On Mon, Jun 4, 2018 at 4:30 PM, Plamena Manolova > wrote: > > Thank you for the review Ilia! > > > > On Fri, 1 Jun 2018 at 23:44, Ilia Mirkin wrote: > >> > >> On Fri, Jun 1, 2018 at 6:21 PM, Plamena Manolova > >> wrote: > >> > + /* > >> >

Re: [Mesa-dev] [PATCH 4/4] i965: Use intel_bufferobj_buffer() wrapper in image surface state setup.

2018-06-04 Thread Nanley Chery
On Fri, May 11, 2018 at 04:55:27PM -0700, Nanley Chery wrote: > On Mon, Mar 19, 2018 at 11:26:59AM -0700, Francisco Jerez wrote: > > Instead of directly using intel_obj->buffer. Among other things > > intel_bufferobj_buffer() will update intel_buffer_object:: > > gpu_active_start/end, which are us

Re: [Mesa-dev] [PATCH 2/2] i965: Implement ARB_compute_variable_group_size.

2018-06-04 Thread Ilia Mirkin
On Mon, Jun 4, 2018 at 4:30 PM, Plamena Manolova wrote: > Thank you for the review Ilia! > > On Fri, 1 Jun 2018 at 23:44, Ilia Mirkin wrote: >> >> On Fri, Jun 1, 2018 at 6:21 PM, Plamena Manolova >> wrote: >> > + /* >> > + * If the local work group size is variable we have to use a >>

Re: [Mesa-dev] [PATCH 2/2] i965: Implement ARB_compute_variable_group_size.

2018-06-04 Thread Plamena Manolova
Thank you for the review Ilia! On Fri, 1 Jun 2018 at 23:44, Ilia Mirkin wrote: > On Fri, Jun 1, 2018 at 6:21 PM, Plamena Manolova > wrote: > > This patch adds the implentation of ARB_compute_variable_group_size > > for i965. We do this by storing the group size in a buffer surface, > > similarl

[Mesa-dev] [Bug 106778] Files missing from tarball - intel_sanitize_gpu.*

2018-06-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106778 Kevin Rogovin changed: What|Removed |Added Assignee|kevin.rogo...@intel.com |mesa-dev@lists.freedesktop.

[Mesa-dev] [Bug 106778] Files missing from tarball - intel_sanitize_gpu.*

2018-06-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106778 --- Comment #2 from Kevin Rogovin --- Hi, I am no longer involved with Mesa development; I suggest assigning the bug to whoever the git log lists as the author for the git commit that added those files. -- You are receiving this mail because

Re: [Mesa-dev] [PATCH 2/2] i965: Implement ARB_compute_variable_group_size.

2018-06-04 Thread Plamena Manolova
Thank you for reviewing this Jordan! On Fri, 1 Jun 2018 at 23:45, Jordan Justen wrote: > On 2018-06-01 15:21:34, Plamena Manolova wrote: > > This patch adds the implentation of ARB_compute_variable_group_size > > for i965. We do this by storing the group size in a buffer surface, > > similarly t

Re: [Mesa-dev] GitLab migration of Piglit

2018-06-04 Thread Marek Olšák
I would say it's a sub-project of Mesa. Marek On Mon, Jun 4, 2018 at 11:48 AM, Jason Ekstrand wrote: > All, > > Sorry for the mess of GitLab e-mails but there are a lot of questions to > ask as this process moves forward. Today, we're discussing piglit. I've > included both the mesa and pigli

Re: [Mesa-dev] [PATCH 2/2] i965: Implement ARB_compute_variable_group_size.

2018-06-04 Thread Plamena Manolova
Ah, that's true, I'll switch them around. Thank you for reviewing Matt! On Sat, 2 Jun 2018 at 04:58, Matt Turner wrote: > On Fri, Jun 1, 2018 at 3:21 PM, Plamena Manolova > wrote: > > This patch adds the implentation of ARB_compute_variable_group_size > > for i965. We do this by storing the gro

Re: [Mesa-dev] [PATCH] trace: Fix trace_context_transfer_unmap methods.

2018-06-04 Thread Jose Fonseca
Right. The issue is that transfer_map/transfer_unmap, just by themselves don't imply changing data. So the way trace driver works is that it emits fake buffer_subdata/transfer_subdata when unmapping write transfers. (Originally, it used pipe_transfer_inline method, before it was rename/refac

[Mesa-dev] [Bug 106151] [amdgpu][vulkan] GPU hang (Vega 56) while running game (Rise of the Tomb Raider)

2018-06-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106151 --- Comment #15 from pritzl3...@gmail.com --- Hi Alex, I gave it a try now with the new update to ROTTR and the game still hangs in the same way. I am now on kernel 4.17.0 Mesa and llvm from git updated about 2 hours ago. OpenGL renderer strin

[Mesa-dev] [PATCH v2] meson: fix private libs when building without glx

2018-06-04 Thread Lukas Rusak
I noticed that the generated pkg-config files will include glx and x11 dependencies even when x11 isn't a selected platform. This fixes the private libs and was tested by building kmscube V2: - check if gallium-xlib is being used for glx Reviewed-by: Dylan Baker --- meson.build | 18

[Mesa-dev] [Bug 106784] 18.1.1 autotools build fail without mako

2018-06-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106784 --- Comment #8 from fred...@rinnestam.se --- (In reply to Dylan Baker from comment #7) > Those are just build-time dependencies, you can uninstall them afterwards. It's not really practical in a source based distribution (yes a few still exist).

Re: [Mesa-dev] [PATCH mesa] configure: radv depends on mako

2018-06-04 Thread Bas Nieuwenhuizen
Acked-by: Bas Nieuwenhuizen On Mon, Jun 4, 2018 at 1:12 PM, Eric Engestrom wrote: > Bug: https://bugs.freedesktop.org/show_bug.cgi?id=106784 > Fixes: 17201a2eb0b1b85387136 "radv: port to using updated anv > entrypoint/extension generator." > Signed-off-by: Eric Enge

[Mesa-dev] [Bug 106784] 18.1.1 autotools build fail without mako

2018-06-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106784 --- Comment #7 from Dylan Baker --- Those are just build-time dependencies, you can uninstall them afterwards. -- You are receiving this mail because: You are the QA Contact for the bug.___ mesa-dev

Re: [Mesa-dev] [PATCH] meson: fix private libs when building without glx

2018-06-04 Thread Dylan Baker
Quoting Lukas Rusak (2018-06-03 22:57:31) > I noticed that the generated pkg-config files will include > glx and x11 dependencies even when x11 isn't a selected platform. > > This fixes the private libs and was tested by building kmscube > --- > meson.build | 18 -- > 1 file chang

Re: [Mesa-dev] [PATCH mesa] autotools: add missing android file to package

2018-06-04 Thread Dylan Baker
Reviewed-by: Dylan Baker Quoting Eric Engestrom (2018-06-04 10:09:55) > Bug: https://bugs.freedesktop.org/show_bug.cgi?id=106779 > Fixes: ff904978a1d299a36b587 "gallium/util: Android backtrace support" > Signed-off-by: Eric Engestrom > --- > src/gallium/auxiliary/Makefile.am | 1 + > 1 file cha

[Mesa-dev] [Bug 106784] 18.1.1 autotools build fail without mako

2018-06-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106784 --- Comment #5 from Bas Nieuwenhuizen --- Some of those files (radv_icd.py) uses the install path, you can't really put the result of that in a release tarball. so either we need to stop using mako for that and use something else, or we still

[Mesa-dev] [Bug 106784] 18.1.1 autotools build fail without mako

2018-06-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106784 --- Comment #6 from fred...@rinnestam.se --- (In reply to Bas Nieuwenhuizen from comment #5) > Just curious though what are the main reasons against mako? Intel has been > depending on them like this for a while. My only "objection" is additiona

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

2018-06-04 Thread Daniel Stone
On 4 June 2018 at 19:29, Dylan Baker wrote: > Quoting Daniel Stone (2018-06-04 11:20:45) >> Is git-lfs mainly about supporting large individual files, or large >> collections of relatively small files? The tarballs aren't massive, >> there are just tons of them. If it does seem like a good idea, I

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

2018-06-04 Thread Dylan Baker
Quoting Daniel Stone (2018-06-04 11:20:45) > Hi Dylan, > > On 4 June 2018 at 19:18, Dylan Baker wrote: > > Quoting Daniel Stone (2018-06-03 13:19:51) > >> One thing I've just remembered is that https://www.mesa3d.org/archive/ > >> serves all the tarballs for Mesa releases. Given how Pages is > >>

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

2018-06-04 Thread Daniel Stone
Hi Dylan, On 4 June 2018 at 19:18, Dylan Baker wrote: > Quoting Daniel Stone (2018-06-03 13:19:51) >> One thing I've just remembered is that https://www.mesa3d.org/archive/ >> serves all the tarballs for Mesa releases. Given how Pages is >> structured, we don't have a good way to redirect these t

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

2018-06-04 Thread Dylan Baker
Quoting Daniel Stone (2018-06-03 13:19:51) > Hi Laura, > > On 25 May 2018 at 01:27, Laura Ekstrand wrote: > > When reviewing these patches, please note: > > 1. This patch series does *not* touch content. Please do not > > bikeshed > >the content of webpages here. That will

Re: [Mesa-dev] GitLab personal repos

2018-06-04 Thread Adam Jackson
On Sat, 2018-06-02 at 13:10 -0400, Rob Clark wrote: > On Sat, Jun 2, 2018 at 12:07 PM, Jason Ekstrand wrote: > > 1) Forks share objects behind the user's back so it should use > > significantly less space on the GitLab server if everyone's personal mesa > > repo is an actual GitLab fork and not a

Re: [Mesa-dev] [PATCH mesa] meson: fix platforms check for `-D egl=true`

2018-06-04 Thread Dylan Baker
Reviewed-by: Dylan Baker Quoting Eric Engestrom (2018-06-04 03:46:32) > Fixes: 0ed6a87a106b6e2266e0 "meson: fix platforms=[]" > Reported-by: Christoph Haag > Signed-off-by: Eric Engestrom > --- > meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meson.build

Re: [Mesa-dev] [PATCH] glx: Fix number of property values to read in glXImportContextEXT

2018-06-04 Thread Adam Jackson
On Fri, 2018-06-01 at 19:01 +0200, Michel Dänzer wrote: > From: Michel Dänzer > > We were trying to read twice as many as the X server sent us, which > upset XCB: > > [xcb] Too much data requested from _XRead > [xcb] This is most likely caused by a broken X extension library > [xcb] Aborting, so

[Mesa-dev] [Bug 106778] Files missing from tarball - intel_sanitize_gpu.*

2018-06-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106778 Eric Engestrom changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |kevin.rogo...@intel.com

Re: [Mesa-dev] [PATCH] virgl: add shader offset alignment to to v2 caps struct

2018-06-04 Thread Gurchetan Singh
I sent out a patch that adds capability bits to this struct, and the first bit is the tgsi invariant capability. It's dependent on this patch to apply correctly to master. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop

[Mesa-dev] [Bug 106784] 18.1.1 autotools build fail without mako

2018-06-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106784 Eric Engestrom changed: What|Removed |Added CC||airl...@freedesktop.org,

[Mesa-dev] [PATCH 2/2] virgl: use bits in caps set v2

2018-06-04 Thread gurchetansi...@chromium.org
Let's add another field to caps v2, that can help report boolean values. Suggested-by: Gert Wollny Suggested-by: Dave Airlie --- src/gallium/drivers/virgl/virgl_hw.h | 5 + src/gallium/drivers/virgl/virgl_winsys.h | 1 + 2 files changed, 6 insertions(+) diff --git a/src/gallium/drivers

[Mesa-dev] [PATCH mesa] autotools: add missing android file to package

2018-06-04 Thread Eric Engestrom
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=106779 Fixes: ff904978a1d299a36b587 "gallium/util: Android backtrace support" Signed-off-by: Eric Engestrom --- src/gallium/auxiliary/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/auxiliary/Makefile.am b/src/gallium/

Re: [Mesa-dev] [PATCH mesa 1/3] egl: rewire the build systems to use libwayland-egl

2018-06-04 Thread Matt Turner
On Mon, Jun 4, 2018 at 9:47 AM, Eric Engestrom wrote: > On Monday, 2018-06-04 09:15:06 -0700, Matt Turner wrote: >> On Thu, May 31, 2018 at 10:22 AM, Emil Velikov >> wrote: >> > On 29 May 2018 at 15:41, Eric Engestrom wrote: >> >> Cc: Emil Velikov >> >> Cc: Daniel Stone >> >> Signed-off-by: E

Re: [Mesa-dev] [PATCH] virgl: add shader offset alignment to to v2 caps struct

2018-06-04 Thread Gurchetan Singh
Got it, thanks. Let me send a patch to virglrenderer to change tgsi_invariant to some sort of bitset, since when it lands it'll just need one bit. On Mon, Jun 4, 2018 at 9:39 AM Gert Wollny wrote: > > Am Montag, den 04.06.2018, 09:07 -0700 schrieb Gurchetan Singh: > > The tgsi_invariant code neve

Re: [Mesa-dev] [PATCH mesa 1/3] egl: rewire the build systems to use libwayland-egl

2018-06-04 Thread Eric Engestrom
On Monday, 2018-06-04 09:15:06 -0700, Matt Turner wrote: > On Thu, May 31, 2018 at 10:22 AM, Emil Velikov > wrote: > > On 29 May 2018 at 15:41, Eric Engestrom wrote: > >> Cc: Emil Velikov > >> Cc: Daniel Stone > >> Signed-off-by: Eric Engestrom > >> --- > >> A couple things worth mentioning:

Re: [Mesa-dev] [PATCH] virgl: add shader offset alignment to to v2 caps struct

2018-06-04 Thread Gert Wollny
Am Montag, den 04.06.2018, 09:07 -0700 schrieb Gurchetan Singh: > The tgsi_invariant code never landed in the Mesa side. Is the caps > code is resilient enough to handle this case? From my understanding > the guest caps and host caps don't have to match exactly, and the > "right thing" will be do

Re: [Mesa-dev] [PATCH mesa 1/3] egl: rewire the build systems to use libwayland-egl

2018-06-04 Thread Matt Turner
On Thu, May 31, 2018 at 10:22 AM, Emil Velikov wrote: > On 29 May 2018 at 15:41, Eric Engestrom wrote: >> Cc: Emil Velikov >> Cc: Daniel Stone >> Signed-off-by: Eric Engestrom >> --- >> A couple things worth mentioning: >> - I chose to add libwayland-egl as a separate dependency for EGL rather

Re: [Mesa-dev] [PATCH] virgl: add shader offset alignment to to v2 caps struct

2018-06-04 Thread Gurchetan Singh
The tgsi_invariant code never landed in the Mesa side. Is the caps code is resilient enough to handle this case? From my understanding the guest caps and host caps don't have to match exactly, and the "right thing" will be done. On Mon, Jun 4, 2018 at 6:03 AM Gert Wollny wrote: > > Am Donnerstag

Re: [Mesa-dev] [PATCH] trace: Fix trace_context_transfer_unmap methods.

2018-06-04 Thread Roland Scheidegger
Alright, this now has all the right bits buffer/texture_subdata would use. That said, I'm still a bit confused why this is necessary. Is that just so the dumped output looks like it's the same as if you called texture/buffer_subdata? Makes sense then, but in reality it still was a transfer. Review

[Mesa-dev] [PATCH] virgl: add shader offset alignment to to v2 caps struct

2018-06-04 Thread gurchetansi...@chromium.org
This is the SSBO analogue to fe0647. User supplied data must be a multiple of GL_SHADER_STORAGE_BUFFER_OFFSET_ALIGNMENT. This fixes 44 GLES31 tests on airlied@'s GLES31 sketch branches with Nvidia hardware, but this patch standalone can applied to master. The alignment restriction on Nvidia is 32,

[Mesa-dev] GitLab migration of Piglit

2018-06-04 Thread Jason Ekstrand
All, Sorry for the mess of GitLab e-mails but there are a lot of questions to ask as this process moves forward. Today, we're discussing piglit. I've included both the mesa and piglit list in the hopes that people will actually see this e-mail. Honestly, I expect the migration of piglit to have

[Mesa-dev] [Bug 106784] 18.1.1 autotools build fail without mako

2018-06-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106784 --- Comment #3 from Michael Olbrich --- Why not ship the generated files in the tarball like it's done in other parts of mesa? -- You are receiving this mail because: You are the QA Contact for the bug._

[Mesa-dev] [Bug 106151] [amdgpu][vulkan] GPU hang (Vega 56) while running game (Rise of the Tomb Raider)

2018-06-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106151 --- Comment #14 from Alex Smith --- If you're still seeing a hang, could you try the latest game update (released today)? -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.

Re: [Mesa-dev] [PATCH] virgl: add shader offset alignment to to v2 caps struct

2018-06-04 Thread Gert Wollny
Am Donnerstag, den 12.04.2018, 18:11 -0700 schrieb gurchetansi...@chromium.org: > This is the SSBO analogue to fe0647. User supplied data must > be a multiple of GL_SHADER_STORAGE_BUFFER_OFFSET_ALIGNMENT. > > This fixes 44 GLES31 tests on airlied@'s GLES31 sketch branches with > Nvidia hardware, b

[Mesa-dev] [PATCH] trace: Fix trace_context_transfer_unmap methods.

2018-06-04 Thread Jose Fonseca
The emitted buffer_subdata/texture_subdata call didn't match the respective signatures. v2: Actually emit buffer_subdata call. --- .../auxiliary/driver_trace/tr_context.c | 60 +-- 1 file changed, 42 insertions(+), 18 deletions(-) diff --git a/src/gallium/auxiliary/driver_t

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/3] radv: Set active_stages the same whether or not shaders were cached

2018-06-04 Thread Alex Smith
On 1 June 2018 at 22:51, Dylan Baker wrote: > Quoting Samuel Pitoiset (2018-06-01 08:58:42) > > > > > > On 06/01/2018 05:48 PM, Dylan Baker wrote: > > > Quoting Alex Smith (2018-06-01 07:56:38) > > >> On 1 June 2018 at 15:48, Dylan Baker wrote: > > >> > > >> Quoting Alex Smith (2018-05-31 0

Re: [Mesa-dev] [PATCH 5/6] r600g: some -Wsign-compare fixes

2018-06-04 Thread Konstantin Kharlamov
On 03.06.2018 16:03, Gert Wollny wrote: Patches 2-4 Reviewed-By: Gert Wollny I can't push them though I'd like to add that for the future it would be better to - send the patches for st and r600 as separate series, this would make it easier to find reviewers - when fixing warning to

Re: [Mesa-dev] [PATCH 6/6] r600g: fix unused variable warning

2018-06-04 Thread Konstantin Kharlamov
On 03.06.2018 15:41, Gert Wollny wrote: This patch doesn't apply, the "int i" was deleted already; I didn't find the commit though. Oh, well. Good thing somebody that cleaned it up already :) ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org ht

Re: [Mesa-dev] [PATCH] wayland/egl: initialize window surface size to window size

2018-06-04 Thread Daniel Stone
Hi Juan, On 4 June 2018 at 12:43, Juan A. Suarez Romero wrote: > On Fri, 2018-06-01 at 16:32 +0100, Daniel Stone wrote: >> I think you're right, and this needs more rework to be consistent. >> >> wl_egl_window_get_attached_size() always returns the size of the last >> attached buffer (if there ha

Re: [Mesa-dev] [PATCH][v2] wayland/egl: initialize window surface size to window size

2018-06-04 Thread Juan A. Suarez Romero
Forgot to say this is an V2 patch. J.A. On Mon, 2018-06-04 at 12:27 +0200, Juan A. Suarez Romero wrote: > When creating a windows surface with eglCreateWindowSurface(), the > width and height returned by eglQuerySurface(EGL_{WIDTH,HEIGHT}) is > invalid until buffers are updated (like ca

Re: [Mesa-dev] [PATCH] wayland/egl: initialize window surface size to window size

2018-06-04 Thread Juan A. Suarez Romero
On Fri, 2018-06-01 at 16:32 +0100, Daniel Stone wrote: > Hi, > > On 1 June 2018 at 15:35, Brendan King wrote: > > IMG has a similar patch to the one you describe, but without the changes to > > the resize_callback, so just this bit: > > > > @@ -255,6 +257,12 @@ dri2_wl_create_window_surface(_EGL

[Mesa-dev] [Bug 106784] 18.1.1 autotools build fail without mako

2018-06-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106784 --- Comment #2 from fred...@rinnestam.se --- Bummer! No workaround available to avoid mako? It does introduce a lot of previously unneeded depencencies. -- You are receiving this mail because: You are the QA Contact for the bug.

[Mesa-dev] [Bug 106784] 18.1.1 autotools build fail without mako

2018-06-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106784 --- Comment #1 from Eric Engestrom --- I just sent a patch to the ML that should fix it; unfortunately for you, the fix is that it should've failed earlier, you do need mako when building radv. (cc'ed you on the patch so that you can confirm the

[Mesa-dev] [PATCH mesa] configure: radv depends on mako

2018-06-04 Thread Eric Engestrom
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=106784 Fixes: 17201a2eb0b1b85387136 "radv: port to using updated anv entrypoint/extension generator." Signed-off-by: Eric Engestrom --- configure.ac | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configure.ac

Re: [Mesa-dev] [PATCH] i965: Fix batch-last mode to properly swap BOs.

2018-06-04 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 04/06/18 11:18, Kenneth Graunke wrote: On pre-4.13 kernels, which don't support I915_EXEC_BATCH_FIRST, we move the validation list entry to the end...but incorrectly left the exec_bo array alone, causing a mismatch where exec_bos[0] no longer corresponded with

Re: [Mesa-dev] [PATCH] radv: Don't pass a TESS_EVAL shader when tesselation is not enabled.

2018-06-04 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 06/02/2018 02:31 PM, Bas Nieuwenhuizen wrote: Otherwise on pre-GFX9, if the constant layout allows both TESS_EVAL and GEOMETRY shaders, but the PIPELINE has only GEOMETRY, it would return the GEOMETRY shader for the TESS_EVAL shader. This would cause the flush_c

[Mesa-dev] [PATCH mesa] meson: fix platforms check for `-D egl=true`

2018-06-04 Thread Eric Engestrom
Fixes: 0ed6a87a106b6e2266e0 "meson: fix platforms=[]" Reported-by: Christoph Haag Signed-off-by: Eric Engestrom --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 7b7c118d77b11cc38f7b..1d1b2a979b1de80ddd06 100644 --- a/meson.build

[Mesa-dev] [PATCH] i965: Fix fractional viewport coordinates handling on gen8+

2018-06-04 Thread Danylo Piliaiev
On gen8+ fractional translation of viewport moved it by a whole integer. The behaviour in this case isn't defined anywhere but some apps like Wine may depend on viewport's width and height being ceiled. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106526 Signed-off-by: Danylo Piliaiev -

[Mesa-dev] [PATCH] wayland/egl: initialize window surface size to window size

2018-06-04 Thread Juan A. Suarez Romero
When creating a windows surface with eglCreateWindowSurface(), the width and height returned by eglQuerySurface(EGL_{WIDTH,HEIGHT}) is invalid until buffers are updated (like calling glClear()). But according to EGL 1.5 spec, section 3.5.6 ("Surface Attributes"): "Querying EGL_WIDTH and EGL_HEI

Re: [Mesa-dev] [PATCH] i965: Fix batch-last mode to properly swap BOs.

2018-06-04 Thread Chris Wilson
Quoting Kenneth Graunke (2018-06-04 11:18:37) > On pre-4.13 kernels, which don't support I915_EXEC_BATCH_FIRST, we move > the validation list entry to the end...but incorrectly left the exec_bo > array alone, causing a mismatch where exec_bos[0] no longer corresponded > with validation_list[0] (and

[Mesa-dev] [PATCH] i965: Fix batch-last mode to properly swap BOs.

2018-06-04 Thread Kenneth Graunke
On pre-4.13 kernels, which don't support I915_EXEC_BATCH_FIRST, we move the validation list entry to the end...but incorrectly left the exec_bo array alone, causing a mismatch where exec_bos[0] no longer corresponded with validation_list[0] (and similarly for the last entry). One example of result

Re: [Mesa-dev] [PATCH] radeonsi/gfx9: fix si_get_buffer_from_descriptors for 48-bit pointers

2018-06-04 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 06/02/2018 01:31 AM, Marek Olšák wrote: From: Marek Olšák This fixes: GL45-CTS.pipeline_statistics_query_tests_ARB.functional_compute_shader_invocations Cc: 18.0 18.1 --- src/gallium/drivers/radeonsi/si_descriptors.c | 4 ++-- 1 file changed, 2 insertions(

[Mesa-dev] [Bug 106807] Failed to parse macro "#line"

2018-06-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106807 Kenneth Graunke changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 1/2] anv/android: Set the BO flags in bo_cache_import (v2)

2018-06-04 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 04/06/18 01:38, Mauro Rossi wrote: Changes to avoid building error: external/mesa/src/intel/vulkan/anv_android.c:131:72: error: too few arguments to function call, expected 5, have 4 result = anv_bo_cache_import(device, &device->bo_cache, dma_buf, &bo);

Re: [Mesa-dev] [PATCH] anv/android: Set the BO flags in bo_cache_import (v2)

2018-06-04 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 04/06/18 01:48, Mauro Rossi wrote: Changes to avoid building error: external/mesa/src/intel/vulkan/anv_android.c:131:72: error: too few arguments to function call, expected 5, have 4 result = anv_bo_cache_import(device, &device->bo_cache, dma_buf, &bo);

Re: [Mesa-dev] [PATCH 1/4] intel/eu: Add some brw_get_default_ helpers

2018-06-04 Thread Kenneth Graunke
On Tuesday, May 29, 2018 5:02:51 PM PDT Jason Ekstrand wrote: > This is much cleaner than everything that wants a default value poking > at the bits of p->current directly. > --- > src/intel/compiler/brw_eu.c | 29 ++ > src/intel/compiler/brw_eu.h | 3 + > src/inte

[Mesa-dev] [Bug 106807] Failed to parse macro "#line"

2018-06-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106807 Zhaowei Yuan changed: What|Removed |Added Summary|Failed to parse macor |Failed to parse macro

[Mesa-dev] [Bug 106807] Failed to parse macor "#line"

2018-06-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106807 Zhaowei Yuan changed: What|Removed |Added Summary|Failed to parser macor |Failed to parse macor

[Mesa-dev] [Bug 106807] Failed to parser macor "#line"

2018-06-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106807 Bug ID: 106807 Summary: Failed to parser macor "#line" Product: Mesa Version: 17.1 Hardware: ARM OS: Linux (All) Status: NEW Severity: normal P

[Mesa-dev] [Bug 106590] Wrong line numbers expanded while compiling shaders

2018-06-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106590 --- Comment #2 from Zhaowei Yuan --- (In reply to Timothy Arceri from comment #1) > Thanks for the patch! However you should sign up to the mesa mailing list > [1] and send it there for review. > > [1] https://lists.freedesktop.org/mailman/list

Re: [Mesa-dev] [PATCH 1/2] i965/miptree: Rename a parameter to create_for_dri_image

2018-06-04 Thread Kenneth Graunke
On Thursday, May 31, 2018 5:04:43 PM PDT Jason Ekstrand wrote: > Instead of having it be a general "is this a winsys image" boolean, make > it more specific to the actual purpose. > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 6 +++--- > src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 2

Re: [Mesa-dev] [PATCH 1/2] anv/android: Set the BO flags in bo_cache_import (v2)

2018-06-04 Thread Tapani Pälli
On 06/04/2018 08:50 AM, Jason Ekstrand wrote: Looks good to me.  Tapani (CCd) would know wheter we want EXEC_OBJECT_ASYNC or not.  Either way (not setting EXEC_OBJECT_ASYNC won't hurt), Currently after import we set EXEC_OBJECT_WRITE and remove EXEC_OBJECT_ASYNC (further down the function),

Re: [Mesa-dev] [PATCH] radv: Don't pass a TESS_EVAL shader when tesselation is not enabled.

2018-06-04 Thread Alex Smith
Oops. Thanks for tracking that down. Reviewed-by: Alex Smith On 2 June 2018 at 13:31, Bas Nieuwenhuizen wrote: > Otherwise on pre-GFX9, if the constant layout allows both TESS_EVAL and > GEOMETRY shaders, but the PIPELINE has only GEOMETRY, it would return the > GEOMETRY shader for the TESS_EV

[Mesa-dev] [Bug 106806] Fast clear for VK_FORMAT_R8G8_SNORM not implemented

2018-06-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106806 Bug ID: 106806 Summary: Fast clear for VK_FORMAT_R8G8_SNORM not implemented Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: enha

[Mesa-dev] [PATCH] compiler/spirv: reject invalid shader code properly

2018-06-04 Thread Martin Pelikán
After bebe3d626e5, b->fail_jump is prepared after vtn_create_builder which can longjmp(3) to it through its vtx_assert()s. This corrupts the stack and creates confusing core dumps, so we need to avoid it. While there, I decided to print the offending values for debugability. --- src/compiler/spi

[Mesa-dev] [PATCH 1/1] vulkan/wsi: Destroy swapchain images after terminating FIFO queues

2018-06-04 Thread Cameron Kumar
The queue_manager thread can access the images from x11_present_to_x11, hence this reorder prevents dereferencing of dangling pointers. Cc: "18.1" --- src/vulkan/wsi/wsi_common_x11.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/vulkan/wsi/wsi_common_x11.c b/src/v