Re: [Mesa3d-dev] [PATCH] dri: test whether the built drivers have unresolved symbols

2010-03-23 Thread Jesse Barnes
On Fri, 19 Mar 2010 23:05:27 +0100 Luca Barbieri wrote: > > For developers that makes a lot of sense, but I've never seen any > > other projects impose this type of thing on regular users. > > Why do you see it as an onerous imposition? > It just tries to compile a program linked with a couple o

Re: [Mesa3d-dev] [PATCH] dri: test whether the built drivers have unresolved symbols

2010-03-19 Thread Brian Paul
On Fri, Mar 19, 2010 at 4:17 PM, Xavier Chantry wrote: > On Fri, Mar 19, 2010 at 10:39 PM, Dan Nicholson wrote: >> On Fri, Mar 19, 2010 at 2:19 PM, Luca Barbieri >> wrote: Can we just put this program in the demos? Or at least just make it a separate target (make test-link)? It seems

Re: [Mesa3d-dev] [PATCH] dri: test whether the built drivers have unresolved symbols

2010-03-19 Thread Xavier Chantry
On Fri, Mar 19, 2010 at 10:39 PM, Dan Nicholson wrote: > On Fri, Mar 19, 2010 at 2:19 PM, Luca Barbieri wrote: >>> Can we just put this program in the demos? Or at least just make it a >>> separate target (make test-link)? It seems excessive to make this part >>> of the default build path. >> >>

Re: [Mesa3d-dev] [PATCH] dri: test whether the built drivers have unresolved symbols

2010-03-19 Thread Luca Barbieri
> For developers that makes a lot of sense, but I've never seen any > other projects impose this type of thing on regular users. Why do you see it as an onerous imposition? It just tries to compile a program linked with a couple of libraries (the DRI driver, plus libGL) and makes the build fail if

Re: [Mesa3d-dev] [PATCH] dri: test whether the built drivers have unresolved symbols

2010-03-19 Thread Dan Nicholson
On Fri, Mar 19, 2010 at 2:19 PM, Luca Barbieri wrote: >> Can we just put this program in the demos? Or at least just make it a >> separate target (make test-link)? It seems excessive to make this part >> of the default build path. > > The whole purpose is to run this as part of the standard build,

Re: [Mesa3d-dev] [PATCH] dri: test whether the built drivers have unresolved symbols

2010-03-19 Thread Luca Barbieri
> Can we just put this program in the demos? Or at least just make it a > separate target (make test-link)? It seems excessive to make this part > of the default build path. The whole purpose is to run this as part of the standard build, so that the build fails if any driver is unloadable, (i.e. a

Re: [Mesa3d-dev] [PATCH] dri: test whether the built drivers have unresolved symbols

2010-03-19 Thread Dan Nicholson
On Fri, Mar 19, 2010 at 12:56 PM, Luca Barbieri wrote: > How about applying this? > > It should prevent introducing regressions similar to ones that > happened in the past, with very little downside. Can we just put this program in the demos? Or at least just make it a separate target (make test-

Re: [Mesa3d-dev] [PATCH] dri: test whether the built drivers have unresolved symbols

2010-03-19 Thread Luca Barbieri
How about applying this? It should prevent introducing regressions similar to ones that happened in the past, with very little downside. -- Download IntelĀ® Parallel Studio Eval Try the new software tools for yourself. Spe

Re: [Mesa3d-dev] [PATCH] dri: test whether the built drivers have unresolved symbols

2010-03-15 Thread Xavier Chantry
On Mon, Mar 15, 2010 at 6:36 PM, Luca Barbieri wrote: > This is a different approach to solving this problem that the patch > I previously posted, and unlike that, should not cause any problems. > > Right now undefined symbols in DRI drivers will still allow the > build to succeed. > > As a result

[Mesa3d-dev] [PATCH] dri: test whether the built drivers have unresolved symbols

2010-03-15 Thread Luca Barbieri
This is a different approach to solving this problem that the patch I previously posted, and unlike that, should not cause any problems. Right now undefined symbols in DRI drivers will still allow the build to succeed. As a result, people modifying drivers they cannot test risk creating unloadabl