Re: [Musicpd-dev-team] [PATCH ncmpc] new key to edit lyric

2011-12-17 Thread Jonathan Neuschäfer
On Tue, Dec 13, 2011 at 12:05:07AM +0100, Jonathan Neuschäfer wrote: On Mon, Dec 12, 2011 at 02:05:46PM -0800, Jeffrey Middleton wrote: On Mon, Dec 12, 2011 at 1:39 PM, Jonathan Neuschäfer j.neuschae...@gmx.netwrote: With the attached follow-up patch it compiles and works resonably, if

[Musicpd-dev-team] [PATCH ncmpc] new key to edit lyric

2011-12-12 Thread Jitka Novotna
Hi, There is a possibility to search for lyric on the Internet and to save it, but I miss a possibility to edit it, so I wrote it. Here it is. Jitka Novotna From 7d8252ae22a1b1b660a49ca584459b45adc4335b Mon Sep 17 00:00:00 2001 From: Jitka Novotna ji...@ucw.cz Date: Sun, 11 Dec 2011 12:50:02

Re: [Musicpd-dev-team] [PATCH ncmpc] new key to edit lyric

2011-12-12 Thread Jonathan Neuschäfer
On Mon, Dec 12, 2011 at 07:13:05PM +0100, Jitka Novotna wrote: Hi, There is a possibility to search for lyric on the Internet and to save it, but I miss a possibility to edit it, so I wrote it. Here it is. Jitka Novotna Thanks for the patch, I like it; but it has some problems. + {

Re: [Musicpd-dev-team] [PATCH ncmpc] new key to edit lyric

2011-12-12 Thread Jeffrey Middleton
On Mon, Dec 12, 2011 at 1:39 PM, Jonathan Neuschäfer j.neuschae...@gmx.netwrote: With the attached follow-up patch it compiles and works resonably, if I set $EDITOR (starting the right editor is _hard_. Debian has sensible- editor to do most of the tricky stuff, but you can't expect that

Re: [Musicpd-dev-team] [PATCH ncmpc] new key to edit lyric

2011-12-12 Thread Jonathan Neuschäfer
On Mon, Dec 12, 2011 at 02:05:46PM -0800, Jeffrey Middleton wrote: On Mon, Dec 12, 2011 at 1:39 PM, Jonathan Neuschäfer j.neuschae...@gmx.netwrote: With the attached follow-up patch it compiles and works resonably, if I set $EDITOR (starting the right editor is _hard_. Debian has sensible-

Re: [Musicpd-dev-team] [PATCH ncmpc] new key to edit lyric

2011-12-12 Thread Max Kellermann
On 2011/12/12 22:39, Jonathan Neuschäfer j.neuschae...@gmx.net wrote: Perhaps we should use system() instead of fork and exec. Max? system() is easier to use and portable, but fork() gives you more control; for example, you could try a list of executables in one child process, instead of having