[PATCH 7/7] Documentation: devicetree: add ar8xxx binding

2015-05-28 Thread Mathieu Olivari
Add device-tree binding for ar8xxx switch families. Signed-off-by: Mathieu Olivari --- .../devicetree/bindings/net/dsa/qca-ar8xxx.txt | 70 ++ 1 file changed, 70 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/dsa/qca-ar8xxx.txt diff --git a/Docum

[PATCH 5/7] net: dsa: ar8xxx: enable QCA header support on AR8xxx

2015-05-28 Thread Mathieu Olivari
This change enable support for the QCA headers in QCA83337 driver. A 2 bytes header will be added by the switch on every incoming packet to identify the ingress port, and the DSA tagging code will add a similar 2 bytes header to control which port is used to send a particular packet. Signed-off-by

[PATCH 4/7] net: dsa: add QCA tag support

2015-05-28 Thread Mathieu Olivari
QCA tags are used on QCA ar8xxx switch family. This change adds support for encap/decap using 2 bytes header mode. Signed-off-by: Mathieu Olivari --- include/net/dsa.h | 1 + net/dsa/Kconfig| 3 + net/dsa/Makefile | 1 + net/dsa/dsa.c | 5 ++ net/dsa/dsa_priv.h | 2 + net/d

[PATCH 1/7] net: dsa: add new driver for ar8xxx family

2015-05-28 Thread Mathieu Olivari
This patch contains initial init & registration code for QCA8337. It will detect a QCA8337 switch, if present and declared in DT/platform. Each port will be represented through a standalone net_device interface, as for other DSA switches. CPU can communicate with any of the ports by setting an IP@

[PATCH 2/7] net: dsa: ar8xxx: add ethtool hw statistics support

2015-05-28 Thread Mathieu Olivari
MIB counters can now be reported through each switch port by using "ethtool -S". Signed-off-by: Mathieu Olivari --- drivers/net/dsa/ar8xxx.c | 106 +++ drivers/net/dsa/ar8xxx.h | 47 + 2 files changed, 146 insertions(+), 7 deletion

[PATCH 6/7] net: dsa: ar8xxx: add support for second xMII interfaces through DT

2015-05-28 Thread Mathieu Olivari
This patch is adding support for port6 specific options to device tree. They can be used to setup the second xMII interface, and connect it to one of the switch port. Signed-off-by: Mathieu Olivari --- drivers/net/dsa/ar8xxx.c | 50 1 file changed

[PATCH 3/7] net: dsa: ar8xxx: add regmap support

2015-05-28 Thread Mathieu Olivari
All switch registers can now be dumped using regmap/debugfs. \# cat /sys/kernel/debug/regmap//registers : 1302 0004: ... ... Signed-off-by: Mathieu Olivari --- drivers/net/dsa/Kconfig | 1 + drivers/net/dsa/ar8xxx.c | 60 drivers/net/ds

Re: [PATCH net-next] neigh: Add missing rcu_assign_pointer

2015-05-28 Thread Eric Dumazet
On Fri, 2015-05-29 at 09:21 +0800, Ying Xue wrote: > On 05/28/2015 06:13 PM, Eric Dumazet wrote: > > This patch is not needed. > > > > You really should read Documentation/RCU , because it looks like you are > > quite confused. > > > > When we remove an element from a RCU protected list, all the

Re: [PATCH 3/7] net: dsa: ar8xxx: add regmap support

2015-05-28 Thread Florian Fainelli
Le 05/28/15 18:42, Mathieu Olivari a écrit : > All switch registers can now be dumped using regmap/debugfs. > > \# cat /sys/kernel/debug/regmap//registers > : 1302 > 0004: ... > ... ethtool has a register dump command, which should already be supported by the current code in net/dsa/slave

Re: [PATCH 7/7] Documentation: devicetree: add ar8xxx binding

2015-05-28 Thread Florian Fainelli
Le 05/28/15 18:42, Mathieu Olivari a écrit : > Add device-tree binding for ar8xxx switch families. > > Signed-off-by: Mathieu Olivari > --- > .../devicetree/bindings/net/dsa/qca-ar8xxx.txt | 70 > ++ > 1 file changed, 70 insertions(+) > create mode 100644 Documentation/

Re: [PATCH net-next] neigh: Add missing rcu_assign_pointer

2015-05-28 Thread Ying Xue
On 05/29/2015 09:50 AM, Eric Dumazet wrote: > I count 5 places of redundancy. > Another two places you found are necessary indeed! Acked-by: Ying Xue > diff --git a/net/core/neighbour.c b/net/core/neighbour.c > index > 3a74df750af4044eba0e7d88ae01ca9b4dac0e72..ac3b69183cc982e722d9683d6de7a39

Re: [PATCH 0/7] net: dsa: add QCA AR8xxx switch family support

2015-05-28 Thread Andrew Lunn
On Thu, May 28, 2015 at 06:42:15PM -0700, Mathieu Olivari wrote: > This patch set adds initial support for AR8xxx switches using the DSA > subsystem. It currently supports QCA8337 switch, and can be extended to > other hardware in the same family. > > This switch was already discussed in the follo

Re: [PATCH 1/7] net: dsa: add new driver for ar8xxx family

2015-05-28 Thread Andrew Lunn
> +static int ar8xxx_set_pad_ctrl(struct dsa_switch *ds, int port, int mode) > +{ > + int reg; > + > + switch (port) { > + case 0: > + reg = AR8327_REG_PORT0_PAD_CTRL; > + break; > + case 6: > + reg = AR8327_REG_PORT6_PAD_CTRL; > + bre

[PATCH net-next] bpf: add missing rcu protection when releasing programs from prog_array

2015-05-28 Thread Alexei Starovoitov
Normally the program attachment place (like sockets, qdiscs) takes care of rcu protection and calls bpf_prog_put() after a grace period. The programs stored inside prog_array may not be attached anywhere, so prog_array needs to take care of preserving rcu protection. Otherwise bpf_tail_call() will

Re: [PATCH 3/7] net: dsa: ar8xxx: add regmap support

2015-05-28 Thread Andrew Lunn
On Thu, May 28, 2015 at 06:58:14PM -0700, Florian Fainelli wrote: > Le 05/28/15 18:42, Mathieu Olivari a écrit : > > All switch registers can now be dumped using regmap/debugfs. > > > > \# cat /sys/kernel/debug/regmap//registers > > : 1302 > > 0004: ... > > ... > > ethtool has a register

Re: [PATCH 3/7] net: dsa: ar8xxx: add regmap support

2015-05-28 Thread Florian Fainelli
Le 05/28/15 19:23, Andrew Lunn a écrit : > On Thu, May 28, 2015 at 06:58:14PM -0700, Florian Fainelli wrote: >> Le 05/28/15 18:42, Mathieu Olivari a écrit : >>> All switch registers can now be dumped using regmap/debugfs. >>> >>> \# cat /sys/kernel/debug/regmap//registers >>> : 1302 >>> 000

Re: [V5 PATCH 2/5] arm64 : Introduce support for ACPI _CCA object

2015-05-28 Thread Mark Salter
On Wed, 2015-05-20 at 17:09 -0500, Suravee Suthikulpanit wrote: > From http://www.uefi.org/sites/default/files/resources/ACPI_6.0.pdf, > section 6.2.17 _CCA states that ARM platforms require ACPI _CCA > object to be specified for DMA-cabpable devices. Therefore, this patch > specifies ACPI_CCA_REQU

Re: [PATCH 3/7] net: dsa: ar8xxx: add regmap support

2015-05-28 Thread Andrew Lunn
> Fair enough, are there other global "things" besides counters that could > deserve adding maybe some sort of global/master net_device to help query > switch-wide information? This was discussed a while back. I like the current abstraction, all interfaces are real interfaces you can send and rece

Re: Fw: [Bug 99091] New: Kernel panic while sending network packets over TAP interface

2015-05-28 Thread Herbert Xu
Stephen Hemminger wrote: > > Our setup is designed specifically to cause the calling path "bridge transmit" > - "VLAN transmit" - "bridge transmit" - "GRE or TAP transmit" as reflected by > the crash dump. It appears that this sequence hits a race condition or a > corrupted/uninitialized error que

Re: [PATCH] net: qlcnic: clean up sysfs error codes

2015-05-28 Thread David Miller
From: Vladimir Zapolskiy Date: Fri, 29 May 2015 04:13:46 +0300 > Hello David, > > On 29.05.2015 02:28, David Miller wrote: >> From: Vladimir Zapolskiy >> Date: Tue, 26 May 2015 03:49:45 +0300 >> >>> Replace confusing QL_STATUS_INVALID_PARAM == -1 == -EPERM with -EINVAL >>> and QLC_STATUS_UNSUP

Re: pull request (net-next): ipsec-next 2015-05-28

2015-05-28 Thread David Miller
From: Steffen Klassert Date: Thu, 28 May 2015 08:25:47 +0200 > 1) Remove xfrm_queue_purge as this is the same as skb_queue_purge. > > 2) Optimize policy and state walk. > > 3) Use a sane return code if afinfo registration fails. > > 4) Only check fori a acquire state if the state is not valid.

Re: [PATCH net-next] bpf: allow BPF programs access skb->skb_iif and skb->dev->ifindex fields

2015-05-28 Thread Alexei Starovoitov
On 5/28/15 12:22 PM, Daniel Borkmann wrote: Signed-off-by: Alexei Starovoitov Acked-by: Daniel Borkmann btw, Daniel, your ack appeared on the mailing list, but didn't make it into patchwork... Same issue as I was having. I noticed when I send email via gmail web interface it always appears

Re: pull request (net): ipsec 2015-05-28

2015-05-28 Thread David Miller
From: Steffen Klassert Date: Thu, 28 May 2015 09:28:03 +0200 > 1) Fix a race in xfrm_state_lookup_byspi, we need to take >the refcount before we release xfrm_state_lock. >From Li RongQing. > > 2) Fix IV generation on ESN state. We used just the >low order sequence numbers for IV gene

Re: [PATCH net-next 1/3] net: systemport: Pre-calculate and utilize cb->bd_addr

2015-05-28 Thread Petri Gynther
On Thu, May 28, 2015 at 3:24 PM, Florian Fainelli wrote: > There is a 1:1 mapping between the software maintained control block in > priv->rx_cbs and the buffer address in priv->rx_bds, such that there is > no need to keep computing the buffer address when refiling a control > block. > > Signed-of

Re: [PATCH net-next] bpf: allow BPF programs access skb->skb_iif and skb->dev->ifindex fields

2015-05-28 Thread David Miller
From: Alexei Starovoitov Date: Thu, 28 May 2015 20:40:44 -0700 > On 5/28/15 12:22 PM, Daniel Borkmann wrote: >>> >>> Signed-off-by: Alexei Starovoitov >> >> Acked-by: Daniel Borkmann > > btw, Daniel, your ack appeared on the mailing list, but didn't make > it into patchwork... > Same issue as

Re: [PATCH] namespace: Remove no longer needed goto label in the function, ops_init

2015-05-28 Thread Eric W. Biederman
Nicholas Krause writes: > This removes the no longer needed goto label, cleanup in the > function ops_init due to kfree being NULL pointer safe and > therefore no need to avoid calling it the call to kzalloc > fails inside this particular function. Your proposed change pessimizes the error path

Re: [PATCH net-next 2/3] net: systemport: rewrite bcm_sysport_rx_refill

2015-05-28 Thread Petri Gynther
On Thu, May 28, 2015 at 3:24 PM, Florian Fainelli wrote: > Currently, bcm_sysport_desc_rx() calls bcm_sysport_rx_refill() at the end of > Rx > packet processing loop, after the current Rx packet has already been passed to > napi_gro_receive(). However, bcm_sysport_rx_refill() might fail to alloca

Re: [PATCH net-next 3/3] net: systemport: Add a check for oversized packets

2015-05-28 Thread Petri Gynther
On Thu, May 28, 2015 at 3:24 PM, Florian Fainelli wrote: > Occasionnaly we may get oversized packets from the hardware which exceed > the nomimal 2KiB buffer size we allocate SKBs with. Add an early check > which drops the packet to avoid invoking skb_over_panic() and move on to > processing the n

Re: [PATCH net-next 2/3] net: systemport: rewrite bcm_sysport_rx_refill

2015-05-28 Thread Florian Fainelli
Le 05/28/15 20:58, Petri Gynther a écrit : [snip] >> /* We do not have a backing SKB, so we do not a corresponding > > Is this comment still valid? I removed it from bcmgenet. Not really, thanks, I will fix that in v2. [snip] >> + >> + if (priv->rx_read_ptr == pri

Re: [RFC 1/3] net: dsa: add basic support for VLAN ndo

2015-05-28 Thread Scott Feldman
On Thu, May 28, 2015 at 2:37 PM, Vivien Didelot wrote: > This patch adds the ndo_vlan_rx_add_vid, ndo_vlan_rx_kill_vid, and > ndo_bridge_setlink wrapper operations, used to create and remove VLAN > entries in a DSA switch VLAN database. > > The switch drivers have to implement the port_vlan_add, p

Re: [RFC 0/3] DSA and Marvell 88E6352 802.1q support

2015-05-28 Thread Scott Feldman
On Thu, May 28, 2015 at 2:37 PM, Vivien Didelot wrote: > This RFC is based on v4.1-rc3. > > It is meant to get a glance to the commits responsible to implement the > necessary NDOs between DSA and the Marvell 88E6352 switch driver. > > With this support, I am able to create VLANs with (un)tagged p

Re: [PATCH net v2] switchdev: don't abort hardware ipv4 fib offload on failure to program fib entry in hardware

2015-05-28 Thread roopa
On 5/28/15, 2:42 AM, Jiri Pirko wrote: Mon, May 18, 2015 at 10:19:16PM CEST, da...@davemloft.net wrote: From: Roopa Prabhu Date: Sun, 17 May 2015 16:42:05 -0700 On most systems where you can offload routes to hardware, doing routing in software is not an option (the cpu limitations make routi

Re: [PATCH net v2] switchdev: don't abort hardware ipv4 fib offload on failure to program fib entry in hardware

2015-05-28 Thread roopa
On 5/28/15, 9:10 AM, John Fastabend wrote: On 05/28/2015 08:40 AM, Scott Feldman wrote: On Thu, May 28, 2015 at 2:42 AM, Jiri Pirko wrote: Mon, May 18, 2015 at 10:19:16PM CEST, da...@davemloft.net wrote: From: Roopa Prabhu Date: Sun, 17 May 2015 16:42:05 -0700 On most systems where you can

Re: [PATCH net v2] switchdev: don't abort hardware ipv4 fib offload on failure to program fib entry in hardware

2015-05-28 Thread roopa
On 5/28/15, 3:35 PM, Andy Gospodarek wrote: On Thu, May 28, 2015 at 08:40:11AM -0700, Scott Feldman wrote: On Thu, May 28, 2015 at 2:42 AM, Jiri Pirko wrote: Mon, May 18, 2015 at 10:19:16PM CEST, da...@davemloft.net wrote: From: Roopa Prabhu Date: Sun, 17 May 2015 16:42:05 -0700 On most sy

Re: [PATCH net-next v2 0/7] netns: ease netlink use with a lot of netns

2015-05-28 Thread Alexander Holler
Am 26.05.2015 um 16:36 schrieb Alexander Holler: Am 26.05.2015 um 14:10 schrieb Nicolas Dichtel: I don't understand why dumping in another netns is a problem. It isn't. I just wondered how you (or someone else) is using NETLINK_LISTEN_ALL_NSID, assuming it already serves a purpose. ;) Maybe

Re: [PATCH 2/4] netfilter: default CONFIG_NETFILTER_INGRESS to y

2015-05-28 Thread Jan Engelhardt
On Friday 2015-05-29 01:44, Pablo Neira Ayuso wrote: >Useful to compile-test all options. > >--- a/net/netfilter/Kconfig >+++ b/net/netfilter/Kconfig >@@ -3,6 +3,7 @@ menu "Core Netfilter Configuration" > > config NETFILTER_INGRESS > bool "Netfilter ingress support" >+ default y >

Re: Possible issue in iproute2 package

2015-05-28 Thread Vadim Kochan
Hi Jose, On Thu, May 28, 2015 at 09:12:15PM +, Guzman Mosqueda, Jose R wrote: > > Hi all > > I'm Jose Guzman from a security team at Intel. > We're using iproute2 in a GNU-Linux project and I'm analyzing the code > to try to find possible issues/gaps/risks. > Since I'm not too familiar with

RE: [Xen-devel] [RFC PATCH 00/13] Persistent grant maps for xen net drivers

2015-05-28 Thread Yuzhou (C)
Hi, About rx zerocopy, I have a question: If some application make a socket, then listen and accept, the client sends packets to it, but it doesn't recv from this socket right now, all persistent grant page would be in used. So other application cannot receive any packets. Is m

<    1   2   3