On 01/07/2016 10:43 AM, Tantilov, Emil S wrote:
-Original Message-
From: zhuyj [mailto:zyjzyj2...@gmail.com]
Sent: Tuesday, January 05, 2016 7:05 PM
To: Tantilov, Emil S; Michal Kubecek; Jay Vosburgh
Cc: vfal...@gmail.com; go...@cumulusnetworks.com; netdev@vger.kernel.org;
Shteinbock, Bor
On Wed, Jan 06, 2016 at 09:20:07AM -0800, Stephen Hemminger wrote:
> This commit breaks compilation of iproute2 with net-next.
Ok, linux/if.h and libc net/if.h have overlapping defines, and this is not
the only one. I saw lots of them in the core dump headers.
How should we handle them? Another i
On Thu, Jan 07, 2016 at 03:36:27AM +0100, Hannes Frederic Sowa wrote:
> On 15.12.2015 02:35, Nelson, Shannon wrote:
> >Using a slightly modified version of udpspam (see diff below -
> >hopefully not mangled by corporate email servers), where I set the
> >SO_NO_CHECK socket option and can specify a
Hi, Emil
Would you like to help me to make tests with this patch?
If the root cause is not the time span, I will make a new patch for this.
Thanks a lot.
Zhu Yanjun
On 01/07/2016 02:15 PM, zyjzyj2...@gmail.com wrote:
From: Zhu Yanjun
In 802.3ad mode, the speed and duplex is needed. But in so
>-Original Message-
>From: zhuyj [mailto:zyjzyj2...@gmail.com]
>Sent: Wednesday, January 06, 2016 7:34 PM
>To: Tantilov, Emil S; Michal Kubecek; Jay Vosburgh
>Cc: vfal...@gmail.com; go...@cumulusnetworks.com; netdev@vger.kernel.org;
>Shteinbock, Boris (Wind River)
>Subject: Re: [PATCH 1/1]
On Wed, Jan 06, 2016 at 02:00:56AM +0100, Daniel Borkmann wrote:
>
> I decided to extend the sch_ingress module with clsact functionality so
> that commonly used code can be reused, the module is being aliased with
> sch_clsact so that it can be auto-loaded properly. Alternative would have been
>
On 01/07/2016 10:43 AM, Tantilov, Emil S wrote:
-Original Message-
From: zhuyj [mailto:zyjzyj2...@gmail.com]
Sent: Tuesday, January 05, 2016 7:05 PM
To: Tantilov, Emil S; Michal Kubecek; Jay Vosburgh
Cc: vfal...@gmail.com; go...@cumulusnetworks.com; netdev@vger.kernel.org;
Shteinbock, Bor
Hi Daniel,
[auto build test ERROR on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Daniel-Borkmann/bpf-add-skb_postpush_rcsum-and-fix-dev_forward_skb-occasions/20160107-090423
config: x86_64-lkp (attached as .config)
reproduce:
# save the attached .config to linux bui
On 07.01.2016 03:36, Tom Herbert wrote:
On Wed, Jan 6, 2016 at 5:52 PM, Hannes Frederic Sowa
wrote:
Hi Tom,
On 05.01.2016 19:41, Tom Herbert wrote:
--- /dev/null
+++ b/arch/x86/lib/csum-partial_64.S
@@ -0,0 +1,147 @@
+/* Copyright 2016 Tom Herbert
+ *
+ * Checksum partial calculation
+ *
+
>-Original Message-
>From: zhuyj [mailto:zyjzyj2...@gmail.com]
>Sent: Tuesday, January 05, 2016 7:05 PM
>To: Tantilov, Emil S; Michal Kubecek; Jay Vosburgh
>Cc: vfal...@gmail.com; go...@cumulusnetworks.com; netdev@vger.kernel.org;
>Shteinbock, Boris (Wind River)
>Subject: Re: [PATCH 1/1] bo
On 01/06/2016 11:30 PM, Tantilov, Emil S wrote:
-Original Message-
From: zhuyj [mailto:zyjzyj2...@gmail.com]
Sent: Tuesday, January 05, 2016 9:42 PM
To: Tantilov, Emil S; Kirsher, Jeffrey T; Brandeburg, Jesse; Nelson,
Shannon; Wyborny, Carolyn; Skidmore, Donald C; Allan, Bruce W; Ronciak,
On Wed, Jan 6, 2016 at 5:52 PM, Hannes Frederic Sowa
wrote:
> Hi Tom,
>
> On 05.01.2016 19:41, Tom Herbert wrote:
>>
>> --- /dev/null
>> +++ b/arch/x86/lib/csum-partial_64.S
>> @@ -0,0 +1,147 @@
>> +/* Copyright 2016 Tom Herbert
>> + *
>> + * Checksum partial calculation
>> + *
>> + * __wsum csum
On 15.12.2015 02:35, Nelson, Shannon wrote:
Using a slightly modified version of udpspam (see diff below - hopefully not mangled by
corporate email servers), where I set the SO_NO_CHECK socket option and can specify a large
buffer size, I can reliably get the following WARN trace. I have repro
On Tue, 15 Dec 2015 01:35:27 +
"Nelson, Shannon" wrote:
> Using a slightly modified version of udpspam (see diff below - hopefully
> not mangled by corporate email servers), where I set the SO_NO_CHECK
> socket option and can specify a large buffer size, I can reliably get
> the following WAR
On 01/06/2016 11:30 PM, Tantilov, Emil S wrote:
-Original Message-
From: zhuyj [mailto:zyjzyj2...@gmail.com]
Sent: Tuesday, January 05, 2016 9:42 PM
To: Tantilov, Emil S; Kirsher, Jeffrey T; Brandeburg, Jesse; Nelson,
Shannon; Wyborny, Carolyn; Skidmore, Donald C; Allan, Bruce W; Ronciak,
On 07.01.2016 02:01, Daniel Borkmann wrote:
+static inline void skb_postpush_rcsum(struct sk_buff *skb,
+ const void *start, unsigned int len)
+{
+ if (skb->ip_summed == CHECKSUM_COMPLETE)
+ skb->csum = csum_add(skb->csum, csum_partial(start
Hi Tom,
On 05.01.2016 19:41, Tom Herbert wrote:
--- /dev/null
+++ b/arch/x86/lib/csum-partial_64.S
@@ -0,0 +1,147 @@
+/* Copyright 2016 Tom Herbert
+ *
+ * Checksum partial calculation
+ *
+ * __wsum csum_partial(const void *buff, int len, __wsum sum)
+ *
+ * Computes the checksum of a memory b
Hi Richard,
This all sounds fine. Thanks for the feedback. I'll roll this into the
next patchset.
Chris
On Tue, 05 Jan 2016 07:27:32 -0800, Richard Cochran
wrote:
On Mon, Jan 04, 2016 at 04:45:22AM -0800, Christopher S. Hall wrote:
+ case PTP_SYS_OFFSET_PRECISE:
+
On Wed, Jan 6, 2016 at 4:29 PM, David Wragg wrote:
> Jesse Gross writes:
>> On Wed, Jan 6, 2016 at 3:25 PM, David Wragg wrote:
>>> I'm certainly open to suggestions of better ways to solve the problem.
>>
>> One option is to simply set the MTU on the device from userspace.
>
> If that worked I w
>>
>> is it right?
>
>
> no. The above works fine for me. I literally copied and pasted all of the
> commands except the master ones which were adapted to my setup -- eth9 and
> eth11 for me instead of eth0 and eth1. tcpdump on N2, N3 show the right one
> is receiving packets based on which 'ping -
Add a small helper skb_postpush_rcsum() and fix up redirect locations
that need CHECKSUM_COMPLETE fixups on ingress. dev_forward_skb() expects
a proper csum that covers also Ethernet header, f.e. since 2c26d34bbcc0
("net/core: Handle csum for CHECKSUM_COMPLETE VXLAN forwarding"), we
also do skb_pos
On Wed, Jan 6, 2016 at 4:14 PM, Hannes Frederic Sowa
wrote:
> Hi,
>
>
> On 07.01.2016 00:57, Jesse Gross wrote:
>>
>> On Wed, Jan 6, 2016 at 3:25 PM, David Wragg wrote:
>>>
>>> David Miller writes:
>
> Prior to 4.3, openvswitch vxlan vports could transmit vxlan packets of
> any size,
Hi Jesse,
On 07.01.2016 01:18, Jesse Gross wrote:
On Wed, Jan 6, 2016 at 3:39 PM, Hannes Frederic Sowa
wrote:
Signed-off-by: Hannes Frederic Sowa
---
drivers/net/geneve.c | 30 +++---
include/net/geneve.h | 7 +++
2 files changed, 30 insertions(+), 7 deletions
Jesse Gross writes:
> On Wed, Jan 6, 2016 at 3:25 PM, David Wragg wrote:
>> I'm certainly open to suggestions of better ways to solve the problem.
>
> One option is to simply set the MTU on the device from userspace.
If that worked I wouldn't be submitting a patch.
The MTU value of 1500 is not
On Wed, Jan 6, 2016 at 3:39 PM, Hannes Frederic Sowa
wrote:
> Signed-off-by: Hannes Frederic Sowa
> ---
> drivers/net/geneve.c | 30 +++---
> include/net/geneve.h | 7 +++
> 2 files changed, 30 insertions(+), 7 deletions(-)
Thanks a lot for going through all the dri
Hi,
On 07.01.2016 00:57, Jesse Gross wrote:
On Wed, Jan 6, 2016 at 3:25 PM, David Wragg wrote:
David Miller writes:
Prior to 4.3, openvswitch vxlan vports could transmit vxlan packets of
any size, constrained only by the ability to transmit the resulting
UDP packets. 4.3 introduced vxlan ne
From: Joe Perches
Date: Wed, 06 Jan 2016 15:32:24 -0800
> On Thu, 2016-01-07 at 00:26 +0100, Bjørn Mork wrote:
>> Joe Perches writes:
>> > On Wed, 2016-01-06 at 16:33 -0500, David Miller wrote:
>> > > A repeating pattern in drivers has become to use OF node information
>> > > and, if not found,
On Wed, 2016-01-06 at 19:01 -0500, David Miller wrote:
> The caller checks for NULL, and this is the default implementation
> doing precisely what it is meant to do.
Yeah, I noticed that later. Nevermind...
cheers, Joe
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the bo
On Wed, Jan 6, 2016 at 3:25 PM, David Wragg wrote:
> David Miller writes:
>>> Prior to 4.3, openvswitch vxlan vports could transmit vxlan packets of
>>> any size, constrained only by the ability to transmit the resulting
>>> UDP packets. 4.3 introduced vxlan netdevs corresponding to vxlan
>>> vp
Florian Westphal wrote:
> Thadeu Lima de Souza Cascardo wrote:
> > On Wed, Jan 06, 2016 at 11:11:41PM +0300, Konstantin Khlebnikov wrote:
[ skb_gso_segment uses skb->cb[], causes oops if ip_fragment is invoked
on segmented skbs ]
> > I have hit this as well, this fixes it for me on an older k
Joe Perches writes:
> On Thu, 2016-01-07 at 00:26 +0100, Bjørn Mork wrote:
>> Joe Perches writes:
>> > On Wed, 2016-01-06 at 16:33 -0500, David Miller wrote:
>> > > A repeating pattern in drivers has become to use OF node information
>> > > and, if not found, platform specific host information to
Cc: Sathya Perla
Cc: Ajit Khaparde
Cc: Padmanabh Ratnakar
Cc: Sriharsha Basavapatna
Signed-off-by: Hannes Frederic Sowa
---
drivers/net/ethernet/emulex/benet/be_main.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/emulex/benet/be_main.c
b/d
Cc: dept-gelinuxnic...@qlogic.com
Signed-off-by: Hannes Frederic Sowa
---
drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_m
Cc: Jeff Kirsher
Signed-off-by: Hannes Frederic Sowa
---
drivers/net/ethernet/intel/fm10k/fm10k_pci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c
b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c
index 4eb7a6fa6b0ddc..846d9b731c8c14 100644
---
Signed-off-by: Hannes Frederic Sowa
---
drivers/net/geneve.c | 30 +++---
include/net/geneve.h | 7 +++
2 files changed, 30 insertions(+), 7 deletions(-)
diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c
index 24b077a32c1c9c..5b8d728b1204be 100644
--- a/driver
Protect IXGBE_FLAG2_VXLAN_REREG_NEEDED flag with rtnl_lock as it seems
it could be concurrently modified by ixgbe_set_features and
ixgbe_del_vxlan_port.
Cc: Jeff Kirsher
Signed-off-by: Hannes Frederic Sowa
---
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 2 ++
1 file changed, 2 insertions(+)
Signed-off-by: Hannes Frederic Sowa
---
drivers/net/vxlan.c | 17 +++--
include/net/vxlan.h | 5 +
2 files changed, 12 insertions(+), 10 deletions(-)
diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index fecf7b6c732e96..10f1304d58e1ea 100644
--- a/drivers/net/vxlan.c
+++
Signed-off-by: Hannes Frederic Sowa
---
include/linux/netdevice.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 8d8e5ca951b493..9750e46760695d 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -2183,6 +2183,
I don't really understand the use of the state_lock. Can't it be simply
replaced by rtnl_lock? It seems a lot of current users depend on
rtnl_lock anyway.
Anyway, fix this up for the moment.
Cc: Eugenia Emantayev
Signed-off-by: Hannes Frederic Sowa
---
drivers/net/ethernet/mellanox/mlx4/en_net
Device drivers which support geneve or vxlan offloading have a dependency
on the correlating tunnel kernel modules. Thus those drivers automatically
load the geneve or vxlan modules. Break this dependency with this
small series.
Additionally this series features a review of the respective ->ndo_op
On Thu, 2016-01-07 at 00:26 +0100, Bjørn Mork wrote:
> Joe Perches writes:
> > On Wed, 2016-01-06 at 16:33 -0500, David Miller wrote:
> > > A repeating pattern in drivers has become to use OF node information
> > > and, if not found, platform specific host information to extract the
> > > ethernet
Joe Perches writes:
> On Wed, 2016-01-06 at 16:33 -0500, David Miller wrote:
>> A repeating pattern in drivers has become to use OF node information
>> and, if not found, platform specific host information to extract the
>> ethernet address for a given device.
> []
>> diff --git a/include/linux/et
David Miller writes:
>> Prior to 4.3, openvswitch vxlan vports could transmit vxlan packets of
>> any size, constrained only by the ability to transmit the resulting
>> UDP packets. 4.3 introduced vxlan netdevs corresponding to vxlan
>> vports. These netdevs have an MTU, which limits the size of
On Wed, 2016-01-06 at 16:33 -0500, David Miller wrote:
> A repeating pattern in drivers has become to use OF node information
> and, if not found, platform specific host information to extract the
> ethernet address for a given device.
[]
> diff --git a/include/linux/etherdevice.h b/include/linux/e
- Forwarded Message -
> This trivial patch series addresses a number of endianness- and
> lock-related issues reported by sparse.
>
> Lance Richardson (3):
> ipv4: fix endianness warnings in ip_tunnel_core.c
> ipv4: eliminate endianness warnings in ip_fib.h
> ipv4: eliminate lock cou
On Wed, Jan 6, 2016 at 12:59 PM, David Miller wrote:
> From: David Wragg
> Date: Wed, 6 Jan 2016 13:33:04 +
>
>> Prior to 4.3, openvswitch vxlan vports could transmit vxlan packets of
>> any size, constrained only by the ability to transmit the resulting
>> UDP packets. 4.3 introduced vxlan
Add lock release/acquire annotations to ping_seq_start() and
ping_seq_stop() to satisfy sparse.
Signed-off-by: Lance Richardson
---
net/ipv4/ping.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/ipv4/ping.c b/net/ipv4/ping.c
index e89094a..c117b21 100644
--- a/net/ipv4/ping.c
+++ b/ne
Eliminate endianness mismatch warnings (reported by sparse) in this file by
using appropriate nla_put_*()/nla_get_*() calls.
Signed-off-by: Lance Richardson
---
net/ipv4/ip_tunnel_core.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/net/ipv4/ip_tunnel_core.
This trivial patch series addresses a number of endianness- and
lock-related issues reported by sparse.
Lance Richardson (3):
ipv4: fix endianness warnings in ip_tunnel_core.c
ipv4: eliminate endianness warnings in ip_fib.h
ipv4: eliminate lock count warnings in ping.c
include/net/ip_fib.h
fib_multipath_hash() computes a hash using __be32 values, force
cast these to u32 to pacify sparse.
Signed-off-by: Lance Richardson
---
include/net/ip_fib.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/net/ip_fib.h b/include/net/ip_fib.h
index 9f4df68..7029527 10
On Wed, Jan 06, 2016 at 10:32:16PM +0100, Daniel Borkmann wrote:
> Move the details behind the cb[] access into a small helper to decouple
> and make them generic for bpf_prog_run_save_cb()/bpf_prog_run_clear_cb()
> that was introduced via commit ff936a04e5f2 ("bpf: fix cb access in socket
> filter
On Wed, Jan 06, 2016 at 09:31:27PM +0100, Rabin Vincent wrote:
> On Tue, Jan 05, 2016 at 09:55:58AM -0800, Alexei Starovoitov wrote:
> > this one is better to be addressed in verifier instead of eBPF JITs.
> > Please reject it in check_alu_op() instead.
>
> AFAICS the eBPF verifier is not called o
As usual, there are a couple straggler bug fixes:
1) qlcnic_alloc_mbx_args() error returns are not checked in qlcnic driver.
Fix from Insu Yun.
2) SKB refcounting bug in connector, from Florian Westphal.
3) vrf_get_saddr() has to propagate fib_lookup() errors to it's callers,
from David A
Thadeu Lima de Souza Cascardo wrote:
> On Wed, Jan 06, 2016 at 11:11:41PM +0300, Konstantin Khlebnikov wrote:
> > On Wed, Jan 6, 2016 at 10:59 PM, Cong Wang wrote:
> > > On Wed, Jan 6, 2016 at 11:15 AM, Konstantin Khlebnikov
> > > wrote:
> > >> Looks like this happens because ip_options_fragmen
From: Maor Gottlieb
Add exports to flow steering API for mlx5_ib usage.
The following functions are exported:
1. mlx5_create_auto_grouped_flow_table - used to create flow
table with auto flow grouping management (create and destroy
flow groups). In auto-grouped flow tables, we create groups
auto
From: Maor Gottlieb
Adding flow steering support by creating a flow-table per
priority (if rules exist in the priority).
mlx5_ib uses autogrouping and thus only creates the
required destinations.
Signed-off-by: Maor Gottlieb
Signed-off-by: Moni Shoua
Signed-off-by: Matan Barak
Signed-off-by:
From: Maor Gottlieb
When the driver is loaded, we create flow steering namespace
for kernel bypass with nine priorities and another namespace
for leftovers(in order to catch packets that weren't matched).
Verbs applications will use these priorities.
we found nine as a number that balances the re
From: Maor Gottlieb
Flow tables from different priorities should be chained together.
When a packet arrives we search for a match in the
by-pass flow tables (first we search for a match in priority 0
and if we don't find a match we move to the next priority).
If we can't find a match in any of th
From: Maor Gottlieb
Each priority has two attributes:
1. max_ft - maximum allowed flow tables under this priority.
2. start_level - start level range of the flow tables
in the priority.
These attributes are set by traversing the tree nodes by
DFS and set start level and max flow tables to each p
From: Maor Gottlieb
Change the mlx5 firmware interface header to make it
more clear which bytes should be used by IPv4 or
IPv6 addresses.
Signed-off-by: Maor Gottlieb
Signed-off-by: Moni Shoua
Signed-off-by: Matan Barak
Signed-off-by: Saeed Mahameed
---
include/linux/mlx5/mlx5_ifc.h | 20
From: Maor Gottlieb
Introduce the modify flow table command. This command is used when
we want to change the next flow table of an existing flow table.
The next flow table is defined as the table we search (in order
to find a match), if we couldn't find a match in any of the flow table
entries in
From: Maor Gottlieb
Add three utility functions for support flow steering:
1. Parsing verbs flow attributes hardware steering specs.
2. Check if flow is multicast - this is required in order to decide to
which flow table will we add the steering rule.
3. Set outer headers in flow match criteri
Hi Dave,
This series adds three new functionalists to the driver flow-steering
infrastructure:
auto-grouped flow tables, chaining of flow tables and updates for the
root flow table.
Changes since V0:
- Fixed improperly formatted comments.
- Compare value of ib_spec->eth.mask.ether
From: Yuchung Cheng
Date: Wed, 6 Jan 2016 12:42:38 -0800
> Patch 3759824da87b ("tcp: PRR uses CRB mode by default and SS mode
> conditionally") introduced a bug that cwnd may become 0 when both
> inflight and sndcnt are 0 (cwnd = inflight + sndcnt). This may lead
> to a div-by-zero if the connec
From: Maor Gottlieb
Add two utility functions for find next and prev flow table.
Find next flow table function gets priority and return the
first flow table of the next priority in the tree.
Find prev flow table return the last flow table of
the previous priority in the tree.
These utility funct
From: Maor Gottlieb
When user add rule to autogrouped flow table, we search
for flow group with the same match criteria, if we don't
find such group then we create new flow group with the
required match criteria and insert the rule to this group.
We divide the flow table into required_groups + 1
From: Maor Gottlieb
The root Flow Table for each Flow Table Type is defined,
by default, as the Flow Table with level 0.
In order not to use an empty flow tables and introduce new hops,
but still preserve space for flow-tables that have a priority
greater(lower number) than the current flow tabl
From: Maor Gottlieb
Before we create the sub tree of a steering namespaces(kernel, bypass,
leftovers) we check that the device has the required capabilities
in order to create this subtree.
Signed-off-by: Maor Gottlieb
Signed-off-by: Moni Shoua
Signed-off-by: Matan Barak
Signed-off-by: Saeed
On (01/06/16 16:33), David Miller wrote:
>
> Signed-off-by: David S. Miller
Acked-by: Sowmini Varadhan
>
> As promised back in November, I'm commiting this into net-next
> now. I'd work on the conversions of existing drivers, but I'd
> rather someone with access to the hardware to so.
I'll
A repeating pattern in drivers has become to use OF node information
and, if not found, platform specific host information to extract the
ethernet address for a given device.
Currently this is done with a call to of_get_mac_address() and then
some ifdef'd stuff for SPARC.
Consolidate this into a
Move the details behind the cb[] access into a small helper to decouple
and make them generic for bpf_prog_run_save_cb()/bpf_prog_run_clear_cb()
that was introduced via commit ff936a04e5f2 ("bpf: fix cb access in socket
filter programs"). Also add a comment to better clarify what is done in
bpf_skb
From: Shrikrishna Khare
Date: Wed, 6 Jan 2016 10:44:27 -0800
> Reported-by: Bingkuo Liu
> Signed-off-by: Shrikrishna Khare
Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http:/
On 06.01.2016 22:01, Jesse Gross wrote:
On Wed, Jan 6, 2016 at 12:25 PM, Hannes Frederic Sowa
wrote:
The refreshes from each module are completely synchronous and don't get
interleaved, so as long as the driver is correctly handling the locking
internally rtnl lock shouldn't be needed. But as I
On Wed, Jan 06, 2016 at 11:11:41PM +0300, Konstantin Khlebnikov wrote:
> On Wed, Jan 6, 2016 at 10:59 PM, Cong Wang wrote:
> > On Wed, Jan 6, 2016 at 11:15 AM, Konstantin Khlebnikov
> > wrote:
> >> Looks like this happens because ip_options_fragment() relies on
> >> correct ip options length in
On Wed, Jan 6, 2016 at 12:25 PM, Hannes Frederic Sowa
wrote:
> On 06.01.2016 20:52, Jesse Gross wrote:
>> On Wed, Jan 6, 2016 at 10:48 AM, Hannes Frederic Sowa
>> wrote:
>>> On 06.01.2016 19:00, Jesse Gross wrote:
Unfortunately, I don't think that we can assume that RTNL is held
here. I
From: Eric Dumazet
Date: Wed, 06 Jan 2016 06:53:50 -0800
> From: Eric Dumazet
>
> TX fast path uses ndo_start_xmit(), ndo_features_check() and
> ndo_select_queue().
>
> Move ndo_features_check() close to ndo_start_xmit() to increase
> data locality.
>
> All "struct net_device_ops" should now
From: David Wragg
Date: Wed, 6 Jan 2016 13:33:04 +
> Prior to 4.3, openvswitch vxlan vports could transmit vxlan packets of
> any size, constrained only by the ability to transmit the resulting
> UDP packets. 4.3 introduced vxlan netdevs corresponding to vxlan
> vports. These netdevs have
From: Kristian Evensen
Date: Wed, 6 Jan 2016 14:15:50 +0100
> From: Kristian Evensen
>
> The WeTelecom-WPD600N is an LTE module that, in addition to supporting most
> "normal" bands, also supports LTE over 450MHz. Manual testing showed that
> only interface number three replies to QMI messages
On (01/06/16 12:05), Tushar Dave wrote:
> commit c9f53e63c208 ("ixgbe: Refactor MAC address configuration code")
> introduced code that doesn't set HW register RAR0 to default mac address
> but FF:FF:FF:FF:FF:FF. Due to this, ixgbe HW discards all incoming packets
> that doesn't have destination m
Patch 3759824da87b ("tcp: PRR uses CRB mode by default and SS mode
conditionally") introduced a bug that cwnd may become 0 when both
inflight and sndcnt are 0 (cwnd = inflight + sndcnt). This may lead
to a div-by-zero if the connection starts another cwnd reduction
phase by setting tp->prior_cwnd t
On Wed, Jan 06, 2016 at 03:27:38PM -0500, David Miller wrote:
> From: Dan Carpenter
> Date: Wed, 6 Jan 2016 13:03:08 +0300
>
> > diff --git a/drivers/net/ethernet/freescale/fman/fman_sp.c
> > b/drivers/net/ethernet/freescale/fman/fman_sp.c
> > index f9e7aa3..b527da1 100644
> > --- a/drivers/net/
On Tue, Jan 05, 2016 at 09:55:58AM -0800, Alexei Starovoitov wrote:
> this one is better to be addressed in verifier instead of eBPF JITs.
> Please reject it in check_alu_op() instead.
AFAICS the eBPF verifier is not called on the eBPF filters generated by
the BPF->eBPF conversion in net/core/filt
Hello.
On 1/6/2016 5:55 PM, Alan wrote:
commit d79f16c046086f4fe0d42184a458e187464eb83e fixed a user triggerable
scripts/checkpatch.pl now enforces certain format of the commit citing.
scribble on free memory but added a new one which allows the user to
scribble even more and user contro
From: Dan Carpenter
Date: Wed, 6 Jan 2016 12:58:09 +0300
> pause_time is unsigned so it can't be less than zero. The bug means
> that we allow invalid pause-times.
>
> Fixes: 57ba4c9b56d8 ('fsl/fman: Add FMan MAC support')
> Signed-off-by: Dan Carpenter
Applied.
--
To unsubscribe from this li
From: Dan Carpenter
Date: Wed, 6 Jan 2016 12:59:10 +0300
> "priv" is allocated with devm_kzalloc() so freeing it here with kfree()
> will lead to a double free.
>
> Fixes: 3933961682a3 ('fsl/fman: Add FMan MAC driver')
> Signed-off-by: Dan Carpenter
Applied.
--
To unsubscribe from this list: s
From: Dan Carpenter
Date: Wed, 6 Jan 2016 13:03:08 +0300
> diff --git a/drivers/net/ethernet/freescale/fman/fman_sp.c
> b/drivers/net/ethernet/freescale/fman/fman_sp.c
> index f9e7aa3..b527da1 100644
> --- a/drivers/net/ethernet/freescale/fman/fman_sp.c
> +++ b/drivers/net/ethernet/freescale/fma
Hi Jesse,
hmpf, I saw your mail too late and send out another series just now.
On 06.01.2016 20:52, Jesse Gross wrote:
On Wed, Jan 6, 2016 at 10:48 AM, Hannes Frederic Sowa
wrote:
On 06.01.2016 19:00, Jesse Gross wrote:
On Wed, Jan 6, 2016 at 7:41 AM, Hannes Frederic Sowa
wrote:
diff --g
Signed-off-by: Hannes Frederic Sowa
---
drivers/net/geneve.c | 30 +++---
include/linux/netdevice.h | 1 +
include/net/geneve.h | 6 ++
3 files changed, 30 insertions(+), 7 deletions(-)
diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c
index 24b077a
Signed-off-by: Hannes Frederic Sowa
---
drivers/net/vxlan.c | 35 ++-
include/linux/netdevice.h | 2 +-
include/net/vxlan.h | 6 ++
3 files changed, 33 insertions(+), 10 deletions(-)
diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index fe
This small series adds a netdev_atomic notifier chain so that drivers can
callback to the core network stack requesting to reprogram the offloads
without depending on the geneve or vxlan modules.
* Result:
$ cd drivers/net/ethernet/
$ find . -name '*.ko' | xargs modinfo | egrep '^depends:.*(vxlan
This atomic notifier is later used by drivers to deliver callbacks to
the core network stack without requireing rtnl lock to be held.
Signed-off-by: Hannes Frederic Sowa
---
include/linux/netdevice.h | 9 +
net/core/dev.c| 24
2 files changed, 33 ins
On Wed, Jan 6, 2016 at 10:59 PM, Cong Wang wrote:
> On Wed, Jan 6, 2016 at 11:15 AM, Konstantin Khlebnikov
> wrote:
>> Looks like this happens because ip_options_fragment() relies on
>> correct ip options length in ip control block in skb. But in
>> ip_finish_output_gso() control block in segmen
From: Dan Carpenter
Date: Wed, 6 Jan 2016 12:56:30 +0300
> We checked "err" on the lines before so we know it's zero here.
>
> These cause a static checker warning because checking known things can
> indicate a bug. Maybe there is a missing assignment or we are checking
> the wrong variable.
>
From: Alan
Date: Wed, 06 Jan 2016 14:55:02 +
> commit d79f16c046086f4fe0d42184a458e187464eb83e fixed a user triggerable
> scribble on free memory but added a new one which allows the user to
> scribble even more and user controlled data into freed space.
>
> As with 6pack we need to halt the
commit c9f53e63c208 ("ixgbe: Refactor MAC address configuration code")
introduced code that doesn't set HW register RAR0 to default mac address
but FF:FF:FF:FF:FF:FF. Due to this, ixgbe HW discards all incoming packets
that doesn't have destination mac address equals to FF:FF:FF:FF:FF:FF.
This com
From: Jarod Wilson
Date: Wed, 6 Jan 2016 09:36:37 -0500
> This is based on the work done by Przemek Rudy in bug 70761 at
> bugzilla.kernel.org, but with some work done to disentagle and clarify
> things a bit.
>
> Similar to Przemek's work and other drivers, we're adding a padding of 16
> here,
Tom Herbert writes:
> Also, we don't do anything special for alignment, unaligned
> accesses on x86 do not appear to be a performance issue.
This is not true on Atom CPUs.
Also on most CPUs there is still a larger penalty when crossing
cache lines.
> Verified correctness by testing arbitrary l
From: Eric Dumazet
Date: Wed, 06 Jan 2016 05:57:24 -0800
> On Wed, 2016-01-06 at 00:18 -0800, Francesco Ruggeri wrote:
>> dst_release should not access dst->flags after decrementing
>> __refcnt to 0. The dst_entry may be in dst_busy_list and
>> dst_gc_task may dst_destroy it before dst_release ge
On Wed, Jan 6, 2016 at 11:15 AM, Konstantin Khlebnikov wrote:
> Looks like this happens because ip_options_fragment() relies on
> correct ip options length in ip control block in skb. But in
> ip_finish_output_gso() control block in segments is reused by
> skb_gso_segment(). following ip_fragment(
On Wed, Jan 6, 2016 at 10:48 AM, Hannes Frederic Sowa
wrote:
> On 06.01.2016 19:00, Jesse Gross wrote:
>>
>> On Wed, Jan 6, 2016 at 7:41 AM, Hannes Frederic Sowa
>> wrote:
>>>
>>> diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c
>>> index 24b077a32c1c9c..548925d1571cb1 100644
>>> --- a/dr
1 - 100 of 213 matches
Mail list logo
