[PATCH] au1000_eth.c power management and driver registration support

2006-07-19 Thread Rodolfo Giometti
Hello, Attached you can find my patch to add power managament and driver registration to the new version of file "drivers/net/au1000_eth.c" that implements the PHY-layer support. Ciao, Rodolfo Giometti Signed-off-by: Rodolfo Giometti <[EMAIL PROTECTED] -- GNU/Li

Re: [PATCH] au1000_eth.c Power Management, driver registration and module support

2006-05-31 Thread Rodolfo Giometti
On Wed, May 31, 2006 at 07:01:02PM +0400, Sergei Shtylyov wrote: > >Now that this is merged, Rodolfo's patch should probably preempt mine... > but it looks like something was lost during the transition: I failed to see > where SYS_PINFUNC register is actually read (the comment mentioning this

Generic netlink interface help

2007-05-24 Thread Rodolfo Giometti
Hello, I'm trying to use this new API for my LinuxPPS support but I have some difficulties in understanding the code! Looking at http://linux-net.osdl.org/index.php/Generic_Netlink_HOWTO is not clear... for example in line: msg_head = genlmsg_put(skb, pid, seq, type, 0, flags, DOC_EXMPL_C_ECH

Re: Generic netlink interface help

2007-05-24 Thread Rodolfo Giometti
On Thu, May 24, 2007 at 09:43:30AM -, Samuel Ortiz wrote: > You could look at Johannes Berg 802.11 generic netlink implementation for > a good example (net/wireless/nl80211.c in John Linville's tree): > http://git.kernel.org/?p=linux/kernel/git/linville/wireless-dev.git;a=blob;f=net/wireless/n

Re: Generic netlink interface help

2007-05-24 Thread Rodolfo Giometti
On Thu, May 24, 2007 at 10:04:08AM -, Samuel Ortiz wrote: > > Yes it's possible, even though it could be more tedious and painful. I know that. Have you some links to suggest to me in order to have some programming examples? Thanks, Rodolfo -- GNU/Linux Solutions e-mail:

Re: Generic netlink interface help

2007-05-27 Thread Rodolfo Giometti
On Sun, May 27, 2007 at 03:24:56PM +0200, Johannes Berg wrote: > > My current userland tool just send a message and expects back a > response. Obviously that's broken once we have events too, is that when Is that written by using the libnl or not? Can you please send to me it, or just a portion o

Re: Generic netlink interface help

2007-05-27 Thread Rodolfo Giometti
On Thu, May 24, 2007 at 09:43:30AM -, Samuel Ortiz wrote: > You could look at Johannes Berg 802.11 generic netlink implementation for > a good example (net/wireless/nl80211.c in John Linville's tree): > http://git.kernel.org/?p=linux/kernel/git/linville/wireless-dev.git;a=blob;f=net/wireless/n

Re: Generic netlink interface help

2007-05-27 Thread Rodolfo Giometti
On Sun, May 27, 2007 at 03:54:30PM +0200, Johannes Berg wrote: > It's written in python without using libnl: > http://git.sipsolutions.net/pynl80211.git If I well understand I should do something like this: s = socket(PF_NETLINK, SOCK_RAW, NETLINK_GENERIC); memset(&src_addr, 0,

Re: Generic netlink interface help

2007-05-28 Thread Rodolfo Giometti
On Mon, May 28, 2007 at 04:42:47AM +0300, Samuel Ortiz wrote: > > > > Is that right? > At first glance, this could work yes. Great! Now I have only to write the userland tool. :) > However, it seems you're trying to encapsulate your pps_netlink_msg into > a generic netlink message which itself i

Re: [PATCH] au1000_eth.c Power Management, driver registration and module support

2006-05-02 Thread Rodolfo Giometti
Hello, here: http://ftp.enneenne.com/pub/misc/au1100-patches/linux/patch-au1000_eth-pm-and-registration the new version of my patch for au1000_eth.c who should implement: * Module support. -bool "MIPS AU1000 Ethernet support" +tristate "MIPS AU1000 Ethernet support" * Driver

Re: [PATCH] au1000_eth.c Power Management, driver registration and module support

2006-05-03 Thread Rodolfo Giometti
Hello, yesterday I did a little mess with GIT... now the patch is complete. Sorry. :) I forgot also to say that it has been done against «linux-2.6.16-stable» branch. Ciao, Rodolfo -- GNU/Linux Solutions e-mail:[EMAIL PROTECTED] Linux Device Driver

Re: [PATCH -next] pps: using ERR_PTR instead of NULL while pps_register_source fails

2018-11-26 Thread Rodolfo Giometti
On 26/11/2018 11:24, YueHaibing wrote: pps_register_source() has keeps error codes in a local variable, but it does not make use of the code. This patch let it return the errcode in case of failure. Suggested-by: Richard Cochran Signed-off-by: YueHaibing Acked-by: Rodolfo Giometti

Re: [PATCH -next] pps: using ERR_PTR instead of NULL while pps_register_source fails

2018-11-27 Thread Rodolfo Giometti
On 27/11/2018 08:34, Greg KH wrote: On Mon, Nov 26, 2018 at 11:43:06AM +0100, Rodolfo Giometti wrote: On 26/11/2018 11:24, YueHaibing wrote: pps_register_source() has keeps error codes in a local variable, but it does not make use of the code. This patch let it return the errcode in case of

Re: Possible bug into DSA2 code.

2019-02-09 Thread Rodolfo Giometti
Hello, I'm working with EPRESSObin and DSA2 where I added the ability to dynamically load and unload switch configurations by using DT-overlay (a patchwork from here https://lore.kernel.org/patchwork/patch/468129/). During my tests I notice that when I remove the overlay in order to disable th

Re: Possible bug into DSA2 code.

2019-02-10 Thread Rodolfo Giometti
On 09/02/2019 20:34, Andrew Lunn wrote: So we I see two possible solutions: 1) having both ds->slave_mii_bus and ds->ops->phy_read already defined is an error, then it must be signaled to the calling code, or I don't think we can do that. mv88e6xxx optionally instantiates the MDIO busses, depe

Re: Possible bug into DSA2 code.

2019-02-11 Thread Rodolfo Giometti
On 11/02/2019 18:28, Florian Fainelli wrote: On 2/10/19 3:45 AM, Rodolfo Giometti wrote: On 09/02/2019 20:34, Andrew Lunn wrote: So we I see two possible solutions: 1) having both ds->slave_mii_bus and ds->ops->phy_read already defined is an error, then it must be signaled to the cal

Re: Possible bug into DSA2 code.

2019-02-18 Thread Rodolfo Giometti
On 11/02/2019 20:13, Florian Fainelli wrote: Does that work: diff --git a/net/dsa/dsa2.c b/net/dsa/dsa2.c index a1917025e155..54cf6a5c865d 100644 --- a/net/dsa/dsa2.c +++ b/net/dsa/dsa2.c @@ -368,6 +368,9 @@ static int dsa_switch_setup(struct dsa_switch *ds) if (err) re

Re: Possible bug into DSA2 code.

2019-02-19 Thread Rodolfo Giometti
On 19/02/2019 01:03, Andrew Lunn wrote: diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index 54a5b660640a..bb46ebbb2bb8 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -2399,7 +2399,7 @@ static int mv88e6xxx_setup(struct ds