[PATCH V2] tipc: Use bsearch library function

2017-09-16 Thread Thomas Meyer
Use common library function rather than explicitly coding some variant of it yourself. Signed-off-by: Thomas Meyer --- net/tipc/name_table.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) V2: Coding style diff --git a/net/tipc/name_table.c b/net/tipc/nam

Re: [PATCH V2] tipc: Use bsearch library function

2017-09-16 Thread Ying Xue
On 09/16/2017 03:50 PM, Thomas Meyer wrote: > Use common library function rather than explicitly coding > some variant of it yourself. > > Signed-off-by: Thomas Meyer Acked-by: Ying Xue > --- > net/tipc/name_table.c | 30 +++--- > 1 file changed, 15 insertions(+), 15 d

Re: [PATCH V2] tipc: Use bsearch library function

2017-09-16 Thread Joe Perches
On Sat, 2017-09-16 at 17:02 +0800, Ying Xue wrote: > On 09/16/2017 03:50 PM, Thomas Meyer wrote: > > Use common library function rather than explicitly coding > > some variant of it yourself. > > > > Signed-off-by: Thomas Meyer > > Acked-by: Ying Xue Are you sure you want to do this? Note the

Re: [PATCH V2] tipc: Use bsearch library function

2017-09-16 Thread Ying Xue
On 09/16/2017 05:26 PM, Joe Perches wrote: > On Sat, 2017-09-16 at 17:02 +0800, Ying Xue wrote: >> On 09/16/2017 03:50 PM, Thomas Meyer wrote: >>> Use common library function rather than explicitly coding >>> some variant of it yourself. >>> >>> Signed-off-by: Thomas Meyer >> >> Acked-by: Ying Xue

Re: [PATCH V2] tipc: Use bsearch library function

2017-09-16 Thread Joe Perches
On Sat, 2017-09-16 at 17:36 +0800, Ying Xue wrote: > On 09/16/2017 05:26 PM, Joe Perches wrote: > > On Sat, 2017-09-16 at 17:02 +0800, Ying Xue wrote: > > > On 09/16/2017 03:50 PM, Thomas Meyer wrote: > > > > Use common library function rather than explicitly coding > > > > some variant of it yours

Re: [PATCH V2] tipc: Use bsearch library function

2017-09-16 Thread Ying Xue
On 09/16/2017 05:58 PM, Joe Perches wrote: > On Sat, 2017-09-16 at 17:36 +0800, Ying Xue wrote: >> On 09/16/2017 05:26 PM, Joe Perches wrote: >>> On Sat, 2017-09-16 at 17:02 +0800, Ying Xue wrote: On 09/16/2017 03:50 PM, Thomas Meyer wrote: > Use common library function rather than explici

Re: [PATCH V2] tipc: Use bsearch library function

2017-09-16 Thread Joe Perches
On Sat, 2017-09-16 at 18:10 +0800, Ying Xue wrote: > On 09/16/2017 05:58 PM, Joe Perches wrote: > > On Sat, 2017-09-16 at 17:36 +0800, Ying Xue wrote: > > > On 09/16/2017 05:26 PM, Joe Perches wrote: > > > > On Sat, 2017-09-16 at 17:02 +0800, Ying Xue wrote: > > > > > On 09/16/2017 03:50 PM, Thomas

RE: [PATCH V2] tipc: Use bsearch library function

2017-09-16 Thread Jon Maloy
ourceforge.net; linux- > ker...@vger.kernel.org; da...@davemloft.net > Subject: Re: [PATCH V2] tipc: Use bsearch library function > > On Sat, 2017-09-16 at 18:10 +0800, Ying Xue wrote: > > On 09/16/2017 05:58 PM, Joe Perches wrote: > > > On Sat, 2017-09-16 at 17:36 +0800, Yin

Re: [PATCH V2] tipc: Use bsearch library function

2017-09-17 Thread Thomas Meyer
> Am 16.09.2017 um 15:20 schrieb Jon Maloy . >> >> What part of "very time critical" have you verified and benchmarked as >> inconsequential? >> >> Please post your results. > > I agree with Joe here. This change does not simplify anything, it does not > reduce the amount of code, plus that it

RE: [PATCH V2] tipc: Use bsearch library function

2017-09-17 Thread Jon Maloy
oft.net > Subject: Re: [PATCH V2] tipc: Use bsearch library function > > > > Am 16.09.2017 um 15:20 schrieb Jon Maloy . > >> > >> What part of "very time critical" have you verified and benchmarked as > >> inconsequential? > >> > >

Re: [PATCH V2] tipc: Use bsearch library function

2017-09-17 Thread Joe Perches
On Sun, 2017-09-17 at 16:27 +, Jon Maloy wrote: > > -Original Message- > > From: Thomas Meyer [mailto:tho...@m3y3r.de] [] > > What about the other binary search implementation in the same file? Should > > I try to convert it it will it get NAKed for performance reasons too? > > The sea

RE: [PATCH V2] tipc: Use bsearch library function

2017-09-18 Thread Jon Maloy
s.sourceforge.net; linux-ker...@vger.kernel.org; > da...@davemloft.net > Subject: Re: [PATCH V2] tipc: Use bsearch library function > > On Sun, 2017-09-17 at 16:27 +, Jon Maloy wrote: > > > -Original Message- > > > From: Thomas Meyer [mailto:tho...@m