[GitHub] wu-sheng commented on issue #2083: Support redisson plugin

wu-sheng commented on issue #2083: Support redisson plugin URL: https://github.com/apache/incubator-skywalking/pull/2083#issuecomment-453459619 @zhaoyuguang @WithLin any of you could work on lettuce redis client? This is an a

[GitHub] wu-sheng commented on issue #2104: Support spring-rabbit plugin for 1.x and 2.x

wu-sheng commented on issue #2104: Support spring-rabbit plugin for 1.x and 2.x URL: https://github.com/apache/incubator-skywalking/pull/2104#issuecomment-453459374 Any update? This is an automated message from the Apache Gi

[GitHub] zhaoyuguang opened a new pull request #2147: Bugfix: logger information has not enough arguments

zhaoyuguang opened a new pull request #2147: Bugfix: logger information has not enough arguments URL: https://github.com/apache/incubator-skywalking/pull/2147 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ] New fe

[GitHub] zhaoyuguang commented on issue #2083: Support redisson plugin

zhaoyuguang commented on issue #2083: Support redisson plugin URL: https://github.com/apache/incubator-skywalking/pull/2083#issuecomment-453487349 I researched lettuce, lettuce was widely popular after the 5.x version, I will try to write a letuce plugin based on the most popular version

[GitHub] zhaoyuguang edited a comment on issue #2083: Support redisson plugin

zhaoyuguang edited a comment on issue #2083: Support redisson plugin URL: https://github.com/apache/incubator-skywalking/pull/2083#issuecomment-453487349 I researched lettuce, the lettuce architecture is similar to redisson, lettuce was widely popular after the 5.x version, I will try to w

[GitHub] zhaoyuguang edited a comment on issue #2083: Support redisson plugin

zhaoyuguang edited a comment on issue #2083: Support redisson plugin URL: https://github.com/apache/incubator-skywalking/pull/2083#issuecomment-453487349 I researched lettuce, the lettuce architecture is similar to redisson, lettuce was widely popular after the 5.x version, I will try to w

[incubator-skywalking] branch inventory-extend updated: Fix code bugs

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch inventory-extend in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git The following commit(s) were added to refs/heads/inventory-extend by this push: new 95229cd Fix

[GitHub] wu-sheng commented on issue #2083: Support redisson plugin

wu-sheng commented on issue #2083: Support redisson plugin URL: https://github.com/apache/incubator-skywalking/pull/2083#issuecomment-453495653 I think 5.x or 5.1x is good enough. This is an automated message from the Apache

[GitHub] wu-sheng closed pull request #2147: Bugfix: logger information has not enough arguments

wu-sheng closed pull request #2147: Bugfix: logger information has not enough arguments URL: https://github.com/apache/incubator-skywalking/pull/2147 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[incubator-skywalking] branch master updated: Bugfix: logger information has not enough arguments (#2147)

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git The following commit(s) were added to refs/heads/master by this push: new 20aa7f9 Bugfix: logger informati

[GitHub] zhaoyuguang commented on issue #2083: Support redisson plugin

zhaoyuguang commented on issue #2083: Support redisson plugin URL: https://github.com/apache/incubator-skywalking/pull/2083#issuecomment-453500119 Yeah~ let me try.. This is an automated message from the Apache Git Servic

[incubator-skywalking] branch inventory-extend updated: Provide develop doc for inventory extension.

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch inventory-extend in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git The following commit(s) were added to refs/heads/inventory-extend by this push: new abfede8 Prov

[GitHub] wu-sheng opened a new pull request #2148: Support service inventory extension fields in json format

wu-sheng opened a new pull request #2148: Support service inventory extension fields in json format URL: https://github.com/apache/incubator-skywalking/pull/2148 For service inventory extension, I add an extension point in service inventory entity. It is in JSON format, but it could only b

[GitHub] wu-sheng commented on issue #2148: Support service inventory extension fields in json format

wu-sheng commented on issue #2148: Support service inventory extension fields in json format URL: https://github.com/apache/incubator-skywalking/pull/2148#issuecomment-453503585 # Backend Inventory Entity Extension SkyWalking includes four inventory entities. - Service Inventory -

[GitHub] wu-sheng commented on issue #2148: Support service inventory extension fields in json format

wu-sheng commented on issue #2148: Support service inventory extension fields in json format URL: https://github.com/apache/incubator-skywalking/pull/2148#issuecomment-453503703 FYI @peng-yongsheng @hanahmily @JaredTan95 I think you may be interested about this. -

[incubator-skywalking] branch inventory-extend updated (abfede8 -> 3d7c4b8)

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch inventory-extend in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git. from abfede8 Provide develop doc for inventory extension. add 20aa7f9 Bugfix: logger infor

[GitHub] wu-sheng edited a comment on issue #2148: Support service inventory extension fields in json format

wu-sheng edited a comment on issue #2148: Support service inventory extension fields in json format URL: https://github.com/apache/incubator-skywalking/pull/2148#issuecomment-453503703 FYI @peng-yongsheng @hanahmily @JaredTan95 I think you may be interested about this. Feel free to review

[GitHub] coveralls edited a comment on issue #2083: Support redisson plugin

coveralls edited a comment on issue #2083: Support redisson plugin URL: https://github.com/apache/incubator-skywalking/pull/2083#issuecomment-450781853 [](https://coveralls.io/builds/21023745) Coverage decreased (-0.0

[GitHub] ascrutae commented on a change in pull request #2083: Support redisson plugin

ascrutae commented on a change in pull request #2083: Support redisson plugin URL: https://github.com/apache/incubator-skywalking/pull/2083#discussion_r247108182 ## File path: apm-sniffer/apm-sdk-plugin/redisson-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/redisson/v3/

[GitHub] coveralls commented on issue #2148: Support service inventory extension fields in json format

coveralls commented on issue #2148: Support service inventory extension fields in json format URL: https://github.com/apache/incubator-skywalking/pull/2148#issuecomment-453512380 [](https://coveralls.io/builds/21024035)

[GitHub] ascrutae commented on issue #2083: Support redisson plugin

ascrutae commented on issue #2083: Support redisson plugin URL: https://github.com/apache/incubator-skywalking/pull/2083#issuecomment-453512334 Is this plugin only interceptor part that Redssion as easy java redis client, and other part is not support? if so, I suggest that you should make

[GitHub] wu-sheng closed pull request #2148: Support service inventory extension fields in json format

wu-sheng closed pull request #2148: Support service inventory extension fields in json format URL: https://github.com/apache/incubator-skywalking/pull/2148 This is an automated message from the Apache Git Service. To respond

[incubator-skywalking] branch master updated: Support service inventory extension fields in json format (#2148)

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git The following commit(s) were added to refs/heads/master by this push: new 9cc5e76 Support service inventor

[incubator-skywalking] branch inventory-extend deleted (was 3d7c4b8)

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch inventory-extend in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git. was 3d7c4b8 Merge branch 'master' into inventory-extend The revisions that were on this branch

[GitHub] wu-sheng commented on issue #2083: Support redisson plugin

wu-sheng commented on issue #2083: Support redisson plugin URL: https://github.com/apache/incubator-skywalking/pull/2083#issuecomment-453516722 > Is this plugin only interceptor part that Redssion as easy java redis client, and other part is not support? Could you be more clear? @a

[GitHub] zhaoyuguang commented on a change in pull request #2083: Support redisson plugin

zhaoyuguang commented on a change in pull request #2083: Support redisson plugin URL: https://github.com/apache/incubator-skywalking/pull/2083#discussion_r247116395 ## File path: apm-sniffer/apm-sdk-plugin/redisson-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/redisson/

[GitHub] zhaoyuguang commented on issue #2083: Support redisson plugin

zhaoyuguang commented on issue #2083: Support redisson plugin URL: https://github.com/apache/incubator-skywalking/pull/2083#issuecomment-453518382 > Is this plugin only interceptor part that Redssion as easy java redis client, and other part is not support? if so, I suggest that you should

[GitHub] wu-sheng commented on a change in pull request #2083: Support redisson plugin

wu-sheng commented on a change in pull request #2083: Support redisson plugin URL: https://github.com/apache/incubator-skywalking/pull/2083#discussion_r247117091 ## File path: apm-sniffer/apm-sdk-plugin/redisson-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/redisson/v3/

[GitHub] zhaoyuguang edited a comment on issue #2083: Support redisson plugin

zhaoyuguang edited a comment on issue #2083: Support redisson plugin URL: https://github.com/apache/incubator-skywalking/pull/2083#issuecomment-453518382 > Is this plugin only interceptor part that Redssion as easy java redis client, and other part is not support? if so, I suggest that you

[GitHub] zhaoyuguang commented on a change in pull request #2083: Support redisson plugin

zhaoyuguang commented on a change in pull request #2083: Support redisson plugin URL: https://github.com/apache/incubator-skywalking/pull/2083#discussion_r247119170 ## File path: apm-sniffer/apm-sdk-plugin/redisson-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/redisson/

[GitHub] wu-sheng commented on issue #2083: Support redisson plugin

wu-sheng commented on issue #2083: Support redisson plugin URL: https://github.com/apache/incubator-skywalking/pull/2083#issuecomment-453520886 > Only intercepted redisson's operation on redis. From the official website, https://redisson.org/, it have 7 use cases, which all include

[GitHub] ascrutae commented on a change in pull request #2083: Support redisson plugin

ascrutae commented on a change in pull request #2083: Support redisson plugin URL: https://github.com/apache/incubator-skywalking/pull/2083#discussion_r247120886 ## File path: apm-sniffer/apm-sdk-plugin/redisson-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/redisson/v3/

[GitHub] ascrutae edited a comment on issue #2083: Support redisson plugin

ascrutae edited a comment on issue #2083: Support redisson plugin URL: https://github.com/apache/incubator-skywalking/pull/2083#issuecomment-453512334 Is this plugin only intercept the part that Redssion as easy java redis client, and other part is not support? if so, I suggest that you sh

[GitHub] zhaoyuguang commented on issue #2083: Support redisson plugin

zhaoyuguang commented on issue #2083: Support redisson plugin URL: https://github.com/apache/incubator-skywalking/pull/2083#issuecomment-453523311 > > Only intercepted redisson's operation on redis. > > From the official website, https://redisson.org/, it have 7 use cases, which all

[GitHub] coveralls edited a comment on issue #2083: Support redisson plugin

coveralls edited a comment on issue #2083: Support redisson plugin URL: https://github.com/apache/incubator-skywalking/pull/2083#issuecomment-450781853 [](https://coveralls.io/builds/21024960) Coverage decreased (-0.0

[GitHub] coveralls edited a comment on issue #2083: Support redisson plugin

coveralls edited a comment on issue #2083: Support redisson plugin URL: https://github.com/apache/incubator-skywalking/pull/2083#issuecomment-450781853 [](https://coveralls.io/builds/21025435) Coverage decreased (-0.0

[GitHub] wu-sheng closed pull request #2083: Support redisson plugin

wu-sheng closed pull request #2083: Support redisson plugin URL: https://github.com/apache/incubator-skywalking/pull/2083 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull r

[incubator-skywalking] branch master updated: Support redisson plugin (#2083)

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git The following commit(s) were added to refs/heads/master by this push: new 43b216a Support redisson plugin

[GitHub] wu-sheng closed issue #1564: does skywalking support trace redisson?

wu-sheng closed issue #1564: does skywalking support trace redisson? URL: https://github.com/apache/incubator-skywalking/issues/1564 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] JaredTan95 opened a new pull request #10: add serviceInstanceId in TraceQueryCondition.

JaredTan95 opened a new pull request #10: add serviceInstanceId in TraceQueryCondition. URL: https://github.com/apache/incubator-skywalking-query-protocol/pull/10 main repo related PR: https://github.com/apache/incubator-skywalking/pull/2146 ---

[GitHub] wu-sheng closed pull request #10: add serviceInstanceId in TraceQueryCondition.

wu-sheng closed pull request #10: add serviceInstanceId in TraceQueryCondition. URL: https://github.com/apache/incubator-skywalking-query-protocol/pull/10 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provena

[incubator-skywalking-query-protocol] branch master updated: add serviceInstanceId in TraceQueryCondition. (#10)

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-skywalking-query-protocol.git The following commit(s) were added to refs/heads/master by this push: new a5137b7 add serv

[GitHub] coveralls commented on issue #2146: add serviceInstanceId in Segment storage.

coveralls commented on issue #2146: add serviceInstanceId in Segment storage. URL: https://github.com/apache/incubator-skywalking/pull/2146#issuecomment-453543563 [](https://coveralls.io/builds/21025943) Coverage decr

[GitHub] liyongfa0311 opened a new issue #2149: Why is my link broken into two?

liyongfa0311 opened a new issue #2149: Why is my link broken into two? URL: https://github.com/apache/incubator-skywalking/issues/2149 Please answer these questions before submitting your issue. - Why do you submit this issue? - [x] Question or discussion - [ ] Bug - [ ] Req

[GitHub] JaredTan95 opened a new issue #2150: [Proposal] Make Traces Data Query association with serviceInstanceId

JaredTan95 opened a new issue #2150: [Proposal] Make Traces Data Query association with serviceInstanceId URL: https://github.com/apache/incubator-skywalking/issues/2150 Hi, Based on the existing `QraphQL` API, we can query traces with serviceInstanceId. @TinyAllen ,If you are interesti

[GitHub] wu-sheng commented on issue #2149: Why is my link broken into two?

wu-sheng commented on issue #2149: Why is my link broken into two? URL: https://github.com/apache/incubator-skywalking/issues/2149#issuecomment-453548818 If `10.102.131.151:10008` is already instrumented by agent, it means the rpc between project-e and project-mysql is using the protocol S

[GitHub] wu-sheng closed issue #2149: Why is my link broken into two?

wu-sheng closed issue #2149: Why is my link broken into two? URL: https://github.com/apache/incubator-skywalking/issues/2149 This is an automated message from the Apache Git Service. To respond to the message, please log on G

[GitHub] wu-sheng commented on issue #2150: [Proposal] Make Traces Data Query association with serviceInstanceId

wu-sheng commented on issue #2150: [Proposal] Make Traces Data Query association with serviceInstanceId URL: https://github.com/apache/incubator-skywalking/issues/2150#issuecomment-453555380 Add a selector for service instance, list all instance if the service selected. And this is an o

[GitHub] coveralls edited a comment on issue #2146: add serviceInstanceId in Segment storage.

coveralls edited a comment on issue #2146: add serviceInstanceId in Segment storage. URL: https://github.com/apache/incubator-skywalking/pull/2146#issuecomment-453543563 [](https://coveralls.io/builds/21026733) Cover

[GitHub] yannxia commented on a change in pull request #2148: Support service inventory extension fields in json format

yannxia commented on a change in pull request #2148: Support service inventory extension fields in json format URL: https://github.com/apache/incubator-skywalking/pull/2148#discussion_r247190370 ## File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/co

[GitHub] yannxia commented on a change in pull request #2148: Support service inventory extension fields in json format

yannxia commented on a change in pull request #2148: Support service inventory extension fields in json format URL: https://github.com/apache/incubator-skywalking/pull/2148#discussion_r247190370 ## File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/co

[GitHub] wu-sheng commented on a change in pull request #2148: Support service inventory extension fields in json format

wu-sheng commented on a change in pull request #2148: Support service inventory extension fields in json format URL: https://github.com/apache/incubator-skywalking/pull/2148#discussion_r247298369 ## File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/c

[GitHub] yannxia opened a new pull request #2151: Improve unessential gson instance

yannxia opened a new pull request #2151: Improve unessential gson instance URL: https://github.com/apache/incubator-skywalking/pull/2151 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature provided - [✓]

[GitHub] JaredTan95 closed pull request #2151: Improve unessential gson instance

JaredTan95 closed pull request #2151: Improve unessential gson instance URL: https://github.com/apache/incubator-skywalking/pull/2151 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a fo

[GitHub] coveralls commented on issue #2151: Improve unessential gson instance

coveralls commented on issue #2151: Improve unessential gson instance URL: https://github.com/apache/incubator-skywalking/pull/2151#issuecomment-453717360 [](https://coveralls.io/builds/21037128) Coverage decreased (-

[incubator-skywalking] branch master updated: Fix unessential gson instance (#2151)

This is an automated email from the ASF dual-hosted git repository. tanjian pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git The following commit(s) were added to refs/heads/master by this push: new f9fb693 Fix unessential gson ins