[PATCH] Ignore encrypted parts when indexing.

2011-12-27 Thread Austin Clements
Quoth Jameson Graef Rollins on Dec 27 at 9:11 am: > It appears to be an oversight that encrypted parts were indexed > previously. The terms generated from encrypted parts are meaningless > and do nothing but add bloat to the database. It is not worth > indexing the encrypted content, just as it'

[PATCH] emacs: Don't attempt to colour tags in `notmuch-show-mode'.

2011-12-27 Thread Austin Clements
LGTM. Quoth David Edmondson on Dec 27 at 4:47 pm: > The tags were coloured using text properties. Unfortunately that text > (the header line) also has an overlay, which overrides the text > properties. There's not point in applying text properties that will > never be seen. > --- > emacs/notmuch

[PATCH 2/4] Introduce a generic tree-like abstraction for MIME traversal.

2011-12-27 Thread Austin Clements
Quoth Daniel Kahn Gillmor on Dec 27 at 9:27 am: > On 12/23/2011 10:45 PM, Austin Clements wrote: > > Quoth Dmitry Kurochkin on Dec 10 at 3:25 am: > >> + /* For some reason the GMimeSignatureValidity returned > >> +* here is not a const (inconsistent with that > >> +

[PATCH] emacs: Add `notmuch-show-line-faces' and apply it.

2011-12-27 Thread Jani Nikula
On Tue, 27 Dec 2011 17:13:23 +, David Edmondson wrote: > Similar to `notmuch-search-line-faces', `notmuch-show-line-faces' > allows the header line in `notmuch-show-mode' buffers to be coloured > according to the tags of the message. Hi David, I've only given this a quick test drive, but so f

list of notmuch frontend

2011-12-27 Thread Xavier Maillard
On Tue, 27 Dec 2011 21:29:33 +0100, Antoine Amarilli wrote: > > Out of curiosity, how can people contribute to the "wiki" ? I do not see > > any 'Edit this page' button. > > It's a git repository which you can clone, edit and push back. See > (linked at

list of notmuch frontend

2011-12-27 Thread Xavier Maillard
On Mon, 26 Dec 2011 22:12:52 +0100, Antoine Amarilli wrote: > On Sun, Dec 18, 2011 at 06:10:13PM +0200, Tomi Ollila wrote: > > On Sun, 18 Dec 2011 15:34:23 +0100, Olivier Schwander > chadok.info> wrote: > > > Is there a somewhere a list of the various notmuch frontend ? It would > > > be very val

list of notmuch frontend

2011-12-27 Thread Antoine Amarilli
next part -- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 198 bytes Desc: Digital signature URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111227/a2426e52/attachment.pgp>

[PATCH] emacs: Cycle through notmuch buffers rather than jumping to the last.

2011-12-27 Thread Jani Nikula
On Tue, 27 Dec 2011 10:50:44 +, David Edmondson wrote: > As suggested by j4ni in #notmuch, rename > `notmuch-jump-to-recent-buffer' as `notmuch-cycle-notmuch-buffers' and > have it behave accordingly. Hi David, thanks for submitting this. It works nicely, and IMHO it's *much* more useful than

Re: [PATCH] Ignore encrypted parts when indexing.

2011-12-27 Thread Austin Clements
Quoth Jameson Graef Rollins on Dec 27 at 9:11 am: > It appears to be an oversight that encrypted parts were indexed > previously. The terms generated from encrypted parts are meaningless > and do nothing but add bloat to the database. It is not worth > indexing the encrypted content, just as it'

Re: [PATCH] emacs: Don't attempt to colour tags in `notmuch-show-mode'.

2011-12-27 Thread Austin Clements
LGTM. Quoth David Edmondson on Dec 27 at 4:47 pm: > The tags were coloured using text properties. Unfortunately that text > (the header line) also has an overlay, which overrides the text > properties. There's not point in applying text properties that will > never be seen. > --- > emacs/notmuch

Re: [PATCH 2/4] Introduce a generic tree-like abstraction for MIME traversal.

2011-12-27 Thread Austin Clements
Quoth Daniel Kahn Gillmor on Dec 27 at 9:27 am: > On 12/23/2011 10:45 PM, Austin Clements wrote: > > Quoth Dmitry Kurochkin on Dec 10 at 3:25 am: > >> + /* For some reason the GMimeSignatureValidity returned > >> +* here is not a const (inconsistent with that > >> +

[PATCH v3 3/3] test: emacs: test notmuch-wash-subject-to-* functions

2011-12-27 Thread Jani Nikula
Signed-off-by: Jani Nikula --- test/emacs-subject-to-filename | 138 test/notmuch-test |1 + 2 files changed, 139 insertions(+), 0 deletions(-) create mode 100755 test/emacs-subject-to-filename diff --git a/test/emacs-subject-to-filenam

[PATCH v3 2/3] emacs: create patch filename from subject for inline patch fake parts

2011-12-27 Thread Jani Nikula
Use the mail subject line for creating a descriptive filename for the wash generated inline patch fake parts. The names are similar to the ones created by 'git format-patch'. If the user has notmuch-wash-convert-inline-patch-to-part hook enabled in notmuch-show-insert-text/plain-hook, this will ch

[PATCH v3 1/3] emacs: add inline patch fake parts through a special handler

2011-12-27 Thread Jani Nikula
Add wash generated inline patch fake parts through a special "inline-patch-fake-part" handler to distinguish them from real MIME parts. The fake parts are described as "inline patch (as text/x-diff)". Signed-off-by: Jani Nikula --- emacs/notmuch-show.el |4 emacs/notmuch-wash.el |2

[PATCH v3 0/3] emacs: patch filename from subject

2011-12-27 Thread Jani Nikula
Hi all, v3 with the following changes: * new patch 1/3 to add fake parts through a special handler to make them stand out from real MIME parts * make notmuch-wash-subject-to-patch-filename more lispy as suggested by David in id:"cun62h3tu51.fsf at hotblack-desiato.hh.sledj.net" BR, Jani. Ja

[PATCH] emacs: Add `notmuch-show-line-faces' and apply it.

2011-12-27 Thread David Edmondson
Similar to `notmuch-search-line-faces', `notmuch-show-line-faces' allows the header line in `notmuch-show-mode' buffers to be coloured according to the tags of the message. --- emacs/notmuch-lib.el | 18 ++ emacs/notmuch-show.el | 32 emacs/not

[PATCH] emacs: Don't attempt to colour tags in `notmuch-show-mode'.

2011-12-27 Thread David Edmondson
The tags were coloured using text properties. Unfortunately that text (the header line) also has an overlay, which overrides the text properties. There's not point in applying text properties that will never be seen. --- emacs/notmuch-show.el |8 ++-- 1 files changed, 2 insertions(+), 6 de

Re: list of notmuch frontend

2011-12-27 Thread Xavier Maillard
On Tue, 27 Dec 2011 21:29:33 +0100, Antoine Amarilli wrote: > > Out of curiosity, how can people contribute to the "wiki" ? I do not see > > any 'Edit this page' button. > > It's a git repository which you can clone, edit and push back. See > (linked at

Re: list of notmuch frontend

2011-12-27 Thread Antoine Amarilli
On Tue, Dec 27, 2011 at 09:43:50PM +0100, Xavier Maillard wrote: > On Mon, 26 Dec 2011 22:12:52 +0100, Antoine Amarilli wrote: > > On Sun, Dec 18, 2011 at 06:10:13PM +0200, Tomi Ollila wrote: > > > On Sun, 18 Dec 2011 15:34:23 +0100, Olivier Schwander > > > wrote: > > > > Is there a somewhere a

Re: list of notmuch frontend

2011-12-27 Thread Xavier Maillard
On Mon, 26 Dec 2011 22:12:52 +0100, Antoine Amarilli wrote: > On Sun, Dec 18, 2011 at 06:10:13PM +0200, Tomi Ollila wrote: > > On Sun, 18 Dec 2011 15:34:23 +0100, Olivier Schwander > > wrote: > > > Is there a somewhere a list of the various notmuch frontend ? It would > > > be very valuable for

[PATCH] emacs: Enable more text/plain hook functions by default.

2011-12-27 Thread Jani Nikula
On Tue, 27 Dec 2011 12:00:25 +, David Edmondson wrote: > Users are missing out on various functions which usefully improve the > display of text/plain message parts because they are not enabled by > default. Enable a useful set. While I didn't try the patch, I'm very much in favour of having

[PATCH] emacs: Enable more text/plain hook functions by default.

2011-12-27 Thread David Edmondson
Users are missing out on various functions which usefully improve the display of text/plain message parts because they are not enabled by default. Enable a useful set. `notmuch-wash-convert-inline-patch-to-part' is _not_ enabled by default as it is based on a heuristic. --- emacs/notmuch-show.el

Re: [PATCH] emacs: Add `notmuch-show-line-faces' and apply it.

2011-12-27 Thread Jani Nikula
On Tue, 27 Dec 2011 17:13:23 +, David Edmondson wrote: > Similar to `notmuch-search-line-faces', `notmuch-show-line-faces' > allows the header line in `notmuch-show-mode' buffers to be coloured > according to the tags of the message. Hi David, I've only given this a quick test drive, but so f

Re: [PATCH] emacs: Cycle through notmuch buffers rather than jumping to the last.

2011-12-27 Thread Jani Nikula
On Tue, 27 Dec 2011 10:50:44 +, David Edmondson wrote: > As suggested by j4ni in #notmuch, rename > `notmuch-jump-to-recent-buffer' as `notmuch-cycle-notmuch-buffers' and > have it behave accordingly. Hi David, thanks for submitting this. It works nicely, and IMHO it's *much* more useful than

[PATCH] emacs: Cycle through notmuch buffers rather than jumping to the last.

2011-12-27 Thread David Edmondson
cent-buffer' in the NEWS file - it should go away soon after 0.11 ships. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmu

[PATCH] emacs: Cycle through notmuch buffers rather than jumping to the last.

2011-12-27 Thread David Edmondson
As suggested by j4ni in #notmuch, rename `notmuch-jump-to-recent-buffer' as `notmuch-cycle-notmuch-buffers' and have it behave accordingly. --- emacs/notmuch.el | 39 +++ 1 files changed, 27 insertions(+), 12 deletions(-) diff --git a/emacs/notmuch.el b/emacs

[PATCH 3/3] test: Correct the expected output of the 'invalid From' test.

2011-12-27 Thread David Edmondson
--- test/emacs |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/test/emacs b/test/emacs index bb4a75f..0168f85 100755 --- a/test/emacs +++ b/test/emacs @@ -78,7 +78,7 @@ thread=$(notmuch search --output=threads subject:message-with-invalid-from) test_emacs "(notmuch-show

[PATCH 2/3] emacs: Avoid `mail-header-parse-address' in `notmuch-show-clean-address'.

2011-12-27 Thread David Edmondson
`mail-header-parse-address' expects un-decoded mailbox parts, which is not what we have at this point. Replace it with simple string deconstruction. --- emacs/notmuch-show.el | 48 +++- 1 files changed, 35 insertions(+), 13 deletions(-) diff --git a/e

[PATCH 1/3] test: Add tests for `notmuch-show-clean-address'.

2011-12-27 Thread David Edmondson
--- The address containing UTF-8 still fails. This looks like a failure to properly round-trip UTF-8 in the test suite - the test passes if run directly within emacs. test/emacs | 19 +++ .../notmuch-address-simplification

[PATCH 2/4] Introduce a generic tree-like abstraction for MIME traversal.

2011-12-27 Thread Daniel Kahn Gillmor
30 bytes Desc: OpenPGP digital signature URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111227/7ce64994/attachment.pgp>

S/MIME support in notmuch

2011-12-27 Thread Daniel Kahn Gillmor
--- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 1030 bytes Desc: OpenPGP digital signature URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111227/05654dd7/attachment.pgp>

[PATCH] emacs: Add `notmuch-show-line-faces' and apply it.

2011-12-27 Thread David Edmondson
Similar to `notmuch-search-line-faces', `notmuch-show-line-faces' allows the header line in `notmuch-show-mode' buffers to be coloured according to the tags of the message. --- emacs/notmuch-lib.el | 18 ++ emacs/notmuch-show.el | 32 emacs/not

[PATCH] Ignore encrypted parts when indexing.

2011-12-27 Thread Jameson Graef Rollins
It appears to be an oversight that encrypted parts were indexed previously. The terms generated from encrypted parts are meaningless and do nothing but add bloat to the database. It is not worth indexing the encrypted content, just as it's not worth indexing the signatures in signed parts. --- l

[PATCH] Ignore encrypted parts when indexing.

2011-12-27 Thread Jameson Graef Rollins
It appears to be an oversight that encrypted parts were indexed previously. The terms generated from encrypted parts are meaningless and do nothing but add bloat to the database. It is not worth indexing the encrypted content, just as it's not worth indexing the signatures in signed parts. --- l

[PATCH] emacs: Don't attempt to colour tags in `notmuch-show-mode'.

2011-12-27 Thread David Edmondson
The tags were coloured using text properties. Unfortunately that text (the header line) also has an overlay, which overrides the text properties. There's not point in applying text properties that will never be seen. --- emacs/notmuch-show.el |8 ++-- 1 files changed, 2 insertions(+), 6 de

[PATCH v3 3/3] test: emacs: test notmuch-wash-subject-to-* functions

2011-12-27 Thread Jani Nikula
Signed-off-by: Jani Nikula --- test/emacs-subject-to-filename | 138 test/notmuch-test |1 + 2 files changed, 139 insertions(+), 0 deletions(-) create mode 100755 test/emacs-subject-to-filename diff --git a/test/emacs-subject-to-filenam

[PATCH v3 2/3] emacs: create patch filename from subject for inline patch fake parts

2011-12-27 Thread Jani Nikula
Use the mail subject line for creating a descriptive filename for the wash generated inline patch fake parts. The names are similar to the ones created by 'git format-patch'. If the user has notmuch-wash-convert-inline-patch-to-part hook enabled in notmuch-show-insert-text/plain-hook, this will ch

[PATCH v3 1/3] emacs: add inline patch fake parts through a special handler

2011-12-27 Thread Jani Nikula
Add wash generated inline patch fake parts through a special "inline-patch-fake-part" handler to distinguish them from real MIME parts. The fake parts are described as "inline patch (as text/x-diff)". Signed-off-by: Jani Nikula --- emacs/notmuch-show.el |4 emacs/notmuch-wash.el |2

[PATCH v3 0/3] emacs: patch filename from subject

2011-12-27 Thread Jani Nikula
Hi all, v3 with the following changes: * new patch 1/3 to add fake parts through a special handler to make them stand out from real MIME parts * make notmuch-wash-subject-to-patch-filename more lispy as suggested by David in id:"cun62h3tu51@hotblack-desiato.hh.sledj.net" BR, Jani. Jani

[RFC][PATCH v4] emacs: Re-implement advance/rewind functions of notmuch-show-mode.

2011-12-27 Thread David Edmondson
: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111227/cf1debcf/attachment.pgp>

Re: [PATCH 2/4] Introduce a generic tree-like abstraction for MIME traversal.

2011-12-27 Thread Daniel Kahn Gillmor
On 12/23/2011 10:45 PM, Austin Clements wrote: > Quoth Dmitry Kurochkin on Dec 10 at 3:25 am: >> + /* For some reason the GMimeSignatureValidity returned >> +* here is not a const (inconsistent with that >> +* returned by >> +* g_mime_multipart_encrypt

Re: S/MIME support in notmuch

2011-12-27 Thread Daniel Kahn Gillmor
On 12/23/2011 11:40 AM, Dan Bryant wrote: > On Wed, 21 Dec 2011 06:51:01 -0500, Darren McGuicken > wrote: >> When you make those changes to the gpg_context are you breaking gpg >> signature validation? Or is the one a superset of the other? > > The current assumption in notmuch is that all encr

Re: [PATCH] emacs: Enable more text/plain hook functions by default.

2011-12-27 Thread Jani Nikula
On Tue, 27 Dec 2011 12:00:25 +, David Edmondson wrote: > Users are missing out on various functions which usefully improve the > display of text/plain message parts because they are not enabled by > default. Enable a useful set. While I didn't try the patch, I'm very much in favour of having

[PATCH] emacs: Enable more text/plain hook functions by default.

2011-12-27 Thread David Edmondson
Users are missing out on various functions which usefully improve the display of text/plain message parts because they are not enabled by default. Enable a useful set. `notmuch-wash-convert-inline-patch-to-part' is _not_ enabled by default as it is based on a heuristic. --- emacs/notmuch-show.el

Re: [PATCH] emacs: Cycle through notmuch buffers rather than jumping to the last.

2011-12-27 Thread David Edmondson
On Tue, 27 Dec 2011 10:50:44 +, David Edmondson wrote: > As suggested by j4ni in #notmuch, rename > `notmuch-jump-to-recent-buffer' as `notmuch-cycle-notmuch-buffers' and > have it behave accordingly. This is the reason that I haven't mentioned `notmuch-jump-to-recent-buffer' in the NEWS file

[PATCH] emacs: Cycle through notmuch buffers rather than jumping to the last.

2011-12-27 Thread David Edmondson
As suggested by j4ni in #notmuch, rename `notmuch-jump-to-recent-buffer' as `notmuch-cycle-notmuch-buffers' and have it behave accordingly. --- emacs/notmuch.el | 39 +++ 1 files changed, 27 insertions(+), 12 deletions(-) diff --git a/emacs/notmuch.el b/emacs

[PATCH 2/3] emacs: Avoid `mail-header-parse-address' in `notmuch-show-clean-address'.

2011-12-27 Thread David Edmondson
`mail-header-parse-address' expects un-decoded mailbox parts, which is not what we have at this point. Replace it with simple string deconstruction. --- emacs/notmuch-show.el | 48 +++- 1 files changed, 35 insertions(+), 13 deletions(-) diff --git a/e

[PATCH 3/3] test: Correct the expected output of the 'invalid From' test.

2011-12-27 Thread David Edmondson
--- test/emacs |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/test/emacs b/test/emacs index bb4a75f..0168f85 100755 --- a/test/emacs +++ b/test/emacs @@ -78,7 +78,7 @@ thread=$(notmuch search --output=threads subject:message-with-invalid-from) test_emacs "(notmuch-show

[PATCH 1/3] test: Add tests for `notmuch-show-clean-address'.

2011-12-27 Thread David Edmondson
--- The address containing UTF-8 still fails. This looks like a failure to properly round-trip UTF-8 in the test suite - the test passes if run directly within emacs. test/emacs | 19 +++ .../notmuch-address-simplification