Why remove the const modifier on `nb`?
On 2021-05-11 — 16:28, Zhen Lei wrote:
> When the 'nb' value allocated from 'bl_ida' is greater than or equal to
> 100, it will not be released. In fact, we can simplify operations by
> limiting the range of idas that can be applied for.
>
> By the way, dele
Reviewed-by: Pierre Moreau
On 2021-05-11 — 16:28, Zhen Lei wrote:
> Fix to return a negative error code from the error handling case instead
> of 0, as done elsewhere in this function.
>
> Fixes: db1a0ae21461 ("drm/nouveau/bl: Assign different names to interfaces")
> Su
Hello Zhen,
There was a similar patch sent in last month, though which does not seem to
have been merged yet; see
https://lists.freedesktop.org/archives/nouveau/2021-April/038451.html.
Whether `ret` should be `-ENOSPC` or `-ENOMEM` is hard to say as
`nouveau_get_backlight_name()` could fail due t
I can not remember why the original code did return 0 rather than an error, but
-ENOMEM seems indeed way more fitting.
Reviewed-by: Pierre Moreau
On 2021-04-14 — 08:58, Dan Carpenter wrote:
> If nouveau_get_backlight_name() fails then this should return -ENOMEM
> but currently it r
With the comment further below addressed, this patch is
Reviewed-by: Pierre Moreau
On 2019-12-16 — 11:48, zhengbin wrote:
> Fixes coccicheck warning:
>
> drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c:583:2-3: Unneeded semicolon
> drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.h:307:2
Reviewed-by: Pierre Moreau
On 2019-12-18 — 09:28, zhengbin wrote:
> Fixes coccicheck warning:
>
> drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c:583:2-3: Unneeded semicolon
> drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.h:307:2-3: Unneeded semicolon
>
> Reported-by: Hulk Robo
Friendly ping, Ben.
I see that in `nouveau_fence_done()` there is a check on `chan` not being NULL
prior to passing it to `nouveau_fence_update()`. Would something similar be
needed here?
Pierre
On 2018-11-15 — 12:14, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers
Hey Lukas,
> Sorry Pierre, I missed this question and am seeing it only now on
> saving the message away:
No worries, and thank you for the great explanation! I’ll definitely make a
mental note to try unloading Nouveau, whenever writing/testing similar patches.
Thanks,
Pierre
signature.asc
Des
A few words about why this change is needed would be nice, as well as what
changed since the v1 (well, looking back to your original patch, absolutely
everything changed :-D).
On 2018-02-19 — 17:09, Karol Herbst wrote:
> fixes d9c0aadc5aa241df26ce8301d34a8418919fb5ae
The formatting does not follo
;drm/nouveau/bl: Do not register interface if Apple GMUX
> detected")
> Cc: sta...@vger.kernel.org # v4.10+
> Cc: Pierre Moreau
> Signed-off-by: Lukas Wunner
> ---
> I reviewed the patch causing the oops but unfortunately missed this, sorry!
>
> drivers/gpu/drm/nouvea
On 2018-02-14 — 09:36, Ilia Mirkin wrote:
> On Wed, Feb 14, 2018 at 9:35 AM, Ilia Mirkin wrote:
> > On Wed, Feb 14, 2018 at 9:29 AM, Meelis Roos wrote:
> >>> This is 4.16-rc1+todays git on a lowly P4 with NV5, worked fine in 4.15:
> >>
> >> NV5 in another PC (secondary card in x86-64) made the sy
Indeed, it looks like the devel-clk branch does not have that typo.
On 2017-12-29 — 13:39, Rosen Penev wrote:
> This is fixed in a different nouveau branch. from Ben Skeggs last I remember.
>
> On Fri, Dec 29, 2017 at 1:37 PM, Pierre Moreau wrote:
> > The typo is still pr
On 2017-12-30 — 15:21, Tobias Klausmann wrote:
> v2: use initialization list (Pierre)
>
> Signed-off-by: Tobias Klausmann
> Reviewed-by: Pierre Moreau
> ---
> src/gallium/drivers/nouveau/codegen/nv50_ir_ra.cpp | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Ping: this can still be an issue today as kstrtol() & co haven’t changed their
possible return value since the patch was written.
On 2017-07-22 — 14:13, Pierre Moreau wrote:
> Reviewed-by: Pierre Moreau
>
> On 2017-07-17 — 11:17, Dan Carpenter wrote:
> > kstrtol() and friends
Ping
On 2017-07-22 — 13:54, Pierre Moreau wrote:
> Reviewed-by: Pierre Moreau
>
> On 2017-06-21 — 15:19, Hans de Goede wrote:
> > Hi,
> >
> > On 26-05-17 09:35, Hans De Goede wrote:
> > > The local #define of ACPI_VIDEO_NOTIFY_PROBE was only added tem
The typo is still present in master.
Not sure whether it will help you Ben, regarding Fermi reclocking, but it
shouldn’t harm in reducing possible errors. :-)
Regards,
Pierre
On 2017-07-27 — 18:20, Rosen Penev wrote:
> Signed-off by: Rosen Penev
> ---
> drm/nouveau/nvkm/subdev/fb/ramgf100.c | 2
It looks like this patch was never merged.
You could initialise “nodeCount” and “nodes” directly in the member
initialisation list. With that changed, this patch is
Reviewed-by: Pierre Moreau
On 2017-08-12 — 01:45, Tobias Klausmann wrote:
> Signed-off-by: Tobias Klausmann
> ---
> sr
Hey Ard,
It seems that Ben already committed a similar patch to his tree (see [0]). I do
not know whether he is planning to have it part of a pull request of fixes for
4.15.
Best regards,
Pierre
[0]:
https://github.com/skeggsb/nouveau/commit/9068f1df2394f0e4ab2b2a28cac06b462fe0a0aa
On 2017-12-
o forward information to the
>print pass (Pierre Moreau)
>
> Signed-off-by: Tobias Klausmann
> ---
> src/gallium/drivers/nouveau/codegen/nv50_ir_driver.h | 1 +
> src/gallium/drivers/nouveau/codegen/nv50_ir_print.cpp | 12 +---
> src/gallium/drivers/nouveau/nouveau
The “Program” class keeps a pointer to the “nv50_ir_prog_info” structure, so
you could
just use that in the “Program::print()” function, rather than passing the flag
as
an argument to “print”.
Pierre
On 2017-11-17 — 17:21, Tobias Klausmann wrote:
> This comes in handy when checking "NV50_PROG_D
This looks like the saner approach, compared to changing tgsi_dump.c to display
more fractional digits. Maybe there could be a second option to display as both
float and hex?
Reviewed-by: Pierre Moreau
On 2017-11-14 — 15:11, Tobias Klausmann wrote:
> Printing without this could lead to
Reviewed-by: Pierre Moreau
On 2017-09-15 — 17:11, Karol Herbst wrote:
> v2: make message about relaxed throttling an info
> rework reporting about current clk state
>
> Signed-off-by: Karol Herbst
> ---
> drm/nouveau/include/nvkm/subdev/clk.h | 1 +
> drm/nouveau/n
Looking good. It would be nice to have some defines/enums for the different
modes. Some comments about t0, t1 and t2 would be nice. I saw you are using t0
in patch 16, but I have no idea why use t0 rather than t1 or t2.
Otherwise,
Acked-by: Pierre Moreau
On 2017-09-15 — 17:11, Karol Herbst
On 2017-09-15 — 17:11, Karol Herbst wrote:
> v2: use min_t
>
> Signed-off-by: Karol Herbst
> ---
> drm/nouveau/include/nvkm/subdev/clk.h | 2 ++
> drm/nouveau/nvkm/subdev/clk/base.c| 42
> +++
> 2 files changed, 44 insertions(+)
>
> diff --git a/drm/nouveau
Reviewed-by: Pierre Moreau
On 2017-09-15 — 17:11, Karol Herbst wrote:
> Depending on the temperature, cstates might become unreachable or the maped
> voltage of a cstate changes. We want to adjust to that.
>
> Signed-off-by: Karol Herbst
> Reviewed-by: Martin Peres
> ---
&
Reviewed-by: Pierre Moreau
On 2017-09-15 — 17:11, Karol Herbst wrote:
> The idea is to clear out the saved state, because after a resume we can't
> know what the GPU is clocked to. The reclock is triggered by the call to
> nvkm_clk_update later in nvkm_clk_init.
>
> v2
On 2017-09-15 — 17:11, Karol Herbst wrote:
> This makes the code easier, because we can compare the id with
> pstate->pstate and saves us from the trouble of iterating over the pstates
> to match the index.
I don’t remember whether I have already done this comment before, but I am not
sure where
Acked-by: Pierre Moreau
On 2017-09-15 — 17:11, Karol Herbst wrote:
> Later we will have situations where the expected and the current state
> isn't the same.
>
> Signed-off-by: Karol Herbst
> Reviewed-by: Martin Peres
> ---
> drm/nouveau/include/nvkm/subdev/clk.h |
The patch seems fine but I found it super confusing that sometimes `pstate` is
a pointer (for example `clk->pstate`), sometimes it is an int (for example
`args->v0.pstate`).
On 2017-09-15 — 17:11, Karol Herbst wrote:
> We will access the current cstate at least every second and this saves us
> som
This patch could be applied before patch 04, that way patch 04 does not need to
update a function (`nvkm_clk_dstate()`) that will be removed in the next patch.
Reviewed-by: Pierre Moreau
On 2017-09-15 — 17:11, Karol Herbst wrote:
> We won't need it now, because we will adjust th
On 2017-09-15 — 17:11, Karol Herbst wrote:
> This function will be used to update the current clock state.
>
> This will happen for various reasons:
> * Temperature changes
> * User changes clocking state
> * Load changes
>
> v2: remove parameter name
>
> Signed-off-by: Karol Herbst
> ---
en “that” and “sensors”.
Otherwise,
Reviewed-by: Pierre Moreau
>
> Signed-off-by: Karol Herbst
> ---
> drm/nouveau/nvkm/subdev/volt/gk104.c | 7 ++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drm/nouveau/nvkm/subdev/volt/gk104.c
> b/drm/nou
Reviewed-by: Pierre Moreau
On 2017-09-15 — 17:11, Karol Herbst wrote:
> Otherwise hwmon interprets error codes as real values.
>
> Signed-off-by: Karol Herbst
> ---
> drm/nouveau/nouveau_hwmon.c | 33 ++---
> 1 file changed, 26 insertio
As you changed the return value of `temp_get()` to solely be the error code, or
absence of an error, I would change all those tests that checked whether the
returned value was strictly less, or greater than, 0 to now only compare
against 0 (no error). For example,
if (therm && therm->attr_get &&
You are right, Tegra should probably be part of the description, even if we do
not support pre-K1 Tegras.
Acked-by: Pierre Moreau
On 2017-08-11 — 10:56, Rhys Kidd wrote:
> nouveau supports the Tegra K1 and higher after the SoC-based GPUs converged
> with the main GeForce GPU fa
Hello Paulo,
Power management is made of different things:
* reclocking the memory and the engines: this is supported on some Tesla cards
(>G92), all Kepler ones and on the first generation of Maxwell (GM10x). In
that regard, the Arch Linux wiki is right, as Pascal cards do not support
recl
having to keep a custom patch around.
Signed-off-by: Pierre Moreau
---
drm/Makefile | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drm/Makefile b/drm/Makefile
index d5e23738..1f4ef45e 100644
--- a/drm/Makefile
+++ b/drm/Makefile
@@ -11,6 +11,9 @@ endif
KBUILD_OPTS := M=$(CURDIR)/nouveau
On 2017-07-21 — 23:55, Karol Herbst wrote:
> Signed-off-by: Karol Herbst
> ---
> drm/nouveau/include/nvkm/subdev/clk.h | 1 +
> drm/nouveau/nvkm/subdev/clk/base.c| 35
> +++
> 2 files changed, 32 insertions(+), 4 deletions(-)
>
> diff --git a/drm/nouveau/inc
Reviewed-by: Pierre Moreau
On 2017-07-17 — 11:17, Dan Carpenter wrote:
> kstrtol() and friends can return -EINVAL or -ERANGE. We have to test
> for both, otherwise the value is possibly uninitialized. Also in some
> of these files we accidentally return "count" on error inst
Reviewed-by: Pierre Moreau
On 2017-06-21 — 15:19, Hans de Goede wrote:
> Hi,
>
> On 26-05-17 09:35, Hans De Goede wrote:
> > The local #define of ACPI_VIDEO_NOTIFY_PROBE was only added temporarily
> > to avoid a dependency between the acpi and nouveau trees while merging.
> Another issue is that in Google Chrome I seem have no hardware acceleration
> for anything other than "Multiple Raster Threads". See attached.
Two things: you are using nomodeset, and hardware acceleration for Pascal cards
was only merged in 4.12 (which has not been released yet), as pointed out
Hello,
Acceleration for Pascal cards is coming in Linux 4.12, support for Pascal cards
in xorg-video-nouveau is in 1.0.15, and if I remember correctly, on the
Mesa-side, you will need >=17.0.
Pierre
On 02:04 am - May 04 2017, Karl Schmidt wrote:
> This is probably the problem
> May 3 16:44:45 k
From: Pierre Moreau
The Apple GMUX is the one managing the backlight, so there is no need for
Nouveau to register its own backlight interface.
v2: Do not split information message on two lines as it prevents from grepping
it, as pointed out by Lukas Wunner
Signed-off-by: Pierre Moreau
From: Pierre Moreau
Currently, every backlight interface created by Nouveau uses the same name,
nv_backlight. This leads to a sysfs warning as it tries to create an already
existing folder. This patch adds a incremented number to the name, but keeps
the initial name as nv_backlight, to avoid
message
Signed-off-by: Pierre Moreau
---
drm/nouveau/nouveau_backlight.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drm/nouveau/nouveau_backlight.c b/drm/nouveau/nouveau_backlight.c
index a34cd35..8b1ca4a 100644
--- a/drm/nouveau/nouveau_backlight.c
+++ b/drm/nouveau
create similarly named interfaces when reaching the maximum
amount of unique names, but fail instead, as pointed out by Lukas Wunner
Signed-off-by: Pierre Moreau
---
drm/nouveau/nouveau_backlight.c | 74 ++---
drm/nouveau/nouveau_display.h | 10 ++
drm
On 11:17 am - Nov 14 2016, Lukas Wunner wrote:
> On Sun, Nov 13, 2016 at 08:57:06PM +0100, Pierre Moreau wrote:
> > From: Pierre Moreau
> >
> > Currently, every backlight interface created by Nouveau uses the same name,
> > nv_backlight. This leads to a sysfs warni
Hello Ben,
You can find below my results; there is a slight over-representation of 1st gen
Tesla cards, but… that’s what I have. :-D No regressions observed, apart from:
* screen rotation on G80, MCP79
* resuming on G86
I’ll retest those cards with your linux-4.10 branch but without the atomic +
On 11:55 am - Nov 12 2016, Karol Herbst wrote:
> v2: Set entry to 0xff if not found
> Add cap entry for ver 0x30 tables
> Rework to fix memory leak
>
> Signed-off-by: Karol Herbst
> ---
> .../include/nvkm/subdev/bios/power_budget.h| 24
> drm/nouveau/nvkm/subdev/bios/Kbuild
bisecting those
issues…
Pierre
On 06:12 am - Nov 08 2016, poma wrote:
> On 21.10.2016 10:56, Pierre Moreau wrote:
> > On 01:15 am - Oct 21 2016, Lukas Wunner wrote:
> >> On Thu, Oct 20, 2016 at 10:08:28AM +0200, Lukas Wunner wrote:
> >>> On Wed, Oct 19, 2016 at 07:58:0
Hello,
The idea was to use the modesetting DDX instead of Nouveau’s one for Maxwell+
as EXA was [broken][1]. But you can give a try at Ilia’s [patches][2], which
fix the Nouveau DDX for GM10x and GM20x (I don’t think it has been tested on a
GM108 yet).
Best regards,
Pierre Moreau
[1]:
https
On 01:15 am - Oct 21 2016, Lukas Wunner wrote:
> On Thu, Oct 20, 2016 at 10:08:28AM +0200, Lukas Wunner wrote:
> > On Wed, Oct 19, 2016 at 07:58:06PM +0200, Pierre Moreau wrote:
> > > For example, my laptop (which also has an NVAC) has been triggering the
> > > no
Hello,
On 07:37 pm - Oct 19 2016, poma wrote:
> On 19.10.2016 17:03, Karol Herbst wrote:
>
> > You don't get why I try to say. We have to actually find out when to
> > apply this workaround, not to create some silly whitelist/blacklist.
> > It's the last option, we never want to actually use.
> >
@Ben: ping
I would guess that the same can be done for Pascal as well.
Cheers,
Pierre
On 02:41 PM - May 21 2016, Faris Alsalama wrote:
> Signed-off-by: Faris Alsalama
> ---
> drivers/gpu/drm/nouveau/nouveau_backlight.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/no
Hello everyone,
Same place as FOSDEM? XDC is in Helsinki and FOSDEM was in Brussels… (IIRC,
FOSDEM is always located in Brussels.) I would prefer picking an hotel in
Helsinki rather than traveling every day between Helsinki and Brussels. :-p Or
was that what you meant by "more or less"? :-D
I’ve
Acked-by: Pierre Moreau
On 02:41 PM - May 21 2016, Faris Alsalama wrote:
> Signed-off-by: Faris Alsalama
> ---
> drivers/gpu/drm/nouveau/nouveau_backlight.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_backlight.c
> b/dr
Hello Marcos,
I sent a serie a year ago to fix some of the ACPI handling in Nouveau and add
runtime pm support for laptops with an Apple GMUX (see [0], and especially [1]
and [2]). I was told that a more generic work for the runtime pm was in the
work, so I let the whole serie slip away. I was thi
On 02:32 PM - May 01 2016, Pierre Moreau wrote:
> The Apple GMUX is the one managing the backlight, so there is no need for
> Nouveau to register its own backlight interface.
>
> v2: Do not split information message on two lines as it prevents from grepping
> it, as pointed
The Apple GMUX is the one managing the backlight, so there is no need for
Nouveau to register its own backlight interface.
v2: Do not split information message on two lines as it prevents from grepping
it, as pointed out by Hans de Goede
Signed-off-by: Pierre Moreau
---
drm/nouveau
> /smo
>
> On 2016-03-31 23:12, Pierre Moreau wrote:
> > Oh, hum, GM108 is NV118 and not NV108 which is Gk208… My bad!
> >
> > SMF from the bug report seemed to have some working setup, and since he
> > didn't
> > pinged back, I guess it's working nicely
`nouveau_get_backlight_name()` to avoid forward declaration, as
suggested by Ilia Mirkin;
* Fix reference to bug report formatting, as reported by Nick Tenney.
Signed-off-by: Pierre Moreau
---
drm/nouveau/nouveau_backlight.c | 64 ++---
drm/nouveau/nouveau_display.h | 10
The Apple GMUX is the one managing the backlight, so there is no need for
Nouveau to register its own backlight interface.
Signed-off-by: Pierre Moreau
---
drm/nouveau/nouveau_backlight.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drm/nouveau/nouveau_backlight.c b/drm/nouveau
[…]
>
> > + const int nb = atomic_inc_return(&bl_interfaces_nb) - 1;
>
> This kinda sucks if you reload nouveau a bunch. How about using an
> "ida". Have a look in drivers/gpu/drm/drm_crtc.c for how I use that
> one.
I had a quick look at drm_crtc.c. This seems to be exactly what I need,
On 02:40 PM - Apr 15 2016, Nick Tenney wrote:
> On Fri, Apr 15, 2016 at 11:25 AM, Ilia Mirkin wrote:
>
> > On Fri, Apr 15, 2016 at 11:22 AM, Pierre Moreau
> > wrote:
> > > On 11:06 AM - Apr 15 2016, Ilia Mirkin wrote:
> > >> On Fri, Apr 15, 201
On 11:06 AM - Apr 15 2016, Ilia Mirkin wrote:
> On Fri, Apr 15, 2016 at 10:57 AM, Pierre Moreau wrote:
> > Currently, every backlight interface created by Nouveau uses the same name,
> > nv_backlight. This leads to a sysfs warning as it tries to create an already
> > existi
The Apple GMUX is the one managing the backlight, so there is no need for
Nouveau to register its own backlight interface.
Signed-off-by: Pierre Moreau
---
drm/nouveau/nouveau_backlight.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drm/nouveau/nouveau_backlight.c b/drm/nouveau
userspace; the
second interface will be named nv_backlight1, and so on.
Fixes: fdo#86539
Signed-off-by: Pierre Moreau
---
drm/nouveau/nouveau_backlight.c | 35 +--
1 file changed, 33 insertions(+), 2 deletions(-)
diff --git a/drm/nouveau/nouveau_backlight.c b/drm/nouveau
ally GM108 is not one of the recognized chips. Someone needs to go
> through and check that its goldens didn't change. Nobody's done that.
>
> See https://bugs.freedesktop.org/show_bug.cgi?id=89558
>
> On Thu, Mar 31, 2016 at 4:57 PM, Pierre Moreau wrote:
> > Hello
Hello,
Acceleration support for GM107 was merged in kernel 4.1, and modesetting
support was added to 3.15. Which kernel version did you try? The GM108 chipset
seems to be recognised since at least 2015/08/20.
Regards,
Pierre Moreau
On 02:55 PM - Mar 29 2016, Sune Mølgaard wrote:
> H
On 11:05 AM - Mar 10 2016, Ilia Mirkin wrote:
> On Thu, Mar 10, 2016 at 11:03 AM, Pierre Moreau wrote:
> > You might want to increment the address by at least
> > `info->prop.cp.inputOffset`, and if inputs still end up in shared on Tesla,
>
> There's a cp.sharedOffse
On 04:27 PM - Mar 10 2016, Samuel Pitoiset wrote:
>
>
> On 03/10/2016 04:23 PM, Ilia Mirkin wrote:
> >On Thu, Mar 10, 2016 at 10:14 AM, Hans de Goede wrote:
> >>Add support for clover / OpenCL kernel input parameters.
> >>
> >>Signed-off-by: Hans de Goede
> >>---
> >> .../drivers/nouveau/codeg
The secondary hit exception thrown while MMIOtracing NVIDIA's driver is gone
with this patch.
Tested-by: Pierre Moreau
On 02:03 AM - Mar 03 2016, Karol Herbst wrote:
> Because Linux might use bigger pages than the 4K pages to handle those mmio
> ioremaps, the kmmio code shouldn
On 11:43 AM - Feb 23 2016, Hans de Goede wrote:
> Hi,
>
[snip]
>
> >You may have to add LOAD64/STORE64 for 64-bit
> >addresses though. Or we could decree that all addressing on global
> >memory shall be 64-bit (and thus read the .xy components of the
> >address source).
>
> I would prefer to k
- Mail original -
> On Mon, Feb 22, 2016 at 10:50 AM, Hans de Goede
> wrote:
> >> But assuming I'm right, what I'm proposing is that instead of
> >> passing
> >> the input in as a global buffer, to instead pass it in as a const
> >> buffer. As such instead of sticking it into ->set_globa
Hello,
> On 22 Feb 2016, at 15:22, Ilia Mirkin wrote:
>
>> On Mon, Feb 22, 2016 at 9:17 AM, Hans de Goede wrote:
>> Hi,
>>
>>> On 22-02-16 14:47, Ilia Mirkin wrote:
>>>
On Mon, Feb 22, 2016 at 8:45 AM, Ilia Mirkin wrote:
INPUT is for shader inputs which come from fixed functi
or acks unfortunately.
> Any takers?
>
> Merging this would allow fdo #61115 to be closed
> (currently assigned to intel-gfx).
>
> FWIW this series has in the meantime been tested by more folks:
>
> Tested-by: Pierre Moreau
>[MBP 5,3 2009 nvidia MCP79 + G96pre-
;>
> >>>http://www.tripadvisor.com/Restaurant_Review-g188644-d802232-Reviews-Le_Falstaff-Brussels.html
> >>>
> >>>Which is not as bad as the reviews there make it out to be,
> >>>note I'm open to better suggestions, esp. from locals, Le Falstaff
Hello everyone,
I'm in for the dinner! As for the restaurant, since I never went to Brussels,
I'll follow the group's decision. Some time around 19:30–20:00? Most of us
should be in Brussels' centre by then I think.
Cheers,
Pierre
On 02:09 PM - Jan 21 2016, Hans de Goede wrote:
> Hi All,
>
> $
Hello,
Maybe my e-mail client is messing with me, but I couldn't find any dmesg output
attached to your e-mail. Could you please try to attach it again?
By the way, since you have a Kepler, you should try booting with
"nouveau.War00C800_0=1". That workaround is enabled by default in 4.4-rc5
(IIRC
Hi,
On 05:42 PM - Dec 01 2015, Karol Herbst wrote:
> this is just a nice thing to know and there is no harm in printing them
> ---
> drm/nouveau/nvkm/subdev/clk/base.c | 16
> 1 file changed, 16 insertions(+)
>
> diff --git a/drm/nouveau/nvkm/subdev/clk/base.c
> b/drm/nouveau/n
Hi Karol,
I have some comments below.
On 05:42 PM - Dec 01 2015, Karol Herbst wrote:
> 0: disable boosting (cap to base clock from the vbios)
> 1: boost only to boost clock from the vbios
> 2: boost to max clock available
> ---
> drm/nouveau/include/nvkm/subdev/clk.h | 10 +-
> drm/nouve
> you write: "This compute support has been tested by
> Pierre Moreau and myself with some compute kernels."
>
> Can you provide testing instructions (and the
> necessary files) so that I can try to reproduce
> your tests ?
>
> And once I've reproduced your tests, t
Wasn't there some work being done by François Tigeot or Jean-Sébastien Pédron
to port Nouveau to DragonFlyBSD/FreeBSD? Or at least they were talking about
porting it
at XDC 2014, no idea what the current status is.
Pierre
PS: Looking at François' slides from this year XDC, it seems there isn't m
Hello poma,
The chipset didn't disappear and is still displayed: it is the G98 you get on
the "[2.483843] nouveau :02:00.0: NVIDIA G98 (098200a2)" line. The
"NV98" was the "Nouveau" chipset, but the switch was made to use the same
naming as NVIDIA. So rather than displaying both the Nou
The repo is a fork of Linus' tree, with the patches on top of it. So you just
need to build that modified version of the kernel and boot it. :-)
Pierre
> On 05 Oct 2015, at 16:15, Evan Foss wrote:
>
>> On Mon, Oct 5, 2015 at 9:23 AM, Lukas Wunner wrote:
>> Hi,
>>
>> I've also pushed this ser
rom nvkm_pci_init to g84_pci_init and remove PCIe and chipset
checks
v5:
* Rebase code on latest PCI structure
* Restore PCIe check
* Fix namings in nvkm_pci_mask
* Rephrase part of the commit message
Signed-off-by: Pierre Moreau
---
drm/nouveau/include/nvkm/subdev/pci.h | 1 +
nit to g84_pci_init and remove PCIe and chipset
checks
Signed-off-by: Pierre Moreau
---
drm/nouveau/include/nvkm/subdev/pci.h | 4 +++
drm/nouveau/nvkm/engine/device/base.c | 64 +--
drm/nouveau/nvkm/subdev/pci/Kbuild| 1 +
drm/nouveau/nvkm/subdev/pci/bas
sible values to 32. Apparently bits 7:0 of 0x8841c
> stores some
> number of outstanding requests, so cap it to 32 if extended tag is
> unsupported.
>
> Fixes: fdo#86537
>
> v2: Restrict changes to chipsets >= 0x84
> v3:
> * Add nvkm_pci_mask to pci.h
> * Mask
some
number of outstanding requests, so cap it to 32 if extended tag is unsupported.
Fixes: fdo#86537
v2: Restrict changes to chipsets >= 0x84
v3:
* Add nvkm_pci_mask to pci.h
* Mask bit 8 before setting it
Signed-off-by: Pierre Moreau
---
drm/nouveau/include/nvkm/subdev/pci.h | 1 +
some
number of outstanding requests, so cap it to 32 if extended tag is unsupported.
Fixes: fdo#86537
v2: Restrict changes to chipsets >= 0x84
Signed-off-by: Pierre Moreau
---
drm/nouveau/nvkm/subdev/pci/base.c | 25 +
1 file changed, 25 insertions(+)
diff --git a/
some
number of outstanding requests, so cap it to 32 if extended tag is unsupported.
Fixes: fdo#86537
Signed-off-by: Pierre Moreau
---
drm/nouveau/nvkm/subdev/pci/base.c | 25 +
1 file changed, 25 insertions(+)
diff --git a/drm/nouveau/nvkm/subdev/pci/base.c
b/drm/nouveau
Hello,
Nouveau will support Cuda and OpenCL, someday. :)
As to say when, I don't know. I am starting to work on translating between
different intermediate representation (from SPIR-V to NV50 IR), and will later
work on finishing compute support for Tesla cards (I only have Tesla cards,
apart fr
Hi Lukas
- Mail original -
> Hi Pierre,
>
> On Thu, May 28, 2015 at 10:52:56AM +0200, Pierre Moreau wrote:
> > How is it supposed to work, by simply echo'ing ON or OFF to
> > vga_switcheroo/switch? Then I probably forgot some stuff as
> > it doesn't
Hi Dave,
- Mail original -
> Changes since v1:
[...]
> diff --git a/drm/nouveau/nouveau_vga.c b/drm/nouveau/nouveau_vga.c
> index 9a6328f..7b13804 100644
> --- a/drm/nouveau/nouveau_vga.c
> +++ b/drm/nouveau/nouveau_vga.c
> @@ -36,7 +36,7 @@ nouveau_switcheroo_set_state(struct pci_dev *pd
I wasn't sure how to insert this one into the flow, if I should make it a patch
4.5 or not. I went with patch 5, so all the following patches are incremented
by 1 compared to the v1, sorry about that.
What should be the way to go?
Pierre
> On 28 May 2015, at 08:40, Pierre Morea
Changes since v1:
* Fix check for result being not NULL in nouveau_evaluate_optimus_dsm
Signed-off-by: Pierre Moreau
---
drm/nouveau/nouveau_acpi.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drm/nouveau/nouveau_acpi.c b/drm/nouveau/nouveau_acpi.c
index
s since v1:
* Replace ACPI errors with standard kernel ones
Signed-off-by: Pierre Moreau
---
drm/nouveau/nouveau_acpi.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/drm/nouveau/nouveau_acpi.c b/drm/nouveau/nouveau_acpi.c
index b837ab1..44a7328 100644
--- a/d
Signed-off-by: Pierre Moreau
---
drm/nouveau/nouveau_acpi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drm/nouveau/nouveau_acpi.c b/drm/nouveau/nouveau_acpi.c
index 01dbf1d..b837ab1 100644
--- a/drm/nouveau/nouveau_acpi.c
+++ b/drm/nouveau/nouveau_acpi.c
@@ -92,7
Changes since v1:
* Re-write the whole patch to detect available _DSMs when we enable them rather
than on each loop run
Signed-off-by: Pierre Moreau
---
drm/nouveau/nouveau_acpi.c | 27 ++-
1 file changed, 6 insertions(+), 21 deletions(-)
diff --git a/drm/nouveau
: Pierre Moreau
---
drm/nouveau/nouveau_acpi.c | 57 --
drm/nouveau/nouveau_acpi.h | 4
drm/nouveau/nouveau_drm.c | 12 +-
drm/nouveau/nouveau_vga.c | 10
4 files changed, 70 insertions(+), 13 deletions(-)
diff --git a/drm/nouveau
1 - 100 of 144 matches
Mail list logo