Re: [Numpy-discussion] Proposal: add `force=` or `copy=` kwarg to `__array__` interface

2020-04-24 Thread Eric Wieser
Perhaps worth mentioning that we've discussed this sort of API before, in https://github.com/numpy/numpy/pull/11897. Under that proposal, the api would be something like: * `copy=True` - always copy, like it is today * `copy=False` - copy if needed, like it is today * `copy=np.never_copy` - never

Re: [Numpy-discussion] Proposal: add `force=` or `copy=` kwarg to `__array__` interface

2020-04-24 Thread Sebastian Berg
On Fri, 2020-04-24 at 11:34 +0100, Eric Wieser wrote: > Perhaps worth mentioning that we've discussed this sort of API > before, in > https://github.com/numpy/numpy/pull/11897. > > Under that proposal, the api would be something like: > > * `copy=True` - always copy, like it is today > * `copy=Fa

[Numpy-discussion] Feelings about type aliases in NumPy

2020-04-24 Thread Joshua Wilson
Hey everyone, Over in numpy-stubs we've been working on typing "array like": https://github.com/numpy/numpy-stubs/pull/66 It would be nice if the type were public so that downstream projects could use it (e.g. it would be very helpful in SciPy). Originally the plan was to only make it publicly a

Re: [Numpy-discussion] Proposal: add `force=` or `copy=` kwarg to `__array__` interface

2020-04-24 Thread Stephan Hoyer
On Fri, Apr 24, 2020 at 6:31 AM Sebastian Berg wrote: > One thing to note is that `__array__` is actually asked to return a > copy AFAIK. The documentation on __array__ seems to quite limited, unfortunately. The most I can find are a few sentences here: https://numpy.org/doc/stable/reference/ar

Re: [Numpy-discussion] Feelings about type aliases in NumPy

2020-04-24 Thread Stefan van der Walt
On Fri, Apr 24, 2020, at 08:45, Joshua Wilson wrote: > But, Stephan pointed out that it might be confusing to users for > objects to only exist at typing time, so we came around to the > question of whether people are open to the idea of including the type > aliases in NumPy itself. Ralf's concrete

Re: [Numpy-discussion] Proposal: add `force=` or `copy=` kwarg to `__array__` interface

2020-04-24 Thread Sebastian Berg
On Fri, 2020-04-24 at 10:12 -0700, Stephan Hoyer wrote: > On Fri, Apr 24, 2020 at 6:31 AM Sebastian Berg < > sebast...@sipsolutions.net> > wrote: > > > One thing to note is that `__array__` is actually asked to return a > > copy AFAIK. > > The documentation on __array__ seems to quite limited, un

Re: [Numpy-discussion] Feelings about type aliases in NumPy

2020-04-24 Thread Sebastian Berg
On Fri, 2020-04-24 at 11:10 -0700, Stefan van der Walt wrote: > On Fri, Apr 24, 2020, at 08:45, Joshua Wilson wrote: > > But, Stephan pointed out that it might be confusing to users for > > objects to only exist at typing time, so we came around to the > > question of whether people are open to the

[Numpy-discussion] beginner introduction to group

2020-04-24 Thread Tina Oberoi
Hi Everyone, I am new to contributing to numpy. I have read the contributors guide and done with the set-up. Hope to make some good contributions and also to connect with all you great people in the numpy community. Any suggestions and tips are always welcome. Thanks and Regards __

Re: [Numpy-discussion] beginner introduction to group

2020-04-24 Thread Robert Kern
On Sat, Apr 25, 2020 at 1:02 AM Tina Oberoi wrote: > Hi Everyone, > I am new to contributing to numpy. I have read the contributors guide and > done with the set-up. Hope to make some good contributions and also to > connect with all you great people in the numpy community. > Any suggestions and

Re: [Numpy-discussion] Feelings about type aliases in NumPy

2020-04-24 Thread Stephan Hoyer
On Fri, Apr 24, 2020 at 11:31 AM Sebastian Berg wrote: > On Fri, 2020-04-24 at 11:10 -0700, Stefan van der Walt wrote: > > On Fri, Apr 24, 2020, at 08:45, Joshua Wilson wrote: > > > But, Stephan pointed out that it might be confusing to users for > > > objects to only exist at typing time, so we

Re: [Numpy-discussion] Feelings about type aliases in NumPy

2020-04-24 Thread Kevin Sheppard
Typing is for library developers more than end users. I would also worry that putting it into the top level might discourage other typing classes since it is more difficult to add to the top level than to a lower level module. np.typing seems very clear to me. On Sat, Apr 25, 2020, 07:41 Stephan H