Re: OAK-6575 - A word of caution

2017-09-04 Thread Francesco Mari
On Mon, Sep 4, 2017 at 6:18 PM, Ian Boston wrote: > Do you mean: > keep the OakConversionService but put all the logic to convert from a > Value to a URI inside that implementation using new Oak SPI/APIs if > necessary and drop the AdapterManager completely ? Yes. I think there is no need to pro

Re: [VOTE] Release Apache Jackrabbit Oak 1.6.5

2017-09-04 Thread Vikas Saurabh
> [X] +1 Release this package as Apache Jackrabbit Oak 1.6.5 Thanks, Vikas

BUILD FAILURE: Jackrabbit Oak - Build # 703 - Failure

2017-09-04 Thread Apache Jenkins Server
The Apache Jenkins build system has built Jackrabbit Oak (build #703) Status: Failure Check console output at https://builds.apache.org/job/Jackrabbit%20Oak/703/ to view the results. Changes: [catholicon] OAK-6576: Refactor OakDirectory to be more manageable Test results: All tests passed

Re: [VOTE] Release Apache Jackrabbit Oak 1.6.5

2017-09-04 Thread Amit Jain
+1 Release this package as Apache Jackrabbit Oak 1.6.5 Thanks Amit On Mon, Sep 4, 2017 at 8:10 PM, Davide Giannella wrote: > A candidate for the Jackrabbit Oak 1.6.5 release is available at: > > https://dist.apache.org/repos/dist/dev/jackrabbit/oak/1.6.5/ > > The release candidate is a zip

Re: [VOTE] Release Apache Jackrabbit Oak 1.6.5

2017-09-04 Thread Julian Reschke
On 2017-09-04 16:40, Davide Giannella wrote: ... [X] +1 Release this package as Apache Jackrabbit Oak 1.6.5 Best regards, Julian

Re: [VOTE] Release Apache Jackrabbit Oak 1.6.5

2017-09-04 Thread Andrei Dulceanu
[X] +1 Release this package as Apache Jackrabbit Oak 1.6.5 2017-09-04 17:40 GMT+03:00 Davide Giannella : > Please vote on releasing this package as Apache Jackrabbit Oak 1.6.5. > The vote is open for the next 72 hours and passes if a majority of at > least three +1 Jackrabbit PMC votes are cast.

Re: OAK-6575 - A word of caution

2017-09-04 Thread Ian Boston
Hi, On 4 September 2017 at 16:43, Francesco Mari wrote: > On Mon, Sep 4, 2017 at 4:57 PM, Ian Boston wrote: > > Hi, > > IIUC There are 2 patterns: > > > > 1 Emitting a short lived signed URL as per the AWS CloudFront recommended > > method of serving private content. > > I have nothing to objec

Re: OAK-6575 - A word of caution

2017-09-04 Thread Francesco Mari
On Mon, Sep 4, 2017 at 4:41 PM, Ian Boston wrote: > If Oak committers feel that the contribution can't be included. Please feel > free to close OAK-6575 and I will delete the GitHub branch. Please don't! I'm not here to criticise your work, quite the contrary. The idea is good, our users seem to

Re: OAK-6575 - A word of caution

2017-09-04 Thread Francesco Mari
On Mon, Sep 4, 2017 at 4:57 PM, Ian Boston wrote: > Hi, > IIUC There are 2 patterns: > > 1 Emitting a short lived signed URL as per the AWS CloudFront recommended > method of serving private content. I have nothing to object to choice of AWS CloudFront. The past technological choices were very d

Re: OAK-6575 - A word of caution

2017-09-04 Thread Michael Dürig
On 04.09.17 16:57, Ian Boston wrote: Hi, IIUC There are 2 patterns: 1 Emitting a short lived signed URL as per the AWS CloudFront recommended method of serving private content. I think this is an area where your patch made a lot of progress. From your description my initial concerns in this

Re: OAK-6575 - A word of caution

2017-09-04 Thread Michael Dürig
Hi, I think the discussion did move forward between the various issues but this might have been obfuscated because several topics where discussed at the same time. To me the two main topics touched exposure of an URI to binaries and an API to expose this from Oak. In the meanwhile I just no

Re: OAK-6575 - A word of caution

2017-09-04 Thread Ian Boston
Hi, IIUC There are 2 patterns: 1 Emitting a short lived signed URL as per the AWS CloudFront recommended method of serving private content. 2 An Oak internal AdapterFactory/AdapterManager pattern to avoid Oak API changes. Would you be willing state your concerns for each one separately ? Best

Re: OAK-6575 - A word of caution

2017-09-04 Thread Michael Dürig
On 04.09.17 16:18, Bertrand Delacretaz wrote: On Mon, Sep 4, 2017 at 3:44 PM, Ian Boston wrote: ...I feel that Oak is weaker without the ability to offload bulk data streaming to infrastructure designed for that purpose FWIW as an Oak user I share that feeling, IMO the use cases describ

Re: OAK-6575 - A word of caution

2017-09-04 Thread Francesco Mari
I'm in no position to veto the POC and I'm not willing to. I am well aware of the importance of this feature. I expressed my concerns and so did others. As the subject of this thread clearly stated, I only wanted to point out that I had the feeling that we had a "reboot" of the conversation for no

Re: OAK-6575 - A word of caution

2017-09-04 Thread Ian Boston
Hi, This is a review of the links shared, clarifying OAK-6575 relationship to the discussion, where it is the same and where it is different. Apologies for the long email, there is a lot of material to cover, and it would be wrong to brush over the concerns of comitters with a few words. -

[VOTE] Release Apache Jackrabbit Oak 1.6.5

2017-09-04 Thread Davide Giannella
A candidate for the Jackrabbit Oak 1.6.5 release is available at:     https://dist.apache.org/repos/dist/dev/jackrabbit/oak/1.6.5/ The release candidate is a zip archive of the sources in:     https://svn.apache.org/repos/asf/jackrabbit/oak/tags/jackrabbit-oak-1.6.5/ The SHA1 checksum of the ar

Re: OAK-6575 - A word of caution

2017-09-04 Thread Bertrand Delacretaz
On Mon, Sep 4, 2017 at 3:44 PM, Ian Boston wrote: > ...I feel > that Oak is weaker without the ability to offload bulk data streaming to > infrastructure designed for that purpose FWIW as an Oak user I share that feeling, IMO the use cases described at https://wiki.apache.org/jackrabbit/JCR%2

Re: OAK-6575 - A word of caution

2017-09-04 Thread Ian Boston
Hi Francesco and Tommaso, I was not aware of the previous discussions and will now read those threads and issues. I submitted the issue, patch and thread in good faith, not having a detailed knowledge of everything that has been discussed on oak-dev. I was not trying to ignore or circumvent any pre

Re: OAK-6575 - A word of caution

2017-09-04 Thread Tommaso Teofili
I share Francesco's concerns, the same way I shared them when we first discussed this way back; I tried to express my doubts on the current proposal in the email thread for OAK-6575 (linked also in Francesco's email), which got ignored; that's fine as long as the majority of us is happy with the cu

Re: OAK-6575 - A word of caution

2017-09-04 Thread Francesco Mari
On Mon, Sep 4, 2017 at 2:13 PM, Chetan Mehrotra wrote: > Adaptable pattern in itself was not much discussed at that time. Concerns about the adaptable pattern and its implications in data encapsulation were expressed in the old thread at [1], [2], [3], [4], and in other messages in the same threa

Re: OAK-6575 - A word of caution

2017-09-04 Thread Chetan Mehrotra
> Why couldn't we discuss this implementation in the light of the OAK-1963? > Why the old concerns are not taken in to consideration once again? We already > talked about all that. I closed OAK-1963 because it was specially related to exposing the File instance url while objective of OAK-6575 is

OAK-6575 - A word of caution

2017-09-04 Thread Francesco Mari
The POC for OAK-6575 aims at introducing the AdapterManager and AdapterFactory API in Oak. This is just a step away from introducing a full-fledged implementation of Sling-like adapters in Oak. In fact, the OakConversionService is just an Adapter for a single, very specific conversion. We had a ve

[ANNOUNCE] Apache Jackrabbit Oak 1.4.18 released

2017-09-04 Thread Davide Giannella
The Apache Jackrabbit community is pleased to announce the release of Apache Jackrabbit Oak. The release is available for download at: http://jackrabbit.apache.org/downloads.html See the full release notes below for details about this release: Release Notes -- Apache Jackrabbit Oak -- Versi

[RESULT][VOTE] Release Apache Jackrabbit Oak 1.4.18

2017-09-04 Thread Davide Giannella
Hello Team, the vote passes as follows: +1 Amit Jain +1 Robert Munteanu +1 Davide Giannella +1 Julian Reschke +1 Andrei Dulceanu Thanks for voting. I'll push the release out. -- Davide

Re: svn commit: r1807198 - /jackrabbit/oak/trunk/oak-upgrade/src/main/java/org/apache/jackrabbit/oak/upgrade/cli/blob/S3DataStoreFactory.java

2017-09-04 Thread Amit Jain
Hi Tomek, You missed the actual store.close(). Thanks Amit On Mon, Sep 4, 2017 at 2:26 PM, wrote: > Author: tomekr > Date: Mon Sep 4 08:56:45 2017 > New Revision: 1807198 > > URL: http://svn.apache.org/viewvc?rev=1807198&view=rev > Log: > OAK-6611: Many S3DataStore errors during migration wit